Review Request 115440: Rename KDE4_SERIALIZE_TOOL to KDOCTOOLS_SERIALIZE_TOOL And Add Setter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115440/ --- Review request for KDE Frameworks and Luigi Toscano. Repository:

Review Request 115442: Change NET* classes and KWindoInfo/KWindowSystem to use declared flag types

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115442/ --- Review request for KDE Frameworks. Repository: kwindowsystem

Re: Review Request 115442: Change NET* classes and KWindoInfo/KWindowSystem to use declared flag types

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115442/#review48791 --- src/netwm.h

kf5 alpha 1 : modules, versions

Any new module that should be added to this release, compared to TP1? Should I include attica? Any version number that should be upgraded in the modules themselves? I realize now that it's all called 5.0.0 everywhere already. The packages are properly numbered, but not the cmake variable

Re: kf5 alpha 1 : modules, versions

On Monday 03 February 2014 10:17:49 David Faure wrote: Any new module that should be added to this release, compared to TP1? Should I include attica? Since this question keeps popping up, let's integrate it. It should also be added to the list: http://community.kde.org/Frameworks/List Also,

Re: Review Request 115336: Change syntax of kservice_desktop_to_json

On Jan. 31, 2014, 8:15 p.m., Alex Merry wrote: There was an optional jsonfile argument; I guess you checked nothing was using it? Because anything that was will be broken by this. That said, I have no objection to breaking source compatibility of something that hasn't even been

Re: Review Request 115421: Clean up the CMakeLists.txt files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115421/#review48815 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 1, 2014,

Re: Review Request 115421: Clean up the CMakeLists.txt files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115421/ --- (Updated Feb. 3, 2014, 12:26 p.m.) Status -- This change has been

Re: Review Request 115421: Clean up the CMakeLists.txt files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115421/#review48817 --- This review has been submitted with commit

Re: Review Request 115442: Change NET* classes and KWindoInfo/KWindowSystem to use declared flag types

On Feb. 3, 2014, 9:36 a.m., Martin Gräßlin wrote: src/netwm.h, lines 1426-1430 https://git.reviewboard.kde.org/r/115442/diff/1/?file=241482#file241482line1426 This method should also get adjusted but as it's virtual it will be a true API break. What's the best way?

Re: Review Request 115336: Change syntax of kservice_desktop_to_json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115336/ --- (Updated Feb. 3, 2014, 12:29 p.m.) Status -- This change has been

Re: Review Request 115336: Change syntax of kservice_desktop_to_json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115336/#review48819 --- This review has been submitted with commit

Re: Review Request 115434: Deprecate KWindowSystem::windowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115434/#review48820 --- Ship it! Ship It! - Aurélien Gâteau On Feb. 2, 2014,

Re: Review Request 115430: Add simple autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115430/#review48821 --- autotests/readtest.cpp

Re: Review Request 115418: Hide private methods of KCompletion into d-pointer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115418/#review48822 --- Ship it! There is a small conflict with KCompletionPrivate

Re: Review Request 115430: Add simple autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115430/ --- (Updated Feb. 3, 2014, 1:12 p.m.) Review request for KDE Frameworks and

Re: Review Request 115430: Add simple autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115430/#review48829 --- Ship it! Can't really test it locally since I can't find a

Re: Review Request 115440: Rename KDE4_SERIALIZE_TOOL to KDOCTOOLS_SERIALIZE_TOOL And Add Setter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115440/#review48830 --- Ship it! If it is worth to move it to another, more generic

Re: Review Request 115430: Add simple autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115430/ --- (Updated Feb. 3, 2014, 3:03 p.m.) Status -- This change has been

Jenkins build became unstable: kimageformats_master_qt5 #18

See http://build.kde.org/job/kimageformats_master_qt5/18/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395/#review48846 --- Please see the big comment below the elseif line, the link to

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

On Feb. 3, 2014, 6:07 p.m., Raphael Kubo da Costa wrote: Please see the big comment below the elseif line, the link to the kde-core-devel and http://lists.kde.org/?l=kde-core-develm=138244424421211w=2: the issue here is that if you pass -fno-exceptions to clang you need to guarantee

Re: Review Request 115345: Fix kimageformats build with MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115345/ --- (Updated Feb. 3, 2014, 6:24 p.m.) Status -- This change has been

Re: Review Request 115345: Fix kimageformats build with MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115345/#review48848 --- This review has been submitted with commit

Re: Review Request 115345: Fix kimageformats build with MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115345/#review48849 --- This review has been submitted with commit

Re: Review Request 115345: Fix kimageformats build with MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115345/ --- (Updated Feb. 3, 2014, 6:24 p.m.) Status -- This change has been

Jenkins build is back to stable : kimageformats_master_qt5 #21

See http://build.kde.org/job/kimageformats_master_qt5/21/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115203: Allow compiling with MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115203/ --- (Updated Feb. 3, 2014, 7:43 p.m.) Review request for KDE Frameworks.

Review Request 115450: Fix build without KWINDOWSYSTEM_HAVE_X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115450/ --- Review request for KDE Frameworks. Repository: kwindowsystem

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

On Feb. 3, 2014, 7:07 p.m., Raphael Kubo da Costa wrote: Please see the big comment below the elseif line, the link to the kde-core-devel and http://lists.kde.org/?l=kde-core-develm=138244424421211w=2: the issue here is that if you pass -fno-exceptions to clang you need to guarantee

Re: Review Request 115344: With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115344/#review48852 --- This review has been submitted with commit

Re: Review Request 115344: With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115344/ --- (Updated Feb. 3, 2014, 7:46 p.m.) Status -- This change has been

Re: Review Request 115450: Fix build without KWINDOWSYSTEM_HAVE_X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115450/#review48854 --- src/kstartupinfo.cpp

Re: Review Request 115450: Fix build without KWINDOWSYSTEM_HAVE_X11

On Feb. 3, 2014, 9:07 p.m., Martin Gräßlin wrote: src/kstartupinfo.cpp, lines 1250-1254 https://git.reviewboard.kde.org/r/115450/diff/1/?file=241654#file241654line1250 why is this introduced again? NET::OnAllDesktops does not exist if KWINDOWSYSTEM_HAVE_X11 is false. I don't know

Re: Review Request 115450: Fix build without KWINDOWSYSTEM_HAVE_X11

On Feb. 3, 2014, 9:07 p.m., Martin Gräßlin wrote: src/kstartupinfo.cpp, lines 1250-1254 https://git.reviewboard.kde.org/r/115450/diff/1/?file=241654#file241654line1250 why is this introduced again? Alexander Richardson wrote: NET::OnAllDesktops does not exist if

Re: Review Request 115450: Fix build without KWINDOWSYSTEM_HAVE_X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115450/ --- (Updated Feb. 3, 2014, 9:24 p.m.) Status -- This change has been

Re: Review Request 115450: Fix build without KWINDOWSYSTEM_HAVE_X11

On Feb. 3, 2014, 9:07 p.m., Martin Gräßlin wrote: src/kstartupinfo.cpp, lines 1250-1254 https://git.reviewboard.kde.org/r/115450/diff/1/?file=241654#file241654line1250 why is this introduced again? Alexander Richardson wrote: NET::OnAllDesktops does not exist if

Re: Review Request 115203: Allow compiling with MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115203/#review48872 --- This review has been submitted with commit

Re: Review Request 115203: Allow compiling with MSVC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115203/ --- (Updated Feb. 3, 2014, 10:25 p.m.) Status -- This change has been

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

On Feb. 3, 2014, 8:07 p.m., Raphael Kubo da Costa wrote: Please see the big comment below the elseif line, the link to the kde-core-devel and http://lists.kde.org/?l=kde-core-develm=138244424421211w=2: the issue here is that if you pass -fno-exceptions to clang you need to guarantee

Re: Review Request 115343: Fix msvc build of solid

On Jan. 31, 2014, 7:41 p.m., Alex Merry wrote: src/solid/networking_win.cpp, lines 116-117 https://git.reviewboard.kde.org/r/115343/diff/1/?file=240767#file240767line116 It's odd that this should be needed. Do you have any way of getting verbose output?

Review Request 115456: Fix MSVC libc linkage for debug builds

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115456/ --- Review request for Build System, Extra Cmake Modules, KDE Frameworks, and

Re: Review Request 115343: Fix msvc build of solid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115343/ --- (Updated Feb. 4, 2014, 1:04 a.m.) Review request for KDE Frameworks.

Review Request 115457: Allow compiling KJS on windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115457/ --- Review request for KDE Frameworks and kdewin. Repository: kjs

Re: Review Request 115418: Hide private methods of KCompletion into d-pointer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115418/ --- (Updated Feb. 4, 2014, 12:30 a.m.) Status -- This change has been

Re: Review Request 115418: Hide private methods of KCompletion into d-pointer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115418/#review48879 --- This review has been submitted with commit

Re: Review Request 115419: Split KCompletionMatches class into files of its own

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115419/ --- (Updated Feb. 4, 2014, 12:36 a.m.) Review request for KDE Frameworks.

Re: Review Request 115378: Resolve some FIXMEs related to MSVC and Intel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115378/#review48880 --- kde-modules/KDECompilerSettings.cmake

Review Request 115458: Include netwm_def.h in kstartupinfo.cpp

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115458/ --- Review request for KDE Frameworks and Alexander Richardson. Repository:

Re: Review Request 115450: Fix build without KWINDOWSYSTEM_HAVE_X11

On Feb. 3, 2014, 9:07 p.m., Martin Gräßlin wrote: src/kstartupinfo.cpp, lines 1250-1254 https://git.reviewboard.kde.org/r/115450/diff/1/?file=241654#file241654line1250 why is this introduced again? Alexander Richardson wrote: NET::OnAllDesktops does not exist if

Re: Review Request 115434: Deprecate KWindowSystem::windowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115434/#review48885 --- This review has been submitted with commit

Re: Review Request 115442: Change NET* classes and KWindoInfo/KWindowSystem to use declared flag types

On Feb. 3, 2014, 9:36 a.m., Martin Gräßlin wrote: src/netwm.h, lines 1426-1430 https://git.reviewboard.kde.org/r/115442/diff/1/?file=241482#file241482line1426 This method should also get adjusted but as it's virtual it will be a true API break. What's the best way?

Re: Review Request 115442: Change NET* classes and KWindoInfo/KWindowSystem to use declared flag types

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115442/ --- (Updated Feb. 4, 2014, 7:52 a.m.) Review request for KDE Frameworks.