Re: Review Request 116952: Make sure non-prefixed desktop files win when looking up by name
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/#review53782 --- Ship it! Another reason to get rid of prefixes indeed. - David Faure On March 21, 2014, 3:41 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/ --- (Updated March 21, 2014, 3:41 p.m.) Review request for KDE Frameworks and David Faure. Repository: kservice Description --- Make sure non-prefixed desktop files win when looking up by name The existing code resolved all the overrides (based on storage id), then if there were multiple desktop files with the same id (say konsole.desktop and kde4/konsole.desktop), it would arbitrarily (due to the use of QHash) pick one of them to return from KService::serviceByDesktopName(), regardless of where in XDG_DATA_DIRS it was found. So you might get serviceByDesktopName(konsole) giving you kde4/konsole.desktop and serviceByDesktopName(amarok) giving you amarok.desktop (even if kde4/amarok.desktop also exists). This change makes desktop files without a prefix (like konsole.desktop) override ones with a prefix (like kde4/konsole.desktop). If you also have kde5/konsole.desktop, the ordering between that and kde4/konsole.desktop is still arbitrary, and the order of XDG_DATA_DIRS is ignored. Remove the prefix hacks from KService::serviceByDesktopName() These didn't work; the desktop file kde4/konsole.desktop will only be listed under the desktop name konsole, not under the name kde4-konsole. Add a test app for the KService::serviceBy* methods Diffs - src/kbuildsycoca/kbuildservicefactory.cpp 4dbb44b7db1a8bc4182899485db9c45c063c9b52 src/services/kservice.cpp 192682b514a69c41fb84231f3b04ec6e9218d587 tests/CMakeLists.txt 47894e5a6175dac924c2e700b2dafe936590cc1b tests/findservice.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116952/diff/ Testing --- Tested using the new test app. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116938: Remove defunct plugin-loading code, and deprecate KLibrary
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116938/#review53784 --- Ship it! Very nice. src/plugin/kpluginloader.h https://git.reviewboard.kde.org/r/116938/#comment37719 Missing @since 5.0 - David Faure On March 21, 2014, 3:50 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116938/ --- (Updated March 21, 2014, 3:50 p.m.) Review request for KDE Frameworks and David Faure. Repository: kservice Description --- Remove defunct plugin-loading code, and deprecate KLibrary KLibrary::factory() tried to load kde3-style plugins (not unreasonable to drop support for) and kdelibs4-style plugins (which do not work, since they depended on Qt support). It now does nothing. This and the KPluginFactory::findPlugin() method leave KLibrary with no purpose, so deprecate it. Improve the KPluginLoader documentation Give KPluginLoader a public static findPlugin method I noticed that several bits of code used KLibrary or KPluginLoader to find a plugin, then proceeded to just use QLibrary to resolve functions from it. This method allows that to be done without actually creating a KPluginLoader instance that is then only used for its fileName() method. Diffs - src/plugin/kpluginloader.h 8621914890bf704213d33108d01032a7b36b3484 src/plugin/kpluginloader.cpp 53d6bc2aa8d8f91f296943ad8831ff6aaab6b3e6 src/plugin/klibrary.h 78f0701e01b0a24e8895127640ce575e09d93d7c src/plugin/klibrary.cpp c77ec32dbb1cbd1ccd6342a082012d2c82575fb8 Diff: https://git.reviewboard.kde.org/r/116938/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116980: Update the kded5 man page
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/#review53796 --- docs/kded5/man-kded5.8.docbook https://git.reviewboard.kde.org/r/116980/#comment37729 All other docbook man pages in frameworks have kde; User's Manual here, why this change? docs/kded5/man-kded5.8.docbook https://git.reviewboard.kde.org/r/116980/#comment37728 Are you sure filename~/.config/kdedrc/filename is correct? Shouldn't kdedrc be in kf5-config --path config? But here it is in: /home/kdeframeworks/.kde/share/config/kdedrc docs/kded5/man-kded5.8.docbook https://git.reviewboard.kde.org/r/116980/#comment37724 grep CheckStamps frameworks/kded - no hit $ wcgrep CheckFileStamps frameworks/kded/ frameworks/kded/README.md:62:CheckFileStamps=true frameworks/kded/src/kded.cpp:749:checkStamps = cg.readEntry(CheckFileStamps, true); frameworks/kded/src/kded.cpp:765:checkStamps = cg.readEntry(CheckFileStamps, true); Should be changed to CheckFileStamps - Burkhard Lück On March 22, 2014, 5:53 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/ --- (Updated March 22, 2014, 5:53 p.m.) Review request for Documentation and KDE Frameworks. Repository: kded Description --- Update the kded5 man page Diffs - docs/kded5/man-kded5.8.docbook 4fca21f00c43be7842f07470b3d52d6607a40c32 Diff: https://git.reviewboard.kde.org/r/116980/diff/ Testing --- Built, installed, visually inspected man page. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116952: Make sure non-prefixed desktop files win when looking up by name
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/ --- (Updated March 23, 2014, 12:20 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Repository: kservice Description --- Make sure non-prefixed desktop files win when looking up by name The existing code resolved all the overrides (based on storage id), then if there were multiple desktop files with the same id (say konsole.desktop and kde4/konsole.desktop), it would arbitrarily (due to the use of QHash) pick one of them to return from KService::serviceByDesktopName(), regardless of where in XDG_DATA_DIRS it was found. So you might get serviceByDesktopName(konsole) giving you kde4/konsole.desktop and serviceByDesktopName(amarok) giving you amarok.desktop (even if kde4/amarok.desktop also exists). This change makes desktop files without a prefix (like konsole.desktop) override ones with a prefix (like kde4/konsole.desktop). If you also have kde5/konsole.desktop, the ordering between that and kde4/konsole.desktop is still arbitrary, and the order of XDG_DATA_DIRS is ignored. Remove the prefix hacks from KService::serviceByDesktopName() These didn't work; the desktop file kde4/konsole.desktop will only be listed under the desktop name konsole, not under the name kde4-konsole. Add a test app for the KService::serviceBy* methods Diffs - src/kbuildsycoca/kbuildservicefactory.cpp 4dbb44b7db1a8bc4182899485db9c45c063c9b52 src/services/kservice.cpp 192682b514a69c41fb84231f3b04ec6e9218d587 tests/CMakeLists.txt 47894e5a6175dac924c2e700b2dafe936590cc1b tests/findservice.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116952/diff/ Testing --- Tested using the new test app. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116952: Make sure non-prefixed desktop files win when looking up by name
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/#review53802 --- This review has been submitted with commit b603f91a57bfde646fd57df79704a3e32f337f7c by Alex Merry to branch master. - Commit Hook On March 21, 2014, 3:41 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/ --- (Updated March 21, 2014, 3:41 p.m.) Review request for KDE Frameworks and David Faure. Repository: kservice Description --- Make sure non-prefixed desktop files win when looking up by name The existing code resolved all the overrides (based on storage id), then if there were multiple desktop files with the same id (say konsole.desktop and kde4/konsole.desktop), it would arbitrarily (due to the use of QHash) pick one of them to return from KService::serviceByDesktopName(), regardless of where in XDG_DATA_DIRS it was found. So you might get serviceByDesktopName(konsole) giving you kde4/konsole.desktop and serviceByDesktopName(amarok) giving you amarok.desktop (even if kde4/amarok.desktop also exists). This change makes desktop files without a prefix (like konsole.desktop) override ones with a prefix (like kde4/konsole.desktop). If you also have kde5/konsole.desktop, the ordering between that and kde4/konsole.desktop is still arbitrary, and the order of XDG_DATA_DIRS is ignored. Remove the prefix hacks from KService::serviceByDesktopName() These didn't work; the desktop file kde4/konsole.desktop will only be listed under the desktop name konsole, not under the name kde4-konsole. Add a test app for the KService::serviceBy* methods Diffs - src/kbuildsycoca/kbuildservicefactory.cpp 4dbb44b7db1a8bc4182899485db9c45c063c9b52 src/services/kservice.cpp 192682b514a69c41fb84231f3b04ec6e9218d587 tests/CMakeLists.txt 47894e5a6175dac924c2e700b2dafe936590cc1b tests/findservice.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116952/diff/ Testing --- Tested using the new test app. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116952: Make sure non-prefixed desktop files win when looking up by name
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/#review53800 --- This review has been submitted with commit 1993b3e7e22d4291df5fd7fb295aa14ff4cf756c by Alex Merry to branch master. - Commit Hook On March 21, 2014, 3:41 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/ --- (Updated March 21, 2014, 3:41 p.m.) Review request for KDE Frameworks and David Faure. Repository: kservice Description --- Make sure non-prefixed desktop files win when looking up by name The existing code resolved all the overrides (based on storage id), then if there were multiple desktop files with the same id (say konsole.desktop and kde4/konsole.desktop), it would arbitrarily (due to the use of QHash) pick one of them to return from KService::serviceByDesktopName(), regardless of where in XDG_DATA_DIRS it was found. So you might get serviceByDesktopName(konsole) giving you kde4/konsole.desktop and serviceByDesktopName(amarok) giving you amarok.desktop (even if kde4/amarok.desktop also exists). This change makes desktop files without a prefix (like konsole.desktop) override ones with a prefix (like kde4/konsole.desktop). If you also have kde5/konsole.desktop, the ordering between that and kde4/konsole.desktop is still arbitrary, and the order of XDG_DATA_DIRS is ignored. Remove the prefix hacks from KService::serviceByDesktopName() These didn't work; the desktop file kde4/konsole.desktop will only be listed under the desktop name konsole, not under the name kde4-konsole. Add a test app for the KService::serviceBy* methods Diffs - src/kbuildsycoca/kbuildservicefactory.cpp 4dbb44b7db1a8bc4182899485db9c45c063c9b52 src/services/kservice.cpp 192682b514a69c41fb84231f3b04ec6e9218d587 tests/CMakeLists.txt 47894e5a6175dac924c2e700b2dafe936590cc1b tests/findservice.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116952/diff/ Testing --- Tested using the new test app. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116952: Make sure non-prefixed desktop files win when looking up by name
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/#review53801 --- This review has been submitted with commit dc618b27253f5f2948ced24d6038108060fd7360 by Alex Merry to branch master. - Commit Hook On March 21, 2014, 3:41 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/ --- (Updated March 21, 2014, 3:41 p.m.) Review request for KDE Frameworks and David Faure. Repository: kservice Description --- Make sure non-prefixed desktop files win when looking up by name The existing code resolved all the overrides (based on storage id), then if there were multiple desktop files with the same id (say konsole.desktop and kde4/konsole.desktop), it would arbitrarily (due to the use of QHash) pick one of them to return from KService::serviceByDesktopName(), regardless of where in XDG_DATA_DIRS it was found. So you might get serviceByDesktopName(konsole) giving you kde4/konsole.desktop and serviceByDesktopName(amarok) giving you amarok.desktop (even if kde4/amarok.desktop also exists). This change makes desktop files without a prefix (like konsole.desktop) override ones with a prefix (like kde4/konsole.desktop). If you also have kde5/konsole.desktop, the ordering between that and kde4/konsole.desktop is still arbitrary, and the order of XDG_DATA_DIRS is ignored. Remove the prefix hacks from KService::serviceByDesktopName() These didn't work; the desktop file kde4/konsole.desktop will only be listed under the desktop name konsole, not under the name kde4-konsole. Add a test app for the KService::serviceBy* methods Diffs - src/kbuildsycoca/kbuildservicefactory.cpp 4dbb44b7db1a8bc4182899485db9c45c063c9b52 src/services/kservice.cpp 192682b514a69c41fb84231f3b04ec6e9218d587 tests/CMakeLists.txt 47894e5a6175dac924c2e700b2dafe936590cc1b tests/findservice.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116952/diff/ Testing --- Tested using the new test app. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116938: Remove defunct plugin-loading code, and deprecate KLibrary
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116938/#review53805 --- This review has been submitted with commit b779f3478b02fc60b3005ad00a7859519d70d9dc by Alex Merry to branch master. - Commit Hook On March 21, 2014, 3:50 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116938/ --- (Updated March 21, 2014, 3:50 p.m.) Review request for KDE Frameworks and David Faure. Repository: kservice Description --- Remove defunct plugin-loading code, and deprecate KLibrary KLibrary::factory() tried to load kde3-style plugins (not unreasonable to drop support for) and kdelibs4-style plugins (which do not work, since they depended on Qt support). It now does nothing. This and the KPluginFactory::findPlugin() method leave KLibrary with no purpose, so deprecate it. Improve the KPluginLoader documentation Give KPluginLoader a public static findPlugin method I noticed that several bits of code used KLibrary or KPluginLoader to find a plugin, then proceeded to just use QLibrary to resolve functions from it. This method allows that to be done without actually creating a KPluginLoader instance that is then only used for its fileName() method. Diffs - src/plugin/kpluginloader.h 8621914890bf704213d33108d01032a7b36b3484 src/plugin/kpluginloader.cpp 53d6bc2aa8d8f91f296943ad8831ff6aaab6b3e6 src/plugin/klibrary.h 78f0701e01b0a24e8895127640ce575e09d93d7c src/plugin/klibrary.cpp c77ec32dbb1cbd1ccd6342a082012d2c82575fb8 Diff: https://git.reviewboard.kde.org/r/116938/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116938: Remove defunct plugin-loading code, and deprecate KLibrary
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116938/#review53803 --- This review has been submitted with commit 886298e6b25152268754179cba9f8d52924da623 by Alex Merry to branch master. - Commit Hook On March 21, 2014, 3:50 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116938/ --- (Updated March 21, 2014, 3:50 p.m.) Review request for KDE Frameworks and David Faure. Repository: kservice Description --- Remove defunct plugin-loading code, and deprecate KLibrary KLibrary::factory() tried to load kde3-style plugins (not unreasonable to drop support for) and kdelibs4-style plugins (which do not work, since they depended on Qt support). It now does nothing. This and the KPluginFactory::findPlugin() method leave KLibrary with no purpose, so deprecate it. Improve the KPluginLoader documentation Give KPluginLoader a public static findPlugin method I noticed that several bits of code used KLibrary or KPluginLoader to find a plugin, then proceeded to just use QLibrary to resolve functions from it. This method allows that to be done without actually creating a KPluginLoader instance that is then only used for its fileName() method. Diffs - src/plugin/kpluginloader.h 8621914890bf704213d33108d01032a7b36b3484 src/plugin/kpluginloader.cpp 53d6bc2aa8d8f91f296943ad8831ff6aaab6b3e6 src/plugin/klibrary.h 78f0701e01b0a24e8895127640ce575e09d93d7c src/plugin/klibrary.cpp c77ec32dbb1cbd1ccd6342a082012d2c82575fb8 Diff: https://git.reviewboard.kde.org/r/116938/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116938: Remove defunct plugin-loading code, and deprecate KLibrary
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116938/#review53804 --- This review has been submitted with commit 4a3a5699f4d5b81bc59cb9de403f5d292a08f561 by Alex Merry to branch master. - Commit Hook On March 21, 2014, 3:50 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116938/ --- (Updated March 21, 2014, 3:50 p.m.) Review request for KDE Frameworks and David Faure. Repository: kservice Description --- Remove defunct plugin-loading code, and deprecate KLibrary KLibrary::factory() tried to load kde3-style plugins (not unreasonable to drop support for) and kdelibs4-style plugins (which do not work, since they depended on Qt support). It now does nothing. This and the KPluginFactory::findPlugin() method leave KLibrary with no purpose, so deprecate it. Improve the KPluginLoader documentation Give KPluginLoader a public static findPlugin method I noticed that several bits of code used KLibrary or KPluginLoader to find a plugin, then proceeded to just use QLibrary to resolve functions from it. This method allows that to be done without actually creating a KPluginLoader instance that is then only used for its fileName() method. Diffs - src/plugin/kpluginloader.h 8621914890bf704213d33108d01032a7b36b3484 src/plugin/kpluginloader.cpp 53d6bc2aa8d8f91f296943ad8831ff6aaab6b3e6 src/plugin/klibrary.h 78f0701e01b0a24e8895127640ce575e09d93d7c src/plugin/klibrary.cpp c77ec32dbb1cbd1ccd6342a082012d2c82575fb8 Diff: https://git.reviewboard.kde.org/r/116938/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116938: Remove defunct plugin-loading code, and deprecate KLibrary
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116938/ --- (Updated March 23, 2014, 12:23 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Repository: kservice Description --- Remove defunct plugin-loading code, and deprecate KLibrary KLibrary::factory() tried to load kde3-style plugins (not unreasonable to drop support for) and kdelibs4-style plugins (which do not work, since they depended on Qt support). It now does nothing. This and the KPluginFactory::findPlugin() method leave KLibrary with no purpose, so deprecate it. Improve the KPluginLoader documentation Give KPluginLoader a public static findPlugin method I noticed that several bits of code used KLibrary or KPluginLoader to find a plugin, then proceeded to just use QLibrary to resolve functions from it. This method allows that to be done without actually creating a KPluginLoader instance that is then only used for its fileName() method. Diffs - src/plugin/kpluginloader.h 8621914890bf704213d33108d01032a7b36b3484 src/plugin/kpluginloader.cpp 53d6bc2aa8d8f91f296943ad8831ff6aaab6b3e6 src/plugin/klibrary.h 78f0701e01b0a24e8895127640ce575e09d93d7c src/plugin/klibrary.cpp c77ec32dbb1cbd1ccd6342a082012d2c82575fb8 Diff: https://git.reviewboard.kde.org/r/116938/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116980: Update the kded5 man page
On March 23, 2014, 12:15 p.m., Burkhard Lück wrote: docs/kded5/man-kded5.8.docbook, line 9 https://git.reviewboard.kde.org/r/116980/diff/1/?file=256194#file256194line9 All other docbook man pages in frameworks have kde; User's Manual here, why this change? To reflect the branding shift away from KDE as a product. The standard in other man pages appears to be to put the product there, which in this case is the KDED framework. On March 23, 2014, 12:15 p.m., Burkhard Lück wrote: docs/kded5/man-kded5.8.docbook, line 246 https://git.reviewboard.kde.org/r/116980/diff/1/?file=256194#file256194line246 Are you sure filename~/.config/kdedrc/filename is correct? Shouldn't kdedrc be in kf5-config --path config? But here it is in: /home/kdeframeworks/.kde/share/config/kdedrc kf5-config is deprecated, and only available if kde4support is installed. Possibly it should refer to XDG_CONFIG_HOME, since that is the variable that actually determines where it is installed on a Unix system. The path given is the default if that does not exist. Unless the distro has been hacking with the paths (in Qt or KConfig, I guess), of course, in which case they should also change the man page. (Also, are you sure that's where kded5 looks, rather than where kded4 looks? kded5 does not create the file if it does not exist). On March 23, 2014, 12:15 p.m., Burkhard Lück wrote: docs/kded5/man-kded5.8.docbook, line 263 https://git.reviewboard.kde.org/r/116980/diff/1/?file=256194#file256194line263 grep CheckStamps frameworks/kded - no hit $ wcgrep CheckFileStamps frameworks/kded/ frameworks/kded/README.md:62:CheckFileStamps=true frameworks/kded/src/kded.cpp:749:checkStamps = cg.readEntry(CheckFileStamps, true); frameworks/kded/src/kded.cpp:765:checkStamps = cg.readEntry(CheckFileStamps, true); Should be changed to CheckFileStamps Oops. Good spot. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/#review53796 --- On March 22, 2014, 5:53 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/ --- (Updated March 22, 2014, 5:53 p.m.) Review request for Documentation and KDE Frameworks. Repository: kded Description --- Update the kded5 man page Diffs - docs/kded5/man-kded5.8.docbook 4fca21f00c43be7842f07470b3d52d6607a40c32 Diff: https://git.reviewboard.kde.org/r/116980/diff/ Testing --- Built, installed, visually inspected man page. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116980: Update the kded5 man page
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/ --- (Updated March 23, 2014, 1:02 p.m.) Review request for KDE Frameworks. Changes --- - separate out configuration stuff into its own section - note that kdedrc is looked for under $XDG_CONFIG_HOME - fix CheckFileStamps configuration option name - fix markup for see also section Repository: kded Description --- Update the kded5 man page Diffs (updated) - docs/kded5/man-kded5.8.docbook 4fca21f00c43be7842f07470b3d52d6607a40c32 Diff: https://git.reviewboard.kde.org/r/116980/diff/ Testing --- Built, installed, visually inspected man page. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116991: kded: Use a consistent configuration file name
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116991/ --- Review request for KDE Frameworks and David Faure. Repository: kded Description --- Use a consistent configuration file name Before, the initial configuration was explicitly drawn from kdedrc, while autoloading stuff was drawn from the application-default file, which was kded5rc. This change makes it always use the application-default file, which involves rearrangeing some of the code to make sure the application instance always has its name set consistently. This also changes the configuration entry reading so that the defaults are set in exactly one place. Diffs - src/kded.cpp b409c69e101ef67558428c4b80f0e075e01599a3 Diff: https://git.reviewboard.kde.org/r/116991/diff/ Testing --- Ran with some debug statements to print the value of CheckFileStamps both with and without --check. Setting the value in ~/.config/kded5rc altered this printout. This is also the file written to and read from for the module auto-loading stuff (checked using kded's D-Bus interface). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116980: Update the kded5 man page
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/ --- (Updated March 23, 2014, 1:37 p.m.) Review request for KDE Frameworks. Changes --- Change the configuration file name (see https://git.reviewboard.kde.org/r/116991/). Also properly markup instances of kded5 as commands, add a note about being able to change the configuration while kded5 is running and add a note about autoloading being configurable via the D-Bus interface. Repository: kded Description --- Update the kded5 man page Diffs (updated) - docs/kded5/man-kded5.8.docbook 4fca21f00c43be7842f07470b3d52d6607a40c32 Diff: https://git.reviewboard.kde.org/r/116980/diff/ Testing --- Built, installed, visually inspected man page. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116984: Fix configuring of kde5init_win32lib_dummy.cpp.in
On March 22, 2014, 10:21 p.m., Nicolás Alvarez wrote: I can't test this because the kservice framework (dep of kinit) doesn't compile on Windows. Yeah... I was operating on the basis of this is probably less broken than before. kwrapper_win.cpp also has some defunct stuff in it, I guess for much the same reason. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116984/#review53773 --- On March 22, 2014, 8:46 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116984/ --- (Updated March 22, 2014, 8:46 p.m.) Review request for KDE Frameworks and Alexander Richardson. Repository: kinit Description --- Fix configuring of kde5init_win32lib_dummy.cpp.in The code referred to a variable that was no longer set, so couldn't possibly produce correct code. This sets the variable again (and renames it). Diffs - KF5InitMacros.cmake dddc230341cfb481955a9308e1b4700aa335f940 kde5init_win32lib_dummy.cpp.in 0c030adb0835a291d98ac91b558a08f50f0d448a Diff: https://git.reviewboard.kde.org/r/116984/diff/ Testing --- Completely untested, as I don't use Windows. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116934: Use KPluginLoader to find kioslaves
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116934/ --- (Updated March 23, 2014, 1:51 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Use KPluginLoader::findPlugin(). Repository: kio Description (updated) --- Use KPluginLoader to find kioslaves KIO slaves are typically installed in PLUGIN_INSTALL_DIR, rather than QT_PLUGIN_INSTALL_DIR, so we should use KPluginLoader instead of QPluginLoader to locate them. Diffs (updated) - src/core/slave.cpp ee84066f96675caaf1fa5ba612c8242eac160c4a src/kioslave/CMakeLists.txt 64bf7e0f36a1a407dd162e2c0461dedb2f57a13e src/kioslave/kioslave.cpp 50413d04be29361638ba581383354d79881e844e Diff: https://git.reviewboard.kde.org/r/116934/diff/ Testing (updated) --- Ran kioslavetest, both with and without KDE_FORK_SLAVES=1 set, and got it to list /tmp. kio_file.so was found each time. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116980: Update the kded5 man page
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/ --- (Updated March 23, 2014, 1:55 p.m.) Review request for Documentation and KDE Frameworks. Changes --- Put docs back in (damn you, RBTools!) Repository: kded Description --- Update the kded5 man page Diffs - docs/kded5/man-kded5.8.docbook 4fca21f00c43be7842f07470b3d52d6607a40c32 Diff: https://git.reviewboard.kde.org/r/116980/diff/ Testing --- Built, installed, visually inspected man page. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116934: Use KPluginLoader to find kioslaves
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116934/#review53811 --- Ship it! Ship It! - David Faure On March 23, 2014, 1:51 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116934/ --- (Updated March 23, 2014, 1:51 p.m.) Review request for KDE Frameworks and David Faure. Repository: kio Description --- Use KPluginLoader to find kioslaves KIO slaves are typically installed in PLUGIN_INSTALL_DIR, rather than QT_PLUGIN_INSTALL_DIR, so we should use KPluginLoader instead of QPluginLoader to locate them. Diffs - src/core/slave.cpp ee84066f96675caaf1fa5ba612c8242eac160c4a src/kioslave/CMakeLists.txt 64bf7e0f36a1a407dd162e2c0461dedb2f57a13e src/kioslave/kioslave.cpp 50413d04be29361638ba581383354d79881e844e Diff: https://git.reviewboard.kde.org/r/116934/diff/ Testing --- Ran kioslavetest, both with and without KDE_FORK_SLAVES=1 set, and got it to list /tmp. kio_file.so was found each time. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116934: Use KPluginLoader to find kioslaves
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116934/ --- (Updated March 23, 2014, 2:11 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Repository: kio Description --- Use KPluginLoader to find kioslaves KIO slaves are typically installed in PLUGIN_INSTALL_DIR, rather than QT_PLUGIN_INSTALL_DIR, so we should use KPluginLoader instead of QPluginLoader to locate them. Diffs - src/core/slave.cpp ee84066f96675caaf1fa5ba612c8242eac160c4a src/kioslave/CMakeLists.txt 64bf7e0f36a1a407dd162e2c0461dedb2f57a13e src/kioslave/kioslave.cpp 50413d04be29361638ba581383354d79881e844e Diff: https://git.reviewboard.kde.org/r/116934/diff/ Testing --- Ran kioslavetest, both with and without KDE_FORK_SLAVES=1 set, and got it to list /tmp. kio_file.so was found each time. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116934: Use KPluginLoader to find kioslaves
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116934/#review53812 --- This review has been submitted with commit a2cd603db5191c49df18488d68dd891b901b63af by Alex Merry to branch master. - Commit Hook On March 23, 2014, 1:51 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116934/ --- (Updated March 23, 2014, 1:51 p.m.) Review request for KDE Frameworks and David Faure. Repository: kio Description --- Use KPluginLoader to find kioslaves KIO slaves are typically installed in PLUGIN_INSTALL_DIR, rather than QT_PLUGIN_INSTALL_DIR, so we should use KPluginLoader instead of QPluginLoader to locate them. Diffs - src/core/slave.cpp ee84066f96675caaf1fa5ba612c8242eac160c4a src/kioslave/CMakeLists.txt 64bf7e0f36a1a407dd162e2c0461dedb2f57a13e src/kioslave/kioslave.cpp 50413d04be29361638ba581383354d79881e844e Diff: https://git.reviewboard.kde.org/r/116934/diff/ Testing --- Ran kioslavetest, both with and without KDE_FORK_SLAVES=1 set, and got it to list /tmp. kio_file.so was found each time. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116993: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116993/ --- Review request for KDE Frameworks. Repository: kcmutils Description --- Use KPluginLoader::findPlugin and QLibrary instead of KLibrary Diffs - src/kcmoduleloader.cpp 31ad1aa95dd664f5d65ab81edeb3274b3c5d73e1 Diff: https://git.reviewboard.kde.org/r/116993/diff/ Testing --- `kcmshell5 kcm_phonon` Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116873: Replace GPL proctitle code with BSD-licensed code from OpenSSH
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116873/#review53813 --- Ship it! Ship It! - David Faure On March 21, 2014, 3:47 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116873/ --- (Updated March 21, 2014, 3:47 p.m.) Review request for KDE Frameworks and David Faure. Repository: kinit Description --- Replace GPL proctitle code with BSD-licensed code from OpenSSH This also alters the calling sites so that we don't get kdeinit5 appearing multiple times in the process title. Diffs - src/kdeinit/proctitle.cpp a710e87dc12a40e9e679d2004980a86e77f39437 src/kdeinit/proctitle.h d0cadb289f93f15f2d9a885dc05911a49ab09877 src/config-kdeinit.h.cmake 2dd906019e44b0ba585817c87809d3ccff8bdce8 src/kdeinit/kinit.cpp 82d570c4453cf083e525125edd448b97d8d11bd3 ConfigureChecks.cmake c53e1defccaf0bcab33afde4342f2f9defb91335 Diff: https://git.reviewboard.kde.org/r/116873/diff/ Testing --- Tested on Linux only. I put a 20-second sleep in before the exec call, so that I could see the process title of the fork. Tested as-is, and with the prctl() call commented out. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116994: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116994/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Use KPluginLoader::findPlugin and QLibrary instead of KLibrary Diffs - src/utils/templateinterface.cpp 241f1a36c5d0c3b6b3cccb914513b28d7c60898a Diff: https://git.reviewboard.kde.org/r/116994/diff/ Testing --- Builds, installs. Cannot test the loading due to a lack of ported pimlibs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116991: kded: Use a consistent configuration file name
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116991/#review53814 --- Ship it! src/kded.cpp https://git.reviewboard.kde.org/r/116991/#comment37736 To be honest I don't like this very much, the variable bCheckSycoca suddenly changes meaning, from being the default value to being the actual value. I would have rather removed the file-global default values. This only creates one issue for checkStamps, but that can be solved with bool s_checkStampsDefault = true. But anyway, no big deal. - David Faure On March 23, 2014, 1:29 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116991/ --- (Updated March 23, 2014, 1:29 p.m.) Review request for KDE Frameworks and David Faure. Repository: kded Description --- Use a consistent configuration file name Before, the initial configuration was explicitly drawn from kdedrc, while autoloading stuff was drawn from the application-default file, which was kded5rc. This change makes it always use the application-default file, which involves rearrangeing some of the code to make sure the application instance always has its name set consistently. This also changes the configuration entry reading so that the defaults are set in exactly one place. Diffs - src/kded.cpp b409c69e101ef67558428c4b80f0e075e01599a3 Diff: https://git.reviewboard.kde.org/r/116991/diff/ Testing --- Ran with some debug statements to print the value of CheckFileStamps both with and without --check. Setting the value in ~/.config/kded5rc altered this printout. This is also the file written to and read from for the module auto-loading stuff (checked using kded's D-Bus interface). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116994: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116994/#review53815 --- Ship it! Ship It! - Christoph Cullmann On March 23, 2014, 2:25 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116994/ --- (Updated March 23, 2014, 2:25 p.m.) Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Use KPluginLoader::findPlugin and QLibrary instead of KLibrary Diffs - src/utils/templateinterface.cpp 241f1a36c5d0c3b6b3cccb914513b28d7c60898a Diff: https://git.reviewboard.kde.org/r/116994/diff/ Testing --- Builds, installs. Cannot test the loading due to a lack of ported pimlibs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116873: Replace GPL proctitle code with BSD-licensed code from OpenSSH
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116873/ --- (Updated March 23, 2014, 2:46 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Repository: kinit Description --- Replace GPL proctitle code with BSD-licensed code from OpenSSH This also alters the calling sites so that we don't get kdeinit5 appearing multiple times in the process title. Diffs - src/kdeinit/proctitle.cpp a710e87dc12a40e9e679d2004980a86e77f39437 src/kdeinit/proctitle.h d0cadb289f93f15f2d9a885dc05911a49ab09877 src/config-kdeinit.h.cmake 2dd906019e44b0ba585817c87809d3ccff8bdce8 src/kdeinit/kinit.cpp 82d570c4453cf083e525125edd448b97d8d11bd3 ConfigureChecks.cmake c53e1defccaf0bcab33afde4342f2f9defb91335 Diff: https://git.reviewboard.kde.org/r/116873/diff/ Testing --- Tested on Linux only. I put a 20-second sleep in before the exec call, so that I could see the process title of the fork. Tested as-is, and with the prctl() call commented out. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116873: Replace GPL proctitle code with BSD-licensed code from OpenSSH
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116873/#review53816 --- This review has been submitted with commit 8d13c18a4e4d01bb3982e7f76578b4f62ba867c3 by Alex Merry to branch master. - Commit Hook On March 21, 2014, 3:47 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116873/ --- (Updated March 21, 2014, 3:47 p.m.) Review request for KDE Frameworks and David Faure. Repository: kinit Description --- Replace GPL proctitle code with BSD-licensed code from OpenSSH This also alters the calling sites so that we don't get kdeinit5 appearing multiple times in the process title. Diffs - src/kdeinit/proctitle.cpp a710e87dc12a40e9e679d2004980a86e77f39437 src/kdeinit/proctitle.h d0cadb289f93f15f2d9a885dc05911a49ab09877 src/config-kdeinit.h.cmake 2dd906019e44b0ba585817c87809d3ccff8bdce8 src/kdeinit/kinit.cpp 82d570c4453cf083e525125edd448b97d8d11bd3 ConfigureChecks.cmake c53e1defccaf0bcab33afde4342f2f9defb91335 Diff: https://git.reviewboard.kde.org/r/116873/diff/ Testing --- Tested on Linux only. I put a 20-second sleep in before the exec call, so that I could see the process title of the fork. Tested as-is, and with the prctl() call commented out. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116991: kded: Use a consistent configuration file name
On March 23, 2014, 2:32 p.m., David Faure wrote: src/kded.cpp, line 778 https://git.reviewboard.kde.org/r/116991/diff/1/?file=256350#file256350line778 To be honest I don't like this very much, the variable bCheckSycoca suddenly changes meaning, from being the default value to being the actual value. I would have rather removed the file-global default values. This only creates one issue for checkStamps, but that can be solved with bool s_checkStampsDefault = true. But anyway, no big deal. I committed it with this change. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116991/#review53814 --- On March 23, 2014, 2:50 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116991/ --- (Updated March 23, 2014, 2:50 p.m.) Review request for KDE Frameworks and David Faure. Repository: kded Description --- Use a consistent configuration file name Before, the initial configuration was explicitly drawn from kdedrc, while autoloading stuff was drawn from the application-default file, which was kded5rc. This change makes it always use the application-default file, which involves rearrangeing some of the code to make sure the application instance always has its name set consistently. This also changes the configuration entry reading so that the defaults are set in exactly one place. Diffs - src/kded.cpp b409c69e101ef67558428c4b80f0e075e01599a3 Diff: https://git.reviewboard.kde.org/r/116991/diff/ Testing --- Ran with some debug statements to print the value of CheckFileStamps both with and without --check. Setting the value in ~/.config/kded5rc altered this printout. This is also the file written to and read from for the module auto-loading stuff (checked using kded's D-Bus interface). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116991: kded: Use a consistent configuration file name
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116991/#review53817 --- This review has been submitted with commit 097ec91cbeed7889b20414ee8eb2958699beb870 by Alex Merry to branch master. - Commit Hook On March 23, 2014, 1:29 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116991/ --- (Updated March 23, 2014, 1:29 p.m.) Review request for KDE Frameworks and David Faure. Repository: kded Description --- Use a consistent configuration file name Before, the initial configuration was explicitly drawn from kdedrc, while autoloading stuff was drawn from the application-default file, which was kded5rc. This change makes it always use the application-default file, which involves rearrangeing some of the code to make sure the application instance always has its name set consistently. This also changes the configuration entry reading so that the defaults are set in exactly one place. Diffs - src/kded.cpp b409c69e101ef67558428c4b80f0e075e01599a3 Diff: https://git.reviewboard.kde.org/r/116991/diff/ Testing --- Ran with some debug statements to print the value of CheckFileStamps both with and without --check. Setting the value in ~/.config/kded5rc altered this printout. This is also the file written to and read from for the module auto-loading stuff (checked using kded's D-Bus interface). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116991: kded: Use a consistent configuration file name
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116991/ --- (Updated March 23, 2014, 2:50 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Repository: kded Description --- Use a consistent configuration file name Before, the initial configuration was explicitly drawn from kdedrc, while autoloading stuff was drawn from the application-default file, which was kded5rc. This change makes it always use the application-default file, which involves rearrangeing some of the code to make sure the application instance always has its name set consistently. This also changes the configuration entry reading so that the defaults are set in exactly one place. Diffs - src/kded.cpp b409c69e101ef67558428c4b80f0e075e01599a3 Diff: https://git.reviewboard.kde.org/r/116991/diff/ Testing --- Ran with some debug statements to print the value of CheckFileStamps both with and without --check. Setting the value in ~/.config/kded5rc altered this printout. This is also the file written to and read from for the module auto-loading stuff (checked using kded's D-Bus interface). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116995: Rename the kconfig_compiler_kf5 target to kconfig_compiler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116995/ --- Review request for KDE Frameworks. Repository: kconfig Description --- Rename the kconfig_compiler_kf5 target to kconfig_compiler Just because the executable has the _kf5 suffix, that does not mean the target should have it. This is ugly API, and will be unnecessary porting effort for KF6. Only one place uses this currently - one CMake file in kde4support. I'll change that when committing this. Diffs - CMakeLists.txt 417cd9cb7e0d80abd9100019786e8ea19007e3ef KF5ConfigMacros.cmake aeebee9ea39ab33712131b13ca561136a9bb6309 autotests/kconfig_compiler/CMakeLists.txt 289e9583b64396c5eb080a1bc9cb2833b540ba71 src/kconfig_compiler/CMakeLists.txt 71f2609d870cd00eae3d98c0f3a07504d5973ff0 Diff: https://git.reviewboard.kde.org/r/116995/diff/ Testing --- Builds, installs, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116994: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116994/ --- (Updated March 23, 2014, 2:53 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Use KPluginLoader::findPlugin and QLibrary instead of KLibrary Diffs - src/utils/templateinterface.cpp 241f1a36c5d0c3b6b3cccb914513b28d7c60898a Diff: https://git.reviewboard.kde.org/r/116994/diff/ Testing --- Builds, installs. Cannot test the loading due to a lack of ported pimlibs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116994: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116994/#review53819 --- This review has been submitted with commit 264d930073aa57fb150a9fe5e8680e262fa54cbc by Alex Merry to branch master. - Commit Hook On March 23, 2014, 2:25 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116994/ --- (Updated March 23, 2014, 2:25 p.m.) Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Use KPluginLoader::findPlugin and QLibrary instead of KLibrary Diffs - src/utils/templateinterface.cpp 241f1a36c5d0c3b6b3cccb914513b28d7c60898a Diff: https://git.reviewboard.kde.org/r/116994/diff/ Testing --- Builds, installs. Cannot test the loading due to a lack of ported pimlibs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: LXR
On 20/03/14 08:13, David Faure wrote: On Thursday 20 March 2014 00:28:44 Alex Merry wrote: LXR says the only users are a couple of projects that haven't even made it onto projects.kde.org. Talking about LXR... I just finished setting up http://lxrnew.kde.org/ident Can you use it for your upcoming searches, to beta-test it? If nothing major came up, we'll switch lxr.kde.org to that new site. It seems to be working really well. The branch-group switching functionality is really useful. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116997: Cleanup KDE 4 references in various comments and dox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116997/ --- Review request for KDE Frameworks. Repository: kio Description --- Cleanup KDE 4 references in various comments and dox Remove commented-out KSocks call No-one noticed its absense through KDE 4... Remove disabled archive support from ListJob According to the comments, this has never worked. Remove the kdestop integration code from fileundomanager This hasn't worked since KDE 2.1(!) Diffs - src/core/listjob.cpp 9ed42eb51f7aa83016a8818f45e88e300eaa726e src/core/slavebase.h 092289349dee1c0136668e14088ef4e3d41077ba src/core/slavebase.cpp b5d5de0f243a9420bcff61102bfca5fadc68c0be src/core/transferjob.h 6bd4d32d0607153db66461b97cbef5b367f9e27f src/core/udsentry.h ff3304fefe1c986e7f5df843ee20473ba41e4b4d src/filewidgets/kdiroperator.h a66d733929ec472971814644dc9847433c955491 src/filewidgets/kdiroperator.cpp 17f09d14b859cba26bb474875bab65d2be0bb7a9 src/filewidgets/kfilepreviewgenerator.cpp c47a309de1305145184ced8fecd042f22cf7dc66 src/widgets/fileundomanager.cpp 7a22532cb5c23ea6dd152fcf22d6a7ff7a02ed88 src/widgets/fileundomanager_p.h f135f499b2c7d8e96936863eac2a6cd81a84b0e4 src/widgets/kfileitemactions.h 94c7a1db14633be2966eb220cc942d59ebe0ccdc src/widgets/krun.h dbdc481d797c364d1cc72a67bc58280fcaf393b1 src/widgets/kurifilter.h b67cb1f5a1f8b77bd2b70085417c1ce42748bdde src/widgets/kurlcombobox.cpp 6f76b2c3ace2b7d556dc9351dc9832c93c61c128 src/widgets/pixmaploader.h a1b9fdaf20d29905d24c668cdd94ab0a48c04053 src/widgets/previewjob.h 0eec0076d8659ce3510d56d5084be0907165aa5c src/core/job_base.h 63c59c2c6ddaa9879777c788a7aef391dde2e8dd src/core/kfileitem.h b09c3c017aab3fac0eed21dc0dcc20b8625d75f4 Diff: https://git.reviewboard.kde.org/r/116997/diff/ Testing --- Builds, compiles, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116999: kparts: Remove/resolve old porting comments and TODOs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116999/ --- Review request for KDE Frameworks. Repository: kparts Description --- Remove old porting comments and TODOs Use QMetaObject::indexOfMethod instead of iterating through methods Diffs - src/browserrun.cpp be89f9f54617b5cf4fb70af9bbaf8295d542150a src/mainwindow.h 728e60b497a4883db754c1fed608638cf250cbd3 src/partmanager.h dbbde7e7e71e9791466fd7bd5a511a059c9b5502 src/browserextension.cpp c3fb5e866ab6a9417fc76d79034cc76f0d0e2653 Diff: https://git.reviewboard.kde.org/r/116999/diff/ Testing --- builds, installs, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117000: Rename kmimetypefactory.h to kmimetypefactory_p.h
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117000/ --- Review request for KDE Frameworks. Repository: kservice Description --- Rename kmimetypefactory.h to kmimetypefactory_p.h This makes it obvious it is not installed. Diffs - src/kbuildsycoca/kbuildmimetypefactory.h a1c9f064c95191d30f92f5911168547892150729 src/kbuildsycoca/kbuildservicefactory.cpp 55b2eea17e164bd64e83860a7d42d0fa95c89b84 src/services/kmimetypefactory.h 239a4cdfa2c3add603c6915ecd967401254cd930 src/services/kmimetypefactory.cpp 8fedf59170e4a1af59eae726ca873288d06ea432 src/services/kmimetypetrader.cpp 839579790e6624ff1856d2b5a26307d4da4f3974 src/services/kservice.cpp 50c86ac1a5dfa1400f7471be48494c323005c47d Diff: https://git.reviewboard.kde.org/r/117000/diff/ Testing --- Builds, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: LXR
On 23/03/14 14:55, Alex Merry wrote: On 20/03/14 08:13, David Faure wrote: On Thursday 20 March 2014 00:28:44 Alex Merry wrote: LXR says the only users are a couple of projects that haven't even made it onto projects.kde.org. Talking about LXR... I just finished setting up http://lxrnew.kde.org/ident Can you use it for your upcoming searches, to beta-test it? If nothing major came up, we'll switch lxr.kde.org to that new site. It seems to be working really well. The branch-group switching functionality is really useful. Oh, except that in the general search mode, switching branches clears the file name and perl regex fields. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116984: Fix configuring of kde5init_win32lib_dummy.cpp.in
On March 22, 2014, 11:21 p.m., Nicolás Alvarez wrote: I can't test this because the kservice framework (dep of kinit) doesn't compile on Windows. Alex Merry wrote: Yeah... I was operating on the basis of this is probably less broken than before. kwrapper_win.cpp also has some defunct stuff in it, I guess for much the same reason. I'll test this tomorrow. I thought kservice works on windows (https://git.reviewboard.kde.org/r/115745/), what's the error? - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116984/#review53773 --- On March 22, 2014, 9:46 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116984/ --- (Updated March 22, 2014, 9:46 p.m.) Review request for KDE Frameworks and Alexander Richardson. Repository: kinit Description --- Fix configuring of kde5init_win32lib_dummy.cpp.in The code referred to a variable that was no longer set, so couldn't possibly produce correct code. This sets the variable again (and renames it). Diffs - KF5InitMacros.cmake dddc230341cfb481955a9308e1b4700aa335f940 kde5init_win32lib_dummy.cpp.in 0c030adb0835a291d98ac91b558a08f50f0d448a Diff: https://git.reviewboard.kde.org/r/116984/diff/ Testing --- Completely untested, as I don't use Windows. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117003: Remove kde3 compatibility code for DocPath in desktop files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117003/ --- Review request for KDE Frameworks. Repository: kconfig Description --- Remove kde3 compatibility code for DocPath in desktop files LXR suggests nothing still sets that (everything is X-DocPath now). Diffs - src/core/kdesktopfile.cpp ea0419f6acf572f3c9a48bb77704b2d7d71e4ad4 Diff: https://git.reviewboard.kde.org/r/117003/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117004: Remove out-of-date design docs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117004/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kiconthemes Description --- Remove out-of-date design docs Diffs - docs/DESIGN.iconloading ceb2ffbceb90f05f7909ad71e8292d3e5480c6fc Diff: https://git.reviewboard.kde.org/r/117004/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117005: Remove KDE3 KParts compatibility code
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117005/ --- Review request for KDE Frameworks and David Faure. Repository: kservice Description --- Remove KDE3 KParts compatibility code Diffs - src/plugin/kpluginfactory.cpp 4efd07a1dc2f70073580b9223b4694abaeb5d225 Diff: https://git.reviewboard.kde.org/r/117005/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117006: Remove kde3 compatibility code and comments
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117006/ --- Review request for KDE Frameworks and David Faure. Repository: kio Description --- Remove kde3 compatibility code and comments Diffs - src/core/kfileitem.cpp a37950860c4c009605b37b8d6d5a09f0e8a604d0 src/core/kmountpoint.cpp 86ed0b2b3ce80a9ceb1d754f321abfed7d04258e src/ioslaves/ftp/ftp.cpp 23b1d8f4832f3184d2bf8fee6f8d814dcfeca948 src/widgets/kdirmodel.cpp bd62d8e66bda0e4b4bea4d88d71b991740e9d91b Diff: https://git.reviewboard.kde.org/r/117006/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Cleanup tasks
http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation/KDE4_References lists a bunch of kde4 references that should be cleaned up. Any row that contains things that aren't review requests is up for grabs (including the ones that say in progress). Just put your email address in the last column. Also, reviewing the open requests would be helpful. Also, there's a bunch of KDE 5 TODOs in various frameworks. Do something like for dir in *; do (cd $dir; echo $dir; git grep -n 'KDE \?5' | cat); done to see them. Some of these are API changes that either have to be made or rejected by the end of this week. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117005: Remove KDE3 KParts compatibility code
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117005/#review53829 --- Ship it! Ship It! - David Faure On March 23, 2014, 6:19 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117005/ --- (Updated March 23, 2014, 6:19 p.m.) Review request for KDE Frameworks and David Faure. Repository: kservice Description --- Remove KDE3 KParts compatibility code Diffs - src/plugin/kpluginfactory.cpp 4efd07a1dc2f70073580b9223b4694abaeb5d225 Diff: https://git.reviewboard.kde.org/r/117005/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117006: Remove kde3 compatibility code and comments
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117006/#review53830 --- Ship it! Ship It! - David Faure On March 23, 2014, 6:25 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117006/ --- (Updated March 23, 2014, 6:25 p.m.) Review request for KDE Frameworks and David Faure. Repository: kio Description --- Remove kde3 compatibility code and comments Diffs - src/core/kfileitem.cpp a37950860c4c009605b37b8d6d5a09f0e8a604d0 src/core/kmountpoint.cpp 86ed0b2b3ce80a9ceb1d754f321abfed7d04258e src/ioslaves/ftp/ftp.cpp 23b1d8f4832f3184d2bf8fee6f8d814dcfeca948 src/widgets/kdirmodel.cpp bd62d8e66bda0e4b4bea4d88d71b991740e9d91b Diff: https://git.reviewboard.kde.org/r/117006/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116927: Fix kdeinit module lookup
On March 21, 2014, 4:10 p.m., Hrvoje Senjan wrote: this seems to broke kded modules loading here: Cannot load library /usr/lib64/libkdeinit5_kio_file: (/usr/lib64/libkdeinit5_kio_file.so: cannot open shared object file: No such file or directory) Hrvoje Senjan wrote: err, s/kded modules/kio plugins Alex Merry wrote: Ah, I see. The old code *only* worked for kioslaves, and now it works for everything *but* kioslaves. Although I'm not sure why I didn't run into this in my testing. I think the correct solution here is to do the lookup in klauncher, though. Alex Merry wrote: Ah, I'm getting the error now. Possibly it was something to do with the multiple patches I had lying around for kinit, kservice and kio. Alex Merry wrote: https://git.reviewboard.kde.org/r/116935/ should fix it. FTR: it fixes the issue, tnx. another side-effect left: Could not open kconf_update using a library: Cannot load library /usr/lib64/libkdeinit5_kconf_update: (/usr/lib64/libkdeinit5_kconf_update.so: cannot open shared object file: No such file or directory) - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116927/#review53702 --- On March 20, 2014, 10:18 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116927/ --- (Updated March 20, 2014, 10:18 p.m.) Review request for KDE Frameworks and David Faure. Repository: kinit Description --- Fix kdeinit module lookup KLibrary's lookup magic is not so magic these days - is just uses QCoreApplication::libraryPaths, which is not what we want. Instead, we let dlopen() do the searching for us, plus hack in a check in the library installation directory for kinit (since dlopen() called from Qt does not respect kdeinit5's RUNPATH). This should cover most common cases (module installed to standard location, module installed to same location as the kinit framework, mdoule in LD_LIBRARY_PATH), and if it still fails we just fall back to the normal executable. Rename kinit_library_path() to generate_socket_name() This reflects what the function actually does. Also got rid of the (mostly) ifdef'd-out code that gave the function its original name. Add comment about fragility of lookup based on installation vars Diffs - src/kdeinit/CMakeLists.txt c4e3c49ea28d4e96be9ee1fa02f801052945d01e src/kdeinit/kinit.cpp 82d570c4453cf083e525125edd448b97d8d11bd3 Diff: https://git.reviewboard.kde.org/r/116927/diff/ Testing --- Built and installed. Ran kdeinit5, which reported that it was launching libkdeinit5_klauncher, rather than /home/kf5-devel/kf5/bin/klauncher as it did previously. klauncher process then has [kdeinit] in its process title in `ps xu`. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116966: Reorder private variables of KLineEditPrivate to avoid padding
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116966/#review53833 --- Ship it! Ship It! - David Faure On March 21, 2014, 9:58 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116966/ --- (Updated March 21, 2014, 9:58 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Reorder private variables of KLineEditPrivate to avoid padding. In my 32bits box the size goes down from 124 to 116. Diffs - src/klineedit_p.h 09cf8b4 Diff: https://git.reviewboard.kde.org/r/116966/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: LXR
On Sunday 23 March 2014 17:33:46 Alex Merry wrote: On 23/03/14 14:55, Alex Merry wrote: On 20/03/14 08:13, David Faure wrote: On Thursday 20 March 2014 00:28:44 Alex Merry wrote: LXR says the only users are a couple of projects that haven't even made it onto projects.kde.org. Talking about LXR... I just finished setting up http://lxrnew.kde.org/ident Can you use it for your upcoming searches, to beta-test it? If nothing major came up, we'll switch lxr.kde.org to that new site. It seems to be working really well. The branch-group switching functionality is really useful. Oh, except that in the general search mode, switching branches clears the file name and perl regex fields. In all search modes, actually. This is just HTML-1.0 link technology from 1990 :) The links load a new page, the fields get reloaded. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116936: Use QLibrary instead of KLibrary
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116936/#review53834 --- Ship it! src/html/kopenssl.cpp https://git.reviewboard.kde.org/r/116936/#comment37753 funny iterator name ;) - David Faure On March 20, 2014, 8:48 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116936/ --- (Updated March 20, 2014, 8:48 p.m.) Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Repository: khtml Description --- Use QLibrary instead of KLibrary This code wants to load normal libraries, rather than ones in plugin directories, and so does not need or want KLibrary's odd lookup routines. Diffs - src/html/kopenssl.cpp 43125ae90cb4e375cb93a011acbf584adc334f0a src/rendering/break_lines.cpp bc4542c7ea1031d75531b6028f3044fe15672009 Diff: https://git.reviewboard.kde.org/r/116936/diff/ Testing --- ./tests/testkhtml 'https://git.reviewboard.kde.org' Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116937: Use QLibrary instead of KLibrary in KOpenSSL
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116937/#review53835 --- Ship it! Ship It! - David Faure On March 20, 2014, 8:50 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116937/ --- (Updated March 20, 2014, 8:50 p.m.) Review request for KDE Frameworks. Repository: kde4support Description --- Use QLibrary instead of KLibrary in KOpenSSL Diffs - src/kssl/kopenssl.cpp 43125ae90cb4e375cb93a011acbf584adc334f0a Diff: https://git.reviewboard.kde.org/r/116937/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116930: Fix device not open warning messages at build time
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116930/
---
(Updated March 23, 2014, 8:12 p.m.)
Review request for KDE Frameworks and Sebastian Kügler.
Repository: kservice
Description
---
The device not open message appears when one registers a factory without a
.json file.
The K_PLUGIN_FACTORY_WITH_BASEFACTORY macro expands to:
class MyPlugin : public KPluginFactory
{
Q_OBJECT
Q_PLUGIN_METADATA(IID KPluginFactory_iid FILE )
When moc parses such code, it tries to read a json file named and rightfully
complains.
Diffs
-
src/plugin/kpluginfactory.h 3880d29
Diff: https://git.reviewboard.kde.org/r/116930/diff/
Testing
---
Rebuilt kde-workspace from scratch. No more message.
Thanks,
Aurélien Gâteau
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116958: Update comment referencing fake MIME types
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116958/#review53839 --- Hmm clearly the whole thing can be removed if there are no more special mimetypes. I'll do that. - David Faure On March 21, 2014, 5:09 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116958/ --- (Updated March 21, 2014, 5:09 p.m.) Review request for KDE Frameworks. Repository: kservice Description --- This is to eventually remove the entry from kde5.xml, which causes shared-mime-info warnings: Unknown media type in type 'all/allfiles'. Diffs - src/kbuildsycoca/kbuildservicefactory.cpp 4dbb44b7db1a8bc4182899485db9c45c063c9b52 src/services/kservicetypeprofile.h d14955d112e973d45a1387ee6db79b0c09949b23 Diff: https://git.reviewboard.kde.org/r/116958/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116962: Clean up KDE4 references in kconfig
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116962/#review53841
---
Ship it!
- David Faure
On March 21, 2014, 6:15 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116962/
---
(Updated March 21, 2014, 6:15 p.m.)
Review request for KDE Frameworks.
Repository: kconfig
Description
---
Update docs for KDesktopFile::isAuthorizedDesktopFile()
The fact that it changed in KDE 4.3 is not so relevant any more.
Remove unhelpful comments
These lines of code do not really require any justification.
Better comment for why KDesktopFile::readPath uses readEntry
Remove old kdelibs4 code
All this ifdef'd-out code just makes it hard to see what's going on.
Remove references to ${_KDE4_KCONFIG_COMPILER_DEP}
Not sure why it would be unset and then used, instead of just not used
at all. LXR says it's not used anywhere else, though.
Diffs
-
KF5ConfigConfig.cmake.in 12ff7c639493f75ed0c5941c40604d00e7a1b047
KF5ConfigMacros.cmake aeebee9ea39ab33712131b13ca561136a9bb6309
src/core/kconfig.cpp 4695621ab4c4dbc862c0ddde1b065e19254ab500
src/core/kdesktopfile.h df8eff1a796ead2b19e1c7bcca2a7b7d22e34d34
src/core/kdesktopfile.cpp ea0419f6acf572f3c9a48bb77704b2d7d71e4ad4
src/kconf_update/kconf_update.cpp f8ba16d1c27029b480f19d5580b3edca9ac98bd0
src/kconfig_compiler/CMakeLists.txt
71f2609d870cd00eae3d98c0f3a07504d5973ff0
Diff: https://git.reviewboard.kde.org/r/116962/diff/
Testing
---
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117000: Rename kmimetypefactory.h to kmimetypefactory_p.h
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117000/#review53850 --- Ship it! Ship It! - David Faure On March 23, 2014, 4:45 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117000/ --- (Updated March 23, 2014, 4:45 p.m.) Review request for KDE Frameworks. Repository: kservice Description --- Rename kmimetypefactory.h to kmimetypefactory_p.h This makes it obvious it is not installed. Diffs - src/kbuildsycoca/kbuildmimetypefactory.h a1c9f064c95191d30f92f5911168547892150729 src/kbuildsycoca/kbuildservicefactory.cpp 55b2eea17e164bd64e83860a7d42d0fa95c89b84 src/services/kmimetypefactory.h 239a4cdfa2c3add603c6915ecd967401254cd930 src/services/kmimetypefactory.cpp 8fedf59170e4a1af59eae726ca873288d06ea432 src/services/kmimetypetrader.cpp 839579790e6624ff1856d2b5a26307d4da4f3974 src/services/kservice.cpp 50c86ac1a5dfa1400f7471be48494c323005c47d Diff: https://git.reviewboard.kde.org/r/117000/diff/ Testing --- Builds, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.
On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: While I'm fine with the idea behind this optimization, I worry that this implementation could create situations were a configuration change is not picked up by the system. For instance, what happens if the user doesn't immediately call readConfig? This could create some subtle bugs in downstream code. I had two ideas for how this optimization could be implemented: 1) Lazy load the KConfig object the first time it is used. Then, in readConfig, the call to be reparseConfiguration could be avoided if the KConfig is created due to its call. This would retain the current behaviour, while ensuring readConfig reads in the most configuration. Other uses of the KConfig will have to ensure the KConfig object has already been created, and if the user calls one of those functions before readConfig, they will still double read the configuration. But since this is just status quo, I'm not too worried. 2) Alternately, create a set of construction functions, like make_shared, that imitate the creation of a KConfigSkeleton subclass, and then reading the configuration through readConfig. Internally, it can use a private readConfig function to ensure the configuration is no re-read. This would require changes to applications to avoid the extra configuration call, unfortunately. I saw RR #115964, and I assume that some of the reductions to the readings of oxygenrc are caused by the sharing the KConfig between some KConfigSkeleton's? If so, I'd suggest implementing solution 1 for the general case, and then making a special construction function to handle shared KConfig's. I don't want to avoid calling reparseConfiguration without some warning around this, as it may again cause some surprises. A new appropriately named function shouldn't be too bad though, as opposed to changing the behaviour of the constructor. David Faure wrote: I've been thinking about this too, but what good is a KConfigSkeleton if you don't call readSettings() on it? You can't read any settings from it then, so all you can do is a) keep it around for later or b) use it purely for writing out a new config file. Use case b) is no problem, so I think we're talking about use case a). Yes in theory an app could see a behavior change in that the config file is loaded from disk at the time of creating the skeleton rather than at the time of calling readConfig the first time. But this is why I'm making this change in 5.0 and not in 4.13. I think it's an acceptable behavior (matching KConfig's behavior more closely - it parses in the ctor, not in readEntry) and I doubt it affects many apps, since all I see everywhere is singletons - i.e. the KConfigSkeleton is created on demand at the time where it's first needed, therefore the ctor is immediately followed by readConfig. My alternative idea (let's call it 3 to complete your list) was to pass a flag to the KConfig constructor to tell it don't parse now, and setting that flag from the KConfigSkeleton constructor. Then readConfig can keep always calling reparseConfiguration(). This would work, right? Your suggestion 1 is somewhat equivalent, but since one of the ctors for KCoreConfigSkeleton takes a KSharedConfig::Ptr as input, it's not applicable, we can't delay the creation of the kconfig within KCoreConfigSkeleton since it's created beforehand by the application. Your suggestion 2 requires changing all the apps, which lowers the benefits of the optimization. Matthew Dawson wrote: I agree, it is a weird use case, and the software should probably be adjusted. However, if an app does rely on that, it is very hard for the author of the software to notice the change, even with the port to 5. If I just looked at the functions names, I'd expect readConfig to read the file all the time. Following the principle of least surprise, I'd like to avoid readConfig ever not reading the file. I'm fine with your alternate idea. I prefer that over my first idea, as it effectively does the same thing while being less invasive. For my second suggestion, I realize its downsides. I just like following the principle of least surprise. If your alternate idea is implemented, I believe that would cover most cases. Suggestion 2 can then be implemented, and its related constructor could be marked deprecated. This would allow for existing programs to continue working, while allowing developers to change their code to take advantage of the optimization. As I stated earlier, I'm not sure about who KDE wants to handle source compatibility with kdelibs. I also wouldn't mind just removing the second constructor, forcing all users to upgrade their code. Since the function is a drop in replacement, it wouldn't be that hard for developers to upgrade.
Re: Review Request 116967: Fix doc in KUrlPixmapProvider
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116967/#review53854 --- Ship it! Ship It! - David Faure On March 21, 2014, 10:20 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116967/ --- (Updated March 21, 2014, 10:20 p.m.) Review request for KDE Frameworks. Repository: kio Description --- Fix doc in KUrlPixmapProvider Diffs - src/widgets/kurlpixmapprovider.h 41ed05a Diff: https://git.reviewboard.kde.org/r/116967/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116959: Remove KDE 4 references from kcmutils
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/#review53855 --- Ship it! with one fix first src/kcmultidialog.cpp https://git.reviewboard.kde.org/r/116959/#comment37758 this if() isn't needed, already tested in the parent scope. - David Faure On March 21, 2014, 5:15 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/ --- (Updated March 21, 2014, 5:15 p.m.) Review request for KDE Frameworks. Repository: kcmutils Description --- KCModuleProxy: remove deprecated forwarding methods These have been deprecated since at least kdelibs 4.0, and LXR says the only user is KCMultiDialog (since I fixed the call in systemsettings). KCModuleContainer: tidy up overridden methods Use the @reimp macro in the docs and use Q_DECL_OVERRIDE. KCModuleContainer: move modulelist variables to private object According to LXR, these were not used by anything. Remove TODO file This is full of API changes for KDE 4. Some were done, and others not (but would probably be considered too disruptive for KF5). Diffs - TODO 82f28e12903e51279ba12871c7b184a97c79a12a src/kcmodulecontainer.h 68aaeb008195aae154b1fbaf44c6f620753884b0 src/kcmodulecontainer.cpp 5b698ab2e320654a9ff3396c22b8aa239d4395d7 src/kcmoduleproxy.h d80d519dbf6e4015864d61daf65f67b99c136f26 src/kcmoduleproxy.cpp c58b68ccb1716493d0537fbfe5a89733ff72e22b src/kcmultidialog.cpp cc0c8d8228ad03e1b4de62152bf7bc7ecdc1f5ee Diff: https://git.reviewboard.kde.org/r/116959/diff/ Testing --- Compiles, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116968: Fix doc in KToolBarLabelAction
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116968/#review53856 --- Ship it! Ship It! - David Faure On March 21, 2014, 10:27 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116968/ --- (Updated March 21, 2014, 10:27 p.m.) Review request for KDE Frameworks. Repository: kwidgetsaddons Description --- Fix doc in KToolBarLabelAction KHistoryCombo - KHistoryComboBox Diffs - src/ktoolbarlabelaction.h 3c6978e Diff: https://git.reviewboard.kde.org/r/116968/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116969: Remove private reset() and move the implementation to the public reset() in KHistoryComboBox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116969/#review53857 --- I don't really get the point of this change? (it's mostly a TODO...) - David Faure On March 21, 2014, 10:51 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116969/ --- (Updated March 21, 2014, 10:51 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Remove private reset() and move the implementation to the public reset() Move method to public Q_SLOTS section Diffs - src/khistorycombobox.h d1f5eac src/khistorycombobox.cpp 80261ae Diff: https://git.reviewboard.kde.org/r/116969/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116970: Remove wish in KComboBox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116970/#review53858 --- Ship it! Ship It! - David Faure On March 21, 2014, 11:06 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116970/ --- (Updated March 21, 2014, 11:06 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Remove wish in KComboBox Diffs - src/kcombobox.h 42de884 Diff: https://git.reviewboard.kde.org/r/116970/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116971: Remove eventFilter and wheelEvent, apparently not needed anymore in KComboBox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116971/#review53859 --- Ship it! Ship It! - David Faure On March 21, 2014, 11:16 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116971/ --- (Updated March 21, 2014, 11:16 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Remove eventFilter and wheelEvent, apparently not needed anymore in KComboBox Diffs - src/kcombobox.h 42de884 src/kcombobox.cpp 30edc1b Diff: https://git.reviewboard.kde.org/r/116971/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116993: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116993/#review53860 --- Ship it! Ship It! - David Faure On March 23, 2014, 2:18 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116993/ --- (Updated March 23, 2014, 2:18 p.m.) Review request for KDE Frameworks. Repository: kcmutils Description --- Use KPluginLoader::findPlugin and QLibrary instead of KLibrary Diffs - src/kcmoduleloader.cpp 31ad1aa95dd664f5d65ab81edeb3274b3c5d73e1 Diff: https://git.reviewboard.kde.org/r/116993/diff/ Testing --- `kcmshell5 kcm_phonon` Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116845: Make readConfig() non-virtual anymore, it's not useful. Remove unnecessary debug output Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116845/#review53862 --- Ship it! Everything seems fine for this to go in as is. The rest can be done later. If you prefer, I'll revert the DelayedParsing commit after you commit this. - Matthew Dawson On March 17, 2014, 7:17 p.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116845/ --- (Updated March 17, 2014, 7:17 p.m.) Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig Description --- Make readConfig() non-virtual anymore, it's not useful. Apps can reimplement usrReadConfig() or the readConfig() in every item instead. Remove unnecessary debug output Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration. Call it from generated singletons, since the constructor creates a KConfig from a filename, which already loads from disk. This removes the need for using DelayedParsing. Diffs - autotests/kconfig_compiler/test10.cpp.ref 21aea9d87af5fce01e64032257283e0883af2d81 autotests/kconfig_compiler/test1main.cpp d7dc038d91d2f8babcd281960100d1c6fa264d7c autotests/kconfig_compiler/test4.cpp.ref 66d0357f114b0aca6148a2091880dd2f62fbf624 autotests/kconfig_compiler/test4main.cpp 8f1c1ec8d41ea123893a59526c52cdbd0b5ee075 autotests/kconfig_compiler/test5.cpp.ref 088cc78f4dc96a719628ece342e149553c1d22aa autotests/kconfig_compiler/test8b.cpp.ref dcd61693ff86f02eaeb93b4c4da9e6ed20463469 autotests/kconfig_compiler/test_dpointer.cpp.ref e50bf8aa29a2d009c4156dabf429c3ffb74eb7ba autotests/kconfig_compiler/test_signal.cpp.ref 35b5cba2736761753d1ba32baa6f9fc2e7808ba1 autotests/kconfigskeletontest.cpp 31278e767655f7e3d25a4ed9984345e8c4e67d82 src/core/kcoreconfigskeleton.h a2b828a4ef3f881b551049901d4bc26bb23a014b src/core/kcoreconfigskeleton.cpp 0c1a96faaa9c511d349a26ad8af4b7b2c9bf313e src/kconfig_compiler/kconfig_compiler.cpp 7d84cfbc28b1648ca999116726455183d88a7f0a Diff: https://git.reviewboard.kde.org/r/116845/diff/ Testing --- Added two unittests (which is how I discovered I had to remove DelayedParsing, so the tests were useful). The bool ok + qWarning thing is a bit clumsy, maybe we want to port these main() to qtestlib too, even though they are themselves executed by a unittest :-) Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116845: Make readConfig() non-virtual anymore, it's not useful. Remove unnecessary debug output Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116845/ --- (Updated March 23, 2014, 10 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig Description --- Make readConfig() non-virtual anymore, it's not useful. Apps can reimplement usrReadConfig() or the readConfig() in every item instead. Remove unnecessary debug output Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration. Call it from generated singletons, since the constructor creates a KConfig from a filename, which already loads from disk. This removes the need for using DelayedParsing. Diffs - autotests/kconfig_compiler/test10.cpp.ref 21aea9d87af5fce01e64032257283e0883af2d81 autotests/kconfig_compiler/test1main.cpp d7dc038d91d2f8babcd281960100d1c6fa264d7c autotests/kconfig_compiler/test4.cpp.ref 66d0357f114b0aca6148a2091880dd2f62fbf624 autotests/kconfig_compiler/test4main.cpp 8f1c1ec8d41ea123893a59526c52cdbd0b5ee075 autotests/kconfig_compiler/test5.cpp.ref 088cc78f4dc96a719628ece342e149553c1d22aa autotests/kconfig_compiler/test8b.cpp.ref dcd61693ff86f02eaeb93b4c4da9e6ed20463469 autotests/kconfig_compiler/test_dpointer.cpp.ref e50bf8aa29a2d009c4156dabf429c3ffb74eb7ba autotests/kconfig_compiler/test_signal.cpp.ref 35b5cba2736761753d1ba32baa6f9fc2e7808ba1 autotests/kconfigskeletontest.cpp 31278e767655f7e3d25a4ed9984345e8c4e67d82 src/core/kcoreconfigskeleton.h a2b828a4ef3f881b551049901d4bc26bb23a014b src/core/kcoreconfigskeleton.cpp 0c1a96faaa9c511d349a26ad8af4b7b2c9bf313e src/kconfig_compiler/kconfig_compiler.cpp 7d84cfbc28b1648ca999116726455183d88a7f0a Diff: https://git.reviewboard.kde.org/r/116845/diff/ Testing --- Added two unittests (which is how I discovered I had to remove DelayedParsing, so the tests were useful). The bool ok + qWarning thing is a bit clumsy, maybe we want to port these main() to qtestlib too, even though they are themselves executed by a unittest :-) Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.
On Feb. 28, 2014, 8:41 p.m., Matthew Dawson wrote: While I'm fine with the idea behind this optimization, I worry that this implementation could create situations were a configuration change is not picked up by the system. For instance, what happens if the user doesn't immediately call readConfig? This could create some subtle bugs in downstream code. I had two ideas for how this optimization could be implemented: 1) Lazy load the KConfig object the first time it is used. Then, in readConfig, the call to be reparseConfiguration could be avoided if the KConfig is created due to its call. This would retain the current behaviour, while ensuring readConfig reads in the most configuration. Other uses of the KConfig will have to ensure the KConfig object has already been created, and if the user calls one of those functions before readConfig, they will still double read the configuration. But since this is just status quo, I'm not too worried. 2) Alternately, create a set of construction functions, like make_shared, that imitate the creation of a KConfigSkeleton subclass, and then reading the configuration through readConfig. Internally, it can use a private readConfig function to ensure the configuration is no re-read. This would require changes to applications to avoid the extra configuration call, unfortunately. I saw RR #115964, and I assume that some of the reductions to the readings of oxygenrc are caused by the sharing the KConfig between some KConfigSkeleton's? If so, I'd suggest implementing solution 1 for the general case, and then making a special construction function to handle shared KConfig's. I don't want to avoid calling reparseConfiguration without some warning around this, as it may again cause some surprises. A new appropriately named function shouldn't be too bad though, as opposed to changing the behaviour of the constructor. David Faure wrote: I've been thinking about this too, but what good is a KConfigSkeleton if you don't call readSettings() on it? You can't read any settings from it then, so all you can do is a) keep it around for later or b) use it purely for writing out a new config file. Use case b) is no problem, so I think we're talking about use case a). Yes in theory an app could see a behavior change in that the config file is loaded from disk at the time of creating the skeleton rather than at the time of calling readConfig the first time. But this is why I'm making this change in 5.0 and not in 4.13. I think it's an acceptable behavior (matching KConfig's behavior more closely - it parses in the ctor, not in readEntry) and I doubt it affects many apps, since all I see everywhere is singletons - i.e. the KConfigSkeleton is created on demand at the time where it's first needed, therefore the ctor is immediately followed by readConfig. My alternative idea (let's call it 3 to complete your list) was to pass a flag to the KConfig constructor to tell it don't parse now, and setting that flag from the KConfigSkeleton constructor. Then readConfig can keep always calling reparseConfiguration(). This would work, right? Your suggestion 1 is somewhat equivalent, but since one of the ctors for KCoreConfigSkeleton takes a KSharedConfig::Ptr as input, it's not applicable, we can't delay the creation of the kconfig within KCoreConfigSkeleton since it's created beforehand by the application. Your suggestion 2 requires changing all the apps, which lowers the benefits of the optimization. Matthew Dawson wrote: I agree, it is a weird use case, and the software should probably be adjusted. However, if an app does rely on that, it is very hard for the author of the software to notice the change, even with the port to 5. If I just looked at the functions names, I'd expect readConfig to read the file all the time. Following the principle of least surprise, I'd like to avoid readConfig ever not reading the file. I'm fine with your alternate idea. I prefer that over my first idea, as it effectively does the same thing while being less invasive. For my second suggestion, I realize its downsides. I just like following the principle of least surprise. If your alternate idea is implemented, I believe that would cover most cases. Suggestion 2 can then be implemented, and its related constructor could be marked deprecated. This would allow for existing programs to continue working, while allowing developers to change their code to take advantage of the optimization. As I stated earlier, I'm not sure about who KDE wants to handle source compatibility with kdelibs. I also wouldn't mind just removing the second constructor, forcing all users to upgrade their code. Since the function is a drop in replacement, it wouldn't be that hard for developers to upgrade.
Re: Review Request 116995: Rename the kconfig_compiler_kf5 target to kconfig_compiler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116995/#review53869 --- Ship it! Ship It! - David Faure On March 23, 2014, 2:52 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116995/ --- (Updated March 23, 2014, 2:52 p.m.) Review request for KDE Frameworks. Repository: kconfig Description --- Rename the kconfig_compiler_kf5 target to kconfig_compiler Just because the executable has the _kf5 suffix, that does not mean the target should have it. This is ugly API, and will be unnecessary porting effort for KF6. Only one place uses this currently - one CMake file in kde4support. I'll change that when committing this. Diffs - CMakeLists.txt 417cd9cb7e0d80abd9100019786e8ea19007e3ef KF5ConfigMacros.cmake aeebee9ea39ab33712131b13ca561136a9bb6309 autotests/kconfig_compiler/CMakeLists.txt 289e9583b64396c5eb080a1bc9cb2833b540ba71 src/kconfig_compiler/CMakeLists.txt 71f2609d870cd00eae3d98c0f3a07504d5973ff0 Diff: https://git.reviewboard.kde.org/r/116995/diff/ Testing --- Builds, installs, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116971: Remove eventFilter and wheelEvent, apparently not needed anymore in KComboBox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116971/#review53871 --- This review has been submitted with commit 5efd23a2aa5ff510e7fc589945ef4f6db918a8e4 by David Gil to branch master. - Commit Hook On March 21, 2014, 11:16 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116971/ --- (Updated March 21, 2014, 11:16 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Remove eventFilter and wheelEvent, apparently not needed anymore in KComboBox Diffs - src/kcombobox.h 42de884 src/kcombobox.cpp 30edc1b Diff: https://git.reviewboard.kde.org/r/116971/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116971: Remove eventFilter and wheelEvent, apparently not needed anymore in KComboBox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116971/ --- (Updated March 23, 2014, 11 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kcompletion Description --- Remove eventFilter and wheelEvent, apparently not needed anymore in KComboBox Diffs - src/kcombobox.h 42de884 src/kcombobox.cpp 30edc1b Diff: https://git.reviewboard.kde.org/r/116971/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116966: Reorder private variables of KLineEditPrivate to avoid padding
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116966/#review53873 --- This review has been submitted with commit 229f334352e40071f773c1a9b9d3cb161a32a597 by David Gil to branch master. - Commit Hook On March 21, 2014, 9:58 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116966/ --- (Updated March 21, 2014, 9:58 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Reorder private variables of KLineEditPrivate to avoid padding. In my 32bits box the size goes down from 124 to 116. Diffs - src/klineedit_p.h 09cf8b4 Diff: https://git.reviewboard.kde.org/r/116966/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116966: Reorder private variables of KLineEditPrivate to avoid padding
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116966/ --- (Updated March 23, 2014, 11:04 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kcompletion Description --- Reorder private variables of KLineEditPrivate to avoid padding. In my 32bits box the size goes down from 124 to 116. Diffs - src/klineedit_p.h 09cf8b4 Diff: https://git.reviewboard.kde.org/r/116966/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116968: Fix doc in KToolBarLabelAction
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116968/#review53875 --- This review has been submitted with commit a7a2af528fab6d412b84a8484515327db16c38a6 by David Gil to branch master. - Commit Hook On March 21, 2014, 10:27 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116968/ --- (Updated March 21, 2014, 10:27 p.m.) Review request for KDE Frameworks. Repository: kwidgetsaddons Description --- Fix doc in KToolBarLabelAction KHistoryCombo - KHistoryComboBox Diffs - src/ktoolbarlabelaction.h 3c6978e Diff: https://git.reviewboard.kde.org/r/116968/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117010: Finish renames in KCoreConfigSkeleton, and stop doing extra loads as well.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117010/ --- Review request for KDE Frameworks and David Faure. Repository: kconfig Description --- Stop re-loading values inside KCoreConfigSkeleton::save(). The extra load of values in KCoreConfigSkeleton is not documented anywhere that it happens, and in normal circumstances re-loading new values isn't expecterd during a save operation. Update various mentions of readConfig/writeConfig to read/save. Update documentation to match the new names of functions. Rename writeConfig() to save() and usrWriteConfig() to usrSave() Rename functions to match the new naming conventions. Also create old deprecated instances of both functions to ensure that old code continues to operate correctly. Also make save() non-virtual, for the same reasons read() is now non-virtual. Rename usrReadConfig to usrRead, to be consistent with the new name for readConfig. Rename usrReadConfig to usrRead, and mark the former as deprecated. To maintain compatibility, usrRead still calls usrReadConfig in its default implementation. usrReadConfig remains empty. Diffs - src/gui/kconfigskeleton.h 8262f5ce642895c94eda5cde7091fdfbc2c8a7b2 src/core/kcoreconfigskeleton.cpp 69a4bf0405b985378976d67ee3774e043fe513db src/core/kcoreconfigskeleton.h 41f1428987b80bd842b7d46720251e3f4d13c86e autotests/kconfigskeletontest.cpp a25aaf40e9b58d2947e6ea89aa8d5024d8981da4 autotests/kconfig_compiler/kconfigcompiler_test_signals.cpp 3017fe2f7bd081719ba4c7cb3867c345e97b3bcb Diff: https://git.reviewboard.kde.org/r/117010/diff/ Testing --- Unit tests continue to pass. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117010: Finish renames in KCoreConfigSkeleton, and stop doing extra loads as well.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117010/#review53876 --- Ah, the old usrReadConfig still exists, OK, that solves my worry. Just one issue, I think some ifdef compiler is gcc are missing (Q_CC_GNU?) src/core/kcoreconfigskeleton.h https://git.reviewboard.kde.org/r/117010/#comment37766 while you're here, overridde - override src/core/kcoreconfigskeleton.cpp https://git.reviewboard.kde.org/r/117010/#comment37767 Won't this break with MSVC? - David Faure On March 23, 2014, 11:11 p.m., Matthew Dawson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117010/ --- (Updated March 23, 2014, 11:11 p.m.) Review request for KDE Frameworks and David Faure. Repository: kconfig Description --- Stop re-loading values inside KCoreConfigSkeleton::save(). The extra load of values in KCoreConfigSkeleton is not documented anywhere that it happens, and in normal circumstances re-loading new values isn't expecterd during a save operation. Update various mentions of readConfig/writeConfig to read/save. Update documentation to match the new names of functions. Rename writeConfig() to save() and usrWriteConfig() to usrSave() Rename functions to match the new naming conventions. Also create old deprecated instances of both functions to ensure that old code continues to operate correctly. Also make save() non-virtual, for the same reasons read() is now non-virtual. Rename usrReadConfig to usrRead, to be consistent with the new name for readConfig. Rename usrReadConfig to usrRead, and mark the former as deprecated. To maintain compatibility, usrRead still calls usrReadConfig in its default implementation. usrReadConfig remains empty. Diffs - src/gui/kconfigskeleton.h 8262f5ce642895c94eda5cde7091fdfbc2c8a7b2 src/core/kcoreconfigskeleton.cpp 69a4bf0405b985378976d67ee3774e043fe513db src/core/kcoreconfigskeleton.h 41f1428987b80bd842b7d46720251e3f4d13c86e autotests/kconfigskeletontest.cpp a25aaf40e9b58d2947e6ea89aa8d5024d8981da4 autotests/kconfig_compiler/kconfigcompiler_test_signals.cpp 3017fe2f7bd081719ba4c7cb3867c345e97b3bcb Diff: https://git.reviewboard.kde.org/r/117010/diff/ Testing --- Unit tests continue to pass. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117011: Use bin/../share on Windows as a workaround
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/ --- Review request for KDE Frameworks and kdewin. Repository: kdoctools Description --- This is a workaround for kdoctools for the same problem discussed in review #115210. In particular, emerge installs docbook-dtd data under %KDEROOT%\share. Diffs - src/xslt.cpp db67599 Diff: https://git.reviewboard.kde.org/r/117011/diff/ Testing --- Tested using MSVC 2013. KJsEmbed, which depends on this, builds after this patch (KJsEmbed still has an unrelated problem on install step). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53877 --- src/colors/kcolorutils.cpp https://git.reviewboard.kde.org/r/116866/#comment37768 Wouldn't it make more sense to use qIsNan? http://qt-project.org/doc/qt-5.0/qtcore/qtglobal.html#qIsNaN - Aleix Pol Gonzalez On March 22, 2014, 8:54 p.m., Michael Hansen wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 22, 2014, 8:54 p.m.) Review request for KDE Frameworks. Repository: kguiaddons Description --- Use std::isnan from cmath instead of isnan from math.h, as MinGW-32 on Windows does not include the latter. This keeps the _isnan hack for MSVC, since that compiler doesn't include either standard version :(. Diffs - src/kguiaddons_config.h.cmake PRE-CREATION src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 src/ConfigureChecks.cmake PRE-CREATION src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 Diff: https://git.reviewboard.kde.org/r/116866/diff/ Testing --- Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC 4.8 (Arch x86_64). Thanks, Michael Hansen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117011: Use bin/../share on Windows as a workaround
On March 24, 2014, 12:51 a.m., Aleix Pol Gonzalez wrote: So what should happen so that we didn't need the workaround? QStandardPaths would have to look in %KDEROOT%\share and not just C:\ProgramData. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/#review53878 --- On March 24, 2014, 12:28 a.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/ --- (Updated March 24, 2014, 12:28 a.m.) Review request for KDE Frameworks and kdewin. Repository: kdoctools Description --- This is a workaround for kdoctools for the same problem discussed in review #115210. In particular, emerge installs docbook-dtd data under %KDEROOT%\share. Diffs - src/xslt.cpp db67599 Diff: https://git.reviewboard.kde.org/r/117011/diff/ Testing --- Tested using MSVC 2013. KJsEmbed, which depends on this, builds after this patch (KJsEmbed still has an unrelated problem on install step). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117011: Use bin/../share on Windows as a workaround
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/#review53880 --- Please add kdewin too. Given the outcome of the other RR, I'm not sure this is the correct solution, but I would prefer if someone with more knowledge of QStandardPaths and Windows could speak up. - Luigi Toscano On March 24, 2014, 12:28 a.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/ --- (Updated March 24, 2014, 12:28 a.m.) Review request for KDE Frameworks and kdewin. Repository: kdoctools Description --- This is a workaround for kdoctools for the same problem discussed in review #115210. In particular, emerge installs docbook-dtd data under %KDEROOT%\share. Diffs - src/xslt.cpp db67599 Diff: https://git.reviewboard.kde.org/r/117011/diff/ Testing --- Tested using MSVC 2013. KJsEmbed, which depends on this, builds after this patch (KJsEmbed still has an unrelated problem on install step). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117011: Use bin/../share on Windows as a workaround
On March 23, 2014, 11:51 p.m., Aleix Pol Gonzalez wrote: So what should happen so that we didn't need the workaround? Alexander Richardson wrote: QStandardPaths would have to look in %KDEROOT%\share and not just C:\ProgramData. So why aren't we adding this in Qt? Or even, why are we installing documentation in share/ if it doesn't make sense on Windows? - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/#review53878 --- On March 23, 2014, 11:28 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/ --- (Updated March 23, 2014, 11:28 p.m.) Review request for KDE Frameworks and kdewin. Repository: kdoctools Description --- This is a workaround for kdoctools for the same problem discussed in review #115210. In particular, emerge installs docbook-dtd data under %KDEROOT%\share. Diffs - src/xslt.cpp db67599 Diff: https://git.reviewboard.kde.org/r/117011/diff/ Testing --- Tested using MSVC 2013. KJsEmbed, which depends on this, builds after this patch (KJsEmbed still has an unrelated problem on install step). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117004: Remove out-of-date design docs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117004/#review53884 --- Ship it! Ship It! - Christoph Feck On March 23, 2014, 5:47 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117004/ --- (Updated March 23, 2014, 5:47 p.m.) Review request for KDE Frameworks and Christoph Feck. Repository: kiconthemes Description --- Remove out-of-date design docs Diffs - docs/DESIGN.iconloading ceb2ffbceb90f05f7909ad71e8292d3e5480c6fc Diff: https://git.reviewboard.kde.org/r/117004/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117012: Place KJsEmbed camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/
---
Review request for KDE Frameworks and kdewin.
Repository: kjsembed
Description
---
Currently kjsembed CMake file tries to install both
${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed (directory) and
${INCLUDE_INSTALL_DIR}/KJsEmbed/KJsEmbed (camel case header). This is not
allowed in a case-insensitive filesystem, causing the install step to fail on
Windows.
Diffs
-
src/kjsembed/CMakeLists.txt e0ab74c
Diff: https://git.reviewboard.kde.org/r/117012/diff/
Testing
---
Tested using MSVC 2013
Thanks,
Andrius da Costa Ribas
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: krunner_master_qt5 #37
See http://build.kde.org/job/krunner_master_qt5/37/changes Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/krunner_master_qt5/ws/ Running Prebuild steps [krunner_master_qt5] $ /bin/sh -xe /tmp/hudson948798025372811324.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/krunner 4b9a2c6..f039165 master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at 4b9a2c6 SVN_SILENT made messages (.desktop file) Removing build/ Success build forhudson.tasks.Shell@7dde938f Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/krunner Checking out Revision f039165e8da88ab73e0402cdb5894a1e02a52b0d (refs/heads/jenkins) Run condition [File exists] enabling prebuild for step [Publish JUnit test result report] Run condition [File exists] enabling prebuild for step [Publish Cppcheck results] [krunner_master_qt5] $ /bin/sh -xe /tmp/hudson9159619067357190613.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: krunner - Branch master == Build Dependencies: threadweaver - Branch master qt5 - Branch stable ki18n - Branch master kwidgetsaddons - Branch master kauth - Branch master kwallet - Branch master kdeclarative - Branch master polkit-qt-1 - Branch qt5 kdoctools - Branch master knotifications - Branch master kconfigwidgets - Branch master extra-cmake-modules - Branch master kdesupport-svn - Branch master kactivities - Branch master kcoreaddons - Branch master plasma-framework - Branch master ktextwidgets - Branch master kjobwidgets - Branch master kcrash - Branch master kidletime - Branch master kjs - Branch master kio - Branch master kdbusaddons - Branch master kcodecs - Branch master sonnet - Branch master cmake - Branch master kitemmodels - Branch master phonon - Branch master kdnssd - Branch master karchive - Branch master kitemviews - Branch master kross - Branch master kglobalaccel - Branch master kservice - Branch master ktexteditor - Branch master kiconthemes - Branch master kcompletion - Branch master kparts - Branch master kwindowsystem - Branch master kunitconversion - Branch master solid - Branch master kxmlgui - Branch master kconfig - Branch master kbookmarks - Branch master kguiaddons - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.7.2 -- The CXX compiler identification is GNU 4.7.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done CMake Warning (dev) at src/declarative/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION_MAJOR PROJECT_VERSION_MINOR PROJECT_VERSION_PATCH This warning is for project developers. Use -Wno-dev to suppress it. -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success -- Performing Test COMPILER_HAS_DEPRECATED_ATTR -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success -- -- The following REQUIRED packages have been found: * Qt5Gui * Qt5Network (required version = 5.3.0) * Qt5Qml (required version = 5.3.0) * Qt5Quick * KF5Config (required version = 4.97.0) * KF5CoreAddons (required version = 4.97.0) * KF5I18n (required version = 4.97.0) * KF5KIO (required version = 4.97.0) * KF5Service (required version = 4.97.0) * Qt5Core (required version = 5.2.0) * ECM (required version = 0.0.9) * KF5Plasma (required version = 4.97.0) * KF5Solid (required version = 4.97.0) * KF5ThreadWeaver (required version = 4.97.0) * Qt5Test * Qt5 (required version = 5.2.0) -- Configuring done -- Generating done CMake Warning: Manually-specified variables were not used by the project: KDE4_BUILD_TESTS
Jenkins build became unstable: kde4support_master_qt5 #85
See http://build.kde.org/job/kde4support_master_qt5/85/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
