Re: Review Request 117919: kcoreaddons: Move license-related KAboutData enums to KAboutLicense.

2014-05-06 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117919/#review57469 --- Ping? It hasn't quite been a week, but on the other hand there

Review Request 118029: Cleanup kdelibs references (mostly replaced by kdoctools)

2014-05-06 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118029/ --- Review request for Documentation and KDE Frameworks. Repository: kdoctool

Re: Review Request 117964: Fix references to translation of licenses

2014-05-06 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117964/ --- (Updated May 6, 2014, 11:56 p.m.) Status -- This change has been mar

Re: Review Request 117964: Fix references to translation of licenses

2014-05-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117964/#review57467 --- This review has been submitted with commit e36e933f9e4b8db6e1

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-06 Thread Luigi Toscano
> On May 6, 2014, 11:01 a.m., Aurélien Gâteau wrote: > > I realized I left one code untouched: the KDOCTOOLS_ENABLE_HTMLHANDBOOK > > block. What should be done with it? The option is not documented: is it > > obsolete? If I understand it correctly, the code generates .html files in > > the sou

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-06 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118004/#review57466 --- Ship it! Thanks - Luigi Toscano On May 6, 2014, 10:59 a.m.

Re: Review Request 118019: Update X11 app timestamp before activating window

2014-05-06 Thread Sebastian Kügler
> On May 6, 2014, 9:42 p.m., Alex Merry wrote: > > src/kdbusservice.cpp, lines 178-179 > > > > > > Use the QX11Info::isPlatformX11() one since you're using QX11Info > > anyway. The two lines are functionally equ

Re: [kde-doc-english] docbook location issues in workspace repos

2014-05-06 Thread Yuri Chornoivan
написане Tue, 06 May 2014 22:23:34 +0300, Burkhard Lück : Am Dienstag, 6. Mai 2014, 22:18:51 schrieb Yuri Chornoivan: написане Tue, 06 May 2014 21:58:37 +0300, Burkhard Lück : > Am Dienstag, 6. Mai 2014, 19:55:02 schrieb Burkhard Lück: >> Hi >> >> attached the updated list of docbooks in kf5 w

Re: Review Request 118025: meinproc5 nam page update to kf5

2014-05-06 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118025/#review57454 --- docs/meinproc5/man-meinproc5.8.docbook

Re: Review Request 118019: Update X11 app timestamp before activating window

2014-05-06 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118019/#review57455 --- src/kdbusservice.cpp

Build failed in Jenkins: kio_master_qt5 #209

2014-05-06 Thread KDE CI System
See Changes: [faure] Fix metatype issue at runtime due to implicit namespace -- [...truncated 773 lines...] [ 18%] Scanning dependencies of target udsentrytest_automoc Scanning dependencies of target li

Re: Review Request 118019: Update X11 app timestamp before activating window

2014-05-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118019/ --- (Updated May 6, 2014, 9:23 p.m.) Review request for KDE Frameworks, David

Re: Review Request 118019: Update X11 app timestamp before activating window

2014-05-06 Thread Sebastian Kügler
> On May 6, 2014, 8:54 p.m., David Faure wrote: > > We don't really need the xcb headers for this to compile (so the cmake > > check surprises me). > > > > I thought the usual way was: > > > > * at compile time, check for QX11Extras' availability (optional dependency) > > * at runtime, check

Re: Review Request 118019: Update X11 app timestamp before activating window

2014-05-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118019/#review57451 --- We don't really need the xcb headers for this to compile (so t

Re: Review Request 118026: Fix KF5_ADD_KDEINIT_EXECUTABLE on Windows

2014-05-06 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118026/ --- (Updated May 6, 2014, 10:29 p.m.) Review request for KDE Frameworks and k

Review Request 118026: Fix KF5_ADD_KDEINIT_EXECUTABLE on Windows

2014-05-06 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118026/ --- Review request for KDE Frameworks. Repository: kinit Description --

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Thomas Lübking
> On May 6, 2014, 1:30 p.m., Kevin Ottens wrote: > > AFAICT it is BIC but no SIC, no brainer. > > Martin Gräßlin wrote: > it's a SIC change as one could have used the variant specifying just > NET::Properties and screen. This would now have to be changed to use > NET::Properties2 before sc

Jenkins build became unstable: kwindowsystem_master_qt5 » All,LINBUILDER #61

2014-05-06 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Marco Martin
> On May 6, 2014, 1:30 p.m., Kevin Ottens wrote: > > AFAICT it is BIC but no SIC, no brainer. > > Martin Gräßlin wrote: > it's a SIC change as one could have used the variant specifying just > NET::Properties and screen. This would now have to be changed to use > NET::Properties2 before sc

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118016/ --- (Updated May 6, 2014, 8:08 p.m.) Status -- This change has been mark

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118016/#review57444 --- This review has been submitted with commit a6672a99a2183a3ead

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Thomas Lübking
> On May 6, 2014, 1:30 p.m., Kevin Ottens wrote: > > AFAICT it is BIC but no SIC, no brainer. > > Martin Gräßlin wrote: > it's a SIC change as one could have used the variant specifying just > NET::Properties and screen. This would now have to be changed to use > NET::Properties2 before sc

Re: Review Request 118025: meinproc5 nam page update to kf5

2014-05-06 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118025/#review57438 --- docs/meinproc5/man-meinproc5.8.docbook

Review Request 118025: meinproc5 nam page update to kf5

2014-05-06 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118025/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano. Repos

Jenkins build is back to normal : solid_master_qt5 #64

2014-05-06 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118019: Update X11 app timestamp before activating window

2014-05-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118019/ --- (Updated May 6, 2014, 3:52 p.m.) Review request for KDE Frameworks, David

Build failed in Jenkins: solid_master_qt5 #63

2014-05-06 Thread KDE CI System
See Changes: [afiestas] Move to udev/CMakeLists.txt all the udev logic [afiestas] Do not compile HAL on Linux [afiestas] Stop checking if UDev has SYSATTR_LIST_ENTRY [afiestas] Make UDev required for Linux [afiestas] Remove no longer need

KF5 on Windows IRC meeting tonight

2014-05-06 Thread Patrick Spendrin
Hi everybody, for those interested, there will be a kf5 meeting on #kde-windows on freenode tonight at 20:00 UTC (22:00 CEST). Some topics can be gathered on the wiki page: http://techbase.kde.org/Projects/KDE_on_Windows/kf5/meetingnotes-2014-05-06 sorry for the short notice, regards, Patrick _

Re: Review Request 118019: Update X11 app timestamp before activating window

2014-05-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118019/#review57421 --- src/kdbusservice.cpp

Re: Review Request 118019: Update X11 app timestamp before activating window

2014-05-06 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118019/#review57420 --- Qt5X11Extras should only be used on X11, otherwise it breaks t

Re: KF5 Update Meeting Minutes 2014-w19

2014-05-06 Thread Marco Martin
On Tuesday 06 May 2014 15:37:05 Jonathan Riddell wrote: > News > - beta 2 is tagged and being packaged by distros with release due thursday > - it is hoped to make a Plasma beta on friday based on Beta 2 > - new schedule up at http://community.kde.org/Frameworks/Epics with beta 3 > on june 1st and

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Thomas Lübking
> On May 6, 2014, 1:30 p.m., Kevin Ottens wrote: > > AFAICT it is BIC but no SIC, no brainer. > > Martin Gräßlin wrote: > it's a SIC change as one could have used the variant specifying just > NET::Properties and screen. This would now have to be changed to use > NET::Properties2 before sc

KF5 Update Meeting Minutes 2014-w19

2014-05-06 Thread Jonathan Riddell
KDE Frameworks meeting was in #kde-devel at 14:00UTC agateau, arichardson, dfaure, ervin, notmart, Riddell, sebas, teo, tosky also present: PovAddictW, apol, mgraesslin < unormal> There is some work going on for new CI system for KF5 and Co. And the webpage http://community.kde.org/Frameworks/Epi

Review Request 118019: Update X11 app timestamp before activating window

2014-05-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118019/ --- Review request for KDE Frameworks, David Faure and Martin Gräßlin. Bugs:

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Marco Martin
> On May 6, 2014, 1:30 p.m., Kevin Ottens wrote: > > AFAICT it is BIC but no SIC, no brainer. > > Martin Gräßlin wrote: > it's a SIC change as one could have used the variant specifying just > NET::Properties and screen. This would now have to be changed to use > NET::Properties2 before sc

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Thomas Lübking
> On May 6, 2014, 1:30 p.m., Kevin Ottens wrote: > > AFAICT it is BIC but no SIC, no brainer. > > Martin Gräßlin wrote: > it's a SIC change as one could have used the variant specifying just > NET::Properties and screen. This would now have to be changed to use > NET::Properties2 before sc

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Marco Martin
> On May 6, 2014, 1:30 p.m., Kevin Ottens wrote: > > AFAICT it is BIC but no SIC, no brainer. > > Martin Gräßlin wrote: > it's a SIC change as one could have used the variant specifying just > NET::Properties and screen. This would now have to be changed to use > NET::Properties2 before sc

Re: Writing a Frameworks book at Randa

2014-05-06 Thread Mirko Boehm
Hi, On 05.05.2014 11:21, Valorie Zimmerman wrote: >> it would be great if you could make "remote participation" possible. While >> > it's too difficult for me to participate in the sprint directly I would be >> > able >> > to remote participate. >> > >> > Cheers >> > Martin > Excellent idea, Mart

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Kevin Ottens
> On May 6, 2014, 1:30 p.m., Kevin Ottens wrote: > > AFAICT it is BIC but no SIC, no brainer. > > Martin Gräßlin wrote: > it's a SIC change as one could have used the variant specifying just > NET::Properties and screen. This would now have to be changed to use > NET::Properties2 before sc

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Martin Gräßlin
> On May 6, 2014, 3:30 p.m., Kevin Ottens wrote: > > AFAICT it is BIC but no SIC, no brainer. > > Martin Gräßlin wrote: > it's a SIC change as one could have used the variant specifying just > NET::Properties and screen. This would now have to be changed to use > NET::Properties2 before sc

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Kevin Ottens
> On May 6, 2014, 1:30 p.m., Kevin Ottens wrote: > > AFAICT it is BIC but no SIC, no brainer. > > Martin Gräßlin wrote: > it's a SIC change as one could have used the variant specifying just > NET::Properties and screen. This would now have to be changed to use > NET::Properties2 before sc

Re: Review Request 117962: forward declare specialisation

2014-05-06 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117962/ --- (Updated May 6, 2014, 1:40 p.m.) Status -- This change has been mark

Re: Review Request 117961: remove several warnings on mingw

2014-05-06 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117961/ --- (Updated May 6, 2014, 1:40 p.m.) Status -- This change has been mark

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Thomas Lübking
> On May 6, 2014, 1:30 p.m., Kevin Ottens wrote: > > AFAICT it is BIC but no SIC, no brainer. > > Martin Gräßlin wrote: > it's a SIC change as one could have used the variant specifying just > NET::Properties and screen. This would now have to be changed to use > NET::Properties2 before sc

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Martin Gräßlin
> On May 6, 2014, 3:30 p.m., Kevin Ottens wrote: > > AFAICT it is BIC but no SIC, no brainer. it's a SIC change as one could have used the variant specifying just NET::Properties and screen. This would now have to be changed to use NET::Properties2 before screen argument. - Martin

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118016/#review57407 --- Ship it! AFAICT it is BIC but no SIC, no brainer. - Kevin Ot

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118016/#review57404 --- Looks good to me and I want to see it merged, but also an ACK

Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118016/ --- Review request for KDE Frameworks and kwin. Repository: kwindowsystem D

Re: Review Request 118014: Fix KUrlNavigator returning a http:// URL for absolute file paths

2014-05-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118014/#review57401 --- This review has been submitted with commit a2d4a96d5742700d13

Re: Review Request 118014: Fix KUrlNavigator returning a http:// URL for absolute file paths

2014-05-06 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118014/ --- (Updated May 6, 2014, 11:27 a.m.) Status -- This change has been mar

Re: Review Request 118014: Fix KUrlNavigator returning a http:// URL for absolute file paths

2014-05-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118014/#review57399 --- Ship it! Fully correct. I'm afraid this isn't the last KUrl(Q

Re: Review Request 117888: Move KCurrencyCode to kdelibs4support

2014-05-06 Thread John Layt
> On April 30, 2014, 1:29 p.m., Alex Merry wrote: > > Well, it looks like nothing that has been ported is using it (and barely > > anything that hasn't been ported ever used it). > > > > However, it should be marked as deprecated, and the apidocs should > > indiciate how to port away from it.

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-06 Thread David Faure
> On May 6, 2014, 9:01 a.m., Aurélien Gâteau wrote: > > I realized I left one code untouched: the KDOCTOOLS_ENABLE_HTMLHANDBOOK > > block. What should be done with it? The option is not documented: is it > > obsolete? If I understand it correctly, the code generates .html files in > > the sour

Review Request 118014: Fix KUrlNavigator returning a http:// URL for absolute file paths

2014-05-06 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118014/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-06 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118004/#review57393 --- I realized I left one code untouched: the KDOCTOOLS_ENABLE_HTM

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-06 Thread Aurélien Gâteau
> On May 6, 2014, 1:03 a.m., Luigi Toscano wrote: > > Is the po-off directory really needed in the example? Oups. No it's not. Removed. - Aurélien --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.k

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-06 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118004/ --- (Updated May 6, 2014, 10:59 a.m.) Review request for Documentation, KDE F

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-06 Thread Aurélien Gâteau
> On May 6, 2014, 1:03 a.m., Luigi Toscano wrote: > > KF5DocToolsMacros.cmake, line 110 > > > > > > Does it work on Windows? (not sure how cmake deals with the different > > separator there). > > Also: the o

Re: Review Request 118004: Fix support for installing files named the same in different directories with kdoctools_install

2014-05-06 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118004/ --- (Updated May 6, 2014, 10:56 a.m.) Review request for Documentation, KDE F

Jenkins build is back to stable : kpty_master_qt5 #38

2014-05-06 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel