Re: Review Request 121065: use correct ki18n_wrap_ui in ki18n based plasma-frameworks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121065/ --- (Updated Nov. 10, 2014, 9:04 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: plasma-framework Description --- see summary Diffs - examples/kpart/CMakeLists.txt ff62817 examples/testcontainmentactionsplugin/CMakeLists.txt cb2cd56 src/tools/port-cmake.sh 4d49e9a Diff: https://git.reviewboard.kde.org/r/121065/diff/ Testing --- builds Thanks, Burkhard Lück ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121066: use correct ki18n_wrap_ui in ki18n based frameworks/kwallet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121066/ --- (Updated Nov. 10, 2014, 9:18 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kwallet Description --- see summary Diffs - src/runtime/kwalletd/CMakeLists.txt 907ef19 Diff: https://git.reviewboard.kde.org/r/121066/diff/ Testing --- builds Thanks, Burkhard Lück ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121067: use correct ki18n_wrap_ui in ki18n based frameworks/knotifyconfig
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121067/ --- (Updated Nov. 10, 2014, 9:21 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: knotifyconfig Description --- see summary Diffs - tests/CMakeLists.txt 8787858 Diff: https://git.reviewboard.kde.org/r/121067/diff/ Testing --- builds Thanks, Burkhard Lück ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121068: use correct ki18n_wrap_ui in ki18n based frameworks/kjsembed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121068/ --- (Updated Nov. 10, 2014, 9:25 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kjsembed Description --- see summary Diffs - examples/kjsconsole/CMakeLists.txt ba98fff Diff: https://git.reviewboard.kde.org/r/121068/diff/ Testing --- builds Thanks, Burkhard Lück ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121090: Move kio-mtp to kio-extras
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121090/ --- Review request for KDE Frameworks, David Faure and Philipp Schmidt. Repository: kio-extras Description --- This patch moves kio-mtp from its frameworks branch to kio-extras. I believe that this kioslave should be with the rest and not alone somewhere without release. I also formatted it a bit to follow kdelibs coding style. Discussion about this move can be found here http://lists.kde.org/?l=kde-develm=141500903106761w=2 Diffs - mtp/kio_mtp_helpers.h PRE-CREATION mtp/kio_mtp_helpers.cpp PRE-CREATION mtp/mtp-network.desktop PRE-CREATION mtp/mtp.protocol PRE-CREATION mtp/solid_mtp.desktop PRE-CREATION mtp/filecache.cpp PRE-CREATION mtp/kio-mtp.kdev4 PRE-CREATION mtp/kio_mtp.h PRE-CREATION mtp/kio_mtp.cpp PRE-CREATION CMakeLists.txt 8f82688 mtp/CMakeLists.txt PRE-CREATION mtp/COPYING PRE-CREATION mtp/LICENCE PRE-CREATION mtp/Messages.sh PRE-CREATION mtp/README PRE-CREATION mtp/devicecache.h PRE-CREATION mtp/devicecache.cpp PRE-CREATION mtp/filecache.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121090/diff/ Testing --- I have tested copying files, creating and removing folders in Dolphin with my Nexus 4 and everything seems to work fine. Thanks, Jan Grulich ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: knewstuff_master_qt5 #111
See http://build.kde.org/job/knewstuff_master_qt5/111/changes Changes: [vonreth] don't recompile exported classes, link to their dll -- [...truncated 121 lines...] Policy CMP0053 is not set: Simplify variable reference and escape sequence evaluation. Run cmake --help-policy CMP0053 for policy details. Use the cmake_policy command to set the policy and suppress this warning. For input: 'QT.@PRI_TARGET_BASENAME@.VERSION = @PROJECT_VERSION_STRING@ QT.@PRI_TARGET_BASENAME@.MAJOR_VERSION = @PROJECT_VERSION_MAJOR@ QT.@PRI_TARGET_BASENAME@.MINOR_VERSION = @PROJECT_VERSION_MINOR@ QT.@PRI_TARGET_BASENAME@.PATCH_VERSION = @PROJECT_VERSION_PATCH@ QT.@PRI_TARGET_BASENAME@.name = @PRI_TARGET_LIBNAME@ QT.@PRI_TARGET_BASENAME@.defines = @PRI_TARGET_DEFINES@ QT.@PRI_TARGET_BASENAME@.includes = @PRI_TARGET_INCLUDES@ QT.@PRI_TARGET_BASENAME@.private_includes = QT.@PRI_TARGET_BASENAME@.libs = @PRI_TARGET_LIBS@ QT.@PRI_TARGET_BASENAME@.depends = @PRI_TARGET_QTDEPS@ ' the old evaluation rules produce: 'QT.KNewStuff.VERSION = 5.5.0 QT.KNewStuff.MAJOR_VERSION = 5 QT.KNewStuff.MINOR_VERSION = 5 QT.KNewStuff.PATCH_VERSION = 0 QT.KNewStuff.name = KF5NewStuff QT.KNewStuff.defines = QT.KNewStuff.includes = /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/knewstuff/inst/include/KF5/KNewStuff QT.KNewStuff.private_includes = QT.KNewStuff.libs = /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/knewstuff/inst/lib64 QT.KNewStuff.depends = widgets Attica KXmlGui ' but the new evaluation rules produce: 'QT.@PRI_TARGET_BASENAME@.VERSION = @PROJECT_VERSION_STRING@ QT.@PRI_TARGET_BASENAME@.MAJOR_VERSION = @PROJECT_VERSION_MAJOR@ QT.@PRI_TARGET_BASENAME@.MINOR_VERSION = @PROJECT_VERSION_MINOR@ QT.@PRI_TARGET_BASENAME@.PATCH_VERSION = @PROJECT_VERSION_PATCH@ QT.@PRI_TARGET_BASENAME@.name = @PRI_TARGET_LIBNAME@ QT.@PRI_TARGET_BASENAME@.defines = @PRI_TARGET_DEFINES@ QT.@PRI_TARGET_BASENAME@.includes = @PRI_TARGET_INCLUDES@ QT.@PRI_TARGET_BASENAME@.private_includes = QT.@PRI_TARGET_BASENAME@.libs = @PRI_TARGET_LIBS@ QT.@PRI_TARGET_BASENAME@.depends = @PRI_TARGET_QTDEPS@ ' Using the old result for compatibility since the policy is not set. Call Stack (most recent call first): src/CMakeLists.txt:96 (ecm_generate_pri_file) This warning is for project developers. Use -Wno-dev to suppress it. -- -- The following REQUIRED packages have been found: * ECM (required version = 1.4.0) * Qt5Core (required version = 5.3.1) * Qt5Gui (required version = 5.3.1) * Qt5Widgets * Qt5Xml * KF5Archive (required version = 5.4.0) * KF5Completion (required version = 5.4.0) * KF5Config (required version = 5.4.0) * KF5CoreAddons (required version = 5.4.0) * Gettext * PythonInterp * KF5I18n (required version = 5.4.0) * KF5IconThemes (required version = 5.4.0) * KF5KIO (required version = 5.4.0) * KF5ItemViews (required version = 5.4.0) * KF5TextWidgets (required version = 5.4.0) * KF5WidgetsAddons (required version = 5.4.0) * KF5XmlGui (required version = 5.4.0) * KF5Attica (required version = 5.4.0) , A Qt library that implements the Open Collaboration Services API , https://projects.kde.org/attica Support for Get Hot New Stuff in KNewStuff * Qt5Test Required for unit tests * Qt5 (required version = 5.2.0) -- Configuring done -- Generating done CMake Warning: Manually-specified variables were not used by the project: KDE4_BUILD_TESTS LIB_SUFFIX SIP_DEFAULT_SIP_DIR -- Build files have been written to: http://build.kde.org/job/knewstuff_master_qt5/ws/build == Commencing the Build Scanning dependencies of target KF5NewStuff_automoc Scanning dependencies of target knewstuffauthortest_automoc Scanning dependencies of target khotnewstuff_upload_automoc Scanning dependencies of target khotnewstuff_automoc Scanning dependencies of target knewstuffentrytest_automoc [ 2%] [ 4%] [ 6%] [ 11%] [ 11%] Automatic moc for target KF5NewStuff Automatic moc for target knewstuffauthortest Automatic moc for target khotnewstuff_upload Automatic moc for target knewstuffentrytest Automatic moc for target khotnewstuff [ 11%] [ 11%] Built target khotnewstuff_upload_automoc Built target khotnewstuff_automoc Generating knewstuffauthortest.moc Generating knewstuffentrytest.moc [ 11%] Built target knewstuffauthortest_automoc [ 11%] Built target knewstuffentrytest_automoc Generating moc_downloadmanager.cpp Generating moc_downloadwidget.cpp Generating moc_uploaddialog.cpp Generating moc_atticaprovider_p.cpp Generating moc_button.cpp Generating moc_cache_p.cpp Generating moc_engine_p.cpp Generating moc_installation_p.cpp Generating moc_provider_p.cpp Generating moc_security_p.cpp Generating moc_xmlloader_p.cpp Generating moc_downloaddialog.cpp Generating moc_staticxmlprovider_p.cpp Generating moc_entrydetailsdialog_p.cpp Generating
Re: Review Request 119607: Support for .hidden files
On Nov. 8, 2014, 10:02 p.m., David Faure wrote:
src/core/kcoredirlister.cpp, line 1241
https://git.reviewboard.kde.org/r/119607/diff/4/?file=313121#file313121line1241
After this line, try adding
if (!url.isLocalFile()) {
const QString localPath = dir-rootItem.localPath();
if (!localPath.isEmpty()) {
filesToHide =
filesInDotHiddenForDir(QUrl::fromLocalFile(localPath));
}
}
This should take care of the case of desktop:/ URLs. Can you test?
Thanks! I'll test it in a few days. I haven't had time to look into this yet.
- Bruno
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119607/#review70102
---
On Set. 18, 2014, 10:06 a.m., Bruno Nova wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119607/
---
(Updated Set. 18, 2014, 10:06 a.m.)
Review request for KDE Frameworks and David Faure.
Bugs: 64740 and 246260
https://bugs.kde.org/show_bug.cgi?id=64740
https://bugs.kde.org/show_bug.cgi?id=246260
Repository: kio
Description
---
This adds support for *.hidden* files to KDE.
When listing a directory, the files/folders listed in the *.hidden* file will
be hidden, unless the user has chosen to show hidden files.
This patch was initially based on the patch provided by Mark in Bug #246260.
Diffs
-
src/core/kcoredirlister.h e6ba2ac
src/core/kcoredirlister.cpp a31d629
src/core/kfileitem.h bebc241
src/core/kfileitem.cpp 74dc069
Diff: https://git.reviewboard.kde.org/r/119607/diff/
Testing
---
Built and tested the patch in Project Neon.
Dolphin was still using KDE4/Qt4 version of the library, so I only tested
using the desktop folder widget, and folder desktop.
It worked correctly when I pointed it to ~ and ~/Desktop (I added
.hidden there).
However, it didn't work when I pointed it to the Desktop folder (the
default option, not the custom location ~/Desktop).
More testing is required.
The version for KDE4/Qt4 submitted to Bug #246260 was tested in Kubuntu
14.04, and it worked everywhere I tested (Dolphin, open/save dialogs, folder
widget and detailed/tree view in Dolphin).
It wasn't an intensive test, though.
Thanks,
Bruno Nova
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KPackage framework
Hi all, since at akademy there seemed the interest in it, I have been working on some classes i extracted from libplasma to be on their own, those related to Plasma::Package, since several applications have the interest of having scriptable or anyways non-binary content shippable over ghns. you can find them in the kpackage repository. there are: KPackage::Package - no API changes from Plasma::Package KPackage::PackageStructure - no API changes from Plasma::PackageStructure KPackage::PackageTrader - loadPackage extracted from Plasma::PluginLoader, plus added a query() method similar to KPluginTrader one. I'm interested to publish the thing as a framework soonish (so then i can start to port the Plasma::Package usage to this) The main thing i would like to get discussed, is that There also seem the interest of trimming its dependencies, since atm it would need to be tier3 due to KService dependency.. It could go down tier2 in this way: * porting all the internal and api use of KPluginInfo to KPluginMetadata * removing all the query functionality, (since it needs KPluginTrader::applyConstraints) and making instead KPluginTrader able to find packages as well Opinions? comments? -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: kio_master_qt5 #434
See http://build.kde.org/job/kio_master_qt5/434/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121093: Revert don't recompile exported classes, link to their dll
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/ --- Review request for KDE Frameworks, Albert Astals Cid, Patrick von Reth, and Jeremy Whiting. Repository: knewstuff Description --- This reverts commit 3ab92282a8909258dc6fa24a3b9d065ee49f8731. This fixes the compile/link errors of the unit tests: Linking CXX executable knewstuffentrytest /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:69: error: undefined reference to 'KNS3::EntryInternal::EntryInternal()' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:70: error: undefined reference to 'KNS3::EntryInternal::setEntryXML(QDomElement const)' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:71: error: undefined reference to 'KNS3::EntryInternal::toEntry() const' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:69: error: undefined reference to 'KNS3::EntryInternal::~EntryInternal()' collect2: error: ld returned 1 exit status and similar. Diffs - autotests/CMakeLists.txt 267f9b1eec47c2cc67106e2ca95f78033f92c86b Diff: https://git.reviewboard.kde.org/r/121093/diff/ Testing --- Compiles again and tests pass. Patrick, was this before an issue on Windows or why did you push this change? See also https://git.reviewboard.kde.org/r/120592/ Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121093: Revert don't recompile exported classes, link to their dll
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/#review70185 --- Yes as the files include export macros compiling them into an another lib/exe will break the build. As those where already part of a dll I thought I could just link the dll. I tested it on Windows and it build fine. What was the isseu on linux? - Patrick von Reth On Nov. 10, 2014, 1:50 p.m., Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/ --- (Updated Nov. 10, 2014, 1:50 p.m.) Review request for KDE Frameworks, Albert Astals Cid, Patrick von Reth, and Jeremy Whiting. Repository: knewstuff Description --- This reverts commit 3ab92282a8909258dc6fa24a3b9d065ee49f8731. This fixes the compile/link errors of the unit tests: Linking CXX executable knewstuffentrytest /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:69: error: undefined reference to 'KNS3::EntryInternal::EntryInternal()' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:70: error: undefined reference to 'KNS3::EntryInternal::setEntryXML(QDomElement const)' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:71: error: undefined reference to 'KNS3::EntryInternal::toEntry() const' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:69: error: undefined reference to 'KNS3::EntryInternal::~EntryInternal()' collect2: error: ld returned 1 exit status and similar. Diffs - autotests/CMakeLists.txt 267f9b1eec47c2cc67106e2ca95f78033f92c86b Diff: https://git.reviewboard.kde.org/r/121093/diff/ Testing --- Compiles again and tests pass. Patrick, was this before an issue on Windows or why did you push this change? See also https://git.reviewboard.kde.org/r/120592/ Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121093: Revert don't recompile exported classes, link to their dll
On Nov. 10, 2014, 2:05 p.m., Patrick von Reth wrote: Yes as the files include export macros compiling them into an another lib/exe will break the build. As those where already part of a dll I thought I could just link the dll. I tested it on Windows and it build fine. What was the isseu on linux? The `_p.h` files do not contain export macros. I showed you some of the build errors above. - Milian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/#review70185 --- On Nov. 10, 2014, 1:50 p.m., Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/ --- (Updated Nov. 10, 2014, 1:50 p.m.) Review request for KDE Frameworks, Albert Astals Cid, Patrick von Reth, and Jeremy Whiting. Repository: knewstuff Description --- This reverts commit 3ab92282a8909258dc6fa24a3b9d065ee49f8731. This fixes the compile/link errors of the unit tests: Linking CXX executable knewstuffentrytest /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:69: error: undefined reference to 'KNS3::EntryInternal::EntryInternal()' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:70: error: undefined reference to 'KNS3::EntryInternal::setEntryXML(QDomElement const)' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:71: error: undefined reference to 'KNS3::EntryInternal::toEntry() const' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:69: error: undefined reference to 'KNS3::EntryInternal::~EntryInternal()' collect2: error: ld returned 1 exit status and similar. Diffs - autotests/CMakeLists.txt 267f9b1eec47c2cc67106e2ca95f78033f92c86b Diff: https://git.reviewboard.kde.org/r/121093/diff/ Testing --- Compiles again and tests pass. Patrick, was this before an issue on Windows or why did you push this change? See also https://git.reviewboard.kde.org/r/120592/ Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121093: Revert don't recompile exported classes, link to their dll
On Nov. 10, 2014, 2:05 p.m., Patrick von Reth wrote: Yes as the files include export macros compiling them into an another lib/exe will break the build. As those where already part of a dll I thought I could just link the dll. I tested it on Windows and it build fine. What was the isseu on linux? Milian Wolff wrote: The `_p.h` files do not contain export macros. I showed you some of the build errors above. Ok the problem on windows is that all other files contain exports ^^ - Patrick --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/#review70185 --- On Nov. 10, 2014, 1:50 p.m., Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/ --- (Updated Nov. 10, 2014, 1:50 p.m.) Review request for KDE Frameworks, Albert Astals Cid, Patrick von Reth, and Jeremy Whiting. Repository: knewstuff Description --- This reverts commit 3ab92282a8909258dc6fa24a3b9d065ee49f8731. This fixes the compile/link errors of the unit tests: Linking CXX executable knewstuffentrytest /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:69: error: undefined reference to 'KNS3::EntryInternal::EntryInternal()' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:70: error: undefined reference to 'KNS3::EntryInternal::setEntryXML(QDomElement const)' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:71: error: undefined reference to 'KNS3::EntryInternal::toEntry() const' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:69: error: undefined reference to 'KNS3::EntryInternal::~EntryInternal()' collect2: error: ld returned 1 exit status and similar. Diffs - autotests/CMakeLists.txt 267f9b1eec47c2cc67106e2ca95f78033f92c86b Diff: https://git.reviewboard.kde.org/r/121093/diff/ Testing --- Compiles again and tests pass. Patrick, was this before an issue on Windows or why did you push this change? See also https://git.reviewboard.kde.org/r/120592/ Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121090: Move kio-mtp to kio-extras
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121090/#review70188 --- +1 makes sense to me. - Aleix Pol Gonzalez On Nov. 10, 2014, 9:30 a.m., Jan Grulich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121090/ --- (Updated Nov. 10, 2014, 9:30 a.m.) Review request for KDE Frameworks, David Faure and Philipp Schmidt. Repository: kio-extras Description --- This patch moves kio-mtp from its frameworks branch to kio-extras. I believe that this kioslave should be with the rest and not alone somewhere without release. I also formatted it a bit to follow kdelibs coding style. Discussion about this move can be found here http://lists.kde.org/?l=kde-develm=141500903106761w=2 Diffs - mtp/kio_mtp_helpers.h PRE-CREATION mtp/kio_mtp_helpers.cpp PRE-CREATION mtp/mtp-network.desktop PRE-CREATION mtp/mtp.protocol PRE-CREATION mtp/solid_mtp.desktop PRE-CREATION mtp/filecache.cpp PRE-CREATION mtp/kio-mtp.kdev4 PRE-CREATION mtp/kio_mtp.h PRE-CREATION mtp/kio_mtp.cpp PRE-CREATION CMakeLists.txt 8f82688 mtp/CMakeLists.txt PRE-CREATION mtp/COPYING PRE-CREATION mtp/LICENCE PRE-CREATION mtp/Messages.sh PRE-CREATION mtp/README PRE-CREATION mtp/devicecache.h PRE-CREATION mtp/devicecache.cpp PRE-CREATION mtp/filecache.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121090/diff/ Testing --- I have tested copying files, creating and removing folders in Dolphin with my Nexus 4 and everything seems to work fine. Thanks, Jan Grulich ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121093: Revert don't recompile exported classes, link to their dll
On Nov. 10, 2014, 2:05 p.m., Patrick von Reth wrote: Yes as the files include export macros compiling them into an another lib/exe will break the build. As those where already part of a dll I thought I could just link the dll. I tested it on Windows and it build fine. What was the isseu on linux? Milian Wolff wrote: The `_p.h` files do not contain export macros. I showed you some of the build errors above. Patrick von Reth wrote: Ok the problem on windows is that all other files contain exports ^^ So how do we fix this then? Maybe just by defining `KNEWSTUFF_STATIC_DEFINE` which should make the defines empty. I'll try this out and update this patch - could you try it out then? - Milian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/#review70185 --- On Nov. 10, 2014, 1:50 p.m., Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/ --- (Updated Nov. 10, 2014, 1:50 p.m.) Review request for KDE Frameworks, Albert Astals Cid, Patrick von Reth, and Jeremy Whiting. Repository: knewstuff Description --- This reverts commit 3ab92282a8909258dc6fa24a3b9d065ee49f8731. This fixes the compile/link errors of the unit tests: Linking CXX executable knewstuffentrytest /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:69: error: undefined reference to 'KNS3::EntryInternal::EntryInternal()' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:70: error: undefined reference to 'KNS3::EntryInternal::setEntryXML(QDomElement const)' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:71: error: undefined reference to 'KNS3::EntryInternal::toEntry() const' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:69: error: undefined reference to 'KNS3::EntryInternal::~EntryInternal()' collect2: error: ld returned 1 exit status and similar. Diffs - autotests/CMakeLists.txt 267f9b1eec47c2cc67106e2ca95f78033f92c86b Diff: https://git.reviewboard.kde.org/r/121093/diff/ Testing --- Compiles again and tests pass. Patrick, was this before an issue on Windows or why did you push this change? See also https://git.reviewboard.kde.org/r/120592/ Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121093: Revert don't recompile exported classes, link to their dll
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/ --- (Updated Nov. 10, 2014, 2:22 p.m.) Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstuff Description (updated) --- The `*_p.h` files do not have any export macros. Instead we now set -DKNEWSTUFF_STATIC_DEFINE which should prevent the export macros from expanding to anything even on Windows. This fixes the compile error for me: This fixes the compile/link errors of the unit tests: Linking CXX executable knewstuffentrytest /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:69: error: undefined reference to 'KNS3::EntryInternal::EntryInternal()' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:70: error: undefined reference to 'KNS3::EntryInternal::setEntryXML(QDomElement const)' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:71: error: undefined reference to 'KNS3::EntryInternal::toEntry() const' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:69: error: undefined reference to 'KNS3::EntryInternal::~EntryInternal()' collect2: error: ld returned 1 exit status and similar. The tests compile again and work properly. This reverts commit 3ab92282a8909258dc6fa24a3b9d065ee49f8731. Diffs (updated) - autotests/CMakeLists.txt 267f9b1eec47c2cc67106e2ca95f78033f92c86b Diff: https://git.reviewboard.kde.org/r/121093/diff/ Testing --- Compiles again and tests pass. Patrick, was this before an issue on Windows or why did you push this change? See also https://git.reviewboard.kde.org/r/120592/ Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121093: Revert don't recompile exported classes, link to their dll
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/ --- (Updated Nov. 10, 2014, 2:23 p.m.) Review request for KDE Frameworks, Albert Astals Cid, Patrick von Reth, and Jeremy Whiting. Repository: knewstuff Description --- The `*_p.h` files do not have any export macros. Instead we now set -DKNEWSTUFF_STATIC_DEFINE which should prevent the export macros from expanding to anything even on Windows. This fixes the compile error for me: This fixes the compile/link errors of the unit tests: Linking CXX executable knewstuffentrytest /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:69: error: undefined reference to 'KNS3::EntryInternal::EntryInternal()' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:70: error: undefined reference to 'KNS3::EntryInternal::setEntryXML(QDomElement const)' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:71: error: undefined reference to 'KNS3::EntryInternal::toEntry() const' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:69: error: undefined reference to 'KNS3::EntryInternal::~EntryInternal()' collect2: error: ld returned 1 exit status and similar. The tests compile again and work properly. This reverts commit 3ab92282a8909258dc6fa24a3b9d065ee49f8731. Diffs - autotests/CMakeLists.txt 267f9b1eec47c2cc67106e2ca95f78033f92c86b Diff: https://git.reviewboard.kde.org/r/121093/diff/ Testing --- Compiles again and tests pass. Patrick, was this before an issue on Windows or why did you push this change? See also https://git.reviewboard.kde.org/r/120592/ Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121093: Revert don't recompile exported classes, link to their dll
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/#review70191 --- Ship it! Ship It! - Patrick von Reth On Nov. 10, 2014, 2:23 p.m., Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/ --- (Updated Nov. 10, 2014, 2:23 p.m.) Review request for KDE Frameworks, Albert Astals Cid, Patrick von Reth, and Jeremy Whiting. Repository: knewstuff Description --- The `*_p.h` files do not have any export macros. Instead we now set -DKNEWSTUFF_STATIC_DEFINE which should prevent the export macros from expanding to anything even on Windows. This fixes the compile error for me: This fixes the compile/link errors of the unit tests: Linking CXX executable knewstuffentrytest /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:69: error: undefined reference to 'KNS3::EntryInternal::EntryInternal()' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:70: error: undefined reference to 'KNS3::EntryInternal::setEntryXML(QDomElement const)' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:71: error: undefined reference to 'KNS3::EntryInternal::toEntry() const' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:69: error: undefined reference to 'KNS3::EntryInternal::~EntryInternal()' collect2: error: ld returned 1 exit status and similar. The tests compile again and work properly. This reverts commit 3ab92282a8909258dc6fa24a3b9d065ee49f8731. Diffs - autotests/CMakeLists.txt 267f9b1eec47c2cc67106e2ca95f78033f92c86b Diff: https://git.reviewboard.kde.org/r/121093/diff/ Testing --- Compiles again and tests pass. Patrick, was this before an issue on Windows or why did you push this change? See also https://git.reviewboard.kde.org/r/120592/ Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121093: Revert don't recompile exported classes, link to their dll
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/ --- (Updated Nov. 10, 2014, 2:36 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Albert Astals Cid, Patrick von Reth, and Jeremy Whiting. Repository: knewstuff Description --- The `*_p.h` files do not have any export macros. Instead we now set -DKNEWSTUFF_STATIC_DEFINE which should prevent the export macros from expanding to anything even on Windows. This fixes the compile error for me: This fixes the compile/link errors of the unit tests: Linking CXX executable knewstuffentrytest /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:69: error: undefined reference to 'KNS3::EntryInternal::EntryInternal()' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:70: error: undefined reference to 'KNS3::EntryInternal::setEntryXML(QDomElement const)' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:71: error: undefined reference to 'KNS3::EntryInternal::toEntry() const' /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:69: error: undefined reference to 'KNS3::EntryInternal::~EntryInternal()' collect2: error: ld returned 1 exit status and similar. The tests compile again and work properly. This reverts commit 3ab92282a8909258dc6fa24a3b9d065ee49f8731. Diffs - autotests/CMakeLists.txt 267f9b1eec47c2cc67106e2ca95f78033f92c86b Diff: https://git.reviewboard.kde.org/r/121093/diff/ Testing --- Compiles again and tests pass. Patrick, was this before an issue on Windows or why did you push this change? See also https://git.reviewboard.kde.org/r/120592/ Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : knewstuff_master_qt5 #112
See http://build.kde.org/job/knewstuff_master_qt5/112/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to stable : kio_master_qt5 #435
See http://build.kde.org/job/kio_master_qt5/435/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121095/ --- Review request for KDE Frameworks. Repository: frameworkintegration Description --- This patch is related to /r/121094, which moves KTextToHTML conversion utility from KPimUtils to KCoreAddons. Since KCoreAddons can't depend on KEmoticons needed for smileys conversion, I added the actual KEmoticons code here, to create a run-time dependency, similar to the KWidgetsAddons-KConfig dependency for KMessageBox. This patch refactors the FrameworkIntegrationPlugin a bit - I split the KMessageBox-specific code into a separate file, and added a new file with the KTextToHTMLEmoticonsInterface implementation, as we can't just keep stacking more and more classes into a single file :-) Diffs - CMakeLists.txt 3721bfa src/integrationplugin/CMakeLists.txt 3395368 src/integrationplugin/frameworkintegrationplugin.h 6dc6825 src/integrationplugin/frameworkintegrationplugin.cpp a45ba9d src/integrationplugin/kmessagebox.h PRE-CREATION src/integrationplugin/kmessagebox.cpp PRE-CREATION src/integrationplugin/ktexttohtml.h PRE-CREATION src/integrationplugin/ktexttohtml.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121095/diff/ Testing --- Tested with KTextToHTML code from /r/121094 in a QGuiApplication and it seems to work. Thanks, Dan Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext - HTML conversion
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121094/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description --- This class comes from KPimUtils::LinkLocator from kdepimlibs.git. This class takes plaintext string, and converts it to HTML while perserving spacing, converting URLs and email addresses into a href... links and interpreting highligting markup (*bold*, _underline_, /italic/) and wrapping it to corresponding HTML tags. It can also convert text emoticons into img smileys. The last - emoticons conversion - depends on KEmoticons, which we can't use directly from KCoreAddons, so I moved the actual KEmoticons code into FrameworkIntegration plugin. There is a dummy implementation provided by default in KCoreAddons that is loaded when the FrameworkIntegration plugin is not available, or when the application is only a QCoreApplication (since KEmoticons require QGuiApplication, so we must not load the plugin). The dummy implementation does nothing and returns the original string unaltered. The reason for moving the class from KPimUtils is that KPimUtils is going to die, and while we could make this internal to KDE PIM, I think this is a rather useful code, that can be used by many applications that need to deal with 3rd party text data and want to provide user-friendly clickable links. If you compare this with the original KPimUtils::LinkLocator you find, that I removed all public API except for the convertToHTML method. This is because the remaining methods (getUrl, getEmailAddress) depend on the actual state of the LinkLocator object, but LinkLocator provides no API for step-by-step parsing, so they were actually useless for public use. For that reason I decided to only publish the convertToHTML method, and hide the remaining methods as internal methods of the KTextToHTMLHelper (useful for unit-testing). This patch also contains a unit-test from KPimUtils. Diffs - autotests/ktexttohtmltest.cpp PRE-CREATION src/lib/CMakeLists.txt 1dc5627 src/lib/text/ktexttohtml.h PRE-CREATION src/lib/text/ktexttohtml.cpp PRE-CREATION src/lib/text/ktexttohtml_p.h PRE-CREATION src/lib/text/ktexttohtmlemoticonsinterface.h PRE-CREATION autotests/CMakeLists.txt d5a5feb autotests/ktexttohtmltest.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121094/diff/ Testing --- Unit test passes Thanks, Dan Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121098: Restore filedialog functionality for modal dialogs.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121098/ --- Review request for KDE Frameworks and Eike Hein. Repository: frameworkintegration Description --- Before David's astyle commit, the show method used to call m_dialog-exec if the window flags weren't nonmodal (i.e. modal dialogs). This got removed somehow. BUG:334963 Diffs - src/platformtheme/kdeplatformfiledialoghelper.cpp 44eca192946f0da2b357b33e93a57ef0de05135b Diff: https://git.reviewboard.kde.org/r/121098/diff/ Testing --- fifteen puzzle config with patch from https://git.reviewboard.kde.org/r/121097/ now shows the dialog and lets you choose a file. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: How to port KTabBar::mouseMiddleClick?
2014-11-09 7:28 GMT-03:00 Frank Reininghaus frank7...@googlemail.com: Hi, 2014-11-06 2:59 GMT+01:00 Milian Wolff: Hey all, what do I do to get middle-click-closes-tab in Qt 5 without KTabBar? Previously, we used KTabBar and its mouseMiddleClick signal. AFAIK, currently the only solution is to subclass QTabBar, override the mousePressEvent method and emit a signal from there. Dolphin uses this approach. There were many other reasons why Emmanuel created a custom QTabBar subclass for Dolphin though . If many apps need the middle click to close bevavior, then reanimating KTabBar or getting this functionality into QTabBar might be better than making every app create its own tab bar class. Or maybe contribute mouseMiddleClick to QTabBar? (I'm not volunteering :P) -- Nicolás ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KPackage framework
On Monday 10 November 2014, Marco Martin wrote: * porting all the internal and api use of KPluginInfo to KPluginMetadata * removing all the query functionality, (since it needs KPluginTrader::applyConstraints) and making instead KPluginTrader able to find packages as well Opinions? comments? in the branch mart/kpluginmetadata there is an experiment in porting away from kservice, tough if i go all the way it should have a complete own copy of the plugin indexing (and indexing tool) since if it doesn't depend from kservice it should be completely independent from it -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121080/#review70214 --- lib/konq/src/konq_historyentry.h https://git.reviewboard.kde.org/r/121080/#comment49091 Just wondering: the place I found in Qt which does something similar (dummy qHash for MSVC), doesn't have any ifdef: qitemselectionmodel.h. Any idea why we have one here? It seems to me that this is useful for both the lib and the app, since they both see the QListKonqHistoryEntry (whose toSet method requires a qHash implementation) lib/konq/src/konq_historyentry.h https://git.reviewboard.kde.org/r/121080/#comment49092 const ref, no? - David Faure On Nov. 8, 2014, 10:26 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121080/ --- (Updated Nov. 8, 2014, 10:26 p.m.) Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository: kde-baseapps Description --- Since we're not using kdemacros.h here anymore, KDE_DUMMY_QHASH_FUNCTION is not available. Implement it instead. Diffs - lib/konq/src/konq_historyentry.h de34d6b Diff: https://git.reviewboard.kde.org/r/121080/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120605: cleanup overlay icon usage
On Nov. 1, 2014, 12:38 p.m., Emmanuel Pescosta wrote: Ping? No git account? Albert Astals Cid wrote: He does have an account as you can see in http://websvn.kde.org/trunk/kde-common/accounts?view=markup But you can still commit it yourself, don't forget to use --author in the git commit line and that's it :) Stefan Brüns wrote: Sorry, completely forgot about it. Are both KF5 and SC4 currently open? Yes, go ahead. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120605/#review69638 --- On Oct. 16, 2014, 3:32 p.m., Stefan Brüns wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120605/ --- (Updated Oct. 16, 2014, 3:32 p.m.) Review request for KDE Frameworks. Bugs: 339193 https://bugs.kde.org/show_bug.cgi?id=339193 Repository: kio Description --- The locked overlay should be added also for directories, as there is no distinct unreadable directory icon. No overlay icon for gzip files with .gz file ending, there is a mimetype icon for gzip files. BUGS: 339193 Signed-off-by: Stefan Brüns stefan.bru...@rwth-aachen.de Diffs - src/core/kfileitem.cpp 74dc069dc964f4fb0040a3dab916ff0d1e26602c Diff: https://git.reviewboard.kde.org/r/120605/diff/ Testing --- Patched kio, see BR for new screenshot Thanks, Stefan Brüns ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Split kde-baseapps?
On Thursday 06 November 2014 10:59:38 David Narvaez wrote: On Sat, Oct 25, 2014 at 3:06 PM, David Narvaez david.narv...@computer.org wrote: It's also used by Rekonq and anything building a web browser using KDE software, it should really go to kioslave-extras. Any feedback on this? If it will not be moved to kioslave-extras I need to patch Rekonq to stop annoying me about the missing about protocol. If it's useful to share it, let's share it, I have no objection to that. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/#review70220 --- Ship it! src/services/kplugininfo.cpp https://git.reviewboard.kde.org/r/120198/#comment49093 Missing static before inline, if these methods are only used in this .cpp file. - David Faure On Nov. 7, 2014, 4:38 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/ --- (Updated Nov. 7, 2014, 4:38 p.m.) Review request for KDE Frameworks. Repository: kservice Description --- A series of 4 commits: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage This means that KPluginInfo can now simply reuse the QJsonObject returned by QPluginLoader.metaData() (by storing it in a KPluginMetaData object instead of having to convert the JSON to a QVariantMap first. Additionally this allows very efficient conversion between KPluginInfo and KPluginMetaData. --- Add compatibility key names to KPluginInfo::property() --- KPluginInfo: Fix loading JSON metadata that only has compatibility keys This can be removed in KF6, but for now allows loading all both old style as well as new style metadata kplugininfotest: also test objects constructed from JSON This tests both new style JSON as well as JSON using the old key names Diffs - src/services/kplugininfo.cpp 54593e57ca2b898a7d68de2915b7e40c3aa96f5f autotests/CMakeLists.txt 913e848ba5d1754ef7726f92604d1aaa398fa107 autotests/kplugininfotest.cpp 9d4ee046db1e5d0b9f30a9a68929147763ee1cfa src/services/kplugininfo.h 871d6a2ead5a9b358d864372152cbfa0c43d8a68 Diff: https://git.reviewboard.kde.org/r/120198/diff/ Testing --- All unit tests still work Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
OSX/CI: kde-baseapps fails to build on branch master
After recent changes to kde-baseapps there is still some usage of KLineEdit left in the sources: [ 91%] Building CXX object dolphin/src/CMakeFiles/kdeinit_dolphin.dir/settings/general/confirmationssettingspage.cpp.o /Users/marko/WC/KDECI-builds/kde-baseapps/dolphin/src/search/dolphinsearchbox.cpp:77:18: error: member access into incomplete type 'KLineEdit' m_searchInput-setText(text); ^ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage
On Nov. 10, 2014, 9:57 nachm., David Faure wrote: src/services/kplugininfo.cpp, line 47 https://git.reviewboard.kde.org/r/120198/diff/3/?file=326715#file326715line47 Missing static before inline, if these methods are only used in this .cpp file. I put it all in an anonymous namespace as Milian suggested. Should be equivalent to marking them as static. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/#review70220 --- On Nov. 7, 2014, 4:38 nachm., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/ --- (Updated Nov. 7, 2014, 4:38 nachm.) Review request for KDE Frameworks. Repository: kservice Description --- A series of 4 commits: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage This means that KPluginInfo can now simply reuse the QJsonObject returned by QPluginLoader.metaData() (by storing it in a KPluginMetaData object instead of having to convert the JSON to a QVariantMap first. Additionally this allows very efficient conversion between KPluginInfo and KPluginMetaData. --- Add compatibility key names to KPluginInfo::property() --- KPluginInfo: Fix loading JSON metadata that only has compatibility keys This can be removed in KF6, but for now allows loading all both old style as well as new style metadata kplugininfotest: also test objects constructed from JSON This tests both new style JSON as well as JSON using the old key names Diffs - src/services/kplugininfo.cpp 54593e57ca2b898a7d68de2915b7e40c3aa96f5f autotests/CMakeLists.txt 913e848ba5d1754ef7726f92604d1aaa398fa107 autotests/kplugininfotest.cpp 9d4ee046db1e5d0b9f30a9a68929147763ee1cfa src/services/kplugininfo.h 871d6a2ead5a9b358d864372152cbfa0c43d8a68 Diff: https://git.reviewboard.kde.org/r/120198/diff/ Testing --- All unit tests still work Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120605: cleanup overlay icon usage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120605/ --- (Updated Nov. 11, 2014, midnight) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Bugs: 339193 https://bugs.kde.org/show_bug.cgi?id=339193 Repository: kio Description --- The locked overlay should be added also for directories, as there is no distinct unreadable directory icon. No overlay icon for gzip files with .gz file ending, there is a mimetype icon for gzip files. BUGS: 339193 Signed-off-by: Stefan Brüns stefan.bru...@rwth-aachen.de Diffs - src/core/kfileitem.cpp 74dc069dc964f4fb0040a3dab916ff0d1e26602c Diff: https://git.reviewboard.kde.org/r/120605/diff/ Testing --- Patched kio, see BR for new screenshot Thanks, Stefan Brüns ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121099: Fix kautosave doesn't work with more than 1 file per application.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121099/ --- Review request for KDE Frameworks and David Faure. Repository: kcoreaddons Description --- kautosave doesn't work when any app tries to use a second filename, because it doesn't filter on filename. The unit tests can be droppped into master to show the problem, if you remove the include on line 21. This patch: 1. Adds unit tests to test more behavior mentioned in the header. 2. Fixes kautosave working with multple files per application. 3. Fixes filenaming brittleness, which would cause kautosave to randomly fail when the last 3 randomly generated characters in the filename matched any 3 consequtive chracters in the managed filename. Original patch by Andreas Xavier (https://git.reviewboard.kde.org/r/119530) Items from original review have been fixed. Diffs - src/lib/io/kautosavefile_p.cpp PRE-CREATION autotests/kautosavefiletest.h cf70f4c6a4e1f093c431eff6ff25e6f510e84a53 autotests/kautosavefiletest.cpp ec0309e5fda95e01bbed31bd2fe91f9b7a48bec0 src/lib/CMakeLists.txt 1dc56270ab5157af706b7745cfa88ae11e16184a src/lib/io/kautosavefile.h 05cc3aedc248665c8727ade3b86b524275c013ca src/lib/io/kautosavefile.cpp 13a13d7cfb26194be3edf7cbdcd1d39309b79465 src/lib/io/kautosavefile_p.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121099/diff/ Testing --- It builds and the test passes. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kde-baseapps fails to build on branch master
On Mon, Nov 10, 2014 at 11:12 PM, Marko Käning mk-li...@email.de wrote: After recent changes to kde-baseapps there is still some usage of KLineEdit left in the sources: [ 91%] Building CXX object dolphin/src/CMakeFiles/kdeinit_dolphin.dir/settings/general/confirmationssettingspage.cpp.o /Users/marko/WC/KDECI-builds/kde-baseapps/dolphin/src/search/dolphinsearchbox.cpp:77:18: error: member access into incomplete type 'KLineEdit' m_searchInput-setText(text); ^ Try adding a #include KLineEdit on top of the file, with the rest of the includes. Should solve the issue. If it does, then it should be there. Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121100: Add qCDebug statements back into knewstuff sources.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121100/ --- Review request for KDE Frameworks. Repository: knewstuff Description --- Add qCDebug statements back into knewstuff sources. Diffs - tests/knewstuff2_standard.cpp e44628b549ea5ad3b002c3a11eac298b92b5a6ae tests/khotnewstuff.cpp 1aba7de48a8b7cf7f8886957fc473bf0cc631a13 tests/knewstuff2_cache.cpp e7e8a48666237f468d986e99a8c472fe37fd7a77 tests/knewstuff2_download.cpp 39d756e30f5b4f56f9254ae1e08c0d8310daf4d1 src/staticxml/staticxmlprovider.cpp 434ecef0b71543bf4504c9781d1d3a21b9cf6e34 src/ui/entrydetailsdialog.cpp 8a36d33f9a390a211313b11fba65030261a54446 src/ui/itemsgridviewdelegate.cpp 19ddc59eb4acbb2b7a591119453be407d01d9a9f src/ui/itemsmodel.cpp 0254e88a5c16a2f8c5818a45bb7ec28eef4973e8 src/ui/itemsviewbasedelegate.cpp 5137beb93ee8cccd15b28b9a9f47eff60fc17fc8 src/ui/itemsviewdelegate.cpp 5e9b985cc155d141664a944b3d2bd1e751d96136 src/uploaddialog.cpp 1a087b30a7fc6198062f0f7a012ae37ed6f396af src/core/engine.cpp 017154323cfd3f48fc61c0c705d4842f3c2f94a4 src/core/entryinternal.cpp d3af619e9908b2f9e6176c7c87eda44897e93f0a src/core/installation.cpp d8de905bd2d19d098fb08a64897f5617f04e996d src/core/upload.cpp 166e69417b687fef6e89ef7fb5c383ec478c5c2d src/core/xmlloader.cpp 2cee02b66f8ec2a0f1fc407aaadd0ea397b89939 src/downloadmanager.cpp 60d0d37ef0bd35efdcfe5e6ac58fefb3a2ce9954 src/downloadwidget.cpp 358bb8b5222ac596dd3f0025778cd2721c1f3120 src/entry.h df3095e3f75d2f6ca15daf9e87172990214d6352 src/entry.cpp 48a92a7db04eec9b7b1b824841c95c280f31fab7 autotests/knewstuffentrytest.cpp bf55f063dc8cb0b0984fdc73501a13107241a75a src/attica/atticaprovider.cpp 7103b59d62de468ba0c21a6b6260e5befc8575a2 src/core/cache.cpp 3ba6cb4f4d344781d7b95c966d0a0643777e1e6a tests/knewstuff2_test.cpp ee2ead451be06854ea65ee9128231d37b118355c Diff: https://git.reviewboard.kde.org/r/121100/diff/ Testing --- Builds and works still, more debug output filterable with the kanagram logging category. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kde-baseapps fails to build on branch master
On Tue, Nov 11, 2014 at 8:02 AM, Aleix Pol aleix...@kde.org wrote: Try adding a #include KLineEdit on top of the file, with the rest of the includes. Should solve the issue. If it does, then it should be there. Yet another #ifdef problem.. this seems to happen only if baloo is not available, (Mac OS/X) 7ed7cd97d084364d8ee61b35f5ffa3630c5277a4 is commit which introduced problem Adding Emmanuel Pescosta to CC. -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
