Re: Review Request 121599: Fix crash in KIO due to exposing inconsistent views of internal data.

2015-04-18 Thread Simeon Bird
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121599/#review79194 --- Hi everyone, Sorry to bother you, but may I please commit th

Re: Review Request 123421: [KNewStuff] Use KDE_INSTALL_DATADIR_KF5 instead of DATA_INSTALL_DIR for future co-installability

2015-04-18 Thread Hrvoje Senjan
> On April 18, 2015, 11:29 p.m., Gregor Mi wrote: > > Ship It! > > Gregor Mi wrote: > Thanks for also taking care of the commments/documentation. There is some > more, which I will do later. Ok, founds some other references to old location and adjusted them also. Please check the commit me

Re: Review Request 123421: [KNewStuff] Use KDE_INSTALL_DATADIR_KF5 instead of DATA_INSTALL_DIR for future co-installability

2015-04-18 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123421/ --- (Updated April 19, 2015, 1:24 a.m.) Status -- This change has been m

Re: Review Request 123421: [KNewStuff] Use KDE_INSTALL_DATADIR_KF5 instead of DATA_INSTALL_DIR for future co-installability

2015-04-18 Thread Gregor Mi
> On April 18, 2015, 9:29 p.m., Gregor Mi wrote: > > Ship It! Thanks for also taking care of the commments/documentation. There is some more, which I will do later. - Gregor --- This is an automatically generated e-mail. To reply, visi

Re: KDateTimeEdit is broken (but unused)

2015-04-18 Thread Albert Astals Cid
El Dissabte, 18 d'abril de 2015, a les 23:21:59, David Faure va escriure: > Hi John, > > In a KDateTimeEdit, changing the date in the date combo (whether by typing > or selecting e.g. "next month" in the popupmenu), does NOT change the value > of date(), which uses its own member variable, unaffec

KDateTimeEdit is broken (but unused)

2015-04-18 Thread David Faure
Hi John, In a KDateTimeEdit, changing the date in the date combo (whether by typing or selecting e.g. "next month" in the popupmenu), does NOT change the value of date(), which uses its own member variable, unaffected by user interaction. (tested in the kdelibs KDE/4.14 branch, I suppose framew

Re: Review Request 123421: [KNewStuff] Use KDE_INSTALL_DATADIR_KF5 instead of DATA_INSTALL_DIR for future co-installability

2015-04-18 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123421/#review79182 --- Ship it! Ship It! - Gregor Mi On April 18, 2015, 7:45 p.m.

Re: stable-KF5-QT5 QT version...

2015-04-18 Thread Scarlett Clark
On Sunday, April 19, 2015 08:24:41 AM Ben Cooksley wrote: > On Sun, Apr 19, 2015 at 7:53 AM, Albert Astals Cid wrote: > > El Dissabte, 18 d'abril de 2015, a les 08:17:16, Scarlett Clark va escriure: > >> Applications are falling over because: > >> > >> 15:09:51 CMake Error at CMakeLists.txt:28

Re: Review Request 123421: [KNewStuff] Use KDE_INSTALL_DATADIR_KF5 instead of DATA_INSTALL_DIR for future co-installability

2015-04-18 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123421/#review79181 --- This looks right to me, but it's Gregor's stuff (KMoreTools) s

Re: stable-KF5-QT5 QT version...

2015-04-18 Thread Jan Kundrát
On Saturday, 18 April 2015 17:17:16 CEST, Scarlett Clark wrote: "qt5": { "kf5-qt5": "5.4.1", "stable-kf5-qt5": "5.3.2" }, The impression which I got in my earlier inquiries about this topic was that there's no KDE-wide consensus on which Qt5 version is t

Re: stable-KF5-QT5 QT version...

2015-04-18 Thread Ben Cooksley
On Sun, Apr 19, 2015 at 7:53 AM, Albert Astals Cid wrote: > El Dissabte, 18 d'abril de 2015, a les 08:17:16, Scarlett Clark va escriure: >> Applications are falling over because: >> >> 15:09:51 CMake Error at CMakeLists.txt:28 (find_package): >> 15:09:51 Could not find a configuration file for p

Re: Review Request 123419: CodingStyle for autotests

2015-04-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123419/#review79179 --- Ship it! Looks ok but it's strange to quote a wiki page calle

Re: stable-KF5-QT5 QT version...

2015-04-18 Thread Albert Astals Cid
El Dissabte, 18 d'abril de 2015, a les 08:17:16, Scarlett Clark va escriure: > Applications are falling over because: > > 15:09:51 CMake Error at CMakeLists.txt:28 (find_package): > 15:09:51 Could not find a configuration file for package "Qt5" that is > compatible > 15:09:51 with requested ve

Review Request 123421: [KNewStuff] Use KDE_INSTALL_DATADIR_KF5 instead of DATA_INSTALL_DIR for future co-installability

2015-04-18 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123421/ --- Review request for KDE Frameworks, Gregor Mi and Jeremy Whiting. Reposito

Re: Review Request 123417: Prevent plasmashell from crashing on wayland

2015-04-18 Thread Nerdopolis Turfwalker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123417/ --- (Updated April 18, 2015, 5:19 p.m.) Review request for KDE Frameworks.

Review Request 123419: CodingStyle for autotests

2015-04-18 Thread Guy Maurel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123419/ --- Review request for KDE Frameworks, Mario Bensi and David Faure. Repositor

Re: stable-KF5-QT5 QT version...

2015-04-18 Thread Marko Käning
Hi Scarlett, On 18 Apr 2015, at 17:17 , Scarlett Clark wrote: > 15:09:51 with requested version "5.4.0”. this is not a matter of whether apps use stable-kf5-qt5 or kf5-qt5 branch groups, it is just about the notion devs have about requirements to be expected for stable-kf5-qt5. And this is cl

stable-KF5-QT5 QT version...

2015-04-18 Thread Scarlett Clark
Applications are falling over because: 15:09:51 CMake Error at CMakeLists.txt:28 (find_package): 15:09:51 Could not find a configuration file for package "Qt5" that is compatible 15:09:51 with requested version "5.4.0". 15:09:51 15:09:51 The following configuration files were considered bu

Re: Review Request 123390: Reorder member variables to reduce memory usage.

2015-04-18 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123390/ --- (Updated April 18, 2015, 2:22 p.m.) Status -- This change has been m

Build failed in Jenkins: kinfocenter_stable_qt5 #14

2015-04-18 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUIL

Review Request 123414: Duplicate RecentDocuments entry if two different files have the same name.

2015-04-18 Thread Anthony Vital
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123414/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

2015-04-18 Thread David Faure
> On Nov. 10, 2014, 9:41 p.m., David Faure wrote: > > lib/konq/src/konq_historyentry.h, line 57 > > > > > > const ref, no? > > Andrius da Costa Ribas wrote: > before I try to fix the pending issues: what are