---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/
---
(Updated April 22, 2015, 6:07 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123443/
---
(Updated April 22, 2015, 6:13 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79346
---
autotests/kconfig_compiler/test13.h.ref (line 38)
On April 22, 2015, 4:36 p.m., Vishesh Handa wrote:
autotests/kconfig_compiler/test_signal.h.ref, line 126
https://git.reviewboard.kde.org/r/123367/diff/3/?file=361167#file361167line126
Is the move required?
This is a unit test, this is how it gets generated after the patch.
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/
---
(Updated April 22, 2015, 4:51 p.m.)
Review request for KDE Frameworks
On April 22, 2015, 9 a.m., Emmanuel Pescosta wrote:
src/widgets/accessmanager.cpp, line 255
https://git.reviewboard.kde.org/r/123443/diff/1/?file=362233#file362233line255
IMO you should always verify if the data is readable, because not all
lib users are trustworthy (assert isn't
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79343
---
autotests/kconfig_compiler/test_signal.h.ref (line 121)
On April 22, 2015, 10:53 a.m., Matthew Dawson wrote:
src/kconfig_compiler/kconfig_compiler.cpp, line 100
https://git.reviewboard.kde.org/r/123367/diff/3/?file=361168#file361168line100
Is there a reason not to generate Q_PROPERTIES for all classes, or at
least do it by default?
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79347
---
Ship it!
- Vishesh Handa
On April 22, 2015, 2:51 p.m.,
On April 22, 2015, 4:53 p.m., Matthew Dawson wrote:
src/kconfig_compiler/kconfig_compiler.cpp, line 100
https://git.reviewboard.kde.org/r/123367/diff/3/?file=361168#file361168line100
Is there a reason not to generate Q_PROPERTIES for all classes, or at
least do it by default?
On April 22, 2015, 4:53 p.m., Matthew Dawson wrote:
src/kconfig_compiler/kconfig_compiler.cpp, line 100
https://git.reviewboard.kde.org/r/123367/diff/3/?file=361168#file361168line100
Is there a reason not to generate Q_PROPERTIES for all classes, or at
least do it by default?
On April 22, 2015, 10:53 a.m., Matthew Dawson wrote:
src/kconfig_compiler/kconfig_compiler.cpp, line 100
https://git.reviewboard.kde.org/r/123367/diff/3/?file=361168#file361168line100
Is there a reason not to generate Q_PROPERTIES for all classes, or at
least do it by default?
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123417/#review79323
---
src/kidletime.cpp (lines 222 - 223)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79353
---
If the first issue doesn't fit into this commit, this has a
Hi all,
I'd like to ask for review of another Framework from kdepimlibs:
KF5Syndication
KF5Syndication is an RSS/Atom parsing library. It also provides API to
fetch
feeds directly from network.
It's a Tier 3 Framework (depends on KCodecs and KIO). AFAIK it's
currently being
used only by
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/
---
(Updated April 23, 2015, 3:20 a.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79355
---
autotests/kconfig_compiler/test13.h.ref (line 20)
On April 22, 2015, 5 p.m., Albert Astals Cid wrote:
autotests/kconfig_compiler/test13.h.ref, line 20
https://git.reviewboard.kde.org/r/123367/diff/5/?file=362514#file362514line20
Why is there no brightness property anymore?
I still see it on line 40.
- Matthew
On 22 Apr 2015, at 22:51, Mark Gaiser mark...@gmail.com wrote:
Disclaimer: I've never seen this code nor knew about it's existence till ~30
minutes ago.
This library depends on QtXml (quite heavily in fact). That very Qt module is
deprecated [1].
Funnily enough, that is the only place
On Thu, Apr 23, 2015 at 12:13 AM, Daniel Vrátil dvra...@kde.org wrote:
On Wednesday, April 22, 2015 11:02:31 PM Frank Osterfeld wrote:
Hi,
KF5Syndication is an RSS/Atom parsing library. It also provides API to
fetch feeds directly from network.
It's a Tier 3 Framework (depends on
On Wed, Apr 22, 2015 at 9:44 PM, Daniel Vrátil dvra...@kde.org wrote:
Hi all,
I'd like to ask for review of another Framework from kdepimlibs:
KF5Syndication
KF5Syndication is an RSS/Atom parsing library. It also provides API to
fetch
feeds directly from network.
It's a Tier 3 Framework
These are from the kf5-qt5 branchGroup (usually master or frameworks
branches) I realize many these are still under heavy development for
porting. This is just a note to inform. Fixes welcome though.
kcalcore:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79361
---
autotests/kconfig_compiler/test13.h.ref (line 20)
Hi,
KF5Syndication is an RSS/Atom parsing library. It also provides API to fetch
feeds directly from network.
It's a Tier 3 Framework (depends on KCodecs and KIO). AFAIK it's currently
being
used only by Akregator.
The Akonadi RSS resources (still lingering in some work branch, I
On Wednesday, April 22, 2015 10:51:15 PM Mark Gaiser wrote:
On Wed, Apr 22, 2015 at 9:44 PM, Daniel Vrátil dvra...@kde.org wrote:
Hi all,
I'd like to ask for review of another Framework from kdepimlibs:
KF5Syndication
KF5Syndication is an RSS/Atom parsing library. It also provides
On Wednesday, April 22, 2015 11:02:31 PM Frank Osterfeld wrote:
Hi,
KF5Syndication is an RSS/Atom parsing library. It also provides API to
fetch feeds directly from network.
It's a Tier 3 Framework (depends on KCodecs and KIO). AFAIK it's currently
being used only by Akregator.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123463/
---
Review request for KDE Frameworks and Martin Klapetek.
Bugs: 346429
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123453/#review79331
---
Ship it!
Ship It!
- Chusslove Illich
On Април 21, 2015,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123443/#review79325
---
src/widgets/accessmanager.cpp (line 255)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123417/
---
(Updated April 22, 2015, 7:13 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123417/#review79327
---
Ship it!
Ship It!
- Martin Gräßlin
On April 22, 2015,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123417/
---
(Updated April 22, 2015, 7:27 a.m.)
Status
--
This change has been
See http://build.kde.org/job/kinfocenter_stable_qt5/16/changes
Changes:
[scripty] SVN_SILENT made messages (.desktop file)
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123453/
---
(Updated April 22, 2015, 8:32 a.m.)
Status
--
This change has been
On April 22, 2015, 10:49 a.m., Martin Klapetek wrote:
src/runtime/logging_p.h, lines 21-23
https://git.reviewboard.kde.org/r/123463/diff/1/?file=362353#file362353line21
It's useful if this also has
#include QDebug
so that you don't have to include two
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123463/
---
(Updated April 22, 2015, 9:03 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123463/#review79332
---
Ship it!
src/runtime/logging_p.h (lines 21 - 23)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123464/
---
Review request for KDE Frameworks.
Repository: kwindowsystem
On April 22, 2015, 9 a.m., Emmanuel Pescosta wrote:
src/widgets/accessmanager.cpp, line 255
https://git.reviewboard.kde.org/r/123443/diff/1/?file=362233#file362233line255
IMO you should always verify if the data is readable, because not all
lib users are trustworthy (assert isn't
39 matches
Mail list logo
