Re: Places bookmark bug - Help needed

2015-04-23 Thread Marco Martin
On Thursday 23 April 2015, Emmanuel Pescosta wrote: So the possible solutions I see are: * Store the bookmarks in one file (user-places.xbel) and remove the syncing I like the idea of storing places bookmarks only in a cross desktop location . I think they were initially synced in two places

Re: Review Request 123477: Add public dependency on NetworkManager

2015-04-23 Thread Aleix Pol Gonzalez
On April 23, 2015, 3:35 p.m., Jan Grulich wrote: And yes, this is required as long as NetworkManager headers are included by NetworkManagerQt headers. Jan Grulich wrote: I just found out that installing FindNetworkManager.cmake into CMake modules is not enough, because it still

Review Request 123478: ensure the filePath metadata is there

2015-04-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123478/ --- Review request for KDE Frameworks, Plasma and Sebastian Kügler.

Re: Review Request 123478: ensure the filePath metadata is there

2015-04-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123478/#review79394 --- Ship it! Yes, please. I was wondering if I could rely on

Re: Review Request 123478: ensure the filePath metadata is there

2015-04-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123478/ --- (Updated April 23, 2015, 2:41 p.m.) Status -- This change has been

Re: Review Request 123477: Add public dependency on NetworkManager

2015-04-23 Thread Lamarque Souza
On April 23, 2015, 1:35 p.m., Jan Grulich wrote: And yes, this is required as long as NetworkManager headers are included by NetworkManagerQt headers. Jan Grulich wrote: I just found out that installing FindNetworkManager.cmake into CMake modules is not enough, because it still

Re: Review Request 123477: Add public dependency on NetworkManager

2015-04-23 Thread Aleix Pol Gonzalez
On April 23, 2015, 3:35 p.m., Jan Grulich wrote: And yes, this is required as long as NetworkManager headers are included by NetworkManagerQt headers. Jan Grulich wrote: I just found out that installing FindNetworkManager.cmake into CMake modules is not enough, because it still

Places bookmark bug - Help needed

2015-04-23 Thread Emmanuel Pescosta
Hi everyone, I want to ask you, if you can help me to fix the Places bookmarks disappear bug [1], which was introduced by commit 2b5c6e42fc8114c6854ce490b9cdd4356be683d9 in kdelibs [2]. The adoption for Dolphin [3] has no effect on this bug. I have done some research and I'm a little bit

Re: Review Request 123477: Add public dependency on NetworkManager

2015-04-23 Thread Jan Grulich
On Dub. 23, 2015, 1:35 odp., Jan Grulich wrote: And yes, this is required as long as NetworkManager headers are included by NetworkManagerQt headers. Jan Grulich wrote: I just found out that installing FindNetworkManager.cmake into CMake modules is not enough, because it still

Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

2015-04-23 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/ --- Review request for KDE Frameworks, David Faure, Marc Mutz, and Volker

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

2015-04-23 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/ --- (Updated April 23, 2015, 4:50 p.m.) Review request for KDE Frameworks,

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

2015-04-23 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/#review79399 --- How are kf5 releases handled btw? Do I need to push this into

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

2015-04-23 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/#review79400 --- LGTM, but I think having/modifying a unit test for this

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

2015-04-23 Thread Luigi Toscano
On April 23, 2015, 6:55 p.m., Milian Wolff wrote: How are kf5 releases handled btw? Do I need to push this into some branch? There are none in kcoreaddons. This patch here should probably be put into a patch release (if we do this for kf5). The current schedule is one release every

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

2015-04-23 Thread Matthew Dawson
On April 23, 2015, 12:55 p.m., Milian Wolff wrote: How are kf5 releases handled btw? Do I need to push this into some branch? There are none in kcoreaddons. This patch here should probably be put into a patch release (if we do this for kf5). Luigi Toscano wrote: The current

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

2015-04-23 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/#review79404 --- +1 from me, but I don't want to hit ship it without hearing

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

2015-04-23 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/ --- (Updated April 23, 2015, 5:19 p.m.) Review request for KDE Frameworks,

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-23 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79403 --- autotests/kconfig_compiler/test13.cpp.ref (line 18)

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

2015-04-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/#review79411 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 23, 2015,

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/ --- (Updated April 24, 2015, 2:53 a.m.) Review request for KDE Frameworks

Re: Review Request 123477: Add public dependency on NetworkManager

2015-04-23 Thread Jan Grulich
On Dub. 23, 2015, 1:35 odp., Aleix Pol Gonzalez wrote: KF5NetworkManagerQtConfig.cmake.in, line 4 https://git.reviewboard.kde.org/r/123477/diff/1/?file=362685#file362685line4 nitpick. weird 1 space indentation. Already spotted. On Dub. 23, 2015, 1:35 odp., Jan Grulich wrote:

Re: New framework: KF5Syndication

2015-04-23 Thread David Edmundson
On Wed, Apr 22, 2015 at 9:44 PM, Daniel Vrátil dvra...@kde.org wrote: Hi all, I'd like to ask for review of another Framework from kdepimlibs: KF5Syndication KF5Syndication is an RSS/Atom parsing library. It also provides API to fetch feeds directly from network. It's a Tier 3 Framework

Re: New framework: KF5Syndication

2015-04-23 Thread Marco Martin
On Thursday 23 April 2015, David Edmundson wrote: It's a Tier 3 Framework (depends on KCodecs and KIO). AFAIK it's currently being used only by Akregator. There is another (depending on the definition of currently) Plasma 4 used it for an RSS reader plasmoid. In Plasma 5 the code is

Build failed in Jenkins: kinfocenter_stable_qt5 #17

2015-04-23 Thread KDE CI System
See http://build.kde.org/job/kinfocenter_stable_qt5/17/changes Changes: [jr] Update version number for 5.3.0 -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in

Jenkins build is back to stable : kpty_stable_qt5 #19

2015-04-23 Thread KDE CI System
See http://build.kde.org/job/kpty_stable_qt5/19/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 123477: Add public dependency on NetworkManager

2015-04-23 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123477/ --- Review request for KDE Frameworks, David Faure, Daniel Vrátil, and

cmake licences inline

2015-04-23 Thread Jonathan Riddell
Rather than referring to a separate COPYING-CMAKE-SCRIPTS file, which can get lost and not included, please just include the BSD licence inline in your cmake modules. Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Build failed in Jenkins: kinfocenter_stable_qt5 #18

2015-04-23 Thread KDE CI System
See http://build.kde.org/job/kinfocenter_stable_qt5/18/changes Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

2015-04-23 Thread Alex Richardson
On April 24, 2015, 12:33 a.m., Alex Richardson wrote: src/lib/io/kdirwatch.cpp, line 303 https://git.reviewboard.kde.org/r/123479/diff/2/?file=362725#file362725line303 Why this manual loop instead of strlen()? Does that mean that null characters in the middle are valid? Or, more

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

2015-04-23 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/#review79415 --- src/lib/io/kdirwatch.cpp (line 303)

Re: Review Request 123452: Expose KJob::capabilities property

2015-04-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123452/#review79418 --- Bump? It's a simple-enough patch, I'll push this tomorrow if