Re: Review Request 129260: Add find module for QtPlatformSupport

2016-10-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129260/#review100323 --- Due to https://git.reviewboard.kde.org/r/129268/ I'm giving

Re: Review Request 129259: Fix the buffersize in certain situations.

2016-10-26 Thread taro yamada
> On Oct. 26, 2016, 5:58 a.m., Jonathan Doman wrote: > > src/ioslaves/file/file.cpp, line 790 > > > > > > I don't think we should use buff.st_size at all. We now know that on > > "virtual" filesystems, the

Re: Review Request 129259: Fix the buffersize in certain situations.

2016-10-26 Thread taro yamada
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129259/ --- (Updated Oct. 27, 2016, 4:58 a.m.) Review request for KDE Frameworks.

Re: Review Request 129259: Fix the buffersize in certain situations.

2016-10-26 Thread taro yamada
> On Oct. 26, 2016, 2:48 p.m., Andreas Hartmetz wrote: > > If a workaround was really necessary I'd agree with Jonathan. But it looks > > like a workaround to fix up st_size is not necessary, because both Krusader > > and ls (just two examples I could easily find) work without changing > >

Re: ABI break checking in frameworks

2016-10-26 Thread Bhushan Shah
Hello Albert, On Wed, Oct 26, 2016 at 11:54:33PM +0200, Albert Astals Cid wrote: > 1) Have a helper repository where we upload the XML files of the ABIs exactly > produced by the CI nodes and then make CI check against that on every build. > > This still has some issues on how we actually fill

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

2016-10-26 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129170/ --- (Updated Oct. 27, 2016, 2:23 a.m.) Review request for KDE Frameworks.

Re: Review Request 129267: [OS X] emulate posix_fallocate()

2016-10-26 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129267/#review100318 --- Fix it, then Ship it! I'm fine with the proposal but

Re: Review Request 129236: KAuth: make sure we can do more than one request

2016-10-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129236/ --- (Updated Oct. 27, 2016, 1:15 a.m.) Review request for KDE Frameworks and

Re: Review Request 129236: KAuth: make sure we can do more than one request

2016-10-26 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129236/#review100317 --- Looks sensible, can you add

ABI break checking in frameworks

2016-10-26 Thread Albert Astals Cid
Hi there, one of the things we say we maintain but we don't really have autotests for is maintaining ABI compatibility. I recently learnt about abigail, a tool that for checking ABI compatibility. Basically we are interested in two tools abidw and abidiff abidw creates an XML file with the ELF

Re: Review Request 129236: KAuth: make sure we can do more than one request

2016-10-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129236/ --- (Updated Oct. 26, 2016, 11:53 p.m.) Review request for KDE Frameworks.

Re: Review Request 129236: KAuth: make sure we can do more than one request

2016-10-26 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129236/#review100313 --- Have you tried adding an autotest so that this doesn't

Re: Review Request 129259: Fix the buffersize in certain situations.

2016-10-26 Thread Jonathan Doman
> On Oct. 26, 2016, 9:48 a.m., Andreas Hartmetz wrote: > > If a workaround was really necessary I'd agree with Jonathan. But it looks > > like a workaround to fix up st_size is not necessary, because both Krusader > > and ls (just two examples I could easily find) work without changing > >

Re: Review Request 129259: Fix the buffersize in certain situations.

2016-10-26 Thread Andreas Hartmetz
> On Oct. 26, 2016, 2:48 p.m., Andreas Hartmetz wrote: > > If a workaround was really necessary I'd agree with Jonathan. But it looks > > like a workaround to fix up st_size is not necessary, because both Krusader > > and ls (just two examples I could easily find) work without changing > >

Review Request 129267: [OS X] emulate posix_fallocate()

2016-10-26 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129267/ --- Review request for KDE Software on Mac OS X and KDE Frameworks.

Re: Review Request 129259: Fix the buffersize in certain situations.

2016-10-26 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129259/#review100304 --- If a workaround was really necessary I'd agree with

Re: Help with KAuth tests

2016-10-26 Thread Aleix Pol
On Sun, Oct 23, 2016 at 11:56 PM, Albert Astals Cid wrote: > El divendres, 21 d’octubre de 2016, a les 20:09:30 CEST, Aleix Pol va > escriure: >> Hey, >> I pushed a change today that broke our build CI which I reverted, I've >> been investigating further and found out that if I run

Re: Review Request 129236: KAuth: make sure we can do more than one request

2016-10-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129236/ --- (Updated Oct. 26, 2016, 2:29 p.m.) Review request for KDE Frameworks.

Re: Review Request 129180: KAuth: simplify debug

2016-10-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129180/ --- (Updated Oct. 26, 2016, 2 p.m.) Status -- This change has been

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-26 Thread Marco Martin
> On Oct. 26, 2016, 10:36 a.m., David Rosca wrote: > > This made the Alternatives action visible in toolbox menu. > > > > The problem is that toolbox tries to emit `contextualActionsAboutToShow` on > > `AppletInterface`, but the connection between > > `Applet::contextualActionsAboutToShow`

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-26 Thread David Edmundson
> On Oct. 26, 2016, 10:36 a.m., David Rosca wrote: > > This made the Alternatives action visible in toolbox menu. > > > > The problem is that toolbox tries to emit `contextualActionsAboutToShow` on > > `AppletInterface`, but the connection between > > `Applet::contextualActionsAboutToShow`

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-26 Thread David Rosca
> On Oct. 26, 2016, 10:36 a.m., David Rosca wrote: > > This made the Alternatives action visible in toolbox menu. > > > > The problem is that toolbox tries to emit `contextualActionsAboutToShow` on > > `AppletInterface`, but the connection between > > `Applet::contextualActionsAboutToShow`

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-26 Thread David Edmundson
> On Oct. 26, 2016, 10:36 a.m., David Rosca wrote: > > This made the Alternatives action visible in toolbox menu. > > > > The problem is that toolbox tries to emit `contextualActionsAboutToShow` on > > `AppletInterface`, but the connection between > > `Applet::contextualActionsAboutToShow`

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-26 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129086/#review100291 --- This made the Alternatives action visible in toolbox menu.

Re: Review Request 129262: Properly finish DropJobs when triggered is not emitted

2016-10-26 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129262/ --- (Updated Oct. 26, 2016, 9:50 a.m.) Review request for KDE Frameworks and

Review Request 129262: Properly finish DropJobs when triggered is not emitted

2016-10-26 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129262/ --- Review request for KDE Frameworks and David Faure. Bugs: 363936

Re: Review Request 129260: Add find module for QtPlatformSupport

2016-10-26 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129260/ --- (Updated Okt. 26, 2016, 9:17 vorm.) Review request for KDE Frameworks,

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

2016-10-26 Thread Mark Gaiser
> On okt 24, 2016, 11 a.m., Albert Astals Cid wrote: > > -1 it's an established shortcut for cut too. even > > https://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts lists it in "Cut > > the selection and store it in the clipboard" > > Elvis Angelaccio wrote: > Ah, sorry I didn't know

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

2016-10-26 Thread Heiko Tietze
> On Okt. 24, 2016, 11 vorm., Albert Astals Cid wrote: > > -1 it's an established shortcut for cut too. even > > https://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts lists it in "Cut > > the selection and store it in the clipboard" > > Elvis Angelaccio wrote: > Ah, sorry I didn't