Re: Review Request 129844: KRun: deprecate runUrl() in favor of runUrl() with RunFlags

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129844/#review102070 --- Ship it! enums instead of bools in APIs are good. It's

[Differential] [Updated] D4154: Fix some -Wdocumentation warnings

kfunk marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4154 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks Cc: aacid, #frameworks

[Differential] [Updated, 104 lines] D4154: Fix some -Wdocumentation warnings

kfunk updated this revision to Diff 10270. kfunk added a comment. Address comments by aacid & fix a few more warnings REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4154?vs=10208=10270 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4154

[Differential] [Abandoned] D2545: Cleanup KSharedUiServerProxy before qApp exists

kfunk abandoned this revision. kfunk added a comment. Patched Qt instead: https://phabricator.kde.org/R138:7f78f7297add7c510c1cf0f1707197c8c403fcee I can't make my mind up how to fix this cleanly, to be honest. REVISION DETAIL https://phabricator.kde.org/D2545 EMAIL PREFERENCES

[Differential] [Abandoned] D2546: Cleanup DBus-related resources before qApp exits

kfunk abandoned this revision. kfunk added a comment. Patched Qt instead: https://phabricator.kde.org/R138:7f78f7297add7c510c1cf0f1707197c8c403fcee I can't make my mind up how to fix this cleanly, to be honest. REVISION DETAIL https://phabricator.kde.org/D2546 EMAIL PREFERENCES

[Differential] [Closed] D3392: winutils_p.h: Restore compatibility with WinXP SDK

kfunk closed this revision. kfunk added a comment. This has been pushed: commit f86e587aefd94b5ea2c6f7ecca29c266f36256fa Author: Kevin Funk Date: Wed Nov 16 22:32:32 2016 +0100 winutils_p.h: Restore compatibility with WinXP SDK REVISION DETAIL

[Differential] [Commented On] D3393: Make compile against WinXP SDK

kfunk added a comment. This has been pushed: commit 61f3c9fef7a5ca1a952e7681f5d37b7a9f0689c4 Author: Kevin Funk Date: Wed Nov 16 23:02:33 2016 +0100 Make compile against WinXP SDK REVISION DETAIL https://phabricator.kde.org/D3393 EMAIL

[Differential] [Abandoned] D3393: Make compile against WinXP SDK

kfunk abandoned this revision. REVISION DETAIL https://phabricator.kde.org/D3393 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, arichardson, #frameworks Cc: dhaumann

Re: Review Request 129776: Allow multiline text for KIconDialog icon names

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129776/#review102067 --- We could try to improve it: - make the size of the text

Re: Review Request 129833: KToolTipWidget: hide immediately if content gets destroyed

> On Jan. 15, 2017, 3:32 a.m., Christoph Feck wrote: > > From what I see, the content widget is not owned by the tool tip widget. > > What happens if I delete the tool tip widget first, then delete the content > > widget? Does deleting automatically break the connections to the now > >

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 212 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/212/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 17 Jan 2017 01:58:10 + Build duration: 6 min 24 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 212 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/212/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 17 Jan 2017 01:58:10 + Build duration: 6 min 24 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 215 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/215/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 17 Jan 2017 01:57:42 + Build duration: 5 min 34 sec CHANGE SET No changes JUNIT RESULTS Name:

[Differential] [Commented On] D4144: Install also CamelCase forward headers for classes from multi-class headers

kossebau added a comment. Yes, both tested and the docs of the macro also have it explicitely: https://api.kde.org/ecm/module/ECMGenerateHeaders.html :) Thanks for review. REPOSITORY R236 KWidgetsAddons BRANCH installMoreCamelCaseForwardHeaders REVISION DETAIL

[Differential] [Closed] D4023: kformat: Make it possible to properly translate relative days of the week

This revision was automatically updated to reflect the committed changes. Closed by commit R244:aeff11101f85: kformat: Make it possible to properly translate relative dates. (authored by mpyne). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4023?vs=9950=10267#toc REPOSITORY R244

[Differential] [Accepted] D4144: Install also CamelCase forward headers for classes from multi-class headers

cfeck accepted this revision. cfeck added a reviewer: cfeck. cfeck added a comment. This revision is now accepted and ready to land. I have no idea if a comma is a valid separator here, but I am sure you tested it :) REPOSITORY R236 KWidgetsAddons BRANCH

[Differential] [Updated, 311 lines] D4130: Let KConfigDialogManager get a property's change signal from the metaObject

kossebau updated this revision to Diff 10263. kossebau added a comment. update KF6 comment REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4130?vs=10262=10263 BRANCH readChangeSignalFromMetaObject REVISION DETAIL

[Differential] [Updated, 311 lines] D4130: Let KConfigDialogManager get a property's change signal from the metaObject

kossebau updated this revision to Diff 10262. kossebau added a comment. Add option to set signal via kcfg_propertyNotify REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4130?vs=10158=10262 BRANCH readChangeSignalFromMetaObject REVISION DETAIL

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 211 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/211/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 17 Jan 2017 00:15:13 + Build duration: 5 min 52 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 214 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/214/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 17 Jan 2017 00:14:05 + Build duration: 7 min 5 sec CHANGE SET No changes JUNIT RESULTS Name:

[Differential] [Closed] D4142: Support "default actions", as specified in [1].

This revision was automatically updated to reflect the committed changes. Closed by commit R289:8b161b971fae: Support "default actions", as specified in [1]. (authored by albertvaka). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4142?vs=10186=10258

[Differential] [Changed Subscribers] D4154: Fix some -Wdocumentation warnings

aacid added inline comments. INLINE COMMENTS > global.h:159 > ERR_UNSUPPORTED_ACTION = KJob::UserDefinedError + 8, > -ERR_IS_DIRECTORY = KJob::UserDefinedError + 9, // ... where a file was > expected > -ERR_IS_FILE = KJob::UserDefinedError + 10, // ... where a directory was >

[Differential] [Accepted] D4142: Support "default actions", as specified in [1].

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. In https://phabricator.kde.org/D4142#77864, @albertvaka wrote: > No, there is no change in our UI at all. In Plasma and KDE apps we can decide to never use

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 511 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/511/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 18:56:26 + Build duration: 9 min 36 sec CHANGE SET Revision

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 511 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/511/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 18:56:26 + Build duration: 9 min 36 sec CHANGE SET Revision

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 508 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/508/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 18:47:07 + Build duration: 8 min 32 sec CHANGE SET Revision

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 508 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/508/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 18:47:07 + Build duration: 8 min 32 sec CHANGE SET Revision

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 394 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/394/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 18:40:50 + Build duration: 8 min 31 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 393 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/393/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 18:29:49 + Build duration: 6 min 15 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 393 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/393/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 18:29:49 + Build duration: 6 min 15 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 213 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/213/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 17:52:13 + Build duration: 1 min 52 sec CHANGE SET No changes JUNIT RESULTS Name:

[Differential] [Commented On] D4142: Support "default actions", as specified in [1].

colomar added a comment. >>>! In https://phabricator.kde.org/D4142#77861, @colomar wrote: >> Hm, that's not easy to decide. Whether one likes the "click to make go away" behavior or not is highly subjective. I, for one, find it very annoying on e.g. OS when a notification covers

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 213 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/213/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 17:52:13 + Build duration: 1 min 52 sec CHANGE SET No changes JUNIT RESULTS Name:

[Differential] [Commented On] D4142: Support "default actions", as specified in [1].

albertvaka added a comment. In https://phabricator.kde.org/D4142#77834, @broulik wrote: > Care needs to be taken that existing notifications don't suddenly behave differently but that moving from actions() to defaultAction() is a conscious and explicit choice in the application that

[Differential] [Commented On] D4142: Support "default actions", as specified in [1].

broulik added a comment. > and there is no way to make it go away other than waiting. There's still the (x) button in the corner. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4142 EMAIL PREFERENCES

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 510 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/510/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 17:32:51 + Build duration: 11 min CHANGE SET Revision

[Differential] [Commented On] D4142: Support "default actions", as specified in [1].

colomar added a comment. Hm, that's not easy to decide. Whether one likes the "click to make go away" behavior or not is highly subjective. I, for one, find it very annoying on e.g. OS when a notification covers something I want to see on the screen and there is no way to make it go away

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 392 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/392/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 17:32:51 + Build duration: 10 min CHANGE SET Revision

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 507 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/507/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 17:29:48 + Build duration: 17 min CHANGE SET Revision

Jenkins-kde-ci: kglobalaccel master stable-kf5-qt5 » Linux,gcc - Build # 202 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kglobalaccel%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/202/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 17:23:29 + Build duration: 1 min 32 sec CHANGE SET Revision

Jenkins-kde-ci: kglobalaccel master stable-kf5-qt5 » Linux,gcc - Build # 202 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kglobalaccel%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/202/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 17:23:29 + Build duration: 1 min 32 sec CHANGE SET Revision

[Differential] [Commented On] D4142: Support "default actions", as specified in [1].

broulik added a comment. I always hated that clicking the notification popup just closed the popup without doing anything. While our users are probably used to always having a visible "Open" or similar button, I think this makes sense to have. Care needs to be taken that existing

[Differential] [Commented On] D4142: Support "default actions", as specified in [1].

mart added a comment. code wise the change makes sense.. that said, this assumes we do an important behavior change in our ui, which i don't think is a good thing, as is disregards completely how our users are used to, in the name of "other platforms do things differently". so OK for the

[Differential] [Commented On] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk added a comment. In https://phabricator.kde.org/D3987#77726, @dfaure wrote: > In https://phabricator.kde.org/D3987#77725, @kfunk wrote: > > > Want me to do a `s/Q_NULLPTR/nullptr/`, too? > > > This would make things consistent and avoid confusing future contributors about

[Differential] [Updated] D4142: Support "default actions", as specified in [1].

mart added a reviewer: VDG. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4142 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: albertvaka, #frameworks, #vdg Cc: #frameworks

[Differential] [Changed Subscribers] D4156: sort alphabetically category list

broulik added inline comments. INLINE COMMENTS > atticaprovider.cpp:137 > } > +std::sort(categoryMetadataList.begin(), categoryMetadataList.end(), > [](const AtticaProvider::CategoryMetadata , const > AtticaProvider::CategoryMetadata ) -> bool { > +const QString

Re: Review Request 129809: KFontRequester: Find the nearest match for a missing font

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129809/ --- (Updated Jan. 16, 2017, 6:48 p.m.) Review request for KDE Frameworks and

[Differential] [Updated] D4137: API dox: Add @class comment with CamelCase include, image title without KDE

kossebau added a comment. Not perfect, but guess that is all we can do with current buildsystems, okay. Could you also officially accept https://phabricator.kde.org/D4144 then? :) Would wait for further feedback until the upcoming WE, and then push both unless someone objects. REPOSITORY

Jenkins-kde-ci: krunner master kf5-qt5 » Linux,gcc - Build # 261 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/krunner%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/261/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 13:31:38 + Build duration: 1 min 25 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: krunner master kf5-qt5 » Linux,gcc - Build # 261 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/krunner%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/261/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 13:31:38 + Build duration: 1 min 25 sec CHANGE SET No changes JUNIT RESULTS Name:

[Differential] [Commented On] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

dfaure added a comment. In https://phabricator.kde.org/D3987#77725, @kfunk wrote: > Want me to do a `s/Q_NULLPTR/nullptr/`, too? This would make things consistent and avoid confusing future contributors about which one to use, so I'd say yes. REPOSITORY R280 Prison REVISION

[Differential] [Commented On] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk added a comment. Hmm, one thing I forgot to ask: Want me to do a `s/Q_NULLPTR/nullptr/`, too? REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D3987 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks,

[Differential] [Updated] D3826: Detect inotify.

dfaure added a comment. OK I see. On Linux it was enough to check that the header is present (-> in /usr/include) while on BSD it's part of a library that could in theory be installed anywhere. Makes sense to set an _INCLUDE_DIRS variable then. REPOSITORY R240 Extra CMake Modules

[Differential] [Commented On] D3826: Detect inotify.

kfunk added a comment. @dfaure `find_path` is okay here, it's commonly used for finding includes. See: https://cmake.org/cmake/help/v3.0/command/find_path.html `check_include_files` is used for just checking the existence of a include, not finding out //where// it is. Example use:

[Differential] [Requested Changes To] D3826: Detect inotify.

kfunk requested changes to this revision. kfunk added a reviewer: kfunk. kfunk added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > FindInotify.cmake:51 > +if(Inotify_INCLUDE_DIRS) > + # On Linux there is no library to link against, on the BSDs there is. > +

[Differential] [Commented On] D3826: Detect inotify.

dfaure added inline comments. INLINE COMMENTS > FindInotify.cmake:48 > + > +find_path(Inotify_INCLUDE_DIRS sys/inotify.h) > + What's the difference with check_include_files as used by kcoreaddons/CMakeLists.txt? It seems to me that find_path won't know where to look, no, at least

[Differential] [Updated] D3826: Detect inotify.

dfaure added a reviewer: skelly. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D3826 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: adridg, apol, arrowdodger, #buildsystem, #frameworks, tcberner,

[Differential] [Updated] D3826: Detect inotify.

ervin added a comment. Not my forte, but I don't see anything blatantly wrong in here. Adding dfaure to see if he got something to say about it. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D3826 EMAIL PREFERENCES

[Differential] [Updated] D3826: Detect inotify.

ervin added a reviewer: dfaure. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D3826 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: adridg, apol, arrowdodger, #buildsystem, #frameworks, ervin, tcberner,

[Differential] [Request, 6 lines] D4156: sort alphabetically category list

mart created this revision. mart added reviewers: Plasma, leinir. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY sort the category list by their visible name prefer sorting by displayName if

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 390 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/390/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 11:39:34 + Build duration: 7 min 2 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 390 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/390/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 11:39:34 + Build duration: 7 min 2 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 389 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/389/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 11:28:28 + Build duration: 1 min 40 sec CHANGE SET No changes

Jenkins-kde-ci: krunner master kf5-qt5 » Linux,gcc - Build # 260 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/krunner%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/260/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 11:18:23 + Build duration: 12 sec CHANGE SET No changes

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 212 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/212/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 10:26:05 + Build duration: 2 min 37 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kglobalaccel master stable-kf5-qt5 » Linux,gcc - Build # 201 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kglobalaccel%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/201/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 09:53:19 + Build duration: 6 min 13 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 209 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/209/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 09:52:50 + Build duration: 1 min 54 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 209 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/209/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 09:52:50 + Build duration: 1 min 54 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 211 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/211/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 09:42:53 + Build duration: 5 min 23 sec CHANGE SET Revision

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 387 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/387/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 09:17:42 + Build duration: 8 min 8 sec CHANGE SET Revision

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 387 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/387/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 09:17:42 + Build duration: 8 min 8 sec CHANGE SET Revision

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 208 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/208/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 09:07:43 + Build duration: 2 min 5 sec CHANGE SET Revision

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 210 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/210/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 Jan 2017 08:36:48 + Build duration: 1 min 58 sec CHANGE SET No changes JUNIT RESULTS Name:

[Differential] [Updated] D4154: Fix some -Wdocumentation warnings

kfunk added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4154 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks Cc: #frameworks

[Differential] [Request, 88 lines] D4154: Fix some -Wdocumentation warnings

kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D4154 AFFECTED FILES src/core/global.h src/core/job_base.h

Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129724/#review102057 --- @Stephen: Let's re-introduce this patch? Laurent + me have

Frameworks minimum required GCC version raised to 4.6

Heya, I've just pushed my bulk-change to use 'nullptr' unconditionally everywhere to the Frameworks repositories, as discussed on [1]. This also means Frameworks now requires at least GCC 4.6. I've updated the Frameworks Policies page as necessary:

[Differential] [Closed] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

This revision was automatically updated to reflect the committed changes. Closed by commit R280:42ae697a1afe: Use nullptr everywhere (authored by kfunk). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3987?vs=9785=10206#toc REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE

[Differential] [Updated] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk updated the summary for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D3987 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks, dfaure Cc: dfaure, graesslin