Jenkins-kde-ci: kitemmodels master kf5-qt5 » Linux,gcc - Build # 173 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kitemmodels%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/173/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Mar 2017 06:14:23 + Build duration: 2 min 56 sec CHANGE SET Revision fdbb6556017036ac159e15bb6285b104a14facbd by Pino Toscano: (KDescendantsProxyModel: fix typo in apidox) change: edit src/kdescendantsproxymodel.h
Jenkins-kde-ci: kitemmodels master stable-kf5-qt5 » Linux,gcc - Build # 173 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kitemmodels%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/173/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Mar 2017 06:14:23 + Build duration: 3 min 1 sec CHANGE SET Revision fdbb6556017036ac159e15bb6285b104a14facbd by Pino Toscano: (KDescendantsProxyModel: fix typo in apidox) change: edit src/kdescendantsproxymodel.h
D5104: Error page, correctly load the image (with a real URL)
mpyne added a comment. The patch looks fine to me, and gives a file:// that successfully opens in a separate Konq tab... but the image still doesn't show in the actual error page. I'm not sure of the cause though and have no time to research further tonight. :( REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D5104 To: ltoscano Cc: mpyne, #frameworks
D4234: Change algorithm for autobrace.
nalvarez added a comment. Writing tests for this might not be easy, so even having passing tests for the current behavior would be very useful, as a first step. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4234 To: cactus, #ktexteditor, mwolff Cc: nalvarez, mwolff, anthonyfieroni, dhaumann, brauch, cullmann, kwrite-devel, #frameworks
D4234: Change algorithm for autobrace.
brauch added a comment. Hm, I think the biggest problem is that we don't know how we want it to work ... so we can't write tests either ;) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4234 To: cactus, #ktexteditor, mwolff Cc: mwolff, anthonyfieroni, dhaumann, brauch, cullmann, kwrite-devel, #frameworks
D4995: Fix DB inconsistency due to some docterms appearing with uppercase symbols
This revision was automatically updated to reflect the committed changes. Closed by commit R293:ca4028aed27b: Fixed normalization/toLower order (authored by poboiko). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4995?vs=12340&id=12624#toc REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4995?vs=12340&id=12624 REVISION DETAIL https://phabricator.kde.org/D4995 AFFECTED FILES autotests/unit/engine/queryparsertest.cpp autotests/unit/engine/termgeneratortest.cpp src/engine/queryparser.cpp src/engine/termgenerator.cpp To: poboiko, pinakahuja, vhanda, mwolff Cc: mwolff, #frameworks
D5090: User messages cleanup (and de-emphasize Konqueror)
This revision was automatically updated to reflect the committed changes. Closed by commit R241:1693ee7a2501: User messages cleanup (and de-emphasize Konqueror) (authored by ltoscano). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5090?vs=12615&id=12623 REVISION DETAIL https://phabricator.kde.org/D5090 AFFECTED FILES src/core/kprotocolmanager.cpp src/kcms/kio/cache.cpp src/kcms/kio/kcookiesmain.cpp src/kcms/kio/kcookiespolicies.cpp src/kcms/kio/smb.desktop src/kcms/kio/smbrodlg.cpp src/kcms/kio/useragent.desktop src/kcms/kio/useragentdlg.cpp To: ltoscano, dfaure Cc: aacid, lueck, #frameworks
D5108: Fix setPen call
This revision was automatically updated to reflect the committed changes. Closed by commit R39:9a9f51956d44: fix debug warning (and wrong pen value) found by kfunk, introduced my me (authored by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5108?vs=12621&id=12622 REVISION DETAIL https://phabricator.kde.org/D5108 AFFECTED FILES src/view/kateviewhelpers.cpp To: cullmann, kfunk Cc: kwrite-devel, #frameworks
D5108: Fix setPen call
kfunk added a comment. Thanks for the quick fix! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5108 To: cullmann, kfunk Cc: kwrite-devel, #frameworks
D5108: Fix setPen call
kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5108 To: cullmann, kfunk Cc: kwrite-devel, #frameworks
D5108: Fix setPen call
cullmann created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY Fix setPen call to be done after begin() REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5108 AFFECTED FILES src/view/kateviewhelpers.cpp To: cullmann, kfunk Cc: kwrite-devel, #frameworks
D5090: User messages cleanup (and de-emphasize Konqueror)
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH focus-on-kio REVISION DETAIL https://phabricator.kde.org/D5090 To: ltoscano, dfaure Cc: aacid, lueck, #frameworks
D5090: User messages cleanup (and de-emphasize Konqueror)
aacid added a comment. Looks good to me now. I'll let someone else do the final approval, since various of us commented. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5090 To: ltoscano, dfaure Cc: aacid, lueck, #frameworks
D5104: Error page, correctly load the image (with a real URL)
mpyne added a comment. Will try to look later today but won't be able to at this point. REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D5104 To: ltoscano Cc: mpyne, #frameworks
D5079: debug when disabling kcrash due to env vars
mpyne accepted this revision. mpyne added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R285 KCrash BRANCH master REVISION DETAIL https://phabricator.kde.org/D5079 To: sitter, dfaure, mpyne Cc: mpyne, #frameworks
D5090: User messages cleanup (and de-emphasize Konqueror)
ltoscano retitled this revision from "More focus on KIO than Konqueror and msg cleanups" to "User messages cleanup (and de-emphasize Konqueror)". ltoscano edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5090 To: ltoscano, dfaure Cc: aacid, lueck, #frameworks
D5090: More focus on KIO than Konqueror and msg cleanups
ltoscano updated this revision to Diff 12615. ltoscano added a comment. Apply the requested suggestions REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5090?vs=12607&id=12615 BRANCH focus-on-kio REVISION DETAIL https://phabricator.kde.org/D5090 AFFECTED FILES src/core/kprotocolmanager.cpp src/kcms/kio/cache.cpp src/kcms/kio/kcookiesmain.cpp src/kcms/kio/kcookiespolicies.cpp src/kcms/kio/smb.desktop src/kcms/kio/smbrodlg.cpp src/kcms/kio/useragent.desktop src/kcms/kio/useragentdlg.cpp To: ltoscano, dfaure Cc: aacid, lueck, #frameworks
D5090: More focus on KIO than Konqueror and msg cleanups
ltoscano added inline comments. INLINE COMMENTS > dfaure wrote in kprotocolmanager.cpp:846 > How about just KIO ? > > kio_http is unnecessarily specific IMHO. It's all of KIO/5.33 that ends up > making up the http client. Ack > dfaure wrote in cache.cpp:109 > Memory? that seems wrong (or at least misleading) to me. The kio_http cache > is on disk, not in RAM. Right, I simply fixed the Konqueror part but I did not read the whole sentence. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5090 To: ltoscano, dfaure Cc: aacid, lueck, #frameworks
D4234: Change algorithm for autobrace.
mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed. I'm personally all for improving the status quo, but I think the biggest problem here is that we have no unit test coverage (or do we?). The unit tests would also clearly show the advantage of this new beheavior compared to the old one. So: Could you add unit tests? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4234 To: cactus, #ktexteditor, mwolff Cc: mwolff, anthonyfieroni, dhaumann, brauch, cullmann, kwrite-devel, #frameworks
D4995: Fix DB inconsistency due to some docterms appearing with uppercase symbols
mwolff accepted this revision. mwolff added a comment. do you have commit rights? otherwise someone from us can commit this for you REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D4995 To: poboiko, pinakahuja, vhanda, mwolff Cc: mwolff, #frameworks
D4947: [KTextEditor] Expose additional internal View's functionality to the public API
This revision was automatically updated to reflect the committed changes. Closed by commit R39:c9cb3e9761f3: Expose additional internal View's functionality to the public API (authored by jsalatas). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4947?vs=12598&id=12613 REVISION DETAIL https://phabricator.kde.org/D4947 AFFECTED FILES src/include/ktexteditor/view.h src/utils/ktexteditor.cpp src/view/kateview.cpp src/view/kateview.h To: jsalatas, #frameworks, tfry, mwolff, #ktexteditor, cullmann Cc: cullmann, dhaumann, anthonyfieroni, mwolff, kwrite-devel
D4947: [KTextEditor] Expose additional internal View's functionality to the public API
jsalatas marked 9 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4947 To: jsalatas, #frameworks, tfry, mwolff, #ktexteditor, cullmann Cc: cullmann, dhaumann, anthonyfieroni, mwolff, kwrite-devel
D4947: [KTextEditor] Expose additional internal View's functionality to the public API
jsalatas marked 2 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4947 To: jsalatas, #frameworks, tfry, mwolff, #ktexteditor, cullmann Cc: cullmann, dhaumann, anthonyfieroni, mwolff, kwrite-devel
D4995: Fix DB inconsistency due to some docterms appearing with uppercase symbols
vhanda accepted this revision. vhanda added a comment. This revision is now accepted and ready to land. This is awesome. Good work. Ship it! (If you don't have commit access, please ask for it, you can add me as a reference) (Optionally, one could even add a unit test) REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D4995 To: poboiko, pinakahuja, vhanda Cc: #frameworks
D5090: More focus on KIO than Konqueror and msg cleanups
dfaure added inline comments.
INLINE COMMENTS
> kprotocolmanager.cpp:846
> d->useragent += QString::number(KIO_VERSION_MAJOR);
> +d->useragent += QStringLiteral(" kio_http/");
> +d->useragent += QString::number(KIO_VERSION_MAJOR);
How about just KIO ?
kio_http is unnecessarily specific IMHO. It's all of KIO/5.33 that ends up
making up the http client.
> cache.cpp:109
>return i18n( "CacheThis module lets you configure your cache
> settings."
> -"The cache is an internal memory in Konqueror where
> recently "
> +"The cache is an internal memory where recently "
> "read web pages are stored. If you want to retrieve a web "
Memory? that seems wrong (or at least misleading) to me. The kio_http cache is
on disk, not in RAM.
> ltoscano wrote in smbrodlg.cpp:176-186
> I will fix it (basically removing most of the text), but I realize now that
> this KCM should not be here. The kio_smb is in kio-extras, this code should
> be moved there.
I agree.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D5090
To: ltoscano, dfaure
Cc: aacid, lueck, #frameworks
Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 475 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/475/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 19 Mar 2017 10:26:13 + Build duration: 6 min 21 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 22/22 (100%)FILES 275/344 (80%)CLASSES 275/344 (80%)LINE 29984/52017 (58%)CONDITIONAL 16422/39051 (42%) By packages autotests FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7971/8288 (96%)CONDITIONAL 4448/8694 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8107/14181 (57%)CONDITIONAL 4446/9267 (48%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3464/7561 (46%)CONDITIONAL 1293/4381 (30%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 330/749 (44%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1767/3780 (47%)CONDITIONAL 1275/3460 (37%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 607/839 (72%) src.ioslaves.remote FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 70/258 (27%)CONDITIONAL 14/200 (7%) src.ioslaves.trash FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 727/1173 (62%)CONDITIONAL 411/851 (48%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 707/785 (90%)CONDITIONAL 461/970 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 111/138 (80%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 280/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 144/256 (56%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 150/546 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 16/26 (62%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 332/412 (81%) src.widgets FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3670/11067 (33%)CONDITIONAL 1754/7114 (25%)
Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 475 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/475/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 19 Mar 2017 10:26:13 + Build duration: 6 min 21 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 22/22 (100%)FILES 275/344 (80%)CLASSES 275/344 (80%)LINE 29984/52017 (58%)CONDITIONAL 16422/39051 (42%) By packages autotests FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7971/8288 (96%)CONDITIONAL 4448/8694 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8107/14181 (57%)CONDITIONAL 4446/9267 (48%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3464/7561 (46%)CONDITIONAL 1293/4381 (30%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 330/749 (44%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1767/3780 (47%)CONDITIONAL 1275/3460 (37%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 607/839 (72%) src.ioslaves.remote FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 70/258 (27%)CONDITIONAL 14/200 (7%) src.ioslaves.trash FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 727/1173 (62%)CONDITIONAL 411/851 (48%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 707/785 (90%)CONDITIONAL 461/970 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 111/138 (80%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 280/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 144/256 (56%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 150/546 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 16/26 (62%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 332/412 (81%) src.widgets FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3670/11067 (33%)CONDITIONAL 1754/7114 (25%)
D5092: [KMessageWidget] Fix wrong size hint when animatedShow() is called with a hidden parentWidget()
elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. I cannot reproduce that bug but the patch looks good to me. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D5092 To: cfeck, kossebau, elvisangelaccio Cc: #frameworks
D4947: [KTextEditor] Expose additional internal View's functionality to the public API
cullmann accepted this revision. cullmann added a comment. Then I would say that is OK to go in. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4947 To: jsalatas, #frameworks, tfry, mwolff, #ktexteditor, cullmann Cc: cullmann, dhaumann, anthonyfieroni, mwolff, kwrite-devel
Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 474 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/474/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 19 Mar 2017 10:12:18 + Build duration: 7 min 23 sec CHANGE SET Revision e449f82311ad89ded3a27790015cebac878cc3ad by Luigi Toscano: (Updated user agents (Firefox 52 ESR, Chromium 57)) change: add src/kcms/kio/uasproviders/firefox520oncurrent.desktop change: add src/kcms/kio/uasproviders/chrome570oncurrent.desktop JUNIT RESULTS Name: (root) Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: TestSuite.kiocore-threadtestFailed: TestSuite.kiofilewidgets-kfilewidgettest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 22/22 (100%)FILES 274/343 (80%)CLASSES 274/343 (80%)LINE 29926/51982 (58%)CONDITIONAL 16387/39029 (42%) By packages autotests FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7936/8253 (96%)CONDITIONAL 4432/8672 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8088/14181 (57%)CONDITIONAL 4435/9267 (48%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3465/7561 (46%)CONDITIONAL 1289/4381 (29%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 330/749 (44%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1767/3780 (47%)CONDITIONAL 1275/3460 (37%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 607/839 (72%) src.ioslaves.remote FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 70/258 (27%)CONDITIONAL 14/200 (7%) src.ioslaves.trash FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 727/1173 (62%)CONDITIONAL 411/851 (48%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 707/785 (90%)CONDITIONAL 461/970 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 111/138 (80%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 372/594 (63%)CONDITIONAL 276/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 144/256 (56%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 150/546 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 16/26 (62%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 332/412 (81%) src.widgets FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3670/11067 (33%)CONDITIONAL 1754/7114 (25%)
D5091: Updated user agents (Firefox 52 ESR, Chromium 57)
This revision was automatically updated to reflect the committed changes. Closed by commit R241:e449f82311ad: Updated user agents (Firefox 52 ESR, Chromium 57) (authored by ltoscano). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5091?vs=12576&id=12610 REVISION DETAIL https://phabricator.kde.org/D5091 AFFECTED FILES src/kcms/kio/uasproviders/chrome570oncurrent.desktop src/kcms/kio/uasproviders/firefox520oncurrent.desktop To: ltoscano, dfaure Cc: #frameworks
D5091: Updated user agents (Firefox 52 ESR, Chromium 57)
ltoscano retitled this revision from "Updated user agents (Firefox 52 ESR, Chromium 52)" to "Updated user agents (Firefox 52 ESR, Chromium 57)". REPOSITORY R241 KIO BRANCH add-current-useragents REVISION DETAIL https://phabricator.kde.org/D5091 To: ltoscano, dfaure Cc: #frameworks
D4799: Delay notifications until desktop session has loaded
vpilo added a comment. I pushed https://phabricator.kde.org/D5012; this rev is now testable. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4799 To: vpilo, #plasma, #plasma_workspaces, davidedmundson, dfaure, broulik, graesslin, mck182 Cc: plasma-devel, davidedmundson, dfaure, broulik, graesslin, mck182, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5091: Updated user agents (Firefox 52 ESR, Chromium 52)
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Bug in the commit log, Chrome 57, not Chromium 52 ;) REPOSITORY R241 KIO BRANCH add-current-useragents REVISION DETAIL https://phabricator.kde.org/D5091 To: ltoscano, dfaure Cc: #frameworks
D5037: KTextEditor: prevent accidental zooming
rjvbb updated this revision to Diff 12608. rjvbb added a comment. Updated as requested CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5037?vs=12480&id=12608 REVISION DETAIL https://phabricator.kde.org/D5037 AFFECTED FILES src/view/kateviewinternal.cpp src/view/kateviewinternal.h To: rjvbb, #ktexteditor Cc: luebking, anthonyfieroni, dhaumann, kwrite-devel, #ktexteditor, #frameworks, head7, cullmann, kfunk, sars
D5089: KDE compiler settings fail to consider AppleClang
rjvbb closed this revision. rjvbb added a comment. https://commits.kde.org/extra-cmake-modules/7af9f8e2b6eb235923a329e8ff24012883fb6b86 REVISION DETAIL https://phabricator.kde.org/D5089 To: rjvbb, #build_system, #frameworks, kfunk Cc: kfunk, apol, kde-mac, #frameworks, #build_system
