Re: Tests leaving behind large temporary files
On Mon, Aug 14, 2017 at 11:40 PM, Bhushan Shah wrote: > Hello Ben, Hi Bhushan, > > On Mon, Aug 14, 2017 at 10:59:49PM +1200, Ben Cooksley wrote: >> Could someone please investigate, determine which test(s) are >> responsible and fix those tests to cleanup after themselves? >> > > I did some investigation on those left-out files, and it seems it's not > the code of frameworks but code of CI itself leaving those files, > > I found a small file "/tmp/tmp8ubko4sx" on FreeBSD builder, looking at > trings of the file, > > # strings /tmp/tmp8ubko4sx > checksum: 39909cda53863cdc13d719a7b800f5abf6a2e73eb89270c26f3cf94ce4dbc570 > scmRevision: null > timestamp: 1502708857.009341 > > And then I looked at the ci builder code and turns out those parts come > from the capture-workspace.py code of ci-tooling. > > We need to make that code failproof it seems instead of the frameworks > code. Oops. That would explain why it shows up on both platforms for sure... Thanks for finding that. I've now fixed that code to cleanup after itself. > > Thanks! Cheers, Ben > > -- > Bhushan Shah > http://blog.bshah.in > IRC Nick : bshah on Freenode > GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
D7281: KCoreAddons: Enforce hidden symbol visibility in nested private classes
bcooksley added a comment. I'm not sure why that happened - it automatically associated correctly so it should have closed. It does appear that one of the reviews (https://phabricator.kde.org/tag/frameworks/) hasn't approved it yet so that may be the reason why. (Phabricator upstream are big on stuff not going in without proper review) REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D7281 To: mpyne, #frameworks, kossebau Cc: bcooksley, kossebau
KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 56 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/56/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 15 Aug 2017 03:04:54 + Build duration: 22 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 64 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.bug205447Failed: TestSuite.kateindenttest_testCstyle build.log Description: Binary data
KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 40 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/40/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 15 Aug 2017 01:29:45 + Build duration: 3 min 3 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 22 test(s) build.log Description: Binary data
KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 44 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/44/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Tue, 15 Aug 2017 01:29:45 + Build duration: 3 min 27 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 25 test(s)Failed: TestSuite.kdirwatch_fam_unittestFailed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (10/10)85% (79/93)85% (79/93)74% (6126/8284)44% (10789/24636)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests83% (33/40)83% (33/40)97% (2635/2718)49% (6538/13336)src.desktoptojson100% (3/3)100% (3/3)79% (84/106)38% (123/324)src.lib67% (2/3)67% (2/3)60% (326/541)27% (221/821)src.lib.caching100% (2/2)100% (2/2)45% (352/787)18% (192/1076)src.lib.io90% (9/10)90% (9/10)60% (840/1397)33% (1048/3158)src.lib.jobs71% (5/7)71% (5/7)52% (159/304)39% (57/146)src.lib.plugin100% (8/8)100% (8/8)86% (648/750)44% (990/2228)src.lib.randomness100% (2/2)100% (2/2)67% (66/99)58% (44/76)src.lib.text63% (5/8)63% (5/8)46% (349/764)40% (748/1867)src.lib.util100% (10/10)100% (10/10)82% (667/818)52% (828/1604) build.log Description: Binary data
D7281: KCoreAddons: Enforce hidden symbol visibility in nested private classes
kossebau closed this revision. kossebau added a comment. Hm, I tried to close this one by adding a line Differential Revision: https://phabricator.kde.org/D7281 in the commit, but seems that was not picked up, so closing manually See eb5f8570f4aa3f6391ef0c040f55b1331e36e0c7 REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D7281 To: mpyne, #frameworks, kossebau Cc: kossebau
D7281: KCoreAddons: Enforce hidden symbol visibility in nested private classes
kossebau accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D7281 To: mpyne, #frameworks, kossebau Cc: kossebau
D7279: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN
This revision was automatically updated to reflect the committed changes. Closed by commit R236:359c0d18fecb: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN (authored by kossebau). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7279?vs=18062&id=18163 REVISION DETAIL https://phabricator.kde.org/D7279 AFFECTED FILES src/kassistantdialog.cpp src/kcapacitybar.cpp src/kcharselect.cpp src/kcolorbutton.cpp src/kdatepicker.cpp src/kfontchooser.cpp src/kfontrequester.cpp src/kfontsizeaction.cpp src/kled.cpp src/kmimetypechooser.cpp src/knewpassworddialog.cpp src/knewpasswordwidget.cpp src/kpagewidgetmodel.cpp src/kpassworddialog.cpp src/kpixmapregionselectordialog.cpp src/kpixmapregionselectorwidget.cpp src/kpixmapsequence.cpp src/kpixmapsequenceoverlaypainter.cpp src/kpixmapsequencewidget.cpp src/kpopupframe.cpp src/kratingpainter.cpp src/kratingwidget.cpp src/kselector.cpp src/ksplittercollapserbutton.cpp src/ktitlewidget.cpp src/ktoggleaction.cpp src/ktogglefullscreenaction.cpp src/ktoolbarlabelaction.cpp src/ktoolbarpopupaction.cpp src/ktooltipwidget.cpp src/kurllabel.cpp src/kxyselector.cpp To: kossebau, cfeck, dfaure, vkrause, mlaurent Cc: dhaumann, apol, #frameworks
D7316: Avoid sending data offers from an invalid source.
davidedmundson created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY A DataDevice will have a source when offers are available, but it can also be legitimately cleared. When calling DataDeviceInterface::sendSelection(DataDeviceInterface *other) if the other data device has no source, we should be setting that we also have no source. In addition this also guards against Seat tracking a DataDeviceInterface with no source when trying to sync x clipboards. BUG: 383054 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7316 AFFECTED FILES autotests/client/test_wayland_seat.cpp src/server/datadevice_interface.cpp To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6972: Add CC BY-SA 4.0 International and set it as default
ltoscano added a comment. Ping! REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D6972 To: ltoscano, jriddell, lueck, yurchor Cc: jriddell, lueck, #frameworks, #documentation, skadinna
D7296: Restore behaviour of KKeyServer::symXToKeyQt
This revision was automatically updated to reflect the committed changes. Closed by commit R278:53ab31c663e6: Restore behaviour of KKeyServer::symXToKeyQt (authored by dfaure). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7296?vs=18109&id=18159 REVISION DETAIL https://phabricator.kde.org/D7296 AFFECTED FILES src/platforms/xcb/kkeyserver.cpp To: dfaure, graesslin Cc: #frameworks
D7293: Deprecate KStandardAction::SaveOptions
elvisangelaccio updated this revision to Diff 18155. elvisangelaccio added a comment. - @deprecated since... REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7293?vs=18094&id=18155 BRANCH deprecate-saveoptions REVISION DETAIL https://phabricator.kde.org/D7293 AFFECTED FILES src/kstandardaction.cpp src/kstandardaction.h To: elvisangelaccio, #frameworks
D7292: Deprecate KStandardAction::Help
elvisangelaccio updated this revision to Diff 18154. elvisangelaccio added a comment. - @deprecated since... REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7292?vs=18093&id=18154 BRANCH deprecate-help REVISION DETAIL https://phabricator.kde.org/D7292 AFFECTED FILES src/kstandardaction.cpp src/kstandardaction.h To: elvisangelaccio, #frameworks Cc: dhaumann
D7296: Restore behaviour of KKeyServer::symXToKeyQt
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D7296 To: dfaure, graesslin Cc: #frameworks
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 42 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/42/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 14 Aug 2017 16:57:26 + Build duration: 41 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests build.log Description: Binary data
D7289: Rewrite the email syntax definition
This revision was automatically updated to reflect the committed changes. Closed by commit R216:b54210c3e238: Rewrite the email syntax definition (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7289?vs=18106&id=18150#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7289?vs=18106&id=18150 REVISION DETAIL https://phabricator.kde.org/D7289 AFFECTED FILES autotests/html/test.eml.html autotests/reference/test.eml.ref data/syntax/email.xml To: vkrause, #framework_syntax_hightlighting, kwrite-devel, dhaumann Cc: dhaumann, #frameworks
D7287: Improve KStandardAction apidox.
elvisangelaccio requested review of this revision. elvisangelaccio marked an inline comment as done. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D7287 To: elvisangelaccio, #frameworks, dhaumann Cc: dhaumann
D7287: Improve KStandardAction apidox.
elvisangelaccio updated this revision to Diff 18146. elvisangelaccio added a comment. - Improve GoTo doc. REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7287?vs=18098&id=18146 BRANCH improve-apidox REVISION DETAIL https://phabricator.kde.org/D7287 AFFECTED FILES src/kstandardaction.h To: elvisangelaccio, #frameworks, dhaumann Cc: dhaumann
D7292: Deprecate KStandardAction::Help
elvisangelaccio added a comment. In https://phabricator.kde.org/D7292#135318, @dhaumann wrote: > Not sure, but is that reason enough to deprecate API? This doesn't sound convincing yet... Well, I can think of other reasons: - you wouldn't add a new enum value unless there is a good reason to (and a real use case). So why keep an unused value? - If we do keep it around, we should document it in https://phabricator.kde.org/D7287, but how? It's not clear what this action is supposed to do. - Less code to maintain/fix/port in the long term. If someone complains, I guess we can always un-deprecate it? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D7292 To: elvisangelaccio, #frameworks Cc: dhaumann
D7253: Add build-flatpak target if there is a flatpak recipe around
elvisangelaccio abandoned this revision. elvisangelaccio added a comment. In https://phabricator.kde.org/D7253#135251, @apol wrote: > Ugh my bad ^^', I don't know what happened. > > > The reason why I'm discussing this is that I think one of the advantages of Flatpak > > is that it makes it much easier to set up the build environment. Documented dependencies and tooling that integrates it. We need to leverage that rather than hiding it in the current state which while it works it's overly complex and part of a problem to solve. This is a good point indeed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7253 To: elvisangelaccio, apol, #frameworks Cc: cgiboudeaux, #frameworks, #build_system
D7078: [server] Fix crash when sending selection to a DDI without a DataSource
graesslin added a comment. > If your patch works, then mine would too. It's checking the exact same pointer, just one frame earlier. But then it's an easy thing: let's do both. Your patch and mine. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7078 To: graesslin, #kwin, #plasma, #frameworks Cc: anthonyfieroni, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.7 - Build # 20 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.7/20/ Project: Frameworks kpty kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 14 Aug 2017 14:54:46 + Build duration: 40 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.kptyprocesstest build.log Description: Binary data
KDE CI: Frameworks kconfigwidgets kf5-qt5 XenialQt5.7 - Build # 22 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kconfigwidgets%20kf5-qt5%20XenialQt5.7/22/ Project: Frameworks kconfigwidgets kf5-qt5 XenialQt5.7 Date of build: Mon, 14 Aug 2017 14:46:31 + Build duration: 1 min 16 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (2/2)52% (12/23)52% (12/23)35% (863/2478)28% (412/1493)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (4/4)100% (4/4)97% (290/299)51% (182/360)src42% (8/19)42% (8/19)26% (573/2179)20% (230/1133) build.log Description: Binary data
KDE CI: Frameworks kpeople kf5-qt5 XenialQt5.7 - Build # 18 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kpeople%20kf5-qt5%20XenialQt5.7/18/ Project: Frameworks kpeople kf5-qt5 XenialQt5.7 Date of build: Mon, 14 Aug 2017 14:45:46 + Build duration: 1 min 49 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (3/3)79% (27/34)79% (27/34)69% (751/1090)42% (358/857)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (8/8)100% (8/8)99% (202/204)47% (131/276)src63% (10/16)63% (10/16)59% (458/782)38% (210/547)src.backends90% (9/10)90% (9/10)88% (91/104)50% (17/34) build.log Description: Binary data
KDE CI: Frameworks kcrash kf5-qt5 FreeBSDQt5.7 - Build # 17 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20FreeBSDQt5.7/17/ Project: Frameworks kcrash kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 14 Aug 2017 14:34:57 + Build duration: 38 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.kcrashtest build.log Description: Binary data
KDE CI: Frameworks bluez-qt kf5-qt5 XenialQt5.7 - Build # 21 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20XenialQt5.7/21/ Project: Frameworks bluez-qt kf5-qt5 XenialQt5.7 Date of build: Mon, 14 Aug 2017 14:25:02 + Build duration: 2 min 12 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 10 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (3/3)78% (67/86)78% (67/86)70% (2882/4146)42% (1761/4230)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (18/18)100% (18/18)97% (1341/1383)43% (1251/2902)src69% (37/54)69% (37/54)51% (1196/2331)38% (484/1270)src.imports86% (12/14)86% (12/14)80% (345/432)45% (26/58) build.log Description: Binary data
KDE CI: Frameworks bluez-qt kf5-qt5 FreeBSDQt5.7 - Build # 22 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20FreeBSDQt5.7/22/ Project: Frameworks bluez-qt kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 14 Aug 2017 14:25:02 + Build duration: 1 min 50 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s) build.log Description: Binary data
Re: KDE CI: Frameworks bluez-qt kf5-qt5 XenialQt5.7 - Build # 20 - Unstable!
On lundi 14 août 2017 15:58:54 CEST David Rosca wrote: > Hi, > I just fixed it yesterday and now it fails again. > What did change this time, please? That would be my changes, then. I'm working on making tests run without the need to "make install" first. I'll debug the failure, thanks for the notification. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
KDE CI: Frameworks kconfig kf5-qt5 XenialQt5.7 - Build # 27 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20XenialQt5.7/27/ Project: Frameworks kconfig kf5-qt5 XenialQt5.7 Date of build: Mon, 14 Aug 2017 13:57:14 + Build duration: 6 min 8 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 36 test(s), Skipped: 0 test(s), Total: 36 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (6/6)93% (79/85)93% (79/85)79% (6772/8551)57% (3989/6981)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (23/23)100% (23/23)100% (2031/2041)51% (1174/2288)autotests.kconfig_compiler96% (25/26)96% (25/26)92% (279/303)47% (117/248)src.core88% (21/24)88% (21/24)68% (2254/3334)54% (1306/2428)src.gui78% (7/9)78% (7/9)60% (431/713)52% (167/323)src.kconf_update100% (2/2)100% (2/2)71% (420/588)57% (268/469)src.kconfig_compiler100% (1/1)100% (1/1)86% (1357/1572)78% (957/1225) build.log Description: Binary data
Re: KDE CI: Frameworks bluez-qt kf5-qt5 XenialQt5.7 - Build # 20 - Unstable!
Hi, I just fixed it yesterday and now it fails again. What did change this time, please? Thanks, David On Mon, Aug 14, 2017 at 3:54 PM, wrote: > *BUILD UNSTABLE* > Build URL https://build.kde.org/job/Frameworks%20bluez-qt%20kf5- > qt5%20XenialQt5.7/20/ > Project: Frameworks bluez-qt kf5-qt5 XenialQt5.7 > Date of build: Mon, 14 Aug 2017 13:49:21 + > Build duration: 5 min 32 sec and counting > * JUnit Tests * > Name: (root) Failed: 8 test(s), Passed: 2 test(s), Skipped: 0 test(s), > Total: 10 test(s) > *- Failed: TestSuite.bluezqt-adaptertest* > *- Failed: TestSuite.bluezqt-agentmanagertest* > *- Failed: TestSuite.bluezqt-devicetest* > *- Failed: TestSuite.bluezqt-inputtest* > *- Failed: TestSuite.bluezqt-managertest* > *- Failed: TestSuite.bluezqt-mediaplayertest* > *- Failed: TestSuite.bluezqt-obexmanagertest* > *- Failed: TestSuite.bluezqt-qmltests* > * Cobertura Report * > * Project Coverage Summary * > Name Packages Files Classes Lines Conditionals > Cobertura Coverage Report 100% (3/3) 48% (41/86) 48% (41/86) 18% > (735/4146) 5% (225/4230) > Coverage Breakdown by Package > Name Files Classes Lines Conditionals > autotests 100% (18/18) 100% (18/18) 32% (440/1383) 6% (163/2902) > src 35% (19/54) 35% (19/54) 11% (264/2331) 4% (57/1270) > src.imports 29% (4/14) 29% (4/14) 7% (31/432) 9% (5/58) >
KDE CI: Frameworks bluez-qt kf5-qt5 XenialQt5.7 - Build # 20 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20XenialQt5.7/20/ Project: Frameworks bluez-qt kf5-qt5 XenialQt5.7 Date of build: Mon, 14 Aug 2017 13:49:21 + Build duration: 5 min 32 sec and counting JUnit Tests Name: (root) Failed: 8 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.bluezqt-adaptertestFailed: TestSuite.bluezqt-agentmanagertestFailed: TestSuite.bluezqt-devicetestFailed: TestSuite.bluezqt-inputtestFailed: TestSuite.bluezqt-managertestFailed: TestSuite.bluezqt-mediaplayertestFailed: TestSuite.bluezqt-obexmanagertestFailed: TestSuite.bluezqt-qmltests Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (3/3)48% (41/86)48% (41/86)18% (735/4146)5% (225/4230)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (18/18)100% (18/18)32% (440/1383)6% (163/2902)src35% (19/54)35% (19/54)11% (264/2331)4% (57/1270)src.imports29% (4/14)29% (4/14)7% (31/432)9% (5/58) build.log Description: Binary data
KDE CI: Frameworks bluez-qt kf5-qt5 FreeBSDQt5.7 - Build # 21 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20FreeBSDQt5.7/21/ Project: Frameworks bluez-qt kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 14 Aug 2017 13:49:21 + Build duration: 3 min 6 sec and counting JUnit Tests Name: (root) Failed: 8 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.bluezqt-adaptertestFailed: TestSuite.bluezqt-agentmanagertestFailed: TestSuite.bluezqt-devicetestFailed: TestSuite.bluezqt-inputtestFailed: TestSuite.bluezqt-managertestFailed: TestSuite.bluezqt-mediaplayertestFailed: TestSuite.bluezqt-obexmanagertestFailed: TestSuite.bluezqt-qmltests build.log Description: Binary data
KDE CI: Frameworks kimageformats kf5-qt5 XenialQt5.7 - Build # 9 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20XenialQt5.7/9/ Project: Frameworks kimageformats kf5-qt5 XenialQt5.7 Date of build: Mon, 14 Aug 2017 13:15:45 + Build duration: 1 min 12 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-xcf Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (3/3)96% (23/24)96% (23/24)47% (1609/3445)38% (844/2245)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (3/3)100% (3/3)74% (296/401)52% (121/234)src.imageformats95% (19/20)95% (19/20)43% (1309/3032)36% (721/2003)tests100% (1/1)100% (1/1)33% (4/12)25% (2/8) build.log Description: Binary data
KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.7 - Build # 22 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/22/ Project: Frameworks krunner kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 14 Aug 2017 13:06:57 + Build duration: 2 min 5 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.runnercontexttest build.log Description: Binary data
KDE CI: Frameworks kxmlgui kf5-qt5 XenialQt5.7 - Build # 32 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20XenialQt5.7/32/ Project: Frameworks kxmlgui kf5-qt5 XenialQt5.7 Date of build: Mon, 14 Aug 2017 12:39:40 + Build duration: 4 min 2 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (2/2)57% (39/68)57% (39/68)43% (4040/9301)34% (2212/6481)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (11/11)100% (11/11)99% (1360/1372)49% (610/1236)src49% (28/57)49% (28/57)34% (2680/7929)31% (1602/5245) build.log Description: Binary data
D7279: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN
dhaumann added a comment. As a side note: Leaking the visibility of nested classes is almost something that could be mentioned in [1]. Then again, this is only a BC issue, if these nested classes are used/accessible in public API. [1] https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B REPOSITORY R236 KWidgetsAddons BRANCH dontleaksymbolsofpimplclasses REVISION DETAIL https://phabricator.kde.org/D7279 To: kossebau, cfeck, dfaure, vkrause, mlaurent Cc: dhaumann, apol, #frameworks
D7289: Rewrite the email syntax definition
dhaumann added a comment. OK, sounds sane. Please commit, no need for another review round. Thanks! REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D7289 To: vkrause, #framework_syntax_hightlighting, kwrite-devel, dhaumann Cc: dhaumann, #frameworks
D7289: Rewrite the email syntax definition
vkrause added a comment. Correct, any highlighting of the body content is gone, intentionally. The original highlighting was from a time when emails had 4-5 human readable headers and ASCII bodys. At that time body highlighting made sense, and even reading emails in kate was feasible. Nowadays you have hundreds of lines of headers, some containing only machine-readable signature blobs etc, and bodys with Unicode content and attachments which have been encoded into more or less unreadable gibberish. Therefore I think the purpose of this highlighting nowadays is for diagnostics, not for reading (or even writing) email. I'll add the missing spellchecking attributes. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D7289 To: vkrause, #framework_syntax_hightlighting, kwrite-devel, dhaumann Cc: dhaumann, #frameworks
KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 55 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/55/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 14 Aug 2017 11:31:33 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 64 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.bug205447Failed: TestSuite.kateindenttest_testCstyle build.log Description: Binary data
Re: Tests leaving behind large temporary files
Hello Ben, On Mon, Aug 14, 2017 at 10:59:49PM +1200, Ben Cooksley wrote: > Could someone please investigate, determine which test(s) are > responsible and fix those tests to cleanup after themselves? > I did some investigation on those left-out files, and it seems it's not the code of frameworks but code of CI itself leaving those files, I found a small file "/tmp/tmp8ubko4sx" on FreeBSD builder, looking at trings of the file, # strings /tmp/tmp8ubko4sx checksum: 39909cda53863cdc13d719a7b800f5abf6a2e73eb89270c26f3cf94ce4dbc570 scmRevision: null timestamp: 1502708857.009341 And then I looked at the ci builder code and turns out those parts come from the capture-workspace.py code of ci-tooling. We need to make that code failproof it seems instead of the frameworks code. Thanks! -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
D5799: Rebase Less syntax highlighting on SCSS one
jtamate requested changes to this revision. jtamate added a comment. This revision now requires changes to proceed. Hello, To be able to compile with the current frameworks, I have had to remove the leading/trailing spaces: "/5kde/frameworks/syntax-highlighting/data/syntax/less.xml" line 19 keyword with leading/trailing spaces: " align-content " "/5kde/frameworks/syntax-highlighting/data/syntax/less.xml" line 20 keyword with leading/trailing spaces: " align-items " "/5kde/frameworks/syntax-highlighting/data/syntax/less.xml" line 21 keyword with leading/trailing spaces: " align-self " "/5kde/frameworks/syntax-highlighting/data/syntax/less.xml" line 22 keyword with leading/trailing spaces: " alignment-baseline " Apart from that, it highlights without problems all the .less files I have tried. Therefore, once the spaces are fixed, you have my ship it! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5799 To: gszymaszek, #framework_syntax_hightlighting, jtamate Cc: jtamate, dhaumann, #frameworks, cullmann, vkrause
KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 39 - Still unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/39/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 14 Aug 2017 11:02:53 + Build duration: 5 min 33 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 22 test(s)Failed: TestSuite.kdirwatch_stat_unittestFailed: TestSuite.kshelltest build.log Description: Binary data
Tests leaving behind large temporary files
Hi all, Since the deployment of the new CI system we've been noticing that disk usage on the FreeBSD and Windows builders is adversely impacted upon by tests leaving significantly large files in the temporary file directories. Just today two of the FreeBSD Builders were knocked out by these files being left behind. Cleanup of less than 100 files released over 170gb of space. These files follow the naming pattern of 'tmpbn760szs'. Given that both FreeBSD and Windows are affected, the following projects are the key suspects for these files: - Frameworks - KDevelop Could someone please investigate, determine which test(s) are responsible and fix those tests to cleanup after themselves? Regards, Ben Cooksley KDE Sysadmin
D7304: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN
davidedmundson created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Nested classes inherit the visibility of their outer class, so all the KClass::Private symbols have also been exported if the ones of KClass were. See also https://phabricator.kde.org/D7279 TEST PLAN Ran nm -DC to list symbols Only changed visibility of classes defined in .cpp files, so no client code should be affected. REPOSITORY R127 KWayland BRANCH davidedmundson/xdgv6 REVISION DETAIL https://phabricator.kde.org/D7304 AFFECTED FILES src/client/blur.cpp src/client/buffer_p.h src/client/compositor.cpp src/client/connection_thread.cpp src/client/contrast.cpp src/client/datadevice.cpp src/client/datadevicemanager.cpp src/client/dataoffer.cpp src/client/datasource.cpp src/client/dpms.cpp src/client/event_queue.cpp src/client/fakeinput.cpp src/client/fullscreen_shell.cpp src/client/idle.cpp src/client/keyboard.cpp src/client/output.cpp src/client/outputconfiguration.cpp src/client/outputdevice.cpp src/client/outputmanagement.cpp src/client/plasmashell.cpp src/client/plasmawindowmanagement.cpp src/client/plasmawindowmodel.cpp src/client/pointer.cpp src/client/pointerconstraints.cpp src/client/pointergestures.cpp src/client/region.cpp src/client/registry.cpp src/client/relativepointer.cpp src/client/seat.cpp src/client/server_decoration.cpp src/client/shadow.cpp src/client/shell.cpp src/client/shm_pool.cpp src/client/slide.cpp src/client/subcompositor.cpp src/client/subsurface.cpp src/client/surface.cpp src/client/textinput_p.h src/client/touch.cpp src/client/xdgshell_p.h To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6899: support X-KDE-OnlyShowOnQtPlatforms
This revision was automatically updated to reflect the committed changes. Closed by commit R297:937ade5d7357: support X-KDE-OnlyShowOnQtPlatforms (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6899?vs=17177&id=18132#toc REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6899?vs=17177&id=18132 REVISION DETAIL https://phabricator.kde.org/D6899 AFFECTED FILES src/kded.cpp src/kded.h To: mart, #frameworks, #plasma, davidedmundson Cc: dfaure, plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6964: Force Plasma style for QQC2 in applets
mart added a comment. ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6964 To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6899: support X-KDE-OnlyShowOnQtPlatforms
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R297 KDED BRANCH master REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma, davidedmundson Cc: dfaure, plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6899: support X-KDE-OnlyShowOnQtPlatforms
mart added a comment. ping? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: dfaure, plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 41 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/41/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 14 Aug 2017 09:04:03 + Build duration: 40 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests build.log Description: Binary data
D7078: [server] Fix crash when sending selection to a DDI without a DataSource
davidedmundson added a comment. > of course we do that :-) We're not. Kwin does not check if a client has a selection. It merely checks if the client has an interface from a selection can be fetched, it does not check that device actually has a valid selection. > you think that we should not even send out the DataOffer I think that's a separate thing, No, that's not what I think. We're getting crosswired. I'll submit my coment as a patch, so maybe you'll understand what I'm trying to say. --- > Please note that I doubt that your suggestion would help against the crash I fixed here. If your patch works, then mine would too. It's checking the exact same pointer, just one frame earlier. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7078 To: graesslin, #kwin, #plasma, #frameworks Cc: anthonyfieroni, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D7289: Rewrite the email syntax definition
dhaumann added a comment. Ah, one more thing: we probably can add spellChecking="false" for some item datas... REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D7289 To: vkrause, #framework_syntax_hightlighting, kwrite-devel, dhaumann Cc: dhaumann, #frameworks
D7297: Add Pony highlighting
dhaumann added a comment. Looks already quite good. But I think one more iteration to especially fix the licensing would be nice. INLINE COMMENTS > foldingtest.pony:2 > +/* > +Copyright (C) 2016 Volker Krause > + Is this file intentionally added? > highlight.pony:1 > +primitive Red fun apply(): U32 => 0x > + Can you add a license as comment? MIT license is preferred. > pony.xml:11 > +]> > + + name="Pony" section="Sources" Can you add license="MIT" as license? > pony.xml:283 > + > + > + You may want to add # to the weakDeliminator list, to make cursor navigation like ctrl+left work correctly, since some keywords contain #. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7297 To: jpoelen, #framework_syntax_hightlighting Cc: dhaumann, #frameworks, cullmann, vkrause
D7253: Add build-flatpak target if there is a flatpak recipe around
cgiboudeaux added inline comments. INLINE COMMENTS > KDECMakeSettings.cmake:361 > +function(_find_json_recipe json_recipe) > +execute_process(COMMAND git ls-files *org.kde.*.json > +OUTPUT_VARIABLE json find_package(Git) if(Git_FOUND) execute_process(COMMAND GIT_EXECUTABLE... else() print some message REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7253 To: elvisangelaccio, apol, #frameworks Cc: cgiboudeaux, #frameworks, #build_system
