BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.9/37/
Project:
Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sat, 25 Nov 2017 03:29:25 +
Build duration:
6 min 6 sec and counting
JUnit T
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.9/23/
Project:
Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sat, 25 Nov 2017 01:56:50 +
Build duration:
5 min 4 sec and counting
JUn
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/6/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
Date of build:
Sat, 25 Nov 2017 01:56:50 +
Build duration:
3 min 47 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/4/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
Date of build:
Sat, 25 Nov 2017 01:56:50 +
Build duration:
3 min 19 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/65/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Sat, 25 Nov 2017 01:56:50 +
Build duration:
2 min 22 sec and counting
JUnit Test
apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
If it didn't parse properly, we'd better know first.
TEST PLAN
Managed to figure out what was wrong with my file
REPOSITORY
R244 KCoreAddons
BRANCH
master
kossebau added inline comments.
INLINE COMMENTS
> elvisangelaccio wrote in kjobtrackerinterface.h:73
> Probably yes, should we add a TODO comment for KF6?
And for the protected, not sure, it feels unbalanced to me. But something to
think about at time of KF6, so yes, add a (non-doxygen) comment
kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.
(Sorry, forgot about this one, subscribed too to many diffs in the
phabricator view)
Looks good to me in general. Added some comments you might want to consider,
but are free to ig
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20WindowsMSVCQt5.9/14/
Project:
Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9
Date of build:
Fri, 24 Nov 2017 22:28:34 +
Build duration:
3 min 25 sec and counting
svuorela accepted this revision.
REPOSITORY
R280 Prison
REVISION DETAIL
https://phabricator.kde.org/D8546
To: vkrause, #frameworks, svuorela, dfaure
Cc: dfaure, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R282:f9079223401e: Remove redundant map look-ups (authored by
apol).
REPOSITORY
R282 NetworkManagerQt
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8976?vs=22851&id=22905
REVISION DETAIL
ht
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
I like the GridView
Note that we'll want to use that from the WallpaperDialog in Plasma, which
isn't a KCM. I don't think it will be a problem though ?
We
franckarrecot added inline comments.
INLINE COMMENTS
> ervin wrote in kfileplacesview.cpp:863-866
> I still stand by that comment, I'd welcome a patch on top of that one to
> reduce that duplication please.
Oki I add that to my list :-)
> ervin wrote in kfileplacesview.cpp:298
> That smells st
franckarrecot updated this revision to Diff 22900.
franckarrecot added a comment.
rebased over in review renato 's patches
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8366?vs=21750&id=22900
REVISION DETAIL
https://phabricator.kde.org/D8366
AFFECTED FILES
franckarrecot marked 3 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent
Cc: mwolff, #frameworks
franckarrecot updated this revision to Diff 22902.
franckarrecot marked an inline comment as done.
franckarrecot added a comment.
rebased over in review renato 's patches
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8450?vs=22734&id=22902
REVISION DETAIL
h
franckarrecot updated this revision to Diff 22901.
franckarrecot added a comment.
rebased over in review renato 's patches
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=22726&id=22901
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
mart updated this revision to Diff 22897.
mart added a comment.
- use the actual scrollbar width
- more sophisticated implicit size for kcms
- size hints for the simple kcm
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8982?vs=22885&id=22897
BRAN
franckarrecot commandeered this revision.
franckarrecot edited reviewers, added: mlaurent; removed: franckarrecot.
REVISION DETAIL
https://phabricator.kde.org/D8366
To: franckarrecot, renatoo, ervin, mlaurent
Cc: ervin, ngraham, mlaurent, #frameworks
franckarrecot marked 5 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8367
To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks
franckarrecot added inline comments.
INLINE COMMENTS
> ervin wrote in kfileplacesmodel.cpp:870
> Why not naming the variable isGroupHidden and use the :: prefix on the
> function call like milian proposed?
Because it wouldn't compile without the whole KFIlePlacesModel:: prefix, so I
end up goi
renatoo marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin, mlaurent, dfaure, mwolff
Cc: mwolff, dfaure, ervin, usta, mlaurent, dvratil, ngraham, #framew
davidedmundson updated this revision to Diff 22890.
davidedmundson marked 8 inline comments as done.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
Docs++
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricat
ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> ervin wrote in kfileplacesview.cpp:863-866
> This duplicates code from the next if branch below... I wonder if before or
> after that commit we shouldn't try to
ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.
A small nitpick otherwise lgtm.
INLINE COMMENTS
> kfileplacesmodel.cpp:870
>
> -bookmark.setMetaDataItem(QStringLiteral("IsHidden"), (hidden ?
> QStringLiteral("true") : QStr
mart added inline comments.
INLINE COMMENTS
> hein wrote in GridDelegate.qml:130
> Do these numbers align with anything? Then a comment pointing at where else
> we use them would be good.
>
> Or maybe use multiples of long/short duration? Or makes no sense?
>
> Same question about the other si
ervin accepted this revision.
ervin added inline comments.
INLINE COMMENTS
> renatoo wrote in kfileplacesmodel.cpp:68
> This code came from dolphin. And it does not check at runtime for changes on
> the configuration.
>
> But yes I agree keep track of this will be nice, I thought about that whi
hein added inline comments.
INLINE COMMENTS
> GridDelegate.qml:130
> +enabled: modelData.enabled
> +Controls.ToolTip.delay: 1000
> +Controls.ToolTip.timeout: 5000
Do these numbers align with anything? Then a comm
mart updated this revision to Diff 22885.
mart added a comment.
- include SimpleKCM
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8982?vs=22883&id=22885
BRANCH
phab/kcmodules
REVISION DETAIL
https://phabricator.kde.org/D8982
AFFECTED FILES
sr
mart added a reviewer: hein.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D8982
To: mart, #plasma, hein
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
schwab created this revision.
schwab added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Use the C locale when parsing dates in cookies, since only English week
and month names are allowed
BU
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
the base C++ class for qml-based kcms is already there,
KQuickAddons::ConfigModule, so this
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.9/66/
Project:
Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9
Date of build:
Fri, 24 Nov 2017 09:41:27 +
Build duration:
27 min and counting
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/151/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 24 Nov 2017 09:41:27 +
Build duration:
10 min and counting
JUnit
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/8/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Fri, 24 Nov 2017 09:41:27 +
Build duration:
8 min 37 sec and counting
JUnit T
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/5/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Fri, 24 Nov 2017 09:41:27 +
Build duration:
8 min 10 sec and counting
JUnit
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f395097fe90b: [Containment Interface] Set
WA_TranslucentBackground before accessing winId() (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phab
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:facaaf93d016: [PlasmaComponents Menu] Set
WA_TranslucentBackground on the underlying QMenu (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabr
broulik updated this revision to Diff 22874.
broulik added a comment.
- Use `qFuzzyIsNull`
REPOSITORY
R292 KUnitConversion
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8971?vs=22838&id=22874
REVISION DETAIL
https://phabricator.kde.org/D8971
AFFECTED FILES
CMakeLists.txt
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:64915e0291cd: ecm_add_test: Use proper path sep on
Windows (authored by kfunk).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8979?vs=22863&id=22869
R
bcooksley accepted this revision.
bcooksley added a comment.
Looks fine to me.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8979
To: kfunk, dfaure, cgiboudeaux, bcooksley
Cc: #windows, #frameworks, #build_system
41 matches
Mail list logo
