[sysadmin/ci-tooling] helpers: Don't allow the dependency diagram data generation process to run on secondary platforms either.

2018-01-22 Thread Ben Cooksley
Git commit 15c5d9a75f87ff5ac78fd8aff2824faa6fdaa349 by Ben Cooksley. Committed on 23/01/2018 at 07:41. Pushed by bcooksley into branch 'master'. Don't allow the dependency diagram data generation process to run on secondary platforms either. This runs into the same issue that the cmake dependency

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 75 - Still Unstable!

2018-01-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/75/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 23 Jan 2018 04:10:28 + Build duration: 23 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 26 - Fixed!

2018-01-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/26/ Project: Frameworks baloo kf5-qt5 SUSEQt5.7 Date of build: Tue, 23 Jan 2018 01:08:43 + Build duration: 12 min and counting JUnit Tests Name: (root) Fai

D9983: Don't stat(/etc/localtime) between read() and write() copying files

2018-01-22 Thread Fabian Vogt
fvogt resigned from this revision. fvogt added a comment. This should work now - I won't give the revision a total accept though as I didn't test it myself. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9983 To: jtamate, #frameworks Cc: fvogt, ngraham

D10017: Find Aspell dictionaries on Windows

2018-01-22 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R246:9038a8effc41: Find Aspell dictionaries on Windows (authored by leinir). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10017?vs=25749&id=25784 REVISION DETAIL htt

D9983: Don't stat(/etc/localtime) between read() and write() copying files

2018-01-22 Thread Jaime Torres Amate
jtamate updated this revision to Diff 25783. jtamate added a comment. - Don't stat(/etc/localtime) between read() and write() copying files Fix logic of cancelations REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9983?vs=25644&id=25783 BRANCH timer (b

D9983: Don't stat(/etc/localtime) between read() and write() copying files

2018-01-22 Thread Jaime Torres Amate
jtamate added a comment. In https://phabricator.kde.org/D9983#194505, @fvogt wrote: > Just a quick idea, it might be wrong: If you use a `QTimer` instead of `QElapsedTimer`, you can get rid of `nextTimeoutMsecs`. This would also simplify the logic a bit. QTimer and I have a stran

D9983: Don't stat(/etc/localtime) between read() and write() copying files

2018-01-22 Thread Fabian Vogt
fvogt added a comment. Just a quick idea, it might be wrong: If you use a `QTimer` instead of `QElapsedTimer`, you can get rid of `nextTimeoutMsecs`. This would also simplify the logic a bit. INLINE COMMENTS > jtamate wrote in slavebase.cpp:279 > Reading the documentation http://doc.qt.io/q

D9983: Don't stat(/etc/localtime) between read() and write() copying files

2018-01-22 Thread Jaime Torres Amate
jtamate added inline comments. INLINE COMMENTS > fvogt wrote in slavebase.cpp:279 > In the old code the timeout was canceled here, but now it gets started again > instead. Reading the documentation http://doc.qt.io/qt-5/qelapsedtimer.html I'm not able to say if start() will restart a timer or c

D9983: Don't stat(/etc/localtime) between read() and write() copying files

2018-01-22 Thread Fabian Vogt
fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > slavebase.cpp:279 > QByteArray data = d->timeoutData; > -d->nextTimeout = QDateTime(); > +d->nextTimeout.start(); >

D10024: Add supportedSchemes feature

2018-01-22 Thread Aleix Pol Gonzalez
apol added a comment. Makes sense I guess. Sounds like it would be useful to set this through kiosk, would that work? INLINE COMMENTS > kdiroperator.cpp:2650 > +{ > +d->supportedSchemes = schemes; > +rereadDir(); only if d->supportedSchemes != schemes? REPOSITORY R241 KIO RE

D10026: Fix loading NotifyByExecute

2018-01-22 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, hein. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY Looks like a copy paste error CHANGELOG: The "Run Command" notification action has been fixed BUG: 3

KDE CI: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 - Build # 4 - Still Failing!

2018-01-22 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/4/ Project: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 Date of build: Mon, 22 Jan 2018 16:29:12 + Build duration: 6 min 37 sec and counting CONSOLE OUT

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.9 - Build # 4 - Still Unstable!

2018-01-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/4/ Project: Frameworks purpose kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 22 Jan 2018 16:29:12 + Build duration: 4 min 0 sec and counting JUnit Tests N

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 4 - Still Unstable!

2018-01-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/4/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Mon, 22 Jan 2018 16:29:12 + Build duration: 2 min 56 sec and counting JUnit Tests Name

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 4 - Still Failing!

2018-01-22 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/4/ Project: Frameworks purpose kf5-qt5 SUSEQt5.7 Date of build: Mon, 22 Jan 2018 16:29:11 + Build duration: 2 min 14 sec and counting CONSOLE OUTPUT [...

D10024: Add supportedSchemes feature

2018-01-22 Thread Milian Wolff
mwolff added a dependent revision: D10025: Use KFileWidget::setSupportedSchemes when available. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10024 To: mwolff, #plasma, dfaure Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abe

D10024: Add supportedSchemes feature

2018-01-22 Thread Milian Wolff
mwolff created this revision. mwolff added reviewers: Plasma, dfaure. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. mwolff requested review of this revision. REVISION SUMMARY This addds a whitelist of supported URL

Re: KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 2 - Still Unstable!

2018-01-22 Thread Aleix Pol
How could I reproduce this? I can only reproduce it with a system without QT_PLUGIN_PATH properly defined. On Sun, Jan 21, 2018 at 8:51 PM, CI System wrote: > *BUILD UNSTABLE* > Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5- > qt5%20SUSEQt5.10/2/ > Project: Frameworks purpose kf

D10020: add a workaround to mark snap bundle mounts as hidden

2018-01-22 Thread Harald Sitter
sitter abandoned this revision. sitter added a comment. Ah. I like his patch better. Thanks REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10020 To: sitter, apol Cc: bshah, broulik, #frameworks

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 3 - Still Failing!

2018-01-22 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/3/ Project: Frameworks purpose kf5-qt5 SUSEQt5.7 Date of build: Mon, 22 Jan 2018 13:48:35 + Build duration: 8 min 3 sec and counting CONSOLE OUTPUT [...t

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.9 - Build # 3 - Still Unstable!

2018-01-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/3/ Project: Frameworks purpose kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 22 Jan 2018 13:48:35 + Build duration: 4 min 4 sec and counting JUnit Tests N

KDE CI: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 - Build # 3 - Still Failing!

2018-01-22 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/3/ Project: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 Date of build: Mon, 22 Jan 2018 13:48:35 + Build duration: 2 min 11 sec and counting CONSOLE OUT

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 3 - Still Unstable!

2018-01-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/3/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Mon, 22 Jan 2018 13:48:35 + Build duration: 2 min 11 sec and counting JUnit Tests Name

D10020: add a workaround to mark snap bundle mounts as hidden

2018-01-22 Thread Bhushan Shah
bshah added subscribers: broulik, bshah. bshah added a comment. umm, @broulik had a patch for this somewhere... https://phabricator.kde.org/D9895 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10020 To: sitter, apol Cc: bshah, broulik, #frameworks

D10020: add a workaround to mark snap bundle mounts as hidden

2018-01-22 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. sitter requested review of this revision. REVISION SUMMARY snap bundles are loop mounted into the file system, the more bundles

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 35 - Still Unstable!

2018-01-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/35/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Mon, 22 Jan 2018 12:41:55 + Build duration: 13 min and counting JUnit Tests N

D10017: Find Aspell dictionaries on Windows

2018-01-22 Thread Hannah von Reth
vonreth accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D10017 To: leinir, vonreth Cc: #frameworks

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 30 - Still Unstable!

2018-01-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/30/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Mon, 22 Jan 2018 12:41:55 + Build duration: 6 min 33 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 19 - Still Unstable!

2018-01-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/19/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 22 Jan 2018 12:41:55 + Build duration: 7 min 1 sec and counting JUnit Test

KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9 - Build # 49 - Failure!

2018-01-22 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.9/49/ Project: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9 Date of build: Mon, 22 Jan 2018 12:41:55 + Build duration: 2 min 25 sec and counting CO

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

2018-01-22 Thread Veluri Mithun
This revision was automatically updated to reflect the committed changes. Closed by commit R244:53f3dce3f012: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ) (authored by velurimithun). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9420?vs=257

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 24 - Still unstable!

2018-01-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/24/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 Date of build: Mon, 22 Jan 2018 12:09:05 + Build duration: 19 min and counting JUnit Tests

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

2018-01-22 Thread Laurent Montel
mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R244 KCoreAddons BRANCH complieWithoutRemoveDef REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: dfaure, #frameworks

D10017: Find Aspell dictionaries on Windows

2018-01-22 Thread Dan Leinir Turthra Jensen
leinir created this revision. leinir added a reviewer: vonreth. leinir added a project: Frameworks. Restricted Application added a subscriber: Frameworks. leinir requested review of this revision. REVISION SUMMARY This feeds the sonnet aspell plugin some information to assist it in locating dic

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 23 - Failure!

2018-01-22 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/23/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 Date of build: Mon, 22 Jan 2018 11:40:35 + Build duration: 28 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 23 - Still Unstable!

2018-01-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/23/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Mon, 22 Jan 2018 11:58:23 + Build duration: 9 min 40 sec and counting JUnit

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 18 - Still Unstable!

2018-01-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/18/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 22 Jan 2018 11:53:20 + Build duration: 12 min and counting JUnit T

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 22 - Still Unstable!

2018-01-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/22/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Mon, 22 Jan 2018 11:40:35 + Build duration: 17 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 17 - Still Unstable!

2018-01-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/17/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 22 Jan 2018 11:40:35 + Build duration: 12 min and counting JUnit T

D8428: Fix cross-compiling with MinGW (MXE)

2018-01-22 Thread Ralf Habacker
This revision was automatically updated to reflect the committed changes. Closed by commit R303:f14ae9d70886: Fix cross-compiling with MinGW (MXE) (authored by vpinon, committed by habacker). REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8428?vs=21141&id=25748

D9831: Add Windows notes for network related test applications

2018-01-22 Thread Ralf Habacker
This revision was automatically updated to reflect the committed changes. Closed by commit R239:a874b6a67643: Add Windows notes for network related test applications (authored by habacker). Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks.

D9468: Refactor Solid::NetworkingPrivate to have a shared and platform specific implementation

2018-01-22 Thread Ralf Habacker
This revision was automatically updated to reflect the committed changes. Closed by commit R239:1d1af3e51407: Refactor Solid::NetworkingPrivate to have a shared and platform specific… (authored by habacker). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.or

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 52 - Still Unstable!

2018-01-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/52/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Mon, 22 Jan 2018 10:10:55 + Build duration: 22 min and counting JUnit Tests

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 49 - Still Unstable!

2018-01-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/49/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 22 Jan 2018 10:10:55 + Build duration: 9 min 32 sec and counting JUn

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 25 - Still Unstable!

2018-01-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/25/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 22 Jan 2018 10:10:55 + Build duration: 8 min 48 sec and counting

D9961: [Plasma Theme] Guard against invalid KPluginInfo object

2018-01-22 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:9870027494b5: [Plasma Theme] Guard against invalid KPluginInfo object (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9961?

D9961: [Plasma Theme] Guard against invalid KPluginInfo object

2018-01-22 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9961 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, a

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

2018-01-22 Thread Milian Wolff
This revision was automatically updated to reflect the committed changes. Closed by commit R244:78e9ffa1844e: Optimize inotify KDirWatch backend: map inotify wd to Entry (authored by mwolff). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9824?vs=25441&id=

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 29 - Still Unstable!

2018-01-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/29/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Mon, 22 Jan 2018 08:55:34 + Build duration: 13 min and counting JUnit Tests Nam

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 34 - Still Unstable!

2018-01-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/34/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Mon, 22 Jan 2018 08:55:34 + Build duration: 12 min and counting JUnit Tests N

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 18 - Still Unstable!

2018-01-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/18/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 22 Jan 2018 08:55:34 + Build duration: 4 min 37 sec and counting JUnit Tes

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

2018-01-22 Thread Milian Wolff
mwolff added a comment. In https://phabricator.kde.org/D9824#193095, @dfaure wrote: > This patch fixes a O(n) performance issue in the inotify backend using a cache, which makes KDirWatch *better* suited for applications that use KDirWatch heavily. Clearly a step in the right direction.