Re: errors building plasma-framework 5.42 (Linux)

[Kai Uwe Broulik]

Hi,

examples aren't built by default in plasma-framework which probably explains 
why they're broken..

Did a patch: https://phabricator.kde.org/D10092

Cheers
Kai Uwe

D10092: [Examples] Fix build

[Kai Uwe Broulik]

broulik edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10092

To: broulik, #plasma, rjvbb
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 - Build # 9 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/9/
 Project:
Frameworks purpose kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Thu, 25 Jan 2018 07:00:21 +
 Build duration:
8 min 6 sec and counting
   CONSOLE OUTPUT
  [...truncated 73.62 KB...]WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'WINDOWSSDKLIBVERSION  = '10.0.16299.0\'WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.16299.0\'WINDOWSSDKVERSION = '10.0.16299.0\'WORKSPACE = 'C:\CI\workspace\Frameworks purpose kf5-qt5 WindowsMSVCQt5.9'__DOTNET_ADD_64BIT= '1'__DOTNET_PREFERRED_BITNESS = '64'__VSCMD_PREINIT_PATH  = 'C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files (x86)\Git\cmd;C:\Program Files\Microsoft SQL Server\130\Tools\Binn\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'CMAKE_PREFIX_PATH = 'C:\CI\workspace\Frameworks purpose kf5-qt5 WindowsMSVCQt5.9\install-prefix;C:\CM\msvc2017x64d;C:\CM\msvc2017x64d\dev-utils'QT_PLUGIN_PATH= 'C:\CI\workspace\Frameworks purpose kf5-qt5 WindowsMSVCQt5.9\install-prefix\lib\plugins;C:\CM\msvc2017x64d\lib\qca-qt5'XDG_DATA_DIRS = 'C:\CI\workspace\Frameworks purpose kf5-qt5 WindowsMSVCQt5.9\install-prefix\share;C:\CM\msvc2017x64d\share;C:\CM\msvc2017x64d\dev-utils\share'PKG_CONFIG_PATH   = 'C:\CM\msvc2017x64d\lib\pkgconfig;C:\CM\msvc2017x64d\dev-utils\lib\pkgconfig'QMAKEFEATURES = 'C:\CM\msvc2017x64d\mkspecs/features'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="C:\CI\workspace\Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/install-prefix/" -G "NMake Makefiles JOM"  "C:\CI\workspace\Frameworks purpose kf5-qt5 WindowsMSVCQt5.9"-- The C compiler identification is MSVC 19.12.25834.0-- The CXX compiler identification is MSVC 19.12.25834.0-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Tried to enable sanitizers (-DECM_ENABLE_SANITIZERS=address), but compiler (MSVC) does not have sanitizer support-- Could not set up the appstream test. appstreamcli is missing.-- Found KF5CoreAddons: C:/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.43.0") -- Found Gettext: C:/CM/msvc2017x64d/dev-utils/bin/msgmerge.exe  -- Found PythonInterp: C:/Program Files/Python36-32/python.exe (found version "3.6.2") -- Found KF5I18n: C:/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.43.0") -- Found KF5Config: C:/CI/workspace/Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.43.0") -- Found KF5: success (found suitable version "5.43.0", minimum required is "5.7.0") found components:  CoreAddons I18n Config -- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Failed-- Performing Test COMPILER_HAS_DEPRECATED-- Performing Test COMPILER_HAS_DEPRECATED - Success-- qmlplugindump failed for Ubuntu.OnlineAccounts.-- Could NOT find Ubuntu.OnlineAccounts-QMLModule (missing: Ubuntu.OnlineAccounts-QMLModule_FOUND) -- qmlplugindump failed for org.kde.kdeconnect.-- Could NOT find org.kde.kdeconnect-QMLModule (missing: org.kde.kdeconnect-QMLModule_FOUND) -- qmlplugindump failed for org.kde.kquickcontrolsaddons.-- Could NOT find org.kde.kquickcontrolsaddons-QMLModule (missing: org.kde.kquickcontrolsaddons-QMLModule_FOUND) CMake Warning at src/plugins/CMakeLists.txt:27 (find_package):  By not providing "FindKAccounts.cmake" in CMAKE_MODULE_PATH this project  has asked CMake to find a package 

D10092: [Examples] Fix build

[Kai Uwe Broulik]

broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added reviewers: Plasma, rjvbb.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10092

To: broulik, #plasma, rjvbb
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10092: [Examples] Fix build

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
broulik requested review of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10092

AFFECTED FILES
  examples/dataengines/customDataContainers/customDataContainersEngine.cpp
  examples/dataengines/customDataContainers/customDataContainersEngine.h
  examples/dataengines/customDataContainers/httpContainer.cpp
  examples/dataengines/customDataContainers/httpContainer.h
  examples/dataengines/simpleEngine/simpleEngine.cpp
  examples/dataengines/sourcesOnRequest/sourcesOnRequest.cpp
  examples/dataengines/sourcesOnRequest/sourcesOnRequest.h
  examples/shell/customcorona.cpp
  examples/shell/customcorona.h
  examples/shell/main.cpp
  examples/testcontainmentactionsplugin/test.cpp
  examples/testcontainmentactionsplugin/test.h

To: broulik
Cc: #frameworks

D10072: Add APKBUILD to be highlighted as a Bash file

[Ben Cooksley]

bcooksley added a comment.


  In order for someone to approve this revision, add a reviewer, or subscribe 
it is necessary for them to have permission to edit the review.
  I have therefore unlocked the edit policy on this review.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10072

To: PureTryOut
Cc: bcooksley, #frameworks

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/7/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 25 Jan 2018 04:04:02 +
 Build duration:
9 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltestFailed: TestSuite.menutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/20)0%
(0/57)0%
(0/57)0%
(0/2065)0%
(0/1228)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests0%
(0/4)0%
(0/4)0%
(0/149)0%
(0/172)src0%
(0/8)0%
(0/8)0%
(0/284)0%
(0/229)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/141)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/4)0%
(0/4)0%
(0/243)0%
(0/84)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas0%
(0/1)0%
(0/1)0%
(0/51)0%
(0/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/121)0%
(0/44)src.quick0%
(0/2)0%
(0/2)0%
(0/5)100%
(0/0)src.widgets0%
(0/2)0%
(0/2)0%
(0/43)0%

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.9 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/7/
 Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 25 Jan 2018 04:04:02 +
 Build duration:
2 min 40 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.alternativesmodeltest

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/8/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.7
 Date of build:
Thu, 25 Jan 2018 04:04:02 +
 Build duration:
2 min 14 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltestFailed: TestSuite.menutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/20)0%
(0/57)0%
(0/57)0%
(0/2065)0%
(0/1228)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests0%
(0/4)0%
(0/4)0%
(0/149)0%
(0/172)src0%
(0/8)0%
(0/8)0%
(0/284)0%
(0/229)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/141)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/4)0%
(0/4)0%
(0/243)0%
(0/84)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas0%
(0/1)0%
(0/1)0%
(0/51)0%
(0/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/121)0%
(0/44)src.quick0%
(0/2)0%
(0/2)0%
(0/5)100%
(0/0)src.widgets0%
(0/2)0%
(0/2)0%
(0/43)0%

KDE CI: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 - Build # 8 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/8/
 Project:
Frameworks purpose kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Thu, 25 Jan 2018 04:04:02 +
 Build duration:
43 sec and counting
   CONSOLE OUTPUT
  [...truncated 57.34 KB...]PROCESSOR_REVISION= '3c01'PROGRAMDATA   = 'C:\ProgramData'PROGRAMFILES  = 'C:\Program Files'PROGRAMFILES(X86) = 'C:\Program Files (x86)'PROGRAMW6432  = 'C:\Program Files'PROMPT= '$P$G'PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'PUBLIC= 'C:\Users\Public'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/8/display/redirect?page=changes'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/8/display/redirect'STAGE_NAME= 'Configuring Build'SYSTEMDRIVE   = 'C:'SYSTEMROOT= 'C:\WINDOWS'TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'UCRTVERSION   = '10.0.16299.0'UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'USERDOMAIN= 'DESKTOP-0LVFIKI'USERNAME  = 'Jenkins'USERPROFILE   = 'C:\Users\Jenkins'VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\IDE\VC\'VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\'VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.12.25827\'VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Redist\MSVC\14.12.25810\'VCTOOLSVERSION= '14.12.25827'VISUALSTUDIOVERSION   = '15.0'VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'VS150COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\Tools\'VSCMD_ARG_APP_PLAT= 'Desktop'VSCMD_ARG_HOST_ARCH   = 'x64'VSCMD_ARG_TGT_ARCH= 'x64'VSCMD_VER = '15.5.3'VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\'WINDIR= 'C:\WINDOWS'WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.16299.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.16299.0'WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'WINDOWSSDKLIBVERSION  = '10.0.16299.0\'WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.16299.0\'WINDOWSSDKVERSION = '10.0.16299.0\'WORKSPACE = 'C:\CI\workspace\Frameworks purpose kf5-qt5 WindowsMSVCQt5.9'__DOTNET_ADD_64BIT= '1'__DOTNET_PREFERRED_BITNESS = '64'__VSCMD_PREINIT_PATH  = 'C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files (x86)\Git\cmd;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'CMAKE_PREFIX_PATH = 'C:\CI\workspace\Frameworks purpose kf5-qt5 WindowsMSVCQt5.9\install-prefix;C:\CM\msvc2017x64d;C:\CM\msvc2017x64d\dev-utils'XDG_DATA_DIRS = 'C:\CI\workspace\Frameworks purpose kf5-qt5 WindowsMSVCQt5.9\install-prefix\share;C:\CM\msvc2017x64d\share;C:\CM\msvc2017x64d\dev-utils\share'PKG_CONFIG_PATH   = 'C:\CM\msvc2017x64d\lib\pkgconfig;C:\CM\msvc2017x64d\dev-utils\lib\pkgconfig'QT_PLUGIN_PATH= 'C:\CM\msvc2017x64d\lib\qca-qt5'QMAKEFEATURES = 'C:\CM\msvc2017x64d\mkspecs/features'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="C:\CI\workspace\Frameworks purpose kf5-qt5 WindowsMSVCQt5.9/install-prefix/" -G "NMake Makefiles JOM"  "C:\CI\workspace\Frameworks purpose kf5-qt5 WindowsMSVCQt5.9"-- The C compiler identification is MSVC 19.12.25834.0-- The CXX compiler identification is MSVC 19.12.25834.0-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/Hostx64/x64/cl.exe -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Check for working CXX 

Re: errors building plasma-framework 5.42 (Linux)

[Ben Cooksley]

On Thu, Jan 25, 2018 at 11:08 AM, René J.V. Bertin  wrote:
> Hi,

Hi Rene,

>
> I'm  getting a build error that seems like it would never have made it into 
> an official release:
>
> [ 63%] Building CXX object 
> examples/dataengines/simpleEngine/CMakeFiles/plasma_dataengine_example_simpleEngine.dir/simpleEngine.cpp.o
> cd /path/to/build/examples/dataengines/simpleEngine && /usr/bin/c++  
> -DKCOREADDONS_LIB -DQT_CORE_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_GUI_LIB 
> -DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_CAST_TO_ASCII 
> -DQT_NO_DEBUG -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING 
> -DQT_USE_FAST_OPERATOR_PLUS -DQT_USE_QSTRINGBUILDER 
> -DTRANSLATION_DOMAIN=\"libplasma5\" -D_GNU_SOURCE -D_LARGEFILE64_SOURCE 
> -Dplasma_dataengine_example_simpleEngine_EXPORTS 
> -I/path/to/build/examples/dataengines/simpleEngine 
> -I/path/to/plasma-framework-5.42.0/examples/dataengines/simpleEngine 
> -I/path/to/build/examples/dataengines/simpleEngine/plasma_dataengine_example_simpleEngine_autogen/include
>  -I/path/to/build -I/path/to/plasma-framework-5.42.0/src/plasma/.. 
> -I/path/to/build/src/plasma -I/path/to/build/src/plasma/Plasma 
> -I/path/to/plasma-framework-5.42.0/src/plasma -isystem /opt/local/include/qt5 
> -isystem /opt/local/include/qt5/QtGui -isystem /opt/local/include/qt5/QtCore 
> -isystem /opt/local/share/qt5/mkspecs/linux-g++-64 -isystem 
> /opt/local/include/KF5/KService -isystem /opt/local/include/KF5 -isystem 
> /opt/local/include/KF5/KConfigCore -isystem 
> /opt/local/include/KF5/KCoreAddons -isystem /opt/local/include/KF5/KPackage 
> -isystem /opt/local/include/KF5/KI18n  -O3 -ftracer -g -DNDEBUG -m64 
> -std=c++0x -fno-operator-names -fno-exceptions -Wall -Wextra -Wcast-align 
> -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef 
> -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -Wvla -Wdate-time 
> -std=c++0x -fno-operator-names -fno-exceptions -Wall -Wextra -Wcast-align 
> -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef 
> -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -Wvla -Wdate-time 
> -pedantic -Wsuggest-override -fPIC -fvisibility=hidden 
> -fvisibility-inlines-hidden   -Wall -std=c++0x -fPIC -std=gnu++11 -o 
> CMakeFiles/plasma_dataengine_example_simpleEngine.dir/simpleEngine.cpp.o -c 
> /path/to/plasma-framework-5.42.0/examples/dataengines/simpleEngine/simpleEngine.cpp
> /path/to/plasma-framework-5.42.0/examples/dataengines/simpleEngine/simpleEngine.cpp:
>  In member function ‘void SimpleEngine::init()’:
> /path/to/plasma-framework-5.42.0/examples/dataengines/simpleEngine/simpleEngine.cpp:59:54:
>  error: ‘QString::QString(const char*)’ is private within this context
>  setData("Simple Source", i18n("Very simple data"));
>
> That's stock 5.42.0 and GCC 7.2 . AFAIK, -DQT_NO_CAST_FROM_ASCII has been the 
> default for building the frameworks for quite a while now.
>
> I'm working around it by adding -UQT_NO_CAST_FROM_ASCII to my compiler 
> options, but that shouldn't be necessary (and it never was, either, last 
> version I built before was 5.38.0).

Is it possible your build is picking up some Git builds?
There are some changes going through at the moment which have been
affecting QT_NO_CAST_FROM_ASCII definition which would explain this.

These have all been fixed in Git.

>
> Am I missing something or is this a regression?
>
> Thanks,
> R.

Cheers,
Ben

D10090: Downgrade not finding smb.conf from warning to debug

[Albert Astals Cid]

aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
aacid requested review of this revision.

REVISION SUMMARY
  After all we only use smb.conf in a depreated function (and unused according 
to lxr.kde.org)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10090

AFFECTED FILES
  src/core/ksambashare.cpp

To: aacid
Cc: #frameworks

errors building plasma-framework 5.42 (Linux)

[René J . V . Bertin]

Hi,

I'm  getting a build error that seems like it would never have made it into an 
official release:

[ 63%] Building CXX object 
examples/dataengines/simpleEngine/CMakeFiles/plasma_dataengine_example_simpleEngine.dir/simpleEngine.cpp.o

 
cd /path/to/build/examples/dataengines/simpleEngine && /usr/bin/c++  
-DKCOREADDONS_LIB -DQT_CORE_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_GUI_LIB 
-DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_CAST_TO_ASCII 
-DQT_NO_DEBUG -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING 
-DQT_USE_FAST_OPERATOR_PLUS -DQT_USE_QSTRINGBUILDER 
-DTRANSLATION_DOMAIN=\"libplasma5\" -D_GNU_SOURCE -D_LARGEFILE64_SOURCE 
-Dplasma_dataengine_example_simpleEngine_EXPORTS 
-I/path/to/build/examples/dataengines/simpleEngine 
-I/path/to/plasma-framework-5.42.0/examples/dataengines/simpleEngine 
-I/path/to/build/examples/dataengines/simpleEngine/plasma_dataengine_example_simpleEngine_autogen/include
 -I/path/to/build -I/path/to/plasma-framework-5.42.0/src/plasma/.. 
-I/path/to/build/src/plasma -I/path/to/build/src/plasma/Plasma 
-I/path/to/plasma-framework-5.42.0/src/plasma -isystem /opt/local/include/qt5 
-isystem /opt/local/include/qt5/QtGui -isystem /opt/local/include/qt5/QtCore 
-isystem /opt/local/share/qt5/mkspecs/linux-g++-64 -isystem 
/opt/local/include/KF5/KService -isystem /opt/local/include/KF5 -isystem 
/opt/local/include/KF5/KConfigCore -isystem /opt/local/include/KF5/KCoreAddons 
-isystem /opt/local/include/KF5/KPackage -isystem /opt/local/include/KF5/KI18n  
-O3 -ftracer -g -DNDEBUG -m64 -std=c++0x -fno-operator-names -fno-exceptions 
-Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long 
-Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual 
-Werror=return-type -Wvla -Wdate-time -std=c++0x -fno-operator-names 
-fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security 
-Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual 
-Werror=return-type -Wvla -Wdate-time -pedantic -Wsuggest-override -fPIC 
-fvisibility=hidden -fvisibility-inlines-hidden   -Wall -std=c++0x -fPIC 
-std=gnu++11 -o 
CMakeFiles/plasma_dataengine_example_simpleEngine.dir/simpleEngine.cpp.o -c 
/path/to/plasma-framework-5.42.0/examples/dataengines/simpleEngine/simpleEngine.cpp
/path/to/plasma-framework-5.42.0/examples/dataengines/simpleEngine/simpleEngine.cpp:
 In member function ‘void SimpleEngine::init()’:
/path/to/plasma-framework-5.42.0/examples/dataengines/simpleEngine/simpleEngine.cpp:59:54:
 error: ‘QString::QString(const char*)’ is private within this context
 setData("Simple Source", i18n("Very simple data"));

That's stock 5.42.0 and GCC 7.2 . AFAIK, -DQT_NO_CAST_FROM_ASCII has been the 
default for building the frameworks for quite a while now.

I'm working around it by adding -UQT_NO_CAST_FROM_ASCII to my compiler options, 
but that shouldn't be necessary (and it never was, either, last version I built 
before was 5.38.0).

Am I missing something or is this a regression?

Thanks,
R.

D10071: Change an assert to do as the function documentation tells

[Jaime Torres Amate]

jtamate updated this revision to Diff 25907.
jtamate edited the summary of this revision.
jtamate added a comment.


  Improved, in my opinion, one comment.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10071?vs=25890=25907

BRANCH
  firstChildUrl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10071

AFFECTED FILES
  autotests/urlutiltest.cpp
  src/filewidgets/urlutil_p.h

To: jtamate, #frameworks, dfaure
Cc: ngraham

D9966: [KIO] Fix issues with sharing of file descriptor

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> chinmoyr wrote in file_unix.cpp:91
> It is the only case for which this hack seems necessary. For all other cases 
> a library call (to perform a file operation) is immediately followed by a 
> call to helper.  IMO the chances of errno changing to something unrelated in 
> between these two calls are very slim (is it even possible?) 
> Although errno is important, saving it for every call will result in 
> unnecessary code. Can't we make an exception for this case?

I don't see how this could ever work. Even the line immediately below `errno = 
err` can change `errno`.
You must not assume that `errno` does not change if you call a function. Save 
it immediately after the function which errno you are interested in returns.
The famous "Could not perform operation: Success" - kind of error messages 
happens exactly because of bugs like these.

> chinmoyr wrote in sharefd_p.h:66
> I didn't follow you here. Can you explain why working of this code on other 
> OSs, specifically FreeBsd and OSX, will be insecure?

Look at `man 7 unix`, section `Pathname socket ownership and permissions`.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago, fvogt
Cc: ngraham, fvogt, lbeltrame, dfaure

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 35 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/35/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 24 Jan 2018 17:57:55 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.vimode_completion
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(301/337)89%
(301/337)69%
(33875/49372)52%
(17763/34214)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)94%
(4370/4669)49%
(2164/4386)autotests.src.vimode100%
(16/16)100%
(16/16)96%
(5310/5534)53%
(970/1846)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1778/3121)43%
(1242/2905)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(185/460)22%
(79/360)src.dialogs0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/242)src.document100%
(4/4)100%
(4/4)60%
(1914/3208)49%
(1731/3517)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)58%
(176/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/296)src.render100%
(9/9)100%
(9/9)73%
(888/1218)63%
(595/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(306/517)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
(6/8)75%
(6/8)30%
  

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 36 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/36/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
 Date of build:
Wed, 24 Jan 2018 17:59:11 +
 Build duration:
7 min 50 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.vimode_completion
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(301/337)89%
(301/337)69%
(33888/49378)52%
(17764/34216)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)94%
(4381/4672)49%
(2166/4386)autotests.src.vimode100%
(16/16)100%
(16/16)96%
(5310/5534)53%
(970/1846)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1779/3121)43%
(1243/2905)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(185/460)22%
(79/360)src.dialogs0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/242)src.document100%
(4/4)100%
(4/4)60%
(1914/3208)49%
(1731/3517)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)58%
(176/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/296)src.render100%
(9/9)100%
(9/9)73%
(888/1218)63%
(595/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(306/517)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
(6/8)75%
(6/8)30%
  

D10054: Fix: View jumps when Scroll past end of document is enabled

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:2bed94b6d463: Fix: View jumps when Scroll past end of 
document is enabled (authored by dhaumann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10054?vs=25837=25899

REVISION DETAIL
  https://phabricator.kde.org/D10054

AFFECTED FILES
  autotests/src/kateview_test.cpp
  autotests/src/kateview_test.h
  src/view/kateviewinternal.cpp

To: dhaumann, cullmann
Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, 
dhaumann

D10058: KateView unit test: simplify finding KateViewInternal

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:fbdfe779e46c: KateView unit test: simplify finding 
KateViewInternal (authored by dhaumann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10058?vs=25836=25898

REVISION DETAIL
  https://phabricator.kde.org/D10058

AFFECTED FILES
  autotests/src/kateview_test.cpp

To: dhaumann, cullmann
Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, 
dhaumann

D9966: [KIO] Fix issues with sharing of file descriptor

[Chinmoy Ranjan Pradhan]

chinmoyr marked 2 inline comments as done.
chinmoyr added inline comments.

INLINE COMMENTS

> fvogt wrote in fdreceiver.cpp:60
> A quick question: Is it possible that there are two FdReceivers with the same 
> pid?
> In that case they would end up removing each other's sockets.

No. Currently only one FdReceiver is created.

> fvogt wrote in file_unix.cpp:91
> That looks like a hack. If errno is that important, save and keep it in a 
> variable. Every call into a library can change errno, it's extremely volatile.

It is the only case for which this hack seems necessary. For all other cases a 
library call (to perform a file operation) is immediately followed by a call to 
helper.  IMO the chances of errno changing to something unrelated in between 
these two calls are very slim (is it even possible?) 
Although errno is important, saving it for every call will result in 
unnecessary code. Can't we make an exception for this case?

> fvogt wrote in sharefd_p.h:66
> The socket permissions only work that way for linux, so if other OSs can use 
> this code as well it's insecure and should `#error` out.

I didn't follow you here. Can you explain why working of this code on other 
OSs, specifically FreeBsd and OSX, will be insecure?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago, fvogt
Cc: ngraham, fvogt, lbeltrame, dfaure

D9966: [KIO] Fix issues with sharing of file descriptor

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 25897.
chinmoyr added a comment.


  1.Return nullptr when address() is called for an invalid socket path
  2.Create SocketAddress object before socket .

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9966?vs=25839=25897

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9966

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, #frameworks, thiago, fvogt
Cc: ngraham, fvogt, lbeltrame, dfaure

D10081: Don't assert if used incorrectly from dbus

[Martin Flöser]

graesslin created this revision.
graesslin added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
graesslin requested review of this revision.

REVISION SUMMARY
  The component dbus interface allowed to remote kill the wayland session
  by sending an incorrect request to the kglobalaccel dbus interface.
  
  There is no point in asserting, the code must be able to handle error
  cases and also is able to handle them.
  
  BUG: 389375
  FIXED-IN: 5.43

REPOSITORY
  R268 KGlobalAccel

BRANCH
  dont-assert-on-dbus-misusage

REVISION DETAIL
  https://phabricator.kde.org/D10081

AFFECTED FILES
  src/runtime/component.cpp

To: graesslin, #frameworks

D10071: Change an assert to do as the function documentation tells

[David Faure]

dfaure added a comment.


  Actually, maybe parentPath == "/" would be more readable then, otherwise the 
next reader will wonder, how it can end with a slash after StripTrailingSlash 
was used...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10071

To: jtamate, #frameworks, dfaure
Cc: ngraham

D10078: Add separate lib KF5::DBusRunner

[David Edmundson]

davidedmundson added a comment.


  
  
  > For the future perhaps there could be a XDG D-Bus interface for such 
quicksearch plugins, so a separate krunner-independent library would make sense 
for that as well.
  
  Gnome does have an equivalent: org.gnome.Shell.SearchProvider2
  
  It's similar to how I would have done it if I wasn't trying to fit into the 
existing krunner achitecture. 
  But it's not feasible do retrofit into here.
  
  Making a client API speak both... /might/ be feasible.
  
  -
  
  I want to us to make sure this is still usable without a library dependency, 
but I think having this makes sense for the KDE apps. Definitely +1 to the idea.
  
  I like how you've made it so you can reply in a sync or async way without 
making the sync version too complex. 
  I have a proposal that re-arranges a little bit to take it just a bit further.
  
  void match( QSharedPointer context)
  that context object stores the m_mLastMatchDBusMessage and has the addMatches 
methods and it calls finish in its destructor
  
  If a user wants to reply normally, they just do context.setMatches() in this 
method, with nothing else.
  
  The baloo/p-b-i code can cache the latest MatchContext as a member variable 
exactly like they currently cache the lastMessage, and everything else gets 
automatically taken care of. 
  (with this API it looks quite easy to send the wrong data as a reply if a 
user doesn't handle the cancel signal correctly)
  
  If a user wants to reply to all messages, they can too.

INLINE COMMENTS

> abstractrunner.h:161
> +void matchingCancelled();
> +
> +private:

please add a virtual hook for future expansion

> dbusadaptor_p.h:31
> + */
> +class DBusRunnerAdaptor: public QDBusAbstractAdaptor
> +{

Can you put a 1 in the class name for future proofing.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D10078

To: kossebau, davidedmundson, broulik
Cc: ngraham, #frameworks

D10071: Change an assert to do as the function documentation tells

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Ah, OK (yes, this is why you should use `arc diff` to upload patches...) :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10071

To: jtamate, #frameworks, dfaure
Cc: ngraham

D10040: Add serial number and EISA ID to OutputDevice interface

[Martin Flöser]

graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> outputdevice.xml:104-107
> + + summary="textual representation of serial number"/>
> + + summary="textual representation of EISA identifier"/>

I'm not sure whether it's allowed to add arguments to an existing event. This 
would result in incompatibilities. You can make the server only emit to clients 
having the version, but then you actually broke any client which only has 
version 1.

To be really compatible you need to add a new event.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10040

To: dvratil, graesslin, sebas
Cc: davidedmundson, plasma-devel, #frameworks, schernikov, ZrenBot, ngraham, 
alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, 
sebas, apol, mart, hein

D10078: Add separate lib KF5::DBusRunner

[Friedrich W . H . Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> broulik wrote in dbusadaptor_p.h:1
> Isn't this file compile-time generated from xml?

It can be, yes. I had switched for reason* to  manually written one, but with 
the public class API no longer affected by reason* I could/should perhaps 
switch back.
Nothing really won or lost though by having a non-generated class.

*qdbusxml2cpp picks up the casing of the method names in the D-Bus interface 
and expects them also to be used in the wrapped class. D-Bus method naming 
standard seems to be "UpperCase", which also used in the krunner1 interface 
("Actions", "Run", "Query").
While in our Qt-style code we prefer method names to be with lowerCaseStart.
And given the purpose of the lib is "being nice to use", I switched to a 
manually adapted version of the adaptor code. Compare e.g. changed to API of 
TestRemoteRunner.
Later though, when I went to use QDBusContext for enabling the async match 
collection, I avoided leaking that detail in the public API and moved all D-Bus 
stuff to the pimpl object. Where having "UpperCaseStart" methods is not harming 
public consumers.
Whatever people prefer, no own preference.

> broulik wrote in querymatch.h:35
> Should be pimpl this? once we commit to this we can never add new fields but 
> then the DBus signature is also now or never.. I think we should add subtext 
> and url to the main struct since I always use the two. Originally David and I 
> thought we could put them in properties as they're seldom used but turns out 
> they're not.

Indeed, DBus signature being fixed is also why I wrote the simple struct for 
now instead of setter/getter pimpl API.
Having learned how to use c++11 initlalizer lists recently I also now fancy 
their use where possible ;) and in the little sample cpde I played for now 
using initializer lists worked nicely, no need for explicit setters. No getters 
used even. After all the runners are just producing that content usually and do 
no own further processing, but just deliver it.

Putting subtext and url to the main struct if you like. No idea yet how to 
adapt the marshalling, given those two need to be in the a{sv}, but possibly 
can be done with some temporary variantmap. No big runtime costs, and will be 
nicer API.

No strong opinion here as well. You decide and I will write :)

> broulik wrote in querymatch.h:53
> Can we static assert this in the dbus runner somehow? But I guess since it's 
> a separate lib you cannot

No idea yet how to automatically ensure this :/ Why are there  no guides with 
tips & tricks for D-Bus interface types?!

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D10078

To: kossebau, davidedmundson, broulik
Cc: ngraham, #frameworks

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 28 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/28/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
 Date of build:
Wed, 24 Jan 2018 15:59:40 +
 Build duration:
4 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

D10024: Add supportedSchemes feature

[Milian Wolff]

mwolff added a comment.


  In https://phabricator.kde.org/D10024#194708, @mart wrote:
  
  > ship it with the extra check Aleix noted
  
  
  Can you guys explain me more what would be required for KIOSK support?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10024

To: mwolff, #plasma, dfaure, mart
Cc: mart, apol, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas

D10024: Add supportedSchemes feature

[Milian Wolff]

mwolff updated this revision to Diff 25891.
mwolff added a comment.


  extend apidox, mention empty list == everything allowed

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10024?vs=25764=25891

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10024

AFFECTED FILES
  autotests/kdiroperatortest.cpp
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h

To: mwolff, #plasma, dfaure, mart
Cc: mart, apol, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 27 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/27/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 24 Jan 2018 15:59:40 +
 Build duration:
2 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.9 - Build # 6 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/6/
 Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 24 Jan 2018 15:13:14 +
 Build duration:
31 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.alternativesmodeltest

D10078: Add separate lib KF5::DBusRunner

[Friedrich W . H . Kossebau]

kossebau added a comment.


  A first draft of some util code for writing D-Bus KRunner plugins, partially 
tested to work. See https://phabricator.kde.org/D10079 for the Baloo krunner 
plugin being adapted to it.
  
  Tries to simulate the KRunner::AbstractRunner API a little, to where the 
krunner1 D-Bus interface makes that easy to do.
  
  Forking KRunner::QueryMatch::Type to KDBusRunner::QueryMatch::Type is not 
perfect, but allows to just have QtCore in public link interface and QtDBus in 
the private, so does not pull in all the deps of KF5::Runner just for this enum 
definition.
  
  While I put this into a subdir for now, all the code of KDBusRunner is 
independent, perhaps it makes sense to move it into a separate tier1 framework 
module?
  For the future perhaps there could be a XDG D-Bus interface for such 
quicksearch plugins, so a separate krunner-independent library would make sense 
for that as well.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D10078

To: kossebau, davidedmundson, broulik
Cc: #frameworks

D10071: Change an assert to do as the function documentation tells

[Jaime Torres Amate]

jtamate added inline comments.

INLINE COMMENTS

> dfaure wrote in urlutil_p.h:69
> s/S/s/ twice
> 
> You could also just use adjustedCurrentUrl.path(QUrl::StripTrailingSlash), no?
> Then you wouldn't have to deal with the fact that the path might end with a 
> slash
> (and it would also cover the case where it ends with two or more consecutive 
> slashes)

It is already done (it's a pity that this can't be seen creating the patch 
using the web):

  const QUrl adjustedLastUrl = lastUrl.adjusted(QUrl::StripTrailingSlash);
  const QUrl adjustedCurrentUrl = currentUrl.adjusted(QUrl::StripTrailingSlash);
   

but in the case of the new test, the values are:
"/d" and "/" from the originals: "file:///d" and "file:///"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10071

To: jtamate, #frameworks, dfaure
Cc: ngraham

D10071: Change an assert to do as the function documentation tells

[Jaime Torres Amate]

jtamate updated this revision to Diff 25890.
jtamate marked an inline comment as done.
jtamate added a comment.


  replaced two uppercase S

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10071?vs=25883=25890

REVISION DETAIL
  https://phabricator.kde.org/D10071

AFFECTED FILES
  autotests/urlutiltest.cpp
  src/filewidgets/urlutil_p.h

To: jtamate, #frameworks, dfaure
Cc: ngraham

D10078: Add separate lib KF5::DBusRunner

[Kai Uwe Broulik]

broulik added a comment.


  Cool! Dunno if this has to be a separate library? But then it would allow for 
super thin dependencies as it's just Qt DBus, I don't really mind either.

INLINE COMMENTS

> dbusadaptor_p.h:1
> +/*
> + *   Copyright 2018 Friedrich W. H. Kossebau 

Isn't this file compile-time generated from xml?

> querymatch.h:35
> + */
> +struct KDBUSRUNNER_EXPORT QueryMatch
> +{

Should be pimpl this? once we commit to this we can never add new fields but 
then the DBus signature is also now or never.. I think we should add subtext 
and url to the main struct since I always use the two. Originally David and I 
thought we could put them in properties as they're seldom used but turns out 
they're not.

> querymatch.h:53
>   * The type of match. Value is important here as it is used for 
> sorting
> + * @internal Needs to match KDBusRunner::QueryMatch::Type.
>   */

Can we static assert this in the dbus runner somehow? But I guess since it's a 
separate lib you cannot

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D10078

To: kossebau, davidedmundson, broulik
Cc: #frameworks

D10078: Add separate lib KF5::DBusRunner

[Friedrich W . H . Kossebau]

kossebau added a dependent revision: D10079: Port baloo krunner plugin to 
KDBusRunner.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D10078

To: kossebau, davidedmundson, broulik
Cc: #frameworks

D10078: Add separate lib KF5::DBusRunner

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: davidedmundson, broulik.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  Enables writing remote-via-D-Bus krunner plugins without
  having to care for any boilerplate of D-Bus calls.

REPOSITORY
  R308 KRunner

BRANCH
  kdbusrunnerlib

REVISION DETAIL
  https://phabricator.kde.org/D10078

AFFECTED FILES
  KF5DBusRunnerConfig.cmake.in
  autotests/CMakeLists.txt
  autotests/testremoterunner.cpp
  autotests/testremoterunner.h
  src/CMakeLists.txt
  src/dbusrunner/CMakeLists.txt
  src/dbusrunner/abstractrunner.cpp
  src/dbusrunner/abstractrunner.h
  src/dbusrunner/abstractrunner_p.cpp
  src/dbusrunner/abstractrunner_p.h
  src/dbusrunner/action.h
  src/dbusrunner/dbusadaptor.cpp
  src/dbusrunner/dbusadaptor_p.h
  src/dbusrunner/querymatch.h
  src/querymatch.h

To: kossebau, davidedmundson, broulik
Cc: #frameworks

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/7/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.7
 Date of build:
Wed, 24 Jan 2018 15:13:15 +
 Build duration:
4 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltestFailed: TestSuite.menutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/20)0%
(0/57)0%
(0/57)0%
(0/2065)0%
(0/1228)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests0%
(0/4)0%
(0/4)0%
(0/149)0%
(0/172)src0%
(0/8)0%
(0/8)0%
(0/284)0%
(0/229)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/141)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/4)0%
(0/4)0%
(0/243)0%
(0/84)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas0%
(0/1)0%
(0/1)0%
(0/51)0%
(0/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/121)0%
(0/44)src.quick0%
(0/2)0%
(0/2)0%
(0/5)100%
(0/0)src.widgets0%
(0/2)0%
(0/2)0%
(0/43)0%

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/6/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 24 Jan 2018 15:13:14 +
 Build duration:
2 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltestFailed: TestSuite.menutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/20)0%
(0/57)0%
(0/57)0%
(0/2065)0%
(0/1228)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests0%
(0/4)0%
(0/4)0%
(0/149)0%
(0/172)src0%
(0/8)0%
(0/8)0%
(0/284)0%
(0/229)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/141)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/4)0%
(0/4)0%
(0/243)0%
(0/84)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas0%
(0/1)0%
(0/1)0%
(0/51)0%
(0/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/121)0%
(0/44)src.quick0%
(0/2)0%
(0/2)0%
(0/5)100%
(0/0)src.widgets0%
(0/2)0%
(0/2)0%
(0/43)0%

D10077: [Default Tooltip] Fix sizing

[Kai Uwe Broulik]

broulik edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10077

To: broulik, #plasma, #vdg
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10077: [Default Tooltip] Fix sizing

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Unset the Label's default height which completely confuses the renderer 
either shifting the item vertically (e.g. when toggling system tray popup), or 
letting it get too wide (e.g. when moving from a two-line tooltip to a one-line 
tooltip).
  
  BUG: 386260
  BUG: 389371

TEST PLAN
  - Opened and closed System Tray popup, tooltip was correctly aligned now (bug 
389371)
  
  F5672178: Screenshot_20180124_155427.png 

  
  - Moved from NM to Battery plasmoid, tooltip was correctly sized now (bug 
386260)
  
  - Moved from task manager tooltip to kickoff and vice-versa, was still correct
  - Observed all tooltips having a sane size.
  
  When subtext linebreaks the tooltip can appear too wide because the word 
wrapped onto the next line but this isn't easily fisable, not without using a 
separate `TextMetrics` instance and other sledgehammer methods

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10077

AFFECTED FILES
  src/declarativeimports/core/private/DefaultToolTip.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10071: Change an assert to do as the function documentation tells

[David Faure]

dfaure added a comment.


  Heh, see the point of writing unittests that actually test the bug ;) It lead 
to a different fix so it was clearly useful ;)

INLINE COMMENTS

> urlutil_p.h:69
>  const QString parentPath = adjustedCurrentUrl.path();
> +// if the parent path ends in / (after Stripping the trailing Slash)
> +// one letter more is a valid path, otherwise two letters are needed.

s/S/s/ twice

You could also just use adjustedCurrentUrl.path(QUrl::StripTrailingSlash), no?
Then you wouldn't have to deal with the fact that the path might end with a 
slash
(and it would also cover the case where it ends with two or more consecutive 
slashes)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10071

To: jtamate, #frameworks, dfaure
Cc: ngraham

D10075: Make pacakge usefull for cross compilation

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> CMakeLists.txt:45
>  
> -set(KAUTH_HELPER_INSTALL_DIR "${KDE_INSTALL_LIBEXECDIR}/kauth")
> +option(KAUTH_HELPER_INSTALL_DIR "Set directory for kauth helper tool" 
> "${KDE_INSTALL_LIBEXECDIR}/kauth")
>  

the 3rd parameter is a bool. This change won't do what you expect.

(https://cmake.org/cmake/help/v3.0/command/option.html)

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D10075

To: knauss, #frameworks, skelly
Cc: cgiboudeaux, #frameworks

D10071: Change an assert to do as the function documentation tells

[Jaime Torres Amate]

jtamate updated this revision to Diff 25883.
jtamate added a comment.


  Do the right thing in the case of urls that end in / after the slash 
stripping.
  
  This new test fails without the patch.
  QCOMPARE(KIO::UrlUtil::firstChildUrl(lUrl("/d"), lUrl("/")), lUrl("/d"));

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10071?vs=25872=25883

REVISION DETAIL
  https://phabricator.kde.org/D10071

AFFECTED FILES
  autotests/urlutiltest.cpp
  src/filewidgets/urlutil_p.h

To: jtamate, #frameworks, dfaure

D10075: Make pacakge usefull for cross compilation

[Sandro Knauß]

knauss added a comment.


  @skelly: IMO it makes sense to discuss also the needed change in ECM, to 
solve the issue popperly.
  
  Just a side note - me personally is not very deep into the cross compilation 
topic. That's why I can understand, if you have many questions and do not get 
it, why this is needed :D
  
  Please feel free to ask any questions, I will try to anwser them, of forward 
them, if needed.
  Also feel welcome to join #debian-qt-kde on irc.debian.org to discuss this 
more direct.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D10075

To: knauss, #frameworks, skelly
Cc: #frameworks

D10075: Make pacakge usefull for cross compilation

[Sandro Knauß]

knauss added reviewers: Frameworks, skelly.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D10075

To: knauss, #frameworks, skelly
Cc: #frameworks

D10075: Make pacakge usefull for cross compilation

[Sandro Knauß]

knauss created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
knauss requested review of this revision.

REVISION SUMMARY
  kauth-gen-policy appears to be a tool for turning a text file in
  qsettings format (similar to .ini) into an xml file. Both are textual,
  so it seems like putting kauth-gen-policy into a Multi-Arch: foreign
  package (like kconfig_compiler_kf5 in #887452).
  
  In a cross compilation environment, kauth-gen-policy is called from the
  host system and not from the target system, so a arch depdend path
  (/usr/lib/) do not make sense in that case and a arch indepdend
  should be used. As we do not want to break other usecases we used the
  non indrudive way possible, to change this to an option, so we can
  modify the path with a camke option.
  
  The bigger picture is to fix libexec path in extra-cmake-modules to a
  arch-independed path, as recommended in the FHS 3.0.
  
  887452 https://bugs.debian.org/887452
  
  Bug-Debian: https://bugs.debian.org/887521

REPOSITORY
  R283 KAuth

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10075

AFFECTED FILES
  CMakeLists.txt

To: knauss
Cc: #frameworks

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 55 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/55/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
 Date of build:
Wed, 24 Jan 2018 12:32:59 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3543/13222)19%
(1969/10463)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)12%
(250/2152)7%
(97/1450)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1445/3488)28%
(828/2917)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(537/1970)18%
(300/1707)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
   

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 52 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/52/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 24 Jan 2018 12:32:59 +
 Build duration:
9 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3544/13226)19%
(1970/10463)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)12%
(251/2156)7%
(98/1454)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1445/3488)28%
(828/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(537/1970)18%
(300/1707)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

D9332: Allow filter places based on alternative application name

[Renato Oliveira Filho]

renatoo updated this revision to Diff 25880.
renatoo added a comment.


  Updated @since tag

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9332?vs=24605=25880

REVISION DETAIL
  https://phabricator.kde.org/D9332

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: renatoo, mwolff, mlaurent
Cc: elvisangelaccio, mlaurent, aacid, ngraham, #frameworks

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 28 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/28/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 24 Jan 2018 12:32:59 +
 Build duration:
7 min 47 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D10074: parametrize qqc2 version

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f9061787136e: parametrize qqc2 version (authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10074?vs=25878=25879

REVISION DETAIL
  https://phabricator.kde.org/D10074

AFFECTED FILES
  CMakeLists.txt
  src/declarativeimports/CMakeLists.txt
  src/declarativeimports/plasmacomponents3/BusyIndicator.qml
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/CheckBox.qml
  src/declarativeimports/plasmacomponents3/CheckDelegate.qml
  src/declarativeimports/plasmacomponents3/ComboBox.qml
  src/declarativeimports/plasmacomponents3/Container.qml
  src/declarativeimports/plasmacomponents3/Control.qml
  src/declarativeimports/plasmacomponents3/Dial.qml
  src/declarativeimports/plasmacomponents3/Dialog.qml
  src/declarativeimports/plasmacomponents3/DialogButtonBox.qml
  src/declarativeimports/plasmacomponents3/Drawer.qml
  src/declarativeimports/plasmacomponents3/Frame.qml
  src/declarativeimports/plasmacomponents3/GroupBox.qml
  src/declarativeimports/plasmacomponents3/ItemDelegate.qml
  src/declarativeimports/plasmacomponents3/Label.qml
  src/declarativeimports/plasmacomponents3/Menu.qml
  src/declarativeimports/plasmacomponents3/MenuItem.qml
  src/declarativeimports/plasmacomponents3/Popup.qml
  src/declarativeimports/plasmacomponents3/ProgressBar.qml
  src/declarativeimports/plasmacomponents3/RadioButton.qml
  src/declarativeimports/plasmacomponents3/RadioDelegate.qml
  src/declarativeimports/plasmacomponents3/RangeSlider.qml
  src/declarativeimports/plasmacomponents3/ScrollBar.qml
  src/declarativeimports/plasmacomponents3/Slider.qml
  src/declarativeimports/plasmacomponents3/SpinBox.qml
  src/declarativeimports/plasmacomponents3/Switch.qml
  src/declarativeimports/plasmacomponents3/SwitchDelegate.qml
  src/declarativeimports/plasmacomponents3/TabBar.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/TextArea.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmacomponents3/ToolBar.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  src/declarativeimports/plasmacomponents3/ToolTip.qml
  src/declarativeimports/plasmacomponents3/private/DefaultListItemBackground.qml

To: mart, #plasma, bshah
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10074: parametrize qqc2 version

[Bhushan Shah]

bshah accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/qqcversion

REVISION DETAIL
  https://phabricator.kde.org/D10074

To: mart, #plasma, bshah
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10074: parametrize qqc2 version

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  for styles in order to work at all they need to import
  the latest available qqc2 version installed in the system
  or any app using new qqc2 feature will fail to load.
  do like in qqc2-desktop-style and set the import version
  at build time

TEST PLAN
  all generated files have 2.3 here as version and apps using qqc2 still oload

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/qqcversion

REVISION DETAIL
  https://phabricator.kde.org/D10074

AFFECTED FILES
  CMakeLists.txt
  src/declarativeimports/CMakeLists.txt
  src/declarativeimports/plasmacomponents3/BusyIndicator.qml
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/CheckBox.qml
  src/declarativeimports/plasmacomponents3/CheckDelegate.qml
  src/declarativeimports/plasmacomponents3/ComboBox.qml
  src/declarativeimports/plasmacomponents3/Container.qml
  src/declarativeimports/plasmacomponents3/Control.qml
  src/declarativeimports/plasmacomponents3/Dial.qml
  src/declarativeimports/plasmacomponents3/Dialog.qml
  src/declarativeimports/plasmacomponents3/DialogButtonBox.qml
  src/declarativeimports/plasmacomponents3/Drawer.qml
  src/declarativeimports/plasmacomponents3/Frame.qml
  src/declarativeimports/plasmacomponents3/GroupBox.qml
  src/declarativeimports/plasmacomponents3/ItemDelegate.qml
  src/declarativeimports/plasmacomponents3/Label.qml
  src/declarativeimports/plasmacomponents3/Menu.qml
  src/declarativeimports/plasmacomponents3/MenuItem.qml
  src/declarativeimports/plasmacomponents3/Popup.qml
  src/declarativeimports/plasmacomponents3/ProgressBar.qml
  src/declarativeimports/plasmacomponents3/RadioButton.qml
  src/declarativeimports/plasmacomponents3/RadioDelegate.qml
  src/declarativeimports/plasmacomponents3/RangeSlider.qml
  src/declarativeimports/plasmacomponents3/ScrollBar.qml
  src/declarativeimports/plasmacomponents3/Slider.qml
  src/declarativeimports/plasmacomponents3/SpinBox.qml
  src/declarativeimports/plasmacomponents3/Switch.qml
  src/declarativeimports/plasmacomponents3/SwitchDelegate.qml
  src/declarativeimports/plasmacomponents3/TabBar.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/TextArea.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmacomponents3/ToolBar.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  src/declarativeimports/plasmacomponents3/ToolTip.qml
  src/declarativeimports/plasmacomponents3/private/DefaultListItemBackground.qml

To: mart, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10071: Change an assert to do as the function documentation tells

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Strange that the "bug report" mentions /d but the unittests doesn't have 
anything like that.
  
  In fact, is it just me, or does the "extended" unittest pass without the fix? 
My testing seems to indicate that.
  
  A good unittest for a bugfix has to *fail* without the fix applied ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10071

To: jtamate, #frameworks, dfaure

Re: A new tier1 for icontheme.rcc handling

[Hannah von Reth]

Hi Matthieu,
On 21/01/2018 21:19, Matthieu Gallien wrote:
> Hello,
>
> On jeudi 18 janvier 2018 08:45:51 CET Hannah von Reth wrote:
>> Hi everyone.
>>
>> Only some few of you will be aware of KIconThemes ability to load binary
>> icon themes automagically.
>>
>> https://cgit.kde.org/kiconthemes.git/tree/src/kicontheme.cpp#n48
>>
>> The code looks for a icontheme.rcc and sets it as default theme.
>>
>> On Windows and Mac we rely on that code as it is more feasible to
>> install that one
>> file with an single application installer. This code also ensures that
>> the theme path is set,
>> which on Linux is done by the qpa.
>>
>> The problem with the current solution is that it only allows one single
>> theme and is in a tier3
>> framework.
>>
>> I recently talked to David Faure and we agreed that it would be best to
>> put those few line of code into a new
>> created tier1 framework, with an explicit call instead of the magical
>> loading.
>>
>> The explicit call would allow to specify the theme loaded and we  can
>> still maintain the current behaviour by putting a call to
>> that new framework into KIconThemes.
>>
>> Now we need a name for that tier1 framework and ideally someone who
>> steps up for the once in a lifetime chance to become
>> maintainer of a glorious new tier1 framework.
> Thanks for the work on this.
>
> If nobody steps up, I can volunteer to maintain it if people are OK with 
> this. 
> The workload should be low ?
>
> I depend on this code for a good windows support. This is important for me.
You would be more than welcome :)
>> Cheers,
>>
>> Hannah
> Best regards
>
> --
> Matthieu Gallien

Cheers,

Hannah



signature.asc
Description: OpenPGP digital signature

D10071: Change an assert to do as the function documentation tells

[Jaime Torres Amate]

jtamate updated this revision to Diff 25872.
jtamate edited the test plan for this revision.
jtamate added a comment.


  Added more unit tests with some comments.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10071?vs=25869=25872

REVISION DETAIL
  https://phabricator.kde.org/D10071

AFFECTED FILES
  autotests/urlutiltest.cpp
  src/filewidgets/urlutil_p.h

To: jtamate, #frameworks, dfaure

D10072: Add APKBUILD to be highlighted as a Bash file

[Bart Ribbers]

PureTryOut created this revision.
PureTryOut created this object with edit policy "Only User: PureTryOut (Bart 
Ribbers)".
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
PureTryOut requested review of this revision.

REVISION SUMMARY
  APKBUILDs are build scripts used by Alpine Linux and it's derivatives, much 
like PKGBUILDs from Arch Linux. They use the Bash syntax so it only makes sense 
to highlight them by default.

TEST PLAN
  Just open any APKBUILD (for example this one 
) 
and check if the highlighting is done properly.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10072

AFFECTED FILES
  data/syntax/bash.xml

To: PureTryOut
Cc: #frameworks

D10071: Change an assert to do as the function documentation tells

[David Faure]

dfaure added a comment.


  IIRC this method is unittested, right? Please extend the unittest.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10071

To: jtamate, #frameworks, dfaure

D10071: Change an assert to do as the function documentation tells

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  Instead of an assert do as the documentation tells: return an invalid Url.
  
  - In case both URLs are equal, an invalid URL is returned

TEST PLAN
  How to assert:
  In dolphin, in the location bar, change it into text and enter into one level 
directory from root, for example /d
  When it changes into the breadcrum, press into the root one and crash (in 
Debug build).ç
  
  I've been using this patch one month. And it doesn't affect the unit tests.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10071

AFFECTED FILES
  src/filewidgets/urlutil_p.h

To: jtamate, #frameworks, dfaure

D10046: unset maintainer

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:978676ee9a20: unset maintainer (authored by sitter).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10046?vs=25809=25870

REVISION DETAIL
  https://phabricator.kde.org/D10046

AFFECTED FILES
  metainfo.yaml

To: sitter, apol, aacid
Cc: #frameworks

D9983: Don't stat(/etc/localtime) between read() and write() copying files

[Jaime Torres Amate]

jtamate marked 3 inline comments as done.
jtamate added inline comments.

INLINE COMMENTS

> dfaure wrote in slavebase.cpp:1054
> Where does this "1" value come from, and it is useful at all?

It was 1 as could have been 0.
It is not needed anymore.

> dfaure wrote in slavebase.cpp:1055
> So when we go to that "else" branch, we'll have called start() and 
> immediately after, invalidate(). To avoid doing this, how about calling 
> start() in the first two if()s?
> (small optimization)

I was trying to save some code, but you're right. Here speed matters more than 
size.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9983

To: jtamate, #frameworks, dfaure
Cc: fvogt, ngraham

D9983: Don't stat(/etc/localtime) between read() and write() copying files

[Jaime Torres Amate]

jtamate updated this revision to Diff 25867.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9983?vs=25783=25867

REVISION DETAIL
  https://phabricator.kde.org/D9983

AFFECTED FILES
  src/core/slavebase.cpp

To: jtamate, #frameworks, dfaure
Cc: fvogt, ngraham

D10045: Don't assert on empty names

[Milian Wolff]

mwolff added a comment.


  In https://phabricator.kde.org/D10045#195097, @dfaure wrote:
  
  > Good point, done.
  
  
  I did the following:
  
  - in Dolphin, go to remote:/
  - add network folder
  - allow execution of this script (separate usability issue)
  - webdav, then fill out the form for our KDAB owncloud instance, i.e. with 
host = swanson and folder == /owncloud/remote.php/webdav
  - then save and connect, you'll see a strange warning dialog with this info:
  
"You are about to log in to the site "swanson.kdab.com" with the username 
"milian", but the website does not require authentication. This may be an 
attempt to trick you. Is "swanson.kdab.com" the site you want to visit?"
  
imo this is again a usability issue, but unrelated I guess? Anyhow, accept 
it and dolphin crashes with the assertion

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10045

To: mwolff, dfaure
Cc: dhaumann, #frameworks

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.7 - Build # 20 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.7/20/
 Project:
Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.7
 Date of build:
Wed, 24 Jan 2018 10:36:28 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: TestSuite.kdatecomboboxtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)45%
(85/187)45%
(85/187)30%
(4442/15029)22%
(1870/8324)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(33/33)100%
(33/33)98%
(1592/1627)51%
(942/1836)src44%
(52/117)44%
(52/117)23%
(2850/12275)15%
(928/6311)tests0%
(0/37)0%
(0/37)0%
(0/1127)0%
(0/177)

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 - Build # 13 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/13/
 Project:
Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 24 Jan 2018 10:36:28 +
 Build duration:
6 min 20 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: TestSuite.kdatecomboboxtest

D8908: KDateComboBox: fix dateChanged() not emitted after typing a date

[David Faure]

dfaure closed this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8908

To: dfaure, cfeck, dvratil, mlaurent
Cc: mlaurent, anthonyfieroni, #frameworks, #kde_pim

KDE CI: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 - Build # 6 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/6/
 Project:
Frameworks purpose kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Wed, 24 Jan 2018 09:59:44 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.alternativesmodeltestFailed: TestSuite.menutest

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 6 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/6/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.7
 Date of build:
Wed, 24 Jan 2018 09:06:38 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltestFailed: TestSuite.menutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/20)0%
(0/57)0%
(0/57)0%
(0/2062)0%
(0/1228)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests0%
(0/4)0%
(0/4)0%
(0/149)0%
(0/172)src0%
(0/8)0%
(0/8)0%
(0/281)0%
(0/229)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/141)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/4)0%
(0/4)0%
(0/243)0%
(0/84)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas0%
(0/1)0%
(0/1)0%
(0/51)0%
(0/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/121)0%
(0/44)src.quick0%
(0/2)0%
(0/2)0%
(0/5)100%
(0/0)src.widgets0%
(0/2)0%
(0/2)0%
(0/43)0%
(0/10)tests0%

D9983: Don't stat(/etc/localtime) between read() and write() copying files

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> slavebase.cpp:1052
>  } else if (timeout == 0) {
> -d->nextTimeout = QDateTime::currentDateTime().addSecs(1);// 
> Immediate timeout
> +d->nextTimeoutMsecs = 1000;  // Inmediate timeout
>  } else {

Typo: In -> Im (i.e. it was correct in the orig code)

> slavebase.cpp:1054
>  } else {
> -d->nextTimeout = QDateTime();// Canceled
> +d->nextTimeoutMsecs = 1;
> +d->nextTimeout.invalidate(); // Canceled

Where does this "1" value come from, and it is useful at all?

> slavebase.cpp:1055
> +d->nextTimeoutMsecs = 1;
> +d->nextTimeout.invalidate(); // Canceled
>  }

So when we go to that "else" branch, we'll have called start() and immediately 
after, invalidate(). To avoid doing this, how about calling start() in the 
first two if()s?
(small optimization)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9983

To: jtamate, #frameworks, dfaure
Cc: fvogt, ngraham

D10024: Add supportedSchemes feature

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> kfilewidget.h:498
> +/**
> + * Set the URL schemes that the file widget should allow navigating to.
> + *

All of these public methods should indicate that the default list is *empty* 
and that empty means "all schemes are supported".
I don't want to see people thinking they have to call this for anything to 
work, since that would only lead to unnecessarily limiting the amount of 
supported schemes in all cases where there's no reason to limit that.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10024

To: mwolff, #plasma, dfaure, mart
Cc: mart, apol, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas