D10405: Don't proceed in runCommandInternal if the executable doesn't exit

[Eike Hein]

hein added a comment.


  Yeah, I had a feeling there were other design considerations here, but 
they're not documented/commented in the code so the only way to find out was to 
show you a patch :)
  
  You want this virtual method where? In KRun? And then Plasma should subclass 
KRun?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10405

To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 111 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/111/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 12 Feb 2018 04:15:49 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 129 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/129/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 12 Feb 2018 04:15:49 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31500/59490)38%
(18499/48824)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8548/9096)48%
(5210/10759)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8345/14343)50%
(4878/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3872/7838)33%
(1634/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 131 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/131/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 12 Feb 2018 04:15:49 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31502/59491)38%
(18491/48748)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8546/9096)48%
(5212/10759)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8343/14343)50%
(4871/9704)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3873/7838)33%
(1635/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)5

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 48 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/48/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 12 Feb 2018 02:14:45 +
 Build duration:
7 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 43 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/43/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 12 Feb 2018 02:14:45 +
 Build duration:
6 min 15 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 32 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/32/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 12 Feb 2018 02:14:45 +
 Build duration:
4 min 47 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittest

D10365: New icon for Elisa music player

[Paul Lesur]

paullesur added a comment.


  In D10365#203797 , @januz wrote:
  
  > Agree with the text not being useful for small sizes, but it could look 
good for a large logo-style image (like say, a 256px logo on the 
wiki/homepage). 
  >  A cassette is definitely an interesting idea for an icon. At least it's 
not another musical note or play icon 

 :)
  >
  > It's true that it's old school, but we also use CDs for albums which is 
also kind of old school now, so it's not totally off. Green is ok too, since 
the CDs and their background are all green (and blueish). You could also mixing 
it with some subtle blue/cyan tints in there.
  >
  > Also, I think if we're going 80s we should go all the way. Instead of a 
gradient (green to white), consider using some 80s motif like the vanishing 
lines in here:
  >  
https://www.google.com.ar/search?dcr=0&tbs=imgo%3A1&tbm=isch&sa=1&ei=zzp-WvW5MsPCwATB-LGwAQ&q=awesome+mix+vol+2&oq=awesome+mix&gs_l=psy-ab.3.1.0l10.345494.346631.0.348056.11.9.0.2.2.0.144.983.4j5.9.00...1c.1.64.psy-ab..1.10.890...0i67k1.0.QW76y1ueao8#imgrc=66ooLxhTsA9q2M
  >
  > You should probably limit it to 1-2 lines for the smaller sizes though. You 
could probably replace the text with the lines/motif in small sizes too.
  >
  > More ideas for that: 
https://www.google.com.ar/search?dcr=0&tbs=imgo%3A1&tbm=isch&sa=1&ei=Rj1-WvPjLYaTwgTj1p2YCw&q=80s+cassette&oq=80s+cassette&gs_l=psy-ab.3..0l2j0i30k1l4j0i8i30k1l2.18392.20298.0.20566.12.12.0.0.0.0.115.1019.11j1.12.00...1c.1.64.psy-ab..0.12.1013...0i67k1j0i10i24k1.0.PyemoiQ5FVk
  >
  > BTW, love your avatar!
  
  
  I followed your advice, here is a big version and a preview in my application 
launcher 
  F5705811: Big2.png 
  F5705810: Screenshot_20180211_200206.png 

  
  In D10365#203820 , @mgallien wrote:
  
  > Thanks for your work. I am hesitant about the choice of an audio tape. I 
fear people under 30 will not recognize it.
  >  I would like to propose trying the tape with the current color and we can 
revisit this decision in 6 months.
  >  I agree on the text removal and your choice of color is good for me.
  
  
  I understand your concern. However we could say the same thing about vinyls, 
and many apps are using vinyls as icons.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien
Cc: mgallien, januz, astippich, andreask, andreaska, ltoscano, ngraham, 
#frameworks, paullesur, michaelh, ognarb, kmf, progwolff

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

[Jaime Torres Amate]

jtamate added a comment.


  In D9840#204587 , @dfaure wrote:
  
  > Can you strace vivaldi to see what it's doing? It must be doing something 
wrong if it's triggering so much I/O.
  
  
  This is related to https://phabricator.kde.org/D10342
  
  I've straced vivaldi and main process is continuously doing futex and gettid, 
and the active child the same + write + sendto. Every tab is a process, just 
like chromium.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D9840

To: jtamate, #frameworks, dfaure
Cc: ngraham, mmustac, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Friedrich W . H . Kossebau]

kossebau added a comment.


  "This (hopefully) fixes the build failure noticed in the FreeBSD (and some 
linuxes)" - leaves the question: why should it exactly fix it? :)
  
  From discussion of last week on irc, it seemed that the actual problem is 
that the generated make files do not contain the dependency between the JSON 
file that needs to be generated and automoc running over the cpp source file to 
generate the moc file based on the referenced JSON file.
  So in a highly parallel build the automoc is run before the JSON file is 
generated.
  
  Something which e.g. is tried to be solved by the code in the 
`kcoreaddons_add_plugin` macro, by grepping over all the source files to find 
the cpp file which references the JSON file and then create the dependency by
  
set_property(SOURCE ${dependent_sources} APPEND PROPERTY OBJECT_DEPENDS 
${json})
  
  Thing is that Plasma only uses the `kcoreaddons_desktop_to_json` macro, so 
this is why it runs the chance to fail here, while all other projects which 
create the JSON still on the fly, also call `kcoreaddons_add_plugin`, cmp. 
https://lxr.kde.org/search?_filestring=&_string=kcoreaddons_add_plugin&_casesensitive=1
  
  But not further explored, so still curious if that really is the case or if 
you found the real reason.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure
Cc: kossebau, #frameworks, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Tobias C . Berner]

tcberner added reviewers: bshah, dfaure.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure
Cc: #frameworks, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Tobias C . Berner]

tcberner created this revision.
tcberner added reviewers: FreeBSD, mpyne.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
tcberner requested review of this revision.

REVISION SUMMARY
  This creates a custom target 'desktop_to_json_X' and then depends on
  it instead of the output file.
  
  This (hopefully) fixes the build failure noticed in the FreeBSD (and some 
linuxes)
  
  - 
https://build.kde.org/view/OS%20-%20FreeBSD/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/138/console
  - https://mail.kde.org/pipermail/kde-freebsd/2018-February/027372.html
  - https://www.mail-archive.com/kde-bugs-dist@kde.org/msg207825.html

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10450

AFFECTED FILES
  KF5CoreAddonsMacros.cmake

To: tcberner, #freebsd, mpyne
Cc: #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 130 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/130/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 11 Feb 2018 20:21:10 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31490/59491)38%
(18479/48748)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8548/9096)48%
(5214/10759)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8340/14343)50%
(4868/9704)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3872/7838)33%
(1634/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)5

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 128 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/128/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Sun, 11 Feb 2018 20:09:22 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31481/59489)38%
(18494/48824)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8548/9096)48%
(5210/10759)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8321/14342)50%
(4869/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3872/7838)33%
(1634/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 110 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/110/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 11 Feb 2018 20:13:36 +
 Build duration:
9 min 19 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 129 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/129/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 11 Feb 2018 20:00:49 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31490/59490)38%
(18479/48748)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8547/9095)48%
(5213/10759)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8340/14343)50%
(4870/9704)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3873/7838)33%
(1635/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)5

D10414: Add move semantics support to KIO::UDSEntry.

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I actually see little point in verifying that *compiler generated* code 
copies all members correctly. We can trust the compiler :-)
  
  So, to me this looks ok (minus the last two small comments).
  
  If however you were to implement a more complete checking of fields, I would 
recommend against hashing (how do you debug it when the expected value is 
wrong?), and to go instead for a string representation (concatenate data using 
a separator [doesn't matter if the separator is used in one of the values, 
there's no splitting back needed], QCOMPARE the two strings, then failures 
*can* be debugged). But as I said, this doesn't seem necessary here.

INLINE COMMENTS

> udsentrytest.cpp:227
> +/**
> + * Test to verify that move semantics work. This is only useful when ran 
> through a profiling or dubugging tool.
> + */

typo: it's debugging, with an 'e'

> udsentrytest.cpp:233
> +QTemporaryFile file;
> +QCOMPARE(file.open(), true);
> +const QByteArray filePath = QFile::encodeName(file.fileName());

That one, however, could be QVERIFY(), that's what it's for ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10414

To: markg, dfaure
Cc: apol, #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 109 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/109/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 11 Feb 2018 20:00:49 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirmodeltest

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

[David Faure]

dfaure added a comment.


  Can you strace vivaldi to see what it's doing? It must be doing something 
wrong if it's triggering so much I/O.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D9840

To: jtamate, #frameworks, dfaure
Cc: ngraham, mmustac, michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 127 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/127/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Sun, 11 Feb 2018 20:00:49 +
 Build duration:
8 min 31 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31489/59489)38%
(18492/48824)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8547/9095)48%
(5214/10759)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8329/14343)50%
(4868/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3873/7838)33%
(1635/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

[David Faure]

dfaure added a comment.


  (FWIW I tested my desktop file in dolphin, not in plasma)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10405

To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  If only it was that simple, I would have done this years ago.
  
  Download http://www.davidfaure.fr/2018/weirdcommand.desktop and then running 
that desktop file, without and then with your patch.
  If works for me without, and I bet it fails with your patch, because "if" 
isn't an executable.
  (https://commits.kde.org/kio/0e28930e6748fb45d152e7c3023a034b7db23854 shows 
what executablePath() will return for that Exec line).
  
  The reason this code was in slotProcessExited is that at that point we know 
something went wrong, and we can try to find out what happened (and if we get 
the diagnosis slightly wrong, the harm is minimal, an error did happen in any 
case). OTOH your patch will fail with any sort of shell command in the Exec 
line, that doesn't start with an executable name.
  
  I think the actual fix is to call a virtual method for that messagebox, so 
that it can be implemented differently in apps that don't like message boxes 
(not just plasma but also e.g. dolphin).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10405

To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh

D10433: Add QML support for Prison

[Volker Krause]

vkrause updated this revision to Diff 26950.
vkrause added a comment.


  Address review comments.

REPOSITORY
  R280 Prison

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10433?vs=26907&id=26950

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10433

AFFECTED FILES
  .gitignore
  CMakeLists.txt
  src/CMakeLists.txt
  src/quick/CMakeLists.txt
  src/quick/barcodequickitem.cpp
  src/quick/barcodequickitem.h
  src/quick/prisonquickplugin.cpp
  src/quick/qmldir
  tests/barcode.qml

To: vkrause, #frameworks, svuorela
Cc: broulik, davidedmundson, michaelh

D10433: Add QML support for Prison

[Volker Krause]

vkrause added a comment.


  In D10433#204528 , @broulik wrote:
  
  > Cool! Would allow us to get rid of the custom barcode stuff in Plasma's 
clipboard plasmoid.
  >
  > Does barcode generation need to be in a separate thread? The Plasma codes 
does it, not sure how big of a performance impact this has?
  
  
  I haven't profiled this, but re-generating the barcode at the key repeat rate 
with the QML test included in this commit shows no measurable CPU cost or 
rendering lag on a desktop machine for any of the code types.

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D10433

To: vkrause, #frameworks, svuorela
Cc: broulik, davidedmundson, michaelh

D10312: FileUndoManager: don't delete non-existing local files

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in fileundomanager.cpp:404
> You mean just an `emit undoAvailable(false);` ?

Yep.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10312

To: elvisangelaccio, dfaure
Cc: ngraham, #frameworks, michaelh

D10433: Add QML support for Prison

[Kai Uwe Broulik]

broulik added a comment.


  Cool! Would allow us to get rid of the custom barcode stuff in Plasma's 
clipboard plasmoid.
  
  Does barcode generation need to be in a separate thread? The Plasma codes 
does it, not sure how big of a performance impact this has?

INLINE COMMENTS

> barcodequickitem.cpp:144
> +m_barcode->toImage(m_barcode->minimumSize());
> +setImplicitWidth(m_barcode->minimumSize().width());
> +setImplicitHeight(m_barcode->minimumSize().height());

Use `setImplicitSize` to do both in one go and avoid intermediate signal 
emissions

> barcodequickitem.h:90
> +Prison::BarcodeType m_type = Prison::Null;
> +bool m_complete = false;
> +};

`QQuickPaintedItem` inherits `QQuickItem` which has a `isComponentComplete()` 
method, no need to keep track of that yourself

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D10433

To: vkrause, #frameworks, svuorela
Cc: broulik, davidedmundson, michaelh

D10446: Add KLanguageName

[Albert Astals Cid]

aacid added a comment.


  With this i can finally stop using kdelibs4support in KTuberling

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid
Cc: #frameworks, michaelh

D10446: Add KLanguageName

[Albert Astals Cid]

aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
aacid requested review of this revision.

REVISION SUMMARY
  KLanguageName is a helper namespace that returns the name of a given language 
code.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10446

AFFECTED FILES
  src/CMakeLists.txt
  src/klanguagename.cpp
  src/klanguagename.h

To: aacid
Cc: #frameworks, michaelh

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

[René J . V . Bertin]

rjvbb added a comment.


  Thanks Gilles.
  
  Please remember that perfect is the enemy of good and that further 
improvements can always be applied down the road.
  
  This patch touches only Mac and concerns very specific functionality that is 
used by only very few applications (besides digiKam I can only think of Dolphin 
and the KDE file dialogs). Given that I am inclined to committing it say next 
Friday if I don't get revision requests I cannot address by then.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D7401

To: rjvbb, #frameworks, kfunk
Cc: ngraham, kfunk, anthonyfieroni, cgilles, kde-mac, michaelh

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

[Gilles Caulier]

cgilles added a comment.


  PING again to KF5 core developpers ...
  
  We need to advance with this very important patch to support properly Apple 
device with Solid. This will permit to use Apple hardware as well, as under 
Linux.
  
  Please review, fix, and validate this non negligible job, done by René.
  
  Thanks in advance.
  
  Gilles Caulier

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D7401

To: rjvbb, #frameworks, kfunk
Cc: ngraham, kfunk, anthonyfieroni, cgilles, kde-mac, michaelh

D9973: ktooltipwidget: Fix tooltip positioning

[Michael Heidelbach]

michaelh marked an inline comment as done.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D9973

To: michaelh, elvisangelaccio, #frameworks, #dolphin, ngraham
Cc: cfeck, michaelh

D9973: ktooltipwidget: Fix tooltip positioning

[Michael Heidelbach]

michaelh updated this revision to Diff 26940.
michaelh added a comment.


  - Clean code

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9973?vs=26717&id=26940

BRANCH
  tooltip_and_test

REVISION DETAIL
  https://phabricator.kde.org/D9973

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/ktooltippositiontest.cpp
  autotests/ktooltippositiontest.h
  src/ktooltipwidget.cpp

To: michaelh, elvisangelaccio, #frameworks, #dolphin, ngraham
Cc: cfeck, michaelh

D10432: Set minimum size on 1D barcodes as well

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R280:278c6def9d32: Set minimum size on 1D barcodes as well 
(authored by vkrause).

REPOSITORY
  R280 Prison

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10432?vs=26895&id=26939

REVISION DETAIL
  https://phabricator.kde.org/D10432

AFFECTED FILES
  src/lib/code39barcode.cpp
  src/lib/code93barcode.cpp

To: vkrause, #frameworks, svuorela
Cc: michaelh

D10437: Limit the use of file.so for privilege operation to one application

[Fabian Vogt]

fvogt added a comment.


  In D10437#204377 , @chinmoyr wrote:
  
  > The whole work is being done inside KIO::Job. If the application uses 
regular Jobs then I can't see how it can fake it.
  
  
  By not using KIO or using a modified KIO. Never assume you can trust anything 
you get sent.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10437

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: anthonyfieroni, michaelh

D10437: Limit the use of file.so for privilege operation to one application

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> slavebase.h:957
> + */
> +bool mAppChanged;
>  

Will break ABI, add new member variables only in SlaveBasePrivate

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10437

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: anthonyfieroni, michaelh

D10437: Limit the use of file.so for privilege operation to one application

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  In D10437#204417 , @markg wrote:
  
  > Could you provide steps to reproduce what you try to fix?
  
  
  Steps:
  create files /opt/{a,b}
  open kioslavetest
  delete /opt/a
  open ksysguard and send interrupt signal to kioslavetest
  again open kioslavetest
  delete /opt/b
  
  Without this patch "/opt/b" will be deleted but password won't be asked.
  With this patch an error will be shown.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10437

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: markg, anthonyfieroni, michaelh

D9973: ktooltipwidget: Fix tooltip positioning

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> ktooltippositiontest.cpp:141
> +KToolTipWidget tooltip;
> +tooltip.showBelow(targetRect, contentWidget, transientParent);
> +QRect tooltipRect(tooltip.frameGeometry());

`QVERIFY(QTest::qWaitForWindowActive(&tooltip));` ?
​

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D9973

To: michaelh, elvisangelaccio, #frameworks, #dolphin, ngraham
Cc: cfeck, michaelh

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

[Jaime Torres Amate]

jtamate added a comment.


  > ! In D9840#203803 , @ngraham 
wrote:
  >  Do any of the active or recently-landed patches address this?
  
  No, but I have one in https://phabricator.kde.org/D10342

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D9840

To: jtamate, #frameworks, dfaure
Cc: ngraham, mmustac, michaelh

D7175: Redesign CMake syntax

[Alex Turbov]

turbov updated this revision to Diff 26933.
turbov added a comment.


  Updates for CMake 3.11

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7175?vs=23100&id=26933

REVISION DETAIL
  https://phabricator.kde.org/D7175

AFFECTED FILES
  data/generators/cmake-gen.sh
  data/generators/cmake.xml.tpl
  data/generators/cmake.yaml
  data/generators/generate-cmake-syntax.py
  data/syntax/cmake.xml

To: turbov, dhaumann, #kate, #framework_syntax_highlighting, vkrause
Cc: cullmann, #frameworks, michaelh

D10437: Limit the use of file.so for privilege operation to one application

[Mark Gaiser]

markg added a comment.


  In D10437#204416 , @chinmoyr wrote:
  
  > In D10437#204402 , @markg wrote:
  >
  > > I just tried this:
  > >  kdesu gwenview (type root password and go to the root homefolder).
  > >  In gwenview i can now go to that folder.
  > >  In dolphin (started as user, not root) i can't get into that folder.
  > >
  > > I don't really see what you try to fix here as it seems to be working 
just fine here.
  > >  Or i don't understand it.. In that case, please provide reproducible 
steps.
  >
  >
  > Currently file ioslave does not support reading contents of a locked(is 
this the right word?) folder. So no file operations are possible.
  
  
  Could you provide steps to reproduce what you try to fix?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10437

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: markg, anthonyfieroni, michaelh

D10437: Limit the use of file.so for privilege operation to one application

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  In D10437#204402 , @markg wrote:
  
  > I just tried this:
  >  kdesu gwenview (type root password and go to the root homefolder).
  >  In gwenview i can now go to that folder.
  >  In dolphin (started as user, not root) i can't get into that folder.
  >
  > I don't really see what you try to fix here as it seems to be working just 
fine here.
  >  Or i don't understand it.. In that case, please provide reproducible steps.
  
  
  Currently file ioslave does not support reading contents of a locked(is this 
the right word?) folder. So no file operations are possible.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10437

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: markg, anthonyfieroni, michaelh

D10437: Limit the use of file.so for privilege operation to one application

[Fabian Vogt]

fvogt added a comment.


  In D10437#204413 , @chinmoyr wrote:
  
  > In D10437#204382 , @fvogt wrote:
  >
  > > In D10437#204377 , @chinmoyr 
wrote:
  > >
  > > > The whole work is being done inside KIO::Job. If the application uses 
regular Jobs then I can't see how it can fake it.
  > >
  > >
  > > By not using KIO or using a modified KIO. Never assume you can trust 
anything you get sent.
  >
  >
  > Going by this logic, it seems any attempt at providing security from job's 
side is pointless.
  
  
  It is.
  
  > So how about moving the handling of prompts to slave's side? At least we 
can be sure a prompt will be shown all the time.
  
  Sounds good. Once polkit granted file.so authorized access to the helper, it 
needs to be treated as privilege boundary so it needs to prompt.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10437

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: markg, anthonyfieroni, michaelh

D10437: Limit the use of file.so for privilege operation to one application

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  In D10437#204382 , @fvogt wrote:
  
  > In D10437#204377 , @chinmoyr 
wrote:
  >
  > > The whole work is being done inside KIO::Job. If the application uses 
regular Jobs then I can't see how it can fake it.
  >
  >
  > By not using KIO or using a modified KIO. Never assume you can trust 
anything you get sent.
  
  
  Going by this logic, it seems any attempt at providing security from job's 
side is pointless. So how about moving the handling of prompts to slave's side? 
At least we can be sure a prompt will be shown all the time.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10437

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: markg, anthonyfieroni, michaelh

D10437: Limit the use of file.so for privilege operation to one application

[Mark Gaiser]

markg added a comment.


  I just tried this:
  kdesu gwenview (type root password and go to the root homefolder).
  In gwenview i can now go to that folder.
  In dolphin (started as user, not root) i can't get into that folder.
  
  I don't really see what you try to fix here as it seems to be working just 
fine here.
  Or i don't understand it.. In that case, please provide reproducible steps.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10437

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: markg, anthonyfieroni, michaelh

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 47 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/47/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 11 Feb 2018 12:44:02 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 42 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/42/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
 Date of build:
Sun, 11 Feb 2018 12:44:02 +
 Build duration:
9 min 19 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 31 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/31/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 11 Feb 2018 12:44:02 +
 Build duration:
3 min 53 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittest

D10444: Improve KLanguageButton::insertLanguage when no name is passed

[Albert Astals Cid]

aacid updated this revision to Diff 26924.
aacid added a comment.


  Do not return "without name" in nameFromEntryFile
  
  An empty string is better so the fallback ifs try to get a name for the 
language code

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10444?vs=26921&id=26924

BRANCH
  arcpatch-D10444

REVISION DETAIL
  https://phabricator.kde.org/D10444

AFFECTED FILES
  src/klanguagebutton.cpp

To: aacid
Cc: #frameworks, michaelh

D10437: Limit the use of file.so for privilege operation to one application

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  The whole work is being done inside KIO::Job. If the application uses regular 
Jobs then I can't see how it can fake it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10437

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: michaelh

D10437: Limit the use of file.so for privilege operation to one application

[Fabian Vogt]

fvogt added a comment.


  If I'm not mistaken, the application sends its own pid to the slave.
  This means it could just fake it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10437

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: michaelh

D10445: Improve KSwitchLanguageDialogPrivate::fillApplicationLanguages

[Albert Astals Cid]

aacid added a comment.


  together with https://phabricator.kde.org/D10444 fixes 
https://bugs.kde.org/show_bug.cgi?id=390078

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D10445

To: aacid
Cc: #frameworks, michaelh

D10445: Improve KSwitchLanguageDialogPrivate::fillApplicationLanguages

[Albert Astals Cid]

aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
aacid requested review of this revision.

REVISION SUMMARY
  KLanguageButton::insertLanguage already knows how to figure out the name
  of a language, so no need to do it ourselves

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10445

AFFECTED FILES
  src/kswitchlanguagedialog_p.cpp

To: aacid
Cc: #frameworks, michaelh

D10444: Improve KLanguageButton::insertLanguage when no name is passed

[Albert Astals Cid]

aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
aacid requested review of this revision.

REVISION SUMMARY
  Move the reading of kf5_entry.desktop from KLanguageButton::loadAllLanguages
  to KLanguageButton::insertLanguage that way all the users can benefit
  from it
  
  Use QLocale::languageToString if QLocale::nativeLanguageName is empty,
  this comes from KSwitchLanguageDialogPrivate::fillApplicationLanguages

REPOSITORY
  R265 KConfigWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10444

AFFECTED FILES
  src/klanguagebutton.cpp

To: aacid
Cc: #frameworks, michaelh

D10432: Set minimum size on 1D barcodes as well

[Sune Vuorela]

svuorela accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D10432

To: vkrause, #frameworks, svuorela
Cc: michaelh

D10433: Add QML support for Prison

[Volker Krause]

vkrause updated this revision to Diff 26907.
vkrause added a comment.


  Address review comments.

REPOSITORY
  R280 Prison

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10433?vs=26896&id=26907

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10433

AFFECTED FILES
  .gitignore
  CMakeLists.txt
  src/CMakeLists.txt
  src/quick/CMakeLists.txt
  src/quick/barcodequickitem.cpp
  src/quick/barcodequickitem.h
  src/quick/prisonquickplugin.cpp
  src/quick/qmldir
  tests/barcode.qml

To: vkrause, #frameworks, svuorela
Cc: davidedmundson, michaelh

D10437: Limit the use of file.so for privilege operation to one application

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added reviewers: Frameworks, dfaure, fvogt.
Restricted Application added a project: Frameworks.
chinmoyr requested review of this revision.

REVISION SUMMARY
  After successful authorization for privilege execution the whole session gets 
full root-level access via file.so.
  This patch changes file ioslave to not perform a privilege operation if the 
application which is requesting the
  operation is different from the one that initially requested the operation. 
However, an exception is made if
  the request came after the expiration of temporary authorization.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10437

AFFECTED FILES
  src/core/simplejob.cpp
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: michaelh

D10433: Add QML support for Prison

[Volker Krause]

vkrause added inline comments.

INLINE COMMENTS

> davidedmundson wrote in barcodequickitem.cpp:37
> Is createBarcode a heavy function? It sounds like it could be.
> 
> If so I'd recommend using QQmlParserStatus so you don't generate it 4 times 
> on startup as each property gets set.

Right, that's cleaner, I'll fix that.

> davidedmundson wrote in barcodequickitem.cpp:113
> you have the actual up-to-date item size from inside paint. Would that be 
> better than minimumSize?
> 
> Please also change to
> 
> img = m_barcode->toImage(size * qApp->devicePixelRatio());
> img.setDevicePixelRatio(qApp->devicePixelRatio());
> 
> for high DPI support.

I don't think any of this makes a visual difference here, as the image is 
ultimately just a black/white pattern that is scaled with nearest neighbor 
scaling anyway, we'd just be moving that scaling around a bit. Results look 
sharp here at 1x/1.5x/2x scaling and are detected correctly by the barcode 
scanner.

> davidedmundson wrote in barcodequickitem.cpp:131
> You're doing this in the paint, do you need to do this here?

That's an issue with Prison, you only get a valid minimum size after one call 
to toImage(). I'll add a comment about that.

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D10433

To: vkrause, #frameworks, svuorela
Cc: davidedmundson, michaelh

D10420: Make sure the FrameSvg and Svg instances have the right devicePixelRatio

[Eike Hein]

hein added a comment.


  Sanity check question: Did you make sure this doesn't introduce an extra 
render when things start up? (Initial vs. change.)
  
  Otherwise makes sense (and finally fixes some Wayland uglyness I've been 
annoyed by ...).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10420

To: apol, #plasma
Cc: hein, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart