D10054: Fix: View jumps when Scroll past end of document is enabled

[Christoph Cullmann]

cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Then lets reopen it.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D10054

To: dhaumann, cullmann
Cc: rikmills, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, 
sars, dhaumann

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 21 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/21/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.7
 Date of build:
Tue, 13 Feb 2018 04:16:46 +
 Build duration:
4 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report25%
(5/20)30%
(17/57)30%
(17/57)21%
(436/2102)21%
(258/1250)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)92%
(143/155)58%
(109/188)src100%
(8/8)100%
(8/8)68%
(205/302)47%
(111/235)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/141)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/4)0%
(0/4)0%
(0/243)0%
(0/84)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)67%
(32/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/121)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
(0/0)src.widgets100%
(2/2)100%
(2/2)96%
(48/50)60%
 

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 44 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/44/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
 Date of build:
Tue, 13 Feb 2018 02:20:01 +
 Build duration:
5 min 21 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 49 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/49/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 13 Feb 2018 02:20:01 +
 Build duration:
5 min 21 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 33 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/33/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 13 Feb 2018 02:20:01 +
 Build duration:
4 min 32 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittest

D9912: [KNewFileMenu] KDirNotify::emitFilesAdded after storedPut

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works great, thanks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9912

To: broulik, dfaure, ngraham
Cc: ngraham, #frameworks, michaelh

D10414: Add move semantics support to KIO::UDSEntry.

[Mark Gaiser]

markg marked 2 inline comments as done.
markg added a comment.


  I'm not afraid of the compiler generating wrong code. That is the least of my 
worries :)
  What i am afraid of (which is why i suggested the copy test) is a wrong 
optimization at some point (like adding a pointer member but forgetting to 
properly copy it) which would break the UDSEntry.
  But a test for that would probably deserves its own review independent of 
this.
  
  Forget it, i have no plans to change the internal data structure of UDSEntry. 
I might play with a HAT-trie  at some point 
but that is unlikely to be on the UDSEntry level. It would be much more 
suitable on the KCoreDirLister level.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10414

To: markg, dfaure
Cc: apol, #frameworks, michaelh

D10414: Add move semantics support to KIO::UDSEntry.

[Mark Gaiser]

markg updated this revision to Diff 27028.
markg added a comment.


  Fix a typo and replace QCOMPARE with QVERIFY for the file open check.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10414?vs=26868&id=27028

BRANCH
  udsentry_reductions

REVISION DETAIL
  https://phabricator.kde.org/D10414

AFFECTED FILES
  autotests/udsentrytest.cpp
  autotests/udsentrytest.h
  src/core/udsentry.cpp
  src/core/udsentry.h

To: markg, dfaure
Cc: apol, #frameworks, michaelh

D10444: Improve KLanguageButton::insertLanguage when no name is passed

[Albert Astals Cid]

aacid updated this revision to Diff 27027.
aacid added a comment.


  fix suggestion by Aleix

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10444?vs=26924&id=27027

BRANCH
  arcpatch-D10444_1

REVISION DETAIL
  https://phabricator.kde.org/D10444

AFFECTED FILES
  src/klanguagebutton.cpp

To: aacid
Cc: apol, #frameworks, michaelh

D10444: Improve KLanguageButton::insertLanguage when no name is passed

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> apol wrote in klanguagebutton.cpp:148
> Why `QStringLiteral("locale") + QLatin1Char('/')`?

Because i wrote that as result of copy&paste, i'll fix it.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10444

To: aacid
Cc: apol, #frameworks, michaelh

D10365: New icon for Elisa music player

[Marijo Mustac]

mmustac added a comment.


  Old-school rules! Also just think of the floppy 💾 disk icon which is mostly 
everywhere the save icon.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien
Cc: mmustac, mgallien, januz, astippich, andreask, andreaska, ltoscano, 
ngraham, #frameworks, jussiv, paullesur, michaelh, ognarb, kmf, progwolff

D10054: Fix: View jumps when Scroll past end of document is enabled

[Rik Mills]

rikmills added a comment.


  This change appears to cause ktexteditor to fail it's vimode_completion 
autotests.
  
  From KDE CI: 
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/35/testReport/junit/(root)/TestSuite/vimode_completion/
  
  Ubuntu autotests: F5707888: testsuite-stdout 

  
  Reported as bug https://bugs.kde.org/show_bug.cgi?id=390333 as this currently 
blocks 5.43 from getting into Ubuntu.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D10054

To: dhaumann, cullmann
Cc: rikmills, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, 
sars, dhaumann

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Raphael Kubo da Costa]

rakuco requested changes to this revision.
rakuco added a comment.
This revision now requires changes to proceed.


  @kossebau's right: the problem lies in `lookandfeeltool` depending on 
`kcm.cpp`, while the `kcoreaddons_desktop_to_json()` call makes the 
`kcm_lookandfeel` target depend on the generation of the json file. It's pretty 
easy to reproduce this bug by running `make lookandfeeltool_autogen` with a 
fresh build directory.
  
  > For this very patch, I am still lost on how cmake generates the rules for 
automoc stuff, so no clue if switching to an explicit intermediate target 
improves something.
  
  In terms of generated `Makefile`s, without the patch in this review request 
we have 
`$BUILDDIR/kcms/lookandfeel/CMakeFiles/kcm_lookandfeel_autogen.dir/build.make` 
with the right dependencies 
(`kcms/lookandfeel/CMakeFiles/kcm_lookandfeel_autogen` depends on 
`kcms/lookandfeel/kcm_lookandfeel.json`, which calls `desktoptojson`). With 
this patch applied, the difference is that the dependency is moved to 
`$BUILDDIR/CMakeFiles/Makefile2`, where 
`kcms/lookandfeel/CMakeFiles/kcm_lookandfeel_autogen.dir/all` depends on 
`kcms/lookandfeel/CMakeFiles/desktop_to_json_.dir/all`. 
`kcms/lookandfeel/CMakeFiles/lookandfeeltool_autogen.dir/all` still doesn't 
depend on anything though, so the bug persists if I run `make  
lookandfeeltool_autogen` directly.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure, rakuco
Cc: rakuco, kfunk, adridg, kossebau, #frameworks, michaelh

D10329: [KUrlNavigatorPlacesSelector] Put categories into submenus

[Nathaniel Graham]

ngraham added a comment.


  The Places panel items are always visible without a submenu, so there should 
never be a situation where the menu consists entirely of submenus.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10329

To: broulik, #vdg, #frameworks, dfaure
Cc: abetts, michaelh, ngraham

D10329: [KUrlNavigatorPlacesSelector] Put categories into submenus

[Andres Betts]

abetts added a comment.


  Will this hide "All" menu items or will it hide after a certain amount of 
them are in the menu? For example, it will turn into a sub menu after 3 items?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10329

To: broulik, #vdg, #frameworks, dfaure
Cc: abetts, michaelh, ngraham

D10329: [KUrlNavigatorPlacesSelector] Put categories into submenus

[Michael Heidelbach]

michaelh added a comment.


  +1 Looking forward to it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10329

To: broulik, #vdg, #frameworks, dfaure
Cc: michaelh, ngraham

D10464: Initialize m_actualGroup to NormalColorGroup

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
apol requested review of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10464

AFFECTED FILES
  src/declarativeimports/core/colorscope.cpp

To: apol, #frameworks, dfaure
Cc: michaelh

D9912: [KNewFileMenu] KDirNotify::emitFilesAdded after storedPut

[Kai Uwe Broulik]

broulik added a comment.


  Ping

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9912

To: broulik, dfaure
Cc: #frameworks, michaelh

D10462: Android toolchain: add ANDROID_COMPILER_PREFIX variable.

[David Faure]

dfaure closed this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D10462

To: dfaure, apol, mart
Cc: #build_system, #frameworks, michaelh

D10329: [KUrlNavigatorPlacesSelector] Put categories into submenus

[Kai Uwe Broulik]

broulik added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10329

To: broulik, #vdg, #frameworks, dfaure
Cc: ngraham, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Friedrich W . H . Kossebau]

kossebau added a subscriber: kfunk.
kossebau added a comment.


  In D10450#204762 , @adridg wrote:
  
  > In D10450#204623 , @kossebau 
wrote:
  >
  > > "This (hopefully) fixes the build failure noticed in the FreeBSD (and 
some linuxes)" - leaves the question: why should it exactly fix it? :)
  >
  >
  > From reading the CMake documentation, it seems (but I'll admit that fancy 
dependency stuff is a dark art in CMake) that AUTOGEN_TARGET_DEPENDS shouldn't 
be a **file**, but a **target**. This patch adds a target, created by the given 
command and hooks that into the dependency graph.
  
  
  Okay, by reading the docs I would agree.
  
  >> From discussion of last week on irc, it seemed that the actual problem is 
that the generated make files do not contain the dependency between the JSON 
file that needs to be generated and automoc running over the cpp source file to 
generate the moc file based on the referenced JSON file.
  > 
  > And that's the whole problem, isn't it. If you force the dependency arc to 
be there -- i.e. by using the target property here -- then it works.
  
  Seems I am to blame for reading code with preoccupied mind :) indeed missed 
what the actual intention of the very line
  
set_property(TARGET ${target} APPEND PROPERTY AUTOGEN_TARGET_DEPENDS 
${json})
  
  was.
  
  >> Something which e.g. is tried to be solved by the code in the 
`kcoreaddons_add_plugin` macro, by grepping over all the source files to find 
the cpp file which references the JSON file and then create the dependency by
  >> 
  >>   set_property(SOURCE ${dependent_sources} APPEND PROPERTY OBJECT_DEPENDS 
${json})
  >>
  > 
  > If this patch fixes the dependency arc, then possibly that (expensive?) 
grepping around isn't needed either.
  
  Indeed. I remember vaguely though there were some bugs with 
AUTOGEN_TARGET_DEPENDS, @kfunk didn't you do something related to that?
  
  > I'll try to do some Makefile-dissection.
  
  Tried as well myself to get an idea, though somehow with the patch I still 
could not find the dep rules I expected. Discovered something else though:
  
  the CMakeLists.txt of the lookandfeel kcm actually defines two targets, which 
both have as source the 'kcm.cpp' file, 'kcm_lookandfeel' and 'lookandfeeltool`:
  
set(kcm_lookandfeel_SRCS
  kcm.cpp
  ../krdb/krdb.cpp
  ../cursortheme/xcursor/cursortheme.cpp
  ../cursortheme/xcursor/xcursortheme.cpp
)

add_library(kcm_lookandfeel MODULE ${kcm_lookandfeel_SRCS})
kcoreaddons_desktop_to_json(kcm_lookandfeel "kcm_lookandfeel.desktop" 
SERVICE_TYPES kcmodule.desktop)

set(lookandfeeltool_SRCS
lnftool.cpp
kcm.cpp
../krdb/krdb.cpp
../cursortheme/xcursor/cursortheme.cpp
../cursortheme/xcursor/xcursortheme.cpp
)

add_executable(lookandfeeltool ${lookandfeeltool_SRCS})
  
  Also note that automoc will be run on the sources for both targets. While the 
kcoreaddons_desktop_to_json macro as used is just adding rules related to the 
JSON file for the kcm_lookandfeel target.
  
  Now if we have a very close look at the build log files, we can see that it 
is actually the automoc being run for the sources of the lookandfeeltool 
target, which fails due to the missing JSON file. Which makes sense, given 
there are no dependency rules set by us. So even with this patch we have a race 
condition on the parallel build for the kcm_lookandfeel. This might also 
explain why we only see this kind of failure for this kcm, but nowhere else.
  
  So a separate fix for the build issue would be to make sure the 
K_PLUGIN_FACTORY_WITH_JSON call is in a separate source file only used for the 
kcm_lookandfeel target.
  
  For this very patch, I am still lost on how cmake generates the rules for 
automoc stuff, so no clue if switching to an explicit intermediate target 
improves something.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure
Cc: kfunk, adridg, kossebau, #frameworks, michaelh

D10462: Android toolchain: add ANDROID_COMPILER_PREFIX variable.

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10462

To: dfaure, apol, mart
Cc: #build_system, #frameworks, michaelh

D10462: Android toolchain: add ANDROID_COMPILER_PREFIX variable.

[David Faure]

dfaure created this revision.
dfaure added reviewers: apol, mart.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added a subscriber: Build System.
dfaure requested review of this revision.

REVISION SUMMARY
  For ARM it's not necessary, but when building for a x86 tablet I had to
  set ANDROID_TOOLCHAIN=x86 while gcc/g++ are prefixed with
  i686-linux-android.
  
  i.e. the path is 
android-ndk-r10e/toolchains/x86-4.9/prebuilt/linux-x86_64/bin/i686-linux-android-g++

TEST PLAN
  cmake picks up the right compiler for me now

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10462

AFFECTED FILES
  toolchain/Android.cmake

To: dfaure, apol, mart
Cc: #build_system, #frameworks, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 60 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/60/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 12 Feb 2018 13:37:48 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13295)19%
(1979/10493)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2227)7%
(102/1488)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/1968)18%
(306/1703)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 63 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/63/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 12 Feb 2018 13:37:48 +
 Build duration:
9 min 32 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3559/13291)19%
(1978/10493)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2223)7%
(101/1484)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2917)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/1968)18%
(306/1703)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/36/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 12 Feb 2018 13:37:48 +
 Build duration:
8 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D10444: Improve KLanguageButton::insertLanguage when no name is passed

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> klanguagebutton.cpp:148
>  if (name.isEmpty()) {
> -text = languageCode;
> -QLocale locale(languageCode);
> -if (locale != QLocale::c()) {
> -text = locale.nativeLanguageName();
> -} else {
> -showCodes = false;
> +const QString entryFile = 
> QStandardPaths::locate(QStandardPaths::GenericDataLocation, 
> QStringLiteral("locale") + QLatin1Char('/') + languageCode + 
> QStringLiteral("/kf5_entry.desktop"));
> +if (QFile::exists(entryFile)) {

Why `QStringLiteral("locale") + QLatin1Char('/')`?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10444

To: aacid
Cc: apol, #frameworks, michaelh

D10420: Make sure the FrameSvg and Svg instances have the right devicePixelRatio

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:3e4b26452aeb: Make sure the FrameSvg and Svg instances 
have the right devicePixelRatio (authored by apol).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10420?vs=26855&id=26993

REVISION DETAIL
  https://phabricator.kde.org/D10420

AFFECTED FILES
  src/declarativeimports/core/framesvgitem.cpp
  src/declarativeimports/core/framesvgitem.h
  src/declarativeimports/core/iconitem.cpp

To: apol, #plasma, hein
Cc: hein, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10420: Make sure the FrameSvg and Svg instances have the right devicePixelRatio

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10420

To: apol, #plasma, hein
Cc: hein, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10420: Make sure the FrameSvg and Svg instances have the right devicePixelRatio

[Aleix Pol Gonzalez]

apol added a comment.


  In D10420#204235 , @hein wrote:
  
  > Sanity check question: Did you make sure this doesn't introduce an extra 
render when things start up? (Initial vs. change.)
  >
  > Otherwise makes sense (and finally fixes some Wayland uglyness I've been 
annoyed by ...).
  
  
  Only should be adding an extra rendering cycle if it was rendered with the 
wrong dpi, so it's something we need anyway.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10420

To: apol, #plasma
Cc: hein, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

[David Faure]

dfaure added a comment.


  Come on, this is fun! Well, unless you feel like I took the fun out of it by 
providing a solution...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10405

To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

[Eike Hein]

hein added a comment.


  /o\ I don't like life anymore

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10405

To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

[David Faure]

dfaure added a comment.


  The statics can be refactored, if they're internal ;)
  
  What's more troublesome is the KRun instance might have gone away by the time 
KProcessRunner ::slotProcessExited is called, though (which is why it's done in 
a different class).
  So maybe what's needed is rather some interface, like 
defaultJobUiDelegateExtension()->requestMessageBox().

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10405

To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

[Eike Hein]

hein added a comment.


  @dfaure I don't see how the virtual thing is going to work - there's numerous 
static affected codepaths so there's no 'this' to pass down to call the 
non-static error handler on.
  
  I could add a new "silent" RunFlag and pass that around to quiet the message 
box altogether, but this would mean zero error handling. I'm unhappy about that.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10405

To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh

D10072: Add APKBUILD to be highlighted as a Bash file

[Bhushan Shah]

bshah added a comment.


  In D10072#204816 , @ltoscano wrote:
  
  > I suggest to push a revert and push it again with the right metadata.
  
  
  done.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10072

To: PureTryOut, vkrause
Cc: ltoscano, dhaumann, bshah, vkrause, bcooksley, #frameworks, michaelh

D10072: Add APKBUILD to be highlighted as a Bash file

[Luigi Toscano]

ltoscano added a comment.


  I suggest to push a revert and push it again with the right metadata.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10072

To: PureTryOut, vkrause
Cc: ltoscano, dhaumann, bshah, vkrause, bcooksley, #frameworks, michaelh

D10072: Add APKBUILD to be highlighted as a Bash file

[Bhushan Shah]

bshah added a comment.


  Uhm sorry, arc screwed up author metadata :-(
  
  but submitted patch anyway.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10072

To: PureTryOut, vkrause
Cc: dhaumann, bshah, vkrause, bcooksley, #frameworks, michaelh

D10072: Add APKBUILD to be highlighted as a Bash file

[Bhushan Shah]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:7bafdc592040: Add APKBUILD to be highlighted as a Bash 
file (authored by bshah).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10072?vs=25985&id=26985

REVISION DETAIL
  https://phabricator.kde.org/D10072

AFFECTED FILES
  data/syntax/bash.xml

To: PureTryOut, vkrause
Cc: dhaumann, bshah, vkrause, bcooksley, #frameworks, michaelh

D8917: Reduce the amount of spurious property changes on ColorScope

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> colorscope.h:131
> +QObject *const m_parent;
> +Plasma::Theme::ColorGroup m_actualGroup;
>  

valgrind says this member isn't initialized, please fix.

http://www.davidfaure.fr/2018/colorscope_valgrind_log.txt

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D8917

To: apol, #plasma, mart, davidedmundson
Cc: dfaure, davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10437: Limit the use of file.so for privilege operation to one application

[David Faure]

dfaure added a comment.


  Indeed the sender could definitely fake the PID.
  One could generate and send a sha1 and store it in the slave (and send it as 
metadata with every command), but this can still be sniffed.
  I assume the KAuth security principle is that an intruder (who would have 
access to your session, and therefore can do a lot of things already, including 
installing a keylogger), shouldn't be able to get root access?
  In that case, either kio_file should lose priviledges immediately (sounds 
annoying for the user, but maybe that's the price of this feature?), or the app 
(libkio) should perform the file operations directly.
  
  I'm surprised you didn't hit that yet, btw. E.g. deleting local files, will 
not involve kio_file. DeleteJobPrivate::deleteNextFile calls QFile::remove() 
directly. Of course this isn't the case for all file operations (otherwise your 
patch wouldn't work at all), and it might not even be a good idea to generalize 
this (it's already visible that deleting a 6 GB local file will freeze the app, 
because of this - which was written under the assumption that deleting is fast).
  
  Brainstorming further: the other possibility is that kio_file processes that 
gained root auth, cannot be reused by another app later on. This could be done 
somehow in the KIO scheduler or in klauncher, if they can be told that this 
slave should be killed rather than reused once idle. The design of that stuff 
isn't fully clear in my mind (I didn't write that part), but make sure not to 
get confused by "idle slave which is associated to my process" 
(KIO::Scheduler's IdleJob, kills the slave after 3 minutes), and "idle slave 
that has been returned to klauncher" (in frameworks/kinit), for use by another 
process (or killed after 30s). But I can't find the code that returns an idle 
slave to klauncher (only a "slave that has been put on hold", which is a 
different use case (documented in kio/docs/krun-passing-slaves.txt).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10437

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: markg, anthonyfieroni, michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 130 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/130/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 12 Feb 2018 08:46:41 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31496/59489)38%
(18497/48822)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8548/9096)48%
(5212/10759)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8340/14343)50%
(4875/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3873/7838)33%
(1635/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Bhushan Shah]

bshah accepted this revision.
bshah added a comment.
This revision is now accepted and ready to land.


  +1

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure
Cc: adridg, kossebau, #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 112 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/112/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 12 Feb 2018 08:46:41 +
 Build duration:
9 min 6 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirmodeltest

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Adriaan de Groot]

adridg added a comment.


  In D10450#204623 , @kossebau wrote:
  
  > "This (hopefully) fixes the build failure noticed in the FreeBSD (and some 
linuxes)" - leaves the question: why should it exactly fix it? :)
  
  
  From reading the CMake documentation, it seems (but I'll admit that fancy 
dependency stuff is a dark art in CMake) that AUTOGEN_TARGET_DEPENDS shouldn't 
be a **file**, but a **target**. This patch adds a target, created by the given 
command and hooks that into the dependency graph.
  
  > From discussion of last week on irc, it seemed that the actual problem is 
that the generated make files do not contain the dependency between the JSON 
file that needs to be generated and automoc running over the cpp source file to 
generate the moc file based on the referenced JSON file.
  
  And that's the whole problem, isn't it. If you force the dependency arc to be 
there -- i.e. by using the target property here -- then it works. Note, though, 
that I haven't dissected a Makefile / ninja file to see that the dependency arc 
is really there. We just tested it by re-running the build a couple of times on 
32- and 48-core machines.
  
  > Something which e.g. is tried to be solved by the code in the 
`kcoreaddons_add_plugin` macro, by grepping over all the source files to find 
the cpp file which references the JSON file and then create the dependency by
  > 
  >   set_property(SOURCE ${dependent_sources} APPEND PROPERTY OBJECT_DEPENDS 
${json})
  >
  
  If this patch fixes the dependency arc, then possibly that (expensive?) 
grepping around isn't needed either.
  
  I'll try to do some Makefile-dissection.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure
Cc: adridg, kossebau, #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 132 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/132/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 12 Feb 2018 08:46:41 +
 Build duration:
5 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/442)67%
(295/442)53%
(31490/59490)38%
(18477/48746)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8548/9096)48%
(5211/10759)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8340/14343)50%
(4869/9704)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3872/7838)33%
(1634/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Adriaan de Groot]

adridg added a comment.


  Associated bug https://bugs.kde.org/show_bug.cgi?id=389982

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure
Cc: adridg, kossebau, #frameworks, michaelh

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

[David Faure]

dfaure added a comment.


  Yes. Well, you can't add new virtual methods, but these two already exist:
  
virtual void handleInitError(int kioErrorCode, const QString &errorMsg);
virtual void handleError(KJob *job);
  
  I think you should be able to (ab)use the first one for this purpose.
  
  (It's called "init" as opposed to "when running a kjob, later", with the 
assumption that these are the only two cases that can happen but it really 
means "when we don't have a kjob"; should have been called something more 
generic, I see now)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10405

To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh