markg marked 2 inline comments as done.
markg added a comment.
I'm not afraid of the compiler generating wrong code. That is the least of my
What i am afraid of (which is why i suggested the copy test) is a wrong
optimization at some point (like adding a pointer member but forgetting to
properly copy it) which would break the UDSEntry.
But a test for that would probably deserves its own review independent of
Forget it, i have no plans to change the internal data structure of UDSEntry.
I might play with a HAT-trie <https://github.com/Tessil/hat-trie> at some point
but that is unlikely to be on the UDSEntry level. It would be much more
suitable on the KCoreDirLister level.
To: markg, dfaure
Cc: apol, #frameworks, michaelh