KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/19/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 11 Mar 2018 07:00:53 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31628/59648)38%
(18570/48884)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8570/9118)48%
(5229/10797)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)59%
(8415/14352)50%
(4906/9728)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3897/7876)33%
(1644/4942)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/982)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 168 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/168/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 11 Mar 2018 07:00:53 +
 Build duration:
10 min and counting
   CONSOLE OUTPUT
  [...truncated 640.66 KB...]  ^~In file included from /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/build/src/widgets/kio/paste.h:1:0, from /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/autotests/jobguitest.cpp:23:/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/src/widgets/paste.h:46:35: note: declared here KIOWIDGETS_DEPRECATED_EXPORT Job *pasteClipboard(const QUrl &destURL, QWidget *widget, bool move = false);   ^~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/autotests/jobguitest.cpp:76:112: warning: ‘KIO::Job* KIO::pasteClipboard(const QUrl&, QWidget*, bool)’ is deprecated [-Wdeprecated-declarations] KIO::Job *job = KIO::pasteClipboard(QUrl::fromLocalFile(otherTmpDir()), static_cast(nullptr));^In file included from /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/build/src/widgets/kio/paste.h:1:0, from /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/autotests/jobguitest.cpp:23:/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/src/widgets/paste.h:46:35: note: declared here KIOWIDGETS_DEPRECATED_EXPORT Job *pasteClipboard(const QUrl &destURL, QWidget *widget, bool move = false);   ^~[ 79%] Building CXX object autotests/CMakeFiles/jobguitest.dir/jobguitest_autogen/mocs_compilation.cpp.o[ 79%] Linking CXX executable ../bin/jobguitest[ 79%] Built target jobguitestScanning dependencies of target runapplication_autogen[ 79%] Automatic MOC for target runapplication[ 79%] Built target runapplication_autogenScanning dependencies of target kprotocolinfo_dumper_autogen[ 79%] Automatic MOC for target kprotocolinfo_dumper[ 79%] Built target kprotocolinfo_dumper_autogenScanning dependencies of target kdirmodeltest_gui_autogen[ 79%] Automatic MOC for target kdirmodeltest_gui[ 79%] Built target kdirmodeltest_gui_autogenScanning dependencies of target kdirlistertest_gui_autogen[ 79%] Automatic MOC for target kdirlistertest_gui[ 79%] Built target kdirlistertest_gui_autogenScanning dependencies of target kencodingfiledialogtest_gui_autogen[ 79%] Automatic MOC for target kencodingfiledialogtest_gui[ 79%] Built target kencodingfiledialogtest_gui_autogenScanning dependencies of target kfilewidgettest_gui_autogen[ 79%] Automatic MOC for target kfilewidgettest_gui[ 79%] Built target kfilewidgettest_gui_autogenScanning dependencies of target kopenwithtest_autogen[ 79%] Automatic MOC for target kopenwithtest[ 79%] Built target kopenwithtest_autogenScanning dependencies of target kruntest_autogen[ 79%] Automatic MOC for target kruntest[ 79%] Built target kruntest_autogenScanning dependencies of target kioslavetest_autogen[ 79%] Automatic MOC for target kioslavetest[ 79%] Built target kioslavetest_autogenScanning dependencies of target kfilecustomdialogtest_gui_autogen[ 79%] Automatic MOC for target kfilecustomdialogtest_gui[ 79%] Built target kfilecustomdialogtest_gui_autogenScanning dependencies of target udsentrybenchmark_autogen[ 79%] Automatic MOC for target udsentrybenchmark[ 79%] Built target udsentrybenchmark_autogenScanning dependencies of target kurlrequestertest_gui_autogen[ 79%] Automatic MOC for target kurlrequestertest_gui[ 79%] Built target kurlrequestertest_gui_autogenScanning dependencies of target kurlnavigatortest_gui_autogen[ 79%] Automatic MOC for target kurlnavigatortest_gui[ 79%] Built target kurlnavigatortest_gui_autogenScanning dependencies of target kpropertiesdialogtest_autogen[ 79%] Automatic MOC for target kpropertiesdialogtest[ 79%] Built target kpropertiesdialogtest_autogenScanning dependencies of target getalltest_autogen[ 79%] Automatic MOC for target getalltest[ 79%] Built target getalltest_autogenScanning dependencies of target listrecursivetest_autogen[ 80%] Automatic MOC for target listrecursivetest[ 80%] Built target listrecursivetest_autogenScanning dependencies of target kmountpoint_debug_autogen[ 80%] Automatic MOC for target kmountpoint_debug[ 80%] Built target kmountpoint_debug_autogenScanning dependencies of target ksycocaupdatetest_autogen[ 80%] Automatic MOC for target ksycocaupdatetest[ 80%] Built target ksycocaupdatetest_autogenScanning dependencies of target previewtest_autogen[ 81%] Automatic MOC for target previewtest[ 81%] Built target previewtest_autogenScanning dependencies of target listjobtest_autogen[ 81%] Automatic MOC for target listjobtest[ 81%] Built target listjobtest_autogenScanning dependencies of target kionetrctest_autogen[ 81%] Automatic MOC

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 148 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/148/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 11 Mar 2018 07:00:53 +
 Build duration:
7 min 43 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest

D11107: [KProtocolInfoFactory] Don't clear cache if it had just been built

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:a9625a3be6b1: [KProtocolInfoFactory] Don't clear 
cache if it had just been built (authored by hein).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11107?vs=28916&id=29202

REVISION DETAIL
  https://phabricator.kde.org/D11107

AFFECTED FILES
  src/core/kprotocolinfofactory.cpp
  src/core/kprotocolinfofactory_p.h

To: hein, #frameworks, broulik, dfaure
Cc: michaelh

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 147 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/147/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 11 Mar 2018 04:22:29 +
 Build duration:
52 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 32 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/32/
 Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 11 Mar 2018 04:22:16 +
 Build duration:
49 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kstandarddirstest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 167 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/167/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 11 Mar 2018 04:22:29 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31591/59631)38%
(18549/48886)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8570/9118)48%
(5233/10797)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8388/14352)50%
(4888/9722)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3896/7874)33%
(1643/4942)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(512/982)41%
(413/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)5

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/18/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 11 Mar 2018 04:22:29 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31628/59647)38%
(18564/48882)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8568/9118)48%
(5228/10797)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)59%
(8417/14351)50%
(4901/9726)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3897/7876)33%
(1644/4942)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/982)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%

D10621: Highlighting Indexer: list of suggestions

[Dominik Haumann]

dhaumann added a comment.


  Just for info: 
https://kate-editor.org/2018/03/10/improving-syntax-highlighting-files/ tries 
to reach a broader audience for getting patches.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10621

To: jpoelen, dhaumann
Cc: #framework_syntax_highlighting, dhaumann, #frameworks, michaelh, 
genethomas, cullmann, vkrause

D10621: Highlighting Indexer: list of suggestions

[Dominik Haumann]

dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.


  Btw, current generated list finds 1658 issues: https://paste.kde.org/p7iareuxc
  
  Not all of them are correct, for instance
  
zsh.xml" line 919 RegExpr candidate for  "Detect2Chars" : "%1"
  
  I believe %1 in this case is a backreference in a dynamic context, so a 
change to Detect2Chars would be wrong.
  
  Similarly, the suggestion
  
html-php.xml" line 223 RegExpr candidate for  "AnyChar" : "[^/><\"'\\s]"
  
  is also not correct, since [^xyz] means match everything _except_ xyz, so the 
^ symbol negates this, afaik (or am I remembering incorrectly?)...
  
  Still, there are many valid items which certainly can be optimized. So 
patches for fixes welcome! In small chunks, if possible!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10621

To: jpoelen, dhaumann
Cc: #framework_syntax_highlighting, dhaumann, #frameworks, michaelh, 
genethomas, cullmann, vkrause

D7175: Redesign CMake syntax

[Dominik Haumann]

dhaumann added a comment.


  Oh, and btw. sorry that this review took essentially 7 months. Sometimes we 
simply suck and things go badly wrong :-)

REVISION DETAIL
  https://phabricator.kde.org/D7175

To: turbov, dhaumann, #kate, #framework_syntax_highlighting, vkrause
Cc: cullmann, #frameworks, michaelh

D7175: Redesign CMake syntax

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  So everyone seems to agree that in general it's a good idea.
  
  @turbov Please go ahead and commit. Don't forget to run make test, and 
possibly update the unit test rererence with 
autotests/update-reference-data.sh. Maybe you even want to extend the 
autotest/input/*.cmake files. Please maintain it also for the future :-)

REVISION DETAIL
  https://phabricator.kde.org/D7175

To: turbov, dhaumann, #kate, #framework_syntax_highlighting, vkrause
Cc: cullmann, #frameworks, michaelh

D10621: Highlighting Indexer: list of suggestions

[Dominik Haumann]

dhaumann added a comment.


  As quick comment: I like the idea of programmatically suggesting better usage 
of rules. I did not yet fine the time to look into this, so I do not know how 
much output this currently generates.
  
  In any case, for the highlighting files we ship with the syntax highlighting 
framework, I would like to have zero error/warning output generated by the 
highlighting indexer (just like we have zero compiler warnings). So if this 
generates a lot of suggestions, would you also agree to fix the output? This 
could possibly touch many many files and be a lot of work :-)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10621

To: jpoelen, dhaumann
Cc: #framework_syntax_highlighting, dhaumann, #frameworks, michaelh, 
genethomas, cullmann, vkrause

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 19 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/19/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Sat, 10 Mar 2018 19:41:51 +
 Build duration:
20 min and counting

Re: KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 18 - Still Failing!

[Ben Cooksley]

Hi all,

This is caused by kioslave.exe continuing to hang around post completion of
tests, and also resisting being killed by the CI Tooling once testing is
all finished.
I've therefore disabled the execution of tests for KIO on Windows to
prevent this from continuing to occur.

Cheers,
Ben

D10312: FileUndoManager: don't delete non-existing local files

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  undo-deleted-file (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10312

To: elvisangelaccio, dfaure
Cc: ngraham, #frameworks, michaelh

D11107: [KProtocolInfoFactory] Don't clear cache if it had just been built

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11107

To: hein, #frameworks, broulik, dfaure
Cc: michaelh

D9973: ktooltipwidget: Fix tooltip positioning

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Almost there! Just minor comments.

INLINE COMMENTS

> ktooltipwidgettest.cpp:195
> +QLabel* contentWidget = new QLabel(content);
> +const QSize shrinkSize{2 * m_offset, 2 * m_offset};
> +contentWidget->setMaximumSize(m_screenGeometry.size() - shrinkSize);

Don't use the `{}` constructor syntax only here, it breaks consistency.

> ktooltipwidget.cpp:32
>  #include 
> +#include 
>  

Please remove this include.

> ktooltipwidget.cpp:125
>  const QRect screenGeometry = screen->geometry();
> -
> +const int margin = 
> q->style()->pixelMetric(QStyle::PM_ToolTipLabelFrameWidth);
> +

Is there a reason why you moved this line?

> ktooltipwidget.cpp:131
>  const bool hasRoomBelow   = (rect.bottom() + size.height() + margin <= 
> screenGeometry.bottom());
> +
>  if (!hasRoomAbove && !hasRoomBelow && !hasRoomToLeft && !hasRoomToRight) 
> {

unrelated whitespace change

> ktooltipwidget.cpp:143
>  }
> +
>  if (hasRoomBelow) {

unrelated whitespace change

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D9973

To: michaelh, elvisangelaccio, #frameworks, #dolphin, ngraham
Cc: dfaure, cfeck, michaelh

D11038: balooctl: Add prune option to remove stale file index entries

[James Smith]

smithjd updated this revision to Diff 29184.
smithjd added a comment.


  - Lessen chattiness.
  - balooctl: Clarify the prune option description.
  - Fix document purging.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11038?vs=28987&id=29184

BRANCH
  master-purgeDb (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11038

AFFECTED FILES
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/tools/balooctl/main.cpp

To: smithjd, #baloo, #frameworks, michaelh
Cc: michaelh, ashaposhnikov, spoorun, nicolasfella, alexeymin

D10312: FileUndoManager: don't delete non-existing local files

[Elvis Angelaccio]

elvisangelaccio updated this revision to Diff 29183.
elvisangelaccio added a comment.


  - QLatin1String for concat

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10312?vs=29182&id=29183

BRANCH
  undo-deleted-file (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10312

AFFECTED FILES
  autotests/fileundomanagertest.cpp
  autotests/fileundomanagertest.h
  src/widgets/fileundomanager.cpp

To: elvisangelaccio, dfaure
Cc: ngraham, #frameworks, michaelh

D10312: FileUndoManager: don't delete non-existing local files

[Elvis Angelaccio]

elvisangelaccio updated this revision to Diff 29182.
elvisangelaccio added a comment.


  - Address comments

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10312?vs=27940&id=29182

BRANCH
  undo-deleted-file (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10312

AFFECTED FILES
  autotests/fileundomanagertest.cpp
  autotests/fileundomanagertest.h
  src/widgets/fileundomanager.cpp

To: elvisangelaccio, dfaure
Cc: ngraham, #frameworks, michaelh

D10312: FileUndoManager: don't delete non-existing local files

[Elvis Angelaccio]

elvisangelaccio marked 3 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10312

To: elvisangelaccio, dfaure
Cc: ngraham, #frameworks, michaelh

D11213: balooctl: Introduce list command

[Michael Heidelbach]

michaelh edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11213

To: michaelh, #baloo, #frameworks, smithjd
Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D11213: balooctl: Introduce list command

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> purgelistcommand.cpp:62
> +: QString();
> +const QSharedPointer urlFilter(pattern.isEmpty() ? 
> nullptr : new QRegularExpression{pattern});
> +qDebug() << "main" 

I'm not sure, if this is correct/proper usage.

> purgelistcommand.cpp:68
> +<< "urlFilter" << urlFilter;
> +
> +auto db = globalDatabaseInstance();

Will be removed on next update.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11213

To: michaelh, #baloo, #frameworks, smithjd
Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D11213: balooctl: Introduce list command

[Michael Heidelbach]

michaelh created this revision.
michaelh added reviewers: Baloo, Frameworks, smithjd.
michaelh added projects: Baloo, Frameworks.
michaelh requested review of this revision.

REVISION SUMMARY
  This command list all entries of the database. Information items are
  
  - device id
  - inode
  - url
  - file accessability
  
  The output may be filtered by
  
  - device id
  - Regular expression match of url
  - file accessability

TEST PLAN
  Running on command line.

REPOSITORY
  R293 Baloo

BRANCH
  list (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11213

AFFECTED FILES
  src/engine/documenturldb.cpp
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/tools/balooctl/CMakeLists.txt
  src/tools/balooctl/main.cpp
  src/tools/balooctl/purgelistcommand.cpp
  src/tools/balooctl/purgelistcommand.h

To: michaelh, #baloo, #frameworks, smithjd
Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D10694: epubextractor: Handle multiple subjects better

[Michael Heidelbach]

michaelh added a comment.


  @mgallien: I think we have a beautiful misunderstanding here :-)
  
  In D10694#221719 , @michaelh wrote:
  
  > This is bad! ...
  
  
  I was referring to baloo inablility to  handle string lists and not to this 
diff.
  
  In D10694#221734 , @mgallien wrote:
  
  > I believe this is quite the opposite. ...
  
  
  I took your answer the wrong way completely. Let's rewind our conversation a 
little

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10694

To: michaelh, mgallien, dfaure
Cc: astippich, #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, 
isidorov, nicolasfella, firef, andrebarros, alexeymin, emmanuelp

D11204: Support NTFS hidden files

[Mark Gaiser]

markg requested changes to this revision.
markg added a comment.
This revision now requires changes to proceed.


  -2 in my opinion.
  KFileItem should know nothing about NTFS.
  
  You already have isHidden in there which should handle it.
  If it doesn't then you might have found a bug.
  
  See how m_hidden is filled:
  
const int hiddenVal = m_entry.numberValue(KIO::UDSEntry::UDS_HIDDEN, -1);
m_hidden = hiddenVal == 1 ? Hidden : (hiddenVal == 0 ? Shown : Auto);
  
  If that gives the wrong result then the place that's filling UDS_HIDDEN (in 
the KIO slave that @broulik point you to.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks, markg
Cc: markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, #frameworks, 
#dolphin, michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/17/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 10 Mar 2018 14:44:26 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31612/59647)38%
(18562/48882)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8570/9118)48%
(5231/10797)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)59%
(8404/14351)50%
(4898/9726)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3897/7876)33%
(1644/4942)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/982)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)52%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 166 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/166/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 10 Mar 2018 14:44:26 +
 Build duration:
9 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31562/59629)38%
(18534/48886)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8570/9118)48%
(5232/10797)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8355/14350)50%
(4880/9722)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3896/7874)33%
(1643/4942)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/982)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 146 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/146/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 10 Mar 2018 14:44:26 +
 Build duration:
7 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 18 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/18/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Sat, 10 Mar 2018 14:44:26 +
 Build duration:
59 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] nodeRunning on Windows Builder 1 in C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.10[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] }[Pipeline] // stage[Pipeline] }java.nio.file.FileSystemException: C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.10\build\autotests: The process cannot access the file because it is being used by another process.	at sun.nio.fs.WindowsException.translateToIOException(Unknown Source)	at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source)	at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source)	at sun.nio.fs.WindowsFileSystemProvider.implDelete(Unknown Source)	at sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(Unknown Source)	at java.nio.file.Files.deleteIfExists(Unknown Source)	at hudson.Util.tryOnceDeleteFile(Util.java:299)	at hudson.Util.deleteFile(Util.java:255)Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from ange.kde.org/144.76.172.7:50657		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1737)		at hudson.remoting.UserResponse.retrieve(UserRequest.java:313)		at hudson.remoting.Channel.call(Channel.java:952)		at hudson.FilePath.act(FilePath.java:998)		at hudson.FilePath.act(FilePath.java:987)		at hudson.FilePath.deleteRecursive(FilePath.java:1192)		at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$Execution.run(DeleteDirStep.java:77)		at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$Execution.run(DeleteDirStep.java:69)		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1$1.call(SynchronousNonBlockingStepExecution.java:49)		at hudson.security.ACL.impersonate(ACL.java:290)		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1.run(SynchronousNonBlockingStepExecution.java:46)		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)		at java.util.concurrent.FutureTask.run(FutureTask.java:266)		at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)		at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)		at java.lang.Thread.run(Thread.java:748)Caused: java.io.IOException: Unable to delete 'C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.10\build\autotests'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts.	at hudson.Util.deleteFile(Util.java:260)	at hudson.FilePath.deleteRecursive(FilePath.java:1225)	at hudson.FilePath.deleteContentsRecursive(FilePath.java:1234)	at hudson.FilePath.deleteRecursive(FilePath.java:1216)	at hudson.FilePath.deleteContentsRecursive(FilePath.java:1234)	at hudson.FilePath.deleteRecursive(FilePath.java:1216)	at hudson.FilePath.access$1100(FilePath.java:208)	at hudson.FilePath$13.invoke(FilePath.java:1195)	at hudson.FilePath$13.invoke(FilePath.java:1192)	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2816)	at hudson.remoting.UserRequest.perform(UserRequest.java:210)	at hudson.remoting.UserRequest.perform(UserRequest.java:53)	at hudson.remoting.Request$2.run(Request.java:358)	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)	at java.util.concurrent.FutureTask.run(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)	at hudson.remoting.Engine$1$1.run(Engine.java:94)	at java.lang.Thread.run(Unknown Source)Caused: java.io.IOException: remote file operation failed: C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.10 at hudson.remoting.Channel@3d87f3cf:JNLP4-connect connection from ange.kde.org/144.76.172.7:50657	at hudson.FilePath.act(FilePath.java:1005)	at hudson.FilePath.act(FilePath.java:987)	at hudson.FilePath.deleteRecursive(FilePath.java:1192)	at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$Execution.run(DeleteDirStep.java:77)	at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$Execution.run(DeleteDirStep.java:69)	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1$1.call(SynchronousNonBlockingStepExecution.java:49)	at hudson.security.ACL.impersonate(ACL.java:290)	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1.run(SynchronousNonBlockingStepExecution.java:46)	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)	at java.util.concurrent.FutureTask.run(FutureTask.java:266)	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)	at java.util.concurrent.Thr

D11107: [KProtocolInfoFactory] Don't clear cache if it had just been built

[Eike Hein]

hein added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11107

To: hein, #frameworks, broulik, dfaure
Cc: michaelh

D11153: Use correct item URL for Create New context menu

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:032709c17f00: Use correct item URL for Create New context 
menu (authored by prukgaber, committed by hein).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11153?vs=29006&id=29163

REVISION DETAIL
  https://phabricator.kde.org/D11153

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: prukgaber, #frameworks, dfaure
Cc: hein, #frameworks, michaelh

D11204: Support NTFS hidden files

[Kai Uwe Broulik]

broulik added a comment.


  > Can you point me out to appropriate files?
  
  Sure, I think you want to add your code to 
`kio/src/ioslaves/file/file_unix.cpp` (it already has a Unix-specific file) in 
the `listDir` method:
  
if (ntfshidden) {
entry.insert(KIO::UDSEntry::UDS_HIDDEN, true);
}
  
  (Note that this stuff runs out of process so you might need to kill the 
`file.so` executable rather than just Dolphin when you test it)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks
Cc: elvisangelaccio, ltoscano, anthonyfieroni, broulik, #frameworks, #dolphin, 
michaelh

D7909: Add syntax support for Crystal Programming Language

[Faustino Aguilar]

faguilar added inline comments.

INLINE COMMENTS

> crystal.xml:160
> +
> + 
> +  char1="%" context="Find closing macro brace" beginRegion="def block"/>

@dhaumann Crystal language supports macros. This macro syntax is a bit 
different from ruby

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D7909

To: faguilar, dhaumann, vkrause, #framework_syntax_highlighting, #kate
Cc: ngraham, #kate, #frameworks, faguilar, michaelh, genethomas, kevinapavew, 
demsking, cullmann, vkrause, sars, dhaumann

D11204: Support NTFS hidden files

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In D11204#222427 , @rominf wrote:
  
  > In D11204#222421 , @broulik 
wrote:
  >
  > > Shouldn't that rather go into the `file` KIO slave so it sets the 
`UDS_HIDDEN` attribute?
  >
  >
  > I think you are right, but I don't have an idea what "`file` KIO slave" 
means. Can you point me out to appropriate files?
  
  
  You can find it in `kio/src/ioslaves/file`.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks
Cc: elvisangelaccio, ltoscano, anthonyfieroni, broulik, #frameworks, #dolphin, 
michaelh

D11153: Use correct item URL for Create New context menu

[Pierre Rukgaber]

prukgaber added a comment.


  My email address is tyel...@gmail.com

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11153

To: prukgaber, #frameworks, dfaure
Cc: hein, #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 17 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/17/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Sat, 10 Mar 2018 08:40:37 +
 Build duration:
2 hr 36 min and counting
   JUnit Tests
  Name: (root) Failed: 23 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: TestSuite.kiocore-deletejobtestFailed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kfileitemtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-mkpathjobtestFailed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiofilewidgets-kfilecustomdialogtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiofilewidgets-knewfilemenutestFailed: TestSuite.kiofilewidgets-kurlnavigatortestFailed: TestSuite.kiowidgets-accessmanagertestFailed: TestSuite.kiowidgets-accessmanagertest-qnamFailed: TestSuite.kiowidgets-dropjobtestFailed: TestSuite.kiowidgets-fileundomanagertestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltestFailed: TestSuite.kiowidgets-krununittestFailed: TestSuite.kiowidgets-kurifiltertestFailed: TestSuite.kiowidgets-kurlcompletiontestFailed: TestSuite.kiowidgets-kurlcompletiontest-nowaitFailed: TestSuite.kpasswdservertest

KDE CI: Frameworks threadweaver kf5-qt5 SUSEQt5.9 - Build # 5 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20SUSEQt5.9/5/
 Project:
Frameworks threadweaver kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 10 Mar 2018 08:42:18 +
 Build duration:
1 hr 50 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 8 test(s)Failed: TestSuite.ThreadWeaverJobTests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(2/7)57%
(62/109)57%
(62/109)44%
(1477/3384)16%
(1106/6996)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests58%
(11/19)58%
(11/19)33%
(412/1237)12%
(492/4190)benchmarks0%
(0/1)0%
(0/1)0%
(0/127)0%
(0/72)examples.HelloInternet0%
(0/5)0%
(0/5)0%
(0/118)0%
(0/264)examples.HelloWorld0%
(0/1)0%
(0/1)0%
(0/3)100%
(0/0)examples.HelloWorldRaw0%
(0/1)0%
(0/1)0%
(0/14)100%
(0/0)examples.ThumbNailer0%
(0/23)0%
(0/23)0%
(0/473)0%
(0/958)src86%
(51/59)86%
(51/59)75%
(1065/1412)41%
(614/1512)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/16/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 10 Mar 2018 08:40:37 +
 Build duration:
1 hr 42 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31626/59647)38%
(18561/48882)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8570/9118)48%
(5229/10797)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)59%
(8413/14351)50%
(4897/9726)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3897/7876)33%
(1644/4942)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/982)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/6/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 10 Mar 2018 08:41:36 +
 Build duration:
1 hr 40 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 41 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: TestSuite.kwayland-testPlasmaWindowModel
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)91%
(220/243)91%
(220/243)82%
(22821/27928)50%
(11145/22234)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client97%
(38/39)97%
(38/39)94%
(10521/11181)48%
(7275/15263)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client97%
(67/69)97%
(67/69)81%
(5282/6521)60%
(1607/2676)src.server99%
(110/111)99%
(110/111)86%
(6659/7703)64%
(2043/3170)src.tools0%
(0/2)0%
(0/2)0%
(0/786)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1255)0%
(0/317)

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 4 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/4/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 10 Mar 2018 08:41:24 +
 Build duration:
1 hr 38 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.completion_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(301/337)89%
(301/337)69%
(34084/49359)52%
(17900/34202)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)94%
(4371/4670)49%
(2170/4386)autotests.src.vimode100%
(16/16)100%
(16/16)99%
(5493/5534)58%
(1073/1846)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1778/3121)43%
(1242/2905)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(185/460)22%
(79/360)src.dialogs0%
(0/4)0%
(0/4)0%
(0/831)0%
(0/242)src.document100%
(4/4)100%
(4/4)59%
(1889/3184)49%
(1718/3499)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/296)src.render100%
(9/9)100%
(9/9)76%
(927/1219)66%
(627/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1502)1%
(6/731)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(306/517)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
(6/8)75%
(6/8)30%
 

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 68 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/68/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 10 Mar 2018 08:41:58 +
 Build duration:
1 hr 30 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D11204: Support NTFS hidden files

[Luigi Toscano]

ltoscano added a comment.


  I can't comment on the internal implementation, but: instead of checking for
  
  #ifndef Q_OS_WIN
  
  shouldn't you check for the availability of xattr? Think about other 
platforms too.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks
Cc: ltoscano, anthonyfieroni, broulik, #frameworks, #dolphin, michaelh

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 - Build # 31 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/31/
 Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 10 Mar 2018 08:41:36 +
 Build duration:
1 hr 22 min and counting
   JUnit Tests
  Name: (root) Failed: 12 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 37 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurface

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.9 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.9/4/
 Project:
Frameworks krunner kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 10 Mar 2018 08:41:18 +
 Build duration:
1 hr 19 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.dbusrunnertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)57%
(12/21)57%
(12/21)31%
(448/1445)22%
(190/856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests60%
(3/5)60%
(3/5)49%
(53/109)23%
(13/56)src90%
(9/10)90%
(9/10)34%
(395/1158)26%
(177/694)src.declarative0%
(0/4)0%
(0/4)0%
(0/135)0%
(0/102)tests0%
(0/2)0%
(0/2)0%
(0/43)0%
(0/4)

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 6 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/6/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 10 Mar 2018 08:41:02 +
 Build duration:
1 hr 19 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 12 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(27/28)96%
(27/28)73%
(1619/2214)51%
(1276/2499)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)100%
(546/548)51%
(329/642)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(560/757)64%
(659/1037)src.kpackage.private100%
(8/8)100%
(8/8)79%
(294/370)52%
(128/246)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/521)27%
(153/562)

D11204: Support NTFS hidden files

[Roman Inflianskas]

rominf added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kfileitem.cpp:1116-1136
> Indeed this should be done in different way, about me
> 
>   std::uint64_t attr;
>   length = getxattr(fileName, attrName, &attr, sizeof attr);
>   if (length <= 0) {
>   return false;
>   }

I wish your code to work, but it doesn't. I took an inspiration from `attr`: 
http://git.savannah.nongnu.org/cgit/attr.git/tree/tools/getfattr.c#n235 and 
http://git.savannah.nongnu.org/cgit/attr.git/tree/tools/getfattr.c#n169.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks
Cc: anthonyfieroni, broulik, #frameworks, #dolphin, michaelh

D11204: Support NTFS hidden files

[Roman Inflianskas]

rominf updated this revision to Diff 29141.
rominf marked an inline comment as done.
rominf added a comment.


  Use delete[] for array deletion

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11204?vs=29137&id=29141

BRANCH
  ntfs-hidden

REVISION DETAIL
  https://phabricator.kde.org/D11204

AFFECTED FILES
  src/core/kfileitem.cpp
  src/core/kfileitem.h

To: rominf, #dolphin, #frameworks
Cc: anthonyfieroni, broulik, #frameworks, #dolphin, michaelh

KDE CI: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.9 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.9/10/
 Project:
Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 10 Mar 2018 08:41:27 +
 Build duration:
1 hr 8 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.ktextwidgets-krichtextedittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/6/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 10 Mar 2018 08:39:42 +
 Build duration:
1 hr 8 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.9 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.9/14/
 Project:
Frameworks kservice kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 10 Mar 2018 08:41:19 +
 Build duration:
1 hr 4 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.ksycocatest

D11204: Support NTFS hidden files

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kfileitem.cpp:1116-1136
> +constexpr size_t xattr_size = 1024;
> +char strAttr[xattr_size];
> +length = getxattr(fileName, attrName, strAttr, xattr_size);
> +if (length <= 0) {
> +return false;
> +}
> +

Indeed this should be done in different way, about me

  std::uint64_t attr;
  length = getxattr(fileName, attrName, &attr, sizeof attr);
  if (length <= 0) {
  return false;
  }

> kfileitem.cpp:1136
> +auto intAttr = static_cast(strtol(hexAttr, nullptr, 16));
> +delete hexAttr;
> +

It should be

  delete[] hexAttr;

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks
Cc: anthonyfieroni, broulik, #frameworks, #dolphin, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 93 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/93/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 10 Mar 2018 08:41:58 +
 Build duration:
1 hr 2 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3558/13343)19%
(1978/10565)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(607/1138)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2235)7%
(102/1492)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(317/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)28%
(553/2009)17%
(306/1771)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 145 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/145/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 10 Mar 2018 08:40:37 +
 Build duration:
1 hr 2 min and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.10 - Build # 6 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20WindowsMSVCQt5.10/6/
 Project:
Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Sat, 10 Mar 2018 08:40:17 +
 Build duration:
1 hr 3 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.9 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.9/13/
 Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 10 Mar 2018 08:41:18 +
 Build duration:
1 hr 1 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.dbusrunnertestFailed: TestSuite.runnercontexttest

D11204: Support NTFS hidden files

[Roman Inflianskas]

rominf added a comment.


  In D11204#222421 , @broulik wrote:
  
  > Shouldn't that rather go into the `file` KIO slave so it sets the 
`UDS_HIDDEN` attribute?
  
  
  I think you are right, but I don't have an idea what "`file` KIO slave" 
means. Can you point me out to appropriate files?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks
Cc: broulik, #frameworks, #dolphin, michaelh

KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.9 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.9/10/
 Project:
Frameworks kpty kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 10 Mar 2018 08:41:12 +
 Build duration:
59 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.kptyprocesstest

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/23/
 Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 10 Mar 2018 08:41:01 +
 Build duration:
56 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.plasma-packagestructuretestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 165 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/165/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 10 Mar 2018 08:40:37 +
 Build duration:
52 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31561/59629)38%
(18542/48886)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8568/9118)48%
(5232/10797)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8359/14350)50%
(4881/9722)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3897/7874)33%
(1644/4942)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(512/982)41%
(413/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%
(8/12)5

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 35 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/35/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 10 Mar 2018 08:41:36 +
 Build duration:
49 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 41 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: TestSuite.kwayland-testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)91%
(222/243)91%
(222/243)85%
(23736/27957)52%
(11634/22234)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(39/39)100%
(39/39)99%
(11058/11184)50%
(7609/15263)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client99%
(68/69)99%
(68/69)85%
(5590/6544)66%
(1760/2676)src.server99%
(110/111)99%
(110/111)87%
(6729/7717)65%
(2045/3170)src.tools0%
(0/2)0%
(0/2)0%
(0/779)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1251)0%
(0/317)

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 29 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/29/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 10 Mar 2018 08:42:02 +
 Build duration:
47 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report25%
(5/20)30%
(17/56)30%
(17/56)21%
(437/2101)21%
(258/1246)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)93%
(144/155)59%
(111/188)src100%
(8/8)100%
(8/8)68%
(205/302)47%
(111/235)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/141)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/121)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
(0/0)src.widgets100%
(2/2)100%
(2/2)96%
(48/50)60%
 

D11204: Support NTFS hidden files

[Kai Uwe Broulik]

broulik added a comment.


  Shouldn't that rather go into the `file` KIO slave so it sets the 
`UDS_HIDDEN` attribute?

INLINE COMMENTS

> kfileitem.h:282
> + */
> +bool isHiddenNtfs() const;
> +#endif

If we were to go this route (adding it to `KFileItem` which I think we 
shouldn't), this should be in `KFileItemPrivate` and not a public method, let 
alone one whose availability depends on the platform

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks
Cc: broulik, #frameworks, #dolphin, michaelh

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 - Build # 17 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/17/
 Project:
Frameworks kwindowsystem kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 10 Mar 2018 08:41:42 +
 Build duration:
41 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kmanagerselectiontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(47/59)80%
(47/59)75%
(7192/9558)54%
(4085/7516)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests89%
(16/18)89%
(16/18)97%
(3074/3161)52%
(1745/3371)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src94%
(15/16)94%
(15/16)57%
(794/1395)46%
(342/747)src.platforms.wayland0%
(0/3)0%
(0/3)0%
(0/71)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3317/4642)60%
(1995/3342)tests0%
(0/5)0%
(0/5)0%
(0/279)0%
(0/50)

D11181: Resolve symlinks in QML import paths

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:919b6be0004d: Resolve symlinks in QML import paths 
(authored by vkrause).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11181?vs=29091&id=29139

REVISION DETAIL
  https://phabricator.kde.org/D11181

AFFECTED FILES
  toolchain/Android.cmake

To: vkrause, #build_system, apol
Cc: #frameworks, michaelh

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 31 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/31/
 Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 10 Mar 2018 08:39:57 +
 Build duration:
38 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kstandarddirstest

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/19/
 Project:
Frameworks kservice kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 10 Mar 2018 08:41:19 +
 Build duration:
35 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kplugininfotestFailed: TestSuite.kservicetestFailed: TestSuite.ksycocathreadtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)83%
(73/88)83%
(73/88)68%
(5506/8117)48%
(3176/6680)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)84%
(1307/1560)45%
(907/2007)src.kbuildsycoca100%
(1/1)100%
(1/1)92%
(54/59)68%
(15/22)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/334)0%
(0/278)src.plugin67%
(2/3)67%
(2/3)49%
(47/96)42%
(44/106)src.services97%
(29/30)97%
(29/30)61%
(1849/3036)41%
(814/1982)src.sycoca83%
(25/30)83%
(25/30)77%
(2141/2794)62%
(1363/2197)tests0%
(0/5)0%
(0/5)0%
(0/118)0%
(0/40)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(108/120)69%
(33/48)

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/21/
 Project:
Frameworks krunner kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 10 Mar 2018 08:41:18 +
 Build duration:
33 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.dbusrunnertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)57%
(12/21)57%
(12/21)29%
(411/1441)21%
(182/856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests60%
(3/5)60%
(3/5)49%
(53/109)23%
(13/56)src90%
(9/10)90%
(9/10)31%
(358/1156)24%
(169/694)src.declarative0%
(0/4)0%
(0/4)0%
(0/135)0%
(0/102)tests0%
(0/2)0%
(0/2)0%
(0/41)0%
(0/4)

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 29 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/29/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 10 Mar 2018 08:41:02 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(27/28)96%
(27/28)73%
(1619/2214)51%
(1276/2499)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)100%
(546/548)51%
(329/642)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(560/757)64%
(659/1037)src.kpackage.private100%
(8/8)100%
(8/8)79%
(294/370)52%
(128/246)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/521)27%
(153/562)

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 45 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/45/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 10 Mar 2018 08:39:42 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittest

KDE CI: Frameworks kbookmarks kf5-qt5 WindowsMSVCQt5.10 - Build # 5 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kbookmarks%20kf5-qt5%20WindowsMSVCQt5.10/5/
 Project:
Frameworks kbookmarks kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Sat, 10 Mar 2018 08:39:27 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 62 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/62/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 10 Mar 2018 08:39:42 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 43 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/43/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 10 Mar 2018 08:39:03 +
 Build duration:
6 min 36 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

D11153: Use correct item URL for Create New context menu

[David Faure]

dfaure added a comment.


  For the git author information, I need your email address. This doesn't seem 
to appear anywhere in phabricator.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11153

To: prukgaber, #frameworks, dfaure
Cc: hein, #frameworks, michaelh

D11204: Support NTFS hidden files

[Roman Inflianskas]

rominf edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks
Cc: #frameworks, #dolphin, michaelh

D11204: Support NTFS hidden files

[Roman Inflianskas]

rominf edited the summary of this revision.
rominf added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks
Cc: #frameworks, #dolphin, michaelh

D11204: Support NTFS hidden files

[Roman Inflianskas]

rominf created this revision.
rominf added a reviewer: Dolphin.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
rominf requested review of this revision.

REVISION SUMMARY
  This patch implements function isHiddenNtfs which checks extended attribute 
HIDDEN of files from NTFS partitions and complements isHidden function.
  FEATURE: 171537

TEST PLAN
  1. Open Dolphin on Windows partition
  2. Check that "$Recycle.Bin", "MSOCache", "System Volume Information", etc. 
are hidden
  3. Show hidden files
  4. Check that Windows hidden files are displayed now

REPOSITORY
  R241 KIO

BRANCH
  ntfs-hidden

REVISION DETAIL
  https://phabricator.kde.org/D11204

AFFECTED FILES
  src/core/kfileitem.cpp
  src/core/kfileitem.h

To: rominf, #dolphin
Cc: #frameworks, #dolphin, michaelh