D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

[Nathaniel Graham]

ngraham marked an inline comment as done.
ngraham added a comment.


  ...Gotta make sure that cancel slot actually works, so this is now dependent 
on my patch that fixes it: D12227 

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D12240

To: ngraham, #frameworks
Cc: anthonyfieroni, elvisangelaccio, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

[Nathaniel Graham]

ngraham removed a dependency: D12239: Create a public writeViewConfig() 
function so the open/save dialog itself can call it.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D12240

To: ngraham, #frameworks
Cc: anthonyfieroni, elvisangelaccio, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12239: Create a public writeViewConfig() function so the open/save dialog itself can call it

[Nathaniel Graham]

ngraham removed a dependent revision: D12240: Save the dialog view settings 
when closing the dialog without hitting the cancel button.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12239

To: ngraham, #frameworks
Cc: anthonyfieroni, michaelh, ngraham, bruns

D12239: Create a public writeViewConfig() function so the open/save dialog itself can call it

[Nathaniel Graham]

ngraham added a subscriber: anthonyfieroni.
ngraham added a comment.


  Don't need this anymore, since @anthonyfieroni showed me a much better way to 
accomplish D12240 !

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12239

To: ngraham, #frameworks
Cc: anthonyfieroni, michaelh, ngraham, bruns

D12239: Create a public writeViewConfig() function so the open/save dialog itself can call it

[Nathaniel Graham]

ngraham abandoned this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12239

To: ngraham, #frameworks
Cc: anthonyfieroni, michaelh, ngraham, bruns

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham added a dependency: D12227: Save the dialog view settings even when 
canceling.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D12240

To: ngraham, #frameworks
Cc: anthonyfieroni, elvisangelaccio, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12227: Save the dialog view settings even when canceling

[Nathaniel Graham]

ngraham added a dependent revision: D12240: Save the dialog view settings when 
closing the dialog without hitting the cancel button.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12227

To: ngraham, #frameworks
Cc: michaelh, ngraham, bruns

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

[Nathaniel Graham]

ngraham updated this revision to Diff 32361.
ngraham added a comment.


  Use a vastly cleaner and cleverer approach (thanks @anthonyfieroni)

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12240?vs=32338=32361

BRANCH
  save-view-config-on-close-and-escape (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12240

AFFECTED FILES
  src/platformtheme/kdeplatformfiledialoghelper.cpp

To: ngraham, #frameworks
Cc: anthonyfieroni, elvisangelaccio, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kdeplatformfiledialoghelper.cpp:108
>  m_buttons->addButton(m_fileWidget->cancelButton(), 
> QDialogButtonBox::RejectRole);
>  connect(m_buttons, SIGNAL(rejected()), m_fileWidget, SLOT(slotCancel()));
>  connect(m_fileWidget->okButton(), SIGNAL(clicked(bool)), m_fileWidget, 
> SLOT(slotOk()));

Even better to me should be

  connect(this, ::rejected, m_fileWidget, 
::slotCancel);

PS: You can make a different review to change old syntax (SIGNAL/SLOT) to new 
function pointers.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D12240

To: ngraham, #frameworks
Cc: anthonyfieroni, elvisangelaccio, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kdeplatformfiledialoghelper.cpp:243
> +{
> +m_fileWidget->writeViewConfig();
> +QDialog::reject();

You can see at line 108 on reject is called slotCancel, so for convenience just 
call it

  m_fileWidget->slotCancel();

Then you can discard D12239 

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D12240

To: ngraham, #frameworks
Cc: anthonyfieroni, elvisangelaccio, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12239: Create a public writeViewConfig() function so the open/save dialog itself can call it

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12239

To: ngraham, #frameworks
Cc: michaelh, ngraham, bruns

D12227: Save the dialog view settings even when canceling

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12227

To: ngraham, #frameworks
Cc: michaelh, ngraham, bruns

D12227: Save the dialog view settings even when canceling

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12227

To: ngraham, #frameworks
Cc: michaelh, ngraham, bruns

D12270: Create a public function to access the actionMenu

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  Create a public function to access the actionMenu, so clients and subclasses 
can manipulate it as they see fit.
  
  BUG: 83679
  FIXED-IN: 5.46

REPOSITORY
  R241 KIO

BRANCH
  public-actionmenu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12270

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h

To: ngraham, #frameworks
Cc: michaelh, ngraham, bruns

D12269: Don't install plugins within lib on android

[Aleix Pol Gonzalez]

apol created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
apol requested review of this revision.

REVISION SUMMARY
  Otherwise we hit a weird code path on androiddeployqt. This is what the 
official SDK looks like anyway:
  
$ ls /opt/Qt/5.10.1/android_armv7/
bin  doc  include  jar  lib  mkspecs  plugins  qml  src  translations

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12269

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: apol
Cc: #frameworks, #build_system, michaelh, ngraham, bruns

D12218: Remove Reload button from the file dialogs' toolbar

[Henrik Fehlauer]

rkflx added a comment.


  Can we find a compromise? For example, the Places panel already seems to know 
when something is on a remote location. Could we show Refresh only for remote 
folders? The toolbar reorganizing itself would also make users aware of the 
need to manually refresh in some cases.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12218

To: ngraham, #frameworks
Cc: markg, broulik, rkflx, #dolphin, michaelh, ngraham, bruns

D12222: baloodb: Use complete access filtering for all outputs

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> databasesanitizer.cpp:179
> +tail = std::remove_if(infos.begin(), tail,
> +  [deviceId,] (const FileInfo& info) {
> +  summary.accessible += info.accessible;

missing space

> databasesanitizer.cpp:180
> +  [deviceId,] (const FileInfo& info) {
> +  summary.accessible += info.accessible;
> +  return info.id == deviceId;

bool is automatically cast to int, false -> 0, true -> 1.
Although probably better to do it explicitly:
`summary.accessible += info.accessible ? 1 : 0;`

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D1

To: michaelh, #baloo, #frameworks
Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

[Nathaniel Graham]

ngraham updated this revision to Diff 32338.
ngraham added a comment.


  Fix typo

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12240?vs=32236=32338

BRANCH
  save-view-config-on-close-and-escape (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12240

AFFECTED FILES
  src/platformtheme/kdeplatformfiledialoghelper.cpp
  src/platformtheme/kdeplatformfiledialoghelper.h

To: ngraham, #frameworks
Cc: elvisangelaccio, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

[Nathaniel Graham]

ngraham marked an inline comment as done.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D12240

To: ngraham, #frameworks
Cc: elvisangelaccio, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> kdeplatformfiledialoghelper.cpp:240
> +// Save the view settings before closing the dialog when the Escape key
> +// is presed or the close button in the titlebar is clicked
> +void KDEPlatformFileDialog::reject()

typo: pressed

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D12240

To: ngraham, #frameworks
Cc: elvisangelaccio, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12233: Avoid manipulation of lists with quadratic complexity

[Michael Heidelbach]

michaelh marked 2 inline comments as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12233

To: michaelh, #baloo
Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12233: Avoid manipulation of lists with quadratic complexity

[Michael Heidelbach]

michaelh marked 4 inline comments as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12233

To: michaelh, #baloo
Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12233: Avoid manipulation of lists with quadratic complexity

[Michael Heidelbach]

michaelh updated this revision to Diff 32322.
michaelh added a comment.


  - Apply suggested change

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12233?vs=32285=32322

BRANCH
  remove-if (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12233

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/pendingfilequeue.cpp

To: michaelh, #baloo
Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12222: baloodb: Use complete access filtering for all outputs

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> databasesanitizer.cpp:180
> +  [deviceId,] (const FileInfo& info) {
> +  summary.accessible += info.accessible;
> +  return info.id == deviceId;

How can this work? `quint64 + bool`

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D1

To: michaelh, #baloo, #frameworks
Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12222: baloodb: Use complete access filtering for all outputs

[Michael Heidelbach]

michaelh updated this revision to Diff 32321.
michaelh added a comment.


  - Use remove_if

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1?vs=32176=32321

BRANCH
  sanitize-dry (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D1

AFFECTED FILES
  src/engine/experimental/databasesanitizer.cpp
  src/tools/experimental/baloodb/main.cpp

To: michaelh, #baloo, #frameworks
Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12222: baloodb: Use complete access filtering for all outputs

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> bruns wrote in databasesanitizer.cpp:252
> If ignoredDevices is a Set/List, you can do a filter pass over the fileList 
> first.
> 
>   auto& fileList = listResult.first;
>   auto tail = fileList.end();
>   for (auto deviceId : ignoredDevices) {
>   tail = std::remove_if(fileList.begin(), tail,
> [deviceId] (const FileInfo& info) {
> return info.id == deviceId;
> });
>   }
>   summary.ignored += fileList.end() - tail;
>   std::erase(tail, fileList.end());

Cool!

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D1

To: michaelh, #baloo, #frameworks
Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D11753: baloodb: Add clean command

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> bruns wrote in databasesanitizer.cpp:173
> Pass in a List/Set of deviceIds, and return the same type.

Your suggestion in D1  can be reused. 
I'll do it there.

> bruns wrote in databasesanitizer.cpp:187
> Are you planning to use this one anywhere else?
> 
> Otherwise, inside `deviceFilters(...)`:
> 
>   auto isIgnored = [](const QStorageInfo& storageInfo) {
>   if (storageInfo.isValid() && ...) {
>   ...
>   }
>   }

> Are you planning to use this one anywhere else?

Yes. For all output: D1 

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11753

To: michaelh, #baloo, #frameworks, bruns
Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D11753: baloodb: Add clean command

[Michael Heidelbach]

michaelh updated this revision to Diff 32320.
michaelh marked 17 inline comments as done.
michaelh added a comment.


  - Apply suggested changes

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11753?vs=32255=32320

BRANCH
  sanitize-clean (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11753

AFFECTED FILES
  src/engine/documenturldb.h
  src/engine/experimental/databasesanitizer.cpp
  src/engine/experimental/databasesanitizer.h
  src/tools/experimental/baloodb/main.cpp

To: michaelh, #baloo, #frameworks, bruns
Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12218: Remove Reload button from the file dialogs' toolbar

[Mark Gaiser]

markg added a comment.


  In D12218#247481 , @ngraham wrote:
  
  > In D12218#247400 , @markg wrote:
  >
  > > As i said, it's all relative. I barely use any of the buttons but the one 
i do use is refresh.
  > >  I only need it when i'm impatient (for instance when wanting to click on 
a file that is still being copied)
  >
  >
  > Not really a valid use case; KDirWatcher should update the view for you 
automatically, and there's no practical benefit to mashing the reload button. 
The button isn't there to facilitate OCD. :) To do that, just hit [F5]. :)
  
  
  Not valid? I'd remove all those buttons on the left side except for refresh :)
  
  > 
  > 
  >> or when i'm browsing a slow network drive.
  > 
  > The Reload functionality is still available via the [F5] as well as the 
context menu. Are those not enough for this use case? And how common is this, 
really? I'm not sure that "file manipulation from the open/save dialog on a 
slow network drive" is a common enough use case to justify taking up space in 
an extremely constrained UI to show a button for reloading the view, especially 
once that functionality is available via another GUI method too (it's always 
available via [F5].
  > 
  > Ultimately the pressure here will be reduced by making the toolbar 
editable, so people who really want a visible Reload button can have one. But 
until then, we need to ask ourselves whether the //general user// benefits from 
having this button always visible, more than he or she might benefit from 
having something or more general usefulness visible in the toolbar (e.g. a 
dropdown menu button that exposes sorting options).
  
  I find refresh (much) more important then the preview toggle (that should 
imho be under the settings thingy, not as it's own button).
  Removing refresh is a mistake in my opinion.
  Note that F5  is for some users FN + F5 
 in case the user prefers to use the "FN" 
functions (in my case that is true on one keyboard where the volume keys are 
hidden under F8, F9 and F10). That's not an argument to either keep or remove 
it, but just to show that refresh doesn't always have to be a one-key thing. 
But i consider that to be a "it's your own fault" case as the user then 
knowingly chose this.
  
  But perhaps we need more opinions.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12218

To: ngraham, #frameworks
Cc: markg, broulik, rkflx, #dolphin, michaelh, ngraham, bruns

D12218: Remove Reload button from the file dialogs' toolbar

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12218

To: ngraham, #frameworks
Cc: markg, broulik, rkflx, #dolphin, michaelh, ngraham, bruns

D12251: Integrate with androiddeployqt dependencies files

[Aleix Pol Gonzalez]

apol added a comment.


  Related and reason of albert's comment: https://phabricator.kde.org/D12250

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D12251

To: apol, #frameworks, vkrause, aacid
Cc: michaelh, ngraham, bruns

D12251: Integrate with androiddeployqt dependencies files

[Aleix Pol Gonzalez]

apol updated this revision to Diff 32313.
apol added a comment.


  Document installation process

REPOSITORY
  R306 KParts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12251?vs=32301=32313

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12251

AFFECTED FILES
  src/CMakeLists.txt
  src/part.h

To: apol, #frameworks, vkrause, aacid
Cc: michaelh, ngraham, bruns

D11874: change 24px view-media-artist icon

[Alexander Stippich]

astippich added a reviewer: andreask.
astippich added a comment.


  ping

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D11874

To: astippich, #vdg, andreask
Cc: #frameworks, michaelh, ngraham, bruns

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/17/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 16 Apr 2018 17:07:48 +
 Build duration:
6 min 33 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 56 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/56/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 16 Apr 2018 17:07:48 +
 Build duration:
3 min 39 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 73 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/73/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 16 Apr 2018 17:07:48 +
 Build duration:
3 min 8 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest

D12233: Avoid manipulation of lists with quadratic complexity

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> michaelh wrote in fileindexscheduler.cpp:148
> I suppose developers on my level will appreciate code to be most 
> self-explanatory. I'm not objecting though, we might al well go "all the way":
> 
>   list.erase(std::remove_if(list.begin(), list.end(), [](const QString& 
> file) {
>   return file.startsWith(dir);
>   }), list.end());

Following Qt coding style, the `[] () {` should go on a separate line, as 
written above

I think having list.erase as a separate statement makes reading simpler.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12233

To: michaelh, #baloo
Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12242: KJob public signals

[Jaime Torres Amate]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:c0b312a41f7f: KJob public signals (authored by jtamate).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12242?vs=32267=32307

REVISION DETAIL
  https://phabricator.kde.org/D12242

AFFECTED FILES
  src/lib/jobs/kjob.h

To: jtamate, dfaure, #frameworks
Cc: michaelh, ngraham, bruns

D12222: baloodb: Use complete access filtering for all outputs

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> databasesanitizer.cpp:252
> +auto& summary = listResult.second;
>  for (const auto& info: listResult.first) {
> +if (ignoredDevices[info.id] == false) {

If ignoredDevices is a Set/List, you can do a filter pass over the fileList 
first.

  auto& fileList = listResult.first;
  auto tail = fileList.end();
  for (auto deviceId : ignoredDevices) {
  tail = std::remove_if(fileList.begin(), tail,
[deviceId] (const FileInfo& info) {
return info.id == deviceId;
});
  }
  summary.ignored += fileList.end() - tail;
  std::erase(tail, fileList.end());

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D1

To: michaelh, #baloo, #frameworks
Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12235: Add XDG Output Protocol

[Roman Gilg]

romangg added a task: T8501: Fractional Scaling.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12235

To: davidedmundson, romangg
Cc: #frameworks, michaelh, ngraham, bruns

D12218: Remove Reload button from the file dialogs' toolbar

[Nathaniel Graham]

ngraham added a comment.


  In D12218#247400 , @markg wrote:
  
  > As i said, it's all relative. I barely use any of the buttons but the one i 
do use is refresh.
  >  I only need it when i'm impatient (for instance when wanting to click on a 
file that is still being copied)
  
  
  Not really a valid use case; KDirWatcher should update the view for you 
automatically, and there's no practical benefit to mashing the reload button. 
The button isn't there to facilitate OCD. :) To do that, just hit [F5]. :)
  
  > or when i'm browsing a slow network drive.
  
  The Reload functionality is still available via the [F5] as well as the 
context menu. Are those not enough for this use case? And how common is this, 
really? I'm not sure that "file manipulation from the open/save dialog on a 
slow network drive" is a common enough use case to justify taking up space in 
an extremely constrained UI to show a button for reloading the view, especially 
once that functionality is available via another GUI method too (it's always 
available via [F5].
  
  Ultimately the pressure here will be reduced by making the toolbar editable, 
so people who really want a visible Reload button can have one. But until then, 
we need to ask ourselves whether the //general user// benefits from having this 
button always visible, more than he or she might benefit from having something 
or more general usefulness visible in the toolbar (e.g. a dropdown menu button 
that exposes sorting options).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12218

To: ngraham, #frameworks
Cc: markg, broulik, rkflx, #dolphin, michaelh, ngraham, bruns

D12251: Integrate with androiddeployqt dependencies files

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R306 KParts

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12251

To: apol, #frameworks, vkrause, aacid
Cc: michaelh, ngraham, bruns

D12251: Integrate with androiddeployqt dependencies files

[Albert Astals Cid]

aacid requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D12251

To: apol, #frameworks, vkrause, aacid
Cc: michaelh, ngraham, bruns

D12251: Integrate with androiddeployqt dependencies files

[Albert Astals Cid]

aacid added a comment.


  I'm not convinced at all parts are not in that folder.

REPOSITORY
  R306 KParts

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12251

To: apol, #frameworks, vkrause, aacid
Cc: michaelh, ngraham, bruns

D11753: baloodb: Add clean command

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> databasesanitizer.cpp:173
> +
> +QMap deviceFilters(QVector& infos, const 
> DatabaseSanitizer::ItemAccessFilters accessFilter)
> +{

Pass in a List/Set of deviceIds, and return the same type.

> michaelh wrote in databasesanitizer.cpp:343
> I'd like to keep it this way.
> 
> 1. For consistency with `printList` and `printDevices`
> 2. I'm thinking in the opposite direction: Make `sep` global to easily change 
> it to another value for all output or even add a `field-separator` 
> getter/setter ('--separator') should the need arise. (in a separate patch, of 
> course)

My preference is:

- Use **one** fixed format string for human readable output, which is 
translatable
- When the need arises to e.g. have something machine readable, use a different 
format string.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11753

To: michaelh, #baloo, #frameworks, bruns
Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12251: Integrate with androiddeployqt dependencies files

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Frameworks, vkrause, aacid.
Restricted Application added a project: Frameworks.
apol requested review of this revision.

REVISION SUMMARY
  Tell androiddeployqt where to look instead of just installing everything

TEST PLAN
  okularpart gets in okular apk when building okular apk

REPOSITORY
  R306 KParts

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12251

AFFECTED FILES
  src/CMakeLists.txt

To: apol, #frameworks, vkrause, aacid
Cc: michaelh, ngraham, bruns

D11753: baloodb: Add clean command

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> databasesanitizer.cpp:187
> +
> +bool isIgnored(const QStorageInfo& storageInfo, const 
> DatabaseSanitizer::ItemAccessFilters accessFilter)
> +{

Are you planning to use this one anywhere else?

Otherwise, inside `deviceFilters(...)`:

  auto isIgnored = [](const QStorageInfo& storageInfo) {
  if (storageInfo.isValid() && ...) {
  ...
  }
  }

> databasesanitizer.cpp:189
> +{
> +if (storageInfo.isValid() && (accessFilter & 
> DatabaseSanitizer::IgnoreMounted)) {
> +return true;

`bool mounted = storageInfo.isValid()`

> databasesanitizer.cpp:191
> +return true;
> +} else if (!storageInfo.isValid() && (accessFilter & 
> DatabaseSanitizer::IgnoreUnmounted)) {
> +return true;

This `else` is ok, although not necessary, it emphasizes symmetry (mounted, not 
mounted)

> databasesanitizer.cpp:193
> +return true;
> +} else if (storageInfo.fileSystemType() == QLatin1String("tmpfs")) {
> +// Due to the volatility of device ids, an id known by baloo may

Remove the `else`, and add a newline here

  ...
  }
  
  if (storageInfo.fileSystemType() == ...) {
  ...
  return true;
  }
  
  return false;

> databasesanitizer.cpp:210
> +void commit() {
> +m_transaction->abort();
> +}

->commit()

> databasesanitizer.cpp:373
> +err << i18nc("numbers", "Removed: %1, Total: %2, Ignored: %3",
> +summary.total - summary.ignored,
> +summary.total,

Nitpick - one more space (align " and __s__ummary)

> michaelh wrote in databasesanitizer.cpp:344
> I'm assuming you meant `DatabaseSanitizerImpl::removeDocument(info.id)`. If 
> you meant `DatabaseSanitizer::removeDocument`, please explain what the 
> advantage is.

Right.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11753

To: michaelh, #baloo, #frameworks, bruns
Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D11732: Improve protocols documentation

[Roman Gilg]

romangg added a comment.


  ping

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11732

To: romangg, #frameworks
Cc: davidedmundson, michaelh, ngraham, bruns

D12218: Remove Reload button from the file dialogs' toolbar

[Mark Gaiser]

markg added a comment.


  >> Refresh on the other hand is something i use relatively often, more then 
any of the other buttons.
  > 
  > Curious to know: What do you need Refresh for? Maybe there's need for some 
changes so you won't have to hit that button manually so often?
  
  As i said, it's all relative. I barely use any of the buttons but the one i 
do use is refresh.
  I only need it when i'm impatient (for instance when wanting to click on a 
file that is still being copied) or when i'm browsing a slow network drive.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12218

To: ngraham, #frameworks
Cc: markg, broulik, rkflx, #dolphin, michaelh, ngraham, bruns

D12247: Use "Do x" action texts for drop menu entries

[Nathaniel Graham]

ngraham added a comment.


  In D12247#247328 , @kossebau wrote:
  
  > Alternativly one could change those menu section titles (which sadly are 
hard to recognize as such with Breeze theme)
  
  
  Agreed, this definitely needs improvement.
  
  In D12247#247328 , @kossebau wrote:
  
  > to be "Add Widgets" and "Set Wallpaper", and then list the widgets and 
wallpapers by their name as before, as kind of inlined submenus.
  >  Though that approach might conflict with some other potential entries in 
that menu, with ""Plasma Package" for the section and "Install" as menu entry. 
Possibly might need a complete overhaul then.
  
  
  I prefer your original approach of simply adding verbs.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12247

To: kossebau, #vdg, #plasma
Cc: ngraham, #frameworks, michaelh, bruns

D10702: Always use a job to delete files to avoid freezing process waiting on IO

[Jaime Torres Amate]

jtamate added a comment.


  > The current state is that it freezes as long as the file deletion (unlink) 
lasts.
  
  Ok, let's go for it.
  
  Another use case when this could be useful is when the filesystem is slow, 
one possible way to know if this is the case is using something like
  
bool KFileItemPrivate::isSlow() const

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10702

To: meven, #frameworks, dfaure, ngraham, #dolphin, jtamate
Cc: jtamate, markg, ngraham, #frameworks, michaelh, bruns

D12244: new resize policy

[Marco Martin]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:ed25dc538941: new resize policy (authored by mart).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12244?vs=32291=32292

REVISION DETAIL
  https://phabricator.kde.org/D12244

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml
  src/qmlcontrols/kcmcontrols/qml/GridView.qml
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml

To: mart, #vdg, #plasma
Cc: broulik, #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

[Marco Martin]

mart updated this revision to Diff 32291.
mart added a comment.


  - ensure items never overlap

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12244?vs=32287=32291

BRANCH
  phab/newResizing

REVISION DETAIL
  https://phabricator.kde.org/D12244

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml
  src/qmlcontrols/kcmcontrols/qml/GridView.qml
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml

To: mart, #vdg, #plasma
Cc: broulik, #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

[Kai Uwe Broulik]

broulik added a comment.


  Fine in principle but it doesn't enforce any minimum spacing
  F5809738: Screenshot_20180416_164705.png 


REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D12244

To: mart, #vdg, #plasma
Cc: broulik, #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

[Marco Martin]

mart updated this revision to Diff 32287.
mart added a comment.


  - better centering

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12244?vs=32280=32287

BRANCH
  phab/newResizing

REVISION DETAIL
  https://phabricator.kde.org/D12244

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml
  src/qmlcontrols/kcmcontrols/qml/GridView.qml
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml

To: mart, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12218: Remove Reload button from the file dialogs' toolbar

[Mark Gaiser]

markg added a comment.


  I personally find the reload button much more useful to have there.
  
  ... (looking at the buttons) ...
  
  Why not removing back, forward and up? This is not an ironic or sarcastic 
suggestion! Just be frank, how often do you use back?
  How often do you use forward (close to never i assume).
  And up? Well, it's twice in there already. You have the breadcrumb bar which 
allows you to go up.
  
  Refresh on the other hand is something i use relatively often, more then any 
of the other buttons. But it depends on my hand position. If i'm already moving 
the mouse i'm inclined to hit the refresh button, if i'm already on the 
keyboard then i'm inclined to just press F5 .

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12218

To: ngraham, #frameworks
Cc: markg, broulik, rkflx, #dolphin, michaelh, ngraham, bruns

D12244: new resize policy

[Marco Martin]

mart added a dependent revision: D12090: port the look and feel kcm to new 
design.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D12244

To: mart, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

[Marco Martin]

mart added a dependent revision: D12088: port the ksplash kcm to the new design.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D12244

To: mart, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12233: Avoid manipulation of lists with quadratic complexity

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> bruns wrote in fileindexscheduler.cpp:148
> You can put the lambda into the `remove_if` invocation:
> 
>   auto tail = std::remove_if(list.begin(), list.end(),
>  [](const QString& file) {
>  return file.startsWith(dir);
>  });

I suppose developers on my level will appreciate code to be most 
self-explanatory. I'm not objecting though, we might al well go "all the way":

  list.erase(std::remove_if(list.begin(), list.end(), [](const QString& 
file) {
  return file.startsWith(dir);
  }), list.end());

> bruns wrote in pendingfilequeue.cpp:66
> You are missing the `m_pendingFiles.remove(...)` and 
> `m_recentlyEmitted.remove(...)` calls here.
> 
> Variant A:
> You can use `std::partition` instead of `std::remove_if` here (which keeps 
> the elements between tail and .end() intact), and iterate over the tail to 
> remove the elements from m_pendingFiles and m_recentlyEmitted. Last, do the 
> erase(tail, m_cache.end()).
> 
> Variant B:
> Use `std::remove_if`, but call `m_pendingFiles.remove()` (dito 
> m_recentlyEmitted) inside the lambda.
> 
> Variant A is definitely the much cleaner approach.

Ooops.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12233

To: michaelh, #baloo
Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12233: Avoid manipulation of lists with quadratic complexity

[Michael Heidelbach]

michaelh updated this revision to Diff 32285.
michaelh added a comment.


  - Include omissions
  - Const!

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12233?vs=3=32285

BRANCH
  remove-if (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12233

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/pendingfilequeue.cpp

To: michaelh, #baloo
Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12247: Use "Do x" action texts for drop menu entries

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Alternativly one could change those menu section titles (which sadly are hard 
to recognize as such with Breeze theme) to be "Add Widgets" and "Set 
Wallpaper", and then list the widgets and wallpapers by their name as before, 
as kind of inlined submenus.
  Though that approach might conflict with some other potential entries in that 
menu, with ""Plasma Package" for the section and "Install" as menu entry. 
Possibly might need a complete overhaul then.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12247

To: kossebau, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12247: Use "Do x" action texts for drop menu entries

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Example of dropping an SVG file onto the background:
  
  Before:
  F5809685: Screenshot_20180416_151514.png 

  After:
  F5809689: Screenshot_20180416_150907.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12247

To: kossebau, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12247: Use "Do x" action texts for drop menu entries

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: VDG, Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  Dropping some item onto a containment results in a menu which lists widgets
  and wallpaper plugins without explicitly telling what will happen onto
  activation.
  
  Changing the menu entries into "Add widget" and "Set wallpaper" makes it
  more obvious what they will result in.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  containmentdropmenudoactions

REVISION DETAIL
  https://phabricator.kde.org/D12247

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: kossebau, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

[Marco Martin]

mart updated this revision to Diff 32280.
mart added a comment.


  - binding loops --

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12244?vs=32274=32280

BRANCH
  phab/newResizing

REVISION DETAIL
  https://phabricator.kde.org/D12244

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml
  src/qmlcontrols/kcmcontrols/qml/GridView.qml
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml

To: mart, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12216: Don't need to run previous iterations commands again

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R249:9c32bdab29b3: Dont need to run previous iterations 
commands again (authored by apol).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12216?vs=32157=32277

REVISION DETAIL
  https://phabricator.kde.org/D12216

AFFECTED FILES
  cmake/build-pofiles.cmake

To: apol, #frameworks, arojas, sitter
Cc: sitter, heikobecker, michaelh, ngraham, bruns

D12218: Remove Reload button from the file dialogs' toolbar

[Nathaniel Graham]

ngraham added a comment.


  In D12218#247125 , @broulik wrote:
  
  > Is it also accessible from the menu in the top right?
  
  
  No, that's a settings menu, not a toolbar overflow menu. Ultimately the 
toolbar should be editable, to satisfy all possible desired combinations: 
https://bugs.kde.org/show_bug.cgi?id=137837

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12218

To: ngraham, #frameworks
Cc: broulik, rkflx, #dolphin, michaelh, ngraham, bruns

D12216: Don't need to run previous iterations commands again

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  Definitely worth a .1

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12216

To: apol, #frameworks, arojas, sitter
Cc: sitter, heikobecker, michaelh, ngraham, bruns

D12244: new resize policy

[Marco Martin]

mart added a comment.


  F5809678: vokoscreen-2018-04-16_14-49-45.mkv 


REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D12244

To: mart, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D12244

To: mart, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

[Marco Martin]

mart added a comment.


  https://www.youtube.com/watch?v=6sXGiGUOSLU=youtu.be
  https://www.youtube.com/watch?v=yN736sDWPHY=youtu.be

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D12244

To: mart, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

[Marco Martin]

mart edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D12244

To: mart, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

[Marco Martin]

mart added a reviewer: Plasma.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D12244

To: mart, #vdg, #plasma
Cc: #frameworks, michaelh, ngraham, bruns

D12244: new resize policy

[Marco Martin]

mart created this revision.
mart added a reviewer: VDG.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
mart requested review of this revision.

REVISION SUMMARY
  the grid view always takes the full kcm
  the extra space is added as space between icons columns

TEST PLAN
  ted on various sizes

REPOSITORY
  R296 KDeclarative

BRANCH
  phab/newResizing

REVISION DETAIL
  https://phabricator.kde.org/D12244

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml
  src/qmlcontrols/kcmcontrols/qml/GridView.qml
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml

To: mart, #vdg
Cc: #frameworks, michaelh, ngraham, bruns

D12231: Reduce the number of zombies to a minimum

[Tobias C . Berner]

tcberner abandoned this revision.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D12231

To: tcberner, #freebsd, sitter, apol
Cc: adridg, anthonyfieroni, #frameworks, michaelh, ngraham, bruns

D11204: Support NTFS hidden files

[Mark Gaiser]

markg added a comment.


  In D11204#247248 , @vonreth wrote:
  
  > The commit broke the build on mac.
  >
  >   11:43:10 
/Users/packaging/Craft/BinaryFactory/macos-64-clang/build/kde/frameworks/tier3/kio/work/kio-5.45.0/src/ioslaves/file/file_unix.cpp:421:19:
 error: no matching function for call to 'getxattr'
  >11:43:10 auto length = getxattr(filenameEncoded.data(), attrName, 
nullptr, 0);
  >11:43:10   ^~~~
  >11:43:10 /usr/include/sys/xattr.h:61:9: note: candidate function not 
viable: requires 6 arguments, but 4 were provided
  >11:43:10 ssize_t getxattr(const char *path, const char *name, void 
*value, size_t size, u_int32_t position, int options);
  >11:43:10 ^
  >11:43:10 
/Users/packaging/Craft/BinaryFactory/macos-64-clang/build/kde/frameworks/tier3/kio/work/kio-5.45.0/src/ioslaves/file/file_unix.cpp:427:14:
 error: no matching function for call to 'getxattr'
  >11:43:10 length = getxattr(filenameEncoded.data(), attrName, 
strAttr, xattr_size);
  >11:43:10  ^~~~
  >11:43:10 /usr/include/sys/xattr.h:61:9: note: candidate function not 
viable: requires 6 arguments, but 4 were provided
  >11:43:10 ssize_t getxattr(const char *path, const char *name, void 
*value, size_t size, u_int32_t position, int options);
  >11:43:10 ^
  >11:43:10 2 errors generated.
  
  
  Ha, apparently linux and mac implement the same principle (xattr) but with 
different arguments (same function names).
  Linux docs: http://man7.org/linux/man-pages/man2/getxattr.2.html
  Mac docs: 
https://developer.apple.com/legacy/library/documentation/Darwin/Reference/ManPages/man2/getxattr.2.html
  
  Note for the mac one, the link above is to their legacy stuff (found via 
google). I don't know if they have a "non-legacy" version or completely new 
alternative.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks, dfaure
Cc: vonreth, kossebau, dfaure, markg, elvisangelaccio, ltoscano, 
anthonyfieroni, broulik, #frameworks, #dolphin, michaelh, ngraham, bruns

D11204: Support NTFS hidden files

[Hannah von Reth]

vonreth added a comment.


  The commit broke the build on mac.
  
11:43:10 
/Users/packaging/Craft/BinaryFactory/macos-64-clang/build/kde/frameworks/tier3/kio/work/kio-5.45.0/src/ioslaves/file/file_unix.cpp:421:19:
 error: no matching function for call to 'getxattr'
11:43:10 auto length = getxattr(filenameEncoded.data(), attrName, 
nullptr, 0);
11:43:10   ^~~~
11:43:10 /usr/include/sys/xattr.h:61:9: note: candidate function not 
viable: requires 6 arguments, but 4 were provided
11:43:10 ssize_t getxattr(const char *path, const char *name, void *value, 
size_t size, u_int32_t position, int options);
11:43:10 ^
11:43:10 
/Users/packaging/Craft/BinaryFactory/macos-64-clang/build/kde/frameworks/tier3/kio/work/kio-5.45.0/src/ioslaves/file/file_unix.cpp:427:14:
 error: no matching function for call to 'getxattr'
11:43:10 length = getxattr(filenameEncoded.data(), attrName, strAttr, 
xattr_size);
11:43:10  ^~~~
11:43:10 /usr/include/sys/xattr.h:61:9: note: candidate function not 
viable: requires 6 arguments, but 4 were provided
11:43:10 ssize_t getxattr(const char *path, const char *name, void *value, 
size_t size, u_int32_t position, int options);
11:43:10 ^
11:43:10 2 errors generated.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks, dfaure
Cc: vonreth, kossebau, dfaure, markg, elvisangelaccio, ltoscano, 
anthonyfieroni, broulik, #frameworks, #dolphin, michaelh, ngraham, bruns

D12216: Don't need to run previous iterations commands again

[Heiko Becker]

heikobecker added a comment.


  In D12216#247225 , @apol wrote:
  
  > I'm unsure if it's worth re-spinning ki18n.
  
  
  It's already out, so it would need a .1, but it may be worth it as it appears 
builds are hanging otherwise.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D12216

To: apol, #frameworks, arojas
Cc: heikobecker, michaelh, ngraham, bruns

D12225: Also make installation of translated docs optional

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R317:03d503362514: Also make installation of translated docs 
optional (authored by heikobecker).

REPOSITORY
  R317 Kross

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12225?vs=32186=32273

REVISION DETAIL
  https://phabricator.kde.org/D12225

AFFECTED FILES
  CMakeLists.txt

To: heikobecker, #frameworks, apol
Cc: michaelh, ngraham, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 105 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/105/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 16 Apr 2018 11:36:58 +
 Build duration:
4 min 36 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 130 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/130/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 16 Apr 2018 11:36:58 +
 Build duration:
3 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3558/13511)19%
(1978/10689)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/452)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2314)7%
(102/1552)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3532)28%
(827/2965)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1621)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(552/2015)17%
(305/1779)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1177)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
  

D12231: Reduce the number of zombies to a minimum

[Aleix Pol Gonzalez]

apol added a comment.


  https://phabricator.kde.org/D12216
  
  Please check the list first...

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D12231

To: tcberner, #freebsd, sitter, apol
Cc: adridg, anthonyfieroni, #frameworks, michaelh, ngraham, bruns

D12225: Also make installation of translated docs optional

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R317 Kross

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12225

To: heikobecker, #frameworks, apol
Cc: michaelh, ngraham, bruns

D12216: Don't need to run previous iterations commands again

[Aleix Pol Gonzalez]

apol added a comment.


  Landing, I'm unsure if it's worth re-spinning.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D12216

To: apol, #frameworks, arojas
Cc: michaelh, ngraham, bruns

D12242: KJob public signals

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D12242

To: jtamate, dfaure, #frameworks
Cc: michaelh, ngraham, bruns

D12242: KJob public signals

[Jaime Torres Amate]

jtamate updated this revision to Diff 32267.
jtamate added a comment.


  Changed from "can't" to "shouldn't".

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12242?vs=32258=32267

REVISION DETAIL
  https://phabricator.kde.org/D12242

AFFECTED FILES
  src/lib/jobs/kjob.h

To: jtamate, dfaure, #frameworks
Cc: michaelh, ngraham, bruns

D12242: KJob public signals

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kjob.h:472
>   *
> - * This is a private signal, it can't be emitted directly by subclasses 
> of
> + * @note: This is a private signal, it can't be emitted directly by 
> subclasses of
>   * KJob, use setTotalAmount() instead.

"can't" should now be "shouldn't", since it's now technically possible, just 
strongly discouraged.

If we leave "can't" and someone tries it, it will work, and they'll think there 
is no problem then ;)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D12242

To: jtamate, dfaure, #frameworks
Cc: michaelh, ngraham, bruns

D12235: Add XDG Output Protocol

[David Edmundson]

davidedmundson updated this revision to Diff 32266.
davidedmundson added a comment.


  Some minor fixes

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12235?vs=32227=32266

BRANCH
  davidedmundson/xdgoutput

REVISION DETAIL
  https://phabricator.kde.org/D12235

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_output.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-output-unstable-v1.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgoutput.cpp
  src/client/xdgoutput.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/xdgoutput_interface.cpp
  src/server/xdgoutput_interface.h
  src/tools/mapping.txt
  tests/CMakeLists.txt

To: davidedmundson, romangg
Cc: #frameworks, michaelh, ngraham, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 104 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/104/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 16 Apr 2018 09:22:52 +
 Build duration:
5 min 31 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D11361: add a version containmentForScreen with activity

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:bfa19dbc8fc7: add a version containmentForScreen with 
activity (authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11361?vs=31200=32263#toc

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11361?vs=31200=32263

REVISION DETAIL
  https://phabricator.kde.org/D11361

AFFECTED FILES
  src/plasma/corona.cpp
  src/plasma/corona.h
  src/plasma/private/corona_p.h

To: mart, #plasma, davidedmundson
Cc: davidedmundson, #frameworks, michaelh, ngraham, bruns

D11945: Optimize AppArmor & SELinux highlighting and improve regex

[Nibaldo González]

nibags added a comment.


  I thought it would be better if the keywords used fewer lines in the file.
  If it's more comfortable I can restore it to how it was before...

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D11945

To: nibags, dhaumann
Cc: #frameworks, michaelh, genethomas, ngraham, bruns, cullmann, vkrause, 
dhaumann

D11902: Add highlighting for GDB command listings and gdbinit files

[Milian Wolff]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:88288f834175: Add highlighting for GDB command listings 
and gdbinit files (authored by mwolff).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11902?vs=31207=32262

REVISION DETAIL
  https://phabricator.kde.org/D11902

AFFECTED FILES
  autotests/folding/highlight.bt.fold
  autotests/folding/highlight.gdb.fold
  autotests/folding/highlight.gdbinit.fold
  autotests/html/highlight.bt.html
  autotests/html/highlight.gdb.html
  autotests/html/highlight.gdbinit.html
  autotests/input/highlight.bt
  autotests/input/highlight.gdb
  autotests/input/highlight.gdbinit
  autotests/reference/highlight.bt.ref
  autotests/reference/highlight.gdb.ref
  autotests/reference/highlight.gdbinit.ref
  data/syntax/gdb-bt.xml
  data/syntax/gdb.xml
  data/syntax/gdbinit.xml

To: mwolff, vkrause, dhaumann, #kate, cullmann
Cc: cullmann, #frameworks, michaelh, ngraham, bruns

D11902: Add highlighting for GDB command listings and gdbinit files

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Given we have unit tests + the static checker is happy (I assume), feel free 
to commit.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11902

To: mwolff, vkrause, dhaumann, #kate, cullmann
Cc: cullmann, #frameworks, michaelh, ngraham, bruns

D11902: Add highlighting for GDB command listings and gdbinit files

[Milian Wolff]

mwolff added a comment.


  Ping? Or can I just commit?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D11902

To: mwolff, vkrause, dhaumann, #kate
Cc: #frameworks, michaelh, ngraham, bruns

D11945: Optimize AppArmor & SELinux highlighting and improve regex

[Nibaldo González]

nibags updated this revision to Diff 32260.
nibags added a comment.


  - SELinux CIL: Add binaries and float.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11945?vs=32240=32260

BRANCH
  opt-apparmor-selinux (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11945

AFFECTED FILES
  autotests/html/usr.bin.apparmor-profile-test.html
  autotests/reference/test.cil.ref
  autotests/reference/test.fc.ref
  autotests/reference/usr.bin.apparmor-profile-test.ref
  data/syntax/apparmor.xml
  data/syntax/selinux-cil.xml
  data/syntax/selinux-fc.xml

To: nibags, dhaumann
Cc: #frameworks, michaelh, genethomas, ngraham, bruns, cullmann, vkrause, 
dhaumann

D12235: Add XDG Output Protocol

[Roman Gilg]

romangg added a reviewer: romangg.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12235

To: davidedmundson, romangg
Cc: #frameworks, michaelh, ngraham, bruns

D12242: KJob public signals

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  KIO::KCoreDirLister connects to those signals, they must be public so the new 
connect syntax compiles.

TEST PLAN
  kio compiles with new connect syntax.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D12242

AFFECTED FILES
  src/lib/jobs/kjob.h

To: jtamate, dfaure, #frameworks
Cc: michaelh, ngraham, bruns

D12226: balooshow: Colorize only when attached to terminal

[Michael Heidelbach]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:094d6e90d4c0: balooshow: Colorize only when attached to 
terminal (authored by michaelh).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12226?vs=32256=32257

REVISION DETAIL
  https://phabricator.kde.org/D12226

AFFECTED FILES
  src/tools/balooshow/main.cpp

To: michaelh, #baloo, bruns, #freebsd, tcberner
Cc: tcberner, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D12226: balooshow: Colorize only when attached to terminal

[Michael Heidelbach]

michaelh updated this revision to Diff 32256.
michaelh added a comment.


  - Rebase

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12226?vs=32193=32256

BRANCH
  no-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12226

AFFECTED FILES
  src/tools/balooshow/main.cpp

To: michaelh, #baloo, bruns, #freebsd, tcberner
Cc: tcberner, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D11945: Optimize AppArmor & SELinux highlighting and improve regex

[Dominik Haumann]

dhaumann added a comment.


  Out of curiosity: why are you putting multiple items in the same line on the 
keyword lists? This bloats up the diff and makes a real review so much 
harder... :/

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D11945

To: nibags, dhaumann
Cc: #frameworks, michaelh, genethomas, ngraham, bruns, cullmann, vkrause, 
dhaumann

D11753: baloodb: Add clean command

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> bruns wrote in databasesanitizer.cpp:344
> do the calls to m_transaction using a wrapper, e.g. 
> `DatabaseSanitizer::removeDocument(info.id)`

I'm assuming you meant `DatabaseSanitizerImpl::removeDocument(info.id)`. If you 
meant `DatabaseSanitizer::removeDocument`, please explain what the advantage is.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11753

To: michaelh, #baloo, #frameworks, bruns
Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham