D12306: Filepicker dialog proper grid icon layout

[Nathaniel Graham]

ngraham added a comment.


  Ooh, centering when there's only one column is a nice touch.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12306

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12389: Filepicker reads thumbs preview from Dolphin settings

[Nathaniel Graham]

ngraham added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R241 KIO

BRANCH
  dolphin_thumbs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12389

To: anemeth, #frameworks, #vdg, ngraham, #dolphin
Cc: ngraham, #frameworks, michaelh, bruns

D12392: Fix the "Default" color scheme to match Breeze again

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D12392

To: ngraham, #breeze, #plasma, hein
Cc: #frameworks, michaelh, bruns

D12392: Fix the "Default" color scheme to match Breeze again

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D12392

To: ngraham, #breeze, #plasma, hein
Cc: #frameworks, michaelh, bruns

D12392: Fix the "Default" color scheme to match Breeze again

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Breeze, Plasma, hein.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  Over the years, the "Default" color scheem seems to have drifted out of 
alignment with Breeze. Part of this was my doing, in 
https://cgit.kde.org/breeze.git/commit/?id=04dac01c2a3268f7f6189b2d5c404cb2b7aaf51f,
 but there were other changes too.
  
  This patch fixes it to match breeze again. There may be more patches required 
in other repos, which will be forth coming as I discover more definitions of 
the default color scheme (this is the only once I;ve found so far).

TEST PLAN
  [video goes here]

REPOSITORY
  R265 KConfigWidgets

BRANCH
  fix-default-color-scheme (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12392

AFFECTED FILES
  src/kcolorscheme.cpp

To: ngraham, #breeze, #plasma, hein
Cc: #frameworks, michaelh, bruns

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 20 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/20/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 21 Apr 2018 00:01:54 +
 Build duration:
8 min 59 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 76 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/76/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 21 Apr 2018 00:01:54 +
 Build duration:
6 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 59 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/59/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Sat, 21 Apr 2018 00:01:54 +
 Build duration:
3 min 40 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittest

D12385: Thumbnail smooth scaling in filepicker

[Nathaniel Graham]

ngraham added a comment.


  I too cannot reproduce the performance issue, even after nuking 
`~/.cache/thumbnails` and having it regenerate the thumbnails. Can you, @cfeck?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12385

To: anemeth, #frameworks, #vdg
Cc: cfeck, broulik, ngraham, #frameworks, michaelh, bruns

D12389: Filepicker reads thumbs preview from Dolphin settings

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a reviewer: Dolphin.
ngraham added a comment.
This revision is now accepted and ready to land.


  Wow, a truly trivial fix! Since Dolphin is currently where the config UI for 
this lives, I think it makes sense to re-use that information here.
  
  I was worried about the use cases where Dolphin isn't installed (e.g. the 
case of someone using Kate or Gwenview or something in their GNOME or MATE 
environment) but I tested that out that seems to work just fine, and it gets 
the correct set of default plugins. Also works fine in the new user use case 
where Dolphin is installed, but the user opens a file dialog before Dolphin.
  
  #dolphin  folks, does this look 
sane?

REPOSITORY
  R241 KIO

BRANCH
  dolphin_thumbs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12389

To: anemeth, #frameworks, #vdg, ngraham, #dolphin
Cc: ngraham, #frameworks, michaelh, bruns

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Stefan Brüns]

bruns added a comment.


  Gnome-disks does, and so do other programs.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12306: Filepicker dialog proper grid icon layout

[Alex Nemeth]

anemeth updated this revision to Diff 32680.
anemeth added a comment.


  Revert centered icons when there is only one column, fix comment

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12306?vs=32614=32680

BRANCH
  grid_layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12306

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D11155: handle zip files embedded within zip files

[Nathaniel Graham]

ngraham added a comment.


  Does this resolve https://bugs.kde.org/show_bug.cgi?id=73821?

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D11155

To: sandsmark, dfaure, #frameworks
Cc: ngraham, #frameworks, michaelh, bruns

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Andrius Štikonas]

stikonas added a comment.


  In D12311#250660 , @bruns wrote:
  
  > No, thats completely off, as thats the action you are authorizing.
  >
  > > Authorization is required to format disk WDC WD10EZEX-08M2NA0
  >
  > I want it to show what it is asking permission for, and to be specific - 
does it want to format the USB stick I just inserted, or my home partition.
  
  
  Partition Manager wouldn't be able to show such specific text anyway (what is 
being formatted). It just starts a helper that can execute any command it asks. 
You can't make it work otherwise.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Stefan Brüns]

bruns added a comment.


  Its not available otherwise ...

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Luigi Toscano]

ltoscano added a comment.


  In D12311#250660 , @bruns wrote:
  
  > No, thats completely off, as thats the action you are authorizing.
  >
  > > Authorization is required to format disk WDC WD10EZEX-08M2NA0
  >
  > I want it to show what it is asking permission for, and to be specific - 
does it want to format the USB stick I just inserted, or my home partition.
  
  
  As long as you keep the detailed information available, that's fine. You can 
always end up having a non useful name for your USB stick...

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Stefan Brüns]

bruns added a comment.


  No, thats completely off, as thats the action you are authorizing.
  
  > Authorization is required to format disk WDC WD10EZEX-08M2NA0
  
  I want it to show what it is asking permission for, and to be specific - does 
it want to format the USB stick I just inserted, or my home partition.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  Hmm, I was actually leaning the other way. Ditch the generic boilerplate and 
keep the app-specific text. I think it's helpful when the dialog tells you why 
it appeared and what app/function is requesting your password.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Nathaniel Graham]

ngraham added a comment.


  So right now, we have two strings of text:
  
  - The top bold string comes from the app and differs on a per-app basis
  - The bottom long boilerplate string is from us, and shown all the time
  
  I  like @abetts' idea: we should remove the app-specific text and make the 
always-shown boilerplate text short and to the point.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a subscriber: stikonas.
sharvey added a comment.


  Semi-related bug from @stikonas, while I'm on dialog duty: 
https://bugs.kde.org/show_bug.cgi?id=393355

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  The small-text boilerplate is definitely on the chopping block. @ltoscano 
makes a fine case for keeping the Details section.
  
  @bruns - Thanks for helping me find the source of the incoming messages. I 
hadn't gotten around to searching for them yet, but you saved me some work. 
Thanks!

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Stefan Brüns]

bruns added a comment.


  Btw, an easy way to trigger the dialog is e.g.
  
$> pkcheck -u -p $$ -a org.freedesktop.udisks2.eject-media-system
  
  $$ is the PID of the shell.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12228: kdirlister new connect syntax

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12228

To: jtamate, dfaure, #frameworks
Cc: michaelh, bruns

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Stefan Brüns]

bruns added a comment.


  The "Authentication is required to ..." header line is directly sourced from 
the action definition below `/usr/share/polkit-1/actions/*`
  
  "Administrator password" is insufficient/wrong, as you can also (dependent on 
system configuration) authorize the actions as another priviledged user, see 
the screenshots.
  
  Password is redundant (label on the textfield), and wrong, as you can 
potentially use something like a fingerprint to authenticate.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Andres Betts]

abetts added a comment.


  In D12311#250637 , @bruns wrote:
  
  > If you really want to save some space (and probably make it easier for 
users to understand the dialog without getting lost), I think the whole
  >
  > > An application is attempting to perform an action that requires 
privileges.
  > >  Authentication is required to perform this action.
  >
  > boilerplate can be removed. It is some lenghty, generic text, which does 
not add any useful information.
  >
  > If the Action in the Details tab is showing the raw id of the action, its 
the fault of the action definition, lacking a `` tag.
  
  
  What about something like:
  
  "Authentication is required to perform this action. Please enter your 
administrator password"
  
  And nothing else. No 3 lines but just one.
  
  ??

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Stefan Brüns]

bruns added a comment.


  If you really want to save some space (and probably make it easier for users 
to understand the dialog without getting lost), I think the whole
  
  > An application is attempting to perform an action that requires privileges.
  >  Authentication is required to perform this action.
  
  boilerplate can be removed. It is some lenghty, generic text, which does not 
add any useful information.
  
  If the Action in the Details tab is showing the raw id of the action, its the 
fault of the action definition, lacking a `` tag.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12389: Filepicker reads thumbs preview from Dolphin settings

[Alex Nemeth]

anemeth edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12389

To: anemeth, #frameworks, #vdg
Cc: ngraham, #frameworks, michaelh, bruns

D12389: Filepicker reads thumbs preview from Dolphin settings

[Alex Nemeth]

anemeth edited the summary of this revision.
anemeth edited the test plan for this revision.
anemeth added reviewers: Frameworks, VDG.
anemeth added a subscriber: ngraham.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12389

To: anemeth, #frameworks, #vdg
Cc: ngraham, #frameworks, michaelh, bruns

D12389: Filepicker reads thumbs preview from Dolphin settings

[Alex Nemeth]

anemeth created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
anemeth requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  dolphin_thumbs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12389

AFFECTED FILES
  src/filewidgets/kfilepreviewgenerator.cpp

To: anemeth
Cc: #frameworks, michaelh, bruns

D12388: Output device color curves correction

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> outputconfiguration.cpp:184
> +uint16_t *s = reinterpret_cast(wl_array_add(dest, 
> sizeof(uint16_t)));
> +*s = (uint16_t)c;
> +}

Maybe `static_cast`?

I haven't used wl_array but can't you allocate big enough contiguous chunk of 
memory and call memcpy, e.g.

  wl_array wlRed;
  
  wl_array_init();
  auto* redDest = wl_array_add(, sizeof(uint16_t) * red.count());
  memcpy(redDest, red.data(), sizeof(uint16_t) * red.count());

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12388

To: romangg, #frameworks
Cc: zzag, cfeck, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

[Christoph Feck]

cfeck added a comment.


  The XDG thumbnail spec has two thumbnail sizes, 128 and 256. It is possible 
that you hit the "slow" issue when only one size of thumbnail had been created, 
but the other was still pending.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12385

To: anemeth, #frameworks, #vdg
Cc: cfeck, broulik, ngraham, #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

[Alex Nemeth]

anemeth added a comment.


  BTW I don't know what caused the performance issue when moving the slider 
before, maybe something heavy was running in the background, but I can't 
reproduce the problem anymore.
  
  F5815440: 2018-04-20 21-45-19.webm 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12385

To: anemeth, #frameworks, #vdg
Cc: broulik, ngraham, #frameworks, michaelh, bruns

D12388: Output device color curves correction

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> outputconfiguration.h:211
> + */
> +void setColorCurves(OutputDevice *outputdevice, QVector red, 
> QVector green, QVector blue);
> +

The documentation could state how many elements need to be in the vectors. 
Ideally, every component could have any number of elements, and if there are 
too few, the other elements are interpolated.

But it is probably simpler to just state "The number of elements in each vector 
must be 256 or 1024, depending on the depth of the framebuffer (24 bits or 30 
bits)."

> outputconfiguration_interface.cpp:217
> +while((char*)pos < (char*)array->data + array->size) {
> +// TODO: check value not bigger than size (i.e. for 8bit display 
> < 255)?
> +v->append(*pos);

X11 uses 16 bit values even for 24 bit screens, because the actual values that 
are sent to the DAC can have higher precision than the screen pixmap. I doubt 
that Wayland has reduced the precision, so I don't think checking values here 
is right.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12388

To: romangg, #frameworks
Cc: cfeck, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

[Alex Nemeth]

anemeth updated this revision to Diff 32675.
anemeth added a comment.


  Remove debug

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12385?vs=32674=32675

BRANCH
  image_smooth_downscale (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12385

AFFECTED FILES
  src/filewidgets/kfilepreviewgenerator.cpp

To: anemeth, #frameworks, #vdg
Cc: broulik, ngraham, #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

[Alex Nemeth]

anemeth updated this revision to Diff 32674.
anemeth added a comment.


  Revert resize change.
  Turns out the image we got here is already downsized to around 128x128 and we 
further downsize 
  it (if needed), dependent on the icon size.
  Working with this small images the smooth scaling should be fast.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12385?vs=32672=32674

BRANCH
  image_smooth_downscale (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12385

AFFECTED FILES
  src/filewidgets/kfilepreviewgenerator.cpp

To: anemeth, #frameworks, #vdg
Cc: broulik, ngraham, #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

[Alex Nemeth]

anemeth updated this revision to Diff 32672.
anemeth added a comment.


  Remove debug

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12385?vs=32671=32672

BRANCH
  image_smooth_downscale (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12385

AFFECTED FILES
  src/filewidgets/kfilepreviewgenerator.cpp

To: anemeth, #frameworks, #vdg
Cc: broulik, ngraham, #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

[Alex Nemeth]

anemeth updated this revision to Diff 32671.
anemeth added a comment.


  @ngraham good advice
  Smooth scale the fast downscaled image for good performance

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12385?vs=32657=32671

BRANCH
  image_smooth_downscale (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12385

AFFECTED FILES
  src/filewidgets/kfilepreviewgenerator.cpp

To: anemeth, #frameworks, #vdg
Cc: broulik, ngraham, #frameworks, michaelh, bruns

D12371: fix always reproducible crash

[Jaime Torres Amate]

jtamate added a comment.


  More investigation, in bold what causes the problem.
  
  moveListersWithoutCachedItemsJob append  KDirLister(0x3b510c70) to holders 
for url= QUrl("file:///virtual/kde5/5kde/build/frameworks/kio")
  forgetDirs removeAll in directoryData[ 
"file:///virtual/kde5/5kde/build/frameworks/kio" ] for KDirLister(0x3b510c70)
  moveListersWithoutCachedItemsJob append  KDirLister(0x3b510c70) to holders 
for url= QUrl("remote:/")
  forgetDirs removeAll in directoryData[ "remote:/" ] for KDirLister(0x3b510c70)
  **forgetDirs not found: "smb://" in directoryData for KDirLister(0x3b510c70) 
**
  moveListersWithoutCachedItemsJob append  KDirLister(0x3b510c70) to holders 
for url= QUrl("smb:///")
  **moveListersWithoutCachedItemsJob append  KDirLister(0x3b510c70) to holders 
for url= QUrl("smb://") **
  forgetDirs removeAll in directoryData[ "smb:///" ] for KDirLister(0x3b510c70)
  moveListersWithoutCachedItemsJob append  KDirLister(0x3b510c70) to holders 
for url= QUrl("smb://127.0.0.1/")
  forgetDirs removeAll in directoryData[ "smb://127.0.0.1/" ] for 
KDirLister(0x3b510c70)
  moveListersWithoutCachedItemsJob append  KDirLister(0x3b510c70) to holders 
for url= QUrl("smb://127.0.0.1/kk")
  forgetDirs removeAll in directoryData[ "smb://127.0.0.1/kk" ] for 
KCoreDirLister(0x3b510c70)
  forgetCachedItemsJob append  KDirLister(0x4e273400) to holders for url= 
QUrl("smb://127.0.0.1/kk")
  forgetDirs removeAll in directoryData[ "smb://127.0.0.1/kk" ] for 
KDirLister(0x4e273400)
  forgetCachedItemsJob append  KDirLister(0x4e273400) to holders for url= 
QUrl("file:///virtual/kde5/5kde/build/frameworks/kio")
  forgetDirs removeAll in directoryData[ 
"file:///virtual/kde5/5kde/build/frameworks/kio" ] for KDirLister(0x4e273400)
  moveListersWithoutCachedItemsJob append  KDirLister(0x4e273400) to holders 
for url= QUrl("smb://127.0.0.1/kk")
  forgetDirs removeAll in directoryData[ "smb://127.0.0.1/kk" ] for 
KDirLister(0x4e273400)
  forgetCachedItemsJob append  KDirLister(0x4e273400) to holders for url= 
QUrl("file:///virtual/kde5/5kde/build/frameworks/kio")
  forgetDirs removeAll in directoryData[ 
"file:///virtual/kde5/5kde/build/frameworks/kio" ] for KDirLister(0x4e273400)
  forgetCachedItemsJob append  KDirLister(0x4e273400) to holders for url= 
QUrl("file:///virtual/kde5/5kde/build/frameworks/kio")
  forgetDirs removeAll in directoryData[ 
"file:///virtual/kde5/5kde/build/frameworks/kio" ] for KDirLister(0x4e273400)
  forgetCachedItemsJob append  KDirLister(0x4e273400) to holders for url= 
QUrl("remote:/")
  forgetDirs removeAll in directoryData[ "remote:/" ] for KDirLister(0x4e273400)
  forgetDirs removeAll in directoryData[ "smb://" ] for KDirLister(0x4e273400)
  **number of holders for  "smb://" 1**
  
==23870== Invalid read of size 8
==23870==at 0x5F41167: KCoreDirListerCache::slotRedirection(KIO::Job*, 
QUrl const&) (kcoredirlister.cpp:1484)
==23870==by 0x5F4A3A9: call (qobjectdefs_impl.h:136)
==23870==by 0x5F4A3A9: call, 
void> (qobjectdefs_impl.h:169)
==23870==by 0x5F4A3A9: QtPrivate::QSlotObject, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, 
bool*) (qobjectdefs_impl.h:398)
==23870==by 0xA0F736B: call (qobjectdefs_impl.h:378)
==23870==by 0xA0F736B: QMetaObject::activate(QObject*, int, int, 
void**) (qobject.cpp:3749)
==23870==by 0x5EED068: KIO::ListJob::redirection(KIO::Job*, QUrl 
const&) (moc_listjob.cpp:246)
==23870==by 0x5EED481: KIO::ListJobPrivate::slotRedirection(QUrl 
const&) (listjob.cpp:222)
==23870==by 0x5EED4C1: operator() (listjob.cpp:294)
==23870==by 0x5EED4C1: call (qobjectdefs_impl.h:130)
==23870==by 0x5EED4C1: call 
(qobjectdefs_impl.h:240)
==23870==by 0x5EED4C1: 
QtPrivate::QFunctorSlotObject::impl(int, 
QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) (qobjectdefs_impl.h:423)
==23870==by 0xA0F736B: call (qobjectdefs_impl.h:378)
==23870==by 0xA0F736B: QMetaObject::activate(QObject*, int, int, 
void**) (qobject.cpp:3749)
==23870==by 0x5ED159A: KIO::SlaveInterface::redirection(QUrl const&) 
(moc_slaveinterface.cpp:518)
==23870==by 0x5ED3B39: KIO::SlaveInterface::dispatch(int, QByteArray 
const&) (slaveinterface.cpp:248)
==23870==by 0x5ED16F5: KIO::SlaveInterface::dispatch() 
(slaveinterface.cpp:89)
==23870==by 0x5ED64A6: KIO::Slave::gotInput() (slave.cpp:406)
==23870==by 0x5F660AB: KIO::Slave::qt_static_metacall(QObject*, 
QMetaObject::Call, int, void**) (moc_slave.cpp:89)
==23870==  Address 0x3b510c70 is 0 bytes inside a block of size 32 free'd
==23870==at 0x4C2F7BB: operator delete(void*) (in 
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==23870==by 0x5BD45B6: KDirLister::~KDirLister() (kdirlister.cpp:55)

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Luigi Toscano]

ltoscano added a comment.


  Do you really want to remove the proper source of information in security 
dialog that asks you some additional credentials?
  Please keep it there.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: ltoscano, broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12388: Output device color curves correction

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
romangg requested review of this revision.

REVISION SUMMARY
  Extends the output device and output configuration interfaces with the ability
  to query and set the RGB color intensity curves (gamma ramps) of the
  associated output.

TEST PLAN
  Manually. Auto tests will be added to this diff soon.

REPOSITORY
  R127 KWayland

BRANCH
  outputColorCorrectionCurvesOnly

REVISION DETAIL
  https://phabricator.kde.org/D12388

AFFECTED FILES
  src/client/outputconfiguration.cpp
  src/client/outputconfiguration.h
  src/client/outputdevice.cpp
  src/client/outputdevice.h
  src/client/protocols/output-management.xml
  src/client/protocols/outputdevice.xml
  src/server/outputchangeset.cpp
  src/server/outputchangeset.h
  src/server/outputchangeset_p.h
  src/server/outputconfiguration_interface.cpp
  src/server/outputdevice_interface.cpp
  src/server/outputdevice_interface.h

To: romangg, #frameworks
Cc: michaelh, bruns

D12228: kdirlister new connect syntax

[Jaime Torres Amate]

jtamate updated this revision to Diff 32663.
jtamate added a comment.


  Removed comment.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12228?vs=32661=32663

REVISION DETAIL
  https://phabricator.kde.org/D12228

AFFECTED FILES
  src/core/kcoredirlister.cpp
  src/core/kcoredirlister.h

To: jtamate, dfaure, #frameworks
Cc: michaelh, bruns

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Nathaniel Graham]

ngraham added a comment.


  In general it's okay to display nerdy technical information hidden away like 
this--as long as it's actually useful information! That's the real question. If 
it's of no real value to anyone for any use case that we can imaging, we can 
probably safely remove it. Otherwise, it should probably stay in.
  
  Personally I have no use for it, but let's collect more perspectives.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12228: kdirlister new connect syntax

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> kcoredirlister.cpp:525
>  qCDebug(KIO_CORE_DIRLISTER) << "Iterating over dirs" << lstDirsCopy;
> +// JTA: FIXME: Entonces puede estar aquí el problema
>  for (QList::const_iterator it = lstDirsCopy.begin();

This should probably not be here ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12228

To: jtamate, dfaure, #frameworks
Cc: michaelh, bruns

D12251: Integrate with androiddeployqt dependencies files

[Albert Astals Cid]

aacid added a comment.


  threre's not so many unneded stuff in there to be honest, maybe kross, kate 
and the emoticonthemes, but doesn't seem terrible. One would improve that by 
not depending on the whole kf5umbrella probably?

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D12251

To: apol, #frameworks, vkrause, aacid
Cc: michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

[Nathaniel Graham]

ngraham added a comment.


  Could we use the fast scaling while resizing, then change to the smooth 
scaling once the resize operation is done?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12385

To: anemeth, #frameworks, #vdg
Cc: broulik, ngraham, #frameworks, michaelh, bruns

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  Reviewers: as part of my task to redesign and tidy up this dialog box, I'm 
considering removing the Details button in the bottom left corner, along with 
the small pop-open panel that shows additional information. My argument is that 
the info in the Details panel is quite technical (PID's of calling process and 
polkit process) and - in some circumstances - lucid information about the 
program needing authorization. Most of the time, what's coming through is in 
raw form, such as `com.canonical.ubuntu.synaptic` (more or less) instead of 
`Synaptic Package Manager`.
  
  I know carving out UI elements can be controversial, so please give a few +/- 
1's so I know what others think. Maybe some people use it. I don't. But that's 
not a good enough reason to remove it.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12228: kdirlister new connect syntax

[Jaime Torres Amate]

jtamate updated this revision to Diff 32661.
jtamate added a comment.


  Removed Q_PRIVATE_SLOT. Didn't saw them again. :-(

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12228?vs=32658=32661

REVISION DETAIL
  https://phabricator.kde.org/D12228

AFFECTED FILES
  src/core/kcoredirlister.cpp
  src/core/kcoredirlister.h

To: jtamate, dfaure, #frameworks
Cc: michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

[Alex Nemeth]

anemeth planned changes to this revision.
anemeth added a comment.


  In D12385#250511 , @broulik wrote:
  
  > What's the performance penalty of that? Does the file dialog request the 
correct size from the preview job? It shouldn't have to end up in this codepath 
that often, I //think//.
  
  
  Thanks.
  Performance is not good right now when you move the zoom slider.
  Dolphins performance is good because it has less icon sizes available on the 
slider and does not do the scaling until the designated zoom value is selected.
  I still have to work on this one...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12385

To: anemeth, #frameworks, #vdg
Cc: broulik, ngraham, #frameworks, michaelh, bruns

D11155: handle zip files embedded within zip files

[David Faure]

dfaure added a comment.


  ping?

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D11155

To: sandsmark, dfaure, #frameworks
Cc: #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

[Nathaniel Graham]

ngraham added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12385

To: anemeth, #frameworks, #vdg
Cc: broulik, ngraham, #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12385

To: anemeth, #frameworks, #vdg
Cc: broulik, ngraham, #frameworks, michaelh, bruns

D12228: kdirlister new connect syntax

[David Faure]

dfaure added a comment.


  I meant this stuff:
  
  src/core/kcoredirlister.h:Q_PRIVATE_SLOT(d, void _k_slotPercent(KJob *, 
unsigned long))

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12228

To: jtamate, dfaure, #frameworks
Cc: michaelh, bruns

D12371: fix always reproducible crash

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.


  I find this solution horrible. QPointers screams "we designed this wrongly, 
the ownership rules are unclear, stuff gets deleted randomly, we have to guard 
against it".
  
  So while I don't deny that we might have designed this wrongly (and if we 
did, it's probably my fault), the right solution is to design this correctly, 
not to sprinkle qpointers.
  
  Changing the documented ownership (as in the first version of the patch) 
isn't a solution either (that's behaviour incompatible by definition), but a 
standard solution is setAutoDeleteDirLister(false) for the case where you don't 
want the ownership to be transferred.
  
  I don't understand "KCoreDirListerCache is probably the owner." People can 
create a KDirLister directly.
  
  Also, the commit description reads like "kdirlister got deleted, 
KCoreDirListerCache wasn't told", which is surprising since the KCoreDirLister 
destructor deregisters from the cache using forgetDirs(this), which ends up 
calling dirData.listersCurrentlyHolding.removeAll(lister);
  So I think the investigation hasn't been completed, which then leads to a bad 
fix...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12371

To: jtamate, dfaure, #frameworks, apol
Cc: apol, michaelh, bruns

D12228: kdirlister new connect syntax

[Jaime Torres Amate]

jtamate updated this revision to Diff 32658.
jtamate added a comment.


  Added space.
  Removed SLOT.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12228?vs=32656=32658

REVISION DETAIL
  https://phabricator.kde.org/D12228

AFFECTED FILES
  src/core/kcoredirlister.cpp
  src/core/kcoredirlister_p.h

To: jtamate, dfaure, #frameworks
Cc: michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

[Kai Uwe Broulik]

broulik added a comment.


  What's the performance penalty of that? Does the file dialog request the 
correct size from the preview job? It shouldn't have to end up in this codepath 
that often, I //think//.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12385

To: anemeth, #frameworks, #vdg
Cc: broulik, ngraham, #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

[Alex Nemeth]

anemeth added a subscriber: ngraham.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12385

To: anemeth, #frameworks, #vdg
Cc: ngraham, #frameworks, michaelh, bruns

D12228: kdirlister new connect syntax

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Looks good, but shouldn't you remove the Q_PRIVATE_SLOT declarations too? 
They aren't used anymore, AFAICS.

INLINE COMMENTS

> kcoredirlister.cpp:2720
> +m_parent->connect(job, ::infoMessage, m_parent,
> +[this](KJob *job,const QString ){ _k_slotInfoMessage(job, 
> plain); });
> +m_parent->connect(job, QOverload::of(::percent), 
> m_parent,

missing space after the first comma

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12228

To: jtamate, dfaure, #frameworks
Cc: michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

[Alex Nemeth]

anemeth edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12385

To: anemeth, #frameworks, #vdg
Cc: #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

[Alex Nemeth]

anemeth edited the summary of this revision.
anemeth edited the test plan for this revision.
anemeth added reviewers: Frameworks, VDG.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12385

To: anemeth, #frameworks, #vdg
Cc: #frameworks, michaelh, bruns

D12228: kdirlister new connect syntax

[Jaime Torres Amate]

jtamate updated this revision to Diff 32656.
jtamate edited the summary of this revision.
jtamate edited the test plan for this revision.
jtamate added a comment.


  Change the first connect.
  No need to change the name of the slot.
  Pass the plain error message.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12228?vs=32362=32656

REVISION DETAIL
  https://phabricator.kde.org/D12228

AFFECTED FILES
  src/core/kcoredirlister.cpp

To: jtamate, dfaure, #frameworks
Cc: michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

[Alex Nemeth]

anemeth updated this revision to Diff 32657.
anemeth added a comment.


  Remove accidental left in change

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12385?vs=32655=32657

BRANCH
  image_smooth_downscale (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12385

AFFECTED FILES
  src/filewidgets/kfilepreviewgenerator.cpp

To: anemeth
Cc: #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

[Alex Nemeth]

anemeth created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
anemeth requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  image_smooth_downscale (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12385

AFFECTED FILES
  CMakeLists.txt
  src/filewidgets/kfilepreviewgenerator.cpp

To: anemeth
Cc: #frameworks, michaelh, bruns

D12384: Fix double margins around DownloadDialog

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: leinir.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.

REPOSITORY
  R304 KNewStuff

BRANCH
  fixextramarginarounddownladdialog

REVISION DETAIL
  https://phabricator.kde.org/D12384

AFFECTED FILES
  src/downloaddialog.cpp

To: kossebau, leinir
Cc: #frameworks, michaelh, bruns

D12130: Use the more user-friendly string "File type" in the save dialogs

[Nathaniel Graham]

ngraham added a comment.


  In D12130#250476 , @rkflx wrote:
  
  > In D12130#245921 , @ngraham 
wrote:
  >
  > > I might need some help with this. It seems that the apps whose save 
dialogs show a combobox in place of a filter list are creating a `QDialog` and 
setting the Mime types list with `QDialog::setMimeTypeFilter()`. I haven't yet 
managed to figure out how this call is intercepted and replaced with a 
KFileDialog, or how KFileDialog can detect that there's a combobox of MIME 
types instead of a filter widget.
  >
  >
  > In Gwenview, grep for "Save Image" (has prepopulated combobox) and "Open 
Image" (does not have combobox, but editable and prepopulated filter). The 
difference seems to be the missing `selectMimeTypeFilter` for the latter.
  >
  > Note than in your comment you are referring to `setMimeTypeFilter[s]`, 
which for Gwenview is called in both cases, thus not leading into a code path 
you are interested in.
  >
  > Did not yet have the time (with all the other Diffs to comment on ;) to 
look into how this translates to `KFileDialog`, but does this help already?
  
  
  Yes, and I did more investigation myself, and all the glue is in 
plasma-integration. Some changes might be needed there too (or maybe //all// 
the changes will be needed there, we'll see!)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12130

To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx, abetts
Cc: safaalfulaij, davidc, ltoscano, cfeck, rkflx, alexeymin, abetts, bruns, 
michaelh

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

[Nathaniel Graham]

ngraham added a comment.


  In D12333#250475 , @rkflx wrote:
  
  > Sorry, I don't really get what you mean. I'm not proposing going back to 
KDE3, Nate is proposing going back to the KDE3 design! (In KDE4 this was 
improved to what we have in KF5, FYI.) Also, I don't see where you get from 
that I'm proposing to follow any "law"? Not sure what you mean with "2 sets of 
navigation buttons" which are "together in one horizontal plane", either. If 
you are referring to Nate's mockup, I'm the wrong person to ask. Comparisons to 
Windows are moot, because there you have different design constraints due to 
the position of the breadcrumb bar. Lastly, I don't get the connection between 
your example and the title of the Diff.
  >
  > @ngraham Do we need to take a decision right now, or are you willing to 
wait until some of the other stuff has cleared up?
  
  
  Definitely willing to wait. We're pretty close to having all the pieces ready 
for Goal #1 on T8552  , so maybe let's focus 
on that first.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12333

To: ngraham, #frameworks, #dolphin, #vdg
Cc: abetts, jtamate, broulik, anemeth, rkflx, michaelh, bruns

D12130: Use the more user-friendly string "File type" in the save dialogs

[Henrik Fehlauer]

rkflx added a comment.


  In D12130#245921 , @ngraham wrote:
  
  > I might need some help with this. It seems that the apps whose save dialogs 
show a combobox in place of a filter list are creating a `QDialog` and setting 
the Mime types list with `QDialog::setMimeTypeFilter()`. I haven't yet managed 
to figure out how this call is intercepted and replaced with a KFileDialog, or 
how KFileDialog can detect that there's a combobox of MIME types instead of a 
filter widget.
  
  
  In Gwenview, grep for "Save Image" (has prepopulated combobox) and "Open 
Image" (does not have combobox, but editable and prepopulated filter). The 
difference seems to be the missing `selectMimeTypeFilter` for the latter.
  
  Note than in your comment you are referring to `setMimeTypeFilter[s]`, which 
for Gwenview is called in both cases, thus not leading into a code path you are 
interested in.
  
  Did not yet have the time (with all the other Diffs to comment on ;) to look 
into how this translates to `KFileDialog`, but does this help already?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12130

To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx, abetts
Cc: safaalfulaij, davidc, ltoscano, cfeck, rkflx, alexeymin, abetts, bruns, 
michaelh

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

[Henrik Fehlauer]

rkflx added a comment.


  Sorry, I don't really get what you mean. I'm not proposing going back to 
KDE3, Nate is proposing going back to the KDE3 design! (In KDE4 this was 
improved to what we have in KF5, FYI.) Also, I don't see where you get from 
that I'm proposing to follow any "law"? Not sure what you mean with "2 sets of 
navigation buttons" which are "together in one horizontal plane", either. If 
you are referring to Nate's mockup, I'm the wrong person to ask. Comparisons to 
Windows are moot, because there you have different design constraints due to 
the position of the breadcrumb bar. Lastly, I don't get the connection between 
your example and the title of the Diff.
  
  @ngraham Do we need to take a decision right now, or are you willing to wait 
until some of the other stuff has cleared up?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12333

To: ngraham, #frameworks, #dolphin, #vdg
Cc: abetts, jtamate, broulik, anemeth, rkflx, michaelh, bruns

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

[Andres Betts]

abetts added a comment.


  +1
  
  In D12333#250266 , @rkflx wrote:
  
  > In D12333#250194 , @abetts wrote:
  >
  > > I gave a +1 to the original idea because I feel that there isn't really 
much closeness that you can achieve with the open dialog. It is simple, 
straightforward.
  >
  >
  > I find the pre-patch design also very streamlined.
  >
  > > If we wanted to do a strict fitt's law follow, then each back and forth 
icon would be next to each of the folders and not in a toolbar.
  >
  > Let's not throw the baby out with the bath water. Having the navigation 
buttons right above the breadcrumb bar is still better the having them crammed 
in the top left corner.
  >
  > > But we also have to see that there is stronger merit in organizing and 
looking for symmetry. Symmetry will sometimes help a user more than Fitt's 
guidelines.
  >
  > This statement may be true in general, but does not fit in our case, as I 
don't see much symmetry here, TBH. Panel and item view occupy most of the 
height, and thus are the most important elements. They are split asymmetrical 
in the horizontal direction, and rightly so. Adding a centered toolbar goes 
against this and breaks up the split, adding even more asymmetry.
  >
  > Furthermore, users are able to hide the places panel. With the current 
design the spatial relation between buttons and item view stays constant, while 
with a centered approach it will jump around.
  >
  > > get user feedback.
  >
  > The file dialog is an important piece of the entire UI. We cannot endlessly 
change things back and forth, we have to get it right by logical thinking the 
first time (in this case it would even be the third time!). In KDE3 it was 
centered, based on feedback from a usability expert it was changed to the 
current design. In terms of //user// feedback, I'm not aware of any huge issue 
users have with it right now.
  >
  > Do you want to change things around again until there //actually// is 
negative feedback? I'd agree with basing design decisions on user feedback if 
we had better telemetry or did some eye tracking studies, but our current 
method of hearing user's opinions over on Reddit and Bugzilla is not very 
effective in painting a broad picture, IMO.
  >
  >  ---
  >
  > Anyway, I'll come back to this Diff once the Sort button is in and we 
decided on a final default dialog size. This should make the decision easier, 
because after all the main motivation was to create space for more buttons.
  
  
  I think you are swimming against a non existent wave with your argument. I 
believe also that we are turning this discussion into a right/wrong argument. I 
don't think that there is a right/wrong approach in this case. If we want to 
hold on to ideas developed or talked about in KDE 3, then we are already 
setting ourselves back a few years. Design evolves. I can understand the desire 
to adhere to "laws" or guidelines, they provide consistency, ideas that we 
follow and easy answers. However, the VDG has not really come out in support of 
this or that "law". We believe that flexibility allows us to grow and evolve. 
Guidelines can be good reference points though.
  
  The proposed alignment has a few advantages, mentioned above. It is also a 
model that Windows and MacOS currently use and have used. I feel that if others 
can pull it off, we can too. This is not about "let's do it the Windows or Mac 
way" but rather it shows an example that while we seem to have a problem with 
it, other, more major and widespread systems, don't have a problem with it at 
all. Plus, it really seems overkill, design wise, to have 2 sets of controls 
that allow you to go back and forth between directories, and they are together 
in one horizontal plane. The first one, would be to the right of the breadcrumb 
navigation and the second would be the breadcrumb itself. Two sets of controls 
that do the same next to each other.
  
  Something that can help is to set the steps a user will take to get to the 
action of opening a file:
  
  1. User clicks open
  2. User looks for file
  3. User navigates to desired folder
1. Breadcrumb grows as folders are clicked
  4. User double-clicks through folders
  5. User goes back to previews folder (Because he can't find the file to open)
  6. User clicks breadcrumb, user clicks arrows, user hits backspace
  7. User finds file
  8. User double clicks file to open
1. User could also select by clicking once, then click [Open]
2. User could also click to select and hit [ENTER]
  
  Alternatively
  
  1. User clicks sidebar to find file
  2. User double clicks file
  
  In these two interaction cases, I am not seeing the need to have 2 sets of 
navigation buttons together.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12333

To: ngraham, #frameworks, #dolphin, #vdg
Cc: abetts, jtamate, broulik, anemeth, rkflx, michaelh, 

D12380: [Containment Interface] Honor plasma/containment_context_menu restriction

[Harald Sitter]

sitter requested changes to this revision.
sitter added a comment.
This revision now requires changes to proceed.


  quick dump from irc
  
[14:48]  kbroulik: hm, doesn't mousePressEvent get called for all 
clicks? (i.e. original line 1021-2026 are where the call chain goes into 
addContainmentActions whcih is where containment_actions is checked), so this 
implementation would make containment_context_menu=false imply 
containment_actions=false, no?
[14:49]  kinda
[14:49]  but you can also restrict just containment ations 
without context menu
[14:49]  oh fuck this shit :(
[14:50]  but not vice versa (:
[14:50]  I'd think they are orthogonal from the documentation
[14:50]  i.e. as previously mentioned one is 
disable-left/middle-click the other is disable-right-click
[14:51]  so containment_actions should do what my patch doies
[14:51]  and containment_context_menu should burn in hell
[14:51]  I'd be content with that :)
  
  Or easier to parse perhaps: either `containment_context_menu` and 
`containment_actions` should be orthogonal (applying to right-click and 
all-other-clicks respectively) OR `containment_actions` applies to all clicks 
while `containment_context_menu` only applies to context menu clicks (right 
clicks) as suggested by Kai.
  
  Previous documentation on the two is as follows:
  
;plasma/containment_actions (since Plasma 4.4)
:Whether or not to allow Plasma mouse actions on containments (usually 
menus that pop up on mouse clicks).

;plasma/containment_context_menu (4.4)
:Whether a context menu should be shown on containments; this can be used 
to shut off the desktop context menu in plasma-desktop, for instance.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12380

To: broulik, #plasma, sitter
Cc: #frameworks, michaelh, bruns

D12380: [Containment Interface] Honor plasma/containment_context_menu restriction

[Kai Uwe Broulik]

broulik updated this revision to Diff 32644.
broulik added a comment.


  - Also reject `QMouseEvent`

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12380?vs=32643=32644

REVISION DETAIL
  https://phabricator.kde.org/D12380

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: broulik, #plasma, sitter
Cc: #frameworks, michaelh, bruns

D12380: [Containment Interface] Honor plasma/containment_context_menu restriction

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, sitter.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  Allows disabling context menus. This got lost in the port from Plasma 4.
  
  CHANGELOG: Most context menus in Plasma can now be disabled using the 
plasma/containment_context_menu KIOSK restriction

TEST PLAN
  Right clicked kickoff, right clicked clock, right clicked desktop, no context 
menu showed up.
  Also disables any other menu actions, e.g. when you assign "application 
launcher" to left click
  
  System tray needs a separate patch

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12380

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: broulik, #plasma, sitter
Cc: #frameworks, michaelh, bruns

D12233: Avoid manipulation of lists with quadratic complexity

[Stefan Brüns]

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> jtamate wrote in pendingfilequeue.cpp:68
> According to std::partition 
> 
> what matches isDescendant should be from m_cache.begin() up to startRemoving, 
> unless you want to remove what does not match isDescendant, isn't it?

Good catch, `std::remove_if` places the elements where the predicate returned 
`false` into the first "partition", `std::partition` shows the opposite 
behavior.

As we have to discard the second part (for O(1) behavior), the correct fix is 
to inverse the return value of the predicate.

Probably rename the the predicate to "preserveFile" or something like that.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12233

To: michaelh, #baloo, bruns
Cc: jtamate, bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun

D12371: fix always reproducible crash

[Jaime Torres Amate]

jtamate added a comment.


  In D12371#250366 , @apol wrote:
  
  > ^^' this won't work though. If the object gets deleted you will get a null 
pointer in the list.
  
  
  If the QPointer kdl detects that the guarded pointer is invalid it is removed 
from the list.
  
if (kdl.isNull()) {
curHolders.removeAll(kdl);
}
  
  I'm unable to create the crash.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12371

To: jtamate, dfaure, #frameworks, apol
Cc: apol, michaelh, bruns

D12371: fix always reproducible crash

[Aleix Pol Gonzalez]

apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.


  ^^' this won't work though. If the object gets deleted you will get a null 
pointer in the list.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12371

To: jtamate, dfaure, #frameworks, apol
Cc: apol, michaelh, bruns

D12379: [Containment Interface] Don't enter edit mode when immutable

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  Opening the toolbox when widgets are locked reveals the widget handles but 
they're empty as all the actions are unavailable.
  Just refuse to enter edit mode then.

TEST PLAN
  Locked widgets, opened toolbox, applet handles stayed hidden. Same for system 
immutable.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12379

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: broulik, #plasma
Cc: #frameworks, michaelh, bruns

D12378: Properly search for NetworkManager

[Jan Grulich]

jgrulich edited the summary of this revision.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D12378

To: jgrulich, #frameworks
Cc: #frameworks, michaelh, bruns

D12378: Properly search for NetworkManager

[Jan Grulich]

jgrulich edited the summary of this revision.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D12378

To: jgrulich, #frameworks
Cc: #frameworks, michaelh, bruns

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 41 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/41/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 20 Apr 2018 11:43:37 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/13/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 20 Apr 2018 11:43:37 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest

D12371: fix always reproducible crash

[Jaime Torres Amate]

jtamate updated this revision to Diff 32640.
jtamate edited the summary of this revision.
jtamate edited the test plan for this revision.
jtamate added a comment.


  Implemented as Aleix suggested, using QPointer.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12371?vs=32626=32640

REVISION DETAIL
  https://phabricator.kde.org/D12371

AFFECTED FILES
  src/core/kcoredirlister.cpp
  src/core/kcoredirlister_p.h

To: jtamate, dfaure, #frameworks
Cc: apol, michaelh, bruns

D12378: Properly search for NetworkManager

[Jan Grulich]

jgrulich added a reviewer: Frameworks.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D12378

To: jgrulich, #frameworks
Cc: #frameworks, michaelh, bruns

D12378: Properly search for NetworkManager

[Jan Grulich]

jgrulich created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
jgrulich requested review of this revision.

REVISION SUMMARY
  Make use of CMake module from nm-qt to search for libnm (NetworkManager 
library) instead
  of previous NM library which has been deprecated. This new library has been 
introduced with
  NM 1.0 which was released ~3 years ago so I assume it's not problem to 
require it. It also 
  fixes build of solid-networkstatus with NM support as it was not never 
enabled because NM_07
  was not set.

REPOSITORY
  R239 KDELibs4Support

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12378

AFFECTED FILES
  cmake/modules/FindNetworkManager.cmake
  src/solid-networkstatus/kded/CMakeLists.txt
  src/solid-networkstatus/kded/networkmanagerstatus.cpp
  src/solid-networkstatus/kded/networkmanagerstatus.h

To: jgrulich
Cc: #frameworks, michaelh, bruns

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/36/
 Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 20 Apr 2018 11:43:37 +
 Build duration:
3 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kmimetypetestFailed: TestSuite.kstandarddirstest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 135 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/135/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 20 Apr 2018 10:44:02 +
 Build duration:
4 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3558/13511)19%
(1978/10689)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/452)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2314)7%
(102/1552)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3532)28%
(827/2965)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1621)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(552/2015)17%
(305/1779)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1177)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
 

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 110 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/110/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 20 Apr 2018 10:44:02 +
 Build duration:
2 min 50 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 225 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/225/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 20 Apr 2018 09:59:16 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(286/442)65%
(286/442)50%
(29920/59672)36%
(17654/48987)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(71/73)97%
(71/73)81%
(7400/9127)42%
(4552/10857)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core79%
(94/119)79%
(94/119)55%
(7890/14347)48%
(4666/9747)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3868/7857)33%
(1630/4934)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(522/1008)42%
(418/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 74 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/74/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 20 Apr 2018 09:59:20 +
 Build duration:
5 min 19 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(286/442)65%
(286/442)50%
(29968/59674)36%
(17676/48983)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(71/73)97%
(71/73)81%
(7400/9127)42%
(4554/10857)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core79%
(94/119)79%
(94/119)55%
(7960/14349)48%
(4698/9751)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3869/7857)33%
(1631/4934)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
   

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 203 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/203/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 20 Apr 2018 09:52:56 +
 Build duration:
6 min 32 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 224 - Failure!

[CI System]

Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38):
${JELLY_SCRIPT,template="html_gmail"}
 ^

java.io.IOException: remote file operation failed: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/html_gmail.jelly at hudson.remoting.Channel@46e5a19c:Docker Swarm-065ef906b532: hudson.remoting.ChannelClosedException: Channel "unknown": Remote call on Docker Swarm-065ef906b532 failed. The channel is closing down or has closed down

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 73 - Failure!

[CI System]

Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38):
${JELLY_SCRIPT,template="html_gmail"}
 ^

java.io.IOException: remote file operation failed: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/html_gmail.jelly at hudson.remoting.Channel@6c4cb2be:Docker Swarm-cf94877a3f1c: hudson.remoting.ChannelClosedException: Channel "unknown": Remote call on Docker Swarm-cf94877a3f1c failed. The channel is closing down or has closed down

D12339: [KUrlNavigatorButton] Also don't stat MTP

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:73d2036b09a9: [KUrlNavigatorButton] Also dont stat 
MTP (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12339?vs=32536=32633

REVISION DETAIL
  https://phabricator.kde.org/D12339

AFFECTED FILES
  src/filewidgets/kurlnavigatorbutton.cpp

To: broulik, #frameworks, ngraham
Cc: #frameworks, michaelh, bruns

D12371: fix always reproducible crash

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kdirmodel.cpp:401
>  {
> +// dirLister is probably onwed by KCoreDirListerCache
>  if (d->m_dirLister) {

Maybe KCoreDirListerCache should be using a QPointer? or checking if it gets 
deleted?

> kdirmodel.h:65
>   */
> +// Can't take ownership because KCoreDirListerCache is probably the 
> owner.
>  void setDirLister(KDirLister *dirLister);

It's a bit weird having a comment after a comment.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12371

To: jtamate, dfaure, #frameworks
Cc: apol, michaelh, bruns

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/19/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 20 Apr 2018 08:49:45 +
 Build duration:
8 min 27 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10 - Build # 20 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.10/20/
 Project:
Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Fri, 20 Apr 2018 08:49:45 +
 Build duration:
8 min 41 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 22 test(s)Failed: TestSuite.kdelibs4configmigratortestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.krandomtest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 75 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/75/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 20 Apr 2018 08:49:45 +
 Build duration:
6 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 58 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/58/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 20 Apr 2018 08:49:45 +
 Build duration:
3 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 AndroidQt5.10 - Build # 11 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20AndroidQt5.10/11/
 Project:
Frameworks kcoreaddons kf5-qt5 AndroidQt5.10
 Date of build:
Fri, 20 Apr 2018 08:49:45 +
 Build duration:
1 min 3 sec and counting

[kcoreaddons] src/lib: Revert "Warning--"

[Ben Cooksley]

Git commit bf353edc42fdecf9fda34a024ba7cabcd0efaf68 by Ben Cooksley.
Committed on 20/04/2018 at 08:47.
Pushed by bcooksley into branch 'master'.

Revert "Warning--"

The changes in these commits fail on all platforms aside from Linux, breaking 
the FreeBSD, Android and Windows builds.

CCMAIL: kde-frameworks-devel@kde.org

This reverts commit 6c27d32fd88387a399955e4497eb976bffc0780e.

M  +1-1src/lib/io/kdirwatch.h
M  +1-1src/lib/jobs/kjobtrackerinterface.h
M  +0-1src/lib/kaboutdata.cpp
M  +2-2src/lib/util/kformatprivate.cpp

https://commits.kde.org/kcoreaddons/bf353edc42fdecf9fda34a024ba7cabcd0efaf68

diff --git a/src/lib/io/kdirwatch.h b/src/lib/io/kdirwatch.h
index d25f2e9..e0de0b6 100644
--- a/src/lib/io/kdirwatch.h
+++ b/src/lib/io/kdirwatch.h
@@ -86,7 +86,7 @@ public:
  * is added.
  * @param parent the parent of the QObject (or 0 for parent-less 
KDataTools)
  */
-explicit KDirWatch(QObject *parent = nullptr);
+KDirWatch(QObject *parent = nullptr);
 
 /**
  * Destructor.
diff --git a/src/lib/jobs/kjobtrackerinterface.h 
b/src/lib/jobs/kjobtrackerinterface.h
index 4c76ca9..f47dfc9 100644
--- a/src/lib/jobs/kjobtrackerinterface.h
+++ b/src/lib/jobs/kjobtrackerinterface.h
@@ -41,7 +41,7 @@ public:
  *
  * @param parent the parent object
  */
-explicit KJobTrackerInterface(QObject *parent = nullptr);
+KJobTrackerInterface(QObject *parent = nullptr);
 
 /**
  * Destroys a KJobTrackerInterface
diff --git a/src/lib/kaboutdata.cpp b/src/lib/kaboutdata.cpp
index bf4e505..194becf 100644
--- a/src/lib/kaboutdata.cpp
+++ b/src/lib/kaboutdata.cpp
@@ -286,7 +286,6 @@ QString KAboutLicense::text() const
 result = d->_licenseText;
 break;
 }
-Q_FALLTHROUGH()
 // fall through
 default:
 result += QCoreApplication::translate(
diff --git a/src/lib/util/kformatprivate.cpp b/src/lib/util/kformatprivate.cpp
index 3e11c84..c64917d 100644
--- a/src/lib/util/kformatprivate.cpp
+++ b/src/lib/util/kformatprivate.cpp
@@ -372,7 +372,7 @@ QString KFormatPrivate::formatRelativeDate(const QDate 
, QLocale::FormatTyp
 return tr("Invalid date", "used when a relative date string can't be 
generated because the date is invalid");
 }
 
-const qint64 daysTo = QDate::currentDate().daysTo(date);
+const int daysTo = QDate::currentDate().daysTo(date);
 if (daysTo > 7 || daysTo < -7) {
 return m_locale.toString(date, format);
 }
@@ -426,7 +426,7 @@ QString KFormatPrivate::formatRelativeDate(const QDate 
, QLocale::FormatTyp
 
 QString KFormatPrivate::formatRelativeDateTime(const QDateTime , 
QLocale::FormatType format) const
 {
-const qint64 daysTo = QDate::currentDate().daysTo(dateTime.date());
+int daysTo = QDate::currentDate().daysTo(dateTime.date());
 if (daysTo > 7 || daysTo < -7) {
 return m_locale.toString(dateTime, format);
 }

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

[Henrik Fehlauer]

rkflx added a comment.


  In D12333#250194 , @abetts wrote:
  
  > I gave a +1 to the original idea because I feel that there isn't really 
much closeness that you can achieve with the open dialog. It is simple, 
straightforward.
  
  
  I find the pre-patch design also very streamlined.
  
  > If we wanted to do a strict fitt's law follow, then each back and forth 
icon would be next to each of the folders and not in a toolbar.
  
  Let's not throw the baby out with the bath water. Having the navigation 
buttons right above the breadcrumb bar is still better the having them crammed 
in the top left corner.
  
  > But we also have to see that there is stronger merit in organizing and 
looking for symmetry. Symmetry will sometimes help a user more than Fitt's 
guidelines.
  
  This statement may be true in general, but does not fit in our case, as I 
don't see much symmetry here, TBH. Panel and item view occupy most of the 
height, and thus are the most important elements. They are split asymmetrical 
in the horizontal direction, and rightly so. Adding a centered toolbar goes 
against this and breaks up the split, adding even more asymmetry.
  
  Furthermore, users are able to hide the places panel. With the current design 
the spatial relation between buttons and item view stays constant, while with a 
centered approach it will jump around.
  
  > get user feedback.
  
  The file dialog is an important piece of the entire UI. We cannot endlessly 
change things back and forth, we have to get it right by logical thinking the 
first time (in this case it would even be the third time!). In KDE3 it was 
centered, based on feedback from a usability expert it was changed to the 
current design. In terms of //user// feedback, I'm not aware of any huge issue 
users have with it right now.
  
  Do you want to change things around again until there //actually// is 
negative feedback? I'd agree with basing design decisions on user feedback if 
we had better telemetry or did some eye tracking studies, but our current 
method of hearing user's opinions over on Reddit and Bugzilla is not very 
effective in painting a broad picture, IMO.
  
  ---
  
  Anyway, I'll come back to this Diff once the Sort button is in and we decided 
on a final default dialog size. This should make the decision easier, because 
after all the main motivation was to create space for more buttons.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12333

To: ngraham, #frameworks, #dolphin, #vdg
Cc: abetts, jtamate, broulik, anemeth, rkflx, michaelh, bruns

D12371: fix always reproducible crash

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  Don't take ownership of KDirLister in KDirModel.
  When KDirModel is destroyed, it also deleted the dirlister, but 
KCoreDirListerCache didn't knew anything about this deletion, and when it 
consulted listersCurrentlyHolding in slotRedirection resulted always in a crash.
  
  As a side effect, it also fixes the crash I got in D10989 


TEST PLAN
  With samba started locally.
  Execute kwrite
  Press "save as" and go to network, then Samba shared resources, wait for the 
error. Then change to smb://127.0.0.1 and press enter, select a place to save 
the file in the local samba.
  Again press "save as" and go to network, then Samba shared resources. 
  Previously, always crash. 
  Now, again the error message (Next thing to investigate).
  
  In my [limited] tests this doens't introduce memory leaks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12371

AFFECTED FILES
  src/widgets/kdirmodel.cpp
  src/widgets/kdirmodel.h

To: jtamate, dfaure, #frameworks
Cc: michaelh, bruns