KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 45 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/45/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 28 May 2018 05:30:29 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/18/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 28 May 2018 05:30:29 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kglobalsettingstestFailed: TestSuite.ktabwidget_unittest

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.10/5/
 Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 28 May 2018 05:30:29 +
 Build duration:
6 min 39 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kmimetypetestFailed: TestSuite.kstandarddirstest

D12745: Unify API for file descriptor sharing

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  @dfaure can you have a look at this?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12745

To: chinmoyr, dfaure, ossi
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11685: Implement single click on line number to select line of text

[Dominik Haumann]

dhaumann added a comment.


  Ok, thanks!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11685

To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann
Cc: kwrite-devel, kde-frameworks-devel, dhaumann, rkron, mwolff, ngraham, 
#ktexteditor, #kate, #frameworks, michaelh, kevinapavew, bruns, demsking, 
cullmann, sars

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/26/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 28 May 2018 03:31:06 +
 Build duration:
2 min 28 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report24%
(5/21)30%
(17/57)30%
(17/57)21%
(459/2175)21%
(272/1270)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)93%
(144/155)56%
(106/188)src100%
(8/8)100%
(8/8)75%
(227/303)55%
(130/237)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/20)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
  

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 50 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/50/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 28 May 2018 03:31:06 +
 Build duration:
2 min 25 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report24%
(5/21)30%
(17/57)30%
(17/57)20%
(437/2175)20%
(253/1270)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)93%
(144/155)56%
(106/188)src100%
(8/8)100%
(8/8)68%
(205/303)47%
(111/237)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/20)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%

D12992: New elisa icon

[Nathaniel Graham]

ngraham added a comment.


  I like it!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12992

To: lshoravi, #vdg, ngraham, #elisa
Cc: abetts, paullesur, januz, astippich, mgallien, alex-l, andreask, 
kde-frameworks-devel, ssteffen, lcmscheid, nhuisman, ursjoss, mykolak, jussiv, 
michaelh, ngraham, bruns, kmf

D12992: New elisa icon

[Andres Betts]

abetts added a comment.


  I think we are trying hard to accommodate and the elements are not lending 
themselves to turn them into an E with some musical tones. I reviewed a few 
music sheets looking for commonalities. I feel also that the icon is busy, it 
is trying really hard to tell you that this app is about music. I feel we can 
simplify and provide other ideas.
  
  Here is a proposal. Not final. I welcome feedback. The idea here is to show 
soundwaves instead.
  
  F5872565: Elisa Long Form.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12992

To: lshoravi, #vdg, ngraham, #elisa
Cc: abetts, paullesur, januz, astippich, mgallien, alex-l, andreask, 
kde-frameworks-devel, ssteffen, lcmscheid, nhuisman, ursjoss, mykolak, jussiv, 
michaelh, ngraham, bruns, kmf

D12992: New elisa icon

[Diego Gangl]

januz added a comment.


  In D12992#267534 , @lshoravi wrote:
  
  > I agree in that a circle doesn't have as much personality as maybe a
  >  casette. I also agree in that the casette felt off when looking at it.
  >
  > How would something like an LP player with the E on top feel? I won't have
  >  time until Monday (finals coming up), but my gut says that a brown-ish
  >  square with a dark circle (like seeing an LP player from above) with some
  >  iconography on top could look good.
  
  
  Yeah, that could be interesting. Another idea to explore could be replacing 
the green background with a vinyl record, keeping the E on top in white. 
  Also, I think the E would read better if it was open on top (instead of 
curlying on itself). With that change you could also bring back the clef-like 
bottom and it'd still read fine.
  
  @mgallien I'm not sure about youngsters not getting it. There are still bands 
putting out cassettes, and Guardians of the galaxy brought them back to the 
spotlight for a while too. And who knows, maybe in a few decades kids will look 
at cassettes and think they are 3D printed Elisa icons :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12992

To: lshoravi, #vdg, ngraham, #elisa
Cc: paullesur, januz, astippich, mgallien, alex-l, andreask, 
kde-frameworks-devel, ssteffen, lcmscheid, nhuisman, ursjoss, mykolak, jussiv, 
michaelh, ngraham, bruns, kmf

D13150: Add ellipsis where appropriate

[Nicolas Fella]

nicolasfella added a comment.


  Quote from VDG:
  If there will be further user input needed and a dialogue or similar popping 
up for it: needs ellipsis
  
  Therefore Pastebin would not need one, but I guess this is neglectable

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: apol, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

[Nicolas Fella]

nicolasfella added a comment.


  It's done this way in Email, KTP and KDE Connect already. If we add the 
ellipsis in AlternativesModel's DisplayRole we get it on every entry, even if 
it would be inappropriate.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: apol, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/25/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 27 May 2018 22:31:51 +
 Build duration:
1 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report24%
(5/21)30%
(17/57)30%
(17/57)21%
(459/2175)21%
(272/1270)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)93%
(144/155)56%
(106/188)src100%
(8/8)100%
(8/8)75%
(227/303)55%
(130/237)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/20)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
  

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 24 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/24/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 27 May 2018 22:13:45 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltestFailed: TestSuite.menutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report24%
(5/21)30%
(17/57)30%
(17/57)20%
(438/2171)21%
(272/1270)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)89%
(138/155)57%
(108/188)src100%
(8/8)100%
(8/8)73%
(219/300)54%
(129/237)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)55%
(29/53)63%
(30/48)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/20)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
  

D12291: Accept file descriptor only from root owned process

[Oswald Buddenhagen]

ossi added inline comments.

INLINE COMMENTS

> chinmoyr wrote in fdreceiver.cpp:89
> I don't think making acceptConnection unconditionally true is a good idea. At 
> least it will make this patch look horrible.
> Since getsocketopt conforms to posix, how about we check for __ unix __ , and 
> posix compliance instead of __ linux __ and upon failure inform the user to 
> install a posix compliant libc?

i don't see why that would be horrible; as i pointed out multiple times 
already, this change is redundant. one correction, though: add a code comment 
here rather than extending the commit message.

getsockopt() is standard, but the actual options aren't. you could change the 
ifdef to SO_PEERCRED itself, but that wouldn't actually add any portability.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12291

To: chinmoyr, #frameworks, dfaure, ossi
Cc: kde-frameworks-devel, ossi, michaelh, ngraham, bruns

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 49 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/49/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 27 May 2018 22:19:45 +
 Build duration:
6 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report24%
(5/21)30%
(17/57)30%
(17/57)20%
(443/2175)21%
(264/1270)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)97%
(150/155)62%
(117/188)src100%
(8/8)100%
(8/8)68%
(205/303)47%
(111/237)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/20)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 48 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/48/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 27 May 2018 22:13:45 +
 Build duration:
1 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report24%
(5/21)30%
(17/57)30%
(17/57)20%
(437/2175)20%
(253/1270)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)93%
(144/155)56%
(106/188)src100%
(8/8)100%
(8/8)68%
(205/303)47%
(111/237)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/20)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%

D13160: Highlight the selected device in the KDE Connect plugin

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:956efe4cd21f: Highlight the selected device in the KDE 
Connect plugin (authored by nicolasfella).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13160?vs=34988=35003

REVISION DETAIL
  https://phabricator.kde.org/D13160

AFFECTED FILES
  src/plugins/kdeconnect/kdeconnectplugin_config.qml

To: nicolasfella, apol
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D13151: Fix Phabricator icon

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:65f9072a2ec7: Fix Phabricator icon (authored by 
nicolasfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13151?vs=34976=35002#toc

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13151?vs=34976=35002

REVISION DETAIL
  https://phabricator.kde.org/D13151

AFFECTED FILES
  src/plugins/phabricator/phabricatorplugin.json

To: nicolasfella, apol
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D13160: Highlight the selected device in the KDE Connect plugin

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  highlight

REVISION DETAIL
  https://phabricator.kde.org/D13160

To: nicolasfella, apol
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D13158: Fix i18n issues in Phabricator Plugin

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> phabricatorplugin_config.qml:125
>  // use i18n().arg() to avoid showing the "%1" when inactive
> -text: i18n("Summary of the update to %1:").arg(updateDR)
> +text: updateDR != "unknown" && updateDR.length > 0 ? i18n("Summary 
> of the update t %1:").arg(updateDR) : i18n("Summary of the update")
>  enabled: updateOld.checked

Change to `i18n("Summary of the update t %1:", updateDR)`, without .arg().

REPOSITORY
  R495 Purpose Library

BRANCH
  i18n

REVISION DETAIL
  https://phabricator.kde.org/D13158

To: nicolasfella, apol
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

[Aleix Pol Gonzalez]

apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.


  That's not correct. This is the plugin name. If you want elipsis add it onto 
the model's displayrole.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: apol, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D13151: Fix Phabricator icon

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  phabicon

REVISION DETAIL
  https://phabricator.kde.org/D13151

To: nicolasfella, apol
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D11685: Implement single click on line number to select line of text

[Randy Kron]

rkron added a comment.


  Yes, tested and it works.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11685

To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann
Cc: kwrite-devel, kde-frameworks-devel, dhaumann, rkron, mwolff, ngraham, 
#ktexteditor, #kate, #frameworks, michaelh, kevinapavew, bruns, demsking, 
cullmann, sars

D13146: Drop old QString::null usage

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  drop-old-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13146

To: elvisangelaccio, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12992: New elisa icon

[Matthieu Gallien]

mgallien added a subscriber: paullesur.
mgallien added a comment.


  @januz and @astippich I really understand your point of view about the 
current icon. I share your point of view the need to have an icon easy to 
differentiate from many other players. For example, I would like Elisa be easy 
to spot on this page: https://flathub.org/apps/category/AudioVideo .
  
  At the same time, I had an ex colleague, aged 62 or something like that, 
saying that the old icons was bad for youngsters. That really made me hesitate 
about the current icon. I really doubt people under 20 could understand the 
current icon.
  
  Anyway, the current icon seems to need some more work to really look finished 
as has been pointed out.
  
  I will try to show the current icon and this one to another bunch of people 
to collect feedback (people around 22 and older one). My idea is definitely not 
to run a popularity contest here.
  
  I do like the idea to have some sort of classical music notes in the icon 
while still being easy to associate to music. That would reflect on the fact 
that we made quite some work on supporting this use case.
  
  @lshoravi  I appreciate your offer to help like I appreciate the one 
@paullesur did.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12992

To: lshoravi, #vdg, ngraham, #elisa
Cc: paullesur, januz, astippich, mgallien, alex-l, andreask, 
kde-frameworks-devel, ssteffen, lcmscheid, nhuisman, ursjoss, mykolak, jussiv, 
michaelh, ngraham, bruns, kmf

D11685: Implement single click on line number to select line of text

[Dominik Haumann]

dhaumann added a comment.
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel.


  Btw, did anyone test with dynamic word wrap enabled? Does it still work, when 
a line spans multiple view lines?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11685

To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann
Cc: kwrite-devel, kde-frameworks-devel, dhaumann, rkron, mwolff, ngraham, 
#ktexteditor, #kate, #frameworks, michaelh, kevinapavew, bruns, demsking, 
cullmann, sars

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 9 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/9/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 27 May 2018 18:40:10 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 66 test(s)

D13160: Highlight the selected device in the KDE Connect plugin

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REPOSITORY
  R495 Purpose Library

BRANCH
  highlight

REVISION DETAIL
  https://phabricator.kde.org/D13160

AFFECTED FILES
  src/plugins/kdeconnect/kdeconnectplugin_config.qml

To: nicolasfella, apol
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D12513: CVE-2018-10361: privilege escalation

[Christoph Cullmann]

cullmann added a comment.


  > What should we do with this?
  ==

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12513

To: cullmann, dfaure
Cc: kwrite-devel, kde-frameworks-devel, mgerstner, aacid, ngraham, fvogt, 
cullmann, michaelh, kevinapavew, bruns, demsking, sars, dhaumann

D13158: Fix i18n issues in Phabricator Plugin

[Nicolas Fella]

nicolasfella edited the summary of this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13158

To: nicolasfella, apol
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D7245: Improve reStructuredText highlighting

[Dominik Haumann]

dhaumann added a comment.


  @turbov ping  again :-) After adding the reference file in autotest/input, 
run make test, and then call ./autotests/update-reference-data.sh in your build 
folder. Then git status will tell you which files are new and need to be added 
updated.

REVISION DETAIL
  https://phabricator.kde.org/D7245

To: turbov, #kate, #framework_syntax_highlighting, dhaumann
Cc: cullmann, dhaumann, #frameworks, michaelh, ngraham, bruns

D10719: Highlighting for OpenSCAD

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:849aea294446: Highlighting for OpenSCAD (authored by 
dhaumann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10719?vs=28190=34985#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10719?vs=28190=34985

REVISION DETAIL
  https://phabricator.kde.org/D10719

AFFECTED FILES
  autotests/folding/highlight.scad.fold
  autotests/html/highlight.scad.html
  autotests/input/highlight.scad
  autotests/reference/highlight.scad.ref
  data/syntax/openscad.xml

To: julianstirling, dhaumann
Cc: kde-frameworks-devel, dhaumann, ngraham, michaelh, bruns

D13158: Fix i18n issues in Phabricator Plugin

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  When the diffs combo box is empty i18n reports issues. This is a quick and 
dirty fix

REPOSITORY
  R495 Purpose Library

BRANCH
  i18n

REVISION DETAIL
  https://phabricator.kde.org/D13158

AFFECTED FILES
  src/plugins/phabricator/phabricatorplugin_config.qml

To: nicolasfella, apol
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D10719: Highlighting for OpenSCAD

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  Looks good, will integrate!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10719

To: julianstirling, dhaumann
Cc: kde-frameworks-devel, dhaumann, ngraham, michaelh, bruns, #frameworks

D13128: Make sure ungrab keyboard request is processed before emitting shortcut

[Sontol Bonggol]

sontolbonggol added a reviewer: mck182.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D13128

To: sontolbonggol, #frameworks, #plasma, mck182
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13151: Fix Phabricator icon

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  use the right icon name

REPOSITORY
  R495 Purpose Library

BRANCH
  phabicon

REVISION DETAIL
  https://phabricator.kde.org/D13151

AFFECTED FILES
  src/plugins/phabricator/phabricatorplugin.json

To: nicolasfella, apol
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: VDG, apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Add ellipsis to actions that open up a dialog. It doesn't seem to work for 
Twitter, probably because it's different to the other plugins.

REPOSITORY
  R495 Purpose Library

BRANCH
  ellipsis

REVISION DETAIL
  https://phabricator.kde.org/D13150

AFFECTED FILES
  src/plugins/nextcloud/nextcloudplugin.json
  src/plugins/phabricator/phabricatorplugin.json
  src/plugins/reviewboard/reviewboardplugin.json
  src/plugins/twitter/metadata.json

To: nicolasfella, #vdg, apol
Cc: apol, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D12291: Accept file descriptor only from root owned process

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> ossi wrote in fdreceiver.cpp:89
> i wonder whether that shouldn't come with an unconditional acceptConnection = 
> true; then - now the compilation succeeds, but it will fail to operate. given 
> that the whole feature is redundant with moving the socket to a safe place 
> (something you really should mention in the commit message), this seems like 
> a rather pointless limitation.

I don't think making acceptConnection unconditionally true is a good idea. At 
least it will make this patch look horrible.
Since getsocketopt conforms to posix, how about we check for __ unix __ , and 
posix compliance instead of __ linux __ and upon failure inform the user to 
install a posix compliant libc?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12291

To: chinmoyr, #frameworks, dfaure, ossi
Cc: kde-frameworks-devel, ossi, michaelh, ngraham, bruns

D12895: WIP: Add KFileItemActionsPlugin

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> sharefileitemaction.cpp:83
> +m_purposeMenu->model()->setInputData(QJsonObject{
> +{QStringLiteral("mimeType"), fileItemInfos.mimeType()},
> +{QStringLiteral("urls"),

mimeType() can be empty which can cause problems (see D12728 
). Not sure if it will here though

> sharefileitemaction.cpp:91
> +
> +QAction *menuAction = new 
> QAction(QIcon::fromTheme(QStringLiteral("document-share")), i18nc("Share 
> file", "Share"), this);
> +menuAction->setMenu(m_purposeMenu);

You can use m_purposeMenu->menuAction()

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D12895

To: broulik, #plasma, #vdg, apol
Cc: nicolasfella, elvisangelaccio, abetts, ngraham, kde-frameworks-devel, 
michaelh, bruns

D12291: Accept file descriptor only from root owned process

[Oswald Buddenhagen]

ossi added inline comments.

INLINE COMMENTS

> fdreceiver.cpp:89
> +#else
> +#warning Cannot get socket credentials!
> +#endif

i wonder whether that shouldn't come with an unconditional acceptConnection = 
true; then - now the compilation succeeds, but it will fail to operate. given 
that the whole feature is redundant with moving the socket to a safe place 
(something you really should mention in the commit message), this seems like a 
rather pointless limitation.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12291

To: chinmoyr, #frameworks, dfaure, ossi
Cc: kde-frameworks-devel, ossi, michaelh, ngraham, bruns

D12291: Accept file descriptor only from root owned process

[Oswald Buddenhagen]

ossi accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12291

To: chinmoyr, #frameworks, dfaure, ossi
Cc: kde-frameworks-devel, ossi, michaelh, ngraham, bruns

D12291: Accept file descriptor only from root owned process

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  @ossi would you mind reviewing this patch?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12291

To: chinmoyr, #frameworks, dfaure
Cc: kde-frameworks-devel, ossi, michaelh, ngraham, bruns

D12291: Accept file descriptor only from root owned process

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 34966.
chinmoyr added a comment.
Restricted Application added a subscriber: kde-frameworks-devel.


  I only realized now that after making the previous change I forgot to rebase.
  So uploading correct patch.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12291?vs=33776=34966

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12291

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp

To: chinmoyr, #frameworks, dfaure
Cc: kde-frameworks-devel, ossi, michaelh, ngraham, bruns

D12745: Unify API for file descriptor sharing

[Oswald Buddenhagen]

ossi accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12745

To: chinmoyr, dfaure, ossi
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12745: Unify API for file descriptor sharing

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 34965.
chinmoyr edited the summary of this revision.
chinmoyr added a comment.


  Used std::string

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12745?vs=33821=34965

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12745

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, dfaure, ossi
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10409: In linux don't use abstract socket to share file descriptor

[Chinmoy Ranjan Pradhan]

chinmoyr removed a dependency: D10273: Create proper SocketAddress.
Restricted Application added a subscriber: kde-frameworks-devel.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10409

To: chinmoyr, #frameworks, ossi
Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns

D10273: Create proper SocketAddress

[Chinmoy Ranjan Pradhan]

chinmoyr removed a dependent revision: D10409: In linux don't use abstract 
socket to share file descriptor.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10273

To: chinmoyr, #frameworks, dfaure, ossi
Cc: ossi, thiago, dfaure, michaelh, ngraham, bruns

D9966: [KIO] Fix issues with sharing of file descriptor

[Chinmoy Ranjan Pradhan]

chinmoyr removed a dependent revision: D10410: Move the task of cleaning up of 
socket file to file ioslave and FdReceiver.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: kde-frameworks-devel, ngraham, fvogt, lbeltrame, dfaure, michaelh, bruns

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

[Chinmoy Ranjan Pradhan]

chinmoyr removed a dependency: D9966: [KIO] Fix issues with sharing of file 
descriptor.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10410

To: chinmoyr, #frameworks, ossi, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 23 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/23/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 27 May 2018 11:03:24 +
 Build duration:
7 min 54 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report24%
(5/21)30%
(17/57)30%
(17/57)21%
(465/2175)22%
(283/1270)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)97%
(150/155)62%
(117/188)src100%
(8/8)100%
(8/8)75%
(227/303)55%
(130/237)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/20)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%

D9966: [KIO] Fix issues with sharing of file descriptor

[Oswald Buddenhagen]

ossi added a comment.
Restricted Application added a subscriber: kde-frameworks-devel.


  this dependency tree is a mess. please remove deps to abandoned changes or 
unabandon what you actually still need, and linearize the history.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: kde-frameworks-devel, ngraham, fvogt, lbeltrame, dfaure, michaelh, bruns

D13146: Drop old QString::null usage

[Elvis Angelaccio]

elvisangelaccio created this revision.
elvisangelaccio added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
elvisangelaccio requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  drop-old-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13146

AFFECTED FILES
  src/widgets/paste.cpp

To: elvisangelaccio, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13120: fix i18n issues in framworks/purpose/plugins

[Burkhard Lück]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:6ff87ba74f80: fix i18n issues in 
framworks/purpose/plugins (authored by lueck).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13120?vs=34875=34964#toc

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13120?vs=34875=34964

REVISION DETAIL
  https://phabricator.kde.org/D13120

AFFECTED FILES
  src/plugins/email/CMakeLists.txt
  src/plugins/email/Messages.sh
  src/plugins/imgur/CMakeLists.txt
  src/plugins/imgur/Messages.sh
  src/plugins/kdeconnect/CMakeLists.txt
  src/plugins/kdeconnect/Messages.sh
  src/plugins/kdeconnect/kdeconnectplugin_config.qml
  src/plugins/ktp-sendfile/CMakeLists.txt
  src/plugins/ktp-sendfile/Messages.sh
  src/plugins/nextcloud/Messages.sh
  src/plugins/pastebin/CMakeLists.txt
  src/plugins/pastebin/Messages.sh
  src/plugins/phabricator/Messages.sh
  src/plugins/saveas/CMakeLists.txt
  src/plugins/saveas/Messages.sh
  src/plugins/telegram/Messages.sh
  src/plugins/twitter/Messages.sh
  src/plugins/twitter/contents/config/config.qml
  src/plugins/youtube/CMakeLists.txt
  src/plugins/youtube/Messages.sh

To: lueck, #frameworks, #localization, nicolasfella, apol
Cc: aacid, apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 47 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/47/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 27 May 2018 11:03:24 +
 Build duration:
2 min 6 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report24%
(5/21)30%
(17/57)30%
(17/57)20%
(437/2175)20%
(253/1270)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)93%
(144/155)56%
(106/188)src100%
(8/8)100%
(8/8)68%
(205/303)47%
(111/237)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/20)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
 

D12744: Add null pointer check when creating SocketAddress

[Oswald Buddenhagen]

ossi accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12744

To: chinmoyr, dfaure, ossi
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13145: Check if destination exists also when pasting binary data

[Elvis Angelaccio]

elvisangelaccio created this revision.
elvisangelaccio added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  Currently we check whether the destination URL exists only if we are
  pasting text (or if the mimedata has only one format).
  
  If we are pasting e.g. images copied from Spectacle, we unconditionally
  overwrite the destination URL.
  
  This patch moves the StatJob+RenameDialog from `getNewFileName()` to a
  new `getDestinationUrl()` function, which we can also call from 
`chooseFormatAndUrl()`.
  
  BUG: 394318
  FIXED-IN: 5.47

TEST PLAN
  - Paste some image into an existing file and check the rename dialog.
  - Check that pasting text still shows the rename dialog.

REPOSITORY
  R241 KIO

BRANCH
  fix-image-pasting (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13145

AFFECTED FILES
  src/widgets/paste.cpp

To: elvisangelaccio, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

[Oswald Buddenhagen]

ossi accepted this revision.
ossi added a comment.
This revision is now accepted and ready to land.


  note that the commit message needs a minor adjustment now.

INLINE COMMENTS

> chinmoyr wrote in fdreceiver.cpp:57
> So shall I commit this change separately right after pushing this patch? Or 
> after all the related patches are pushed?

the order really doesn't matter here.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10410

To: chinmoyr, #frameworks, ossi, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12744: Add null pointer check when creating SocketAddress

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 34961.
chinmoyr marked 2 inline comments as done.
chinmoyr added a comment.


  fixed the issues mentioned

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12744?vs=33831=34961

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12744

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/kauth/fdsender.cpp

To: chinmoyr, dfaure, ossi
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 34960.
chinmoyr added a comment.


  corrected the unlink position

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10410?vs=34959=34960

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10410

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, #frameworks, ossi, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D9966: [KIO] Fix issues with sharing of file descriptor

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D10410: Move the task of cleaning up of 
socket file to file ioslave and FdReceiver.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh, bruns

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 34959.
chinmoyr marked 2 inline comments as done.
chinmoyr added a dependency: D9966: [KIO] Fix issues with sharing of file 
descriptor.
chinmoyr added a comment.


  Do the first unlink in FdReceiver constructor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10410?vs=33761=34959

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10410

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, #frameworks, ossi, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  SocketAddress is used only in FdSender and FdRecevier.

INLINE COMMENTS

> ossi wrote in fdreceiver.cpp:57
> that's a good addition, but it isn't logically part of this patch, because it 
> adds a new feature (cleanup at exit) instead of only refactoring.

So shall I commit this change separately right after pushing this patch? Or 
after all the related patches are pushed?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10410

To: chinmoyr, #frameworks, ossi, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12745: Unify API for file descriptor sharing

[Oswald Buddenhagen]

ossi added a comment.


  but so does using raw pointers. as the stl is available here anyway, it seems 
like the preferable abstraction layer.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12745

To: chinmoyr, dfaure, ossi
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12745: Unify API for file descriptor sharing

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  In D12745#268946 , @ossi wrote:
  
  > why aren't you standardizing on std::string? that's cleaner than raw char 
pointers.
  >  i know we discussed this before to some degree, but i don't remember the 
particulars.
  
  
  It was pointed out that using std::string made the API stand out a bit (which 
btw is true). That's why I used char pointers here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12745

To: chinmoyr, dfaure, ossi
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12745: Unify API for file descriptor sharing

[Oswald Buddenhagen]

ossi added a comment.


  why aren't you standardizing on std::string? that's cleaner than raw char 
pointers.
  i know we discussed this before to some degree, but i don't remember the 
particulars.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12745

To: chinmoyr, dfaure, ossi
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13124: [RFC] Add Share action to Dolphin context menu

[Nicolas Fella]

nicolasfella added a comment.


  In D13124#268906 , @broulik wrote:
  
  > Have you seen D12895 ?
  
  
  I looked for similar patches with the #dolphin 
 tag, but I didn't see yours

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13124

To: nicolasfella, #dolphin, apol, elvisangelaccio
Cc: broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, 
#dolphin, michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, 
bruns, emmanuelp

D12744: Add null pointer check when creating SocketAddress

[Oswald Buddenhagen]

ossi requested changes to this revision.
ossi added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> fdreceiver.cpp:34
>  {
> +const SocketAddress addr(m_path.toLocal8Bit().constData());
> +if (!addr.address()) {

it would be more elegant to use m_path.toLocal8Bit().toStdString() here.

> fdsender.cpp:29
>  {
> +const SocketAddress addr(path.c_str());
> +if (!addr.address()) {

you're changing the type you're using for the call here. that's a good change, 
but logically not part of this patch.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12744

To: chinmoyr, dfaure, ossi
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10411: Create socket file in user's runtime directory

[Oswald Buddenhagen]

ossi accepted this revision.
Restricted Application added a subscriber: kde-frameworks-devel.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10411

To: chinmoyr, #frameworks, ossi
Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

[Oswald Buddenhagen]

ossi requested changes to this revision.
ossi added a comment.
This revision now requires changes to proceed.


  did you make sure that this is the only place where SocketAddress is used?

INLINE COMMENTS

> fdreceiver.cpp:41
>  const SocketAddress addr(path.toStdString());
>  if (bind(m_socketDes, addr.address(), addr.length()) != 0 || 
> listen(m_socketDes, 5) != 0) {
>  std::cerr << "bind/listen error:" << strerror(errno) << std::endl;

do the first unlink right before here, so it's equivalent with the old code, 
just better structured.

> fdreceiver.cpp:57
>  }
> +::unlink(m_path.toLocal8Bit().constData());
>  }

that's a good addition, but it isn't logically part of this patch, because it 
adds a new feature (cleanup at exit) instead of only refactoring.

> file_unix.cpp:87
>  const QString sockPath = socketPath();
> +QFile::remove(sockPath);
>  FdReceiver fdRecv(sockPath);

that's the wrong place, imo. leave it FdReceiver, so it's more local.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10410

To: chinmoyr, #frameworks, ossi, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13124: [RFC] Add Share action to Dolphin context menu

[Kai Uwe Broulik]

broulik added a comment.


  Have you seen D12895 ?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13124

To: nicolasfella, #dolphin, apol, elvisangelaccio
Cc: broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, 
#dolphin, michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, 
bruns, emmanuelp