KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/41/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 08 Aug 2018 17:37:32 + Build duration: 6 hr 14 min and counting JUnit Tests

D13782: RFC: Ignore NTFS hidden flag for root volume

ngraham added a comment. @broulik? Is it ready to land? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13782 To: broulik, dfaure, yurikoles, bruns Cc: ngraham, oysteins, wbauer, kde-frameworks-devel, michaelh, bruns

D13782: RFC: Ignore NTFS hidden flag for root volume

oysteins added a comment. I cannot speak for the code, but this seems to work perfectly well when I tested it today. I used Kate and KBackup to open some files/directories on an external NTFS, and used KBackup to write a backup to the drive. I didn't have to check 'Show hidden folders' and

D10040: Add serial number and EISA ID to OutputDevice interface

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:f3378c6808e4: Add serial number and EISA ID to OutputDevice interface (authored by dvratil, committed by

D14505: Sync set/send/update methods

This revision was automatically updated to reflect the committed changes. Closed by commit R127:9e0d814bc62c: Sync set/send/update methods (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14505?vs=38819=39323 REVISION DETAIL

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 49 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/49/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Wed, 08 Aug 2018 17:37:32 + Build duration: 6 min 1 sec and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 76 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/76/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Wed, 08 Aug 2018 17:37:32 + Build duration: 4 min 11 sec and counting JUnit Tests

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.10/15/ Project: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 08 Aug 2018 17:37:07 + Build duration: 50 sec and counting JUnit Tests

D13032: Fix cleanup of kconfigtest kdeglobals

This revision was automatically updated to reflect the committed changes. Closed by commit R237:499edcea2576: Fix cleanup of kconfigtest kdeglobals (authored by davidedmundson). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13032?vs=34627=39320 REVISION

D14505: Sync set/send/update methods

romangg accepted this revision. romangg added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > outputdevice_interface.cpp:656 > Q_D(); > d->edid = edid; > +d->updateEdid(); Check for equality here as well? REPOSITORY R127 KWayland REVISION

D10040: Add serial number and EISA ID to OutputDevice interface

romangg accepted this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10040 To: davidedmundson, graesslin, sebas, #kwin, dvratil, romangg Cc: romangg, kde-frameworks-devel, davidedmundson, plasma-devel, ragreen, Pitel, schernikov, michaelh, ZrenBot, ngraham,

D14674: handle non-ASCII encodings of file names in tar archives

xyquadrat added a comment. Two links that might be useful when writing the unit test: https://community.kde.org/Guidelines_and_HOWTOs/UnitTests https://wiki.qt.io/Writing_Unit_Tests Also, there are already a few unit tests in this repo that you could take a look at. Thank you for

D14161: [KStyle] Use dialog-question for question icon

ngraham added a comment. In D14161#294031 , @rkflx wrote: > Thanks for noticing, LGTM and restores the proper icon indeed. > > > This was changed in `KMessageBox` in 9b05a12a43dbe2b31a4655052f20de0832ac7a61

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 115 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/115/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 08 Aug 2018 13:49:01 + Build duration: 5 min 22 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 114 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/114/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 08 Aug 2018 13:43:13 + Build duration: 5 min 46 sec and counting JUnit Tests

D14692: Use custom QScrollArea with size hint not limited by font size

ngraham accepted this revision. ngraham added a comment. Thanks! REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D14692 To: valeriymalov, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14692: Use custom QScrollArea with size hint not limited by font size

valeriymalov updated this revision to Diff 39313. valeriymalov added a comment. - add link to qt bug REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14692?vs=39308=39313 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14692 AFFECTED FILES

D14579: api for multi level kcms

mart abandoned this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D14579 To: mart, #plasma, #frameworks Cc: abetts, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14663: Give the "invalid directory name" dialog a cancel button

This revision was automatically updated to reflect the committed changes. Closed by commit R241:63178e2fe045: Give the invalid directory name dialog a cancel button (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14663?vs=39275=39311

D14580: support for multi pages kcms

mart updated this revision to Diff 39310. mart added a comment. - paint internally the title and breadcrumb REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14580?vs=39018=39310 BRANCH mart/multipageKCM REVISION DETAIL

D14692: Use custom QScrollArea with size hint not limited by font size

ngraham added a comment. OK, great! Could you add a comment in the code indicating that the custom scrollview is a workaround for that bug? REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D14692 To: valeriymalov, #frameworks, ngraham Cc: ngraham,

D14692: Use custom QScrollArea with size hint not limited by font size

valeriymalov added a comment. I think it's this bug/suggestion: https://bugreports.qt.io/browse/QTBUG-10459 REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D14692 To: valeriymalov, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, michaelh,

D14692: Use custom QScrollArea with size hint not limited by font size

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Wow, this works perfectly for me. I banged my head against this by trying to pass the sizeHint to the existing scrollview, so it makes sense to me know to know that a regular scrollView

D14692: Use custom QScrollArea with size hint not limited by font size

valeriymalov added a reviewer: Frameworks. valeriymalov added a comment. Context for the size hint limitation this patch is supposed to circumvent: https://code.woboq.org/qt5/qtbase/src/widgets/widgets/qscrollarea.cpp.html#403 REPOSITORY R295 KCMUtils REVISION DETAIL

D14692: Use custom QScrollArea with size hint not limited by font size

valeriymalov created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. valeriymalov requested review of this revision. REVISION SUMMARY For some reason original QScrollArea has constraint on a size hint This

D14689: [KFileItem] Don't read directory comment on slow mounts

broulik added a comment. Even `isSlow()` causes blockage as that does `KFileSystemType::fileSystemType` which then blocks in `statfs64` :( (this patch still makes sense imho) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14689 To: broulik, #frameworks, dfaure,

KDE CI: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.10 - Build # 43 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsMSVCQt5.10/43/ Project: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.10 Date of build: Wed, 08 Aug 2018 09:49:48 + Build duration: 1 hr 17 min and counting

D13032: Fix cleanup of kconfigtest kdeglobals

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D13032 To: davidedmundson, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks oxygen-icons5 kf5-qt5 WindowsMSVCQt5.10 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20oxygen-icons5%20kf5-qt5%20WindowsMSVCQt5.10/20/ Project: Frameworks oxygen-icons5 kf5-qt5 WindowsMSVCQt5.10 Date of build: Wed, 08 Aug 2018 09:36:08 + Build duration: 1 hr 15 min and counting

D14162: Figure out the escaped path list on kconfig

dfaure added a comment. Can we split this into two commits then? The bugfix (which certainly seems fine to me), and the optimization (which is separate and needs to be measured for increased CPU usage, and alternative solutions like QStringRef). REPOSITORY R237 KConfig REVISION DETAIL

D14689: [KFileItem] Don't read directory comment on slow mounts

broulik created this revision. broulik added reviewers: Frameworks, dfaure, lbeltrame. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Doing so might block the UI. We

D14162: Figure out the escaped path list on kconfig

apol added a comment. Correct, I wanted to fix all the allocations as the commit message says, then I realised it wasn't even working well when I added the unit test, so I fixed that too. The problem with the allocation is that it's allocating for the remaining part of the field and

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 43 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/43/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 Date of build: Wed, 08 Aug 2018 09:49:48 + Build duration: 5 min 45 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 99 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/99/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Wed, 08 Aug 2018 09:49:48 + Build duration: 3 min 23 sec and counting JUnit Tests

D12872: ScalableTest, add "scalable" plasma-browser-integration

dfaure closed this revision. dfaure added a comment. Pushed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12872 To: maximilianocuria, #frameworks, dfaure, andreaska, andreask, ngraham Cc: heikobecker, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.10/19/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 08 Aug 2018 09:49:48 + Build duration: 1 min 7 sec and counting JUnit

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 113 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/113/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 08 Aug 2018 09:39:58 + Build duration: 5 min 12 sec and counting JUnit Tests

D14686: API docs: fix *xi18n* calls in example code to use correct variants

This revision was automatically updated to reflect the committed changes. Closed by commit R249:db10b5a3eb4e: API docs: fix *xi18n* calls in example code to use correct variants (authored by kossebau). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE

D14686: API docs: fix *xi18n* calls in example code to use correct variants

ilic accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH fixxi18ncallexamples REVISION DETAIL https://phabricator.kde.org/D14686 To: kossebau, ilic Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14686: API docs: fix *xi18n* calls in example code to use correct variants

kossebau created this revision. kossebau added a reviewer: ilic. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R249 KI18n BRANCH fixxi18ncallexamples REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 112 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/112/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 08 Aug 2018 09:15:43 + Build duration: 7 min 47 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 111 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/111/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 08 Aug 2018 08:06:47 + Build duration: 1 hr 8 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 357 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/357/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 08 Aug 2018 08:26:13 + Build duration: 9 min 54 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 202 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/202/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Wed, 08 Aug 2018 08:26:13 + Build duration: 10 min and counting JUnit Tests Name: (root)

D14663: Give the "invalid directory name" dialog a cancel button

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D14663 REVISION DETAIL https://phabricator.kde.org/D14663 To: ngraham, #vdg, #frameworks, elvisangelaccio, #dolphin, dfaure Cc: kde-frameworks-devel, michaelh, ngraham,

D13584: KFormat: Replace byte specific implementation with generic one

dfaure added a comment. I don't really know this code, but one thing that could be done to ensure that the change is safe, is to increase unittest coverage (which is already not too bad, but more would be safer)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 201 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/201/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Wed, 08 Aug 2018 08:06:47 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 356 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/356/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 08 Aug 2018 08:06:47 + Build duration: 10 min and counting JUnit Tests Name: (root)

D14674: handle non-ASCII encodings of file names in tar archives

dfaure added a comment. Looks good, but indeed a unittest addition would be very welcome. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D14674 To: ibragimovrinat, dfaure, kossebau Cc: broulik, cfeck, ibragimovrinat, kde-frameworks-devel, michaelh, ngraham, bruns

D14662: KPropertiesDialog: switch to label in setFileNameReadOnly(true)

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14662 To: dfaure, rkflx, shubham, ngraham Cc: bruns, michaelh, kde-frameworks-devel, ngraham

D14666: Fixes memory leak in KUrlComboBox::setUrl

dfaure added a comment. Yes, I think you should apply for one. You can quote my name when the form asks who recommended you. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D14666 To: hallas, dfaure Cc: dfaure, kde-frameworks-devel, michaelh, ngraham,

D14308: [Exe Thumbnailer] Improve icon selection algorithm

broulik added a comment. The code doesn't compile and I don't understand it well enough to fix that. I tried but now I have it pick 16x16 every time REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14308 To: broulik, #frameworks, dfaure, ngraham, pali, vonreth,

D14662: KPropertiesDialog: switch to label in setFileNameReadOnly(true)

dfaure added inline comments. INLINE COMMENTS > rkflx wrote in kpropertiesdialog.cpp:853 > Just out of interest (don't change anything): I assume you don't fully > transition everything to `d->m_grid` to keep the diff small, or because > `grid` is more readable? Yeah, a bit of both, mostly to

D14662: KPropertiesDialog: switch to label in setFileNameReadOnly(true)

rkflx accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH kpropsdlg REVISION DETAIL https://phabricator.kde.org/D14662 To: dfaure, rkflx, shubham, ngraham Cc: bruns, michaelh, kde-frameworks-devel, ngraham

D14666: Fixes memory leak in KUrlComboBox::setUrl

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Very nice work, thanks! Do you have a KDE contributor account, to push this commit? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D14666 To:

D14662: KPropertiesDialog: switch to label in setFileNameReadOnly(true)

dfaure updated this revision to Diff 39291. dfaure added a comment. Handle multiple calls to setFileNameReadOnly(true), just in case. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14662?vs=39232=39291 BRANCH kpropsdlg REVISION DETAIL

D14162: Figure out the escaped path list on kconfig

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. No, I don't think I mean that. The code in kconfiggroup is already iterating over one character at a time and handling escapes and wait, what are we fixing here exactly?

D14666: Fixes memory leak in KUrlComboBox::setUrl

hallas added a comment. In D14666#305209 , @dfaure wrote: > Very nice work, thanks! > > Do you have a KDE contributor account, to push this commit? No, not yet - do you think I should apply for one? I would really like to continue

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 68 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/68/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 Date of build: Wed, 08 Aug 2018 07:32:42 + Build duration: 2 min 11 sec and counting JUnit

D14161: [KStyle] Use dialog-question for question icon

This revision was automatically updated to reflect the committed changes. Closed by commit R252:baf011a72ffc: [KStyle] Use dialog-question for question icon (authored by broulik). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE

D14397: Support libcanberra for audio notification

This revision was automatically updated to reflect the committed changes. Closed by commit R289:f03443cfb2b9: Support libcanberra for audio notification (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14397?vs=38843=39289#toc REPOSITORY R289 KNotifications

D14160: [KMessageBox] Call style for icon

This revision was automatically updated to reflect the committed changes. Closed by commit R236:c6be3760ecd0: [KMessageBox] Call style for icon (authored by broulik). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14160?vs=37883=39288 REVISION DETAIL