D14308: [Exe Thumbnailer] Improve icon selection algorithm

bruns added a comment. qreal distance(int width, int height, int desiredWidth, int desiredHeight) { auto targetSamples = desiredWidth * desiredHeight; auto xscale = (1.0 * desiredWidth) / width; auto yscale = (1.0 * desiredHeight) / height; // clamp

D14639: Add syntax-highlighting for RDoc (R documentation)

aaronpuchert added a subscriber: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14639 To: aaronpuchert, dhaumann, cullmann Cc: #framework_syntax_highlighting, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew,

D14674: handle non-ASCII encodings of file names in tar archives

ibragimovrinat added inline comments. INLINE COMMENTS > cfeck wrote in ktar.cpp:777 > Does the spec say `> 99` or `> 100`? The comment and the code should match. The comment is right in some sense, 100 bytes means 99 bytes of name and 1 byte of '\0'. I don't know for sure if there is a

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/59/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Thu, 09 Aug 2018 14:24:53 + Build duration: 11 min and counting JUnit

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/33/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 Date of build: Thu, 09 Aug 2018 14:24:53 + Build duration: 5 min 13 sec and counting JUnit

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 120 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/120/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 09 Aug 2018 14:25:13 + Build duration: 2 min 51 sec and counting

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.10/19/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 09 Aug 2018 14:24:53 + Build duration: 2 min 29 sec and counting

D14689: [KFileItem] Don't read directory comment on slow mounts

This revision was automatically updated to reflect the committed changes. Closed by commit R241:3b39f63af50b: [KFileItem] Dont read directory comment on slow mounts (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14689?vs=39348=39356

D14457: Forward-declare X509 structure

dfaure closed this revision. dfaure added a comment. Fix pushed as https://commits.kde.org/kdelibs4support/c3fe9344a8e7be1347e97523da19b5395ce9b3db REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D14457 To: luc4, #frameworks, cfeck, dfaure Cc: dfaure,

D14457: Forward-declare X509 structure

luc4 edited the summary of this revision. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D14457 To: luc4, #frameworks, cfeck, dfaure Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14707: autotests: skip '/' fstab check with zfs

dfaure added a comment. OK maybe I misunderstood the comment "Welcome to the wondeful world of / on zfs with boot-environments :)." If it's not related to zfs then two options: 1. allowing for no root possible mountpoint, as you suggest, but I don't like it, it could hide a major

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

rkflx accepted this revision. rkflx added a comment. @muhlenpfordt I'd say go ahead with landing (after updating the version). It would be good to still have some testing time before the next Frameworks release. (The new Neon seems to be just around the corner, AFAICS.) REPOSITORY

KDE CI: Frameworks kpackage kf5-qt5 AndroidQt5.11 - Build # 11 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20AndroidQt5.11/11/ Project: Frameworks kpackage kf5-qt5 AndroidQt5.11 Date of build: Thu, 09 Aug 2018 13:06:43 + Build duration: 2 min 43 sec and counting CONSOLE

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 45 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/45/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.9 Date of build: Thu, 09 Aug 2018 13:06:43 + Build duration: 1 min 17 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.10/17/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 09 Aug 2018 13:06:43 + Build duration: 45 sec and counting JUnit Tests

D14707: autotests: skip '/' fstab check with zfs

bruns added a comment. In D14707#305749 , @dfaure wrote: > Yes it does, and that's where I get the "zfs" information from. > > But the test that fails is in the following method, which uses possibleMountPoints() i.e. fstab. Yes, I

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/43/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Thu, 09 Aug 2018 12:24:53 + Build duration: 7 min 28 sec and counting JUnit Tests

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.10 - Build # 18 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.10/18/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 09 Aug 2018 12:24:53 + Build duration: 4 min 15 sec and counting JUnit Tests

D14457: Forward-declare X509 structure

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK, now we're getting somewhere. If ssl-dev isn't installed, this code is compiled without SSL support, and fails ksslcertificate.h:387:18: error: ‘X509’ has not been declared

D14707: autotests: skip '/' fstab check with zfs

dfaure added a comment. Yes it does, and that's where I get the "zfs" information from. But the test that fails is in the following method, which uses possibleMountPoints() i.e. fstab. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14707 To: dfaure Cc: bruns,

D14689: [KFileItem] Don't read directory comment on slow mounts

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Yep, exactly. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14689 To: broulik, #frameworks, dfaure, lbeltrame Cc: anthonyfieroni, kde-frameworks-devel, michaelh,

D14707: autotests: skip '/' fstab check with zfs

bruns added a comment. But doesn't KMountPoint::currentMountPoints() use mtab? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14707 To: dfaure Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D14689: [KFileItem] Don't read directory comment on slow mounts

broulik updated this revision to Diff 39348. broulik added a comment. - Move check `isDirectoryMounted` creates a `QFileInfo` on the url anyway, so both are prone to block, doesn't really matter which way round, does it? REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kpackage kf5-qt5 AndroidQt5.11 - Build # 10 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20AndroidQt5.11/10/ Project: Frameworks kpackage kf5-qt5 AndroidQt5.11 Date of build: Thu, 09 Aug 2018 11:38:47 + Build duration: 3 min 0 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 44 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/44/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.9 Date of build: Thu, 09 Aug 2018 11:38:47 + Build duration: 2 min 52 sec and counting CONSOLE OUTPUT

D14457: Forward-declare X509 structure

luc4 added a comment. When QT_NO_OPENSSL is defined, I see that X509 was declared as a class, so I used the same instruction. In ksslconfig.h I have `#define KSSL_HAVE_SSL 0`. I don't know if I can recovery much more output, the build succeeded days ago. Unfortunately I'm not an expert

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.10/16/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 09 Aug 2018 11:38:47 + Build duration: 1 min 8 sec and counting JUnit Tests

D9387: Add cross compile support for kconfig_compiler and kconf_update.

habacker added a comment. In D9387#305685 , @dfaure wrote: > > I don't know much about all this, but it sounds like Aleix is saying that an existing solution also works and is simpler. Please show me that solution with a

D14707: autotests: skip '/' fstab check with zfs

dfaure created this revision. Restricted Application added a project: Frameworks. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. dfaure requested review of this revision. REVISION SUMMARY Tobias C. Berner says the vm builders set their root via the

D9387: Add cross compile support for kconfig_compiler and kconf_update.

dfaure added a comment. That doesn't mean it's the right solution :-) I don't know much about all this, but it sounds like Aleix is saying that an existing solution also works and is simpler. Sounds worth investigating before "blindly" implementing a second way to do the same, even if

D13584: KFormat: Replace byte specific implementation with generic one

safaalfulaij added a comment. Can we please take a look at this before continuing here? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13584 To: bruns, #frameworks Cc: safaalfulaij, dfaure, astippich,

D9387: Add cross compile support for kconfig_compiler and kconf_update.

habacker added a comment. This patch is used at https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win32:KF547/mingw32-kconfig https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win64:KF547/mingw64-kconfig for about a year

D14457: Forward-declare X509 structure

dfaure added a comment. The reason I don't like it, is that X509 isn't a class ;-) Here in ksslconfig.h (generated file) I have `#define KSSL_HAVE_SSL 1`. Why is `find_package(OpenSSL)` failing for you? Any output from cmake? REPOSITORY R239 KDELibs4Support REVISION DETAIL

D14457: Forward-declare X509 structure

luc4 added a comment. In D14457#304135 , @dfaure wrote: > Can you explain why in the commit log, not just what? The diff tells us what already, but why? I assume this fixes a compilation error? Which one, on which platform? Thanks.

D14457: Forward-declare X509 structure

luc4 edited the summary of this revision. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D14457 To: luc4, #frameworks, cfeck, dfaure Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D13743: Migrate build system to use find_package in autotests/ki18n_install

This revision was automatically updated to reflect the committed changes. Closed by commit R249:507415c54bd1: Migrate build system to use find_package in autotests/ki18n_install (authored by habacker). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13743?vs=38569=39339#toc REPOSITORY

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 119 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/119/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 09 Aug 2018 09:46:20 + Build duration: 10 min and counting JUnit Tests Name:

D13743: Migrate build system to use find_package in autotests/ki18n_install

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Ah, I see. This fails indeed: CMake Error at CMakeLists.txt:4 (include): include could not find load file: KF5I18nMacros REPOSITORY R249 KI18n BRANCH master

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 207 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/207/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Thu, 09 Aug 2018 09:01:10 + Build duration: 38 min and counting JUnit Tests Name: (root)

Re: purpose unittest (AlternativesModelTest::runJobTest) fails randomly

On lundi 6 août 2018 10:52:52 CEST Ben Cooksley wrote: > On Mon, Aug 6, 2018 at 7:27 PM, David Faure wrote: > > On lundi 6 août 2018 01:18:44 CEST Aleix Pol wrote: > >> On Sat, Aug 4, 2018 at 12:31 PM David Faure wrote: > >> > Any idea about this test that fails sometimes? Timing issue? The

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 118 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/118/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 09 Aug 2018 09:12:05 + Build duration: 12 min and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 74 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/74/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Thu, 09 Aug 2018 09:09:10 + Build duration: 3 min 56 sec and counting JUnit Tests Name:

D13782: Ignore NTFS hidden flag for root volume

broulik added inline comments. INLINE COMMENTS > wbauer wrote in file_unix.cpp:567 > This still doesn't handle symlinks. > E.g. if you create a symlink to the NTFS partition's mount point/root dir on > your desktop, it will still be hidden. > > As mentioned, `const QString fullFilePath =

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 117 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/117/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 09 Aug 2018 09:01:10 + Build duration: 10 min and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 97 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/97/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Thu, 09 Aug 2018 09:09:10 + Build duration: 1 min 51 sec and counting JUnit Tests

D14702: Java: add binaries & hex-float, and support underscores in numbers

nibags added reviewers: dhaumann, cullmann, vkrause, Kate. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14702 To: nibags, dhaumann, cullmann, vkrause, #kate Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking,

D14702: Java: add binaries & hex-float, and support underscores in numbers

nibags created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Some improvements in the highlighting of literal numbers: - BUG

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 116 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/116/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 09 Aug 2018 07:47:14 + Build duration: 1 hr 5 min and counting JUnit Tests Name:

D13782: Ignore NTFS hidden flag for root volume

wbauer added inline comments. INLINE COMMENTS > file_unix.cpp:567 > +if (ep->d_type == DT_DIR || ep->d_type == DT_UNKNOWN) { > +const QString fullFilePath = > QDir::cleanPath(QDir().absoluteFilePath(filename)); > +auto

D9387: Add cross compile support for kconfig_compiler and kconf_update.

habacker added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. ping REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9387 To: habacker, dfaure, ltoscano, bcooksley, apol Cc: kde-frameworks-devel, apol,

D14689: [KFileItem] Don't read directory comment on slow mounts

anthonyfieroni added inline comments. INLINE COMMENTS > dfaure wrote in kfileitem.cpp:816 > Shouldn't you check isSlow() at the end of the condition, or at least after > isDir()? This way it wouldn't be checked for non-directories (you say it > takes time...). +1, at end will be better.

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 206 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/206/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Thu, 09 Aug 2018 07:47:14 + Build duration: 5 min 21 sec and counting JUnit Tests Name:

D13743: Migrate build system to use find_package in autotests/ki18n_install

habacker added a comment. In D13743#304127 , @dfaure wrote: > I don't understand either, what does this fix? The macro file is intended to be used by client packages and is normally fetched by KI18nConfig.cmake, which is provided with

D14689: [KFileItem] Don't read directory comment on slow mounts

dfaure added inline comments. INLINE COMMENTS > kfileitem.cpp:816 > // Support for .directory file in directories > -if (isLocalUrl && isDir() && isDirectoryMounted(url)) { > +if (isLocalUrl && !d->isSlow() && isDir() && isDirectoryMounted(url)) { > QUrl u(url); Shouldn't

D13782: Ignore NTFS hidden flag for root volume

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13782 To: broulik, dfaure, yurikoles, bruns Cc: ngraham, oysteins, wbauer, kde-frameworks-devel, michaelh, bruns

D13782: Ignore NTFS hidden flag for root volume

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f6df95e595ee: Ignore NTFS hidden flag for root volume (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13782?vs=39331=39332 REVISION DETAIL

D13743: Migrate build system to use find_package in autotests/ki18n_install

habacker added a comment. In D13743#298834 , @apol wrote: > Looks good to me, I don't really see why it's better though... This way you can find problems that are normally detected by client packages simply by running make test

D13782: Ignore NTFS hidden flag for root volume

broulik updated this revision to Diff 39331. broulik retitled this revision from "RFC: Ignore NTFS hidden flag for root volume" to "Ignore NTFS hidden flag for root volume". broulik added a comment. - Rebase - use `QDir().absoluteFilePath()` REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE