D15999: Add icons with added background to system.svgz

pstefan added a comment. In D15999#369135 , @ndavis wrote: > In D15999#369134 , @pstefan wrote: > > > In D15999#369132 , @ndavis wrote: > > > > > In D1

D15999: Add icons with added background to system.svgz

ndavis added a comment. In D15999#369134 , @pstefan wrote: > In D15999#369132 , @ndavis wrote: > > > In D15999#369131 , @pstefan wrote: > > > > > In D15

D15999: Add icons with added background to system.svgz

pstefan added a comment. In D15999#369132 , @ndavis wrote: > In D15999#369131 , @pstefan wrote: > > > In D15999#369066 , @ndavis wrote: > > > > > With

D17028: Loader: Avoid Q_FOREACH

loh.tar added a comment. >> @cfeck wrote: > > It looked strange on the list of names of all committers. A look at your page indicates that you are doing some public relations? Should you copy&paste some data from an auto generated list, feel free to remove me. REPOSITORY R246 Son

D15999: Add icons with added background to system.svgz

ndavis added a comment. In D15999#369131 , @pstefan wrote: > In D15999#369066 , @ndavis wrote: > > > With colorschemes applied, these will be your colors: > > > > | Ring| Backgro

D15999: Add icons with added background to system.svgz

pstefan added a comment. In D15999#369066 , @ndavis wrote: > With colorschemes applied, these will be your colors: > > | Ring| Background | Symbol | > | --- | -- | --- | >Breeze | #f

D17274: Remove duplicated code for rating property

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17274 To: bruns, #baloo, #frameworks, ngraham, poboiko Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, n

D17272: Fix searches for rating 10 (5 stars)

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LOL whoops! Nice catch. Works great. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17272 To: bruns, #baloo, #frameworks, ngraham, poboiko, mgallien Cc: kde-frame

D17273: Extend unit tests to check comparisons of multi-digit numeric properties

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17273 To: bruns, #baloo, #frameworks, ngraham, poboiko, mgallien Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D16617: fix extraction of GPS altitude for exif data

bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > exiv2extractor.cpp:217 > > if (altitude) { > result->add(Property::PhotoGpsAltitude, altitude); This is bogus, why am I not allowed to take photos at sea

D17272: Fix searches for rating 10 (5 stars)

bruns added a dependent revision: D17274: Remove duplicated code for rating property. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17272 To: bruns, #baloo, #frameworks, ngraham, poboiko, mgallien Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ng

D17274: Remove duplicated code for rating property

bruns added a dependency: D17272: Fix searches for rating 10 (5 stars). REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17274 To: bruns, #baloo, #frameworks, ngraham, poboiko Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17274: Remove duplicated code for rating property

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The rating can be handled like any other integer valued pr

D17272: Fix searches for rating 10 (5 stars)

bruns updated this revision to Diff 46593. bruns added a comment. Use qlonglong for comparing numeric properties REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17272?vs=46591&id=46593 REVISION DETAIL https://phabricator.kde.org/D17272 AFFECTED FILES aut

D17273: Extend unit tests to check comparisons of multi-digit numeric properties

bruns added a dependency: D17272: Fix searches for rating 10 (5 stars). REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17273 To: bruns, #baloo, #frameworks, ngraham, poboiko, mgallien Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D17272: Fix searches for rating 10 (5 stars)

bruns added a dependent revision: D17273: Extend unit tests to check comparisons of multi-digit numeric properties. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17272 To: bruns, #baloo, #frameworks, ngraham, poboiko, mgallien Cc: kde-frameworks-devel, ashaposhnikov, mi

D17273: Extend unit tests to check comparisons of multi-digit numeric properties

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko, mgallien. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The unit test only checked for single digit valu

D17272: Fix searches for rating 10 (5 stars)

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko, mgallien. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The comparator callback/lambda used a string com

D15999: Add icons with added background to system.svgz

ndavis added a comment. With colorschemes applied, these will be your colors: | Ring| Background | Symbol | | --- | -- | --- | Breeze | #fcfcfc | #eff0f1| #232627 | Breeze Dark | #232629 | #31363b| #eff0f1 | REPOSITOR

D17270: [KUrlNavigator] List subdirs of a parent folder of an archive

gregormi added inline comments. INLINE COMMENTS > kurlnavigatorbutton.cpp:414 > +url = KIO::upUrl(m_url); > +} else if ((m_url.scheme() == QLatin1String("tar")) || (m_url.scheme() > == QLatin1String("zip"))) { > +// We are in an archive, check whether the subdir we have to li

D17270: [KUrlNavigator] List subdirs of a parent folder of an archive

thsurrel updated this revision to Diff 46589. thsurrel added a comment. Fix deleted empty line. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17270?vs=46588&id=46589 BRANCH arc_urlnavigatorbutton (branched from master) REVISION DETAIL https://phabricator

D17270: [KUrlNavigator] List subdirs of a parent folder of an archive

thsurrel created this revision. thsurrel added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REVISION SUMMARY When we are navigating in an archive, trying to use the navigator buttons to

D17028: Loader: Avoid Q_FOREACH

loh.tar added a comment. > ..but I cannot remember we didn't ask contributors for their real name for contributions. Um, what? I was asked. I hope it's ok as it is. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17028 To: loh.tar, davidedmundson Cc: cfeck, sm

D17220: Improve symbolism for off and muted status icon

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17220 To: trickyricky26, #vdg, ndavis Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Improve symbolism for off and muted status icon

trickyricky26 updated this revision to Diff 46587. trickyricky26 added a comment. - enlarge muted symbol in 22px microphone-sensitivity-muted icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17220?vs=46577&id=46587 BRANCH streamline-muted-off (br

D17220: Improve symbolism for off and muted status icon

trickyricky26 planned changes to this revision. trickyricky26 added a comment. I will make changes to the muted symbol in the microphone icons as well REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17220 To: trickyricky26, #vdg, ndavis Cc: abetts, ndavis, ngrah

D17028: Loader: Avoid Q_FOREACH

cfeck added a comment. I do not know if there is a written rule that we require commits with real names (for legal reasons), but I cannot remember we didn't ask contributors for their real name for contributions. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17028

D17204: BrightScript: Allow sub to be unnamed

dlevin added a comment. This language does not have folding test. I did not provide validation for it before. Should I do that? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17204 To: dlevin, cullmann Cc: dfaure, kwrite-devel, kde-frameworks-devel, has

D17269: Fix build failure in neon by adding QVariant include.

scarlettclark updated this revision to Diff 46584. scarlettclark added a comment. Remove class QVariant as per bruns review comment. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17269?vs=46581&id=46584 BRANCH master REVISION DETAIL https://phabr

D15999: Add icons with added background to system.svgz

pstefan updated this revision to Diff 46583. pstefan added a comment. - Remove hardcoded background color; Switch background to "ColorScheme-ViewBackground" - Reintroduce the outline border on top of the background. Opacity set to 0.3 - Removed superfluous entries in the style properties

D17245: Add string formatting function to property info

bruns added inline comments. INLINE COMMENTS > astippich wrote in formatstrings.cpp:83 > How about using the descriptions from D15503 > , which are also consistent with digiKam > and Gwenview? The best solution is probably to make D15503 >

D17269: Fix build failure in neon by adding QVariant include.

bruns added a comment. The right reference here is likely https://phabricator.kde.org/D17078 INLINE COMMENTS > kaboutdata.h:38 > class QJsonObject; > class QVariant; > class KAboutData; No longer needed REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.9 - Build # 106 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.9/106/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 30 Nov 2018 18:30:17 + Build duration: 2 min 14 sec and counting BUILD ARTIFACTS compat_reports/K

D17269: Fix build failure in neon by adding QVariant include.

apol accepted this revision. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D17269 To: scarlettclark, apol, mart, ngraham Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D17269: Fix build failure in neon by adding QVariant include.

apol added a comment. Thanks! REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D17269 To: scarlettclark, apol, mart, ngraham Cc: bruns, ngraham, kde-frameworks-devel, michaelh

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.9 - Build # 105 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.9/105/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 30 Nov 2018 18:20:42 + Build duration: 2 min 20 sec and counting JUnit Tests Name: (root) Failed

D17269: Fix build failure in neon by adding QVariant include.

bruns added a comment. This should reference the appropriate Qt or KF5 version which removed the implicit QVariant include. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D17269 To: scarlettclark, apol, mart, ngraham Cc: bruns, ngraham, kde-fram

D17028: Loader: Avoid Q_FOREACH

loh.tar added a comment. Well, neither of that. My "online me" is loh.tar but that was rejected by Phabricator, so the dot had to go. Lastly used ngraham uppercase letters, what looks even more strange to me :-) Should you intend to commit this, thanks in advance! May you look at D17055

D17269: Fix build failure in neon by adding QVariant include.

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Fixes it for me. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D17269 To: scarlettclark, apol, mart, ngraham Cc: ngraham, kde-frameworks-de

D17269: Fix build failure in neon by adding QVariant include.

ngraham added reviewers: apol, mart. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D17269 To: scarlettclark, apol, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17269: Fix build failure in neon by adding QVariant include.

scarlettclark created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. scarlettclark requested review of this revision. REVISION SUMMARY Build failed with error: invalid use of incomplete type ‘class QVariant’ By adding #include it now builds

D17220: Improve symbolism for off and muted status icon

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17220 To: trickyricky26, #vdg, ndavis Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Improve symbolism for off and muted status icon

trickyricky26 updated this revision to Diff 46577. trickyricky26 added a comment. - Lower opacity of inactive sound waves; improve sound muted icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17220?vs=46504&id=46577 BRANCH streamline-muted-off (

D17028: Loader: Avoid Q_FOREACH

cfeck added a comment. Is your full name really "loh tar", spelled with lower case letters? It looked strange on the list of names of all committers. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17028 To: loh.tar, davidedmundson Cc: cfeck, smartins, kde-frameworks

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.10 - Build # 377 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.10/377/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 30 Nov 2018 16:46:47 + Build duration: 4 min 56 sec and counting BUILD ARTIFACTS compat_report

KDE CI: Frameworks » kirigami » kf5-qt5 AndroidQt5.11 - Build # 193 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20AndroidQt5.11/193/ Project: kf5-qt5 AndroidQt5.11 Date of build: Fri, 30 Nov 2018 16:46:47 + Build duration: 2 min 22 sec and counting

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.9 - Build # 293 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.9/293/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 30 Nov 2018 16:46:47 + Build duration: 1 min 40 sec and counting BUILD ARTIFACTS compat_reports/

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.11 - Build # 112 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.11/112/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 30 Nov 2018 16:46:47 + Build duration: 2 min 11 sec and counting

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.11 - Build # 103 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.11/103/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 30 Nov 2018 16:46:47 + Build duration: 1 min 3 sec and counting

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.10 - Build # 376 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.10/376/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 30 Nov 2018 16:31:57 + Build duration: 2 min 15 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kirigami » kf5-qt5 AndroidQt5.11 - Build # 192 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20AndroidQt5.11/192/ Project: kf5-qt5 AndroidQt5.11 Date of build: Fri, 30 Nov 2018 16:31:57 + Build duration: 2 min 10 sec and counting CONSOLE OUTPUT [...trun

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.11 - Build # 111 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.11/111/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 30 Nov 2018 16:31:57 + Build duration: 1 min 24 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.9 - Build # 292 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.9/292/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 30 Nov 2018 16:31:57 + Build duration: 1 min 11 sec and counting CONSOLE OUTPUT [...truncated 10

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.11 - Build # 102 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.11/102/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 30 Nov 2018 16:31:57 + Build duration: 42 sec and counting CONSOLE OUTPUT [...truncated

D17260: Port some core Q_PRIVATE_SLOTS to new connect syntax

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17260 To: davidedmundson, apol Cc: apol, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D16867: Don't generate appstream data for files that lack a description

apol added a comment. Tests fixed, sorry about that. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D16867 To: apol, #plasma, #frameworks, ngraham Cc: dfaure, ngraham, kde-frameworks-devel, michaelh, bruns

D17245: Add string formatting function to property info

astippich added inline comments. INLINE COMMENTS > bruns wrote in formatstrings.cpp:83 > Of course I can look this up. But this information is not available when the > user looks at the string. > > Probably we should ask what is the target audience here? The average user > only wants the image

D17260: Port some core Q_PRIVATE_SLOTS to new connect syntax

davidedmundson updated this revision to Diff 46570. davidedmundson marked an inline comment as done. davidedmundson added a comment. update REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17260?vs=46565&id=46570 BRANCH master REVISION DETAIL https://phabri

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 91 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/91/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 30 Nov 2018 15:31:32 + Build duration: 4 min 33 sec and counting JUnit Tests Name: (root) Fail

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 69 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/69/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 30 Nov 2018 15:31:31 + Build duration: 4 min 29 sec and counting JUnit Tests Name: (root) Failed

D17260: Port some core Q_PRIVATE_SLOTS to new connect syntax

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in filecopyjob.cpp:225 > Why this change? m_copyJob is a superclass of DirectCopyJob which doesn't have the signal. so it's this or q->connect(qobject_cast(m_copyJob), ) REPOSITORY R241 KIO REVISION DETAIL https://

D17260: Port some core Q_PRIVATE_SLOTS to new connect syntax

broulik added inline comments. INLINE COMMENTS > filecopyjob.cpp:225 > KIO_ARGS << m_src << m_dest << m_permissions << (qint8)(m_flags & > Overwrite); > -m_copyJob = new DirectCopyJob(slave_url, packedArgs); > +auto job = new DirectCopyJob(slave_url, packedArgs); > +m_copyJob =

D17258: Fixed a bug(error?) in ipv4 & ipv6 settings

This revision was automatically updated to reflect the committed changes. Closed by commit R282:25118c3e80ce: Fixed a bug(error?) in ipv4 & ipv6 settings (authored by jgrulich). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17258?vs=46563&id=46566 R

D17258: Fixed a bug(error?) in ipv4 & ipv6 settings

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17258 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17258: Fixed a bug(error?) in ipv4 & ipv6 settings

jgrulich added a comment. Thanks for spotting this. I wonder how it's possible this passed the test, I guess comparing it the way we do, it doesn't compare it properly. I'll check the tests further. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17258 To:

D17028: Loader: Avoid Q_FOREACH

loh.tar added a comment. @davidedmundson May I ask how does this here will progress? You seemed to request a change which was not clear to me, but it's anyway "green flagged". REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17028 To: loh.tar, davidedmundson Cc: s

D17245: Add string formatting function to property info

bruns added inline comments. INLINE COMMENTS > astippich wrote in formatstrings.cpp:83 > CCW, see > https://docs.microsoft.com/en-us/uwp/api/windows.storage.fileproperties.photoorientation. Of course I can look this up. But this information is not available when the user looks at the string.

D17260: Port some core Q_PRIVATE_SLOTS to new connect syntax

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY KJob's are quite QObject heavy, we lose a non-trivial amount of time in signal matching strings. This po

D17258: Fixed a bug(error?) in ipv4 & ipv6 settings

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Fixed a couple of misplaced lines of code REPOSITORY R282 NetworkManager

kde-frameworks-devel@kde.org

loh.tar added a comment. Only 'm_view->' => 'view()' has plenty of hits, the others only a few. Please do a grep for m_startPos. To replace these few would require a changed or added function. Last note: I hope you test all these changes thoroughly. At the last mentioned m_startPos

kde-frameworks-devel@kde.org

loh.tar created this revision. loh.tar added reviewers: KTextEditor, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - 'm_view->' => 'view()' - 'm_startPos.line()' => 's

D17167: Provide a method of assigning custom default icons for non-XDG dirs

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. This feels *very* special cased. Where does this automagic ends? Any why only in $HOME? We'll keep adding entries here forever... Why don't people use a .directory file for this?

D17195: Avoid constantly increasing Qt event queue in KIO slaves

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Very nice catch. Just in case, please wait for after the tagging this weekend before pushing; an old performance issue is better than a possible major regression. REPOSITORY R241 KIO

D17256: [KUrlNavigator] Fix firstChildUrl when going back from archive

thsurrel created this revision. thsurrel added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REVISION SUMMARY When navigating in a archive file in Dolphin and then using the URL navigator

D17253: Fix colors for vector image mimetypes

ndavis retitled this revision from "Fix inconsistent x-office-drawing icon color" to "Fix colors for vector image mimetypes". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17253 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17253: Fix inconsistent x-office-drawing icon color

ndavis planned changes to this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17253 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17253: Fix inconsistent x-office-drawing icon color

ndavis added a comment. I just ran into 2 other issues. `libreoffice-drawing` has the same consistency problem with the same inconsistent color, but at 16px. I also noticed that the `libreoffice-drawing icons have a color that is the same as or almost the same as the `x-office-drawing`

D17253: Fix inconsistent x-office-drawing icon color

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17253 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17253: Fix inconsistent x-office-drawing icon color

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17253 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17253: Fix inconsistent x-office-drawing icon color

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The 22px `x-office-drawing` mimetype icon had a color that was inconsistent with the other

D17239: ovs-bridge and ovs-interface setting

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R282:2d72fc8c496c: Add ovs-bridge and ovs-interface setting (authored by pranavgade, committed by jgrulich). CHANGED PRIOR

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/55/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 30 Nov 2018 11:01:45 + Build duration: 7 min 57 sec and counting BUILD ARTIFACTS compat_r

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 86 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/86/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 30 Nov 2018 11:00:45 + Build duration: 8 min 34 sec and counting JUnit Tests

KDE CI: Frameworks » kitemmodels » kf5-qt5 WindowsMSVCQt5.11 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20WindowsMSVCQt5.11/20/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 30 Nov 2018 10:59:55 + Build duration: 5 min 57 sec and counting JUnit Tests N

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/43/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 30 Nov 2018 11:01:45 + Build duration: 4 min 3 sec and counting BUILD ARTIFACTS compat_repo

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 259 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/259/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 30 Nov 2018 11:00:45 + Build duration: 3 min 19 sec and counting BUILD ARTIFACTS co

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.9 - Build # 203 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.9/203/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 30 Nov 2018 11:00:45 + Build duration: 2 min 37 sec and counting BUILD ARTIFACTS comp

D17204: BrightScript: Allow sub to be unnamed

cullmann added a comment. Upsa, you are right. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17204 To: dlevin, cullmann Cc: dfaure, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D16867: Don't generate appstream data for files that lack a description

dfaure added a comment. More casualties: the kpackage unittests... https://build.kde.org/job/Frameworks/view/Everything/job/kpackage/job/kf5-qt5%20SUSEQt5.10/90/testReport/junit/(root)/TestSuite/testjsonmetadatapackage_appstream/ and 5 others (https://build.kde.org/job/Frameworks/view/

D17204: BrightScript: Allow sub to be unnamed

dfaure added a comment. It seems this commit is the reason for the unittest failure below? https://build.kde.org/job/Frameworks/view/Everything/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/258/testReport/junit/(root)/TestSuite/folding_test/ --- "/home/jenkins/workspace/Framewor

D17252: ovs-patch and ovs-port setting

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Added ovs-patch and ovs-port setting according to: https://developer.gn

D15999: Add icons with added background to system.svgz

filipf added a comment. In D15999#368500 , @ngraham wrote: > In D15999#368499 , @filipf wrote: > > > But there is a tangible problem here - imagine what the logout screen when using dark themes would

D17239: ovs-bridge and ovs-interface setting

pranavgade updated this revision to Diff 46542. pranavgade marked an inline comment as done. REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17239?vs=46537&id=46542 REVISION DETAIL https://phabricator.kde.org/D17239 AFFECTED FILES autotests/settin

D17239: ovs-bridge and ovs-interface setting

jgrulich added inline comments. INLINE COMMENTS > ovsinterfacesetting.cpp:27 > +#if !NM_CHECK_VERSION(1, 10, 0) > +#define NM_SETTING_OVS_INTERFACE_SETTING_NAME "ovs-interface" > +#endif I forgot that the same problem will be with NM_SETTING_OVS_INTERFACE_TYPE. Define it too please. REPOSITORY

D17040: Make FindExiv2.cmake work with exiv 0.27.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R260:6f4e08953736: Make FindExiv2.cmake work with exiv 0.27. (authored by cgiboudeaux). REPOSITORY R260 Gwenview CHANGES

D17251: Update Ip-tunnel settings

This revision was automatically updated to reflect the committed changes. Closed by commit R282:d2531a32e28d: Update Ip-tunnel settings (authored by pranavgade, committed by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17251?vs=46535&id=46540#toc REPOSITORY R282 NetworkMan

D17251: Update Ip-tunnel settings

jgrulich accepted this revision. jgrulich added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > iptunnelsetting.h:28 > +#if !NM_CHECK_VERSION(1, 12, 0) > +#define NM_SETTING_IP_TUNNEL_FLAGS"flags" > + No need to define this here, it's a

D17245: Add string formatting function to property info

astippich added inline comments. INLINE COMMENTS > bruns wrote in formatstrings.cpp:81 > Thats somewhat ambigous - flipped along the vertical axis, or top/bottom > flipped? Actually I don't know, I just copied the code from Dolphin into here. Seems to be a common term though according to https

D17239: ovs-bridge and ovs-interface setting

pranavgade updated this revision to Diff 46537. pranavgade marked 8 inline comments as done. pranavgade added a comment. Made the required changes REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17239?vs=46491&id=46537 REVISION DETAIL https://pha

D17251: Update Ip-tunnel settings

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Fixed a few things in ip-tunnel settings REPOSITORY R282 NetworkManagerQ

  1   2   >