KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 366 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/366/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 07 Dec 2018 04:26:25 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: TestSuite.kiofilewidgets-knewfilemenutestFailed: TestSuite.kiogui-favicontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(31916/60117)37%
(16475/44086)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4279/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8320/14337)50%
(4660/9263)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3909/7970)34%
(1604/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4288)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.11 - Build # 3 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.11/3/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 07 Dec 2018 04:26:45 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5Purpose_compat_report.html
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report22%
(5/23)26%
(14/53)26%
(14/53)20%
(450/2204)18%
(198/1118)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)94%
(146/155)57%
(60/106)src100%
(8/8)100%
(8/8)67%
(220/327)50%
(104/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/152)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
  

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/5/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 07 Dec 2018 04:26:25 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: TestSuite.kiofilewidgets-knewfilemenutestFailed: TestSuite.kiogui-favicontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(31920/60118)37%
(16481/44086)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4279/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8325/14338)50%
(4665/9259)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3908/7970)34%
(1603/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4288)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 365 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/365/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 07 Dec 2018 04:07:50 +
 Build duration:
7 min 33 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: TestSuite.kiofilewidgets-knewfilemenutestFailed: TestSuite.kiogui-favicontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(31918/60117)37%
(16471/44086)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4272/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8322/14337)50%
(4664/9263)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3909/7970)34%
(1604/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4288)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%
  

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/4/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 07 Dec 2018 04:07:50 +
 Build duration:
7 min 47 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: TestSuite.kiofilewidgets-knewfilemenutestFailed: TestSuite.kiogui-favicontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(31923/60118)37%
(16476/44086)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4279/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8323/14338)50%
(4658/9259)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3908/7970)34%
(1603/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4288)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%
  

D17378: Change title of the message box to something which conveys message

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:13092bd64615: Change title of the message box to 
something which conveys message (authored by shubham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17378?vs=46941=47007

REVISION DETAIL
  https://phabricator.kde.org/D17378

AFFECTED FILES
  src/widgets/jobuidelegate.cpp

To: shubham, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17395: add attributes `shared` and `__gshared`

[aG0aep6G aG0aep6G]

aG0aep6G set the repository for this revision to R216 Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17395

To: aG0aep6G
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D16716: fail writing test if mime type is not supported by the extractor

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  skip_missing

REVISION DETAIL
  https://phabricator.kde.org/D16716

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 3 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/3/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 06 Dec 2018 20:04:43 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: TestSuite.kiofilewidgets-knewfilemenutestFailed: TestSuite.kiogui-favicontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(31963/60118)37%
(16509/44086)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4281/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8350/14338)50%
(4675/9259)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3909/7970)34%
(1604/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(532/1036)37%
(319/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4288)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%

D17301: add documentation to result class

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  result_documentation

REVISION DETAIL
  https://phabricator.kde.org/D17301

To: astippich, #baloo, bruns
Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 364 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/364/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 06 Dec 2018 20:04:43 +
 Build duration:
9 min 3 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: TestSuite.kiofilewidgets-knewfilemenutestFailed: TestSuite.kiogui-favicontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(31917/60117)37%
(16480/44086)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4277/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8321/14337)50%
(4665/9263)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3909/7970)34%
(1604/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4288)35%
(1305/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%
   

D17310: Improve Kile icon with LaTeX font

[Noah Davis]

ndavis added a comment.


  In D17310#371697 , @trickyricky26 
wrote:
  
  > With a small "k" in the equation:
  >  F6457785: kile-alternative.svg.png 
  >
  > With a capital "K":
  >  F6457787: kile-alternative2.svg.png 
  >
  > What do you think?
  
  
  Can you show it at 100% size? You should generally show icons at 100% size so 
that they can be seen the way the user will see them.

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-kile-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17310

To: trickyricky26, #vdg, ngraham, #kile
Cc: mludwig, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17281: Add icon to KBuildSycocaProgressDialog cancel button

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3b320f7a32f3: Add icon to KBuildSycocaProgressDialog 
cancel button (authored by GB_2, committed by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17281?vs=46677=46998

REVISION DETAIL
  https://phabricator.kde.org/D17281

AFFECTED FILES
  src/widgets/kbuildsycocaprogressdialog.cpp

To: GB_2, ngraham, #frameworks, cfeck, elvisangelaccio
Cc: bcooksley, elvisangelaccio, ngraham, kde-frameworks-devel, alexde, 
IohannesPetros, trickyricky26, michaelh, crozbo, ndavis, firef, bruns, 
skadinna, aaronhoneycutt, mbohlender

D17392: Fix checkDesktopFile function

[Aleksei Nikiforov]

i.Dark_Templar added a commit: R241:16edef0dca46: Remove unused variable.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17392

To: i.Dark_Templar, davidedmundson, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17015: Fix the Qt doc creation with Qt 5.12.

[Tobias C. Berner]

tcberner added inline comments.

INLINE COMMENTS

> ECMQueryQmake.cmake:9
> +# We need to look for the executable directly.
> +find_program(_qmake_executable_default NAMES qmake-qt5)
>  endif()

^ on FreeBSD qmake-qt5 is just called qmake (which is in fact qtchooser).

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D17015

To: cgiboudeaux, kossebau
Cc: tcberner, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17392: Fix checkDesktopFile function

[Nathaniel Graham]

ngraham added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17392

To: i.Dark_Templar, davidedmundson, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17378: Change title of the message box to something which conveys message

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17378

To: shubham, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14998: Add AppImage thumbnailer

[Luigi Toscano]

ltoscano added a comment.


  In D14998#372293 , @probono wrote:
  
  > Can it be included/installed in KDE neon?
  
  
  You should ask on Neon request channels.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D14998

To: broulik, #plasma, #vdg, TheAssassin, anthonyfieroni
Cc: ltoscano, kde-frameworks-devel, kfm-devel, probono, michaeltunnell, 
ngraham, abetts, anthonyfieroni, alexde, sourabhboss, feverfew, shubham, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D17392: Fix checkDesktopFile function

[Aleksei Nikiforov]

i.Dark_Templar created this revision.
i.Dark_Templar added a reviewer: davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
i.Dark_Templar requested review of this revision.

REVISION SUMMARY
  Variable isLocal is no longer initialized anywhere.
  Return function call which set it's value before while still discarding value 
returned by that function.
  Also provide default value (false) for variable isLocal since function
  items.mostLocalUrl(...) might not set a value to it if item is empty.
  
  Alternatively, remains of isLocal variable and it's usage probably should be 
removed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17392

AFFECTED FILES
  src/core/kfileitem.cpp

To: i.Dark_Templar, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16716: fail writing test if mime type is not supported by the extractor

[Alexander Stippich]

astippich retitled this revision from "skip writing test if mime type is not 
supported by the extractor" to "fail writing test if mime type is not supported 
by the extractor".

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16716

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

[Simon Peter]

probono added a comment.


  Thank you @kossebau, really nice to see this.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham, TheAssassin
Cc: probono, TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D14998: Add AppImage thumbnailer

[Simon Peter]

probono added a comment.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.


  Can it be included/installed in KDE neon?
  
  F6459777: ss.png 

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D14998

To: broulik, #plasma, #vdg, TheAssassin, anthonyfieroni
Cc: kde-frameworks-devel, kfm-devel, probono, michaeltunnell, ngraham, abetts, 
anthonyfieroni, alexde, sourabhboss, feverfew, shubham, michaelh, spoorun, 
navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D17391: add support for more mimetypes to taglibwriter

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: bruns, mgallien.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  adds support for basic tag writing to
  aiff, wav, wavpack, wma/asf, ape and speex files

TEST PLAN
  tests pass

REPOSITORY
  R286 KFileMetaData

BRANCH
  taglibwriter_mimetypes

REVISION DETAIL
  https://phabricator.kde.org/D17391

AFFECTED FILES
  autotests/taglibwritertest.cpp
  src/writers/taglibwriter.cpp

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16716: skip writing test if mime type is not supported by the extractor

[Alexander Stippich]

astippich added a comment.


  Well, if it is not even signaled via ctest, that's pretty bad, I agree

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16716

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16716: skip writing test if mime type is not supported by the extractor

[Alexander Stippich]

astippich updated this revision to Diff 46990.
astippich added a comment.


  - use QFAIL

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16716?vs=44983=46990

BRANCH
  skip_missing

REVISION DETAIL
  https://phabricator.kde.org/D16716

AFFECTED FILES
  autotests/taglibwritertest.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17301: add documentation to result class

[Alexander Stippich]

astippich marked 2 inline comments as done.
astippich added inline comments.

INLINE COMMENTS

> bruns wrote in result.h:79
> The TermGenerator's do not contain any data themselves, but
> 
> - keep/update the position state when adding data
> - add the data to the referenced Baloo::Document when supplied with new data 
> (`index*Text()`)

Would be nice if you could add that information to the TermGenerator :)

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17301

To: astippich, #baloo, bruns
Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17301: add documentation to result class

[Alexander Stippich]

astippich updated this revision to Diff 46987.
astippich added a comment.


  - rephase description of TermGenerator

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17301?vs=46864=46987

BRANCH
  result_documentation

REVISION DETAIL
  https://phabricator.kde.org/D17301

AFFECTED FILES
  src/file/extractor/result.h

To: astippich, #baloo, bruns
Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17358: implement cover extraction for asf files

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:2a41e4b45262: implement cover extraction for asf files 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17358?vs=46868=46985

REVISION DETAIL
  https://phabricator.kde.org/D17358

AFFECTED FILES
  autotests/embeddedimagedatatest.cpp
  autotests/samplefiles/test.wma
  src/embeddedimagedata.cpp

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17357: extend list of supported mimetypes for embedded image extractor

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:9f67b436f851: extend list of supported mimetypes for 
embedded image extractor (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17357?vs=46861=46983

REVISION DETAIL
  https://phabricator.kde.org/D17357

AFFECTED FILES
  autotests/embeddedimagedatatest.cpp
  autotests/samplefiles/test.spx
  src/embeddedimagedata.cpp

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16671: Refactor embedded image extractor for greater extensibility

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:7929a896b5e1: Refactor embedded image extractor for 
greater extensibility (authored by astippich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16671?vs=46880=46982#toc

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16671?vs=46880=46982

REVISION DETAIL
  https://phabricator.kde.org/D16671

AFFECTED FILES
  src/embeddedimagedata.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17357: extend list of supported mimetypes for embedded image extractor

[Alexander Stippich]

astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

BRANCH
  image_extend

REVISION DETAIL
  https://phabricator.kde.org/D17357

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.11 - Build # 2 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.11/2/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 06 Dec 2018 17:47:32 +
 Build duration:
4 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6346/8464)43%
(10138/23412)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5762/11825)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(972/2303)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 79 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/79/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 06 Dec 2018 17:47:32 +
 Build duration:
4 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6346/8464)43%
(10138/23410)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5763/11827)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(121/321)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(242/938)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1043/2803)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(972/2301)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(863/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D15829: make units and prefixes of formatValue translatable

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:0b58dc656d1a: make units and prefixes of formatValue 
translatable (authored by astippich).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15829?vs=43038=46981

REVISION DETAIL
  https://phabricator.kde.org/D15829

AFFECTED FILES
  src/lib/util/kformatprivate.cpp

To: astippich, bruns, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17381: macsec setting

[Pranav Gade]

pranavgade added inline comments.

INLINE COMMENTS

> pranavgade wrote in macsecsetting.h:58
> From where can I get the possible values? Because I cannot find them here: 
> https://developer.gnome.org/NetworkManager/stable/settings-macsec.html

(I mean the default values to use in the defines)

REVISION DETAIL
  https://phabricator.kde.org/D17381

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17381: macsec setting

[Pranav Gade]

pranavgade updated this revision to Diff 46975.
pranavgade marked 3 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17381?vs=46958=46975

REVISION DETAIL
  https://phabricator.kde.org/D17381

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/macsecsettingtest.cpp
  autotests/settings/macsecsettingtest.h
  src/CMakeLists.txt
  src/settings/macsecsetting.cpp
  src/settings/macsecsetting.h
  src/settings/macsecsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17381: macsec setting

[Pranav Gade]

pranavgade added inline comments.

INLINE COMMENTS

> jgrulich wrote in macsecsettingtest.cpp:29
> This required version is not true, please verify it properly, I'm not going 
> to do it every time :).

I tried to get the version from here: 
F6459587: Screenshot from 2018-12-06 22-13-34.png 


Is that incorrect?
If so, from where do I check the version?

> jgrulich wrote in macsecsetting.h:58
> Can be turned into an enum.

From where can I get the possible values? Because I cannot find them here: 
https://developer.gnome.org/NetworkManager/stable/settings-macsec.html

REVISION DETAIL
  https://phabricator.kde.org/D17381

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style

[loh tar]

loh.tar added a comment.


  Without any special "Oh, that would be nice", I will stop now with further S
  
  - I have tried to clean up a little bit the two header files, but that's more 
difficult than thought
  - m_cursor => cursorPosition() is also not so easy
  - There was no comment regarding m_startPos => startPos()
  - m_mouse => mousePosition(), not investigated
  - Who can I bother regarding stuff on kate-editor.org ?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17382

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style

[loh tar]

loh.tar created this revision.
loh.tar added reviewers: KTextEditor, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17382

AFFECTED FILES
  src/view/kateview.cpp
  src/view/kateviewaccessible.h
  src/view/kateviewinternal.h
  src/vimode/inputmodemanager.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D16694: Improve visibility for Konsole icon when using Breeze Dark

[Anish Giri]

anishgiri edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16694

To: anishgiri, ngraham, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17381: macsec setting

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> macsecsettingtest.cpp:29
> +
> +#if !NM_CHECK_VERSION(1, 12, 0)
> +#define NM_SETTING_MACSEC_PARENT   "parent"

This required version is not true, please verify it properly, I'm not going to 
do it every time :).

> macsecsetting.cpp:26
> +
> +#if !NM_CHECK_VERSION(1, 12, 0)
> +#define NM_SETTING_MACSEC_SETTING_NAME "macsec"

Same wrong NM version as in the test.

> macsecsetting.cpp:311
> +
> +if (mkaCakFlags()) {
> +setting.insert(QLatin1String(NM_SETTING_MACSEC_MKA_CAK_FLAGS), 
> (int)mkaCakFlags());

Flags should be inserted to the map all the time.

> macsecsetting.h:58
> +
> +void setMode(qint32 mode);
> +qint32 mode() const;

Can be turned into an enum.

> macsecsetting.h:70
> +
> +void setValidation(qint32 validation);
> +qint32 validation() const;

Can be turned into an enum.

> setting.cpp:34
>  
> +#if !NM_CHECK_VERSION(1, 12, 0)
> +#define NM_SETTING_MACSEC_SETTING_NAME "macsec"

Again not true.

REVISION DETAIL
  https://phabricator.kde.org/D17381

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16694: Improve visibility for Konsole icon when using Breeze Dark

[Anish Giri]

anishgiri updated this revision to Diff 46959.
anishgiri edited the summary of this revision.
anishgiri added a comment.


  Corrected the bright corner issue

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16694?vs=44931=46959

BRANCH
  utilities-terminal (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16694

AFFECTED FILES
  icons-dark/apps/48/utilities-terminal.svg
  icons-dark/apps/64/utilities-terminal.svg

To: anishgiri, ngraham, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17381: macsec setting

[Pranav Gade]

pranavgade updated this revision to Diff 46958.
pranavgade added a comment.


  rebased on master

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17381?vs=46953=46958

REVISION DETAIL
  https://phabricator.kde.org/D17381

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/macsecsettingtest.cpp
  autotests/settings/macsecsettingtest.h
  src/CMakeLists.txt
  src/settings/macsecsetting.cpp
  src/settings/macsecsetting.h
  src/settings/macsecsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17241: WIP:Disable highlighting for lines longer than 1024 characters.

[Kåre Särs]

sars added a comment.


  The highlighting limit is now returned in a function in KateRenderer as it is 
used also in katedocument.cpp for the warning/information message.

INLINE COMMENTS

> mwolff wrote in katerenderer.cpp:400
> this style-change should be submitted independently of this code review

I figured that since I'm indenting the whole section and touching the line 
anyways, that fixing the style does not hurt. ;)

(Phabricator is not showing the white-space change)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17241

To: sars, cullmann, vkrause, dhaumann, mwolff
Cc: mwolff, brauch, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17241: WIP:Disable highlighting for lines longer than 1024 characters.

[Kåre Särs]

sars updated this revision to Diff 46957.
sars edited the summary of this revision.
sars added a comment.


  Add a message to inform about why the lines are not highlighted.
  Add a note about disabled highlighting to the wrapped lines warning.
  Increase the default line length limit to 100 000 characters per line.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17241?vs=46633=46957

BRANCH
  disable_hl2

REVISION DETAIL
  https://phabricator.kde.org/D17241

AFFECTED FILES
  src/buffer/katetextbuffer.cpp
  src/document/katedocument.cpp
  src/render/katerenderer.cpp
  src/render/katerenderer.h

To: sars, cullmann, vkrause, dhaumann, mwolff
Cc: mwolff, brauch, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 2 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/2/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 06 Dec 2018 13:18:01 +
 Build duration:
6 min 27 sec and counting
   BUILD ARTIFACTS
  compat_reports/KF5TextEditor_compat_report.html
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.vimode_keys
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(255/290)88%
(255/290)68%
(32930/48202)51%
(15906/31062)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4431/4730)49%
(1696/3450)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5483/5523)58%
(996/1712)src.buffer88%
(15/17)88%
(15/17)90%
(1678/1860)76%
(1271/1670)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1863/3157)47%
(1559/3307)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor94%
(15/16)94%
(15/16)91%
(222/245)64%
(147/228)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1244)67%
(627/942)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(6/6)100%
(6/6)74%
(1106/1494)64%
(582/914)src.spellcheck86%
(6/7)86%
  

D17243: Only cal updateView() in visibleRange() when endPos() is invalid.

[Kåre Särs]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:cb63ec1ee30a: Only cal updateView() in visibleRange() when 
endPos() is invalid. (authored by sars).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17243?vs=46937=46956

REVISION DETAIL
  https://phabricator.kde.org/D17243

AFFECTED FILES
  src/view/kateview.cpp

To: sars, cullmann, #kate, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17381: macsec setting

[Jan Grulich]

jgrulich added a comment.


  Rebase this change on top of your previous change, this will not apply.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17381

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17381: macsec setting

[Pranav Gade]

pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.

REVISION SUMMARY
  Added macsec setting according to:
  https://developer.gnome.org/NetworkManager/stable/settings-macsec.html

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17381

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/macsecsettingtest.cpp
  autotests/settings/macsecsettingtest.h
  src/CMakeLists.txt
  src/settings/macsecsetting.cpp
  src/settings/macsecsetting.h
  src/settings/macsecsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17342: team-port setting

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:d3ca739a37ab: team-port setting (authored by pranavgade, 
committed by jgrulich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17342?vs=46946=46949#toc

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17342?vs=46946=46949

REVISION DETAIL
  https://phabricator.kde.org/D17342

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/teamportsettingtest.cpp
  autotests/settings/teamportsettingtest.h
  src/CMakeLists.txt
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/teamportsetting.cpp
  src/settings/teamportsetting.h
  src/settings/teamportsetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17342: team-port setting

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  I lived in assumption that "link-watchers" is NMVariantMapMap and not 
NMVariantMapList, that's why I suggested those changes. I'm sorry for that. 
I'll fix it locally here, you were correct before. The rest looks good.

REVISION DETAIL
  https://phabricator.kde.org/D17342

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17342: team-port setting

[Pranav Gade]

pranavgade updated this revision to Diff 46946.
pranavgade marked an inline comment as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17342?vs=46940=46946

REVISION DETAIL
  https://phabricator.kde.org/D17342

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/teamportsettingtest.cpp
  autotests/settings/teamportsettingtest.h
  src/CMakeLists.txt
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/teamportsetting.cpp
  src/settings/teamportsetting.h
  src/settings/teamportsetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17342: team-port setting

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> teamportsettingtest.cpp:103
> +if (it.key() == QLatin1String(NM_SETTING_TEAM_PORT_LINK_WATCHERS)) {
> +NMVariantMapList list = it_1.value().value();
> +NMVariantMapList list1 = 
> map1.value(it_1.key()).value();

Why don't you skip this and just use NMVariantMapList list = 
map.value(QLatin1String(NM_SETTING_TEAM_PORT_LINK_WATCHERS).value()?
 same for the second one. You don't need to go through the map to get 
"link-watchers" property.

REVISION DETAIL
  https://phabricator.kde.org/D17342

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17342: team-port setting

[Jan Grulich]

jgrulich added a comment.


  Submit full patch, not only recent changes.

REVISION DETAIL
  https://phabricator.kde.org/D17342

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17378: Change title of the message box to something which conveys message

[Shubham]

shubham created this revision.
shubham added a reviewer: ngraham.
shubham added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.

REVISION SUMMARY
  The warning message box which appears on applying shift + delete (permanent 
deletion) combination had title "Warning", which didn't conveyed the actual 
message to the user.

TEST PLAN
  Shift + delete any file or folder or a  combination of multiple files/folders.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17378

AFFECTED FILES
  src/widgets/jobuidelegate.cpp

To: shubham, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17342: team-port setting

[Pranav Gade]

pranavgade updated this revision to Diff 46940.
pranavgade marked 2 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17342?vs=46905=46940

REVISION DETAIL
  https://phabricator.kde.org/D17342

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/teamportsettingtest.cpp
  autotests/settings/teamportsettingtest.h
  src/CMakeLists.txt
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/teamportsetting.cpp
  src/settings/teamportsetting.h
  src/settings/teamportsetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17243: Only cal updateView() in visibleRange() when endPos() is invalid.

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Then lets try that.

REPOSITORY
  R39 KTextEditor

BRANCH
  lessUpdateView

REVISION DETAIL
  https://phabricator.kde.org/D17243

To: sars, cullmann, #kate, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann