D17681: RFC: Cache translated strings in Job::emit functions

broulik added a comment. > That 6% goes to 0% i guess? Pretty much, goes down to 0.07% REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17681 To: broulik, davidedmundson, dfaure, chinmoyr Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D17681: RFC: Cache translated strings in Job::emit functions

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a48a277a8296: Cache translated strings in Job::emit functions (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17681?vs=47828=47874 REVISION

D17680: Port connect of subjob in copyNextFile to new connect syntax

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a4905c5994a7: Port connect of subjob in copyNextFile to new connect syntax (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17680?vs=47827=47873

D17459: SearchBar: Add Cancel button to stop long running tasks

anthonyfieroni added inline comments. INLINE COMMENTS > katesearchbar.h:153 > -bool find(SearchDirection searchDirection = SearchForward, const QString > *replacement = nullptr); > -int findAll(KTextEditor::Range inputRange, const QString *replacement); > It's exported class you

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.9 - Build # 320 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.9/320/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 20 Dec 2018 01:31:18 + Build duration: 5 min 4 sec and counting JUnit Tests Name: (root)

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

gregormi added a comment. If there are no further comments, would proceed with: - Introduce "Save Variants" by leaving Save and Save as... top-level. I will use the name 'file_save_variants' - Introduce "Print and Export" submenu - Introduce "Close Variants" while leaving the

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

gregormi added a comment. Yes, those shortcuts exist long time. I would like to change them for these specific reasons which I think are worth to be considered: 1. Introduce a default shortcut pair for "Next / Prev Match" which is useful and currently missing. 2. "Free" some F keys

D17681: RFC: Cache translated strings in Job::emit functions

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Good idea. This is indeed threadsafe, since in C++11 static objects are threadsafe. And this is done on demand the first time the function is called, so qApp exists and the catalogs

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D17459 To: loh.tar, #ktexteditor, #vdg, cullmann Cc: brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.9 - Build # 102 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.9/102/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 19 Dec 2018 20:52:24 + Build duration: 8 min 54 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.11 - Build # 45 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.11/45/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 19 Dec 2018 20:52:26 + Build duration: 8 min 38 sec and counting JUnit Tests

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.11 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.11/5/ Project: kf5-qt5 SUSEQt5.11 Date of build: Wed, 19 Dec 2018 20:52:22 + Build duration: 2 min 21 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » knewstuff » kf5-qt5 FreeBSDQt5.11 - Build # 44 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20FreeBSDQt5.11/44/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 19 Dec 2018 20:52:06 + Build duration: 57 sec and counting

D17681: RFC: Cache translated strings in Job::emit functions

aacid added a comment. That 6% goes to 0% i guess? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17681 To: broulik, davidedmundson, dfaure, chinmoyr Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D17331: Extend PositionCodec unit tests, better code coverage

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17331 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko, lbeltrame Cc: kde-frameworks-devel, ashaposhnikov,

D17680: Port connect of subjob in copyNextFile to new connect syntax

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17680 To: broulik, davidedmundson, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » attica » kf5-qt5 SUSEQt5.9 - Build # 50 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20SUSEQt5.9/50/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 19 Dec 2018 17:13:40 + Build duration: 6 min 34 sec and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.9 - Build # 101 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.9/101/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 19 Dec 2018 17:07:40 + Build duration: 7 min 34 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » attica » kf5-qt5 SUSEQt5.11 - Build # 3 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20SUSEQt5.11/3/ Project: kf5-qt5 SUSEQt5.11 Date of build: Wed, 19 Dec 2018 17:13:40 + Build duration: 1 min 56 sec and counting JUnit Tests Name: projectroot

D17593: Notify if a default provider failed to download

apol closed this revision. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D17593 To: apol, #frameworks, leinir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17593: Notify if a default provider failed to download

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Hm, definitely yes. Frankly i thought this already happened, goes to show what assumptions make of us, eh? ;) REPOSITORY R235 Attica BRANCH master REVISION DETAIL

KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.11 - Build # 44 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.11/44/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 19 Dec 2018 17:07:40 + Build duration: 1 min 49 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.11 - Build # 4 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.11/4/ Project: kf5-qt5 SUSEQt5.11 Date of build: Wed, 19 Dec 2018 17:07:40 + Build duration: 1 min 2 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » knewstuff » kf5-qt5 FreeBSDQt5.11 - Build # 43 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20FreeBSDQt5.11/43/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 19 Dec 2018 17:07:40 + Build duration: 58 sec and counting CONSOLE OUTPUT [...truncated

D17594: Notify about the provider not being loaded

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Oh wow, ouch, yes that should definitely be happening. Well caught, thank you! :) REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D17594 To:

D17594: Notify about the provider not being loaded

apol closed this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D17594 To: apol, #frameworks, leinir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

loh.tar added a comment. Should you dislike the auto bracket code changes can I remove them from this patch. They are not needed for this one and only be the byproduct of my code studying. As always, poor tested :-) REPOSITORY R39 KTextEditor REVISION DETAIL

D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY The first attempt was to add these chars to the auto bracket

D17650: Install kioslave as kioslave5 on Windows

lbeltrame added a comment. In D17650#379423 , @heikobecker wrote: > In D17650#379396 , @habacker wrote: > > > I think this is unrelated - this request is to fix an issue with an available package

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.9 - Build # 319 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.9/319/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 19 Dec 2018 16:50:55 + Build duration: 47 sec and counting CONSOLE OUTPUT [...truncated 278

D17692: Add a proper python-bytecode icon, use consistent color in python icons

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17692 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham,

D17692: Add a proper python-bytecode icon, use consistent color in python icons

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH fix-python-bytecode (branched from master) REVISION DETAIL

D17691: Add rows info to the plasma virtual desktop protocol

mart created this revision. mart added reviewers: Plasma, KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY in order for the pager to work correctly and not having to use a weird mix of wayland

D17331: Extend PositionCodec unit tests, better code coverage

bruns added a comment. Ping! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17331 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17338: Move typesForMimeType helper from BasicIndexingJob to anonymous namespace

This revision was automatically updated to reflect the committed changes. Closed by commit R293:f3a49ddc869a: Move typesForMimeType helper from BasicIndexingJob to anonymous namespace (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 47843. loh.tar added a comment. - Fix too much stretching of Cancel|Find/Replace button (I misunderstood probably Andres above :-) - Add S progress hint, Rename showInfoMessage(..) -> showResultMessage() and move logic in what text to show Notes:

D17245: Add string formatting function to property info

bruns added a comment. I think this is ok now, but I would like to have one +1 from any other frameworks developer. INLINE COMMENTS > formatstrings.h:21 > +#ifndef KFILEMETADATA_FORMATSTRINGS_H > +#define KFILEMETADATA_FORMATSTRINGS_H > This is a private headers, and thus should have a

D17650: Install kioslave as kioslave5 on Windows

heikobecker added a comment. In D17650#379396 , @habacker wrote: > I think this is unrelated - this request is to fix an issue with an available package on a distribution, so can anyone accept this ? I'd argue that the problem is with

D17650: Install kioslave as kioslave5 on Windows

habacker added a comment. I think this is unrelated - this request is to fix an issue with an available package on a distribution, so can anyone accept this ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17650 To: habacker, #frameworks, lbeltrame, vonreth Cc:

D17678: Use qobject_cast instead of dynamic_cast

This revision was automatically updated to reflect the committed changes. Closed by commit R241:1d8e4e6fa29c: Use qobject_cast instead of dynamic_cast (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17678?vs=47824=47834 REVISION DETAIL

D17678: Use qobject_cast instead of dynamic_cast

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17678 To: broulik, davidedmundson, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17681: RFC: Cache translated strings in Job::emit functions

broulik edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17681 To: broulik, davidedmundson, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17680: Port connect of subjob in copyNextFile to new connect syntax

broulik edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17680 To: broulik, davidedmundson, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17681: RFC: Cache translated strings in Job::emit functions

broulik created this revision. broulik added reviewers: davidedmundson, dfaure, chinmoyr. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY These are called repeatedly for every single file processed

D17680: Port connect of subjob in copyNextFile to new connect syntax

broulik edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17680 To: broulik, davidedmundson, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17680: Port connect of subjob in copyNextFile to new connect syntax

broulik created this revision. broulik added reviewers: davidedmundson, dfaure, chinmoyr. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN Copied files, total and processed size still correct REPOSITORY

D17678: Use qobject_cast instead of dynamic_cast

broulik edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17678 To: broulik, davidedmundson, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17678: Use qobject_cast instead of dynamic_cast

broulik created this revision. broulik added reviewers: davidedmundson, dfaure, chinmoyr. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Since `KJob` is a `QObject` we can use the more efficient