D19557: Update css

2019-03-06 Thread Carl Schwan
ognarb added a comment.


  In D19557#426051 , @aacid wrote:
  
  > Why changing from jpg to png for the image file ?
  
  
  I only had a png version in my hard drive, but if it's a problem I can 
convert the png in a jpg.
  
  In D19557#426057 , @broulik wrote:
  
  > Can't we just go SVG with the icon?
  
  
  I tried this first but khtml didn't look like it support svg.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, 
ngraham, bruns, skadinna


D18673: Add symlinks for flatpak

2019-03-06 Thread Nathaniel Graham
ngraham added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18673

To: GeeXT, #frameworks, #vdg
Cc: nibags, kde-frameworks-devel, michaelh, ngraham, bruns


D18673: Add symlinks for flatpak

2019-03-06 Thread Nathaniel Graham
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  I like the functionality, though I'm not thrilled about having to change 
these symlinks around as apps change their appstream IDs, and constabtly add 
new ones as different packagers replace the existing AppStream IDs with their 
own (ugh).  Then again that's already the world we live in and I guess we've 
signed ourselves up for this mess by supporting icons for 3rd-party apps anyway.
  
  This currently causes the `scalable` test to fail, so at a minimum that needs 
to be fixed before this patch can land:
  
FAIL!  : ScalableTest::test_scalable(icons:Applications) The following 
icons are not available in a scalable directory:
  com.github.bajoja.indicator-kdeconnect
   Loc: [/home/dev/kde/src/breeze-icons/autotests/scalabletest.cpp(262)]
FAIL!  : ScalableTest::test_scalable(icons-dark:Applications) The following 
icons are not available in a scalable directory:
  com.github.bajoja.indicator-kdeconnect
  
  Remove the 16px `com.github.bajoja.indicator-kdeconnect` icon symlink, I 
guess.
  
  Looks like @nibags found another one that could be added, too

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18673

To: GeeXT, #frameworks, #vdg, ngraham
Cc: ngraham, nibags, kde-frameworks-devel, michaelh, bruns


D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

2019-03-06 Thread Ralf Habacker
habacker updated this revision to Diff 53327.
habacker marked an inline comment as done.
habacker added a comment.


  - added @since tag
  
  The patch was added to build the stable version of KMyMoney
  for Windows to fix an issue not been able to have common
  printer settings. Since KHTML is the successor of kdelilbs,
  it has been ported to KF5.

REPOSITORY
  R313 KHtml

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19504?vs=53104=53327

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19504

AFFECTED FILES
  src/khtmlview.cpp
  src/khtmlview.h

To: habacker
Cc: aacid, tbaumgart, kde-frameworks-devel, michaelh, ngraham, bruns


D18904: [FileCopyJob] Clean up after file copy operation is cancelled

2019-03-06 Thread David Faure
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Withdrawing my approval, after realizing that this is missing the "enough 
free space at destination" check.
  Imagine a 5GB partition with a 4GB file on it. You want to copy another 
version of that 4GB file onto it. Old implementation: it works. New 
implementation: we start copying 1GB into a .part file, then it fails (out of 
space), and then IIUC we finally do the right thing and overwrite the file. 
Right? So it ends up working, but it's much slower than it should behave. This 
could be improved with a free space check, right?

INLINE COMMENTS

> filecopyjob.cpp:479
> +if (job == d->m_copyJob) {
> +d->m_bFileWriteInProgress = false;
> +}

"file write" sounds like putJob, which isn't what this is about.

I guess this should be called d->m_bFileCopyInProgress instead.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18904

To: chinmoyr, dfaure, dmitrio, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns


D18673: Add symlinks for flatpak

2019-03-06 Thread Nibaldo González
nibags added a comment.


  +1
  Also missing the symlink for JDownloader (org.jdownloader.JDownloader.svg): 
https://flathub.org/apps/details/org.jdownloader.JDownloader
  
  I don't know if it's also necessary to add symlinks for AppImage apps: 
https://appimage.github.io/apps/
  For example: hotspot.svg -> appimagekit-hotspot.svg

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18673

To: GeeXT, #frameworks
Cc: nibags, kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 11 - Unstable!

2019-03-06 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/11/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 06 Mar 2019 21:43:20 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5WindowSystem-5.56.0.xmlcompat_reports/KF5WindowSystem_compat_report.htmllogs/KF5WindowSystem/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7166/9546)55%
(3542/6397)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3054/3138)53%
(1298/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)54%
(748/1387)42%
(281/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3357/4664)61%
(1960/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 10 - Still Unstable!

2019-03-06 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/10/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 06 Mar 2019 21:43:20 +
 Build duration:
3 min 17 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5WindowSystem-5.56.0.xmlcompat_reports/KF5WindowSystem_compat_report.htmllogs/KF5WindowSystem/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7175/9550)55%
(3537/6397)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3045/3138)52%
(1290/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(786/1391)45%
(303/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3337/4664)60%
(1941/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Still Unstable!

2019-03-06 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/12/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 06 Mar 2019 21:43:21 +
 Build duration:
2 min 15 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test

D19544: Send blur/background contrast in device pixels

2019-03-06 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R278:abcf323ab6f3: Send blur/background contrast in device 
pixels (authored by davidedmundson).

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19544?vs=53210=53319

REVISION DETAIL
  https://phabricator.kde.org/D19544

AFFECTED FILES
  src/kwindoweffects.h
  src/platforms/xcb/kwindoweffects.cpp

To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns


D19575: Add collapse-all and expand-all action icons

2019-03-06 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks great to me!

REPOSITORY
  R266 Breeze Icons

BRANCH
  collapse-expand-all-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns


D19575: Add collapse-all and expand-all action icons

2019-03-06 Thread TrickyRicky
trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D19575: Add collapse-all and expand-all action icons

2019-03-06 Thread TrickyRicky
trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D19575: Add collapse-all and expand-all action icons

2019-03-06 Thread TrickyRicky
trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D18604: Implement support for writing rating information for taglib writer

2019-03-06 Thread Stefan Brüns
bruns requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18604

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams


D19575: Add collapse-all and expand-all action icons

2019-03-06 Thread TrickyRicky
trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  collapse-expand-all-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19575

AFFECTED FILES
  icons-dark/actions/16/collapse-all.svg
  icons-dark/actions/16/expand-all.svg
  icons-dark/actions/22/collapse-all.svg
  icons-dark/actions/22/expand-all.svg
  icons-dark/actions/24/collapse-all.svg
  icons-dark/actions/24/expand-all.svg
  icons-dark/actions/32/collapse-all.svg
  icons-dark/actions/32/expand-all.svg
  icons-dark/actions/symbolic/collapse-all.svg
  icons-dark/actions/symbolic/expand-all.svg
  icons/actions/16/collapse-all.svg
  icons/actions/16/expand-all.svg
  icons/actions/22/collapse-all.svg
  icons/actions/22/expand-all.svg
  icons/actions/24/collapse-all.svg
  icons/actions/24/expand-all.svg
  icons/actions/32/collapse-all.svg
  icons/actions/32/expand-all.svg
  icons/actions/symbolic/collapse-all.svg
  icons/actions/symbolic/expand-all.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D19532: Don't crash when no contexts are present

2019-03-06 Thread Christoph Cullmann
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  In D19532#426005 , @vkrause wrote:
  
  > In D19532#425432 , @cullmann 
wrote:
  >
  > > Ok with that.
  > >  Volker, ok, too?
  > >  I think the if(...isLoaded) removal is a diff artifact, that was never 
in the original code bug just in the first try here.
  >
  >
  > Yep, replacing the assert certainly makes sense. This would assume though 
that the caller of initalContext() expects a nullptr return value already, 
which I guess is the case if this doesn't crash somewhere else now :)
  
  
  Hmm, actually that part of the diff is not needed, either.
  No caller is able to handle nullptrs, but that just doesn't happen.
  
  I would like to have that change removed, then we can apply this.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19532

To: davispuh, cullmann, dhaumann, vandenoever, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann


D19307: Enforce new muted icon style in all action icons

2019-03-06 Thread TrickyRicky
trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19307

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns


Re: kconf_update lost its update.log in 2014

2019-03-06 Thread Albert Astals Cid
El divendres, 1 de març de 2019, a les 11:21:04 CET, Harald Sitter va escriure:
> On Thu, Feb 28, 2019 at 8:20 PM Albert Astals Cid  wrote:
> >
> > El dijous, 28 de febrer de 2019, a les 12:43:07 CET, Harald Sitter va 
> > escriure:
> > > ...and I don't understand why
> > >
> > > Hi!
> > >
> > > this commit [1] wrapped KonfUpdate::log's update.log stream in `#if 0`
> > > and thus disabling the update.log writing, replacing it with logging
> > > to stderr instead. Why it does that eludes me though. It seems
> > > entirely unrelated to the rest of the commit.
> >
> > Yep, maybe he was testing on windows, that code had issues on windows, 
> > disabled it for the moment and then forgot to reenable?
> >
> > Sound we try CC'ing Alex Richardson in case he remembers? Or you did and it 
> > got lost because he's on the list?
> 
> He's in the CC of my original mail.
> 
> > > Should the update.log writing happen? I expect this won't be super
> > > reliable because I think these days the application itself forks
> > > kconf_update.
> >
> > I don't understand what you mean with this. kconf_update has always been 
> > its own application as far as i know.
> 
> I noticed KConfig::checkUpdate which would invoke the helper per
> config (i.e. there could be multiple helpers running at the same time,
> since checkUpdate could be called by multiple applications at the same
> time) which would then cause out-of-order writes to the log from the
> different inputs. Specifically it looks that the qtextstream was
> buffered. After a second look checkUpdate seems to be a possibility
> *in addition* to kded's global update run, my original thinking was
> that the kded updating went away in favor of more atomic updating.
> 
> I find myself agreeing with Aleix that simply using QDebug is probably
> the smart way to move forward.
> 
> Unfortunately I now have even more questions... namely: wouldn't every
> application actually need to checkUpdate in case they are run in a
> !plasma environment without kded? Otherwise kconf_update would never
> get run. IOW: in a kde frameworks world order isn't the assumption
> that kded is not running and therefore KConfig itself needs to run the
> update?

Probably. The docu of KConfig::checkUpdate is kind of clear about that if you 
really need an update you should be using this method.

A different thing is if people are reading the documentation :D

Cheers,
  Albert

> 
> HS
> 






D19557: Update css

2019-03-06 Thread Kai Uwe Broulik
broulik added a comment.


  Can't we just go SVG with the icon?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, 
ngraham, bruns, skadinna


D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

2019-03-06 Thread Albert Astals Cid
aacid added a comment.


  The code is fine, the bigger question here is if we want new features in 
khtml that is part of the "portingAids" part of frameworks.

INLINE COMMENTS

> khtmlview.h:207
> + * @param quick if true, fully automated printing, without print dialog
> + */
> +void print(QPrinter *printer, bool quick = false);

Needs a @since marker.

REPOSITORY
  R313 KHtml

REVISION DETAIL
  https://phabricator.kde.org/D19504

To: habacker
Cc: aacid, tbaumgart, kde-frameworks-devel, michaelh, ngraham, bruns


D19557: Update css

2019-03-06 Thread Albert Astals Cid
aacid added a comment.


  Why changing from jpg to png for the image file ?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, 
bruns, skadinna


KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 45 - Still Unstable!

2019-03-06 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/45/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 06 Mar 2019 17:01:08 +
 Build duration:
21 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.56.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32834/60375)38%
(17042/44354)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9241/9683)48%
(4345/9083)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8399/14390)51%
(4714/9321)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)55%
(4353/7987)40%
(1917/4777)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(540/1055)36%
(320/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4291)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

D19532: Don't crash when no contexts are present

2019-03-06 Thread Volker Krause
vkrause added a comment.


  In D19532#425432 , @cullmann wrote:
  
  > Ok with that.
  >  Volker, ok, too?
  >  I think the if(...isLoaded) removal is a diff artifact, that was never in 
the original code bug just in the first try here.
  
  
  Yep, replacing the assert certainly makes sense. This would assume though 
that the caller of initalContext() expects a nullptr return value already, 
which I guess is the case if this doesn't crash somewhere else now :)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19532

To: davispuh, cullmann, dhaumann, vandenoever, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann


KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 49 - Still Unstable!

2019-03-06 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/49/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 06 Mar 2019 17:01:08 +
 Build duration:
6 min 26 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 32 - Still Unstable!

2019-03-06 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/32/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 06 Mar 2019 17:01:08 +
 Build duration:
6 min 6 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.56.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32804/60382)38%
(17021/44357)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9243/9683)48%
(4346/9083)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8391/14398)51%
(4714/9324)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4349/7987)40%
(1913/4777)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(540/1055)36%
(320/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
   

D19422: Fix upper/lower case rename on case insensitive fs

2019-03-06 Thread Chinmoy Ranjan Pradhan
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ef5b9c6991aa: Fix upper/lower case rename on case 
insensitive fs (authored by hoffmannrobert, committed by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19422?vs=53051=53301

REVISION DETAIL
  https://phabricator.kde.org/D19422

AFFECTED FILES
  src/core/copyjob.cpp

To: hoffmannrobert, #frameworks, #dolphin, dfaure, chinmoyr
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

2019-03-06 Thread Ralf Habacker
habacker marked an inline comment as done.
habacker added inline comments.

INLINE COMMENTS

> tbaumgart wrote in khtmlview.cpp:3134
> Why don't you pass a reference to the QPrinter object here?

Because api  dealing with QPrinter always use a pointer.

void QWebView::print(QPrinter *)
void QPrintPreviewDialog::paintRequested(QPrinter *printer)
QPrintPreviewDialog(QPrinter *printer, QWidget *parent = nullptr, 
Qt::WindowFlags flags = Qt::WindowFlags()
QPrintDialog(QPrinter * printer, QWidget * parent = 0)
QPageSetupDialog(QPrinter *printer, QWidget *parent)
QPrintPreviewWidget(QPrinter *printer, QWidget *parent, Qt::WindowFlags flags)

REPOSITORY
  R313 KHtml

REVISION DETAIL
  https://phabricator.kde.org/D19504

To: habacker
Cc: tbaumgart, kde-frameworks-devel, michaelh, ngraham, bruns


D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

2019-03-06 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 53299.
kossebau added a comment.


  update to latest master

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19565?vs=53273=53299

BRANCH
  configfileextensions

REVISION DETAIL
  https://phabricator.kde.org/D19565

AFFECTED FILES
  KF5ConfigMacros.cmake
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/test_fileextensions.kcfg
  autotests/kconfig_compiler/test_fileextensions.kcfgc
  autotests/kconfig_compiler/test_fileextensions_main.cxx
  src/kconfig_compiler/README.dox
  src/kconfig_compiler/checkkcfg.pl
  src/kconfig_compiler/kconfig_compiler.cpp

To: kossebau, #frameworks
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns


D19567: KCONFIG_ADD_KCFG_FILES macro: ensure a change of File= in kcfg is picked up

2019-03-06 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:d996a0fba67d: KCONFIG_ADD_KCFG_FILES macro: ensure a 
change of File= in kcfg is picked up (authored by kossebau).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19567?vs=53283=53298

REVISION DETAIL
  https://phabricator.kde.org/D19567

AFFECTED FILES
  KF5ConfigMacros.cmake

To: kossebau, #frameworks, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns


D19567: KCONFIG_ADD_KCFG_FILES macro: ensure a change of File= in kcfg is picked up

2019-03-06 Thread Friedrich W. H. Kossebau
kossebau added a comment.


  @apol Thanks for review :)

REPOSITORY
  R237 KConfig

BRANCH
  reruncmakeonkfgcchange

REVISION DETAIL
  https://phabricator.kde.org/D19567

To: kossebau, #frameworks, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns


D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

2019-03-06 Thread loh tar
loh.tar updated this revision to Diff 53296.
loh.tar retitled this revision from "DocumentPrivate: Auto reload in read-only 
mode" to "DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt".
loh.tar edited the summary of this revision.
loh.tar edited the test plan for this revision.
loh.tar added a comment.


  - Add option "Enable Auto Reload" to ModOnHdPrompt
  - Allow also auto reload for not read-only files
  - Only auto reload when doc is unmodified
  - Only reload when no reload is in progress, may that not enough to avoid 
mentioned lock up?
  
  Issues:
  
  - The new button is slightly dangerous placed for my taste but with intend 
not nearby the normal reload button
  - No other way to disable that setting than to close/open the file
  - The reload is only triggered when the application has the focus, but that 
may be an intended behavior
  
  TODO(?)
  
  - Add getter function so that e.g. the status bar can show a suitable icon to 
indicate that mode and the ModOnHdPrompt can hide that button in case of an 
already active setting
  - Add some option/action to the view so that the view scrolls down after an 
auto reload

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19517?vs=53132=53296

REVISION DETAIL
  https://phabricator.kde.org/D19517

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/katedialogs.h
  src/document/katedocument.cpp
  src/document/katedocument.h

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann


D18904: [FileCopyJob] Clean up after file copy operation is cancelled

2019-03-06 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 53297.
chinmoyr added a comment.


  Remove unrelated changes commited by mistake.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18904?vs=53291=53297

BRANCH
  arcpatch-D18904 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18904

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/filecopyjob.cpp
  src/core/filecopyjob.h

To: chinmoyr, dfaure, dmitrio, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns


D19570: Add "." as weakDeliminator in Octave syntax file and update tests

2019-03-06 Thread Nikita Sirgienko
sirgienko created this revision.
sirgienko added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
sirgienko requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  octave-weak-delimiter

REVISION DETAIL
  https://phabricator.kde.org/D19570

AFFECTED FILES
  autotests/html/test.octave.html
  autotests/reference/test.octave.ref
  data/syntax/octave.xml

To: sirgienko, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann


D18904: [FileCopyJob] Clean up after file copy operation is cancelled

2019-03-06 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 53291.
chinmoyr added a comment.


  Delete .part file when Overwrite flag is set.
  
  @dfaure please have a look at it again.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18904?vs=51383=53291

BRANCH
  arcpatch-D18904_1

REVISION DETAIL
  https://phabricator.kde.org/D18904

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/filecopyjob.cpp
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, dfaure, dmitrio, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns


D19422: Fix upper/lower case rename on case insensitive fs

2019-03-06 Thread Robert Hoffmann
hoffmannrobert added a comment.


  Could you please land it for me, I don't have commit access. Thanks.

REPOSITORY
  R241 KIO

BRANCH
  fix_case_rename

REVISION DETAIL
  https://phabricator.kde.org/D19422

To: hoffmannrobert, #frameworks, #dolphin, dfaure, chinmoyr
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D19422: Fix upper/lower case rename on case insensitive fs

2019-03-06 Thread Chinmoy Ranjan Pradhan
chinmoyr accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  fix_case_rename

REVISION DETAIL
  https://phabricator.kde.org/D19422

To: hoffmannrobert, #frameworks, #dolphin, dfaure, chinmoyr
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D19567: KCONFIG_ADD_KCFG_FILES macro: ensure a change of File= in kcfg is picked up

2019-03-06 Thread Aleix Pol Gonzalez
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Cool!

REPOSITORY
  R237 KConfig

BRANCH
  reruncmakeonkfgcchange

REVISION DETAIL
  https://phabricator.kde.org/D19567

To: kossebau, #frameworks, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns


D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

2019-03-06 Thread Aleix Pol Gonzalez
apol added a comment.


  +1 LGTM

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D19565

To: kossebau, #frameworks
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns


D19567: KCONFIG_ADD_KCFG_FILES macro: ensure a change of File= in kcfg is picked up

2019-03-06 Thread Friedrich W. H. Kossebau
kossebau created this revision.
kossebau added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  The build configuration depends on the value of the "File=" entry in the
  kcfg file, as this file name is used in the build instructions.
  So if the name is changed, cmake would need to be rerun.
  Adding the kcfgc file to CMAKE_CONFIGURE_DEPENDS makes cmake know about that
  dependency.
  While this will also result in a reconfiguarion if non-File entries are
  edited, this should not happen too often, so the extra costs outweighs the
  unexpected and confusing behaviour due to outdated build instructions
  in case the File= entry is changed.

TEST PLAN
  Before this change renaming a kcfg file before did not trigger a rerun of 
cmake,
  resulting in outdated builds instructions and unexpected behaviour.
  With this change cmake is rerun once the kcgc file is edited, so build
  instructions are always up-to-date.

REPOSITORY
  R237 KConfig

BRANCH
  reruncmakeonkfgcchange

REVISION DETAIL
  https://phabricator.kde.org/D19567

AFFECTED FILES
  KF5ConfigMacros.cmake

To: kossebau, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D19367: SearchBar: Don't block GUI when enter incremental pattern

2019-03-06 Thread loh tar
loh.tar updated this revision to Diff 53281.
loh.tar retitled this revision from "[RFC]SearchBar: Don't block GUI when enter 
incremental pattern" to "SearchBar: Don't block GUI when enter incremental 
pattern".
loh.tar edited the test plan for this revision.
loh.tar added a comment.


  - Consider multi line pattern
  - Remove notes from Test Plan
  
  TODOs, but how?
  
  - Fix failing autotest
  - Add autotest for feature?

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19367?vs=52728=53281

REVISION DETAIL
  https://phabricator.kde.org/D19367

AFFECTED FILES
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann


D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

2019-03-06 Thread Thomas Baumgart
tbaumgart added inline comments.

INLINE COMMENTS

> khtmlview.cpp:3134
> +
> +void KHTMLView::print(QPrinter *_printer, bool quick)
> +{

Why don't you pass a reference to the QPrinter object here?

REPOSITORY
  R313 KHtml

REVISION DETAIL
  https://phabricator.kde.org/D19504

To: habacker
Cc: tbaumgart, kde-frameworks-devel, michaelh, ngraham, bruns


D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

2019-03-06 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 53273.
kossebau added a comment.


  fixup: correct default cpp for SourceExtension in README.dox

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19565?vs=53272=53273

BRANCH
  configfileextensions

REVISION DETAIL
  https://phabricator.kde.org/D19565

AFFECTED FILES
  KF5ConfigMacros.cmake
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/test_fileextensions.kcfg
  autotests/kconfig_compiler/test_fileextensions.kcfgc
  autotests/kconfig_compiler/test_fileextensions_main.cxx
  src/kconfig_compiler/README.dox
  src/kconfig_compiler/checkkcfg.pl
  src/kconfig_compiler/kconfig_compiler.cpp

To: kossebau, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

2019-03-06 Thread Friedrich W. H. Kossebau
kossebau created this revision.
kossebau added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  When using kconfig_compiler generated sources in projects where the used
  file extensions for C++ files are not ".h" and/or ".cpp", the include for
  the generated header looks a bit alien to the project, as well as the
  generated source file if one looks closer at it.
  
  This code adds new optional flags HeaderExtension & SourceExtension which
  can be used to control the file extensions used for the generated files.

TEST PLAN
  All unit tests and the new test_fileextensions pass, existing projects using
  kcfg without & with the new flags build fine.

REPOSITORY
  R237 KConfig

BRANCH
  configfileextensions

REVISION DETAIL
  https://phabricator.kde.org/D19565

AFFECTED FILES
  KF5ConfigMacros.cmake
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/test_fileextensions.kcfg
  autotests/kconfig_compiler/test_fileextensions.kcfgc
  autotests/kconfig_compiler/test_fileextensions_main.cxx
  src/kconfig_compiler/README.dox
  src/kconfig_compiler/checkkcfg.pl
  src/kconfig_compiler/kconfig_compiler.cpp

To: kossebau, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 20 - Fixed!

2019-03-06 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/20/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 06 Mar 2019 12:05:54 +
 Build duration:
6 min 2 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.56.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 46 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/260)92%
(240/260)85%
(26869/31460)53%
(10778/20173)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12318/12393)50%
(6482/12887)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client99%
(73/74)99%
(73/74)85%
(6284/7396)65%
(1810/2799)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)87%
(7813/9018)66%
(2309/3498)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1291)0%
(0/313)

KDE CI: Frameworks » kholidays » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

2019-03-06 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Wed, 06 Mar 2019 11:39:25 +
 Build duration:
2 min 44 sec and counting

KDE CI: Frameworks » kitemmodels » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

2019-03-06 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Wed, 06 Mar 2019 11:39:24 +
 Build duration:
1 min 27 sec and counting

KDE CI: Frameworks » kitemviews » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

2019-03-06 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kitemviews/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Wed, 06 Mar 2019 11:39:23 +
 Build duration:
1 min 1 sec and counting

KDE CI: Frameworks » kplotting » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

2019-03-06 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kplotting/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Wed, 06 Mar 2019 11:39:22 +
 Build duration:
56 sec and counting

KDE CI: Frameworks » syndication » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

2019-03-06 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Wed, 06 Mar 2019 11:39:21 +
 Build duration:
54 sec and counting

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 29 - Still Unstable!

2019-03-06 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/29/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 06 Mar 2019 09:55:42 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.56.0.xmlacc/KF5PlasmaQuick-5.56.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3609/13344)18%
(1818/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(300/2263)7%
(96/1464)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 41 - Still Unstable!

2019-03-06 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/41/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 06 Mar 2019 09:55:42 +
 Build duration:
6 min 42 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 37 - Still Unstable!

2019-03-06 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/37/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 06 Mar 2019 09:55:42 +
 Build duration:
6 min 10 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.56.0.xmlacc/KF5PlasmaQuick-5.56.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3609/13344)18%
(1818/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(300/2263)7%
(96/1464)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%