D19771: Use placeholder instead of label

[loh tar]

loh.tar added a comment.


  > Hi, any more feedback on this?
  
  When in power mode, and the fields are filled, it is not clear what which 
field is.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19771

To: ognarb, #ktexteditor, #vdg
Cc: cullmann, cfeck, loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, 
domson, michaelh, bruns, demsking, sars, dhaumann

D21287: Try to find always an unique visible document name without a number suffix

[loh tar]

loh.tar added a comment.


  > the path is appended behind the document name. What about this solution?
  
  Don't like that idea. And fit not well to the shown "Document List" problem.
  
  > to be efficient one could hash all documents
  
  I'm always in favor for such. But here I had no idea how to do that nicely 
and reliable. One Document is not the place to hold such hash, and the patch 
lives only there.
  
  The "file rename case" may indeed not catch here when it goes from duplicate 
to unique, but how often is that the case? Guess nearby never and it is no big 
harm to keep the prefix in that case. "Untitled" documnets are handled as 
before.
  
  > that would avoid that one needs to iterate always again over all documents 
to collect duplicates.
  
  Is a loop running once over 10 to 1000 (one should rethink his workflow when 
he has so many files open) turns on a file name update such an issue and any 
optimization worth? Well, currently lead that on session restore to one million 
loops, how long may take that? And compared to the other needed work to open 
one file. Guess it's not a big thing.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21287

To: loh.tar, #ktexteditor
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
domson, michaelh, ngraham, bruns, demsking, sars

D21356: Port to ECMAddQmlModule, add plugins.qmltypes files

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R296 KDeclarative

BRANCH
  porttoECMInstallQmlModules

REVISION DETAIL
  https://phabricator.kde.org/D21356

AFFECTED FILES
  CMakeLists.txt
  src/qmlcontrols/draganddrop/CMakeLists.txt
  src/qmlcontrols/draganddrop/plugins.qmltypes
  src/qmlcontrols/draganddrop/qmldir
  src/qmlcontrols/kcmcontrols/CMakeLists.txt
  src/qmlcontrols/kcmcontrols/plugins.qmltypes
  src/qmlcontrols/kcmcontrols/qml/qmldir
  src/qmlcontrols/kconfig/CMakeLists.txt
  src/qmlcontrols/kconfig/plugins.qmltypes
  src/qmlcontrols/kconfig/qmldir
  src/qmlcontrols/kcoreaddons/CMakeLists.txt
  src/qmlcontrols/kcoreaddons/plugins.qmltypes
  src/qmlcontrols/kcoreaddons/qmldir
  src/qmlcontrols/kioplugin/CMakeLists.txt
  src/qmlcontrols/kioplugin/plugins.qmltypes
  src/qmlcontrols/kioplugin/qmldir
  src/qmlcontrols/kquickcontrols/CMakeLists.txt
  src/qmlcontrols/kquickcontrols/plugins.qmltypes
  src/qmlcontrols/kquickcontrols/private/CMakeLists.txt
  src/qmlcontrols/kquickcontrols/private/plugins.qmltypes
  src/qmlcontrols/kquickcontrols/private/qmldir
  src/qmlcontrols/kquickcontrols/qmldir
  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt
  src/qmlcontrols/kquickcontrolsaddons/plugins.qmltypes
  src/qmlcontrols/kquickcontrolsaddons/qmldir
  src/qmlcontrols/kwindowsystemplugin/CMakeLists.txt
  src/qmlcontrols/kwindowsystemplugin/plugins.qmltypes
  src/qmlcontrols/kwindowsystemplugin/qmldir

To: kossebau, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21355: Fix qmldir files

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  By what I learned the last weeks about the requirements with qmldir files,
  these fixes here seem needed.
  Not exactly sure why things seems to have worked despite that.

REPOSITORY
  R296 KDeclarative

BRANCH
  improveqmldirs

REVISION DETAIL
  https://phabricator.kde.org/D21355

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/qmldir
  src/qmlcontrols/kquickcontrols/private/qmldir
  src/qmlcontrols/kquickcontrols/qmldir
  src/qmlcontrols/kquickcontrolsaddons/qmldir

To: kossebau, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21354: Port to new connect syntax

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> ngraham wrote in delegate.cpp:46
> I'd love to, and I tried, but this stuff is pretty new to me and I kept 
> getting `error: cannot define member function` What's wrong with this?
> 
>   connect(comboBox, &QComboBox::activated,
>   [comboBox]() { emit commitData(comboBox); });

without having tried it, you probably still need the QOverload to say which 
activated version you want, so

connect(comboBox, QOverload::of(&QComboBox::activated), this, [this, 
comboBox] { emit commitData(comboBox); });

> ngraham wrote in delegate.h:41
> `QComboBox::activated` passes an int argument along that as far as I can tell 
> (I could be wrong) needs to be handled by the function it's connected to

nah, the right hand side needs to be a subset of the left hand side (or be able 
to convert from one to another)

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21354

To: ngraham, #frameworks, apol
Cc: bruns, aacid

D21354: Port to new connect syntax

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> ngraham wrote in delegate.cpp:46
> I'd love to, and I tried, but this stuff is pretty new to me and I kept 
> getting `error: cannot define member function` What's wrong with this?
> 
>   connect(comboBox, &QComboBox::activated,
>   [comboBox]() { emit commitData(comboBox); });

commitData is an inherited member function from `QItemDelegate`, i.e. you have 
to also capture `this`

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21354

To: ngraham, #frameworks, apol
Cc: bruns, aacid

D21354: Port to new connect syntax

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> bruns wrote in delegate.cpp:46
> use a lambda here:
> 
> - avoids the single-use `emitCommitData` wrapper
> - avoids the need for `qobject_cast(sender())`, which is the 
> combobox (just capture it).

I'd love to, and I tried, but this stuff is pretty new to me and I kept getting 
`error: cannot define member function` What's wrong with this?

  connect(comboBox, &QComboBox::activated,
  [comboBox]() { emit commitData(comboBox); });

> aacid wrote in delegate.h:41
> why add the int if you're not going to use it?

`QComboBox::activated` passes an int argument along that as far as I can tell 
(I could be wrong) needs to be handled by the function it's connected to

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21354

To: ngraham, #frameworks, apol
Cc: bruns, aacid

D20197: Fix desktop link to file or directory

[Stefan Brüns]

bruns added a comment.


  I think this can go in now, as the i18n strings are not actually new - grep 
src/widgets/fileundomanager.cpp for `i18n("File")` and `i18n("Directory")`.

REPOSITORY
  R241 KIO

BRANCH
  fix_desktop_link_filter

REVISION DETAIL
  https://phabricator.kde.org/D20197

To: hoffmannrobert, #frameworks, ngraham, dfaure
Cc: bruns, michaelweghorn, ngraham, kde-frameworks-devel, michaelh

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 108 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/108/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 22 May 2019 22:18:21 +
 Build duration:
14 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.59.0.xmlacc/KF5PlasmaQuick-5.59.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3633/13378)18%
(1823/9885)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2274)6%
(92/1475)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1419/3511)28%
(793/2831)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 101 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/101/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 22 May 2019 22:18:21 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.59.0.xmlacc/KF5PlasmaQuick-5.59.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3633/13378)18%
(1823/9885)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2274)6%
(92/1475)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1419/3511)28%
(793/2831)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
 

D21354: Port to new connect syntax

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> sambausershareplugin.cpp:126
> +connect(propertiesUi.sambaChk, &QCheckBox::toggled,
> +this, &SambaUserSharePlugin::changed);
> +connect(propertiesUi.sambaNameEdit, &QLineEdit::textChanged,

I think instead of emiting `KFilePropertiesPlugin::changed()` it would be 
better to call `setDirty()` in the slots.

See 
https://api.kde.org/frameworks/kio/html/classKPropertiesDialogPlugin.html#af25f4b84d915dcc005a203a637ad0511

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21354

To: ngraham, #frameworks, apol
Cc: bruns, aacid

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 111 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/111/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 22 May 2019 22:18:21 +
 Build duration:
8 min 9 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D21349: Use simply configure_file to generate the plasmacomponents3 files

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:b0850b1f6fc7: Use simply configure_file to generate the 
plasmacomponents3 files (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21349?vs=58500&id=58516

REVISION DETAIL
  https://phabricator.kde.org/D21349

AFFECTED FILES
  src/declarativeimports/CMakeLists.txt

To: kossebau, #plasma, mart, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21354: Port to new connect syntax

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> delegate.cpp:46
> +connect(comboBox, QOverload::of(&QComboBox::activated),
> +this, &UserPermissionDelegate::emitCommitData);
>  

use a lambda here:

- avoids the single-use `emitCommitData` wrapper
- avoids the need for `qobject_cast(sender())`, which is the combobox 
(just capture it).

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21354

To: ngraham, #frameworks, apol
Cc: bruns, aacid

D21327: Support installing multiple Samba packages

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> sambausershareplugin.cpp:43
>  
>  // copied from kio/src/core/ksambashare.cpp, 
> KSambaSharePrivate::isSambaInstalled()
>  static bool isSambaInstalled()

see here ^

`net` is not checked for at all, it just tries to execute it using 
`QProcess::start("net", args)`

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21327

To: ngraham, apol, #frameworks
Cc: bruns

D21349: Use simply configure_file to generate the plasmacomponents3 files

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  simplefileconfigure

REVISION DETAIL
  https://phabricator.kde.org/D21349

To: kossebau, #plasma, mart, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21354: Port to new connect syntax

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> delegate.h:41
> +private:
> +void emitCommitData(int index);
>  };

why add the int if you're not going to use it?

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21354

To: ngraham, #frameworks, apol
Cc: aacid

D21354: Port to new connect syntax

[Nathaniel Graham]

ngraham updated this revision to Diff 58513.
ngraham added a comment.


  Remove extra space

REPOSITORY
  R432 File Sharing (Samba) integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21354?vs=58512&id=58513

BRANCH
  port-to-new-connect-symtax (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21354

AFFECTED FILES
  samba/filepropertiesplugin/delegate.cpp
  samba/filepropertiesplugin/delegate.h
  samba/filepropertiesplugin/sambausershareplugin.cpp
  samba/filepropertiesplugin/sambausershareplugin.h

To: ngraham, #frameworks, apol

D21354: Port to new connect syntax

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Frameworks, apol.
ngraham requested review of this revision.

TEST PLAN
  - It compiles
  - Tested all functionality; everything works (well... at least everything 
that was working before is still working now :) )

REPOSITORY
  R432 File Sharing (Samba) integration

BRANCH
  port-to-new-connect-symtax (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21354

AFFECTED FILES
  samba/filepropertiesplugin/delegate.cpp
  samba/filepropertiesplugin/delegate.h
  samba/filepropertiesplugin/sambausershareplugin.cpp
  samba/filepropertiesplugin/sambausershareplugin.h

To: ngraham, #frameworks, apol

D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:bbc465981bd5: SyntaxHighlighter: Fix foreground color for 
text without special highlighting (authored by dhaumann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21295?vs=58315&id=58511#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21295?vs=58315&id=58511

REVISION DETAIL
  https://phabricator.kde.org/D21295

AFFECTED FILES
  examples/codeeditor/codeeditor.cpp
  src/lib/syntaxhighlighter.cpp

To: dhaumann, vkrause, cullmann, kossebau
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19677: WIP: Port UDisks to using DBus ObjectManager

[Aleix Pol Gonzalez]

apol added a comment.


  +1 do we know what's stopping this to move forward?
  
  At least the commit message needs addressing.

INLINE COMMENTS

> udisksmanager.h:41
>  
> +// interface -> [ {property: key}, {property: key}, ... ]
> +using PropertyMap = QMap;

This comment looks wrong. If this was the case it would be QList

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D19677

To: broulik, #frameworks, bruns
Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

D21349: Use simply configure_file to generate the plasmacomponents3 files

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D21349#468698 , @apol wrote:
  
  > Won't it need installing then?
  
  
  It is installed as before, by code below
  
install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/plasmacomponents3/ 
DESTINATION ${KDE_INSTALL_QMLDIR}/QtQuick/Controls.2/Plasma)
  
  and then the one partially also copying over for other needs once more.
  
  > What are we fixing here?
  
  The use of the not that much right macro to use for the need. Which here is 
to apply QQC2_VERSION to the qml template files and nothing more,  by what I 
saw?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21349

To: kossebau, #plasma, mart
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20655: Use generated DBus interface

[Aleix Pol Gonzalez]

apol added a comment.


  UPower already installs the xml files. Wouldn't it be better to use the 
installed xml instead of providing our own?

INLINE COMMENTS

> upowerdevice.cpp:35
>  
> +#include 
> +

unneeded?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20655

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21349: Use simply configure_file to generate the plasmacomponents3 files

[Aleix Pol Gonzalez]

apol added a comment.


  Won't it need installing then?
  What are we fixing here?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21349

To: kossebau, #plasma, mart
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21327: Support installing multiple Samba packages

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R432:0b2e51981044: Support installing multiple Samba packages 
(authored by ngraham).

REPOSITORY
  R432 File Sharing (Samba) integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21327?vs=58484&id=58505

REVISION DETAIL
  https://phabricator.kde.org/D21327

AFFECTED FILES
  CMakeLists.txt
  samba/filepropertiesplugin/sambausershareplugin.cpp
  samba/filepropertiesplugin/sambausershareplugin.h

To: ngraham, apol, #frameworks
Cc: bruns

D21327: Support installing multiple Samba packages

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  I wouldn't have made it better :D

REPOSITORY
  R432 File Sharing (Samba) integration

BRANCH
  support-multiple-samba-packages (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21327

To: ngraham, apol, #frameworks
Cc: bruns

D21350: plasmacore: fix qmldir, ToolTip.qml no longer part of module

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  cleancoreqmldir

REVISION DETAIL
  https://phabricator.kde.org/D21350

AFFECTED FILES
  src/declarativeimports/core/qmldir

To: kossebau, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21349: Use simply configure_file to generate the plasmacomponents3 files

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  simplefileconfigure

REVISION DETAIL
  https://phabricator.kde.org/D21349

AFFECTED FILES
  src/declarativeimports/CMakeLists.txt

To: kossebau, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21344: Port to ECMAddQmlModule

[Friedrich W. H. Kossebau]

kossebau added a comment.


  The diff between the generated qmldir files and the manually written ones 
looks good. And also showed the one of plasmacore has some left-over.

INLINE COMMENTS

> CMakeLists.txt:37
> +OBJECT_TYPES
> +BusyIndicator qml/BusyIndicator.qml
> +Button qml/Button.qml

All the repeated names make me wonder if the macro could be made even more nice 
by having it autoderive the type name from the file.  At least all the files in 
Plasma and the mojority in my own projects match this naming pattern.

As that might blow up the macro code a bit, first waiting for principal 
feedback.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21344

To: kossebau, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20984: Add ECMAddQmlModule

[Friedrich W. H. Kossebau]

kossebau retitled this revision from "Add ECMInstallQmlModules, with 
ecm_install_qmlplugin as start" to "Add ECMAddQmlModule".
kossebau edited the summary of this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D20984

To: kossebau, #plasma
Cc: apol, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, 
bruns

D21344: Port to ECMAddQmlModule

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 58492.
kossebau added a comment.


  also remove include of ECMGenerateQmlTypes, newer macros cover that as well

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21344?vs=58491&id=58492

BRANCH
  porttoECMInstallQmlModules

REVISION DETAIL
  https://phabricator.kde.org/D21344

AFFECTED FILES
  CMakeLists.txt
  src/declarativeimports/calendar/CMakeLists.txt
  src/declarativeimports/calendar/qml/qmldir
  src/declarativeimports/core/CMakeLists.txt
  src/declarativeimports/core/qmldir
  src/declarativeimports/plasmacomponents/CMakeLists.txt
  src/declarativeimports/plasmacomponents/qml/qmldir
  src/declarativeimports/plasmaextracomponents/CMakeLists.txt
  src/declarativeimports/plasmaextracomponents/qml/qmldir
  src/declarativeimports/platformcomponents/CMakeLists.txt
  src/declarativeimports/platformcomponents/qmldir

To: kossebau, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21344: Port to ECMAddQmlModule

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  While the current logic for Plasma QML modules is stable and all repeated
  data has been already repeated, porting to the new macros of ECMAddQmlModule
  can help others to learn about the macros and how to use them.
  
  Perhaps there could also be a special macro for the generation stuff being
  done for components3, for that some other potential users would be first
  good to have to know more patterns.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  porttoECMInstallQmlModules

REVISION DETAIL
  https://phabricator.kde.org/D21344

AFFECTED FILES
  CMakeLists.txt
  src/declarativeimports/calendar/CMakeLists.txt
  src/declarativeimports/calendar/qml/qmldir
  src/declarativeimports/core/CMakeLists.txt
  src/declarativeimports/core/qmldir
  src/declarativeimports/plasmacomponents/CMakeLists.txt
  src/declarativeimports/plasmacomponents/qml/qmldir
  src/declarativeimports/plasmaextracomponents/CMakeLists.txt
  src/declarativeimports/plasmaextracomponents/qml/qmldir
  src/declarativeimports/platformcomponents/CMakeLists.txt
  src/declarativeimports/platformcomponents/qmldir

To: kossebau, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 58490.
kossebau added a comment.


  Renamed to ECMAddQmlModule, with more helper macros for non-C++ parts

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20984?vs=57481&id=58490

BRANCH
  addinstallqmlplugin

REVISION DETAIL
  https://phabricator.kde.org/D20984

AFFECTED FILES
  docs/module/ECMAddQmlModule.rst
  modules/ECMAddQmlModule.cmake

To: kossebau, #plasma
Cc: apol, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, 
bruns

D21327: Support installing multiple Samba packages

[Nathaniel Graham]

ngraham marked an inline comment as done.

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21327

To: ngraham, apol, #frameworks
Cc: bruns

D21327: Support installing multiple Samba packages

[Nathaniel Graham]

ngraham updated this revision to Diff 58484.
ngraham added a comment.


  Make it work (Thanks @apol for contributing virtually all of this code)

REPOSITORY
  R432 File Sharing (Samba) integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21327?vs=58445&id=58484

BRANCH
  support-multiple-samba-packages (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21327

AFFECTED FILES
  CMakeLists.txt
  samba/filepropertiesplugin/sambausershareplugin.cpp
  samba/filepropertiesplugin/sambausershareplugin.h

To: ngraham, apol, #frameworks
Cc: bruns

D20197: Fix desktop link to file or directory

[Nathaniel Graham]

ngraham added a comment.


  Because it has new strings though, I'm afraid this is 5.60 material because 
we're past the 5.59 string freeze. Making a note on my calendar so it doesn't 
get lost again...

REPOSITORY
  R241 KIO

BRANCH
  fix_desktop_link_filter

REVISION DETAIL
  https://phabricator.kde.org/D20197

To: hoffmannrobert, #frameworks, ngraham, dfaure
Cc: michaelweghorn, ngraham, kde-frameworks-devel, michaelh, bruns

D20197: Fix desktop link to file or directory

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Oops, sorry I lost track of this. LGTM now. Let's get it in.

REPOSITORY
  R241 KIO

BRANCH
  fix_desktop_link_filter

REVISION DETAIL
  https://phabricator.kde.org/D20197

To: hoffmannrobert, #frameworks, ngraham, dfaure
Cc: michaelweghorn, ngraham, kde-frameworks-devel, michaelh, bruns

D19771: Use placeholder instead of label

[Nathaniel Graham]

ngraham added a comment.


  In D19771#440886 , @cullmann wrote:
  
  > Hi, if we do that: Could we then remove the "Mode:", too and move that into 
the combobox?
  >  Perhaps like "Plain text search", "Whole words search", ...
  >  Otherwise the search&replace doesn't save space and it looks "strange".
  
  
  Agreed, makes sense to me. @ognarb, can you look into doing this?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19771

To: ognarb, #ktexteditor, #vdg
Cc: cullmann, cfeck, loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, 
domson, michaelh, bruns, demsking, sars, dhaumann

D21327: Support installing multiple Samba packages

[Nathaniel Graham]

ngraham added a comment.


  In D21327#468390 , @bruns wrote:
  
  > There are two executables required two run the samba integration properly:
  >
  > - smbd
  > - net
  >
  >   But this is actually an implementation detail of KSambaShare from 
KIOCore. Wouldn't it be better to query the required packages from KSambaShare 
instead?
  
  
  Hmm, maybe. I don't see where that's actually specified in KSambaShare 
though. Can you help me find it?

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21327

To: ngraham, apol, #frameworks
Cc: bruns

D19771: Use placeholder instead of label

[Christoph Cullmann]

cullmann added a comment.


  Hi, any more feedback on this?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19771

To: ognarb, #ktexteditor, #vdg
Cc: cullmann, cfeck, loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, 
domson, michaelh, bruns, demsking, sars, dhaumann

D20815: Ensure highlighted folding marker after unfold

[Christoph Cullmann]

cullmann added a comment.


  Ok, I see, I tried it a bit more and yes, now the folding start/end tokens 
are highlighted on unfold.
  Btw., is it intentional that the folding start/end tokens are only sometimes 
highlighted on folding, still?
  
  e.g. not for the
  
if (trueValues.contains(val)) {
*result = true;
return true;
}
  
  case?

REVISION DETAIL
  https://phabricator.kde.org/D20815

To: loh.tar, #ktexteditor
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D20959: Allow to change the Mode, after changing the Highlighting

[Christoph Cullmann]

cullmann closed this revision.
cullmann added a comment.


  Ok, regression taken care of in D21331 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20959

To: nibags, #ktexteditor, #kate, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D20815: Ensure highlighted folding marker after unfold

[Christoph Cullmann]

cullmann added a comment.


  I must confess, I am a bit confused what this patch should improve.
  Could you tell again which concrete issue it fixes?
  And why is the delete not useful?

REVISION DETAIL
  https://phabricator.kde.org/D20815

To: loh.tar, #ktexteditor
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D21287: Try to find always an unique visible document name without a number suffix

[Christoph Cullmann]

cullmann added a comment.


  I think for 2 one still needs a clever way to compute the "short" path. I 
think the document list tries to create shortest unique "suffixes".
  For 1) to be efficient one could hash all documents with "filename" => 
documents with that if file names changes, that would avoid that one needs to 
iterate always again over all documents to collect duplicates.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21287

To: loh.tar, #ktexteditor
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
domson, michaelh, ngraham, bruns, demsking, sars

D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Given nobody proposes a working alternative, lets go with this.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-syntax-highlighter-default-color

REVISION DETAIL
  https://phabricator.kde.org/D21295

To: dhaumann, vkrause, cullmann, kossebau
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21339: Block a bit less when introspecting udisks

[Nathaniel Graham]

ngraham added a reviewer: bruns.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21339

To: apol, #frameworks, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21339: Block a bit less when introspecting udisks

[Aleix Pol Gonzalez]

apol updated this revision to Diff 58469.
apol added a comment.


  iteration

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21339?vs=58468&id=58469

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21339

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksmanager.cpp
  src/solid/devices/backends/udisks2/udisksmanager.h

To: apol, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21339: Block a bit less when introspecting udisks

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Allow both introspections to happen in parallel

TEST PLAN
  tests still pass, solid-hardware5 output is still the same

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21339

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksmanager.cpp
  src/solid/devices/backends/udisks2/udisksmanager.h

To: apol, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21327: Support installing multiple Samba packages

[Stefan Brüns]

bruns added a comment.


  There are two executables required two run the samba integration properly:
  
  - smbd
  - net
  
  But this is actually an implementation detail of KSambaShare from KIOCore. 
Wouldn't it be better to query the required packages from KSambaShare instead?

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21327

To: ngraham, apol, #frameworks
Cc: bruns

D21331: Fix: don't reset Highlight when saving some files

[Nibaldo González]

nibags closed this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21331

To: nibags, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21331: Fix: don't reset Highlight when saving some files

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Lets give this a try.

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-save-hl

REVISION DETAIL
  https://phabricator.kde.org/D21331

To: nibags, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21331: Fix: don't reset Highlight when saving some files

[Nibaldo González]

nibags created this revision.
nibags added reviewers: KTextEditor, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  BUG: 407763
  
  Fix the regression of patch D20959 .
  
  In sftp:// or fish:// files, the current syntax highlighting isn't stored in 
`$HOME/.config/katemetainfos`. 
  Therefore, when saving a file, the highlighting is reset. 
  This only happens when changing the hl from the "Highlighting" menu, not from 
the "Mode" menu.
  
  Basically, this returns to the state before the patch D20959 
, but now the highlight will always change 
if `user` is true.

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-save-hl

REVISION DETAIL
  https://phabricator.kde.org/D21331

AFFECTED FILES
  src/document/katedocument.cpp

To: nibags, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/26/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 22 May 2019 08:27:24 +
 Build duration:
2 min 6 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 118 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/118/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 22 May 2019 07:58:24 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.59.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(260/295)88%
(260/295)68%
(33101/48717)51%
(15665/31019)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)94%
(4711/5004)49%
(1781/3606)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5472/5513)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1708/1900)76%
(1214/1602)src.completion100%
(11/11)100%
(11/11)57%
(1783/3125)43%
(1166/2735)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/815)0%
(0/192)src.document100%
(4/4)100%
(4/4)60%
(1925/3196)49%
(1583/3243)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(215/237)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode88%
(7/8)88%
(7/8)35%
(285/806)19%
(129/695)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/834)0%
(0/294)src.render100%
(7/7)100%
(7/7)78%
(973/1246)68%
(640/944)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(7/7)100%
   

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/25/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 22 May 2019 08:11:54 +
 Build duration:
2 min 3 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 49 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/49/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 22 May 2019 07:57:59 +
 Build duration:
2 min 44 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Purpose-5.59.0.xmlcompat_reports/KF5Purpose_compat_report.htmllogs/KF5Purpose/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)20%
(458/2243)18%
(175/996)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(151/156)58%
(58/100)src100%
(8/8)100%
(8/8)68%
(223/329)49%
(88/180)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/16)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/80)0%
(0/22)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/76)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src

D21317: Manipulate bytes instead of characters

[David Faure]

dfaure added a reviewer: thiago.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21317

To: chinmoyr, bruns, dfaure, thiago
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21314: Don't enable QT_STRICT_ITERATORS on Windows.

[David Faure]

dfaure closed this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21314

To: dfaure, vkrause, dvratil
Cc: apol, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, 
bruns

D21328: Add qml import for KItemModels

[Volker Krause]

vkrause added a comment.


  +1 too, having the QML bindings as part of the corresponding framework is 
IMHO the way to go, compared to the KDeclarative approach.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D21328

To: davidedmundson
Cc: vkrause, apol, kde-frameworks-devel, michaelh, ngraham, bruns