KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/9/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 29 Jul 2019 02:49:40 +
 Build duration:
53 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

D22800: Fix KService build on Android

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Frameworks, sitter.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  DrKonqi isn't working there, so ifdef it out

TEST PLAN
  Built it

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22800

AFFECTED FILES
  CMakeLists.txt
  src/kbuildsycoca/CMakeLists.txt
  src/kbuildsycoca/kbuildsycoca_main.cpp

To: apol, #frameworks, sitter
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22790: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> CMakeLists.txt:29
>  
> +option(BUILD_DESIGNERPLUGIN "Build plugin for Qt Designer" ON)
> +add_feature_info(DESIGNERPLUGIN ${BUILD_DESIGNERPLUGIN} "Build plugin for Qt 
> Designer")

Would it make sense to have this option with the macro? This way we make sure 
it's easy to disable and we save some boilerplate on every project.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D22790

To: kossebau, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22789: KZip::openArchive: Don't assert when opening broken files

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22789

To: aacid, apol
Cc: apol, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22724: Add ECMAddQtDesignerPlugin

[Aleix Pol Gonzalez]

apol added a comment.


  +1 LGTM

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22724

To: kossebau, #build_system, #frameworks
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, 
bencreasy, michaelh, ngraham, bruns

D22786: KTar::openArchive: Don't assert if file has two root dirs

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22786

To: aacid, apol
Cc: dfaure, apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

RFC: Deprecating KDesignerPlugin in favour of new ECMAddQtDesignerPlugin

[Friedrich W. H. Kossebau]

Hi,

following up on a recent discussion about kdesignerplugin currently providing 
a single Qt Designer plugin for all of those modules from KDE Frameworks which 
provide custom QWidgets, and with this coupling running against the idea of 
mpdularization with KDE Frameworks, a few patches have been sketched and made 
working to approach this.

Please see for discussion of problem and proposed solution with a series of 
patches this task:

https://phabricator.kde.org/T11289

Please add your comments there, as well as on the patches, especially the 
proposed ECMAddQtDesignerPlugin addition to ECM.

If everyone agrees with the appraoch, would be material for KF 6.62 earliest 
(so only post upcoming KF 6.61).

Cheers
Friedrich

D22797: Fix typo - GridView -> ScrollView

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:2571616ec547: Fix typo - GridView - ScrollView 
(authored by ognarb).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22797?vs=62705=62708

REVISION DETAIL
  https://phabricator.kde.org/D22797

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/ScrollViewKCM.qml

To: ognarb, #plasma, aacid
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22797: Fix typo - GridView -> ScrollView

[Albert Astals Cid]

aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22797

To: ognarb, #plasma, aacid
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22797: Fix typo - GridView -> ScrollView

[Carl Schwan]

ognarb created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  Probably the result of a bad copy pasta ;)

TEST PLAN
  Not tested

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22797

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/ScrollViewKCM.qml

To: ognarb
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22798: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Enables the library to provide its own plugin, instead of having to refer
  to the single plugin from KDesignerPlugin module, which pulls in
  dependencies to all other covered KDE Frameworks modules.

REPOSITORY
  R263 KXmlGui

BRANCH
  createdesignerplugin

REVISION DETAIL
  https://phabricator.kde.org/D22798

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/designer/CMakeLists.txt

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22797: Fix typo - GridView -> ScrollView

[Carl Schwan]

ognarb added a reviewer: Plasma.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22797

To: ognarb, #plasma
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22796: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Enables the library to provide its own plugin, instead of having to refer
  to the single plugin from KDesignerPlugin module, which pulls in
  dependencies to all other covered KDE Frameworks modules.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  createdesignerplugin

REVISION DETAIL
  https://phabricator.kde.org/D22796

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/designer/CMakeLists.txt

To: kossebau, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22795: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Enables the library to provide its own plugin, instead of having to refer
  to the single plugin from KDesignerPlugin module, which pulls in
  dependencies to all other covered KDE Frameworks modules.

REPOSITORY
  R276 KItemViews

BRANCH
  createdesignerplugin

REVISION DETAIL
  https://phabricator.kde.org/D22795

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/designer/CMakeLists.txt

To: kossebau, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22794: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, sandsmark.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Enables the library to provide its own plugin, instead of having to refer
  to the single plugin from KDesignerPlugin module, which pulls in
  dependencies to all other covered KDE Frameworks modules.

REPOSITORY
  R246 Sonnet

BRANCH
  createdesignerplugin

REVISION DETAIL
  https://phabricator.kde.org/D22794

AFFECTED FILES
  CMakeLists.txt
  src/ui/CMakeLists.txt
  src/ui/designer/CMakeLists.txt

To: kossebau, #frameworks, sandsmark
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22793: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Enables the library to provide its own plugin, instead of having to refer
  to the single plugin from KDesignerPlugin module, which pulls in
  dependencies to all other covered KDE Frameworks modules.
  
  Icon files copied over from kdesignerplugin.

REPOSITORY
  R284 KCompletion

BRANCH
  createdesignerplugin

REVISION DETAIL
  https://phabricator.kde.org/D22793

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/designer/CMakeLists.txt
  src/designer/pics/kcombobox.png
  src/designer/pics/khistorycombo.png
  src/designer/pics/klineedit.png

To: kossebau, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22792: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, cfeck.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Enables the library to provide its own plugin, instead of having to refer
  to the single plugin from KDesignerPlugin module, which pulls in
  dependencies to all other covered KDE Frameworks modules.

REPOSITORY
  R277 KPlotting

BRANCH
  createdesignerplugin

REVISION DETAIL
  https://phabricator.kde.org/D22792

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/designer/CMakeLists.txt

To: kossebau, #frameworks, cfeck
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22791: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, mlaurent.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Enables the library to provide its own plugin, instead of having to refer
  to the single plugin from KDesignerPlugin module, which pulls in
  dependencies to all other covered KDE Frameworks modules.
  
  Icon file copied over from kdesignerplugin.

REPOSITORY
  R310 KTextWidgets

BRANCH
  createdesignerplugin

REVISION DETAIL
  https://phabricator.kde.org/D22791

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/designer/CMakeLists.txt
  src/designer/pics/ktextedit.png

To: kossebau, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22725: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

[Friedrich W. H. Kossebau]

kossebau edited the summary of this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22725

To: kossebau, #frameworks, cfeck
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22785: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

[Friedrich W. H. Kossebau]

kossebau edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22785

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.11 - Build # 63 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.11/63/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sun, 28 Jul 2019 20:05:26 +
 Build duration:
2 min 45 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)

D22790: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Enables the library to provide its own plugin, instead of having to refer
  to the single plugin from KDesignerPlugin module, which pulls in
  dependencies to all other covered KDE Frameworks modules.
  
  Icon file copied over from kdesignerplugin.

REPOSITORY
  R302 KIconThemes

BRANCH
  createdesignerplugin

REVISION DETAIL
  https://phabricator.kde.org/D22790

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/designer/CMakeLists.txt
  src/designer/pics/kiconbutton.png

To: kossebau, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22782: KZip::openArchive: Don't assert when opening broken files

[Albert Astals Cid]

aacid added a comment.


  In D22782#503345 , @dfaure wrote:
  
  > Yes, I mean all of them.
  
  
  I think it can useful to have such "technical" error messages, obviously not 
something you'd show the user directly, but maybe in an "advanced" button of 
the UI.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D22782

To: aacid, dfaure
Cc: dfaure, kde-frameworks-devel, apol, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22789: KZip::openArchive: Don't assert when opening broken files

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  It's not nice bringing down the application just because the user opens a 
broken file

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22789

AFFECTED FILES
  src/kzip.cpp

To: aacid
Cc: apol, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22784: Deprecate kgendesignerplugin, drop bundle plugim for all KF5 widgets

[Friedrich W. H. Kossebau]

kossebau retitled this revision from "[WIP] Deprecate kgendesignerplugin, drop 
bundle plugim for all KF5 widgets" to "Deprecate kgendesignerplugin, drop 
bundle plugim for all KF5 widgets".
kossebau added a reviewer: Frameworks.

REPOSITORY
  R298 KDesignerPlugin

REVISION DETAIL
  https://phabricator.kde.org/D22784

To: kossebau, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22143: Add proper logging using ECMQtDeclareLoggingCategory

[Méven Car]

meven updated this revision to Diff 62695.
meven added a comment.


  Add comment regarding the origin of a generated cpp file

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22143?vs=62526=62695

BRANCH
  arcpatch-D22143

REVISION DETAIL
  https://phabricator.kde.org/D22143

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  kactivities-stats.categories
  src/CMakeLists.txt
  src/common/database/Database.cpp
  src/resultmodel.cpp
  src/resultset.cpp
  src/resultwatcher.cpp

To: meven, ivan, #frameworks, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22777: Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin

[Friedrich W. H. Kossebau]

kossebau retitled this revision from "[WIP] Use ECMAddQtDesignerPlugin instead 
of KF5DesignerPlugin" to "Use ECMAddQtDesignerPlugin instead of 
KF5DesignerPlugin".
kossebau edited the summary of this revision.
kossebau added a reviewer: Frameworks.

REPOSITORY
  R300 KDEWebKit

REVISION DETAIL
  https://phabricator.kde.org/D22777

To: kossebau, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22785: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

[Friedrich W. H. Kossebau]

kossebau retitled this revision from "[WIP] Add option to build Qt Designer 
plugin (BUILD_DESIGNERPLUGIN, default ON" to "Add option to build Qt Designer 
plugin (BUILD_DESIGNERPLUGIN, default ON".
kossebau edited the summary of this revision.
kossebau added reviewers: Frameworks, dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22785

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22725: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

[Friedrich W. H. Kossebau]

kossebau retitled this revision from "[WIP] Add option to build Qt Designer 
plugin (BUILD_DESIGNERPLUGIN, default ON" to "Add option to build Qt Designer 
plugin (BUILD_DESIGNERPLUGIN, default ON".
kossebau edited the summary of this revision.
kossebau added reviewers: Frameworks, cfeck.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22725

To: kossebau, #frameworks, cfeck
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22724: Add ECMAddQtDesignerPlugin

[Friedrich W. H. Kossebau]

kossebau retitled this revision from "[WIP] Add ECMAddQtDesignerPlugin" to "Add 
ECMAddQtDesignerPlugin".
kossebau edited the summary of this revision.
kossebau added reviewers: Build System, Frameworks.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22724

To: kossebau, #build_system, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, 
michaelh, ngraham, bruns

D22782: KZip::openArchive: Don't assert when opening broken files

[David Faure]

dfaure added a comment.


  Yes, I mean all of them.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D22782

To: aacid, dfaure
Cc: dfaure, kde-frameworks-devel, apol, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22609: Add expanding spacers as a customization option for toolbars

[Felix Ernst]

felixernst added a comment.


  I kept the names lowercase because I like the visible difference between 
lowercase separator/spacer and title case actions. I don't mind changing the 
names to title case though. Judge for yourself:
  F7109858: Screenshot_20190728_185837.png 

  
  F7109860: Screenshot_20190728_191058.png 


REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst, dfaure
Cc: ngraham, #vdg, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D22609: Add expanding spacers as a customization option for toolbars

[Felix Ernst]

felixernst updated this revision to Diff 62687.
felixernst marked an inline comment as done.
felixernst added a comment.


  Rename to "expanding spacer", Cast to QToolBar instead
  
  Remove unrelated comments and documentation

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22609?vs=62188=62687

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22609

AFFECTED FILES
  src/kedittoolbar.cpp
  src/kxmlgui.xsd
  src/kxmlguibuilder.cpp

To: felixernst, dfaure
Cc: ngraham, #vdg, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D22786: KTar::openArchive: Don't assert if file has two root dirs

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  I was wondering if adding this check in KArchive::setRootDir
  instead but i ended doing it here since i think an assert in setRootDir is
  valid for when C++ users of that class do it wrong.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22786

AFFECTED FILES
  src/karchive_p.h
  src/ktar.cpp

To: aacid
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22786: KTar::openArchive: Don't assert if file has two root dirs

[Albert Astals Cid]

aacid added subscribers: apol, dfaure.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D22786

To: aacid
Cc: dfaure, apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22724: [WIP] Add ECMAddQtDesignerPlugin

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 62676.
kossebau added a comment.


  - escape strings to be used as strings in C++ code
  - use Qt5Core version to decide whether checking only for QtUiPlugin is enough

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22724?vs=62653=62676

BRANCH
  addqtdesignerplugin

REVISION DETAIL
  https://phabricator.kde.org/D22724

AFFECTED FILES
  docs/module/ECMAddQtDesignerPlugin.rst
  modules/ECMAddQtDesignerPlugin.cmake

To: kossebau
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 22 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/22/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 28 Jul 2019 11:33:00 +
 Build duration:
23 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.61.0.xmllogs/KF5KIO/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_ktcpsockettestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/402)66%
(264/402)55%
(33456/61054)39%
(17051/43959)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9338/9793)48%
(4284/9007)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8518/14437)51%
(4686/9207)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4614/8217)42%
(2006/4771)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(653/1204)39%
(371/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1343)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1788/4290)36%
(1316/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

D22785: [WIP] Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

[Friedrich W. H. Kossebau]

kossebau added a dependency: D22724: [WIP] Add ECMAddQtDesignerPlugin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22785

To: kossebau
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22724: [WIP] Add ECMAddQtDesignerPlugin

[Friedrich W. H. Kossebau]

kossebau added a dependent revision: D22785: [WIP] Add option to build Qt 
Designer plugin (BUILD_DESIGNERPLUGIN, default ON.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22724

To: kossebau
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, 
michaelh, ngraham, bruns

D22785: [WIP] Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

[Friedrich W. H. Kossebau]

kossebau created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  createdesignerplugin

REVISION DETAIL
  https://phabricator.kde.org/D22785

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/designer/CMakeLists.txt
  src/designer/pics/kurlcomborequester.png
  src/designer/pics/kurlrequester.png

To: kossebau
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/16/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 28 Jul 2019 11:33:00 +
 Build duration:
6 min 57 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D22784: [WIP] Deprecate kgendesignerplugin, drop bundle plugim for all KF5 widgets

[Friedrich W. H. Kossebau]

kossebau added dependencies: D22725: [WIP] Add option to build Qt Designer 
plugin (BUILD_DESIGNERPLUGIN, default ON, D22724: [WIP] Add 
ECMAddQtDesignerPlugin, D22777: [WIP] Use ECMAddQtDesignerPlugin instead of 
KF5DesignerPlugin.

REPOSITORY
  R298 KDesignerPlugin

REVISION DETAIL
  https://phabricator.kde.org/D22784

To: kossebau
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22724: [WIP] Add ECMAddQtDesignerPlugin

[Friedrich W. H. Kossebau]

kossebau added a dependent revision: D22784: [WIP] Deprecate 
kgendesignerplugin, drop bundle plugim for all KF5 widgets.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22724

To: kossebau
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, 
michaelh, ngraham, bruns

D22777: [WIP] Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin

[Friedrich W. H. Kossebau]

kossebau added a dependent revision: D22784: [WIP] Deprecate 
kgendesignerplugin, drop bundle plugim for all KF5 widgets.

REPOSITORY
  R300 KDEWebKit

REVISION DETAIL
  https://phabricator.kde.org/D22777

To: kossebau
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22725: [WIP] Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

[Friedrich W. H. Kossebau]

kossebau added a dependent revision: D22784: [WIP] Deprecate 
kgendesignerplugin, drop bundle plugim for all KF5 widgets.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22725

To: kossebau
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22784: [WIP] Deprecate kgendesignerplugin, drop bundle plugim for all KF5 widgets

[Friedrich W. H. Kossebau]

kossebau created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Each Frameworks module with widgets generates now an own designer plugin
  for those, using the new ECMAddQtDesignerPlugin.

REPOSITORY
  R298 KDesignerPlugin

BRANCH
  deprecateit

REVISION DETAIL
  https://phabricator.kde.org/D22784

AFFECTED FILES
  CMakeLists.txt
  README.md
  metainfo.yaml
  src/CMakeLists.txt
  src/kde.widgets
  src/kdewidgets.qrc
  src/pics/CMakeLists.txt
  src/pics/k3iconview.png
  src/pics/k3listview.png
  src/pics/kactionselector.png
  src/pics/kactivelabel.png
  src/pics/kbusyindicatorwidget.png
  src/pics/kcharselect.png
  src/pics/kcmodule.png
  src/pics/kcolorbutton.png
  src/pics/kcolorcombo.png
  src/pics/kcombobox.png
  src/pics/kdatepicker.png
  src/pics/kdatetable.png
  src/pics/kdualcolorbutton.png
  src/pics/keditlistwidget.png
  src/pics/kfontcombo.png
  src/pics/kfontrequester.png
  src/pics/kgradientselector.png
  src/pics/khistorycombo.png
  src/pics/khsselector.png
  src/pics/kiconbutton.png
  src/pics/kkeybutton.png
  src/pics/kled.png
  src/pics/klineedit.png
  src/pics/klistbox.png
  src/pics/kpalettetable.png
  src/pics/kpasswordedit.png
  src/pics/kruler.png
  src/pics/ksqueezedtextlabel.png
  src/pics/ktextedit.png
  src/pics/kurlcomborequester.png
  src/pics/kurllabel.png
  src/pics/kurlrequester.png

To: kossebau
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D12992: New elisa icon

[Noah Davis]

ndavis added a comment.


  In D12992#503172 , @KonqiDragon 
wrote:
  
  > In D12992#269399 , @abetts wrote:
  >
  > > I think we are trying hard to accommodate and the elements are not 
lending themselves to turn them into an E with some musical tones. I reviewed a 
few music sheets looking for commonalities. I feel also that the icon is busy, 
it is trying really hard to tell you that this app is about music. I feel we 
can simplify and provide other ideas.
  > >
  > > Here is a proposal. Not final. I welcome feedback. The idea here is to 
show soundwaves instead.
  > >
  > > F5872565: Elisa Long Form.png 
  >
  >
  > The colors must match to HIG 
? I don't understand why KDE 
Applications have a logos in different styles. We do not have complete unify 
KDE style.
  
  
  There aren't enough colors in the HIG to really match the HIG consistently, 
it just needs to look similar to other icons in the breeze-icons repository.
  
  The rest seems unrelated to the Elisa icon. Project home pages tend not to 
update their logos very often and Kdenlive's icons are fine as they are. The 
website version is just a simple style for branding and the breeze-icons 
version has a dark background behind the other parts to give it some contrast 
with different colorschemes. I don't think it's absolutely necessary that 
projects have their logos be exactly the same as their Breeze icons. They just 
need to be obviously similar.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12992

To: lshoravi, #vdg, ngraham, #elisa
Cc: ndavis, KonqiDragon, abetts, paullesur, januz, mgallien, alex-l, andreask, 
kde-frameworks-devel, mfraser, mnesbitt, LeGast00n, carneirogustavo, sbergeron, 
jguidon, ctakano, Tizon, oussemabouaneni, ashwind, fbampaloukas, sourabhboss, 
aureliencouderc, tgraves, hantzv, lcmscheid, nhuisman, ursjoss, mykolak, 
jussiv, michaelh, astippich, James, ngraham, bruns, kmf, lemuel

D22725: [WIP] Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 62672.
kossebau added a comment.


  - update with new kbusyindivator widget
  - enable icon for KFontChooser

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22725?vs=62493=62672

BRANCH
  createdesignerplugin

REVISION DETAIL
  https://phabricator.kde.org/D22725

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/designer/CMakeLists.txt
  src/designer/pics/kactionselector.png
  src/designer/pics/kbusyindicatorwidget.png
  src/designer/pics/kcharselect.png
  src/designer/pics/kcolorbutton.png
  src/designer/pics/kcolorcombo.png
  src/designer/pics/kdatepicker.png
  src/designer/pics/keditlistwidget.png
  src/designer/pics/kfontcombo.png
  src/designer/pics/kfontrequester.png
  src/designer/pics/kgradientselector.png
  src/designer/pics/kled.png
  src/designer/pics/kpasswordlineedit.png
  src/designer/pics/kruler.png
  src/designer/pics/ksqueezedtextlabel.png
  src/designer/pics/kurllabel.png

To: kossebau
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22776: [WIP] Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin

[Friedrich W. H. Kossebau]

kossebau abandoned this revision.
kossebau added a comment.


  kelibs4support still sports the `KDEUIMacros.cmale` file, which defines a 
macro `KDE4_ADD_WIDGET_FILES`, which uses 
KF5DESIGNERPLUGIN_GENERATOR_EXECUTABLE, so has a runtime dependency on 
kdesignerplugin with the development files.
  In that case it does not make that much sense to also remove it as build time 
dependency? Potentially resulting in packagers changing too much things, and 
forgetting about the run time dependency?
  
  Thus discarding for now.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D22776

To: kossebau
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D12992: New elisa icon

[KonqiDragon]

KonqiDragon added a comment.


  In D12992#269399 , @abetts wrote:
  
  > I think we are trying hard to accommodate and the elements are not lending 
themselves to turn them into an E with some musical tones. I reviewed a few 
music sheets looking for commonalities. I feel also that the icon is busy, it 
is trying really hard to tell you that this app is about music. I feel we can 
simplify and provide other ideas.
  >
  > Here is a proposal. Not final. I welcome feedback. The idea here is to show 
soundwaves instead.
  >
  > F5872565: Elisa Long Form.png 
  
  
  The colors must match to HIG ? 
I don't understand why KDE Applications have a logos in different styles. We do 
not have complete unify KDE style.
  For example:
  In Homepage 
  F7108971: proxy.duckduckgo.com.jpg 
  In KDE Applications 
  F7108974: Breezeicons-apps-48-amarok.svg.png 

  In Homepage 
  F7108981: proxy.duckduckgo.com.png 
  In KDE Applications 
  F7108984: 1024px-Breezeicons-apps-48-kdenlive.svg.png 
 
  In Homepage 
  F7108993: 1024px-Digikam_Oxygen.svg.png 
  In KDE Applications 
  F7108996: Breezeicons-apps-48-digikam.svg.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12992

To: lshoravi, #vdg, ngraham, #elisa
Cc: KonqiDragon, abetts, paullesur, januz, mgallien, alex-l, andreask, 
kde-frameworks-devel, mfraser, mnesbitt, LeGast00n, carneirogustavo, sbergeron, 
jguidon, ctakano, Tizon, oussemabouaneni, ashwind, fbampaloukas, sourabhboss, 
aureliencouderc, tgraves, hantzv, lcmscheid, nhuisman, ursjoss, mykolak, 
jussiv, michaelh, astippich, James, ngraham, bruns, kmf, lemuel