D25334: Added transparent blue background to tabbars

ndavis added a comment. In D25334#566992 , @ngraham wrote: > In D25334#566745 , @ndavis wrote: > > > Yes that's right, the Kickoff tabs are fine, it's the panel that doesn't look right. It just

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a comment. I also think these *.menu and *.directory files should not be required at compile time. And they should better be in same repository because they are connected so closely. In this patch, we added a new file `kf5-network.directory` in plasma-workspace and

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

ahmadsamir updated this revision to Diff 70271. ahmadsamir marked 8 inline comments as done. ahmadsamir retitled this revision from "More (and last) fixes to compile without implicit conversion from ASCII/ByteArray" to "More fixes to compile without implicit conversion from ASCII/ByteArray".

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in slavebase.h:979 > This method should be const A B C, nothing changed inside make it const, D E F. > dfaure wrote in ftp.cpp:1232 > Should this be remoteEncoding()->decode(...) given that the method will then > use

D25512: Remove unused include

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN builds REPOSITORY R265 KConfigWidgets BRANCH incl REVISION DETAIL

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

davidedmundson added a comment. > The trouble is still here: if we land this patch and released new frameworks, it won't work with older plasma workspace (like 5.17.0, 5.16.x). Talk me through what will happen. Do they end up in lost and found? In terms of the circular dependency,

D25511: Drop unused broken KGesture support

vkrause added a comment. Seems used in KAction in kdelibs4support. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25511 To: davidedmundson Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25511: Drop unused broken KGesture support

davidedmundson edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25511 To: davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a comment. Not sure who should I ping. So I posted in maillist plasma-de...@kde.org REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc: ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25511: Drop unused broken KGesture support

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY The functionality was disabled before kdelibs 4.0 (7a390751076bafafc67557007172028956966ef1

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

ltoscano added a comment. Maybe pinging a few Plasma people may be more effective, or though a mailing list thread. I don't know. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc: ngraham, ltoscano, kde-frameworks-devel,

D24046: Allow triggering sort from QML

mpyne added inline comments. INLINE COMMENTS > broulik wrote in personssortfilterproxymodel.h:53 > "You can ... reimplement virtual functions defined in the primary base class > hierarchy (that is, virtuals defined in the first non-virtual base class, or > in that class's first non-virtual

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a comment. @ngraham @ltoscano should I create bug ticket about the dependency issue we have here? REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc: ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

KDE CI: Frameworks » threadweaver » kf5-qt5 FreeBSDQt5.13 - Build # 27 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/threadweaver/job/kf5-qt5%20FreeBSDQt5.13/27/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 24 Nov 2019 18:51:32 + Build duration: 7 min 7 sec and counting JUnit Tests Name:

D23205: [KProcessList] Optimize KProcessList::processInfo

mpyne accepted this revision. mpyne added a comment. This revision is now accepted and ready to land. I've reviewed the patch and it's good, you've addressed the issues that were noted by Aleix already, so please commit and we can address anything that might pop up as it happens. REPOSITORY

D25508: Make KF6 cleanup work visible

This revision was automatically updated to reflect the committed changes. Closed by commit R304:c8fa3ab044cb: Make KF6 cleanup work visible (authored by dhaumann). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25508?vs=70264=70266 REVISION DETAIL

D25334: Added transparent blue background to tabbars

ngraham added a comment. In D25334#566745 , @ndavis wrote: > Yes that's right, the Kickoff tabs are fine, it's the panel that doesn't look right. It just doesn't look good with that kind of highlight to me. Or maybe the highlight background is

D25508: Make KF6 cleanup work visible

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH work-add-kf6-note-kmoretools REVISION DETAIL https://phabricator.kde.org/D25508 To: dhaumann, gregormi, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25508: Make KF6 cleanup work visible

dhaumann created this revision. dhaumann added a reviewer: gregormi. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dhaumann requested review of this revision. REVISION SUMMARY This work is simply about removing an unused private member variable that is

D24349: More (and last) fixes to compile without implicit conversion from ASCII/ByteArray

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Thanks! INLINE COMMENTS > forwardingslavebase.cpp:91 > > -if (url.scheme() == q->mProtocol) { > +if (url.scheme() == QString::fromLatin1(q->mProtocol)) { >

D25495: Fix Sonnet autodetect failing on Indian langs

waqar updated this revision to Diff 70262. waqar added a comment. Revert a change, as autodetection fails for languages with similar scripts REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25495?vs=70238=70262 BRANCH fix-176537 (branched from master)

D25503: JavaScript: move keywords from TypeScript and other improvements

dhaumann added a comment. I think this is ok. I recognize only now that a much better syntax would have been variable_property but that is off-topic :) If the kateversions are correct, then I'm fine with this. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D25506: Remove Attica from KAboutDialog

broulik retitled this revision from "Remove Attica" to "Remove Attica from KAboutDialog". REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25506 To: broulik, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25506: Remove Attica from KAboutDialog

broulik edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25506 To: broulik, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25506: Remove Attica

broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It's defunct and unused. Gets rid of everything that cannot be done with just

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

kossebau added a comment. IMHO such idea notes should also be put into the source file or, better, a separate TODO file in the toplevel source, not the header (which is going to be deployed as part of devel-packages), as this note is uninteresting to users of current KXMLGUIClient.

Re: KF6 Blogs

On samedi 23 novembre 2019 16:34:01 CET Dominik Haumann wrote: > Hi everyone, > > could you who currently are at the KF6 sprint blog a bit more? > > Even if it's just about small details like "app X does not depend on Y > anymore and this is how we got rid of the dependency" already is valuable

D24349: More (and last) fixes to compile without implicit conversion from ASCII/ByteArray

kossebau edited reviewers, added: Frameworks; removed: kossebau. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24349 To: ahmadsamir, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25059: KPluginSelector: use new KAboutPluginDialog

This revision was automatically updated to reflect the committed changes. Closed by commit R295:918978c7e26e: KPluginSelector: use new KAboutPluginDialog (authored by kossebau). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25059?vs=69004=70260 REVISION

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/62/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 24 Nov 2019 12:53:26 + Build duration: 2 min 47 sec and counting JUnit Tests Name:

D25063: Deprecate KAboutData::fromPluginMetaData, now there is KAboutPluginDialog

kossebau marked an inline comment as done. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D25063 To: kossebau, #frameworks, apol, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25063: Deprecate KAboutData::fromPluginMetaData, now there is KAboutPluginDialog

This revision was automatically updated to reflect the committed changes. Closed by commit R244:e8f558f8b2c7: Deprecate KAboutData::fromPluginMetaData, now there is KAboutPluginDialog (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25063?vs=69017=70259#toc

D7010: KSqueezedTextLabel: call updateGeometry() when text changes

cfeck resigned from this revision. cfeck added a comment. This revision is now accepted and ready to land. Yes, I would prefer the check condition. Feel free to commandeer; it looks like the original author didn't find time to further investigate. REVISION DETAIL

D25058: Add KAboutPluginDialog, to be used with KPluginMetaData

This revision was automatically updated to reflect the committed changes. kossebau marked 2 inline comments as done. Closed by commit R263:415402081d92: Add KAboutPluginDialog, to be used with KPluginMetaData (authored by kossebau). CHANGED PRIOR TO COMMIT

D25503: JavaScript: move keywords from TypeScript and other improvements

nibags updated this revision to Diff 70254. nibags added a comment. - Update comment REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25503?vs=70253=70254 BRANCH improve-javascript REVISION DETAIL https://phabricator.kde.org/D25503

D25503: JavaScript: move keywords from TypeScript and other improvements

nibags edited the summary of this revision. nibags added reviewers: cullmann, dhaumann, Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25503 To: nibags, cullmann, dhaumann, #framework_syntax_highlighting Cc: kwrite-devel,

D25503: JavaScript: move keywords from TypeScript and other improvements

nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH improve-javascript REVISION DETAIL https://phabricator.kde.org/D25503

D17863: Add ecm_check_linker_flags function

tcberner abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17863 To: tcberner, #freebsd, dfaure, apol, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D17595: Upstream Dolphin's file rename dialog

meven added a subscriber: lydia. meven added a comment. In D17595#566800 , @dhaumann wrote: > In D17595#542142 , @meven wrote: > > > I received the agreements of all contributors including the