D25870: SELinux: add "glblub" keyword and update permissions list

nibags edited the test plan for this revision. nibags added reviewers: dhaumann, cullmann, Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25870 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting Cc: kwrite-devel, k

D25870: SELinux: add "glblub" keyword and update permissions list

nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY - Add new keyword "glblub" for default_range rules: https://github.com/SELinuxProject/selinux/commit/9b

D25869: Python: improve numbers, add octals, binaries and "breakpoint" keyword

nibags updated this revision to Diff 71242. nibags added a comment. - Fix autotest REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25869?vs=71241&id=71242 BRANCH python-numbers REVISION DETAIL https://phabricator.kde.org/D25869 AFFECTED FI

D25869: Python: improve numbers, add octals, binaries and "breakpoint" keyword

nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25869 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demski

D25869: Python: improve numbers, add octals, binaries and "breakpoint" keyword

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY - Improve number detection w

D25866: kholidays EBN transport protocol cleanup

jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Change http to https and update link to calendar faq REPOSITORY R175 KHolidays BRANCH ebn-transport-cleanup (branche

D25865: kfilemetadata EBN transport protocol cleanup

jhayes created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Change tranport protocol from http to https and verify address REPOSITORY R286 KFileMetaData BRANCH ebn-

D25849: Ensure the dialog title is correct with an uninitialised engine

leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > ngraham wrote in Dialog.qml:55 > For readability's sake and to avoid nested `i18n()` calls which would cause > string puzzles, I would do it like this: > > title: component.downloadNewWhat.length === 0 ?

D25849: Ensure the dialog title is correct with an uninitialised engine

leinir updated this revision to Diff 71234. leinir added a comment. - Less string puzzles are better REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25849?vs=71198&id=71234 BRANCH ensure-dialog-title-with-uninitialised-engine (branched from master) REV

D25685: [QImageItem/QPixmapItem] Don't lose precision during calculation

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25685 To: broulik, #plasma, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25856: Show IOSlaves that return local files when in local file mode

fvogt added a comment. In D25856#575083 , @ngraham wrote: > In D25856#575044 , @fvogt wrote: > > > IMO this should be done in KIO, so that all users benefit. > > > How would you do it in KIO?

D23457: Port regex search to QRegularExpression

dhaumann added a comment. In D23457#574846 , @ahmadsamir wrote: > Personally, I am not convinced replacing \s with [ \t], and deviating from PCRE default behaviour is a good idea in this case. That is not to be discussed, and Christoph t

D25864: kdeclarative EBN spelling cleanup

jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Correct spelling in comments REPOSITORY R296 KDeclarative BRANCH ebn-spelling-cleanup (branched from master) REVISI

D25858: Use QStyle for determining icon sizes

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25858 To: vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25856: Show IOSlaves that return local files when in local file mode

ngraham added a comment. In D25856#575044 , @fvogt wrote: > IMO this should be done in KIO, so that all users benefit. How would you do it in KIO? > In D25856#575011 , @broulik wrote: >

D25856: Show IOSlaves that return local files when in local file mode

fvogt added a comment. IMO this should be done in KIO, so that all users benefit. In D25856#575011 , @broulik wrote: > Isn't that what `KProtocolInfo::protocolClass() == ":local"` is for? Almost, but not quite - it just means that the

D7700: Show list of tags in PlacesView

chehrlic added inline comments. INLINE COMMENTS > kfileplacesmodel.cpp:172 > + tags(), > + tagsLister(new KCoreDirLister()) > { While I way playing around with asan, I got a report that tagsLister is leaking. I can't see a deletion of this object anywhere, even in current

D25859: Add Battery1 interface

broulik added a dependent revision: D25860: [plasmoid] Show device battery percentage. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D25859 To: broulik, #frameworks, drosca Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25856: Show IOSlaves that return local files when in local file mode

broulik added a comment. Isn't that what `KProtocolInfo::protocolClass() == ":local"` is for? REPOSITORY R229 KDialog REVISION DETAIL https://phabricator.kde.org/D25856 To: ngraham, #frameworks, #dolphin Cc: broulik, meven

D25856: Show IOSlaves that return local files when in local file mode

ngraham added inline comments. INLINE COMMENTS > meven wrote in kdialog.cpp:865 > The trash recentlyused tags and desktop ioslaves can't be save filename' > folder since they are not writable. > So I believe this should be undone here. `kdialog` can be used to show open dialogs as well as save

D25856: Show IOSlaves that return local files when in local file mode

meven added inline comments. INLINE COMMENTS > kdialog.cpp:865 > if (!saveUrls) { > -dlg.setSupportedSchemes({QStringLiteral("file")}); > +dlg.setSupportedSchemes(schemesthatReturnLocalFiles()); > } The trash recentlyused tags and desktop ioslaves can't

D25859: Add Battery1 interface

broulik created this revision. broulik added reviewers: Frameworks, drosca. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Allows querying for a Bluetooth device's battery status. TEST PLAN - Add

D25858: Use QStyle for determining icon sizes

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This should remove the last use of the IconSize() top-level function from Frameworks, in preparation of deprecating th

D25856: Show IOSlaves that return local files when in local file mode

ngraham updated this revision to Diff 71212. ngraham added a comment. Formalize TODO REPOSITORY R229 KDialog CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25856?vs=71211&id=71212 BRANCH show-local-ioslaves (branched from release/19.12) REVISION DETAIL https://phabricator.kd

D25856: Show IOSlaves that return local files when in local file mode

ngraham created this revision. ngraham added reviewers: Frameworks, Dolphin. ngraham requested review of this revision. REVISION SUMMARY `kdialog --get{open,save}filename` returns only local paths, but does not show IOSlaves that return local paths. It should. :) TODO: show removable dis

D25855: Don't show the info icon on the big preview delegate

This revision was automatically updated to reflect the committed changes. Closed by commit R304:0784d3f42e06: Don't show the info icon on the big preview delegate (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25855?vs=71209&id=71210 R

D25855: Don't show the info icon on the big preview delegate

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH dont-show-that-info-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D25855 To: leinir, #frameworks, #knewstuff, ngraham, abetts, #vdg, ndavis Cc: kde-fr

D25855: Don't show the info icon on the big preview delegate

leinir edited the test plan for this revision. leinir added reviewers: Frameworks, KNewStuff, ngraham, abetts, VDG. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25855 To: leinir, #frameworks, #knewstuff, ngraham, abetts, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_

D25855: Don't show the info icon on the big preview delegate

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY As discussed on the VDG chat with the original author of the design, the information icon was supposed to be an interact

D25820: SimpleScreenRecorder icon added

ndavis added a comment. In D25820#574397 , @vinzenzv wrote: > In D25820#574119 , @ndavis wrote: > > > Good start! The lens flare looks upside down > > > That was intentionally to make it disting

D25311: Add KColumnHeadersProxyModel

This revision was automatically updated to reflect the committed changes. Closed by commit R275:241e9dec6896: Add KColumnHeadersProxyModel (authored by ahiemstra). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25311?vs=70948&id=71204#toc REPOSITORY R275 KItemModels CHANGES SINCE LAST

D25849: Ensure the dialog title is correct with an uninitialised engine

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > Dialog.qml:55 > property string downloadNewWhat: engine.name > -title: i18n("Download New %1", component.downloadNewWhat) > +title: i18n("Downlo

D23457: Port regex search to QRegularExpression

ahmadsamir added a comment. Personally, I am not convinced replacing \s with [ \t], and deviating from PCRE default behaviour is a good idea in this case. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23457 To: ahmadsamir, #ktexteditor, dhaumann, cullmann Cc: k

D25849: Ensure the dialog title is correct with an uninitialised engine

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Prior to this patch, when the engine was not correctly initialised, it would cause the dialog title to be Download New %

D25849: Ensure the dialog title is correct with an uninitialised engine

leinir added reviewers: Frameworks, KNewStuff, ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25849 To: leinir, #frameworks, #knewstuff, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23457: Port regex search to QRegularExpression

dhaumann added a comment. Was anything of the previously commented issues addressed? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23457 To: ahmadsamir, #ktexteditor, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh,

D25824: Support archive installs with adoption commands

This revision was automatically updated to reflect the committed changes. Closed by commit R304:709944d6cb5c: Support archive installs with adoption commands (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25824?vs=71173&id=71185 REVISI

D25824: Support archive installs with adoption commands

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH support-archive-installs-in-use-commands (branched from master) REVISION DETAIL https://phabricator.kde.org/D25824 To: leinir, #frameworks, #plasma, #knewstuff, apol, ngraham Cc:

D23457: Port regex search to QRegularExpression

ahmadsamir updated this revision to Diff 71178. ahmadsamir added a comment. clang-fromat the code in this diff REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23457?vs=71059&id=71178 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D25824: Support archive installs with adoption commands

leinir updated this revision to Diff 71173. leinir marked an inline comment as done. leinir added a comment. - Ensure rootPath is definitely clean and has a / at the end REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25824?vs=71134&id=71173 BRANCH supp

D25824: Support archive installs with adoption commands

leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > apol wrote in engine.cpp:744 > Shouldn't we make sure rootPath ends with /? > at least with an ASSERT if we know it's there. Hmm... It /should/ be done, but it's also not a bad thing to perform a touch of s

D25833: Expose getter to KConfigWatcher's config

This revision was automatically updated to reflect the committed changes. Closed by commit R237:7ab8275bdb56: Expose getter to KConfigWatcher's config (authored by davidedmundson). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25833?vs=71159&id=71171 REVISIO

D25833: Expose getter to KConfigWatcher's config

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kconfigwatcher.h:56 > + * Returns the config being watched > + * @since 5.65 > + */ 5.66 - tagging for 5.65 was last Sunday REPOSITORY R237 KConfig BR

D25827: kcodecs EBN transport protocol cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R270 KCodecs BRANCH ebn-transport-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25827 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25829: kconfig EBN transport protocol cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH ebn-transport-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25829 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25833: Expose getter to KConfigWatcher's config

davidedmundson added a dependent revision: D25834: [effects/startupfeedback] Port to KConfigWatcher. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25833 To: davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25833: Expose getter to KConfigWatcher's config

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY It can help save users having to member variables for the config and the watcher. REPOSITORY R237 KCo

D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts"

This revision was automatically updated to reflect the committed changes. Closed by commit R265:df95c485f47c: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts" (authored by ngraham). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25793?vs=7

D25791: Fix writeFlags with KConfigCompilerSignallingItem

This revision was automatically updated to reflect the committed changes. Closed by commit R237:89fb70b57115: Fix writeFlags with KConfigCompilerSignallingItem (authored by davidedmundson). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25791?vs=71029&id=71154

D25791: Fix writeFlags with KConfigCompilerSignallingItem

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. Indeed not pretty and error prone but as you say: should be fine in autogenerated code REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D25791 To: da