KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 282 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/282/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 04 Feb 2020 07:32:31 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 160 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/160/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 04 Feb 2020 07:32:31 + Build duration: 7 min 53 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 154 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/154/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 04 Feb 2020 07:32:31 + Build duration: 5 min 20 sec and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.14 - Build # 9 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.14/9/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 04 Feb 2020 07:32:31 + Build duration: 3 min 41 sec and counting JUnit Tests

D26691: Optimize code when dropping files into the desktop

jjazeix added a comment. Compilation fails: https://build.kde.org/view/Failing/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/288/console Missing the new file in the CMakeLists.txt? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26691

Re: Banning QNetworkAccessManager

On Mon, Feb 3, 2020 at 11:51 PM Johan Ouwerkerk wrote: > > On Mon, Feb 3, 2020 at 11:27 AM laurent Montel wrote: > > > > Le lundi 3 février 2020, 10:49:10 CET David Edmundson a écrit : > > > I updated: > > > > > > https://community.kde.org/Policies/API_to_Avoid > > > > > > Which had no mention

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 153 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/153/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 04 Feb 2020 05:55:09 + Build duration: 59 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.14 - Build # 8 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.14/8/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 04 Feb 2020 05:55:08 + Build duration: 56 min and counting CONSOLE OUTPUT

Re: Banning QNetworkAccessManager

On Mon, Feb 3, 2020 at 10:49 PM David Edmundson wrote: > > I updated: > > https://community.kde.org/Policies/API_to_Avoid > > Which had no mention of this. Many thanks for updating the wiki David. > > David Cheers, Ben

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

mlaurent added a comment. Seems ok for me REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D27151: Use ecm_qt_install_logging_categories over manual categories file

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Seems ok for me. REPOSITORY R244 KCoreAddons BRANCH generateqtlogcatfile REVISION DETAIL https://phabricator.kde.org/D27151 To: kossebau, #build_system, #frameworks, broulik,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 295 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/295/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 04 Feb 2020 05:05:15 + Build duration: 1 hr 22 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 287 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/287/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 04 Feb 2020 05:05:15 + Build duration: 1 hr 21 min and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 159 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/159/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 04 Feb 2020 05:55:09 + Build duration: 22 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 281 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/281/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 04 Feb 2020 05:55:09 + Build duration: 18 min and counting CONSOLE OUTPUT

D26691: Optimize code when dropping files into the desktop

This revision was automatically updated to reflect the committed changes. Closed by commit R242:f8be3ea7102f: Optimize code when dropping files into the desktop (authored by trmdi). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D27152: Introduce FilesystemEntry class

hallas created this revision. hallas added reviewers: Frameworks, bruns, meven. hallas added a project: Frameworks. hallas requested review of this revision. REVISION SUMMARY Introdue a dedicated type for representing a FilesystemEntry. A FilesystemEntry is either mounted by the system or can

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a comment. See D27150 as an example next to the test and docs for how this would be used. The ecm_qt_export_logging_category also is kept similar to ecm_qt_declare_logging_category in case someone wants to turn the manual definition to a

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a dependent revision: D27151: Use ecm_qt_install_logging_categories over manual categories file. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel,

D27151: Use ecm_qt_install_logging_categories over manual categories file

kossebau added a dependency: D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D27151 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2,

D27151: Use ecm_qt_install_logging_categories over manual categories file

kossebau created this revision. kossebau added reviewers: Build System, Frameworks, broulik, mlaurent. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. TEST PLAN Diff of generated file matches existing file, besides

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added inline comments. INLINE COMMENTS > ECMQtDeclareLoggingCategory.cmake:76 > +# FILE > +# DESTINATION > +# [SORT] Why the need for explicit DESTINATION argument, where almost all use-cases will use ${KDE_INSTALL_LOGGINGCATEGORIESDIR}? Because

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau created this revision. kossebau added reviewers: Build System, Frameworks, broulik, mlaurent. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Having to

D27082: [Tests]Make radiobutton3.qml use PC3

gvgeo added a comment. I 'll ask you to keep committing my patches a little longer. At least for my current patches, and their related bugfixes. REPOSITORY R242 Plasma Framework (Library) BRANCH radiobutton (branched from master) REVISION DETAIL https://phabricator.kde.org/D27082

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 104 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/104/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 04 Feb 2020 01:55:50 + Build duration: 34 min and counting JUnit Tests Name:

D27017: [KColorUtils] Add hue(), chroma(), getHcyColor() and update documentation

ndavis marked an inline comment as done. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27017 To: ndavis, #frameworks, dfaure Cc: mwoehlke, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27017: [KColorUtils] Add hue(), chroma(), getHcyColor() and update documentation

ndavis marked 2 inline comments as done. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27017 To: ndavis, #frameworks, dfaure Cc: mwoehlke, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27148: update d->m_file in ReadOnlyPart::setUrl()

pdabrowski created this revision. pdabrowski added reviewers: elvisangelaccio, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pdabrowski requested review of this revision. REVISION SUMMARY Properly update d->m_file so it can be safely used later in

D25123: [WIP] New yakuake logo/icon

ngraham added a comment. @mglb ping! I feel like we're really close for this. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25123 To: mglb, #vdg, #yakuake, hein Cc: GB_2, ndavis, ognarb, ngraham, hein, kde-frameworks-devel, numerodix, vmarinescu,

KDE CI: Frameworks » kauth » kf5-qt5 WindowsMSVCQt5.14 - Build # 3 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kauth/job/kf5-qt5%20WindowsMSVCQt5.14/3/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 03 Feb 2020 22:48:40 + Build duration: 2 min 46 sec and counting JUnit Tests Name:

D26961: Be more helpfully verbose when we can't start an action

This revision was automatically updated to reflect the committed changes. Closed by commit R283:5fc7551632ca: Be more helpfully verbose when we cant start an action (authored by davidedmundson). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE

D27140: Calculate KAuthAction::isValid on demand

This revision was automatically updated to reflect the committed changes. Closed by commit R283:afbfd5d436b1: Calculate KAuthAction::isValid on demand (authored by davidedmundson). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27140?vs=74950=74967 REVISION

D27017: [KColorUtils] Add hue(), chroma(), getHcyColor() and update documentation

ndavis retitled this revision from "[KColorUtils] Add hue(), chroma() and getHcyColor() and update documentation" to "[KColorUtils] Add hue(), chroma(), getHcyColor() and update documentation". REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27017 To: ndavis,

D27017: [KColorUtils] Add hue(), chroma() and getHcyColor() and update documentation

ndavis updated this revision to Diff 74964. ndavis added a comment. - Say that the hue, chroma and luma values are based on linear RGB. REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27017?vs=74963=74964 BRANCH hue-chroma (branched from master)

D27017: [KColorUtils] Add hue(), chroma() and getHcyColor() and update documentation

ndavis edited the summary of this revision. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27017 To: ndavis, #frameworks, dfaure Cc: mwoehlke, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27017: [KColorUtils] Add hue(), chroma() and getHcyColor() and update documentation

ndavis retitled this revision from "[KColorUtils] Add hue(), chroma() and getHcyColor()" to "[KColorUtils] Add hue(), chroma() and getHcyColor() and update documentation". REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27017 To: ndavis, #frameworks, dfaure Cc:

D27017: [KColorUtils] Add hue(), chroma() and getHcyColor()

ndavis updated this revision to Diff 74963. ndavis added a comment. - Update commments REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27017?vs=74962=74963 BRANCH hue-chroma (branched from master) REVISION DETAIL https://phabricator.kde.org/D27017

D27017: [KColorUtils] Add hue(), chroma() and getHcyColor()

ndavis updated this revision to Diff 74962. ndavis added a comment. - Wrap the hue REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27017?vs=74959=74962 BRANCH hue-chroma (branched from master) REVISION DETAIL https://phabricator.kde.org/D27017

D27017: [KColorUtils] Add hue(), chroma() and getHcyColor()

mwoehlke added inline comments. INLINE COMMENTS > broulik wrote in kcolorutils.h:42 > This doesn't mention hcy anywhere and there's `QColor::hue`. > But we already have `luma` in the same way, so I guess this is alright. I expect it wouldn't hurt to mention that `luma`, `chroma` and `hue` all

D27017: [KColorUtils] Add hue(), chroma() and getHcyColor()

mwoehlke added a comment. Indeed, we could have been having this conversation here instead of via e-mail . But, six of one... I believe `luma` and `chroma` are already guaranteed to return normalized values; it's just `hue` that you may want to normalize if you don't want to

D27017: [KColorUtils] Add hue(), chroma() and getHcyColor()

ndavis added a comment. Just realized @mwoehlke is on Phabricator, so I added him to the subscribers in case he has anything he wants to say. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27017 To: ndavis, #frameworks, dfaure Cc: mwoehlke, broulik,

D25682: add initial wsdiscovery support

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH arcpatch-D25682 REVISION DETAIL https://phabricator.kde.org/D25682 To: sitter, dfaure, #frameworks, #dolphin, ngraham Cc: meven, schmeisser, bcooksley, ngraham, caspermeijn,

D27017: [KColorUtils] Add hue(), chroma() and getHcyColor()

ndavis added a subscriber: mwoehlke. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27017 To: ndavis, #frameworks, dfaure Cc: mwoehlke, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27017: [KColorUtils] Add hue(), chroma() and getHcyColor()

ndavis added a comment. luma() and getHcy() don't return normalized luma amounts. Should they? If they should, then we should also normalize chroma() and wrap hue() as Matthew said. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27017 To: ndavis, #frameworks,

D27017: [KColorUtils] Add hue(), chroma() and getHcyColor()

ndavis added a comment. I emailed Matthew Woehlke: Me: > I noticed that the minimum value for hue was -0.17 (#ff00ff) and > the maximum was almost 0.83 (slightly less red than #ff00ff). Is > this intentional or a bug? It's a bit hard to tell how the math is > meant

D27017: [KColorUtils] Add hue(), chroma() and getHcyColor()

ndavis updated this revision to Diff 74959. ndavis added a comment. - Update hue() comment to reflect its true behavior REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27017?vs=74642=74959 BRANCH hue-chroma (branched from master) REVISION DETAIL

D27141: Drop Policykit backend

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY PolicyKit was replaced by "Polkit-1" 8 years ago. No supported Linux distribution is shipping

D27140: Calculate KAuthAction::isValid on demand

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R283 KAuth BRANCH delayed_isValid REVISION DETAIL https://phabricator.kde.org/D27140 To: davidedmundson, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27140: Calculate KAuthAction::isValid on demand

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Polkit1Backend fetches a list of /all/ actions once on startup, when we want to see if an action is

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ngraham added a comment. In D27122#605489 , @filipf wrote: > I really like this all in all, and the light version looks ready to go. > > The transparency in the dark one if fine IMO, it's just that the Breeze Dark color scheme should be

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

filipf added a comment. I really like this all in all, and the light version looks ready to go. The transparency in the dark one if fine IMO, it's just that the Breeze Dark color scheme should be somewhat darker and then the Plasma theme would also be darker. What's more important

D27123: Add a default provider (as per documentation)

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R235 Attica BRANCH provide-default-provider-as-per-docs (branched from master) REVISION DETAIL https://phabricator.kde.org/D27123 To: leinir, kossebau, #frameworks,

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/73/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 03 Feb 2020 18:32:50 + Build duration: 1 min 6 sec and counting JUnit Tests Name:

D27082: [Tests]Make radiobutton3.qml use PC3

ngraham added a comment. Additional documentation is at https://community.kde.org/Infrastructure/Get_a_Developer_Account Definitely apply! You've earned it. REPOSITORY R242 Plasma Framework (Library) BRANCH radiobutton (branched from master) REVISION DETAIL

D27112: Fix errors in the QRegularExpression porting commit

apol added a comment. LGTM, adding tests would be brilliant. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D27112 To: ahmadsamir, #frameworks, drosca, apol, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27080: Don't warn for invalid plugin metata

apol added a comment. Change to qDebug? this is just a result to an ugly workaround and is just a symptom of also a performance issue. Silencing it only perpetuates the issue. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27080 To: ngraham,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. I agree that the dark variant needs a bit of work still. I had focused on the light version. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove Cc: ngraham, davidedmundson, kde-frameworks-devel,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ngraham added a comment. Though I said I wouldn't be in favor of making Plasma elements more transparent, I have to admit that the changes look really, really good to my eye, at least for the light version. The dark version looks a bit odd to me though. It seems too transparent and not dark

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ngraham added a task: T11925: Breeze Desktop Theme Transparency. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove Cc: ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

ervin added reviewers: dfaure, Frameworks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27059 To: crossi, ervin, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

ervin added reviewers: dfaure, Frameworks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27133 To: crossi, ervin, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27132: Allow to use KPropertySkeletonItem in ManagedConfigModule

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27132 To: bport, #plasma, ervin, meven, crossi Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

crossi updated this revision to Diff 74938. crossi added a comment. noop REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27133?vs=74937=74938 REVISION DETAIL https://phabricator.kde.org/D27133 AFFECTED FILES autotests/kconfig_compiler/CMakeLists.txt

D27133: kconfig_compiler : generate kconfig settings with subgroup

crossi created this revision. crossi added a reviewer: ervin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. crossi requested review of this revision. REVISION SUMMARY Following D27059 , add group separator to generate

D27132: Allow to use KPropertySkeletonItem in ManagedConfigModule

bport created this revision. bport added reviewers: Plasma, ervin, meven, crossi. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27132

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added inline comments. INLINE COMMENTS > davidedmundson wrote in metadata.desktop.cmake:98 > There's an explicit comment on why this is as it is. > > That needs some addressing as to why it no longer applies or is less > important that some other change. Simply put, it doesn't work.

D27082: [Tests]Make radiobutton3.qml use PC3

davidedmundson added a comment. > I can't do that, someone else need to commit it. Then lets fix that. You can apply for a developer account (there should be a button on identity.kde.org) and tag me and Nate as approvers. REPOSITORY R242 Plasma Framework (Library) BRANCH

T11627: Improve KIO asynchronicity

ahartmetz added a comment. In T11627#219720 , @meven wrote: > In T11627#219718 , @ahartmetz wrote: > > > You may want to look at the DBus part of this with dfer-monitor, a tool I have written. It

T11627: Improve KIO asynchronicity

meven added a comment. In T11627#219718 , @ahartmetz wrote: > You may want to look at the DBus part of this with dfer-monitor, a tool I have written. It is especially useful for looking at latency problems. >

T11627: Improve KIO asynchronicity

ahartmetz added a comment. You may want to look at the DBus part of this with dfer-monitor, a tool I have written. It is especially useful for looking at latency problems. https://cgit.kde.org/dferry.git/ TASK DETAIL https://phabricator.kde.org/T11627 To: meven, ahartmetz Cc:

T11627: Improve KIO asynchronicity

ngraham updated the task description. TASK DETAIL https://phabricator.kde.org/T11627 To: meven, ngraham Cc: broulik, ognarb, #dolphin, #frameworks, meven, dfaure, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, spoorun,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove Cc: davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon,

Re: Banning QNetworkAccessManager

On Monday, 3 February 2020 10:49:10 CET David Edmundson wrote: > I updated: > > https://community.kde.org/Policies/API_to_Avoid > > Which had no mention of this. Thanks for taking care of this! I'd propose a slightly different approach than the per-request all-or-nothing attribute mentioned

D27123: Add a default provider (as per documentation)

leinir updated this revision to Diff 74917. leinir added a comment. - Use more modern style for the list initialisation REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27123?vs=74914=74917 BRANCH provide-default-provider-as-per-docs (branched from master)

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove Cc: davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon,

D27082: [Tests]Make radiobutton3.qml use PC3

gvgeo added a comment. > Ship it! I can't do that, someone else need to commit it. REPOSITORY R242 Plasma Framework (Library) BRANCH radiobutton (branched from master) REVISION DETAIL https://phabricator.kde.org/D27082 To: gvgeo, #plasma, davidedmundson Cc: davidedmundson,

D27123: Add a default provider (as per documentation)

leinir edited the summary of this revision. leinir added reviewers: kossebau, Frameworks, KNewStuff. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D27123 To: leinir, kossebau, #frameworks, #knewstuff Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27123: Add a default provider (as per documentation)

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Prior to this patch, without the KDE Platform Dependent, Attica would fail to correctly initialise providers from

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

davidedmundson resigned from this revision. davidedmundson added a comment. Change is now purely visual, so VDG can have say on the details. INLINE COMMENTS > metadata.desktop.cmake:98 > -contrast=0.2 > -#intensity is disabled, in order to auto adjust to the chosen theme color >

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, davidedmundson Cc: davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 74911. niccolove added a comment. Fixed accidental changes REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=74907=74911 BRANCH contrast_effect_background_color (branched from master)

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the summary of this revision. niccolove added projects: Plasma, VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, davidedmundson Cc: davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, davidedmundson Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25682: add initial wsdiscovery support

sitter added a comment. Any further comments? @dfaure in particular. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25682 To: sitter, dfaure, #frameworks, #dolphin, ngraham Cc: meven, schmeisser, bcooksley, ngraham, caspermeijn, davidedmundson,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > metadata.desktop.cmake:81 > X-KDE-PluginInfo-Name=default > -X-KDE-PluginInfo-Version=@KF5_VERSION@ > +X-KDE-PluginInfo-Version=5.66.0 >

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY I tweaked the contrast effect values to make Breeze a bit prettier (also similiarly to what's described here

Re: Banning QNetworkAccessManager

No, no. Please go the other way round and update the wiki to whatever working code you have. David

Re: Banning QNetworkAccessManager

Le lundi 3 février 2020, 10:49:10 CET David Edmundson a écrit : > I updated: > > https://community.kde.org/Policies/API_to_Avoid > > Which had no mention of this. > > David I think that you made an error "networkAccessManger->setAttribute(QNetworkRequest::FollowRedirectsAttribute, true); "

Re: Banning QNetworkAccessManager

I updated: https://community.kde.org/Policies/API_to_Avoid Which had no mention of this. David

Re: Banning QNetworkAccessManager

On Mon, Feb 3, 2020 at 7:42 AM Volker Krause wrote: > > I agree on the problem of QNAM's default, see also https://conf.kde.org/en/ > akademy2019/public/events/135 on that subject. > > On Saturday, 1 February 2020 23:24:14 CET Ben Cooksley wrote: > [...] > > Prior to now, i've taken the approach

D27028: Switch from download.k.o to autoconfig

leinir marked 6 inline comments as done. leinir added inline comments. INLINE COMMENTS > meven wrote in khotnewstuff.knsrc:2 > Better set this to https then, to make it explicit and not relying on server > expectations. Quite - that redirection isn't what these test knsrc files are supposed to

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 294 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/294/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 03 Feb 2020 08:59:07 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 286 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/286/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 03 Feb 2020 08:51:38 + Build duration: 24 min and counting JUnit Tests Name: projectroot

D27028: Switch from download.k.o to autoconfig

leinir updated this revision to Diff 74896. leinir added a comment. Address comments by meven and bcooksley - Make sure we're using https REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27028?vs=74687=74896 BRANCH

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 285 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/285/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 03 Feb 2020 08:41:04 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D26368: Add an isImmutable to know if a property is immutable

meven added a reviewer: dfaure. REPOSITORY R237 KConfig BRANCH arcpatch-D26368 REVISION DETAIL https://phabricator.kde.org/D26368 To: meven, ervin, #frameworks, dfaure Cc: dfaure, tcanabrava, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25117: file ioslave: stop copying as soon as the ioslave is killed

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8a834785c875: file ioslave: stop copying as soon as the ioslave is killed (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25117?vs=74870=74895

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

ahmadsamir updated this revision to Diff 74893. ahmadsamir added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24951?vs=68769=74893 BRANCH arcpatch-D24951 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24951

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:efa5438e39bb: [KOpenWithDialog] Automatically select the result if the model filter has only… (authored by

D25117: file ioslave: stop copying as soon as the ioslave is killed

dfaure added a comment. I wouldn't worry about the performance impact of the added if() statement, we're just testing a bool testMode which is always false (so the call to contains() will never happen outside tests) and the branch predictor will find out as soon as the second time, that

  1   2   >