KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 30 - Still Unstable!

2020-06-30 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/30/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Wed, 01 Jul 2020 03:57:23 +
 Build duration:
4 min 26 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_fileundomanagertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.15 - Build # 31 - Fixed!

2020-06-30 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.15/31/
 Project:
kf5-qt5 SUSEQt5.15
 Date of build:
Wed, 01 Jul 2020 03:57:23 +
 Build duration:
8 min 9 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.72.0.xmllogs/KF5KIO/5.72.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 54 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(288/431)67%
(288/431)57%
(36569/63775)41%
(18566/45116)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)96%
(10432/10908)46%
(4911/10694)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)90%
(179/198)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core87%
(103/118)87%
(103/118)60%
(8751/14487)52%
(4565/8722)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets74%
(32/43)74%
(32/43)58%
(4920/8471)45%
(2169/4854)src.gui100%
(7/7)100%
(7/7)78%
(643/824)62%
(373/598)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(718/1300)41%
(431/1054)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1376)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1802/4298)36%
(1309/3632)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1334)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 717 - Unstable!

2020-06-30 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/717/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 01 Jul 2020 03:57:24 +
 Build duration:
6 min 11 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.72.0.xmllogs/KF5KIO/5.72.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)68%
(281/415)68%
(281/415)57%
(36288/63375)41%
(18552/45134)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)95%
(10349/10869)46%
(4913/10716)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)60%
(8711/14412)52%
(4576/8730)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(29/38)76%
(29/38)58%
(4860/8386)45%
(2174/4858)src.gui88%
(7/8)88%
(7/8)78%
(635/819)62%
(373/598)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(718/1300)41%
(431/1054)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3632)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

D27197: Add symbolic screenshot icons

2020-06-30 Thread Nathaniel Graham 
ngraham added a comment.


  Thanks, that's better now. However the camera silhouette still doesn't match 
that of other monochrome camera images we have. I'd like to stick to standard 
iconography if possible. Do you think we should switch the other related icons 
to use your new camera icon, or would you like to use the one from, for 
example, `preferences-system-windows-effect-screenshot`?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27197

To: mbruchert, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

Re: Deprecate KRandomSequence ?

2020-06-30 Thread Albert Astals Cid 
El dimarts, 30 de juny de 2020, a les 22:17:56 CEST, Johan Ouwerkerk va 
escriure:
> On Tue, Jun 30, 2020 at 7:32 PM Albert Astals Cid  wrote:
> >
> > >
> > > If an application was relying on the random application sequence, it
> > > probably has bigger problems.
> >
> > Why? It's exactly what KRandomSequence (and QRandomGenerator) promise to do.
> >
> > And at least on KPat this is really useful.
> >
> > You can directly seed the random generator from the "Create new game" UI, 
> > so if there's a bug found in say game 1232145345, you can tell me that and 
> > then everyone can reproduce that bug since starting game 1232145345 gives 
> > everyone the same random numbers.
> >
> > Cheers,
> >   Albert
> >
> 
> As I read it, the only thing that could change is that KRandomSequence
> and QRandomGenerator will produce different outputs for the same seed
> value because the underlying PRNG may be different. So that might
> introduce a backwards incompatible change if you rely on the output of
> the sequence remaining stable between two versions of KPat. However,
> seeding it with a fixed value and then consuming the sequence should
> remain fully reproducible between two instances of the *same* KPat
> version.

Correct :)

Cheers,
  Albert

> 
> Regards,
> 
> - Johan
>

Re: Deprecate KRandomSequence ?

2020-06-30 Thread Johan Ouwerkerk 
On Tue, Jun 30, 2020 at 7:32 PM Albert Astals Cid  wrote:
>
> >
> > If an application was relying on the random application sequence, it
> > probably has bigger problems.
>
> Why? It's exactly what KRandomSequence (and QRandomGenerator) promise to do.
>
> And at least on KPat this is really useful.
>
> You can directly seed the random generator from the "Create new game" UI, so 
> if there's a bug found in say game 1232145345, you can tell me that and then 
> everyone can reproduce that bug since starting game 1232145345 gives everyone 
> the same random numbers.
>
> Cheers,
>   Albert
>

As I read it, the only thing that could change is that KRandomSequence
and QRandomGenerator will produce different outputs for the same seed
value because the underlying PRNG may be different. So that might
introduce a backwards incompatible change if you rely on the output of
the sequence remaining stable between two versions of KPat. However,
seeding it with a fixed value and then consuming the sequence should
remain fully reproducible between two instances of the *same* KPat
version.

Regards,

- Johan

Re: Deprecate KRandomSequence ?

2020-06-30 Thread Albert Astals Cid 
El dimarts, 30 de juny de 2020, a les 1:21:48 CEST, Aleix Pol va escriure:
> On Mon, Jun 29, 2020 at 10:27 PM Albert Astals Cid  wrote:
> >
> > QRandomGenerator is very similar in which you can give it a seed and get 
> > randomness out of it.
> >
> > Things that QRandomGenerator doesn't have:
> >  * getBool(); -> should be easy enough to port to bounded(2) == 1
> >  * randomize(QList) -> We could add namespace function in KRandom
> >  * modulate() -> Couldn't find any user, so no worries if we drop it
> >
> > Benefits of deprecation:
> >  * Less manintaince
> >
> > Problems of deprecation:
> >  * Moving from KRadomSequence(FIXED_SEED) to QRandomGenerator(FIXED_SEED) 
> > will probably generate a different sequence, so if you need to 100% 
> > generate the same sequence for all your app versions (e.g. for a game or 
> > something) moving may not be "possible"
> >
> > Ideas? Comments?
> 
> +1 makes sense to me.
> 
> If an application was relying on the random application sequence, it
> probably has bigger problems. 

Why? It's exactly what KRandomSequence (and QRandomGenerator) promise to do.

And at least on KPat this is really useful.

You can directly seed the random generator from the "Create new game" UI, so if 
there's a bug found in say game 1232145345, you can tell me that and then 
everyone can reproduce that bug since starting game 1232145345 gives everyone 
the same random numbers.

Cheers,
  Albert

> It can always be hardcoded into the
> application too.
> 
> Aleix
>

Syndication: Relicense notice

2020-06-30 Thread Christophe Giboudeaux 
Hi,

While porting the syndication files to use the SPDX license format, some files 
added by Frerich Raabe which originally lived in 'librss' (> 15 years ago) 
were marked as problematic. 

dataretriever.{cpp,h} and loader.{cpp,h} only have a partial license header 
pointing to a COPYING file which I can't find anywhere.

According to the relicensecheck script, all developers who pushed changes to 
these files allow to relicense files to LGPL-2.0-or-later.
Unless someone has a valid objection, I'll update the license header for these 
files in a couple days.

Christophe

D28745: Skip caching thumbnails on encrypted filesystems

2020-06-30 Thread Stefan Brüns 
bruns added a comment.


  In D28745#675698 , @marcingu wrote:
  
  > > How often do I have to repeat the thumbnailer has to use the canonical 
path anyway? Please use that.
  >
  > `storageAccessFromPath` converts given path into canonical. I figured it 
should do so anyway, so I'm not doing it again here.
  
  
  And thats wrong. You need the canonical path in the thumbnailer itself.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov

D27197: Add symbolic screenshot icons

2020-06-30 Thread Mathis Brüchert 
mbruchert updated this revision to Diff 83320.
mbruchert added a comment.


  Fix colors

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27197?vs=75125=83320

BRANCH
  sreenshot

REVISION DETAIL
  https://phabricator.kde.org/D27197

AFFECTED FILES
  icons-dark/actions/16/screenshot.svg
  icons-dark/actions/22/screenshot.svg
  icons/actions/16/screenshot.svg
  icons/actions/22/screenshot.svg

To: mbruchert, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28856: Save disabling of desktop file components in kglobalshortcutsrc

2020-06-30 Thread Méven Car 
meven added a comment.


  ping
  
  Would be important to land with 
https://invent.kde.org/frameworks/kglobalaccel/-/merge_requests/2

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D28856

To: davidre, davidedmundson, fvogt, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 716 - Fixed!

2020-06-30 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/716/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 30 Jun 2020 09:49:16 +
 Build duration:
5 min 45 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.72.0.xmllogs/KF5KIO/5.72.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 54 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)68%
(281/415)68%
(281/415)57%
(36332/63374)41%
(18577/45134)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)96%
(10393/10869)46%
(4938/10716)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)60%
(8711/14412)52%
(4575/8730)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(29/38)76%
(29/38)58%
(4860/8386)45%
(2174/4858)src.gui88%
(7/8)88%
(7/8)78%
(635/819)62%
(373/598)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(718/1300)41%
(431/1054)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3632)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.15 - Build # 30 - Unstable!

2020-06-30 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.15/30/
 Project:
kf5-qt5 SUSEQt5.15
 Date of build:
Tue, 30 Jun 2020 09:49:16 +
 Build duration:
5 min 57 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.72.0.xmllogs/KF5KIO/5.72.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(288/431)67%
(288/431)57%
(36531/63776)41%
(18552/45116)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)95%
(10388/10908)46%
(4891/10694)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)90%
(179/198)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core87%
(103/118)87%
(103/118)60%
(8763/14488)52%
(4574/8722)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets74%
(32/43)74%
(32/43)58%
(4925/8471)45%
(2172/4854)src.gui100%
(7/7)100%
(7/7)78%
(643/824)62%
(373/598)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(718/1300)41%
(431/1054)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1376)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1802/4298)36%
(1309/3632)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1334)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 29 - Still Unstable!

2020-06-30 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/29/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Tue, 30 Jun 2020 09:49:17 +
 Build duration:
4 min 18 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 306 - Fixed!

2020-06-30 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/306/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 30 Jun 2020 09:49:16 +
 Build duration:
2 min 55 sec and counting

D17816: Support for xattrs on kio copy/move

2020-06-30 Thread Gleb Popov 
arrowd added inline comments.

INLINE COMMENTS

> bruns wrote in jobtest.cpp:487
> not done ...

There are no arrays of `512` size anymore. Or am I missing something?

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

D17816: Support for xattrs on kio copy/move

2020-06-30 Thread Gleb Popov 
arrowd updated this revision to Diff 83319.
arrowd marked an inline comment as done.
arrowd added a comment.


  - Remove extraneous debugging output.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17816?vs=83318=83319

BRANCH
  arcpatch-D17816

REVISION DETAIL
  https://phabricator.kde.org/D17816

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/ConfigureChecks.cmake
  src/ioslaves/file/config-kioslave-file.h.cmake
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

D28745: Skip caching thumbnails on encrypted filesystems

2020-06-30 Thread Marcin Gurtowski 
marcingu added a comment.


  > How often do I have to repeat the thumbnailer has to use the canonical path 
anyway? Please use that.
  
  `storageAccessFromPath` converts given path into canonical. I figured it 
should do so anyway, so I'm not doing it again here.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov