D27475: Make kwapper/kshell spawn klauncher5 if needed

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R303 KInit BRANCH master REVISION DETAIL https://phabricator.kde.org/D27475 To: davidedmundson, apol Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27476: [KDBusConnectionPool] Handle the case of no qApp

apol added inline comments. INLINE COMMENTS > kdbusconnectionpool.cpp:66 > +if (!QCoreApplication::instance()) { > +return QDBusConnection::sessionBus(); > +} It feels like we should be using the s_perThreadConnection when we're not on a QApplication. Non-QApplications might st

D27475: Make kwapper/kshell spawn klauncher5 if needed

apol added inline comments. INLINE COMMENTS > CMakeLists.txt:57 > find_package(KF5Config ${KF5_DEP_VERSION} REQUIRED) > +find_package(KF5DBusAddons ${KF5_DEP_VERSION} REQUIRED) > find_package(KF5DocTools ${KF5_DEP_VERSION}) I suppose this should be if (NOT WIN32)? I'm not entirely sure why it

D27478: Add a --replace option to kded5

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Allows restarting kded5 properly, useful when trying new modules. TEST PLAN resta

Re: Standardizing Qt logging categories used in KF

On Mon, Feb 17, 2020 at 7:43 PM Friedrich W. H. Kossebau wrote: > > Hi, > > while going through the KF modules to adapt to the new > ecm_qt_install_logging_categories() macro* to auto-generate KDebugSettings > .categories (& .renamecategories) files I once more found there is no real > naming patt

D27459: Port QLinkedList which is deprecated in qt5.15

apol added a comment. In D27459#613205 , @aacid wrote: > Are we sure we can lose the features of QLinkedList here? > > maybe makes more sense to use std::list that has the same features as QLinkedList? I thought so too, but we just it

D27459: Port QLinkedList which is deprecated in qt5.15

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH port_QLinkedList (branched from master) REVISION DETAIL https://phabricator.kde.org/D27459 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, n

D26918: Improve KNotification API docs

apol added inline comments. INLINE COMMENTS > broulik wrote in knotification.h:96 > It actually sends out the icon name as a string and plasmashell then looks it > up. With QIcon? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26918 To: nicolasfella, #framewo

D26918: Improve KNotification API docs

apol added inline comments. INLINE COMMENTS > jucato wrote in knotification.h:96 > Maybe we should keep this part that the icon name, especially that it has to > be one that can be found by KIconLoader. Since Qt5 KIconLoader is an implementation detail. Even our apps and frameworks use QIcon::

Re: Taking over KNotifications maintainership

El dl., 17 de febr. 2020, 12:19, Kai Uwe Broulik va escriure: > Hi all, > > I propose to make me the official maintainer of KNotifications given > that's pretty much what I've been doing for quite some time already anyway. > > It still lists Martin Klapetek as maintainer who unfortunately isn't >

D26918: Improve KNotification API docs

apol added a subscriber: class. apol added a comment. Let's do this. +1 INLINE COMMENTS > Mainpage.dox:9 > + > +KNotification is the main entry point for using KNotifications. > + @class so we create a link. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26

D26918: Improve KNotification API docs

apol added a comment. +1 on improving the documentation, it does read dated. Thanks! INLINE COMMENTS > knotification.h:44 > * @li Feedback events: > - * For notifying the user that he/she just performed an operation, like > maximizing a > - * window. This allows us to play sounds when a di

D26749: WIP: Support NDK r20 and Qt 5.14

apol added a comment. Patch makes sense to me overall, we could consider landing it. INLINE COMMENTS > vkrause wrote in Android.cmake:173 > It's "better" in the way that it actually works with NDK r20, while CMake > 3.16 failed to even pass the basic compiler checks. For a toolchain file >

D27412: Port away from deprecated API on Qt 5.15.0

This revision was automatically updated to reflect the committed changes. Closed by commit R871:781064ba1c13: Port away from deprecated API on Qt 5.15.0 (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27412?vs=75714&id=75731#toc REPOSITORY R871 DrKonqi CHANGES SINCE

D27412: Port away from deprecated API on Qt 5.15.0

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Upstream recommends using QLocale for turning dates into strings. TEST PLAN Builds on my system now

D27366: Construct NullEngine with KPluginMetaData()

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27366 To: broulik, #plasma, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26858: Provide an implementation for the tablet interface

apol updated this revision to Diff 75564. apol added a comment. Only call destruction if it was an owned tablet, this way we don't crash. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=75561&id=75564 BRANCH arcpatch-D26858 REVISION DETAIL ht

D26858: Provide an implementation for the tablet interface

apol added a comment. In D26858#605869 , @davidedmundson wrote: > Feedback from some testing: > > - we're adding the same tool a bunch of times when a new client is created > - sometimes we fail to enter the surface leaving the cursor "stuc

D26858: Provide an implementation for the tablet interface

apol updated this revision to Diff 75561. apol added a comment. rebase on master REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=74473&id=75561 BRANCH arcpatch-D26858 REVISION DETAIL https://phabricator.kde.org/D26858 AFFECTED FILES CMakeL

D27338: Provide an initial implementation for input-method-unstable-v1

apol added a dependent revision: D27339: Implement input methods. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27338 To: apol, #kwin, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27338: Provide an initial implementation for input-method-unstable-v1

apol created this revision. apol added reviewers: KWin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Makes it possible to implement the protocol in your favourite compositor. TEST PLAN

Re: License Clarification for kguiaddons/tests/openurltest.cpp

Hi Andreas, I'm happy with it having whatever license is more appropriate within the framework. You suggestion makes sense to me. Aleix On Sat, Feb 8, 2020 at 4:43 PM Andreas Cord-Landwehr wrote: > > Hi Aleix, > > I found the file kguiaddons/tests/openurltest.cpp with an ambiguous license > stat

D25495: Fix Sonnet autodetect failing on Indian langs

apol added a comment. This patch makes it do all the languages identified by identify + all the languages supported by the script. This could mean lots of languages for some scripts... INLINE COMMENTS > guesslanguage.cpp:586 > + > +QStringList candidateLanguages = d->identify(text, scri

D27207: Use a less convoluted way to check if it's in flatpak

This revision was automatically updated to reflect the committed changes. Closed by commit R271:9027710fb817: Use a less convoluted way to check if it's in flatpak (authored by apol). REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27207?vs=75156&id=75163

D27207: Use a less convoluted way to check if it's in flatpak

apol created this revision. apol added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REPOSITORY R271 KDBusAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27207 AFFECTED F

D27067: Change "AutoSkip" to "Skip All"

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27067 To: ngraham, #frameworks, #vdg, dfaure, apol Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, b

D27080: Don't warn for invalid plugin metata

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH less-warning-spam (branched from master) REVISION DETAIL https://phabricator.kde.org/D27080 To: ngraham, #plasma, mart, apol Cc: apol, alex, kde-frameworks-devel

D27203: Don't try to open files we can't figure out where they are

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. TEST PLAN Been using it for a few days, no regressions. Opening sftp:///localhost/.../somefile.text twice, doesn't try

D27200: Make the attached property a simple QObject

apol added a comment. LGTM otherwise INLINE COMMENTS > colorscope.cpp:57 > +connect(parentItem, &QQuickItem::windowChanged, > this, [this]() { > findParentScope(); let's make this a proper method? it's used twice here and a normal method should be quick

D25698: New query mechanism for applications: KApplicationTrader

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. +1 Makes sense. REPOSITORY R309 KService BRANCH kapplicationtrader REVISION DETAIL https://phabricator.kde.org/D25698 To: dfaure, broulik, mart, vkrause, nicolasfella, aacid, davidedmun

D27123: Add a default provider (as per documentation)

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R235 Attica BRANCH provide-default-provider-as-per-docs (branched from master) REVISION DETAIL https://phabricator.kde.org/D27123 To: leinir, kossebau, #frameworks, #kne

D27112: Fix errors in the QRegularExpression porting commit

apol added a comment. LGTM, adding tests would be brilliant. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D27112 To: ahmadsamir, #frameworks, drosca, apol, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27080: Don't warn for invalid plugin metata

apol added a comment. Change to qDebug? this is just a result to an ugly workaround and is just a symptom of also a performance issue. Silencing it only perpetuates the issue. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27080 To: ngraham, #pla

D27034: Fix message box when passing a remote url that includes a file

This revision was automatically updated to reflect the committed changes. Closed by commit R135:317a899dc774: Fix message box when passing a remote url that includes a file (authored by apol). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabric

D27034: Fix message box when passing a remote url that includes a file

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY The if was negated, I assume it was a typo TEST PLAN I don't get the following screenshot anymore R

D26133: Enable Auto Save

apol added a comment. In D26133#603118 , @tcanabrava wrote: > > That's why personally I think it's fine to assume people need to opt-in for GenerateProperties if they want the feature, it's closely related after all. > > I disagree here. >

D26573: Add missing Import Env Variable

apol added a comment. I don't really understand why this is needed, I've never needed that at least. Having @davidedmundson's patch would be interesting too, although we might want to support earlier versions that won't get the patch. REPOSITORY R240 Extra CMake Modules BRANCH add_m

Re: SPDX KAboutLicense

On Tue, Jan 28, 2020 at 12:29 PM Harald Sitter wrote: > > Hey! > > For general interest, and so this thought doesn't only exist in my > head: As a follow-up to us embracing SPDX for code files it would make > a whole lot of sense sense to move KAboutLicense away from our custom > text format (see

D26858: Provide an implementation for the tablet interface

apol updated this revision to Diff 74473. apol added a comment. clang format REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=74241&id=74473 BRANCH apol/tablet-unstable-v2-1 REVISION DETAIL https://phabricator.kde.org/D26858 AFFECTED FILES

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH port_QXmlStreamReader (branched from master) REVISION DETAIL https://phabricator.kde.org/D26890 To: mlaurent, dfaure, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

apol added inline comments. INLINE COMMENTS > kconfigloader.cpp:125 > for (int i = 0; i < numAttrs; ++i) { > -QString name = attrs.localName(i).toLower(); > +const QString name = attrs.at(i).name().toString().toLower(); > if (name == QLatin1String("na

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

apol added inline comments. INLINE COMMENTS > kconfigloader.cpp:77 > +case QXmlStreamReader::Characters: > +if (!reader.isWhitespace() && > !reader.text().toString().trimmed().isEmpty()) { > +if (!characters(reader.text())) No need to construct a QString if i

D26900: Support multiple values in XDG_CURRENT_DESKTOP

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. The patch looks good to me. INLINE COMMENTS > apol wrote in kservice.cpp:658 > You can use QVector here, it would save us constructing a bunch > of strings for no reason. Maybe not in the gene

D26903: allow programLogo property to be a QIcon, too

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D26903 To: cullmann, apol Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26900: Support multiple values in XDG_CURRENT_DESKTOP

apol added inline comments. INLINE COMMENTS > kservice.cpp:658 > > -QStringList > currentDesktops(QString::fromLatin1(qgetenv("XDG_CURRENT_DESKTOP"))); > +QStringList > currentDesktops(QString::fromLatin1(qgetenv("XDG_CURRENT_DESKTOP")).split(QLatin1Char(':'), > Qt::SkipEmptyParts));

D26876: Remove the Enum hack: finish lists with a comma, it's valid c++

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH remove_enum_hack REVISION DETAIL https://phabricator.kde.org/D26876 To: tcanabrava, ervin, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

apol added a comment. Looks good otherwise, this code is pretty well tested too, so I quite trust we aren't breaking it horribly. Trying to compile the rest of KDE Software against this patch would also be useful. INLINE COMMENTS > kconfigloader.cpp:127 > } else if (name =

D26858: Provide an implementation for the tablet interface

apol updated this revision to Diff 74241. apol added a comment. Address comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=74217&id=74241 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26858 AFFECTED FILES CMakeLists.txt

D26858: Provide an implementation for the tablet interface

apol marked 11 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26858 To: apol, #kwin, #frameworks, zzag Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26858: Provide an implementation for the tablet interface

apol updated this revision to Diff 74217. apol added a comment. ehm.. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=74214&id=74217 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26858 AFFECTED FILES CMakeLists.txt autot

D26858: Provide an implementation for the tablet interface

apol reopened this revision. apol added a comment. Phabricator chokes on git branches... REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26858 To: apol, #kwin, #frameworks, zzag Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26858: Provide an implementation for the tablet interface

apol updated this revision to Diff 74213. apol added a comment. remove unrelated bits REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=74212&id=74213 BRANCH apol/tablet-unstable-v2 REVISION DETAIL https://phabricator.kde.org/D26858 AFFECTED F

D26858: Provide an implementation for the tablet interface

apol updated this revision to Diff 74212. apol added a comment. Addressed zzag's comments, fixed the patch overall. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=74187&id=74212 BRANCH apol/tablet-unstable-v2 REVISION DETAIL https://phabrica

D26858: Provide an implementation for the tablet interface

apol marked 6 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26858 To: apol, #kwin, #frameworks, zzag Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26858: Provide an implementation for the tablet interface

apol added a dependent revision: D26859: Implement the tablet wayland protocol in kwin. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26858 To: apol, #kwin, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26858: Provide an implementation for the tablet interface

apol created this revision. apol added reviewers: KWin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Implements the necessary classes to have proper support for the tablet and pen. Doe

D26800: autotests: use local desktop file to avoid relying on konsole

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D26800 To: dfaure, meven, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26781: Fix test since Konsole added icons to its actions

apol added a comment. How about we ship a desktop file here to test instead of using the one in the system? It doesn't make much sense that there's this weird dependency here. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D26781 To: meven, #frameworks, dfaure

D26740: Add KService::isSubseq as a public API for filtering queries.

apol added a comment. > I like isSubsequence(). But I also just realized, it's a bit odd to have this in KService. I think I should make it part of the KApplicationTrader namespace instead, since it's a utility method for querying. > This means merging with D25698

D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names

apol accepted this revision. apol added a comment. Looks good to me, bonus points if you provide a better commit message explaining what it does and how you tested it. REPOSITORY R240 Extra CMake Modules BRANCH sc_appicon REVISION DETAIL https://phabricator.kde.org/D26751 To: patrick

D26749: WIP: Support NDK r20 and Qt 5.14

apol added inline comments. INLINE COMMENTS > Android.cmake:173 > +set(ANDROID_STL ${CMAKE_ANDROID_STL_TYPE}) > +include(${CMAKE_ANDROID_NDK}/build/cmake/android.toolchain.cmake REQUIRED) > + Why's this better? Or how is it different? REPOSITORY R240 Extra CMake Modules REVISION DETAIL htt

D26735: [Components 3]Make slider tickmarks optional

apol added a comment. But this means that for your keyboard it's either on or off, right? This is what it looks for me. The screen has hundreds of steps so it shows nothing, for the keyboard it has a middle step so it's shown below. I don't think it should be removed. F7893059: IMG_202

D26735: [Components 3]Make slider tickmarks optional

apol added a comment. You should only see them if you have very a few discrete number of steps. Can you show a screenshot of what you see that you don't like? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26735 To: gvgeo, #plasma, #vdg Cc: apol,

D26740: Add KService::isSubseq as a public API for filtering queries.

apol added a comment. Other than that, makes sense. INLINE COMMENTS > kservice.h:576 > + */ > +static bool isSubseq(const QString& pattern, const QString& text, > Qt::CaseSensitivity cs = Qt::CaseSensitive); > + Can we give it a better name? How about something like `isContained`? o

D26736: QHash::insertMulti is deprecated in qt5.15 => port to QMultiHash

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH use_multihash (branched from master) REVISION DETAIL https://phabricator.kde.org/D26736 To: mlaurent, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, n

D26737: QJsonDocument::fromBinaryData is deprecated in qt5.15. We need to port to QCborValue::fromCbor

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH port_to_QCborValue (branched from master) REVISION DETAIL https://phabricator.kde.org/D26737 To: mlaurent, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D26713: Adapt to Qt 5.14 Android changes

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D26713 To: vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26707: Fix QRegularExpression::wildcardToRegularExpression() usage

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R311 KWallet BRANCH l-qregularexpression-wildcard (branched from master) REVISION DETAIL https://phabricator.kde.org/D26707 To: ahmadsamir, #frameworks, apol, dfaure Cc: kde-frameworks-devel, LeGast00

D26693: Fix QRegularExpression::wildcardToRegularExpression() usage

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH l-qregularexpressoin-wildcard (branched from master) REVISION DETAIL https://phabricator.kde.org/D26693 To: ahmadsamir, #frameworks, apol, dfaure Cc: kde-frameworks-devel,

D26122: Add utility text function KShell::tildeCollapse

apol accepted this revision. apol added a comment. Looks good to me, just explain what it does on the commit message. REPOSITORY R244 KCoreAddons BRANCH arcpatch-D26122 REVISION DETAIL https://phabricator.kde.org/D26122 To: meven, #frameworks, broulik, ngraham, ervin, apol Cc: apol, k

D26633: Deprecate KWindowEffects::markAsDashboard()

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kwindoweffects.h:164 > * > * @param window The window for which to enable the blur effect > */ @deprecated since 5.67, support for dashboard windows was removed REPO

D26626: Allow to also pass a target instead of list of sources to KCONFIG_ADD_KCFG_FILES

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense, thanks David! Please address kossebau's comments before landing. REPOSITORY R237 KConfig BRANCH target (branched from master) REVISION DETAIL https://phabricator.kde.or

D26616: Adjust metainfo.yaml to new tier

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH tier REVISION DETAIL https://phabricator.kde.org/D26616 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22875: Offer toolTipDelay as a plasma unit

apol abandoned this revision. apol added a comment. This was eventually fixed in a different way REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22875 To: apol, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23586: Improve code that detects useful elements in an Svg file

apol updated this revision to Diff 73324. apol added a comment. address fregl's commetn REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23586?vs=65005&id=73324 BRANCH arcpatch-D23586 REVISION DETAIL https://phabricator.kde.org/D23586

D23586: Improve code that detects useful elements in an Svg file

apol marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23586 To: apol, #plasma, #frameworks Cc: gladhorn, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23682: Make use of KPluginMetaData where we can

This revision was automatically updated to reflect the committed changes. Closed by commit R242:591aceb3f926: Make use of KPluginMetaData where we can (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23682?vs=73322&id=73323

D23682: Make use of KPluginMetaData where we can

apol updated this revision to Diff 73322. apol added a comment. Addressed kossebau's comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23682?vs=68546&id=73322 BRANCH arcpatch-D23682 REVISION DETAIL https://phabricator.kde.org/

D23682: Make use of KPluginMetaData where we can

apol marked 8 inline comments as done. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D23682 To: apol, #plasma, mart Cc: kossebau, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26597: Drop HAVE_X11 remnants

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R252 Framework Integration BRANCH no-have-x11 REVISION DETAIL https://phabricator.kde.org/D26597 To: asturmlechner, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26596: Drop unused dependency

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R252 Framework Integration BRANCH unused-deps REVISION DETAIL https://phabricator.kde.org/D26596 To: asturmlechner, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26594: Deprecate raiseWidget

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH raise REVISION DETAIL https://phabricator.kde.org/D26594 To: nicolasfella, #frameworks, broulik, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26588: Simplify usage of QMimeDatabase.

apol accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26588 To: dfaure, chinmoyr, ngraham, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25490: Remove legacy plugin loading code

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH service REVISION DETAIL https://phabricator.kde.org/D25490 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26532: Don't use KWindowSystem on Android

apol accepted this revision. REPOSITORY R289 KNotifications BRANCH nokwindowsystem REVISION DETAIL https://phabricator.kde.org/D26532 To: nicolasfella, #frameworks, vkrause, apol Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26524: configmodule: Make sure the kcm information is loaded when the qml is created

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Otherwise we'll initialize with dumb values and refresh it when shown, which isn't

D26512: Drop unused headers

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D26512 To: davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26502: [ConfigModule] Say which package is invalid

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26502 To: broulik, #plasma, mart, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26465: Port endl to \n Not necessary to flush as QTextStream uses QFile which flush when it's deleted

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH port_endl (branched from master) REVISION DETAIL https://phabricator.kde.org/D26465 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michael

D26464: Port qrand to QRandomGenerator (qrand is deprecated in qt5.15)

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH port_QRandomGenerator (branched from master) REVISION DETAIL https://phabricator.kde.org/D26464 To: mlaurent, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, mic

D26453: [Purpose] Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26453 To: ahmadsamir, apol, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, micha

D26194: Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26194 To: ahmadsamir, #plasma, davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, GB

D26416: Kicker/Documents optimization: Lazily build KFileItem

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D26416 REVISION DETAIL https://phabricator.kde.org/D26416 To: meven, #frameworks, apol Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fba

D26416: Kicker/Documents optimization: Lazily build KFileItem

apol added inline comments. INLINE COMMENTS > recentusagemodel.cpp:251 > +auto getFileItem = [=] () { > +#if KIO_VERSION >= QT_VERSION_CHECK(5,57,0) > +// Avoid calling QT_LSTAT and accessing recent documents I'm pretty sure we can/should depend on newer KF5. I'd say just

D26402: [android] Fix apk install target

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH androidinstall REVISION DETAIL https://phabricator.kde.org/D26402 To: nicolasfella, apol Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michael

D26394: ECMGeneratePriFile: Fix static configurations

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D26394 To: kfunk, dfaure, winterz, vkrause, apol Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreas

D26303: Remove endl in qDebug as it's already add "\n" + port to Qt::endl in qt5.15

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH port_endl (branched from master) REVISION DETAIL https://phabricator.kde.org/D26303 To: mlaurent, dfaure, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ahmadsamir wrote in kuitmarkup.cpp:412 > According to the QList docs, at() should be used for read-only access, it > could be faster than [] and it never causes a detach.

D26374: [Attica] Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26374 To: ahmadsamir, #frameworks, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, m

D26372: In qt5.15 QHash::insertMulti is deprecated now we need to use QMultiHash

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH use_qmultihash (branched from master) REVISION DETAIL https://phabricator.kde.org/D26372 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, L

<    1   2   3   4   5   6   7   8   9   10   >