://git.reviewboard.kde.org/r/112451/diff/
Testing
---
Installs and seems to work.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112457/#review39242
---
On Sept. 2, 2013, 4:42 p.m., Aleix Pol Gonzalez wrote
/klineedit.cpp b2b430d
staging/kcompletion/src/config-kcompletion.h.cmake 35b64a2
staging/kcompletion/src/CMakeLists.txt f08a47d
staging/kcompletion/src/klineedit_p.h 4d3cfbc
Diff: http://git.reviewboard.kde.org/r/112485/diff/
Testing
---
builds, tests pass
Thanks,
Aleix Pol Gonzalez
-modules/FindDocBookXSL.cmake PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/112451/diff/
Testing
---
Installs and seems to work.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
.
Diffs (updated)
-
attic/modules/FindDocBookXML.cmake 26053bf
attic/modules/FindDocBookXSL.cmake ab93c9e
Diff: http://git.reviewboard.kde.org/r/112451/diff/
Testing
---
Installs and seems to work.
Thanks,
Aleix Pol Gonzalez
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119590/#review63719
---
Ship it!
Makes sense to me.
- Aleix Pol Gonzalez
On Aug
.
- Aleix Pol Gonzalez
On Aug. 3, 2014, 7:13 p.m., Thomas Lübking wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119593
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119594/#review63721
---
Ship it!
Makes sense to me.
- Aleix Pol Gonzalez
On Aug
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119588/#review63888
---
Ship it!
Looks reasonable to me.
- Aleix Pol Gonzalez
you're not accessing through them.
And maybe you can use the more generic type QAbstractButton, only maybe, I'm
unsure, up to you.
- Aleix Pol Gonzalez
On Aug. 10, 2014, 8:28 p.m., Albert Astals Cid wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119698/#review64263
---
Ship it!
Makes sense to me.
- Aleix Pol Gonzalez
On Aug
/119713/#comment44914
Wouldn't it be better to use something like this?
QIcon::setThemeSearchPaths(QIcon::themeSearchPaths()+thePathFor(breeze));
- Aleix Pol Gonzalez
On Aug. 11, 2014, 1:24 p.m., Albert Astals Cid wrote
the properties' methods (get/set/signal)
from the rest of the documentation? It would be really cool to document them
all together.
- Aleix Pol Gonzalez
On Aug. 11, 2014, 10:35 p.m., David Edmundson wrote:
---
This is an automatically generated e
in the sprint, I think we
should move this into the kde:kwidgetsaddons repository, in an examples
subdirectory.
- Aleix Pol Gonzalez
On Aug. 12, 2014, 9:33 a.m., Laurent Navet wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119745/#review64405
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Aug. 12, 2014
/kde5/lib64
Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons
Requires: Qt5Core
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119808/#review64750
---
Maybe a screenshot will make it easier to review?
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119798/#review64585
---
On Aug. 14, 2014, 11:10 p.m., Aleix Pol Gonzalez wrote
, on my system:
Name: KF5CoreAddons
Version: 5.1.0
Libs: -L/home/kde-devel/kde5/lib64 -l/home/kde-devel/kde5/lib64
Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons
Requires: Qt5Core
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
to interact with the
File List more often. I think this shows we want a new design after all.
For the moment, I won't +1 or -1.
- Aleix Pol Gonzalez
On Aug. 18, 2014, 10:04 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail
: KF5CoreAddons
Version: 5.1.0
Libs: -L/home/kde-devel/kde5/lib64 -l/home/kde-devel/kde5/lib64
Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons
Requires: Qt5Core
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
that don't use
KDEInstallDirs can create their own variable.
Also, pkconfig - pkgconfig.
Aleix Pol Gonzalez wrote:
I'm unsure about that, first ECM_MKSPECS_INSTALL_DIR is declared the same
way (again, copypaste) then I understand that we can override the variable
from
On Aug. 19, 2014, 10:19 a.m., Aleix Pol Gonzalez wrote:
I think it's disputable that the developers will want to interact with the
File List more often. I think this shows we want a new design after all.
For the moment, I won't +1 or -1.
Alex Merry wrote:
I'm admittedly going
break integration
quite a bit, wouldn't it be possible to set it as fallback?
- Aleix Pol Gonzalez
On Aug. 13, 2014, 8:55 p.m., Albert Astals Cid wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Aug. 24, 2014, 9:56 p.m., Aleix Pol Gonzalez wrote:
Changing the theme for everyone using kconfigwidgets would break
integration quite a bit, wouldn't it be possible to set it as fallback?
Albert Astals Cid wrote:
Break integration with what?
It only changes the theme
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119713/#review65160
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Aug. 13, 2014
/CMake_Coding_Style#End_commands
- Aleix Pol Gonzalez
On Aug. 25, 2014, 6 p.m., Rohan Garg wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901
/KCoreAddons
Requires: Qt5Core
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
screenshot would help in these reviews.
- Aleix Pol Gonzalez
On Aug. 26, 2014, 2:14 p.m., Hugo Pereira Da Costa wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119940
, reproduced with an application.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/119975/diff/
Testing
---
Ran tests, reproduced with an application.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
the comments are from
human?
- Aleix Pol Gonzalez
On Aug. 29, 2014, 2:16 p.m., Denis Steckelmacher wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119991
smarter with
@reimp, no?
- Aleix Pol Gonzalez
On Aug. 29, 2014, 9:42 p.m., Martin Klapetek wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119997
On Aug. 31, 2014, 4:57 a.m., Matthew Dawson wrote:
Thanks for taking a look at this. It appears KConfigBase isn't available
on api.kde.org as it isn't documented, as kapidox hides such classes by
default. As KConfigBase is used outside of KConfig, I'd prefer if
KConfigBase gained a
.
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119798/#review65528
---
On Aug. 26, 2014, 11:51 a.m., Aleix Pol Gonzalez wrote
${PRI_FILENAME} DESTINATION ${ECM_MKSPECS_INSTALL_DIR})
This is the result, on my system:
Name: KF5CoreAddons
Version: 5.1.0
Libs: -L/home/kde-devel/kde5/lib64 -l/home/kde-devel/kde5/lib64
Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons
Requires: Qt5Core
Thanks,
Aleix Pol Gonzalez
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/#review65702
---
Ship it!
I think it looks good, let's get this in.
- Aleix
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120049/#review65781
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Sept. 3, 2014
a9b7cc8
Diff: https://git.reviewboard.kde.org/r/119975/diff/
Testing
---
Ran tests, reproduced with an application.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
${PRI_FILENAME} DESTINATION ${ECM_MKSPECS_INSTALL_DIR})
This is the result, on my system:
Name: KF5CoreAddons
Version: 5.1.0
Libs: -L/home/kde-devel/kde5/lib64 -l/home/kde-devel/kde5/lib64
Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons
Requires: Qt5Core
Thanks,
Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/120118/diff/
Testing
---
Plasma Framework is already doing it, I just moved the code.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
On Sept. 8, 2014, 10:22 p.m., Ben Cooksley wrote:
What is the status of this? Is there anything blocking it being shipped and
made available on api.kde.org?
Denis Steckelmacher wrote:
It works locally, so I'm just waiting for a ship-it or other comments :-)
Aleix Pol Gonzalez
Requires: Qt5Core
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Framework is already doing it, I just moved the code.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
it locally, then too.
Diffs
-
kde-modules/KDECompilerSettings.cmake f0d1aef
modules/ECMCoverageOption.cmake PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/120118/diff/
Testing
---
Plasma Framework is already doing it, I just moved the code.
Thanks,
Aleix Pol Gonzalez
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119867/#review66279
---
Ship it!
Looks good to me.
- Aleix Pol Gonzalez
On Aug
to be visually
integrated with the host application?
Do we get to hit the scrollbar if the component doesn't have a margin and it's
by the screen's border?
- Aleix Pol Gonzalez
On Sept. 11, 2014, 9:25 p.m., Hugo Pereira Da Costa wrote
On Sept. 11, 2014, 10:19 p.m., Aleix Pol Gonzalez wrote:
Why is the component responsible for defining how it's going to be visually
integrated with the host application?
Do we get to hit the scrollbar if the component doesn't have a margin and
it's by the screen's border?
Hugo
different things to me.
- Aleix Pol Gonzalez
On Sept. 14, 2014, 10:19 a.m., Christoph Cullmann wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120196
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote:
Shouldn't it be called FindLibGit2?
Git2 and LibGit2 seem different things to me.
Christoph Cullmann wrote:
I can rename it, but then it is inconsistent with most other
FindXXX.cmake's, as they skip the lib prefix.
I'm
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote:
Shouldn't it be called FindLibGit2?
Git2 and LibGit2 seem different things to me.
Christoph Cullmann wrote:
I can rename it, but then it is inconsistent with most other
FindXXX.cmake's, as they skip the lib prefix
...
- Aleix Pol Gonzalez
On Sept. 17, 2014, 12:07 p.m., David Edmundson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120243
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120277/#review66932
---
Ship it!
Looks good to me.
- Aleix Pol Gonzalez
On Sept
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120278/#review66933
---
Ship it!
Looks good to me too
- Aleix Pol Gonzalez
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120283/#review66949
---
Makes sense. +1
- Aleix Pol Gonzalez
On Sept. 19, 2014, 11
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120332/#review67288
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Sept. 23, 2014
into this.
- Aleix Pol Gonzalez
On Sept. 25, 2014, 12:36 p.m., Hugo Pereira Da Costa wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120361
argument.
Maybe you can make it a normal cmake option() and use configure_file() to
generate a kdesu_config.h file?
- Aleix Pol Gonzalez
On Sept. 26, 2014, 3:35 p.m., Jonathan Riddell wrote:
---
This is an automatically generated e-mail
://git.reviewboard.kde.org/r/120422/diff/
Testing
---
Builds.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
we should fix
polkit-qt cmake files to do so?
- Aleix Pol Gonzalez
On Sept. 29, 2014, 12:59 p.m., Helio Castro wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120421
src/kcmultidialog.cpp 8fd2cfd
Diff: https://git.reviewboard.kde.org/r/120448/diff/
Testing
---
Reproduced the Bugs in the Bugs: section (Baloo and KDE Connect).
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks
a chance
to figure out the correct size properly.
Diffs
-
src/kcmultidialog.h 78b1625
src/kcmultidialog.cpp 8fd2cfd
Diff: https://git.reviewboard.kde.org/r/120448/diff/
Testing
---
Reproduced the Bugs in the Bugs: section (Baloo and KDE Connect).
Thanks,
Aleix Pol Gonzalez
/kdeplatformsystemtrayicon.h 6ceaa43
src/platformtheme/kdeplatformsystemtrayicon.cpp 3ada7d2
Diff: https://git.reviewboard.kde.org/r/120422/diff/
Testing
---
Builds.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120508/#review67976
---
The port looks legit to me.
+1
- Aleix Pol Gonzalez
On Oct. 8, 2014, 9:22 p.m., Albert Astals Cid wrote:
According to
https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++
changing the const/volatile qualifiers of the function is BIC
Now the thing is if we allow BIC changes in frameworks like attica or not
is for
Discover, which use the component. Everything
still works.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120550/#review68307
---
On Oct. 13, 2014, 11:13 a.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e
://git.reviewboard.kde.org/r/120550/diff/
Testing
---
I added some manual test (that was impossible to run before the patch). Also
tested it in KRunner and Muon Discover, which use the component. Everything
still works.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks
On Oct. 13, 2014, 1:35 p.m., Marco Martin wrote:
src/quickaddons/managedtexturenode.h, line 52
https://git.reviewboard.kde.org/r/120550/diff/2/?file=318205#file318205line52
even if will always remain just this member, just to me sure, it should
be in a dpointer
Aleix Pol
crash anymore.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/appletquickitem.cpp 45055a5
Diff: https://git.reviewboard.kde.org/r/120581/diff/
Testing
---
Doesn't crash anymore.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120592/#review68423
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Oct. 14, 2014
src/CMakeLists.txt eb0dfd3
Diff: https://git.reviewboard.kde.org/r/120550/diff/
Testing
---
I added some manual test (that was impossible to run before the patch). Also
tested it in KRunner and Muon Discover, which use the component. Everything
still works.
Thanks,
Aleix Pol Gonzalez
8cc7bb3
src/plasmaquick/CMakeLists.txt a10beab
src/declarativeimports/core/CMakeLists.txt 9aba919
src/declarativeimports/core/framesvgitem.h 73494d4
Diff: https://git.reviewboard.kde.org/r/120596/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120603/#review68528
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Oct. 15, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120606/#review68553
---
Can we maybe get a unit test for that?
- Aleix Pol Gonzalez
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120621/#review68613
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Oct. 17, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120622/#review68614
---
Ship it!
Looks good!
- Aleix Pol Gonzalez
On Oct. 17
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120640/#review68670
---
Looks good to me. +1
- Aleix Pol Gonzalez
On Oct. 18, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120641/#review68671
---
+1 Looks good to me.
- Aleix Pol Gonzalez
On Oct. 18, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120641/#review68862
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Oct. 18, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120640/#review68861
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Oct. 18, 2014
seen the header file, nobody is linking
against it (if they don't copy the header over, which is not supported, of
course).
- Aleix Pol Gonzalez
On Oct. 22, 2014, 5:33 p.m., Martin Klapetek wrote:
---
This is an automatically generated
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120854/#review69303
---
Should maybe be delay 0?
Either way, +1.
- Aleix Pol
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120903/#review69503
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Oct. 30, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121007/#review69990
---
This makes me so happy I want to hug you.
- Aleix Pol
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121076/#review70147
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Nov. 8, 2014
a step forward towards a ported
dolphin.
I'm saying shipit because I've ended having to do that in many projects
already. Thanks!
- Aleix Pol Gonzalez
On Nov. 8, 2014, 10:25 p.m., Andrius da Costa Ribas wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121080/#review70149
---
Shouldn't it be actually implemented then?
- Aleix Pol
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121062/#review70153
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Nov. 8, 2014, 2
://git.reviewboard.kde.org/r/121065/#comment49080
missing an _
:)
Note the typo, but looks good.
- Aleix Pol Gonzalez
On Nov. 8, 2014, 2:15 p.m., Burkhard Lück wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121066/#review70155
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Nov. 8, 2014, 2
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121067/#review70156
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Nov. 8, 2014, 2
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121068/#review70157
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Nov. 8, 2014, 2
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121090/#review70188
---
+1 makes sense to me.
- Aleix Pol Gonzalez
On Nov. 10
On Nov. 11, 2014, 12:22 p.m., Laurent Montel wrote:
src/lib/text/ktexttohtml.cpp, line 380
https://git.reviewboard.kde.org/r/121094/diff/1/?file=327569#file327569line380
same here
There's no semantic difference between x++ and ++x here, I don't see the point
of requesting this
On Nov. 11, 2014, 2:39 p.m., Albert Astals Cid wrote:
I sincerely think this is a *VERY BAD* idea. I don't want my app behaving
differently depending if a third party misterious compononent that is not
documented anywhere is installed or not. If you have a dependency, well put
it in
1001 - 1100 of 4253 matches
Mail list logo
