Review Request 128057: Don't initialize KNS3::DownloadManager with the wrong categories

/downloadmanager.h 0441742 src/downloadmanager.cpp 9eca302 Diff: https://git.reviewboard.kde.org/r/128057/diff/ Testing --- Tested with Plasma's comic.knsrc file and Discover, which triggers this problem. Thanks, Aleix Pol Gonzalez ___ Kde

Re: Review Request 128057: Don't initialize KNS3::DownloadManager with the wrong categories

marked as submitted. Review request for KDE Frameworks and Jeremy Whiting. Changes --- Submitted with commit ed0a1be18ec5b421fc1319d2a28f118d9ea324b9 by Aleix Pol to branch master. Repository: knewstuff Description --- If we request some unexisting categories, we'll get basically

Re: Review Request 127997: Extend KNS3::Entry public API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127997/#review95833 --- bump? - Aleix Pol Gonzalez On May 24, 2016, 1:25 p.m

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

> On May 31, 2016, 1:38 a.m., Aleix Pol Gonzalez wrote: > > Would it be possible to get this as a KWidgetsAddons patch? It seems like > > it could easily be turned into a `KStyleSelectorMenu`. > > René J.V. Bertin wrote: > True, and the same would go for the "

Re: Review Request 128065: move glass theme to kde-look.

? - Aleix Pol Gonzalez On May 31, 2016, 10:33 a.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

> On May 31, 2016, 10:51 a.m., Milian Wolff wrote: > > -2 > > > > kdevelop should use the global widget style. if you don't want that, change > > it via systemsettings Well, it's not far-fetching to understand that on non-plasma systems this KCM will be hidden or unavailable. Linux's Skype

Review Request 128244: Use categorized debug for KCoreAddons

31c111a src/lib/util/kshell_unix.cpp 8355da3 src/lib/util/kuser_win.cpp 3cb0398 Diff: https://git.reviewboard.kde.org/r/128244/diff/ Testing --- Builds, now I can filter. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list

Re: Review Request 128244: Use categorized debug for KCoreAddons

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 4dfe8c1d090a286589a083ea4fe48f21a91ce0e9 by Aleix Pol to branch master. Repository: kcoreaddons Description --- as expected Diffs - CMakeLists.txt e9e8fe4 src/lib/CMakeLists.txt

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

tically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126672/ > --- > > (Updated Jan. 8, 2016, 2:34 a.m.) > > > Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. > > >

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

; > Q_FOREACH as replacement, the Q_ macros seem safer in the long run. > > Aleix Pol Gonzalez wrote: > It also detaches. > > http://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops/ > > Sebastian Kügler wrote: > but wouldn't with f

Re: Review Request 126696: kssld: install DBus service file for org.kde.kssld5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126696/#review90885 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 10, 2016

Re: Review Request 126712: Make kcookiejar accessible under the dbus service name org.kde.kcookiejar5.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126712/#review90883 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 10, 2016

Re: Review Request 126692: Provide a DBus service file for org.kde.kpasswdserver

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126692/#review90882 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 10, 2016

Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

> On Jan. 11, 2016, 4:17 p.m., Yichao Yu wrote: > > qt5/style/qtcurve_api.cpp, line 3211 > > > > > > Should this be turned on only when KF5 is enabled? KGlobalSettings is deprecated in KF5. I recommend

Re: Review Request 126740: Add a script for optimizing svgs

ts BUT it would be awesome for us to have this scripts before > > an distribution build there packages. In git keep it as simple as possible > > and when an distro will use the icons use therefore an script (check if the > > stylesheets fit, compress, make png files, ...

Re: Review Request 126746: Fix compilation with Qt5.6

g/r/126746/#comment62192> Can't this be -std=c++11 by now? - Aleix Pol Gonzalez On Jan. 14, 2016, 6:45 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.rev

Re: Review Request 126740: Add a script for optimizing svgs

obably the compression to svgz to be done at > > build time and have all simple svgs in the repository > > Aleix Pol Gonzalez wrote: > What do you mean with "because git"? Because we might have the exact same > problem with svgo then. > > Sebastian Kügle

Re: Review Request 126758: Drop support for building with Qt 4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126758/#review91152 --- +1 - Aleix Pol Gonzalez On Jan. 15, 2016, 4:33 p.m

Re: Review Request 126734: Fix Clazy warnings in KNotifications.

sn't helping and can be removed. - Aleix Pol Gonzalez On Jan. 14, 2016, 12:30 a.m., Andrey Cygankov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.

Re: Review Request 126734: Fix Clazy warnings in KNotifications.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126734/#review91038 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 14, 2016

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

> On Jan. 14, 2016, 1:07 a.m., Aleix Pol Gonzalez wrote: > > These look good. You wrote "most". Which warnings couldn't you fix? > > Andrey Cygankov wrote: > log file sent `/home/andrey/dev/projects/kitemmodels/autotests/proxymodeltestsuite/proxymodeltest.h:

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

s couldn't you fix? - Aleix Pol Gonzalez On Jan. 14, 2016, 1:05 a.m., Andrey Cygankov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 126736: Fix all Clazy warnings in KFileMetadata.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126736/#review91039 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 14, 2016

Re: Review Request 126734: Fix Clazy warnings in KNotifications.

> On Jan. 14, 2016, 12:30 a.m., Aleix Pol Gonzalez wrote: > > Only the foreach I don't understand, as for the rest, note that `NewStatus` > > first argument is `QString`. > > > > Use QString::fromLatin1(). > > Andrey Cygankov wrote: > What to put in kst

Review Request 126740: Add a script for optimizing svgs

-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/ 32M icons 32M icons-dark/ #run the script kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/ 17M icons 17M icons-dark/ ``` Thanks, Aleix Pol Gonzalez

Re: Review Request 126738: Remove external dependencies from svgs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126738/#review91043 --- +1 Good catch. - Aleix Pol Gonzalez On Jan. 14, 2016, 2:18

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126735/#review91073 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 14, 2016

Re: Review Request 126740: Add a script for optimizing svgs

an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/#review91055 ----------- On Jan. 14, 2016, 4 a.m., Aleix Pol Gonzalez wrote: > > --- > T

Re: Review Request 126740: Add a script for optimizing svgs

--- > > ``` > kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/ > 32M icons > 32M icons-dark/ > > #run the script > > kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/ > 17M icons > 17M

Re: Review Request 126740: Add a script for optimizing svgs

users whatever is easier to execute when we release. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/#review91064 -------

Re: Review Request 126740: Add a script for optimizing svgs

ts BUT it would be awesome for us to have this scripts before > > an distribution build there packages. In git keep it as simple as possible > > and when an distro will use the icons use therefore an script (check if the > > stylesheets fit, compress, make png files, ...

Re: Review Request 126740: Add a script for optimizing svgs

ts BUT it would be awesome for us to have this scripts before > > an distribution build there packages. In git keep it as simple as possible > > and when an distro will use the icons use therefore an script (check if the > > stylesheets fit, compress, make png files, ...

Re: Review Request 126737: Fix most Clazy warnings in KItemViews.

]` - Aleix Pol Gonzalez On Jan. 14, 2016, 10:49 a.m., Andrey Cygankov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

------- > > (Updated Jan. 14, 2016, 9:52 a.m.) > > > Review request for KDE Frameworks and Aleix Pol Gonzalez. > > > Repository: kitemmodels > > > Description > --- > > Fixed most Clazy warnings in KItemModels. > >

Re: Review Request 126740: Add a script for optimizing svgs

obably the compression to svgz to be done at > > build time and have all simple svgs in the repository > > Aleix Pol Gonzalez wrote: > What do you mean with "because git"? Because we might have the exact same > problem with svgo then. > > Sebastian Kügle

Re: Review Request 126798: Add multiple installation method per categorie

/engine.cpp (line 123) <https://git.reviewboard.kde.org/r/126798/#comment62401> Initialize with declaration src/core/engine.cpp (line 135) <https://git.reviewboard.kde.org/r/126798/#comment62402> Shouldn't this break? Otherwise some of the installations won't get connected.

Re: Review Request 126772: Fix some Clazy warnings in KService

/r/126772/#comment62242> Should be QLatin1String - Aleix Pol Gonzalez On Jan. 16, 2016, 10:06 p.m., Andrey Cygankov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revi

Re: Review Request 126740: Add a script for optimizing svgs

-dark/ #run the script kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/ 17M icons 17M icons-dark/ ``` Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 126770: Fix most Clazy warnings in KXmlGui.

) <https://git.reviewboard.kde.org/r/126770/#comment62205> recipient seems to already be a QString, no need to explicitly pass the constructor. - Aleix Pol Gonzalez On Jan. 16, 2016, 4:36 p.m., Andrey Cygankov

Re: Review Request 126737: Fix most Clazy warnings in KItemViews.

> On Jan. 14, 2016, 1:35 p.m., Aleix Pol Gonzalez wrote: > > Looks good, I'll add Sergio, he maybe can explain what the warning meant in > > the first place. > > > > Andrey, Are you sure you fixed all the warnings? I found some missing, for > > example

Re: Review Request 126737: Fix most Clazy warnings in KItemViews.

t; --- > > (Updated Jan. 14, 2016, 11:40 p.m.) > > > Review request for KDE Frameworks, Aleix Pol Gonzalez and Sergio Martins. > > > Repository: kitemviews > > > Description > --- > > Fix Claz

Re: Review Request 126746: Fix compilation with Qt5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126746/#review91112 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 14, 2016

Re: Review Request 128235: Specify supported platforms

is always possible. - Aleix Pol Gonzalez On June 18, 2016, 9:37 a.m., Andreas Cord-Landwehr wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128234: Name provided platforms

add more. - Aleix Pol Gonzalez On June 23, 2016, 9:08 p.m., Andreas Cord-Landwehr wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

A bunch of these can be marked as const. src/inhibition.cpp (line 94) <https://git.reviewboard.kde.org/r/126650/#comment62914> If this has to be cross-platform, dbus usage should be abstracted out. On Windows/OS X one won't find a dbus interface with this information. - Aleix Pol

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

tps://git.reviewboard.kde.org/r/127048/#comment62965> elseif? - Aleix Pol Gonzalez On Feb. 12, 2016, 4:47 p.m., Andreas Cord-Landwehr wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 127024: Don't filter names if we have mimetypes

the extra knowledge. Diffs (updated) - src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efb Diff: https://git.reviewboard.kde.org/r/127024/diff/ Testing --- Tested it while porting okular. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks

Review Request 127024: Don't filter names if we have mimetypes

://git.reviewboard.kde.org/r/127024/diff/ Testing --- Tested it while porting okular. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

tps://git.reviewboard.kde.org/r/127048/#comment62945> maybe it should be `#ifdef libintl-lite` no? - Aleix Pol Gonzalez On Feb. 11, 2016, 8:11 p.m., Andreas Cord-Landwehr wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 126926: Clean up dependencies for KDeclarative/QuickAddons

pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126772: Fix some Clazy warnings in KService

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126772/#review91880 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 16

Re: Review Request 126926: Clean up dependencies for KDeclarative/QuickAddons

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 950e5c2963ee5d1e41071d8ca5b9767cac796874 by Aleix Pol to branch master. Repository: kdeclarative Description --- They were copy-pasted from somewhere else. Also Qt5::Quick is part of the public

Review Request 126948: Simplify attica plugin look-up and initialization

system. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126769: Fix all Clazy warnings in KDED.

function David pointed is `qEnvironmentVariableIntValue`. - Aleix Pol Gonzalez On Jan. 16, 2016, 3:27 p.m., Andrey Cygankov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/#review91881 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 17

Re: Review Request 126770: Fix most Clazy warnings in KXmlGui.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126770/#review91882 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 16

Re: Review Request 126948: Simplify attica plugin look-up and initialization

/ Testing --- Test still passes, initializing attica still finds the right plugin on my system. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 126948: Simplify attica plugin look-up and initialization

--- Test still passes, initializing attica still finds the right plugin on my system. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126948: Simplify attica plugin look-up and initialization

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 58e6ed4f6a6c24737cc3ca1e5082c3fe976eda46 by Aleix Pol to branch master. Repository: attica Description --- Just use QPluginLoader instead of doing it locally (and with an awkward blocking

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

> This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126672/ > --- > > (Updated Jan. 17, 2016, 9:50 p.m.) > > > Review request for KDE Frameworks, Plasma and Aleix Pol

Re: Review Request 126926: Clean up dependencies for KDeclarative/QuickAddons

/CMakeLists.txt 8dc431f src/quickaddons/configmodule.cpp f739469 Diff: https://git.reviewboard.kde.org/r/126926/diff/ Testing --- Still builds, tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 126969: KRecursiveFilterProxyModel::match: Fix crash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126969/#review91959 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 2, 2016

Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

--- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126740: Add a script for optimizing svgs

marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 8a31ac8ac1056a9065d50845b71336fff74e317c by Aleix Pol to branch master. Repository: breeze-icons Description --- Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me

Re: Review Request 127141: KModelIndexProxyMapper: Simplify logic of connected check

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127141/#review92690 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 22

Re: Review Request 127143: Reset KSelectionProxyModel state when needed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127143/#review92689 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 22

Re: Review Request 127144: KSelectionProxyModel: Fix iteration bug

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127144/#review92688 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 22

Re: Review Request 127139: Add unit test for KModelIndexProxyMapper.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127139/#review92692 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 22

Re: Review Request 127140: KModelIndexProxyMapper: Add some asserts

tps://git.reviewboard.kde.org/r/127140/#comment63178> Get the condition inside the assert? `Q_ASSERT(seekSelection.isEmpty() || seekSelection.first().model() == proxy);` Same for the rest. - Aleix Pol Gonzalez On Feb. 22, 2016, 4:35 p.m., Stephen Kelly

Re: Review Request 127031: Add function to get runtime frameworks version information

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127031/#review92697 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 23

Re: Review Request 127117: Reverse the filtering logic

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127117/#review92698 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 23

Re: Review Request 127164: Add actionType to the declarative plugin

? `ActionTypeWrapper.TextChatAction` might be awkward. - Aleix Pol Gonzalez On Feb. 24, 2016, 12:29 a.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127146: KLinkItemSelectionModel: Handle changes to the selectionModel model

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127146/#review92687 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 22

Re: Review Request 127149: KLinkItemSelectionModel: Test the effect of separate object network

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127149/#review92686 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 22

Re: Review Request 127150: KLinkItemSelectionModel: Test clearing the selection

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127150/#review92685 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 22

Re: Review Request 127148: KLinkItemSelectionModel: Add new default constructor.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127148/#review92696 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 22

Re: Review Request 127147: KLinkItemSelectionModel: Make the linked selection model settable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127147/#review92695 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 22

Re: Review Request 127142: Add a property indicating whether the models form a connected chain.

tps://git.reviewboard.kde.org/r/127142/#comment63179> Maybe get some API documentation for isConnected? - Aleix Pol Gonzalez On Feb. 22, 2016, 5:33 p.m., Stephen Kelly wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 127164: Add actionType to the declarative plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127164/#review92704 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 24

Re: Review Request 127145: KLinkItemSelectionModel: Don't store model locally

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127145/#review92693 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 22

Re: Review Request 127145: KLinkItemSelectionModel: Don't store model locally

> On Feb. 24, 2016, 1:36 a.m., Aleix Pol Gonzalez wrote: > > Ship It! Eh.. wait, we still support Qt 5.3, will that be a problem? - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.

Re: Review Request 127163: Add actionType to the PersonActionsModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127163/#review92700 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 24

Re: Review Request 127159: Make the KPeople qml example slightly more usable

! - Aleix Pol Gonzalez On Feb. 23, 2016, 10:50 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

> On Feb. 24, 2016, 8:06 p.m., Stephen Kelly wrote: > > Hi Aleix, > > > > I'm not familiar with the 'tiny mess'. Can you say what it is? I would > > expect the libs go in the same place, but maybe the plugins are affected by > > this? Can you be more specific

Review Request 127209: Fix some issues found by Coverity

://git.reviewboard.kde.org/r/127209/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127211: Properly use static QMaps

/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126765: Fix some Clazy warnings in KTextEditor.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126765/#review92867 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 16

Review Request 127210: Fix warnings

: https://git.reviewboard.kde.org/r/127210/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

, 9:50 p.m.) > > > Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. > > > Repository: plasma-framework > > > Description > --- > > Fix almost all the Clazy warnings in plasma-framework. > > Related GCI-2015 task: > [https://

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

and commit it, since Sergey seems AFK. - Aleix Pol Gonzalez On Jan. 17, 2016, 9:50 p.m., Sergey Popov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Review Request 127214: Remove some warnings

/127214/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127209: Fix some issues found by Coverity

--- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127214: Remove some warnings

marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 06c7b9c050aa57d4d7ac8b3302ef7b09a6436b55 by Aleix Pol to branch master. Repository: plasma-framework Description --- * Unused variables * Unused code * Unused arguments

Re: Review Request 127215: simplify code, reduce pointer dereferences

tps://git.reviewboard.kde.org/r/127215/#comment63343> foreach like you did above? src/sycoca/ksycocadict.cpp (line 316) <https://git.reviewboard.kde.org/r/127215/#comment63344> Maybe it's better to leave the * there, as it makes it more clear that it's an output argument. - Aleix

Re: Review Request 127090: Clean KWalletQuery cmake file

marked as submitted. Review request for KDE Frameworks and Valentin Rusu. Changes --- Submitted with commit 94c5348663e7457a3741af2e5e355c6923c71140 by Aleix Pol to branch master. Repository: kwallet Description --- I saw it didn't build because I needed a build with KDocTools

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

-------- On Feb. 24, 2016, 6:09 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127169/ > -

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

> On Feb. 24, 2016, 8:06 p.m., Stephen Kelly wrote: > > Hi Aleix, > > > > I'm not familiar with the 'tiny mess'. Can you say what it is? I would > > expect the libs go in the same place, but maybe the plugins are affected by > > this? Can you be more specific

Re: Review Request 127209: Fix some issues found by Coverity

/kformatprivate.cpp 3d98007 Diff: https://git.reviewboard.kde.org/r/127209/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127209: Fix some issues found by Coverity

g q_ptr to nullptr for a brief instance doesn't help a lot either. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127209/#review92912 ---------

Re: Review Request 127210: Fix warnings

marked as submitted. Review request for KDE Frameworks and KDEPIM. Changes --- Submitted with commit 4b2c66f19a53c7fef765a1420d74c84f724f995c by Aleix Pol to branch master. Repository: kpeople Description --- * Fixes Coverity issue that notifies that the factory might be null

<    12   13   14   15   16   17   18   19   20   21   >