> On April 28, 2016, 3:52 p.m., Aleix Pol Gonzalez wrote:
> > src/kiconloader.cpp, line 870
> > <https://git.reviewboard.kde.org/r/127779/diff/5/?file=461490#file461490line870>
> >
> > I'd only use QBuffer in the case of svg.
>
> Marco Martin wrote
> On April 28, 2016, 3:52 p.m., Aleix Pol Gonzalez wrote:
> > src/kiconloader.cpp, line 825
> > <https://git.reviewboard.kde.org/r/127779/diff/5/?file=461490#file461490line825>
> >
> > maybe return contents?
>
> Marco Martin wrote:
> contents of
ne 825)
<https://git.reviewboard.kde.org/r/127779/#comment64470>
maybe return contents?
src/kiconloader.cpp (line 870)
<https://git.reviewboard.kde.org/r/127779/#comment64471>
I'd only use QBuffer in the case of svg.
- Aleix Pol Gonzalez
On April 28, 2016, 2:59 p.m.,
> On April 28, 2016, 3:52 p.m., Aleix Pol Gonzalez wrote:
> > src/kiconloader.cpp, line 870
> > <https://git.reviewboard.kde.org/r/127779/diff/5/?file=461490#file461490line870>
> >
> > I'd only use QBuffer in the case of svg.
>
> Marco Martin wrote
> On April 28, 2016, 3:52 p.m., Aleix Pol Gonzalez wrote:
> > I like the idea, but I think it needs polishing still.
> >
> > Some kind of assessment about the performance impact would be very
> > appreciated.
Also could we get a test? It's an important feature..
viewboard.kde.org/r/127763/#review94948
---
On April 27, 2016, 3:10 p.m., Aleix Pol Gonzalez wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127763/
> ---
://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/3f9b64d7-58e0-454b-9774-6ec86aa7f0c3__heaptrack.dolphin.16572-after.gz
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
: knewstuff
Description
---
A local variable was shadowing the actual variable declaration.
Diffs
-
src/core/engine.cpp c8d0579
Diff: https://git.reviewboard.kde.org/r/127788/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde
marked as submitted.
Review request for KDE Frameworks and Jos van den Oever.
Changes
---
Submitted with commit 932420b824e1c8e4a32960d24fdccf9a041014b5 by Aleix Pol to
branch master.
Repository: kservice
Description
---
This way we make sure the correct kbuildsycoca is tested
: https://git.reviewboard.kde.org/r/127765/diff/
Testing
---
Tests pass, KConfig becomes 6% of dolphin at load.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127774/#review94925
---
+1
- Aleix Pol Gonzalez
On April 27, 2016, 11:53 p.m
the other hand, I completely agree that fixing those abuses is important and
should be done.
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127765/#review94923
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127778/#review94934
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On April 28
y5kqvppv`
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127632/#review94875
---
On April 26, 2016, 10:51 p.m., Aleix
mp; grep ENOENT | wc -l
2119
```
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
: kservice
Description
---
This way we make sure the correct kbuildsycoca is tested.
Diffs
-
autotests/CMakeLists.txt 52e7298
autotests/ksycoca_xdgdirstest.cpp 1aa7140
Diff: https://git.reviewboard.kde.org/r/127757/diff/
Testing
---
Tests still pass here.
Thanks,
Aleix Pol
/127757/
- Aleix Pol Gonzalez
On April 27, 2016, 10:33 a.m., Jos van den Oever wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127756/#review94901
---
+1
- Aleix Pol Gonzalez
On April 27, 2016, 1:16 p.m
pass, apps still work.
Starting and closing dolphin under callgrind showed 1640M instructions, now
1466M(10% improvement).
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127759/#review94904
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On April 27
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127743/#review94837
---
+1
- Aleix Pol Gonzalez
On April 25, 2016, 11:02 a.m
dy being generated at some point, it just was being
discarded).
Diffs
-
src/kicontheme.cpp 0996054
Diff: https://git.reviewboard.kde.org/r/127236/diff/
Testing
---
Builds, tests still pass, applications start noticeably faster.
Thanks,
Aleix Pol
marked as submitted.
Review request for KDE Frameworks and Jeremy Whiting.
Changes
---
Submitted with commit a061fd2abdbe2f03a6b61b2ae871f673b5cade51 by Aleix Pol to
branch master.
Repository: knewstuff
Description
---
A local variable was shadowing the actual variable declaration
marked as submitted.
Review request for KDE Frameworks and Christoph Feck.
Changes
---
Submitted with commit 41ce57dce2830861aea6f9d11dd607e4b851b987 by Aleix Pol to
branch master.
Repository: kiconthemes
Description
---
Leverages the implicitly shared nature of QString by only
ller memory impact, since
we're not caching all the icon names (which was specially bad as it was
per-process).
```
$ strace kwrite |& grep ENOENT | wc -l
4699
$ strace kwrite |& grep ENOENT | wc -l
2119
```
Thanks,
Aleix Pol Gonzalez
___
Kd
that by this metric, it's
almost as good as the RR #127236, but with a much smaller memory impact, since
we're not caching all the icon names (which was specially bad as it was
per-process).
```
$ strace kwrite |& grep ENOENT | wc -l
4699
$ strace kwrite |& grep ENOENT | wc -l
2119
```
Thanks
changed?
- Aleix Pol Gonzalez
On May 20, 2016, 12:19 a.m., Pino Toscano wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127976/#review95650
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On May 20, 2016
marked as submitted.
Review request for KDE Frameworks and Jeremy Whiting.
Changes
---
Submitted with commit c685fb5098e4e37bf3aae933a0ae09e0f798ffc5 by Aleix Pol to
branch master.
Repository: knewstuff
Description
---
Mostly clazy fixes, few cleanups
Diffs
-
src/core
/entryinternal.cpp b05fe24
src/core/entryinternal_p.h 20f9b1b
src/entry.h 6603e97
src/entry.cpp 09f9542
Diff: https://git.reviewboard.kde.org/r/127997/diff/
Testing
---
Discover works as it used to, with many changes I have locally.
Thanks,
Aleix Pol Gonzalez
.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
the flag does, but I think it should go in
if it fixes the look in mac and doesn't break others.
- Aleix Pol Gonzalez
On May 24, 2016, 6:39 p.m., René J.V. Bertin wrote:
>
> ---
> This is an automatically generated e-mail. To rep
view95188
---
On May 3, 2016, 1:09 a.m., Aleix Pol Gonzalez wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewb
://git.reviewboard.kde.org/r/127887/diff/
Testing
---
Builds, tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127899/#review95423
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On May 12, 2016
/corona.cpp 1784516
Diff: https://git.reviewboard.kde.org/r/127850/diff/
Testing
---
Tests pass.
PlasmaShell prints completed once both with and without configuration.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127813/#review95393
---
ping?
- Aleix Pol Gonzalez
On May 5, 2016, 3:02 a.m
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit ad1ead84ee2c3a14363afdb048b3579f3d01fa18 by Aleix Pol to
branch master.
Repository: kiconthemes
Description
---
We were using oxygen as the default theme, this meant that oxygen was processed
hould inherit Oxygen? Or just be extended to have such
icons. KIconThemes it's the wrong place to enforce these.
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127817/#revi
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127900/#review95463
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On May 13, 2016
tps://git.reviewboard.kde.org/r/127923/#comment64726>
.arg(escaped, path).arg...
- Aleix Pol Gonzalez
On May 15, 2016, 5:55 a.m., Martin Klapetek wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
tps://git.reviewboard.kde.org/r/127911/#comment64725>
Trailing spaces!
- Aleix Pol Gonzalez
On May 14, 2016, 10:27 a.m., Gleb Popov wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127887/#review95561
-------
On May 12, 2016, 1:01 a.m., Aleix Pol Gonzalez wrote:
>
> ---
ed code.
src/atticabasejob.cpp (line 65)
<https://git.reviewboard.kde.org/r/127900/#comment64710>
`} else {`
- Aleix Pol Gonzalez
On May 12, 2016, 7:17 p.m., Andreas Cord-Landwehr wrote:
>
> ---
> This is an automatically gen
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127895/#review95386
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On May 11, 2016
/corona.cpp 1784516
Diff: https://git.reviewboard.kde.org/r/127850/diff/
Testing
---
Tests pass.
PlasmaShell prints completed once both with and without configuration.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks
tLayout()`.
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127850/#review95241
---
On May 6, 2016, 5:56 p.m., Ale
, apps work.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
ard.kde.org/r/127813/#review95112
---
On May 2, 2016, 6:32 p.m., Aleix Pol Gonzalez wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
an improvement on callgrind 1556M/1185M instructions (30% improvement).
KIconLoader allocations correspond to 3.8% instead of 4.8%, going down by:
535K/509K
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127833/#review95195
---
+1
- Aleix Pol Gonzalez
On May 5, 2016, 1:03 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127836/#review95196
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On May 5, 2016
tps://git.reviewboard.kde.org/r/127829/#comment64584>
maybe `soundFilename.contains(':')` would do the trick?
This seems to be making it even more complex...
- Aleix Pol Gonzalez
On May 4, 2016, 3:26 p.m., Harald Sitter
/kconfiggroup.cpp 39d2441
Diff: https://git.reviewboard.kde.org/r/127813/diff/
Testing
---
Tests pass, apps work.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
tps://git.reviewboard.kde.org/r/126495/#comment64607>
Maybe it should be installed in `libexec`?
- Aleix Pol Gonzalez
On May 5, 2016, 9:55 p.m., Ralf Habacker wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
src/ui/itemsviewdelegate.cpp 7001be2
tests/kmoretools/kmoretoolstest_interactive.cpp b1cbdea
Diff: https://git.reviewboard.kde.org/r/127887/diff/
Testing
---
Builds, tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing
> On May 6, 2016, 6:08 p.m., David Rosca wrote:
> > It will also need
> > https://quickgit.kde.org/?p=plasma-workspace.git=commit=1b6231f2e3f1de8cb5ea2540f0b8f425f6ae43a3
> > in Plasma/5.6
>
> Aleix Pol Gonzalez wrote:
> No, it's already called by `
sets an URL, he'll
get an URL.
- Aleix Pol Gonzalez
On April 17, 2016, 1:09 p.m., Nick Shaforostoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
that it still works on github.
https://github.com/KDE/baloo/blob/master/docs/development/build-instructions.md
- Aleix Pol Gonzalez
On May 24, 2016, 10:27 p.m., Olivier Churlaud wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128514/#review97841
---
Ship it!
LGTM, nice catch!
- Aleix Pol Gonzalez
---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128514/
> -------
>
> (Updated July 24, 2016, 2:27 p.m.)
>
>
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Christoph Fe
er than within this patch, it's only used by KDEInstallDirs, which is
Qt5-only.
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128488/#review97710
----------
://git.reviewboard.kde.org/r/128488/diff/
Testing
---
Should fix this issue:
https://build.kde.org/job/extra-cmake-modules%20master%20latest-qt4/16/PLATFORM=Linux,compiler=gcc/console
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde
marked as submitted.
Review request for KDE Frameworks and Matthew Dawson.
Changes
---
Submitted with commit 6c4e504d76b2424ac06c50394a0cca63860e65b5 by Aleix Pol to
branch master.
Repository: kconfig
Description
---
Don't drop the file: prefix twice in every run.
Use appropriate
/KDECMakeSettings.cmake dd37e7f
kde-modules/appstreamtest.cmake PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/128533/diff/
Testing
---
Tested on some projects, locally.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128555/#review97913
---
+1
- Aleix Pol Gonzalez
On July 29, 2016, 8:44 p.m
marked as submitted.
Review request for Extra Cmake Modules, KDE Frameworks and David Faure.
Changes
---
Submitted with commit 8ac7abb78d97210c5cbbc87fba83d58d7b843a8d by Aleix Pol to
branch master.
Repository: extra-cmake-modules
Description
---
Addresses its usage on systems
r128579), we get quite
some metadata.
`appstreamcli validate` doesn't choke on output files.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128587/#review98029
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Aug. 3, 2016
> On Aug. 3, 2016, 3:28 a.m., Aleix Pol Gonzalez wrote:
> > Why?
>
> Alexander Potashev wrote:
> To make Kross easier to build for exotic (= non-Linux) platforms. (We
> have no actual users for these options yet.)
My experience says this tends to complicate the us
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128582/#review98024
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Aug. 3, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128584/#review98026
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Aug. 3, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128583/#review98025
---
Why?
- Aleix Pol Gonzalez
On Aug. 3, 2016, 1:36 a.m
/
Testing
---
Everything still installs in the same place, apparently.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit fd516c52eea7f2c58c24c4944e68a3d718232eac by Aleix Pol on
behalf of Aleix Pol Gonzalez to branch master.
Repository: kpackage
Description
---
I was trying to query a metadata.json
validate` doesn't choke on output files.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit 333bdd7fb38e8ccd4f079f760bbb86e711b2b2b1 by Aleix Pol to
branch master.
Repository: plasma-framework
Description
---
Plasma packages are essentially kpackages, so use the macros
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128640/#review98254
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Aug. 10
`git diff --find-copies-harder` so
moves are actual moves rather than destruction + creation.
- Aleix Pol Gonzalez
On Aug. 9, 2016, 9:14 p.m., Burkhard Lück wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128642/#review98255
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Aug. 10
.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit ad30347a4717a03de82fdd78a85b7641a01c9ef8 by Aleix Pol to
branch master.
Repository: kpackage
Description
---
* Make sure we don't just append to the regenerateindex.sh file
: https://git.reviewboard.kde.org/r/128533/diff/
Testing
---
Tested on some projects, locally.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
to work.
Tests pass.
A bunch of appdata files are installed from kdeplasma-addons.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128678/#review98389
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Aug. 15
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128232/#review97364
---
+1
- Aleix Pol Gonzalez
On July 14, 2016, 12:22 a.m
marked as submitted.
Review request for Extra Cmake Modules, KDE Frameworks and Antonio Rojas.
Changes
---
Submitted with commit 5bb92992317a6cf878c823cadac6dd0ccff969d6 by Aleix Pol to
branch master.
Repository: extra-cmake-modules
Description
---
In `KDEInstallDirs` we have some
---
Should fix this issue:
https://build.kde.org/job/extra-cmake-modules%20master%20latest-qt4/16/PLATFORM=Linux,compiler=gcc/console
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
/declarativeimports/core/fadingnode.cpp (line 67)
<https://git.reviewboard.kde.org/r/128426/#comment65692>
use `switch`?
- Aleix Pol Gonzalez
On July 12, 2016, 1:34 a.m., David Edmundson wrote:
>
> ---
> This is a
files are installed using the same reasoning.
Diffs
-
modules/ECMGeneratePriFile.cmake af4b877
Diff: https://git.reviewboard.kde.org/r/128427/diff/
Testing
---
The issue was reported by `arojas`, I haven't been able to reproduce myself.
Thanks,
Aleix Pol Gonzalez
/
Testing
---
Tests pass, apps work.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
on paths rather than string handling, when possible.
Diffs (updated)
-
src/core/kconfiggroup.cpp 39d2441
Diff: https://git.reviewboard.kde.org/r/127813/diff/
Testing
---
Tests pass, apps work.
Thanks,
Aleix Pol Gonzalez
___
Kde
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128357/#review97081
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On July 4, 2016
discarded.
Review request for KDE Frameworks.
Repository: kdelibs4support
Description
---
Like in many other frameworks.
Diffs
-
CMakeLists.txt 15ecead
Diff: https://git.reviewboard.kde.org/r/127110/diff/
Testing
---
Builds with and without KDocTools.
Thanks,
Aleix Pol
://git.reviewboard.kde.org/r/127813/diff/
Testing
---
Tests pass, apps work.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/
Testing
---
Tests pass for good now.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit 142b793138b050e15ca39b82a8149d6a180fa68b by Aleix Pol to
branch master.
Repository: kpackage
Description
---
Properly concatenate paths.
Make sure cleanupPackage doesn't expand
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit c0d2159bc1153974cb9b7854e3f182d3bcd92d0c by Aleix Pol to
branch master.
Repository: kpackage
Description
---
In general, KPackage plugins should work anywhere the
KPackage
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit de1a45764a777ccaf092d241324790268b0e9d9e by Aleix Pol to
branch master.
Repository: plasma-framework
Description
---
It specifies org.kde.plasmashell as the structures' target
1801 - 1900 of 4253 matches
Mail list logo
