---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129382/#review100795
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Nov. 11
tps://git.reviewboard.kde.org/r/129381/#comment67651>
I'm guessing that this was trying to make sure mMyBool is changed upon
`s->read()`?
- Aleix Pol Gonzalez
On Nov. 11, 2016, 11:14 p.m., Allen Winter wrote:
>
> ---
> This is an
reads weird.
- Aleix Pol Gonzalez
On Nov. 13, 2016, 12:33 p.m., Elvis Angelaccio wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
tps://git.reviewboard.kde.org/r/129400/#comment67671>
Then just change to `QStandardPath::locate`?
- Aleix Pol Gonzalez
On Nov. 14, 2016, 2:35 p.m., David Edmundson wrote:
>
> ---
> This is an automatically generated e-mail.
s will create a new QAction instance.
*/
```
- Aleix Pol Gonzalez
On Nov. 13, 2016, 12:33 p.m., Elvis Angelaccio wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboar
tps://git.reviewboard.kde.org/r/129389/#comment67688>
How about this:
`Add URL to recent files list. This will enable this action.`
- Aleix Pol Gonzalez
On Nov. 13, 2016, 12:33 p.m., Elvis Angelaccio wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129418/#review100889
---
Ship it!
LGTM
- Aleix Pol Gonzalez
On Nov. 16, 2016
> On Oct. 31, 2016, 6:19 p.m., Marco Martin wrote:
> > src/kpackage/private/packagejobthread.cpp, line 436
> > <https://git.reviewboard.kde.org/r/129298/diff/1/?file=483567#file483567line436>
> >
> > would this need a local database of installed packages/depe
-handlers/appstream/main.cpp PRE-CREATION
src/kpackage-install-handlers/kns/CMakeLists.txt PRE-CREATION
src/kpackage-install-handlers/kns/main.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/129419/diff/
Testing
---
It worked with the test package.
Thanks,
Aleix Pol Gonzalez
ejobthread.cpp 0a0cc01
src/kpackage/private/packagejobthread_p.h 1babf0b
Diff: https://git.reviewboard.kde.org/r/129298/diff/
Testing
---
None. just builds. It's a proof of concept, not even the test I added was
tested, it was just to display what it could look like.
Thanks,
Aleix Pol Gonzalez
atically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129298/#review100913
-----------
On Nov. 17, 2016, 5 p.m., Aleix Pol Gonzalez wrote:
>
> ---
> This is a
ing on the server which can be used to check the item of id
> > 1159726 that has been downloaded is actually the needed color scheme or is
> > just description?)
>
> Aleix Pol Gonzalez wrote:
> This is a review for the other patch... ;)
>
> To see what inf
iff/
Testing (updated)
---
Can install packages with RR 129419
Thanks,
Aleix Pol Gonzalez
marked as submitted.
Review request for KDE Frameworks, Plasma, Dan Leinir Turthra Jensen, and Marco
Martin.
Changes
---
Submitted with commit 43bafd69694ba829243cdbf6c9f72a5943ada23b by Aleix Pol to
branch master.
Repository: kpackage
Description
---
Makes it possible to specify
?
- Aleix Pol Gonzalez
On Nov. 17, 2016, 5 p.m., Aleix Pol Gonzalez wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
tps://git.reviewboard.kde.org/r/129520/#comment67742>
I'm not convinced we want to install this.
Maybe we can find a way for the tests to find it in the build directory?
I really like the patch though! :)
- Aleix Pol Gonzalez
On Nov. 21, 2016, 3:28 p.m., Bhushan
> On Nov. 20, 2016, 11:39 a.m., Aleix Pol Gonzalez wrote:
> > WRT 129298, should I re-submit only with PK backend?
>
> Marco Martin wrote:
> why?
Because the conversation ended with some doubts on how unique the ids are.
I'll submit a new one with just KNS and l
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit a540c1d2f0342abf0f9bc3546988b61398155f08 by Aleix Pol to
branch master.
Repository: frameworkintegration
Description
---
Installs binaries that will perform the installation
Diffs
/main.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/129554/diff/
Testing
---
Works, ids are not entirely unique just yet (just within the provider)
Thanks,
Aleix Pol Gonzalez
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128574/#review101146
---
+1
- Aleix Pol Gonzalez
On Aug. 2, 2016, 12:08 p.m
7;t landed yet...
- Aleix Pol Gonzalez
On Dec. 2, 2016, 1:09 a.m., Sebastian Kügler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.review
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129623/#review101371
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Dec. 7
297
Diff: https://git.reviewboard.kde.org/r/129643/diff/
Testing
---
Tests still pass, plasma-workspace applets are generated with correct types.
Thanks,
Aleix Pol Gonzalez
eviewboard.kde.org/r/129643/#review101406
---
On Dec. 12, 2016, 4:26 p.m., Aleix Pol Gonzalez wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
98d
src/lib/plugin/desktopfileparser_p.h c61b297
Diff: https://git.reviewboard.kde.org/r/129643/diff/
Testing
---
Tests still pass, plasma-workspace applets are generated with correct types.
Thanks,
Aleix Pol Gonzalez
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit d5652726b30c14033cddd757242db703576b1e95 by Aleix Pol on
behalf of Aleix Pol Gonzalez to branch master.
Repository: frameworkintegration
Description
---
Installs the handlers that should be
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 49bc26a135bf92bcddecabfdd4f3f71f65540104 by Aleix Pol to
branch master.
Repository: kcoreaddons
Description
---
In case there's a ServiceType field in the desktop file, look them u
676)
<https://git.reviewboard.kde.org/r/129653/#comment67924>
There's `@param` but the argument doesn't have a name.
- Aleix Pol Gonzalez
On Dec. 15, 2016, 2:52 a.m., David Edmundson wrote:
>
> ---
> This is an
f -o -type
l ) -print ) >> $filelist
extradesktopscripts=`find $dir -name ExtraDesktop.sh`
initialdir=`pwd`
for extradesktopscript in $extradesktopscripts; do
```
Diffs
-
src/downloaddialog.cpp 5831211
Diff: https://git.reviewboard.kde.org/r/129654/diff/
Testing
---
The `Name` field is used when available, also adopted it in Discover.
Thanks,
Aleix Pol Gonzalez
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129657/#review101460
---
+1 looks good.
- Aleix Pol Gonzalez
On Dec. 16, 2016, 12
?
- Aleix Pol Gonzalez
On Dec. 16, 2016, 4:05 p.m., Elvis Angelaccio wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
ull path (tested from Discover).
Thanks,
Aleix Pol Gonzalez
.
- Aleix Pol Gonzalez
On Dec. 15, 2016, 5:05 p.m., Aleix Pol Gonzalez wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
still pass, doesn't choke anymore on a full path (tested from Discover).
Kate, KDevelop still work (listing of installed resources etc)
Thanks,
Aleix Pol Gonzalez
> On Dec. 16, 2016, 5:55 p.m., Aleix Pol Gonzalez wrote:
> > Waiting for feedback from tsdgeos on the change in scripty.
>
> Albert Astals Cid wrote:
> Looks good (make sure you commit to the correct location (i.e. i guess we
> want this for stable and trunk kf5, not
marked as submitted.
Review request for KDE Frameworks and Jeremy Whiting.
Changes
---
Submitted with commit a6549d048b97d29d740044ec868522fb95393e20 by Aleix Pol to
branch master.
Repository: knewstuff
Description
---
Discover has been changed to display all installed `knsrc
---
It's essentially the only methods required to start using it from QML.
Diffs
-
src/kconcatenaterowsproxymodel.h 53db900
Diff: https://git.reviewboard.kde.org/r/129678/diff/
Testing
---
Used it locally in Discover, changes pending to submit. :)
Thanks,
Alei
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 818ae4cf720eeb5f3ac3758afba0b0d2bb5fd022 by Aleix Pol to
branch master.
Repository: kitemmodels
Description
---
It's essentially the only methods required to start using it from QML.
marked as submitted.
Review request for KDE Frameworks and Jeremy Whiting.
Changes
---
Submitted with commit 1da38bb7dc33bc8df1cdd23e355d8b95f096c448 by Aleix Pol to
branch master.
Repository: knewstuff
Description
---
`QStrandardPaths::locate` returns `{}` when an absolute path is
Description
---
Instead of using `contains(key);value(key)`, prefer `it=constFind(key)` and
`*it`.
Diffs
-
src/kpackage/package.cpp 45a8676
Diff: https://git.reviewboard.kde.org/r/129698/diff/
Testing
---
Tests still pass (except for the two that need fixing.
Thanks,
Aleix
for the unrelated two that need fixing from before
submitting the patch.
Thanks,
Aleix Pol Gonzalez
iff: https://git.reviewboard.kde.org/r/129699/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
---
All tests pass now.
Thanks,
Aleix Pol Gonzalez
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit 63c5a76127d3cdf45558af88a995b3aaf42bbb37 by Aleix Pol to
branch master.
Repository: kpackage
Description
---
Instead of using `contains(key);value(key)`, prefer `it=constFind(key
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit 4d6bba978bbf6fa0f6ee35c7d0fabe04dec9eee6 by Aleix Pol to
branch master.
Repository: kpackage
Description
---
Since newer Qt, QtQml sometimes generates `*.qmlc` files by the original
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit 06fda1a594bbb57fdb669467f94044c8ed4b8bbd by Aleix Pol to
branch master.
Repository: kpackage
Description
---
Fixes tests.
Removes warnings when using kpackagetool5 on `KPackage
fs
-
src/plasmapkg/CMakeLists.txt 7d3df5d22
src/plasmapkg/main.cpp dfbd2f4c3
src/plasmapkg/plasmapkg.h 3383980db
src/plasmapkg/plasmapkg.cpp 3724ae85e
Diff: https://git.reviewboard.kde.org/r/129704/diff/
Testing
---
`plasmapkg2 --help` returns `kpackagetool5`'s.
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit dc4474125ca85003ade1550517f602cde1b70ab8 by Aleix Pol to
branch master.
Repository: plasma-framework
Description
---
They're supposed to do the same, completely different code
tps://git.reviewboard.kde.org/r/129658/#comment68040>
Please keep the ones that stayed in KDELibs4Support...
- Aleix Pol Gonzalez
On Dec. 16, 2016, 4:05 p.m., Elvis Angelaccio wrote:
>
> ---
> This is an automatically generated e-mail.
---
Thanks,
Aleix Pol Gonzalez
https://git.reviewboard.kde.org/r/129715/diff/
Testing
---
Manually tested
Thanks,
Aleix Pol Gonzalez
ckage/private/packagejobthread.cpp 8697341
Diff: https://git.reviewboard.kde.org/r/129716/diff/
Testing
---
Managed to install llukas's example.
Thanks,
Aleix Pol Gonzalez
d
Thanks,
Aleix Pol Gonzalez
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit e6d72cb9df6f55b3f463a5acfcad6a7bafe4bd81 by Aleix Pol to
branch master.
Repository: kpackage
Description
---
When parsing the desktop files, pass together the kpackage
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 53af6f9e0ecc646df4d11582bd45a22a90dbd39f by Aleix Pol to
branch master.
Repository: frameworkintegration
Description
---
* add a positive and negative test
* makes sure exiting event loops
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129733/#review101688
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Dec. 31
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129734/#review101689
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Dec. 31
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129744/#review101723
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Jan. 2
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129745/#review101724
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Jan. 2
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129747/#review101726
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Jan. 2
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129746/#review101725
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Jan. 2
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129748/#review101727
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Jan. 2
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129750/#review101729
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Jan. 2
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129751/#review101730
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Jan. 2
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129770/#review101824
---
Ship it!
Looks good, thanks!
- Aleix Pol Gonzalez
On
apol created this revision.
apol added reviewers: Plasma, Frameworks, mart.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This happens when calling from kpackagetool5 --list
REPOSITORY
R290 KPackage
BRANCH
apol updated this revision to Diff 9917.
apol added a comment.
Make sure we list the plugins in the correct directory if we don't have a
reason not to
REPOSITORY
R290 KPackage
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4042?vs=9907&id=9917
BRANCH
master
REVISION DETAIL
apol created this revision.
apol added reviewers: Frameworks, leinir, mart.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Otherwise it would get stuck.
If the question is not supported it will give an invalid response.
REPOSITORY
R252 Framework Integration
BRANCH
m
apol added a comment.
Can you add a test for the case?
REPOSITORY
R290 KPackage
REVISION DETAIL
https://phabricator.kde.org/D4043
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: apol, plasma-devel, #frameworks, lesliezhai, ali-moham
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.
REPOSITORY
R290 KPackage
BRANCH
phab/subdir
REVISION DETAIL
https://phabricator.kde.org/D4043
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ma
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:f311434c5d9f: Fix listing when the requested path is
absolute (authored by apol).
REPOSITORY
R290 KPackage
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4042?vs=9917&id=9941
REVISION DET
apol updated this revision to Diff 77551.
apol added a comment.
cleanup
REPOSITORY
R285 KCrash
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27986?vs=77522&id=77551
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27986
AFFECTED FILES
src/kcrash.cpp
src/kcras
apol updated this revision to Diff 77552.
apol added a comment.
nullptr
REPOSITORY
R285 KCrash
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27986?vs=77551&id=77552
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27986
AFFECTED FILES
src/kcrash.cpp
src/kcras
apol added inline comments.
INLINE COMMENTS
> kcoredirlister.cpp:1045
> +
> +QList dirs({dir});
> +dirs.append(urlList);
Is this to force dir at the end?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D27947
To: ahmadsamir, #frameworks, dfaure, meven
Cc: apol, kde
This revision was automatically updated to reflect the committed changes.
Closed by commit R285:6177c81d04a7: Allow providing an error message from the
application (authored by apol).
REPOSITORY
R285 KCrash
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27986?vs=77552&id=77675
REVIS
This revision was automatically updated to reflect the committed changes.
Closed by commit R871:39ed9cf6449e: Include s_kcrashErrorMessage in our traces
(authored by apol).
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27985?vs=77452&id=77676
REVISION DETAIL
apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.
REVISION SUMMARY
No need to translate a test app that is not even being installed.
Make it a QGuiApplication so less s
apol updated this revision to Diff 77678.
apol added a comment.
polish
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28061?vs=77677&id=77678
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28061
AFFECTED FILES
src/tests/crashtest/CMakeL
This revision was automatically updated to reflect the committed changes.
Closed by commit R871:aa2ea5059e02: Reduce unneeded dependencies (authored by
apol).
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28061?vs=77678&id=77732
REVISION DETAIL
https://pha
apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D
apol updated this revision to Diff 77839.
apol added a comment.
Address comment by David
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26858?vs=75564&id=77839
BRANCH
arcpatch-D26858
REVISION DETAIL
https://phabricator.kde.org/D26858
AFFECTED FILES
apol updated this revision to Diff 77861.
apol added a comment.
Fix tablet removal
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26858?vs=77839&id=77861
BRANCH
arcpatch-D26858
REVISION DETAIL
https://phabricator.kde.org/D26858
AFFECTED FILES
CMak
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R266 Breeze Icons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28108
To: heikobecker, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R285 KCrash
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28123
To: sitter, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
apol updated this revision to Diff 77926.
apol added a comment.
Only delete when all the subscribed resources are gone.
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26858?vs=77861&id=77926
BRANCH
arcpatch-D26858
REVISION DETAIL
https://phabricator.
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R236 KWidgetsAddons
BRANCH
l-qset-deprecated-methods (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D28124
To: ahmadsamir, #frameworks, apol, cfeck
Cc: kde-frameworks-devel, LeGast
apol created this revision.
apol added reviewers: Frameworks, broulik, sitter.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.
REVISION SUMMARY
This way if we're linking against an old KF5, we still generate a backtrace
REPOSITORY
apol planned changes to this revision.
apol added a comment.
Just tested it properly, it fails to generate a backtrace altogether :(
REPOSITORY
R871 DrKonqi
REVISION DETAIL
https://phabricator.kde.org/D28129
To: apol, #frameworks, broulik, sitter
Cc: plasma-devel, Orage, LeGast00n, The-F
apol updated this revision to Diff 78027.
apol added a comment.
Fix the refcounting
Expose teh set_cursor interface as well
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26858?vs=77926&id=78027
BRANCH
arcpatch-D26858
REVISION DETAIL
https://phabri
apol updated this revision to Diff 78028.
apol added a comment.
rebase
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26858?vs=78027&id=78028
BRANCH
arcpatch-D26858
REVISION DETAIL
https://phabricator.kde.org/D26858
AFFECTED FILES
CMakeLists.txt
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:a009c8c0d91a: Provide an implementation for the tablet
interface (authored by apol).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26858?vs=78028&id=78055
REVISI
apol updated this revision to Diff 78117.
apol added a comment.
This revision is now accepted and ready to land.
Fix it in a theoretically better but more convoluted way
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28129?vs=77929&id=78117
BRANCH
master
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3f69e6401e44: Assign an icon to action submenus (authored
by apol).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27950?vs=77295&id=78164
REVISION DETAIL
https://ph
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
I confirm that the test gets fixed.
Also the change makes sense.
It seems to me that both else branches end the same. From `list = ...` it can
be moved out, no?
REPOSITORY
R241 KIO
BR
apol added a comment.
LGTM +1
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D21902
To: dvratil, mart, #frameworks, #plasma
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,
bruns
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Makes sense. It's weird that this needs doing through QStandardPaths but it's
not something we can address here.
REPOSITORY
R243 KArchive
BRANCH
master
REVISION DETAIL
https://phabricat
apol created this revision.
apol added a reviewer: vkrause.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
apol requested review of this revision.
REVISION SUMMARY
Just a QPlainTextEdit and a highlighter.
TEST PLAN
Used it to figure out
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R271 KDBusAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28241
To: jgrulich, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
apol added inline comments.
INLINE COMMENTS
> waqar wrote in guesslanguage.cpp:586
> `identify()` fails if a certain language is not present in the trigrams.
Why did you handle it here rather than in identify then? is it a problem doing
it there? I see that identify is being used elsewhere too.
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Whatever, let's go with this and we can learn along the way.
Sorry it took so long.
REPOSITORY
R246 Sonnet
BRANCH
fix-176537 (branched from master)
REVISION DETAIL
https://phabricat
2201 - 2300 of 4453 matches
Mail list logo
