D29872: Provide methods to register SecretAgent to NetworkManager with capabilities, specifically with NM_SECRET_AGENT_CAPABILITY_VPN_HINTS

apol abandoned this revision. apol added a comment. https://invent.kde.org/frameworks/networkmanager-qt/-/merge_requests/2 REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D29872 To: apol, jgrulich, enriquem Cc: ngraham, apol, kde-frameworks-devel, LeGast00n,

D29872: Provide methods to register SecretAgent to NetworkManager with capabilities, specifically with NM_SECRET_AGENT_CAPABILITY_VPN_HINTS

apol commandeered this revision. apol added a reviewer: enriquem. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D29872 To: apol, jgrulich, enriquem Cc: ngraham, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29872: Provide methods to register SecretAgent to NetworkManager with capabilities, specifically with NM_SECRET_AGENT_CAPABILITY_VPN_HINTS

apol added a comment. We have moved to gitlab, now patches should be uploaded here: https://invent.kde.org/frameworks/networkmanager-qt Sorry for the change (@jgrulich can still review it, but it's better to have everything in the new infrastructure). The patch itself looks okay to

D27338: Provide an initial implementation for input-method-unstable-v1

apol abandoned this revision. apol added a comment. https://invent.kde.org/plasma/kwayland-server/-/merge_requests/31 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27338 To: apol, #kwin, #frameworks Cc: davidedmundson, zzag, kde-frameworks-devel, LeGast00n,

D22362: Port keystates to use QtWayland's generator

apol abandoned this revision. apol added a comment. Moved to invent for kwayland-server REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D22362 To: apol, #kwin Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28235: Add a simpler example

apol closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28235 To: apol, vkrause, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D26524: configmodule: Make sure the kcm information is loaded when the qml is created

apol added a comment. hmmm. Ping @mart. :) what do you suggest we do? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26524 To: apol, #plasma, #frameworks Cc: mart, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28235: Add a simpler example

apol added a comment. Should I understand this is not desired and that I should abandon it? I know it's not going to make a big difference to the project but it was hard for me to adopt it in the first place. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D29540: plasmawindowmodel: Expose the internal id to the model

apol abandoned this revision. apol added a comment. Will move to gitlab REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29540 To: apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29810: Don't use setenv after fork

apol added inline comments. INLINE COMMENTS > kcrash.cpp:823 > +char** environ_end; > +for(environ_end = environ; *environ_end; ++environ_end); > + Use {} instead of ; for readability. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29810 To: jpalecek,

D29802: Require out-of-source builds

apol accepted this revision. REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre, apol Cc: ltoscano, davidre, kde-frameworks-devel, LeGast00n, cblack,

D29745: look for kded as runtime dep

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH kded REVISION DETAIL https://phabricator.kde.org/D29745 To: sitter, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29631: [android] Allow specifying APK install location

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH androinstall REVISION DETAIL https://phabricator.kde.org/D29631 To: nicolasfella, #frameworks, #android, apol, vkrause Cc: kde-frameworks-devel, kde-buildsystem,

D29600: Fix build with KF set to EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fixbuildwithoutdeprecated REVISION DETAIL https://phabricator.kde.org/D29600 To: kossebau, #plasma, mart, apol Cc: kde-frameworks-devel, LeGast00n, cblack,

D29631: [android] Allow specifying APK install location

apol added a comment. +1 overall, good idea. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29631 To: nicolasfella, #frameworks, #android, apol, vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham, bruns

D29631: [android] Allow specifying APK install location

apol added inline comments. INLINE COMMENTS > Android.cmake:93 > # > -# The APK would then be found in ``myapp_build_apk/bin`` in the build > directory. > +# You can specify the APK output directory by setting > ANDROID_APK_INSTALL_DIR. > +# Otherwise the APK can be found in

D29511: Label: Add ping-pong logic

apol added a comment. I feel like this could break Labels unknowingly. Maybe it would make sense to have an extra scrollToFit (?) property or even another separate component to do that. Seeing things bouncing without the author intending could be worse than having the text cut off.

D28882: Create protocol to manage video feeds

apol added a comment. Moving to kwayland-server REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich, davidedmundson, zzag Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

apol abandoned this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich, davidedmundson, zzag Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29540: plasmawindowmodel: Expose the internal id to the model

apol created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It allows to use this class together with the screencast protocol. It's public API on the window anyway so it should

D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

apol added inline comments. INLINE COMMENTS > kopenwithdialog.cpp:1006 > // Ensure that the typed binary name actually exists (#81190) > if (QStandardPaths::findExecutable(binaryName).isEmpty()) { > +// Maybe it exists but isn't executable This patch D29170

D29406: Add X-KDE-Original-Executable to Applications properties

apol added a comment. > If I understand correctly, it is necessary to use dbus spectacle in this case, so that dbus can manage the application instance and make sure we end up with only one, whether we launch the app, use a shortcut or launch from command line. I don't think that's a

D29405: [PoC] Make notifications work without a notifyrc file

apol added a comment. What's the advantage? Won't this make it harder to put together the notifications kcm? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29405 To: nicolasfella, #frameworks, broulik, vkrause Cc: apol, kde-frameworks-devel, LeGast00n,

D29406: Add X-KDE-Original-Executable to Applications properties

apol added a comment. This should be documented somewhere, as is it's really confusing. I'm not sure it wouldn't be better to have spectacle launched again there instead of going through dbus (which is a change I admittedly don't understand very well). REPOSITORY R309 KService

D29396: Suppress find_package_handle_standard_args package name mismatch warning.

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. This will make our configure steps readable again. Thanks! REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D29396 To: xuetianweng,

D29201: KCMUtils: Add option to append service file to list of arguments

apol added a comment. I have the feeling there's a missing piece here. Would it make sense to always pass it? Would it regress in any way? At the very least, on the API documentation, explain why one would want that. REPOSITORY R295 KCMUtils REVISION DETAIL

D29361: KCrash: remove debug output which breaks unittests from using ~/.qttest/config for categorized logging

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R285 KCrash BRANCH master REVISION DETAIL https://phabricator.kde.org/D29361 To: dfaure, kossebau, davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29278: Port KWin to KWaylandServer

This revision was automatically updated to reflect the committed changes. Closed by commit R108:3a9d7a6e9d75: Port KWin to KWaylandServer (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29278?vs=81574=81575#toc REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D29278: Port KWin to KWaylandServer

apol updated this revision to Diff 81574. apol added a comment. Address @zzag's comments REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29278?vs=81521=81574 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29278 AFFECTED FILES

D29278: Port KWin to KWaylandServer

apol marked an inline comment as done. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D29278 To: apol, #kwin, #plasma, #frameworks, davidedmundson Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D29278: Port KWin to KWaylandServer

apol created this revision. apol added reviewers: KWin, Plasma, Frameworks. Herald added a project: KWin. Herald added a subscriber: kwin. apol requested review of this revision. REVISION SUMMARY Away from KWayland::Server and KF5WaylandServer. TEST PLAN Builds, ran nested session

D29256: [server] Introduce mapped() signal

apol accepted this revision. REPOSITORY R127 KWayland BRANCH introduce-mapped-signal REVISION DETAIL https://phabricator.kde.org/D29256 To: zzag, #kwin, davidedmundson, apol Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29079: android: include the architecture on the apk name

This revision was automatically updated to reflect the committed changes. Closed by commit R240:fca97c036c8d: android: include the architecture on the apk name (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29079?vs=80829=81480

D29256: [server] Introduce mapped() signal

apol added inline comments. INLINE COMMENTS > zzag wrote in surface_interface.cpp:333 > We can't use != because mapped() will be emitted each time a new buffer is > attached to the surface. I don't understand, ^ and != are logically equivalent, ^ is the bitwise counterpart. Am I missing

D29256: [server] Introduce mapped() signal

apol added a comment. +1 INLINE COMMENTS > surface_interface.cpp:333 > const bool childrenChanged = source->childrenChanged; > +const bool visibilityChanged = bool(source->buffer) ^ > bool(target->buffer); > bool sizeChanged = false; Using != would probably be more readable

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

apol added inline comments. INLINE COMMENTS > keyboard_shortcuts_inhibit_interface.cpp:144 > +QPair key(surface, seat); > +if (m_inhibitors.contains(key)) { > +return m_inhibitors[key]; Just `return m_inhibitors.value({ surface, seat })` to save a look-up and a few lines of

D28882: Create protocol to manage video feeds

apol added a comment. > In future, it might be faster to put up just the interface xml for review first. @davidedmundson @zzag I don't really see how it would have made a difference, you only decided to review it 7 to 10 days after I first submitted it. 路 > What about using

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

apol added a comment. Code looks good overall, I'd say you'll get to polish the weird bits when developing the kwin side. In fact, this probably could be implemented within kwin considering what we discussed last week. We could remove the weirdness we have to keep its ABI. INLINE

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 81341. apol added a comment. Address review comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=81113=81341 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED FILES

D28882: Create protocol to manage video feeds

apol marked 2 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich, davidedmundson Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29216: Remove dead code since KF5.0: mount/umount devices in their contextmenu

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH 2020_04_remove_dead_solid_code REVISION DETAIL https://phabricator.kde.org/D29216 To: dfaure, apol, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29181: Use KFileMetaData for XAttr support instead of private reimplementation

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D29181 To: bruns, #baloo, ngraham, apol Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov,

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 81113. apol added a comment. Refactor the protocol as suggested by David and Vlad REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80984=81113 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882

D28882: Create protocol to manage video feeds

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > davidedmundson wrote in screencast.xml:31 > this is racey with create. Any suggestion on how to do it better? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin,

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80984. apol added a comment. Also propagate the buffer size, it's important for the client to know what buffer size it will have. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80801=80984 BRANCH master

D29102: Prefer QIcon::pixmap(QWindow*, ...) overload

This revision was automatically updated to reflect the committed changes. Closed by commit R242:25ce2b90dab1: Prefer QIcon::pixmap(QWindow*, ...) overload (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D29102: Prefer QIcon::pixmap(QWindow*, ...) overload

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It takes into account the dpi of the screen we're rendering to. Other overloads

D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args

apol added a comment. +1 makes sense REPOSITORY R240 Extra CMake Modules BRANCH avoidnewwarningsinfindkf5 REVISION DETAIL https://phabricator.kde.org/D29097 To: kossebau, #frameworks, #build_system, cgiboudeaux Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack,

D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks like an improvement REPOSITORY R290 KPackage BRANCH fixXDG_DATA_DIRSextending REVISION DETAIL https://phabricator.kde.org/D29063 To: kossebau, #frameworks, mart, apol, sitter,

D29079: android: include the architecture on the apk name

apol created this revision. apol added reviewers: Android, Frameworks. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Makes them easier to use afterwards. TEST PLAN

D29062: Port KToolInvocation::kdeinitExecWait to QProcess

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kded.cpp:67 > > static void runKonfUpdate() > { The function has a typo, should be `runKConfUpdate`, no? REPOSITORY R297 KDED REVISION DETAIL

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80801. apol added a comment. Hopefully fix the build for Jan REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80798=80801 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED FILES

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80798. apol added a comment. - Test Cleanup - When a resource is destroyed, emit to close all its streams REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80677=80798 BRANCH master REVISION DETAIL

D29033: Remove duplicated code

apol abandoned this revision. apol added a comment. My bad, thanks! REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D29033 To: apol, #frameworks, zzag Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D29033: Remove duplicated code

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Went through it while reviewing some code. TEST PLAN Been running it for a while, including direct

D29018: Align description in metainfo.yaml with the one of README.md

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R174 KContacts BRANCH fixmetainfodescription REVISION DETAIL https://phabricator.kde.org/D29018 To: kossebau, mlaurent, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80677. apol added a comment. Improve how we initialise the sourceId REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80662=80677 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED

D28780: [FstabWatcher] Fix loosing of fstab watcher

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28780 To: bruns, #frameworks, ngraham, apol Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80662. apol added a comment. Iterate tests (which work now) and uses REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80658=80662 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80658. apol added a comment. Fix test REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80637=80658 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED FILES

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80637. apol added a comment. iterate test REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80605=80637 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED FILES

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D29003 To: junghans, kossebau, dfaure, apol Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80605. apol added a comment. oops REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80604=80605 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED FILES

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80604. apol added a comment. Include server side, a test (that doesn't pass) and some renaming REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80411=80604 BRANCH master REVISION DETAIL

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

apol added a comment. I wonder, while this will work with all our uses of DropUrlPatterns, this would have been able to work with something like `scheme:/*potato*` which after this patch won't work. In fact, it's called Patterns, not DropUrlWhenStartsWith. I'd appreciate feedback from

D28956: [QML Monitor] Show remaining time as soon as possible

apol added a comment. You're using QDeadlineTimer weird. Why don't you use QDeadlineTimer::remainingTime() and ::setDeadline? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28956 To: bruns, #baloo, ngraham Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs,

D28955: [FileContentIndexer] Fix state update and signal order

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28955 To: bruns, #baloo, ngraham, apol Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

D28953: [Extractor] Fix progress reporting

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28953 To: bruns, #baloo, ngraham, mlaurent, apol Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,

D28954: [Monitor] Fix monitor state and signal ordering

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28954 To: bruns, #baloo, ngraham, apol Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

D28940: [baloo_file] Remove KAboutData from baloo_file

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28940 To: bruns, #baloo, ngraham, leszeklesner, apol Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,

D28900: Fix wayland scanner warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R240:3734a5368e44: Fix wayland scanner warnings (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28900?vs=80334=80436 REVISION DETAIL

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80411. apol added a comment. Include the server side and some renames REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80284=80411 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED

D28882: Create protocol to manage video feeds

apol marked 2 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28919: Drop delayed second phase

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense, sounds like the second phase is quite arbitrary there. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D28919 To: broulik, #plasma, dfaure, davidedmundson,

D28355: Introduce function ecm_install_configured_file

apol added a comment. Are we stuck somewhere? The patch looks good to me. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28355 To: davidedmundson Cc: apol, kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh,

D19913: [plasma-framework] make it compiles without foreach

apol accepted this revision. apol added inline comments. INLINE COMMENTS > dropmenu.cpp:80 > } else if (m_menu) { > -foreach (QAction *action, m_dropActions) { > +for (QAction *action : qAsConst(m_dropActions)) { > m_menu->addAction(action);

D28900: Fix wayland scanner warnings

apol created this revision. apol added reviewers: Build System, KWin, Frameworks. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Tells cmake not to automoc certain files

D28883: Add wrapper for wl_global_remove

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D28883 To: davidedmundson, #plasma, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80284. apol added a subscriber: zzag. apol added a comment. renamed protocol as per @zzag's suggestion REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80278=80284 BRANCH master REVISION DETAIL

D28882: Create protocol to manage video feeds

apol added a dependent revision: D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

apol created this revision. apol added reviewers: KWin, jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Creates a protocol based on Pipewire that allows us to request feeds to be set up by

D28850: Updated Romanian holidays

This revision was automatically updated to reflect the committed changes. Closed by commit R175:28ad589a1fbe: Updated Romanian holidays (authored by sionescu, committed by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28850?vs=80179=80220#toc REPOSITORY R175 KHolidays CHANGES

D24956: Consider desktop files with NoDisplay attribute

apol added a comment. +1 This makes sense to me REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D24956 To: meven, mart, #plasma, fvogt, apol Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28088: Fix warnings

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:298ce0ed7ff4: Fix warnings (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D28776: FstabDevice: Avoid recurrent construction of emblems QStringList

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Address the scope of the statics as kai mentioned in D28778 . Or use Q_GLOBAL_STATIC. REPOSITORY R245 Solid REVISION DETAIL

D28778: [FstabWatcher] Use static QStringLiteral instead of macro

apol added a comment. In D28778#646791 , @broulik wrote: > Don't use global statics in library code in case it gets statically compiled? REPOSITORY R245 Solid BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28778 To:

D28776: FstabDevice: Avoid recurrent construction of emblems QStringList

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28776 To: bruns, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28780: [FstabWatcher] Fix loosing of fstab watcher

apol added inline comments. INLINE COMMENTS > fstabwatcher.cpp:110 > emit fstabChanged(); > if (!m_fileSystemWatcher->files().contains(s_fstabFile)) { > +m_isFstabWatched = m_fileSystemWatcher->addPath(s_fstabFile); Use m_isFstabWatched? Or maybe m_isFstabWatched

D28778: [FstabWatcher] Use static QStringLiteral instead of macro

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28778 To: bruns, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28782: [Fstab] Do not emit deviceAdded twice on fstab/mtab changes

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > fstabmanager.cpp:122 > + > +qCDebug(FSTAB) << oldlist << "->" << newlist; > + The debug seems wrong and probably unnecessary. I'd remove it. REPOSITORY R245 Solid

D28779: [Fstab] Use new style connect API

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28779 To: bruns, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28726: [KJS] Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R314 KJs BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D28726 To: ahmadsamir, #frameworks, porten, apol Cc: kde-frameworks-devel, LeGast00n, cblack,

D28699: Add startCapture method

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH startCpature (branched from master) REVISION DETAIL https://phabricator.kde.org/D28699 To: davidre, #frameworks, davidedmundson, broulik, apol Cc: kde-frameworks-devel,

D28637: Use ecm_setup_qtplugin_macro_names

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH useECMSetupQtPluginMacroNames REVISION DETAIL https://phabricator.kde.org/D28637 To: kossebau, #frameworks, mart, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28620: Add readmes clarifying state of plasma component versions

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D28620 To: davidedmundson, #plasma, apol Cc:

D28599: [configview] Simplify code / workaround Qt5.15 crash

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM INLINE COMMENTS > configview.cpp:137 > > + > q->engine()->rootContext()->setContextProperty(QStringLiteral("plasmoid"), > applet.data()->property("_plasma_graphicObject").value());

D28409: ECM: attempt to fix KDEInstallDirsTest.relative_or_absolute on Windows

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D28409 To: dfaure, kossebau, apol, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2,

D28409: ECM: attempt to fix KDEInstallDirsTest.relative_or_absolute on Windows

apol added a comment. Will /tmp then still work on Windows? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28409 To: dfaure, kossebau, apol, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, michaelh, ngraham,

D28579: Improve the look of kcachegrind

apol added a comment. +1 much better! REPOSITORY R266 Breeze Icons BRANCH kcachegrind (branched from master) REVISION DETAIL https://phabricator.kde.org/D28579 To: ndavis, #vdg, cblack, ngraham Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28565: [QueryParser] Replace single-use helper with std::none_of

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28565 To: bruns, #baloo, ngraham, apol Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

  1   2   3   4   5   6   7   8   9   10   >