D27950: Assign an icon to action submenus

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Currently, action submenus (X-KDE-Submenu) have no icons. This patch makes it inherit

D27910: Make sure warning output is enabled before testing if the correct warning is printed

apol added a comment. Is it passing on the CI because somehow we enable warnings on there? https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20SUSEQt5.13/60/testReport/ REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D27910 To: sandsmark, dfaure Cc:

D27883: Register spawned applications as an independent cgroups

apol added inline comments. INLINE COMMENTS > kprocessrunner.cpp:51 > + > +std::once_flag dbusTypesRegistered; > + This could be in the function scope as static. > kprocessrunner.cpp:281 > +{ > +if (!qEnvironmentVariableIsSet("KDE_APPLICATIONS_AS_SCOPE")) { > +return; Who defines

D27882: Move KProcessRunner into it's own file

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27882 To: davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27860: [server] Add some sub-surface life cycle signals

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM INLINE COMMENTS > surface_interface.h:348 > +/** > + * Emitted whenever a new child sub-surface @p subSurface is added. > + */ Include @since REPOSITORY R127 KWayland

D27848: Remove the panel tooltip icon

apol accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH remove-tooltip-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27848 To: ngraham, #vdg, #plasma, cblack, niccolove, apol Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D27838: Port to new QML Connections syntax

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Yes, can't be done until 5.14 is required in frameworks. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D27838 To: jbbgameich,

D27833: Add an accessor to get the last loaded value for KConfigSkeletonItem

apol added a comment. What's the use-case? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27833 To: meven, ervin, bport, crossi, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27828: [server] Introduce SurfaceInterface::boundingRect()

apol added a comment. Maybe producing the patch that is meant to consume this will help see what's the use for this patch. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27828 To: zzag, #kwin Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27801: smb: add a unit test for smburl

apol added a comment. +1 from me INLINE COMMENTS > apol wrote in smburl.cpp:67 > Can't we then just rename the method to `::cdUp()`? it can return void too, nobody is checking it anyway. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27801 To: sitter, ngraham

D27800: smb: split module into two targets of which one is a static lib

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good, it's not being used though so as is it feels wrong. REPOSITORY R320 KIO Extras BRANCH smb-smburl-static REVISION DETAIL https://phabricator.kde.org/D27800 To: sitter,

D27801: smb: add a unit test for smburl

apol added inline comments. INLINE COMMENTS > smburl.cpp:67 > > bool SMBUrl::cd(const QString ) > { Can't we then just rename the method to `::cdUp()`? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27801 To: sitter, ngraham Cc: apol, kde-frameworks-devel,

D26749: WIP: Support NDK r20 and Qt 5.14

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Seems ready to land to me. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause, apol Cc: flherne, apol,

D26749: WIP: Support NDK r20 and Qt 5.14

apol added inline comments. INLINE COMMENTS > vkrause wrote in Android.cmake:173 > I actually didn't test 64bit ARM here, only armv7 and x86, both work. What > does break for you there? I'm not sure what was going on, seems to work now. REPOSITORY R240 Extra CMake Modules BRANCH master

D27707: Use kcoreaddons_add_plugin for kded module

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R155 KAccounts Integration BRANCH plug REVISION DETAIL https://phabricator.kde.org/D27707 To: nicolasfella, #frameworks, bshah, leinir, apol

D27706: Random cmake cleanup

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R155 KAccounts Integration BRANCH cmakecleanup REVISION DETAIL https://phabricator.kde.org/D27706 To: nicolasfella, #frameworks, bshah, leinir, apol

D27705: Use QStringLiteral

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. if you want to have this, it could make sense to enforce it from cmake. INLINE COMMENTS > createaccount.cpp:195 > base.append(authData.method()); > -base.append("/"); > +

D27616: [UrlHandler] Handle opening the online docs for KCM modules

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R273 KGuiAddons BRANCH l-urlhandler-optimi (branched from master) REVISION DETAIL https://phabricator.kde.org/D27616 To: ahmadsamir, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack,

D27616: [UrlHandler] Handle opening the online docs for KCM modules

apol added inline comments. INLINE COMMENTS > CMakeLists.txt:33 > target_compile_definitions(KF5GuiAddons INTERFACE > "$") > -target_link_libraries(KF5GuiAddons PUBLIC Qt5::Gui) > +target_link_libraries(KF5GuiAddons PUBLIC Qt5::Widgets) > +target_link_libraries(KF5GuiAddons PUBLIC KF5::I18n)

D27616: [UrlHandler] Handle opening the online docs for KCM modules

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. We can't add new dependencies to a tier1 framework, it would break the whole dependency system. Just make it a qCWarning. REPOSITORY R273 KGuiAddons REVISION DETAIL

D27662: Rewrite nextcloud plugin

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH nextcloud REVISION DETAIL https://phabricator.kde.org/D27662 To: nicolasfella, #frameworks, apol, bshah Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27616: [UrlHandler] optimise the code and less if nesting

apol added inline comments. INLINE COMMENTS > ahmadsamir wrote in urlhandler.cpp:55 > I could be wrong, but this is exactly equivalent to the original code, i.e. > it won't reach this unless helpcenter is empty and it's not a kde app... and > I actually wanted to ask about this bit from the

D27637: kill twitter support

apol accepted this revision. REPOSITORY R495 Purpose Library BRANCH killtwitter REVISION DETAIL https://phabricator.kde.org/D27637 To: nicolasfella, #frameworks, apol, bshah Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27633: Port to KPluginLoader

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R155 KAccounts Integration BRANCH kpluginloader REVISION DETAIL https://phabricator.kde.org/D27633 To: nicolasfella, bshah, leinir, #frameworks, apol

D27596: Load QM files from assets: URLs on Android

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. They used to work back when I added the code for it. Maybe it broke over time. If it works for you, go for it. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL

D27627: Fix initialization order

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D27627 To: dvratil, #plasma, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D23339: Fix memory leak in ConfigView and Dialog

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D23339 REVISION DETAIL https://phabricator.kde.org/D23339 To: dvratil, #plasma, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27616: [UrlHandler] optimise the code and less if nesting

apol added a comment. LGTM otherwise INLINE COMMENTS > urlhandler.cpp:55 > +// not a KDE application > +QDesktopServices::openUrl(u); > } won't this recurse forever? REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27616 To: ahmadsamir,

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

apol accepted this revision. REPOSITORY R252 Framework Integration BRANCH messagewidget (branched from master) REVISION DETAIL https://phabricator.kde.org/D27039 To: davidre, #frameworks, aacid, anthonyfieroni, apol Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27620: [krun] Share implementation of runService and runApplication

apol added a comment. Don't we need KDesktopFile::isAuthorizedDesktopFile now? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27620 To: davidedmundson, apol Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27620: [krun] Share implementation of runService and runApplication

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > krun.cpp:716 > +if (!flags.testFlag(DeleteTemporaryFiles)) { > +// Remember we opened those urls, for the "recent documents" menu in > kicker > +for

D27591: KAbstractFileItemActionPlugin: Add missing quotes in code example

apol accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27591 To: alex, elvisangelaccio, #frameworks, mlaurent, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27596: Load QM files from assets: URLs on Android

apol added a comment. Don't we need an if Qt 5.13 elseif Qt 5.14? In other Qt versions it won't be in the assets... REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D27596 To: vkrause Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack,

D27594: Remove unused KDBusConnectionPool include

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27594 To: vkrause, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27038: [KMessageWidget] Allow the style to change our palette

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Meh, right. I guess it doesn't matter that much. REPOSITORY R236 KWidgetsAddons BRANCH polish (branched from master) REVISION DETAIL https://phabricator.kde.org/D27038 To: davidre,

D27597: KRunner: Refactor deprecated toSet() method

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense. It would be ideal to have a way to do an unsorted comparison without having to create 2 temporary sets every time, although I guess it's out of scope here. REPOSITORY R308

D27038: [KMessageWidget] Allow the style to change our palette

apol added a comment. But then now we are not refreshing the palette when it changes outside, no? How about adding a boolean value when it's already happening to prevent the infinite recursion? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D27038 To:

D27552: Have kai the knotifications maintainer

This revision was automatically updated to reflect the committed changes. Closed by commit R289:224cc7382e63: Have kai the knotifications maintainer (authored by apol). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27552?vs=76121=76125 REVISION

D27478: Add a --replace option to kded5

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R297:bb604f05b0bd: Add a --replace option to kded5 (authored by apol). REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE

D27552: Have kai the knotifications maintainer

apol created this revision. apol added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY As discussed in the mailing list TEST PLAN :D REPOSITORY R289 KNotifications

D27550: Support Qt 5.14 on Android

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kcatalog.cpp:121 > > +#ifdef Q_OS_ANDROID > +static QString androidUnpackCatalog(const QString ) `#if defined(Q_OS_ANDROID) && QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)`

D27535: Add XdgOutputV1 version 2

apol added a comment. +1 LGTM INLINE COMMENTS > xdgoutput_interface.cpp:319 > +} > +if (wl_resource_get_version(d->resource) < > ZXDG_OUTPUT_V1_DESCRIPTION_SINCE_VERSION) { > +return; noob question: what would happen if you didn't have this check? REPOSITORY R127

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

apol added a comment. +1 code looks much better! REPOSITORY R236 KWidgetsAddons BRANCH no-css (branched from master) REVISION DETAIL https://phabricator.kde.org/D27035 To: davidre, #frameworks, ngraham, cfeck Cc: apol, cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n,

D27334: Fix pri file: have qmake name of QtGui as dep, do not fail with CamelCase includes

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH prifixesreview REVISION DETAIL https://phabricator.kde.org/D27334 To: kossebau, svuorela, vkrause, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27475: Make kwapper/kshell spawn klauncher5 if needed

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R303 KInit BRANCH master REVISION DETAIL https://phabricator.kde.org/D27475 To: davidedmundson, apol Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27476: [KDBusConnectionPool] Handle the case of no qApp

apol added inline comments. INLINE COMMENTS > kdbusconnectionpool.cpp:66 > +if (!QCoreApplication::instance()) { > +return QDBusConnection::sessionBus(); > +} It feels like we should be using the s_perThreadConnection when we're not on a QApplication. Non-QApplications might

D27475: Make kwapper/kshell spawn klauncher5 if needed

apol added inline comments. INLINE COMMENTS > CMakeLists.txt:57 > find_package(KF5Config ${KF5_DEP_VERSION} REQUIRED) > +find_package(KF5DBusAddons ${KF5_DEP_VERSION} REQUIRED) > find_package(KF5DocTools ${KF5_DEP_VERSION}) I suppose this should be if (NOT WIN32)? I'm not entirely sure why

D27478: Add a --replace option to kded5

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Allows restarting kded5 properly, useful when trying new modules. TEST PLAN

D27459: Port QLinkedList which is deprecated in qt5.15

apol added a comment. In D27459#613205 , @aacid wrote: > Are we sure we can lose the features of QLinkedList here? > > maybe makes more sense to use std::list that has the same features as QLinkedList? I thought so too, but we just

D27459: Port QLinkedList which is deprecated in qt5.15

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH port_QLinkedList (branched from master) REVISION DETAIL https://phabricator.kde.org/D27459 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D26918: Improve KNotification API docs

apol added inline comments. INLINE COMMENTS > broulik wrote in knotification.h:96 > It actually sends out the icon name as a string and plasmashell then looks it > up. With QIcon? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26918 To: nicolasfella,

D26918: Improve KNotification API docs

apol added inline comments. INLINE COMMENTS > jucato wrote in knotification.h:96 > Maybe we should keep this part that the icon name, especially that it has to > be one that can be found by KIconLoader. Since Qt5 KIconLoader is an implementation detail. Even our apps and frameworks use

D26918: Improve KNotification API docs

apol added a subscriber: class. apol added a comment. Let's do this. +1 INLINE COMMENTS > Mainpage.dox:9 > + > +KNotification is the main entry point for using KNotifications. > + @class so we create a link. REPOSITORY R289 KNotifications REVISION DETAIL

D26918: Improve KNotification API docs

apol added a comment. +1 on improving the documentation, it does read dated. Thanks! INLINE COMMENTS > knotification.h:44 > * @li Feedback events: > - * For notifying the user that he/she just performed an operation, like > maximizing a > - * window. This allows us to play sounds when a

D26749: WIP: Support NDK r20 and Qt 5.14

apol added a comment. Patch makes sense to me overall, we could consider landing it. INLINE COMMENTS > vkrause wrote in Android.cmake:173 > It's "better" in the way that it actually works with NDK r20, while CMake > 3.16 failed to even pass the basic compiler checks. For a toolchain file >

D27412: Port away from deprecated API on Qt 5.15.0

This revision was automatically updated to reflect the committed changes. Closed by commit R871:781064ba1c13: Port away from deprecated API on Qt 5.15.0 (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27412?vs=75714=75731#toc REPOSITORY R871 DrKonqi CHANGES SINCE

D27412: Port away from deprecated API on Qt 5.15.0

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Upstream recommends using QLocale for turning dates into strings. TEST PLAN Builds on my system now

D27366: Construct NullEngine with KPluginMetaData()

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27366 To: broulik, #plasma, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26858: Provide an implementation for the tablet interface

apol updated this revision to Diff 75564. apol added a comment. Only call destruction if it was an owned tablet, this way we don't crash. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=75561=75564 BRANCH arcpatch-D26858 REVISION DETAIL

D26858: Provide an implementation for the tablet interface

apol added a comment. In D26858#605869 , @davidedmundson wrote: > Feedback from some testing: > > - we're adding the same tool a bunch of times when a new client is created > - sometimes we fail to enter the surface leaving the cursor

D26858: Provide an implementation for the tablet interface

apol updated this revision to Diff 75561. apol added a comment. rebase on master REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=74473=75561 BRANCH arcpatch-D26858 REVISION DETAIL https://phabricator.kde.org/D26858 AFFECTED FILES

D27338: Provide an initial implementation for input-method-unstable-v1

apol added a dependent revision: D27339: Implement input methods. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27338 To: apol, #kwin, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27338: Provide an initial implementation for input-method-unstable-v1

apol created this revision. apol added reviewers: KWin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Makes it possible to implement the protocol in your favourite compositor. TEST

D25495: Fix Sonnet autodetect failing on Indian langs

apol added a comment. This patch makes it do all the languages identified by identify + all the languages supported by the script. This could mean lots of languages for some scripts... INLINE COMMENTS > guesslanguage.cpp:586 > + > +QStringList candidateLanguages = d->identify(text,

D27207: Use a less convoluted way to check if it's in flatpak

This revision was automatically updated to reflect the committed changes. Closed by commit R271:9027710fb817: Use a less convoluted way to check if its in flatpak (authored by apol). REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27207?vs=75156=75163

D27207: Use a less convoluted way to check if it's in flatpak

apol created this revision. apol added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REPOSITORY R271 KDBusAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27207 AFFECTED

D27067: Change "AutoSkip" to "Skip All"

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27067 To: ngraham, #frameworks, #vdg, dfaure, apol Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27080: Don't warn for invalid plugin metata

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH less-warning-spam (branched from master) REVISION DETAIL https://phabricator.kde.org/D27080 To: ngraham, #plasma, mart, apol Cc: apol, alex,

D27203: Don't try to open files we can't figure out where they are

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. TEST PLAN Been using it for a few days, no regressions. Opening sftp:///localhost/.../somefile.text twice, doesn't

D27200: Make the attached property a simple QObject

apol added a comment. LGTM otherwise INLINE COMMENTS > colorscope.cpp:57 > +connect(parentItem, ::windowChanged, > this, [this]() { > findParentScope(); let's make this a proper method? it's used twice here and a normal method should be quicker to use

D25698: New query mechanism for applications: KApplicationTrader

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. +1 Makes sense. REPOSITORY R309 KService BRANCH kapplicationtrader REVISION DETAIL https://phabricator.kde.org/D25698 To: dfaure, broulik, mart, vkrause, nicolasfella, aacid,

D27123: Add a default provider (as per documentation)

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R235 Attica BRANCH provide-default-provider-as-per-docs (branched from master) REVISION DETAIL https://phabricator.kde.org/D27123 To: leinir, kossebau, #frameworks,

D27112: Fix errors in the QRegularExpression porting commit

apol added a comment. LGTM, adding tests would be brilliant. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D27112 To: ahmadsamir, #frameworks, drosca, apol, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27080: Don't warn for invalid plugin metata

apol added a comment. Change to qDebug? this is just a result to an ugly workaround and is just a symptom of also a performance issue. Silencing it only perpetuates the issue. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27080 To: ngraham,

D27034: Fix message box when passing a remote url that includes a file

This revision was automatically updated to reflect the committed changes. Closed by commit R135:317a899dc774: Fix message box when passing a remote url that includes a file (authored by apol). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D27034: Fix message box when passing a remote url that includes a file

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY The if was negated, I assume it was a typo TEST PLAN I don't get the following screenshot anymore

D26133: Enable Auto Save

apol added a comment. In D26133#603118 , @tcanabrava wrote: > > That's why personally I think it's fine to assume people need to opt-in for GenerateProperties if they want the feature, it's closely related after all. > > I disagree here.

D26573: Add missing Import Env Variable

apol added a comment. I don't really understand why this is needed, I've never needed that at least. Having @davidedmundson's patch would be interesting too, although we might want to support earlier versions that won't get the patch. REPOSITORY R240 Extra CMake Modules BRANCH

D26858: Provide an implementation for the tablet interface

apol updated this revision to Diff 74473. apol added a comment. clang format REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=74241=74473 BRANCH apol/tablet-unstable-v2-1 REVISION DETAIL https://phabricator.kde.org/D26858 AFFECTED FILES

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH port_QXmlStreamReader (branched from master) REVISION DETAIL https://phabricator.kde.org/D26890 To: mlaurent, dfaure, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2,

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

apol added inline comments. INLINE COMMENTS > kconfigloader.cpp:125 > for (int i = 0; i < numAttrs; ++i) { > -QString name = attrs.localName(i).toLower(); > +const QString name = attrs.at(i).name().toString().toLower(); > if (name ==

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

apol added inline comments. INLINE COMMENTS > kconfigloader.cpp:77 > +case QXmlStreamReader::Characters: > +if (!reader.isWhitespace() && > !reader.text().toString().trimmed().isEmpty()) { > +if (!characters(reader.text())) No need to construct a QString if

D26900: Support multiple values in XDG_CURRENT_DESKTOP

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. The patch looks good to me. INLINE COMMENTS > apol wrote in kservice.cpp:658 > You can use QVector here, it would save us constructing a bunch > of strings for no reason. Maybe not in the

D26903: allow programLogo property to be a QIcon, too

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D26903 To: cullmann, apol Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26900: Support multiple values in XDG_CURRENT_DESKTOP

apol added inline comments. INLINE COMMENTS > kservice.cpp:658 > > -QStringList > currentDesktops(QString::fromLatin1(qgetenv("XDG_CURRENT_DESKTOP"))); > +QStringList > currentDesktops(QString::fromLatin1(qgetenv("XDG_CURRENT_DESKTOP")).split(QLatin1Char(':'), >

D26876: Remove the Enum hack: finish lists with a comma, it's valid c++

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH remove_enum_hack REVISION DETAIL https://phabricator.kde.org/D26876 To: tcanabrava, ervin, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

apol added a comment. Looks good otherwise, this code is pretty well tested too, so I quite trust we aren't breaking it horribly. Trying to compile the rest of KDE Software against this patch would also be useful. INLINE COMMENTS > kconfigloader.cpp:127 > } else if (name

D26858: Provide an implementation for the tablet interface

apol updated this revision to Diff 74241. apol added a comment. Address comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=74217=74241 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26858 AFFECTED FILES CMakeLists.txt

D26858: Provide an implementation for the tablet interface

apol marked 11 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26858 To: apol, #kwin, #frameworks, zzag Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26858: Provide an implementation for the tablet interface

apol updated this revision to Diff 74217. apol added a comment. ehm.. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=74214=74217 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26858 AFFECTED FILES CMakeLists.txt

D26858: Provide an implementation for the tablet interface

apol reopened this revision. apol added a comment. Phabricator chokes on git branches... REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26858 To: apol, #kwin, #frameworks, zzag Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26858: Provide an implementation for the tablet interface

apol updated this revision to Diff 74213. apol added a comment. remove unrelated bits REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=74212=74213 BRANCH apol/tablet-unstable-v2 REVISION DETAIL https://phabricator.kde.org/D26858 AFFECTED

D26858: Provide an implementation for the tablet interface

apol updated this revision to Diff 74212. apol added a comment. Addressed zzag's comments, fixed the patch overall. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=74187=74212 BRANCH apol/tablet-unstable-v2 REVISION DETAIL

D26858: Provide an implementation for the tablet interface

apol marked 6 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26858 To: apol, #kwin, #frameworks, zzag Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26858: Provide an implementation for the tablet interface

apol added a dependent revision: D26859: Implement the tablet wayland protocol in kwin. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26858 To: apol, #kwin, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26858: Provide an implementation for the tablet interface

apol created this revision. apol added reviewers: KWin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Implements the necessary classes to have proper support for the tablet and pen.

D26800: autotests: use local desktop file to avoid relying on konsole

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D26800 To: dfaure, meven, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26781: Fix test since Konsole added icons to its actions

apol added a comment. How about we ship a desktop file here to test instead of using the one in the system? It doesn't make much sense that there's this weird dependency here. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D26781 To: meven, #frameworks,

D26740: Add KService::isSubseq as a public API for filtering queries.

apol added a comment. > I like isSubsequence(). But I also just realized, it's a bit odd to have this in KService. I think I should make it part of the KApplicationTrader namespace instead, since it's a utility method for querying. > This means merging with D25698

D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names

apol accepted this revision. apol added a comment. Looks good to me, bonus points if you provide a better commit message explaining what it does and how you tested it. REPOSITORY R240 Extra CMake Modules BRANCH sc_appicon REVISION DETAIL https://phabricator.kde.org/D26751 To:

<    1   2   3   4   5   6   7   8   9   10   >