D22475: Use metadata.json when creating the metadata from KPackage::metadata()

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R290:898e5133e796: Use metadata.json when creating the metadata from KPackage::metadata() (authored by apol). REPOSITORY

D22475: Use metadata.json when creating the metadata from KPackage::metadata()

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Otherwise we'd end up using the slow path. TEST PLAN metadata still gets loaded but usin

D22471: [KProcessList] Split command line and process name

apol added a comment. So now name() will often return an empty string? INLINE COMMENTS > kprocesslist_unix.cpp:142 > +int processNameStart = cmd.lastIndexOf('/', zeroIndex); > +if (processNameStart == -1) { > +processNameStart = 0; if it's

D21901: Calendar events: allow plugins to show event details

apol added inline comments. INLINE COMMENTS > calendareventsplugin.h:236 > + * > + * @since 5.60 > + */ should be since 5.61 now REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D21901 To: dvratil, #frameworks, mart, apol Cc: ngraham, broulik, kde-

D21901: Calendar events: allow plugins to show event details

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D21901 To: dvratil, #frameworks, mart, apol Cc: ngraham, broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bru

D22425: personsmodel: Add phoneNumber

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R307 KPeople BRANCH personsmodel-phoneNumber (branched from master) REVISION DETAIL https://phabricator.kde.org/D22425 To: jbbgameich, #plasma:_mobile, #kde_pim, apol

D22339: Make sure solid backends are reentrant

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R245:00abb4839abe: Make sure solid backends are reentrant (authored by apol). REPOSITORY R245 Solid CHANGES SINCE LAST

D22425: personsmodel: Add phoneNumber

apol added a comment. Other than that LGTM INLINE COMMENTS > personsmodel.h:60 > +UserRole = Qt::UserRole + 0x1000, ///< in case it's needed to > extend, use this one to start from > +PhoneNumberRole > }; Put it after GroupsRole REPOSITORY R307 KPeople REVISION DETA

D22339: Make sure solid backends are reentrant

apol added a comment. In D22339#494252 , @bruns wrote: > The invalidation has to be done per thread then as well, which you don't do. See fstabmanager.cpp As you can see in fstabmanager.cpp:40, FstabWatcher::instance() stays a singleton.

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D22375 To: sitter, cfeck, apol Cc: ngraham, kossebau, broulik, kde-frameworks-devel, apol,

D21782: Add a warning dialog with details, continue, and cancel button

apol accepted this revision. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21782 To: chinmoyr, #vdg, #frameworks, dfaure, ngraham, apol Cc: mreeves, ngraham, GB_2, kde-frameworks-devel, LeGast00n, michaelh, bruns

D22339: Make sure solid backends are reentrant

apol added a comment. In D22339#494142 , @bruns wrote: > How do you guarantee *each thread local* copy now is connected to the right signals, i.e. the socket notifier for the mtab and inotify for fstab? each backend will create things sep

D22387: Allow KAutostart to be constructed using an absolute path

This revision was automatically updated to reflect the committed changes. Closed by commit R309:93107a9532e9: Allow KAutostart to be constructed using an absolute path (authored by apol). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22387?vs=61535&id=61559

D22387: Allow KAutostart to be constructed using an absolute path

apol added a dependent revision: D22390: ksmserver/autostart: remove qstandardpaths queries. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D22387 To: apol, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22387: Allow KAutostart to be constructed using an absolute path

apol retitled this revision from "Allow the instance to be constructed using an absolute path" to "Allow KAutostart to be constructed using an absolute path". REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D22387 To: apol, #frameworks Cc: kde-frameworks-devel, LeGast00

D22387: Allow the instance to be constructed using an absolute path

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY If we already have found the service we need to autostart, it's a waste to strip the full

D22235: PoC: asynchronous initialization of Solid::UDisks backend

apol abandoned this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D22235 To: apol Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22370: Simplify previous-/nextActivity code in kactivities-cli

apol accepted this revision. REPOSITORY R6 KActivities BRANCH kactivities-cli-simplify (branched from master) REVISION DETAIL https://phabricator.kde.org/D22370 To: muesli, ivan, davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22362: Port keystates to use QtWayland's generator

apol added a comment. As discussed in the Plasma sprint. Removes some boilerplate code and turns it into C++ overrides. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D22362 To: apol, #kwin Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22362: Port keystates to use QtWayland's generator

apol updated this revision to Diff 61478. apol added a comment. --debug REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22362?vs=61477&id=61478 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22362 AFFECTED FILES CMakeLists.txt src/cli

D22362: Port keystates to use QtWayland's generator

apol created this revision. apol added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Saves us some of the boilerplate code TEST PLAN The plasmoid still works REPOSITORY R127 KW

D22317: Fix type names casing

apol added a comment. In D22317#492656 , @vatra wrote: > Just out of curiosity, why don't you use the cmake toolchain from Android NDK ? is located in ndk-bundle/build/cmake/android.toolchain.cmake We could consider it. Our toolchain pred

D22339: Make sure solid backends are reentrant

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Solid will create different backends for each separate thread but then some backends will

D22317: Fix type names casing

This revision was automatically updated to reflect the committed changes. Closed by commit R240:70ae7cff8bc7: Fix type names casing (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22317?vs=61304&id=61334 REVISION DETAIL https:/

D22258: Improve plugin caching

This revision was automatically updated to reflect the committed changes. Closed by commit R242:21227e0f989a: Improve plugin caching (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22258?vs=61122&id=61333 REVISION DETAIL

D22317: Fix type names casing

apol created this revision. apol added reviewers: Frameworks, Android. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It's supposed to be uppercase, cmake was warning about

D22314: Don't try to generate python bindings for kmodifierkeyinfoprovider_p.h

apol accepted this revision. apol added a comment. In D22314#492011 , @dfaure wrote: > Makes sense to me - this is private API anyway - but that makes me wonder why Aleix added it explicitly in commit 0fe2990dbad992a4

D22241: KModifierKeyInfo: we are sharing the internal implementation

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R273:7ecff22e7215: KModifierKeyInfo: we are sharing the internal implementation (authored by apol). REPOSITORY R273 KGuiA

D22241: KModifierKeyInfo: we are sharing the internal implementation

apol added a comment. Landing because it works and we want it in before the freeze. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D22241 To: apol, broulik Cc: davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22281: Do not crash if the inner file wants to be bigger than QByteArray max size

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D22281 To: aacid, apol Cc: apol, dfaure, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22275: [Svg] Fix porting error from QRegExp::exactMatch

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22275 To: broulik, #plasma, apol Cc: kde-frameworks-devel, ndavis, LeGast00n, michaelh, ngraham, bruns

D22267: ContainmentAction: Fix loading from KPlugin

This revision was automatically updated to reflect the committed changes. Closed by commit R242:46f0da45c655: ContainmentAction: Fix loading from KPlugin (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22267?vs=61136&id=61

D22147: Better use of Qt APIs in Plasma::Theme

apol added a comment. In D22147#490887 , @ndavis wrote: > I've compiled this with the latest commits, but the problem hasn't gone away. Try removing `.cache/plasma-svgelements-default_v5.60.0` and `.cache/plasma_theme_default_v5.60.0.kca

D22265: KPluginMetaData: use Q_DECLARE_METATYPE

This revision was automatically updated to reflect the committed changes. Closed by commit R244:318b0e752429: KPluginMetaData: use Q_DECLARE_METATYPE (authored by apol). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22265?vs=61131&id=61151 REVISION DETAI

D22267: ContainmentAction: Fix loading from KPlugin

apol added a dependent revision: D22268: Port containmentActions to use KPlugin instead of KService. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22267 To: apol, #plasma, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22267: ContainmentAction: Fix loading from KPlugin

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY At the moment it was enabled in the PluginLoader but we were not using it anywhere.

D22265: KPluginMetaData: use Q_DECLARE_METATYPE

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY This way it can be used with QVariant. REPOSITORY R244 KCoreAddons BRANCH master REV

D22258: Improve plugin caching

apol updated this revision to Diff 61122. apol added a comment. addressed comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22258?vs=61113&id=61122 BRANCH caches REVISION DETAIL https://phabricator.kde.org/D22258 AFFECTED FIL

D22147: Better use of Qt APIs in Plasma::Theme

apol added inline comments. INLINE COMMENTS > broulik wrote in svg.cpp:313 > Oh, I think the `static` might be the culprit, I didn't realize the `status` > and `ratio` were changing. Sorry Fixed https://commits.kde.org/plasma-framework/e3c6c2731eb272ca4f66e7836281992fb1f90e04 REPOSITORY R24

D22257: performance, Qt API

This revision was automatically updated to reflect the committed changes. Closed by commit R290:8e9fea2bc0bf: performance, Qt API (authored by apol). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22257?vs=61112&id=61121 REVISION DETAIL https://phabricator.

D22258: Improve plugin caching

apol marked 3 inline comments as done. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D22258 To: apol, #plasma, davidedmundson Cc: davidedmundson, mart, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22241: KModifierKeyInfo: we are sharing the internal implementation

apol added a comment. In D22241#490562 , @broulik wrote: > I don't think any of these changes are ABI-compatible? Yes it is, we're just modifying the size of a private class. Also this was never released yet. REPOSITORY R273 KGuiAd

D22258: Improve plugin caching

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Extend the plasmoid startup cache to DataEngines and ContaimentActions. Include a cache for s

D22257: performance, Qt API

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Use proper appending API Don't look-up twice REPOSITORY R290 KPackage BRANCH master

D22250: get rid of blockSignals

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R296 KDeclarative BRANCH blocksignals REVISION DETAIL https://phabricator.kde.org/D22250 To: mart, #plasma, apol Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngr

D22241: KModifierKeyInfo: we are sharing the internal implementation

apol created this revision. apol added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Use data types that will only destroy it when necessary. REPOSITORY R273 KGuiAddons BRANCH

D22235: PoC: asynchronous initialization of Solid::UDisks backend

apol planned changes to this revision. apol added a comment. This breaks solid, needs to notify about the new devices somehow. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D22235 To: apol Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22235: PoC: asynchronous initialization of Solid::UDisks backend

apol created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY There's a bunch of blocking calls in the construction of the backend that shouldn't be necessary. TEST PLAN Tests pass RE

D22216: RFC: Use wayland-protocols

apol added a comment. Big +1. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D22216 To: zzag, #kwin, #frameworks Cc: apol, romangg, asturmlechner, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22147: Better use of Qt APIs in Plasma::Theme

This revision was automatically updated to reflect the committed changes. Closed by commit R242:6c692309edf7: Better use of Qt APIs in Plasma::Theme (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22147?vs=60932&id=61009

D22147: Better use of Qt APIs in Plasma::Theme

apol updated this revision to Diff 60932. apol marked an inline comment as done. apol added a comment. address fvogt's comment REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22147?vs=60875&id=60932 BRANCH arcpatch-D22147 REVISION DETA

D22147: Better use of Qt APIs in Plasma::Theme

apol marked 3 inline comments as done. apol added inline comments. INLINE COMMENTS > fvogt wrote in svg.cpp:317 > It really does not look that way as you're immediately using captures after > that. > > If that's really what you want (which I doubt), it should be > `sizeHintedKeyExpr.isValid()`

D22147: Better use of Qt APIs in Plasma::Theme

apol added inline comments. INLINE COMMENTS > fvogt wrote in svg.cpp:317 > `isValid` is always true, you probably want to use `hasMatch` instead. > > This is not obvious, I only noticed this because I debugged this error before > (https://phabricator.kde.org/D17359) Please note this is only to

D22147: Better use of Qt APIs in Plasma::Theme

apol updated this revision to Diff 60875. apol added a comment. address logic, no artifacts REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22147?vs=60840&id=60875 BRANCH arcpatch-D22147 REVISION DETAIL https://phabricator.kde.org/D2

D22156: RFC: Add wayland-protocols find module

apol added a comment. LGTM +1 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22156 To: zzag, #kwin, #frameworks Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, bencreasy, michaelh, ngraham, bruns

D22147: Better use of Qt APIs in Plasma::Theme

apol marked 3 inline comments as done. apol added inline comments. INLINE COMMENTS > broulik wrote in theme.cpp:106 > Can we clean up all of this custom refcounting by using a `QSharedPointer`? Implemented with QSharedData. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https:/

D22147: Better use of Qt APIs in Plasma::Theme

apol updated this revision to Diff 60840. apol marked an inline comment as done. apol added a comment. Address kai's comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22147?vs=60802&id=60840 BRANCH master REVISION DETAIL https

D22147: Better use of Qt APIs in Plasma::Theme

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Try not to access hashes repeatedly. QRegExp -> QRegularExpression. REPOSITORY

D22108: [TabBar] Remove exterior margins

apol added a comment. Makes sense to me, but why are the computer icons different? ^^' REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22108 To: filipf, #vdg, #plasma, ngraham Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22093: Don't show progress window for jobs that don't report progress

apol added a comment. I think it's valuable information that the job is in progress. How about making the progress bar indeterminate? https://doc.qt.io/qt-5/qml-qtquick-controls2-progressbar.html#indeterminate-prop REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator

D22061: Add a logging category for logs warnings

apol added a comment. The patch looks good to me. I see that you're just doing KDesktopFile, but there's many others available, can you port the rest too? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks Cc: apol, kde-frameworks-deve

D22061: Add a logging category for logs warnings

apol added inline comments. INLINE COMMENTS > CMakeLists.txt:19 > +IDENTIFIER KCONF_DESKTOP_LOG > +CATEGORY_NAME kf5.kconfig.desktop) > + This is for KF5ConfigCore, I'd call it kf5.kconfig.core. REPOSITORY R237 KConfig REVISION

D22061: Add a logging category for logs warnings

apol added inline comments. INLINE COMMENTS > kdesktopfile.h:27 > > +#include > +Q_DECLARE_LOGGING_CATEGORY(kconfigLoggingDesktop) Use ecm_qt_declare_logging_category from cmake. This should never be in header files too, or it would spill on applications otherwise. See for example how it's

D22047: Fix translation of actiondisplay

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. okay REPOSITORY R495 Purpose Library BRANCH unfuckup REVISION DETAIL https://phabricator.kde.org/D22047 To: nicolasfella, apol, aacid Cc: pino, kde-frameworks-devel, LeGast00n, michaelh

D13150: Add ellipsis where appropriate

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH ellipsis REVISION DETAIL https://phabricator.kde.org/D13150 To: nicolasfella, #vdg, apol, ngraham Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngr

D13150: Add ellipsis where appropriate

apol added a comment. X-Purpose-Action won't get translations. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13150 To: nicolasfella, #vdg, apol, ngraham Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, bruns

D20193: Expose locked keystates on KModifierKeyInfo when on wayland

apol abandoned this revision. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D20193 To: apol, romangg, dfaure Cc: alexeymin, zzag, romangg, dfaure, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21989: Don't show error message if sharing is cancelled by the user

apol accepted this revision. REPOSITORY R495 Purpose Library BRANCH noerror REVISION DETAIL https://phabricator.kde.org/D21989 To: nicolasfella, apol, ngraham Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

This revision was automatically updated to reflect the committed changes. Closed by commit R127:71cbb548e0ad: Proof of concept of a wayland protocol to allow the keystate dataengine to work (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20191?vs=55913&id=60325#toc REP

D20443: Move to runtime the decision to use x11 or not

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R273:0fe2990dbad9: Move to runtime the decision to use x11 or not (authored by apol). REPOSITORY R273 KGuiAddons CHANGES

D21967: Fix warning when reading plugin metadata

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Improving the string like Albert says could make sense. Also porting to qCDebug. :) REPOSITORY R495 Purpose Library BRANCH warning REVISION DETAIL https://phabricator.kde.org/D21967 To

D19646: Redesign config pages

apol accepted this revision. REPOSITORY R495 Purpose Library BRANCH arcpatch-D19646 REVISION DETAIL https://phabricator.kde.org/D19646 To: nicolasfella, #vdg, apol, ngraham Cc: abetts, ltoscano, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21788: Make Plasma::Svg::elementRect a bit leaner

This revision was automatically updated to reflect the committed changes. Closed by commit R242:097f0e83e7bf: Make Plasma::Svg::elementRect a bit leaner (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21788?vs=59837&id=602

D20193: Expose locked keystates on KModifierKeyInfo when on wayland

apol edited the summary of this revision. apol edited the test plan for this revision. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D20193 To: apol Cc: dfaure, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D20443: Move to runtime the decision to use x11 or not

apol updated this revision to Diff 60135. apol added a comment. rebase REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20443?vs=55915&id=60135 BRANCH wayland_keystate REVISION DETAIL https://phabricator.kde.org/D20443 AFFECTED FILES src/CMakeList

D21923: Replace old kconfig_compiler_kf5 references to kconfig_compiler

apol added a comment. That doesn't look alright: https://phabricator.kde.org/source/kconfig/browse/master/src/kconfig_compiler/kconfig_compiler.cpp$1768 We are still including the _kf5 postfix. Also note the executable still is called kconfig_compiler_kf5 REPOSITORY R237 KConfig

D21788: Make Plasma::Svg::elementRect a bit leaner

apol added a comment. ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21788 To: apol, #plasma, #frameworks Cc: bruns, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

apol added a comment. In D21369#480148 , @albertvaka wrote: > If I understand correctly, the only reason to use KContacts here is so we can use its PhoneNumber type. We could change it to a QString? It is a string now, the advantage of u

D21788: Make Plasma::Svg::elementRect a bit leaner

apol marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21788 To: apol, #plasma, #frameworks Cc: bruns, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D21788: Make Plasma::Svg::elementRect a bit leaner

apol updated this revision to Diff 59837. apol added a comment. static const to be sure that QRegularExpression is only initialised once REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21788?vs=59772&id=59837 BRANCH master REVISION DET

D19732: [KWidgetAddons] Fix build with Qt 5.13

apol closed this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D19732 To: matthieugras, apol Cc: mlaurent, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D19732: [KWidgetAddons] Fix build with Qt 5.13

apol added a subscriber: mlaurent. apol added a comment. No, @mlaurent sent a similar patch and since he doesn't ask for review it went unnoticed. commit 57a1ac06fdd712bb39de30d2a0323c8c04d9d5e0 Author: Laurent

D21788: Make Plasma::Svg::elementRect a bit leaner

apol added inline comments. INLINE COMMENTS > bruns wrote in svg.cpp:123 > Are you sure about this? As far as I can see: > > `QRegularExpression::QRegularExpression(QString pattern)` default constructs > a `QRegularExpressionPrivate`, which sets `dirty(true)`. > > Calling `QRE::globalMatch()`

D21788: Make Plasma::Svg::elementRect a bit leaner

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > bruns wrote in svg.cpp:123 > Are you sure you uploaded the right diff? No const static, Q_ASSERT ... static isn't necessary, QRegularExpression already has internal regex compilation optimisations we can levera

D21788: Make Plasma::Svg::elementRect a bit leaner

apol updated this revision to Diff 59772. apol added a comment. Prefer a QRegularExpression to QRegExp REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21788?vs=59746&id=59772 BRANCH master REVISION DETAIL https://phabricator.kde.org/

D21788: Make Plasma::Svg::elementRect a bit leaner

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Don't double-access maps Don't construct ids more times than necessary. Make reg

D21618: Allow QtQuick applets and wallpapers to defer UiReadyConstraint

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thought about it a bit more, it should be okay. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D21618 To: davidedmundson, #plasma,

D20984: Add ECMAddQmlModule

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH addinstallqmlplugin REVISION DETAIL https://phabricator.kde.org/D20984 To: kossebau, #plasma, apol Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, bencreasy

D21344: Port to ECMAddQmlModule

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I like it :) REPOSITORY R242 Plasma Framework (Library) BRANCH porttoECMInstallQmlModules REVISION DETAIL https://phabricator.kde.org/D21344 To: kossebau, #plasma, apol Cc: apol, kde-fr

D21481: Don't notify about changing to the same state it was at

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:52124c663e34: Don't notify about changing to the same state it was at (authored by apol). REPOSITORY R242 Plasma Fra

D21481: Don't notify about changing to the same state it was at

apol added a comment. Been running it since and no replies, I'll land it. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21481 To: apol, #plasma Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21767: Automatically set version of desktopthemes packages to KF5_VERSION

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH autoversionfordesktopthemes REVISION DETAIL https://phabricator.kde.org/D21767 To: kossebau, #plasma, ltoscano, apol Cc: kde-frameworks-devel, LeGast00n, michael

D21400: Downgrade KDEWebKit from Tier 3 to Porting Aids

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R300 KDEWebKit BRANCH master REVISION DETAIL https://phabricator.kde.org/D21400 To: vkrause, apol Cc: apol, asturmlechner, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21660: simplify conditions and remove audio dependency for win32

apol added a comment. I'd say you're not simplifying it, you're changing the logic. This needs to be reflected in the commit message. INLINE COMMENTS > CMakeLists.txt:93 > endif() > endif() > +endif() indentation is wrong. REPOSITORY R289 KNotifications REVISION DETAIL https://p

D21618: Allow QtQuick applets and wallpapers to defer UiReadyConstraint

apol added a comment. I wonder if that's the right API to use from QML, I guess it's fine but marking something as successful by assigning null could feel odd? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21618 To: davidedmundson, #plasma Cc: a

D21618: Allow QtQuick applets and wallpapers to defer UiReadyConstraint

apol added a dependent revision: D21619: Wallpaper: delay calling UIReady until the image is actually loaded. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21618 To: davidedmundson, #plasma Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraha

D21618: Allow QtQuick applets and wallpapers to defer UiReadyConstraint

apol added a comment. +1 LGTM REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21618 To: davidedmundson, #plasma Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21565: phabricator: Fix fallthrough in switch

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH phab-fix-fallthrough REVISION DETAIL https://phabricator.kde.org/D21565 To: aspotashev, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21502: [PlasmaComponents3] Vertically center button text as well

apol added inline comments. INLINE COMMENTS > Button.qml:56 > Layout.fillWidth: !icon.visible > +Layout.fillHeight: !icon.visible > visible: text.length > 0 With it being a RowLayout, shouldn't fillHeight be always true? REPOSITORY R242 Plasma Framework (

D21480: Pass fully-qualified arguments and return values to moc

This revision was automatically updated to reflect the committed changes. Closed by commit R242:f631aec33faf: Pass fully-qualified arguments and return values to moc (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21480?vs

<    3   4   5   6   7   8   9   10   11   12   >