Re: Review Request 112525: Properly check for QtNetwork/QSslSocket

Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112525: Properly check for QtNetwork/QSslSocket

QT_INCLUDES, it's not available for Qt5. I have no idea why we didn't trigger that before. Diffs - staging/kde4support/src/ConfigureChecks.cmake 578277c Diff: http://git.reviewboard.kde.org/r/112525/diff/ Testing --- Thanks, Aleix Pol Gonzalez

Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

:50 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/ --- (Updated Sept. 4, 2013, 2:50 p.m

Review Request 112536: Move KUnitConversion to tier2

/r/112536/diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112536: Move KUnitConversion to tier2

/src/velocity.h staging/kunitconversion/src/velocity.cpp staging/kunitconversion/src/volume.h staging/kunitconversion/src/volume.cpp tier2/CMakeLists.txt 1f110e8 Diff: http://git.reviewboard.kde.org/r/112536/diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez

Re: Review Request 112536: Move KUnitConversion to tier2

staging/kunitconversion/src/volume.h staging/kunitconversion/src/volume.cpp tier2/CMakeLists.txt 1f110e8 Diff: http://git.reviewboard.kde.org/r/112536/diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel

Review Request 112545: Unify both meinproc5 binaries

. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112560: Remove KNotification dependency in KCompletion

staging/kcompletion/src/kcompletion.cpp bcd220a staging/kcompletion/src/khistorycombobox.cpp fe955a2 Diff: http://git.reviewboard.kde.org/r/112560/diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

don't need a ${variable}. BTW, are you sure that many publicly linked libraries are needed? - Aleix Pol Gonzalez On Sept. 7, 2013, 7:45 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 112545: Unify both meinproc5 binaries

/kdoctools/src/CMakeLists.txt 72bb06e staging/kdoctools/src/meinproc.cpp 5d476f6 staging/kdoctools/src/meinproc_simple.cpp 334f13f Diff: http://git.reviewboard.kde.org/r/112545/diff/ Testing --- Builds, both ways. Thanks, Aleix Pol Gonzalez

Re: Review Request 112560: Remove KNotification dependency in KCompletion

/kcompletion.cpp bcd220a staging/kcompletion/src/khistorycombobox.cpp fe955a2 Diff: http://git.reviewboard.kde.org/r/112560/diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 112570: Port some kde4_add_executable usages to add_executable

://git.reviewboard.kde.org/r/112570/diff/ Testing --- Builds, although it doesn't change much in linux. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112570: Port some kde4_add_executable usages to add_executable

:D - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112570/#review39569 --- On Sept. 6, 2013, 6:52 p.m., Aleix Pol Gonzalez

Re: Review Request 112545: Unify both meinproc5 binaries

--- On Sept. 9, 2013, 2:50 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112545

Re: Review Request 112545: Unify both meinproc5 binaries

) - staging/kdoctools/src/CMakeLists.txt 72bb06e staging/kdoctools/src/meinproc.cpp 5d476f6 staging/kdoctools/src/meinproc_simple.cpp 334f13f Diff: http://git.reviewboard.kde.org/r/112545/diff/ Testing --- Builds, both ways. Thanks, Aleix Pol Gonzalez

Re: Review Request 112545: Unify both meinproc5 binaries

) - staging/kdoctools/src/CMakeLists.txt 72bb06e staging/kdoctools/src/meinproc.cpp 5d476f6 staging/kdoctools/src/meinproc_simple.cpp 334f13f Diff: http://git.reviewboard.kde.org/r/112545/diff/ Testing --- Builds, both ways. Thanks, Aleix Pol Gonzalez

Review Request 112643: Adapt KCompletion so that it can be moved to tier2

5e8ae19 Diff: http://git.reviewboard.kde.org/r/112643/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112689: Drop KI18n dependencies in KCompletion

/khistorycombobox.cpp 2e53bd9 staging/kcompletion/src/klineedit.cpp 76ef377 Diff: http://git.reviewboard.kde.org/r/112689/diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Review Request 112696: Moves KNotifications to tier2

Diff: http://git.reviewboard.kde.org/r/112696/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112699: Reorganize KDocTools cmake code

it to FindKDocTools.cmake? Diffs - staging/kdoctools/CMakeLists.txt 7687f97 staging/kdoctools/src/CMakeLists.txt 6910ef7 Diff: http://git.reviewboard.kde.org/r/112699/diff/ Testing --- Builds Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel

Review Request 112700: Prepare KI18n to move to tier2

/CMakeLists.txt b64e2f7 staging/ki18n/KI18nConfig.cmake.in 3e90a9e Diff: http://git.reviewboard.kde.org/r/112700/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

Diff: http://git.reviewboard.kde.org/r/112697/diff/ Testing --- Still builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

. To reply, visit: http://git.reviewboard.kde.org/r/112697/#review39918 --- On Sept. 12, 2013, 5 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

ff0feb0 tier2/kauth/src/CMakeLists.txt 31f0f9c tier2/kcrash/src/CMakeLists.txt f340acd Diff: http://git.reviewboard.kde.org/r/112697/diff/ Testing --- Still builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/ --- (Updated Sept. 13, 2013, 10:33 a.m

Re: Review Request 112689: Drop KI18n dependencies in KCompletion

--- builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112699: Reorganize KDocTools cmake code

/112699/diff/ Testing --- Builds Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112699: Reorganize KDocTools cmake code

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112699/#review39917 --- On Sept. 12, 2013, 5:22 p.m., Aleix Pol Gonzalez wrote

Review Request 112715: Move KI18n to tier2

staging/ki18n/src/ktranscript_p.h staging/ki18n/src/kuitmarkup.h staging/ki18n/src/kuitmarkup.cpp staging/ki18n/src/kuitmarkup_p.h tier2/CMakeLists.txt f88af0c Diff: http://git.reviewboard.kde.org/r/112715/diff/ Testing --- Thanks, Aleix Pol Gonzalez

Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

/CMakeLists.txt ff0feb0 tier2/kauth/src/CMakeLists.txt 31f0f9c tier2/kcrash/src/CMakeLists.txt f340acd Diff: http://git.reviewboard.kde.org/r/112697/diff/ Testing --- Still builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing

Review Request 112717: Start adopting QCollator

/kstringhandler.cpp 2f192aa Diff: http://git.reviewboard.kde.org/r/112717/diff/ Testing --- Builds, affected tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 112717: Start adopting QCollator

://git.reviewboard.kde.org/r/112717/#review39986 --- On Sept. 13, 2013, 5:12 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 112717: Start adopting QCollator

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112717/#review40054 --- On Sept. 13, 2013, 5:55 p.m., Aleix Pol Gonzalez wrote

Review Request 112758: Move KCompletion to tier2

/kcompletionuitest.h staging/kcompletion/tests/kcompletionuitest.cpp staging/kcompletion/tests/klineedittest.h staging/kcompletion/tests/klineedittest.cpp tier2/CMakeLists.txt 51f093b Diff: http://git.reviewboard.kde.org/r/112758/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol

Re: Review Request 112759: sonnet - improve dependencies

://git.reviewboard.kde.org/r/112759/#comment29689 Seems like you should use ${REQUIRED_QT_VERSION} here too... no? - Aleix Pol Gonzalez On Sept. 16, 2013, 5:12 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 112717: Start adopting QCollator

concerns in a specific use of QCollator in this patch I can leave it out, but I think this should go in. Thoughts? - Aleix Pol Gonzalez On Sept. 13, 2013, 5:55 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/#review40184 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Sept

Re: Review Request 112519: trim KStyle

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112519/#review40185 --- Bump! what's the status of this? - Aleix Pol Gonzalez

Re: Review Request 112547: avoid creating jobs on urls with double slashes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112547/ --- (Updated Sept. 17, 2013, 11:14 a.m.) Status -- This change has been

Review Request 112772: Create an ecm_mark_as_autotest macro

://git.reviewboard.kde.org/r/112772/diff/ Testing --- Ported some tests in KF5, it worked. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112772: Create an ecm_mark_as_autotest macro

, 12:35 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112772/ --- (Updated Sept. 17, 2013, 12:35

Re: Review Request 112792: Move itemviews to tier2

people to upgrade their Qt repo. Pushing it now. - Aleix Pol Gonzalez On Sept. 18, 2013, 2:50 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112792

Re: Review Request 112792: Move itemviews to tier2

On Sept. 18, 2013, 2:58 p.m., Aleix Pol Gonzalez wrote: I was waiting for alex to send the meeting minutes telling people to upgrade their Qt repo. Pushing it now. It's pushed, sorry for the wait . - Aleix

Review Request 112795: Move KDocTools to tier2

, no tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112797: Bring back KStringHandler::naturalCompare()

/kstringhandler.h 442b97a tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 Diff: http://git.reviewboard.kde.org/r/112797/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 112717: Start adopting QCollator

On Sept. 18, 2013, 3:22 p.m., Mark Gaiser wrote: How RUDE to just commit this without a addressing the concerns Frank and i have. That is not appreciated! Aleix Pol Gonzalez wrote: Alright, maybe I didn't think this through. I'll un-deprecate and bring back the KStringHandler

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

/#review40289 --- On Sept. 18, 2013, 4:55 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797

Review Request 112803: Start cleaning up KDNSSD

to KDNSSD. Properly look-up Qt and KF5. After that I'll move it to staging. Diffs - dnssd/CMakeLists.txt 7f2620a Diff: http://git.reviewboard.kde.org/r/112803/diff/ Testing --- Builds, there are no tests. Thanks, Aleix Pol Gonzalez

Re: Review Request 112808: Port away from KDirWatch in KEmoticons (prior to splitting)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112808/#review40316 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Sept

Re: Review Request 112795: Move KDocTools to tier2

Diff: http://git.reviewboard.kde.org/r/112795/diff/ Testing --- Builds, no tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 112803: Start cleaning up KDNSSD

, there are no tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/#review40350 --- Maybe you should add a note in KDE5Porting.html? - Aleix Pol

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/#review40351 --- Maybe you should add a note in KDE5Porting.html? - Aleix Pol

Review Request 112825: Adopt modules directory structure

dnssd/servicetypebrowser.h dnssd/settings.kcfgc dnssd/src/CMakeLists.txt PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112825/diff/ Testing --- Builds, there are no tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing

Re: Review Request 112828: Provide ecm_add_unit_test() and ecm_add_multiple_unit_tests()

the nomenclature we're using so far in KF5. Additionally, an executable has many unit tests inside. - Aleix Pol Gonzalez On Sept. 19, 2013, 3:57 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit

Review Request 112830: Start splitting KParts

kutils/CMakeLists.txt 0cb281d staging/xmlgui/tests/krichtexteditor/CMakeLists.txt 372856b Diff: http://git.reviewboard.kde.org/r/112830/diff/ Testing --- Builds Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks

Review Request 112840: Port from kde4_add_plugin to add_library

://git.reviewboard.kde.org/r/112840/diff/ Testing --- Builds, nothing seem to have changed. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112825: DNSSD: Adopt modules directory structure

: http://git.reviewboard.kde.org/r/112825/diff/ Testing --- Builds, there are no tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112882: Split remaining KUtils into kcmutils and kprintutils

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112882/#review40492 --- Ship it! \o/ - Aleix Pol Gonzalez On Sept. 22, 2013, 12:32

Re: Review Request 112882: Split remaining KUtils into kcmutils and kprintutils

On Sept. 23, 2013, 11:18 a.m., Kevin Ottens wrote: staging/kprintutils/KPrintUtilsConfig.cmake.in, line 3 http://git.reviewboard.kde.org/r/112882/diff/1/?file=191209#file191209line3 I surely has other dependencies. Most things in staging have faulty *Config.cmake.in files, I'd say

Re: Review Request 112830: Start splitting KParts

9e7806d kutils/CMakeLists.txt 0cb281d staging/xmlgui/tests/krichtexteditor/CMakeLists.txt 372856b Diff: http://git.reviewboard.kde.org/r/112830/diff/ Testing --- Builds Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

/112797/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112897: Move itemviews to tier1

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112897/#review40576 --- Ship it! Ship It! - Aleix Pol Gonzalez On Sept. 23, 2013

Re: Review Request 112829: Move XMLGUI to Tier3

) Aleix Pol Gonzalez wrote: Building standalone is not one of the things required by http://community.kde.org/Frameworks/Epics/Splitting_kdelibs . Also it's something we probably want to deal with at a later stage, when we decide how each should be distributed. Aurélien Gâteau

Review Request 112900: Prepare KDNSSD for moving

://git.reviewboard.kde.org/r/112900/diff/ Testing --- Builds, there are no tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112829: Move XMLGUI to Tier3

) Aleix Pol Gonzalez wrote: Building standalone is not one of the things required by http://community.kde.org/Frameworks/Epics/Splitting_kdelibs . Also it's something we probably want to deal with at a later stage, when we decide how each should be distributed. Aurélien Gâteau

Review Request 112901: Remove weird cmake indirections

/CMakeLists.txt 0cb281d staging/kemoticons/src/core/CMakeLists.txt f7fb463 staging/ktextwidgets/src/CMakeLists.txt 4787c10 Diff: http://git.reviewboard.kde.org/r/112901/diff/ Testing --- Everything still builds Thanks, Aleix Pol Gonzalez ___ Kde

Re: Review Request 112907: Move KEmoticons framework to tier3

it much easier to read such patches where there are moves and changes. Also, why did you change from Qt5::Xml to Qt5Xml? - Aleix Pol Gonzalez On Sept. 23, 2013, 5:42 p.m., David Gil Oliva wrote: --- This is an automatically generated e

Re: Review Request 112907: Move KEmoticons framework to tier3

it much easier to read such patches where there are moves and changes. Also, why did you change from Qt5::Xml to Qt5Xml? - Aleix Pol Gonzalez On Sept. 23, 2013, 5:42 p.m., David Gil Oliva wrote: --- This is an automatically generated e

Review Request 112902: Start cleanup for kdewebkit

--- Builds, there are no tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112900: Prepare KDNSSD for moving

-publicservice.cpp 119c5a8 dnssd/src/mdnsd-publicservice.cpp 2a775fa dnssd/src/servicemodel.cpp 348db57 staging/kde4support/CMakeLists.txt 24ee457 Diff: http://git.reviewboard.kde.org/r/112900/diff/ Testing --- Builds, there are no tests. Thanks, Aleix Pol Gonzalez

Re: Review Request 112900: Prepare KDNSSD for moving

dnssd/src/mdnsd-publicservice.cpp 2a775fa dnssd/src/servicemodel.cpp 348db57 Diff: http://git.reviewboard.kde.org/r/112900/diff/ Testing --- Builds, there are no tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde

Review Request 112919: Prepare KParts for the move

kparts/statusbarextension.cpp kparts/textextension.h kparts/textextension.cpp staging/kde4support/src/CMakeLists.txt 5dc206d Diff: http://git.reviewboard.kde.org/r/112919/diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112921: Adjust CMakeLists.txt files in KEmoticons (prior to splitting)

/CMakeLists.txt http://git.reviewboard.kde.org/r/112921/#comment29960 Make it REQUIRED? find_package(Qt5Xml REQUIRED) Looks good to me. - Aleix Pol Gonzalez On Sept. 24, 2013, 10:09 p.m., David Gil Oliva wrote

Re: Review Request 112926: Prepare ktextwidgets' cmake for splitting

://git.reviewboard.kde.org/r/112926/#comment29971 Maybe pass REQUIRED_QT_VERSION? - Aleix Pol Gonzalez On Sept. 25, 2013, 9:09 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 112927: Move KTextWidgets to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112927/#review40751 --- Ship it! Ship It! - Aleix Pol Gonzalez On Sept. 25, 2013

Re: Review Request 112932: Update superbuild to include all tiered libraries

about superbuild. Why do we need to specify the dependencies from superbuild? Shouldn't they depend on the Config.cmake files? - Aleix Pol Gonzalez On Sept. 25, 2013, 12:54 p.m., David Edmundson wrote: --- This is an automatically

Review Request 112942: Move KDNSSD to tier2

/servicetypebrowser.h dnssd/src/settings.kcfgc staging/kde4support/src/ConfigureChecks.cmake 21cac3f tier2/CMakeLists.txt 73175b3 Diff: http://git.reviewboard.kde.org/r/112942/diff/ Testing --- Builds, no tests Thanks, Aleix Pol Gonzalez ___ Kde

Review Request 112943: Move KParts to tier3

/plugin_spellcheck.rc kparts/tests/testmainwindow.h kparts/tests/testmainwindow.cpp tier3/CMakeLists.txt 5ac107a Diff: http://git.reviewboard.kde.org/r/112943/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks

Review Request 112944: Move KDEWebKit to tier3

/kwebwallet.h kdewebkit/src/kwebwallet.cpp staging/kde4support/src/ConfigureChecks.cmake 21cac3f tier3/CMakeLists.txt 5ac107a Diff: http://git.reviewboard.kde.org/r/112944/diff/ Testing --- Builds, there are no tests Thanks, Aleix Pol Gonzalez

Re: Review Request 112942: Move KDNSSD to tier2

. 25, 2013, 5:35 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112942/ --- (Updated Sept. 25, 2013

Re: Review Request 112957: Move KMimeTypeChooser from kio to KWidgetAddons

sugguested. - Aleix Pol Gonzalez On Sept. 26, 2013, 11:11 a.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112957

Re: Review Request 112940: Move all kio tests to the appropriate location

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112940/#review40879 --- Ship it! Ship It! - Aleix Pol Gonzalez On Sept. 26, 2013

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

://git.reviewboard.kde.org/r/112984/#comment30112 Use KEMOTICONS_DEPRECATED I don't really understand what's better from ::save instead of ::saveTheme. Is it just the naming? They seem to do the same. - Aleix Pol Gonzalez On Sept. 28, 2013, 9:19 p.m., David Gil Oliva wrote

Re: Review Request 112942: Move KDNSSD to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112942/#review41021 --- ping? - Aleix Pol Gonzalez On Sept. 25, 2013, 5:35 p.m

Re: Review Request 112901: Remove weird cmake indirections

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112901/#review41023 --- ping? - Aleix Pol Gonzalez On Sept. 24, 2013, 1:32 p.m

Re: Review Request 112964: Prepare KPrintUtils cmake stuff

://git.reviewboard.kde.org/r/112964/#comment30118 Only half our modules are like this so far, should we add this as a KF5 module requirement? staging/kprintutils/CMakeLists.txt http://git.reviewboard.kde.org/r/112964/#comment30113 Why are you removing these? - Aleix Pol Gonzalez On Sept. 27, 2013, 9:15

Re: Review Request 112964: Prepare KPrintUtils cmake stuff

an improvement. - Aleix Pol Gonzalez On Sept. 27, 2013, 9:15 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964

Review Request 113008: Clean up KWallet before moving to its own tier

Description --- Makes a bit of sense of the cmake, adds a TODO. Diffs - staging/kwallet/src/CMakeLists.txt 0aaa39e staging/kwallet/src/kwallet_mac.cpp d5d522b Diff: http://git.reviewboard.kde.org/r/113008/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez

Re: Review Request 113045: Prepare KCMUtils for move to tier3

://git.reviewboard.kde.org/r/113045/#comment30168 Why removing these? - Aleix Pol Gonzalez On Oct. 2, 2013, 8:06 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045

Re: Review Request 112828: Provide ecm_add_unit_test() and ecm_add_multiple_unit_tests()

need to get this going... - Aleix Pol Gonzalez On Sept. 19, 2013, 3:57 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112828

Re: Review Request 113048: Move KPrintUtils to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113048/#review41108 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 2, 2013, 10

Re: Review Request 113046: Move kconfigwidgets to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113046/#review41109 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 2, 2013, 8

Re: Review Request 113050: Use enum for KMessageBox return types

, but isn't this going to break source compatibility? - Aleix Pol Gonzalez On Oct. 2, 2013, 2:43 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113050

Re: Review Request 113052: Remove find_package calls from root kdelibs

tier3/kprintutils/src/CMakeLists.txt 5d797d1 tier3/ktextwidgets/CMakeLists.txt a8b4aa9 tier3/xmlgui/CMakeLists.txt a45d86d tier3/xmlgui/src/CMakeLists.txt 9677b0a Diff: http://git.reviewboard.kde.org/r/113052/diff/ Testing --- Everything keeps building Thanks, Aleix Pol

Re: Review Request 112942: Move KDNSSD to tier2

dnssd/src/servicebrowser.h dnssd/src/servicemodel.h dnssd/src/servicemodel.cpp dnssd/src/servicetypebrowser.h dnssd/src/settings.kcfgc tier2/CMakeLists.txt 73175b3 Diff: http://git.reviewboard.kde.org/r/112942/diff/ Testing --- Builds, no tests Thanks, Aleix Pol

Re: Review Request 113052: Remove find_package calls from root kdelibs

--- Everything keeps building Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112901: Remove weird cmake indirections

--- Everything still builds Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113039: Remove unused includes from KDESu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113039/#review41141 --- Ship it! Woa amazing :) +1 - Aleix Pol Gonzalez On Oct. 1

  1   2   3   4   5   6   7   8   9   10   >