Re: Review Request 118690: Introduce a KLocalizedTranslator

t could provide something to reduce the boilerplate > elements (addContextToMonitor and language change events). > > Albert Astals Cid wrote: > I can understand the use case for dynamically loaded .ui files. > > For static ones I thought we were using "uic -tr i18n"

Re: Review Request 118838: Don't require mandatory subText in tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118838/#review60512 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 19, 2014

Re: Review Request 118366: Porting keyboard module to Framework5

7;t do coding style changes while coding. - Aleix Pol Gonzalez On June 19, 2014, 6:48 p.m., shivam makkar wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 112449: Move KUnitConverter files to src/

://git.reviewboard.kde.org/r/112449/diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112450: Move KScanDialog to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112450/#review39171 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Sept. 2

Review Request 112451: Actually install the modules in the ecm attic

x27;m missing something. Please tell me if that's the case. Diffs - CMakeLists.txt 5a22f85 attic/modules/CMakeLists.txt c832bed Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Po

Re: Review Request 112451: Actually install the modules in the ecm attic

to be polished... Why does it even have a CMakeLists.txt file then? - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/#review39177 --

Review Request 112457: Start cleanup of KDocTools

has no tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112401: Let ki18n report the list of available translations of the application

approved. - Aleix Pol Gonzalez On Sept. 1, 2013, 12:22 p.m., Chusslove Illich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 112451: Actually install the modules in the ecm attic

Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112457: Start cleanup of KDocTools

locally, I'll push it once we have a way to find DocBook from ECM. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112457/#review39242 --------

Review Request 112485: Cleaning up KCompletion

Diffs - staging/kcompletion/src/klineedit.cpp b2b430d staging/kcompletion/src/config-kcompletion.h.cmake 35b64a2 staging/kcompletion/src/CMakeLists.txt f08a47d staging/kcompletion/src/klineedit_p.h 4d3cfbc Diff: http://git.reviewboard.kde.org/r/112485/diff/ Testing --- builds,

Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

-modules/FindDocBookXSL.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

. Diffs (updated) - attic/modules/FindDocBookXML.cmake 26053bf attic/modules/FindDocBookXSL.cmake ab93c9e Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Pol Gonzalez

Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

for KF5. Diffs (updated) - attic/modules/FindDocBookXML.cmake attic/modules/FindDocBookXSL.cmake Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Pol Gonzalez ___ Kde

Re: Review Request 112525: Properly check for QtNetwork/QSslSocket

Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112525: Properly check for QtNetwork/QSslSocket

t use QT_INCLUDES, it's not available for Qt5. I have no idea why we didn't trigger that before. Diffs - staging/kde4support/src/ConfigureChecks.cmake 578277c Diff: http://git.reviewboard.kde.org/r/112525/diff/ Testing --- Thanks, Ale

Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions

ed e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/#review39371 ----------- On Sept. 4, 2013, 2:50 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an a

Review Request 112536: Move KUnitConversion to tier2

/r/112536/diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112536: Move KUnitConversion to tier2

/src/velocity.h staging/kunitconversion/src/velocity.cpp staging/kunitconversion/src/volume.h staging/kunitconversion/src/volume.cpp tier2/CMakeLists.txt 1f110e8 Diff: http://git.reviewboard.kde.org/r/112536/diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez

Re: Review Request 112536: Move KUnitConversion to tier2

staging/kunitconversion/src/volume.h staging/kunitconversion/src/volume.cpp tier2/CMakeLists.txt 1f110e8 Diff: http://git.reviewboard.kde.org/r/112536/diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel

Re: Review Request 112525: Properly check for QtNetwork/QSslSocket

board.kde.org/r/112525/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112545: Unify both meinproc5 binaries

ilds, both ways. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112570: Port some kde4_add_executable usages to add_executable

/tests/CMakeLists.txt 5e0d46e Diff: http://git.reviewboard.kde.org/r/112570/diff/ Testing --- Builds, although it doesn't change much in linux. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Review Request 112560: Remove KNotification dependency in KCompletion

staging/kcompletion/src/kcompletion.cpp bcd220a staging/kcompletion/src/khistorycombobox.cpp fe955a2 Diff: http://git.reviewboard.kde.org/r/112560/diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

ing Qt5::Core and you don't need a ${variable}. BTW, are you sure that many publicly linked libraries are needed? - Aleix Pol Gonzalez On Sept. 7, 2013, 7:45 p.m., David Edmundson wrote: > > --- > This is an autom

Re: Review Request 112545: Unify both meinproc5 binaries

staging/kdoctools/src/CMakeLists.txt 72bb06e staging/kdoctools/src/meinproc.cpp 5d476f6 staging/kdoctools/src/meinproc_simple.cpp 334f13f Diff: http://git.reviewboard.kde.org/r/112545/diff/ Testing --- Builds, both ways. Thanks, Ale

Re: Review Request 112560: Remove KNotification dependency in KCompletion

letion/src/kcompletion.cpp bcd220a staging/kcompletion/src/khistorycombobox.cpp fe955a2 Diff: http://git.reviewboard.kde.org/r/112560/diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-framew

Re: Review Request 112570: Port some kde4_add_executable usages to add_executable

://git.reviewboard.kde.org/r/112570/diff/ Testing --- Builds, although it doesn't change much in linux. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112570: Port some kde4_add_executable usages to add_executable

---------- On Sept. 6, 2013, 6:52 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112570/

Re: Review Request 112545: Unify both meinproc5 binaries

tomatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112545/#review39690 ------- On Sept. 9, 2013, 2:50 p.m., Aleix Pol Gonzalez wrote: > > --- > This i

Re: Review Request 112545: Unify both meinproc5 binaries

ns? Diffs (updated) - staging/kdoctools/src/CMakeLists.txt 72bb06e staging/kdoctools/src/meinproc.cpp 5d476f6 staging/kdoctools/src/meinproc_simple.cpp 334f13f Diff: http://git.reviewboard.kde.org/r/112545/diff/ Testing --- Builds, both ways. Thanks,

Re: Review Request 112545: Unify both meinproc5 binaries

Diffs (updated) - staging/kdoctools/src/CMakeLists.txt 72bb06e staging/kdoctools/src/meinproc.cpp 5d476f6 staging/kdoctools/src/meinproc_simple.cpp 334f13f Diff: http://git.reviewboard.kde.org/r/112545/diff/ Testing --- Builds, both ways. Thanks, Ale

Review Request 112643: Adapt KCompletion so that it can be moved to tier2

5e8ae19 Diff: http://git.reviewboard.kde.org/r/112643/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112689: Drop KI18n dependencies in KCompletion

kcompletion/src/khistorycombobox.cpp 2e53bd9 staging/kcompletion/src/klineedit.cpp 76ef377 Diff: http://git.reviewboard.kde.org/r/112689/diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-framework

Review Request 112696: Moves KNotifications to tier2

Diff: http://git.reviewboard.kde.org/r/112696/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112699: Reorganize KDocTools cmake code

name it to FindKDocTools.cmake? Diffs - staging/kdoctools/CMakeLists.txt 7687f97 staging/kdoctools/src/CMakeLists.txt 6910ef7 Diff: http://git.reviewboard.kde.org/r/112699/diff/ Testing --- Builds Thanks, Aleix Pol Gonzalez ___ Kde-framew

Review Request 112700: Prepare KI18n to move to tier2

/CMakeLists.txt b64e2f7 staging/ki18n/KI18nConfig.cmake.in 3e90a9e Diff: http://git.reviewboard.kde.org/r/112700/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

sts.txt f340acd Diff: http://git.reviewboard.kde.org/r/112697/diff/ Testing --- Still builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

ed e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/#review39918 --- On Sept. 12, 2013, 5 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically ge

Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

/CMakeLists.txt ff0feb0 tier2/kauth/src/CMakeLists.txt 31f0f9c tier2/kcrash/src/CMakeLists.txt f340acd Diff: http://git.reviewboard.kde.org/r/112697/diff/ Testing --- Still builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel m

Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

--------- On Sept. 13, 2013, 10:33 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112697/ &

Re: Review Request 112689: Drop KI18n dependencies in KCompletion

diff/ Testing --- builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112699: Reorganize KDocTools cmake code

board.kde.org/r/112699/diff/ Testing --- Builds Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112699: Reorganize KDocTools cmake code

h it being in a pre-repo-split stage. I think that we have to think about how we want applications to use KDocTools eventually, as we do with our C++ code. - Aleix --- This is an automatically generated e-mail. To reply, visit: ht

Review Request 112715: Move KI18n to tier2

staging/ki18n/src/ktranscript_p.h staging/ki18n/src/kuitmarkup.h staging/ki18n/src/kuitmarkup.cpp staging/ki18n/src/kuitmarkup_p.h tier2/CMakeLists.txt f88af0c Diff: http://git.reviewboard.kde.org/r/112715/diff/ Testing --- Thanks, Aleix Pol Gonzalez

Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

kauth/autotests/CMakeLists.txt ff0feb0 tier2/kauth/src/CMakeLists.txt 31f0f9c tier2/kcrash/src/CMakeLists.txt f340acd Diff: http://git.reviewboard.kde.org/r/112697/diff/ Testing --- Still builds. Thanks, Aleix Pol Gonzalez ___ Kde-framework

Review Request 112717: Start adopting QCollator

b/text/kstringhandler.h 1b08f6f tier1/kcoreaddons/src/lib/text/kstringhandler.cpp 2f192aa Diff: http://git.reviewboard.kde.org/r/112717/diff/ Testing --- Builds, affected tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel ma

Re: Review Request 112717: Start adopting QCollator

-- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112717/#review39986 ------- On Sept. 13, 2013, 5:12 p.m., Aleix Pol Gonzalez wrote: > > -

Re: Review Request 112717: Start adopting QCollator

inghandlertest.cpp d12f086 tier1/kcoreaddons/src/lib/text/kstringhandler.h 1b08f6f tier1/kcoreaddons/src/lib/text/kstringhandler.cpp 2f192aa Diff: http://git.reviewboard.kde.org/r/112717/diff/ Testing --- Builds, affected tests pass. Thanks, Aleix Pol Gonzalez _

Re: Review Request 112717: Start adopting QCollator

you configure Qt, if ICU is found it will be used. I think it's ok to assume that Dolphin on linux users will all have ICU available. I wouldn't hack around the posix backends, personally. - Aleix --- This is an aut

Review Request 112758: Move KCompletion to tier2

/kcompletionuitest.h staging/kcompletion/tests/kcompletionuitest.cpp staging/kcompletion/tests/klineedittest.h staging/kcompletion/tests/klineedittest.cpp tier2/CMakeLists.txt 51f093b Diff: http://git.reviewboard.kde.org/r/112758/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol

Re: Review Request 112759: sonnet - improve dependencies

ttp://git.reviewboard.kde.org/r/112759/#comment29689> Seems like you should use "${REQUIRED_QT_VERSION}" here too... no? - Aleix Pol Gonzalez On Sept. 16, 2013, 5:12 p.m., Michael Palimaka wrote: > > --- > This is an automatic

Re: Review Request 112717: Start adopting QCollator

s any concerns in a specific use of QCollator in this patch I can leave it out, but I think this should go in. Thoughts? - Aleix Pol Gonzalez On Sept. 13, 2013, 5:55 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatic

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/#review40184 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Sept

Re: Review Request 112519: trim KStyle

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112519/#review40185 --- Bump! what's the status of this? - Aleix Pol Gonzalez

Re: Review Request 112662: Clean up CMakeLists.txt and prepare for splitting KEmoticons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112662/#review40186 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Sept

Re: Review Request 112760: Add test program for KMessageBox methods

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112760/#review40187 --- Ship it! Tests are always good, aren't they? :) - Alei

Re: Review Request 112547: avoid creating jobs on urls with double slashes

> On Sept. 8, 2013, 1:13 p.m., David Faure wrote: > > Please test https://codereview.qt-project.org/64926, it should make this > > fix unnecessary. Quietness suggests that this review can be closed probably. Is that the case? - Aleix -

Re: Review Request 112547: avoid creating jobs on urls with double slashes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112547/ --- (Updated Sept. 17, 2013, 11:14 a.m.) Status -- This change has been d

Review Request 112772: Create an ecm_mark_as_autotest macro

http://git.reviewboard.kde.org/r/112772/diff/ Testing --- Ported some tests in KF5, it worked. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112772: Create an ecm_mark_as_autotest macro

.kde.org/r/112772/#review40240 ----------- On Sept. 17, 2013, 12:35 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://gi

Re: Review Request 112792: Move itemviews to tier2

people to upgrade their Qt repo. Pushing it now. - Aleix Pol Gonzalez On Sept. 18, 2013, 2:50 p.m., Aurélien Gâteau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 112792: Move itemviews to tier2

> On Sept. 18, 2013, 2:58 p.m., Aleix Pol Gonzalez wrote: > > I was waiting for alex to send the meeting minutes telling people to > > upgrade their Qt repo. > > > > Pushing it now. It's pushed,

Review Request 112795: Move KDocTools to tier2

, no tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112717: Start adopting QCollator

naive to localization). - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112717/#review40277 --- On Sept. 18, 2013,

Review Request 112797: Bring back KStringHandler::naturalCompare()

/text/kstringhandler.h 442b97a tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 Diff: http://git.reviewboard.kde.org/r/112797/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-

Re: Review Request 112717: Start adopting QCollator

> On Sept. 18, 2013, 3:22 p.m., Mark Gaiser wrote: > > How RUDE to just commit this without a addressing the concerns Frank and i > > have. That is not appreciated! > > Aleix Pol Gonzalez wrote: > Alright, maybe I didn't think this through. I'll

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

erated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review40289 ------- On Sept. 18, 2013, 4:55 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatica

Review Request 112803: Start cleaning up KDNSSD

KDNSSD. Properly look-up Qt and KF5. After that I'll move it to staging. Diffs - dnssd/CMakeLists.txt 7f2620a Diff: http://git.reviewboard.kde.org/r/112803/diff/ Testing --- Builds, there are no tests. Thanks, Aleix Pol Gon

Re: Review Request 112808: Port away from KDirWatch in KEmoticons (prior to splitting)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112808/#review40316 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Sept

Re: Review Request 112808: Port away from KDirWatch in KEmoticons (prior to splitting)

> On Sept. 19, 2013, 7:48 a.m., David Faure wrote: > > staging/kemoticons/src/core/kemoticons.cpp, line 110 > > > > > > This test is already done internally in QFSW, remove it from here. But then, it keeps output

Re: Review Request 112795: Move KDocTools to tier2

--------- On Sept. 18, 2013, 3:34 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112795/ >

Re: Review Request 112772: Create an ecm_mark_as_autotest macro

n wrote: > I just played around with adding a new macro to replace the > _UNIT_TESTS macros which are in every autotests directory: > http://paste.kde.org/p11adaa09/ > > Could something like this be considered for ecm? If so I will add some > documentation and create a

Re: Review Request 112803: Start cleaning up KDNSSD

-- Builds, there are no tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/#review40350 --- Maybe you should add a note in KDE5Porting.html? - Aleix Pol

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/#review40351 --- Maybe you should add a note in KDE5Porting.html? - Aleix Pol

Review Request 112825: Adopt modules directory structure

dnssd/servicetypebrowser.h dnssd/settings.kcfgc dnssd/src/CMakeLists.txt PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112825/diff/ Testing --- Builds, there are no tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing

Re: Review Request 112828: Provide ecm_add_unit_test() and ecm_add_multiple_unit_tests()

s the nomenclature we're using so far in KF5. Additionally, an executable has many unit tests inside. - Aleix Pol Gonzalez On Sept. 19, 2013, 3:57 p.m., Alexander Richardson wrote: > > --- > This is an automatically generat

Review Request 112830: Start splitting KParts

sts.txt 9e7806d kutils/CMakeLists.txt 0cb281d staging/xmlgui/tests/krichtexteditor/CMakeLists.txt 372856b Diff: http://git.reviewboard.kde.org/r/112830/diff/ Testing --- Builds Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list

Review Request 112839: Make add_library(...MODULE...) a proper replacement for kde4_add_plugin

http://git.reviewboard.kde.org/r/112839/diff/ Testing --- Builds. Changed locally some kde4_add_plugin to add_library( MODULE ) and they didn't have a prefix. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde

Review Request 112840: Port from kde4_add_plugin to add_library

ttp://git.reviewboard.kde.org/r/112840/diff/ Testing --- Builds, nothing seem to have changed. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112825: DNSSD: Adopt modules directory structure

Diff: http://git.reviewboard.kde.org/r/112825/diff/ Testing --- Builds, there are no tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112882: Split remaining KUtils into kcmutils and kprintutils

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112882/#review40492 --- Ship it! \o/ - Aleix Pol Gonzalez On Sept. 22, 2013, 12:32

Re: Review Request 112882: Split remaining KUtils into kcmutils and kprintutils

> On Sept. 23, 2013, 11:18 a.m., Kevin Ottens wrote: > > staging/kprintutils/KPrintUtilsConfig.cmake.in, line 3 > > > > > > I surely has other dependencies. Most things in staging have faulty *Config.cmake.in files

Re: Review Request 112830: Start splitting KParts

kross/ui/CMakeLists.txt 9e7806d kutils/CMakeLists.txt 0cb281d staging/xmlgui/tests/krichtexteditor/CMakeLists.txt 372856b Diff: http://git.reviewboard.kde.org/r/112830/diff/ Testing --- Builds Thanks, Aleix Pol Gonzalez ___ Kde-framewor

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

org/r/112797/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112897: Move itemviews to tier1

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112897/#review40576 --- Ship it! Ship It! - Aleix Pol Gonzalez On Sept. 23, 2013

Re: Review Request 112829: Move XMLGUI to Tier3

first (which is why I switched to kconfigwidgets) > > Aleix Pol Gonzalez wrote: > Building standalone is not one of the things required by > http://community.kde.org/Frameworks/Epics/Splitting_kdelibs . > > Also it's something we probably want to deal with at a later

Review Request 112900: Prepare KDNSSD for moving

.txt 24ee457 Diff: http://git.reviewboard.kde.org/r/112900/diff/ Testing --- Builds, there are no tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112829: Move XMLGUI to Tier3

first (which is why I switched to kconfigwidgets) > > Aleix Pol Gonzalez wrote: > Building standalone is not one of the things required by > http://community.kde.org/Frameworks/Epics/Splitting_kdelibs . > > Also it's something we probably want to deal with at a later

Review Request 112901: Remove weird cmake indirections

kutils/CMakeLists.txt 0cb281d staging/kemoticons/src/core/CMakeLists.txt f7fb463 staging/ktextwidgets/src/CMakeLists.txt 4787c10 Diff: http://git.reviewboard.kde.org/r/112901/diff/ Testing --- Everything still builds Thanks, Aleix Pol Gonzalez _

Re: Review Request 112829: Move XMLGUI to Tier3

> On Sept. 23, 2013, 3:10 p.m., Aurélien Gâteau wrote: > > It does not build standalone for me, linking fails: > > http://paste.kde.org/p05c23fa6 > > > > I tried to do xmlgui last week, but realized it needs more work on the > > underlying frameworks first (which is why I switched to kconfigwi

Re: Review Request 112907: Move KEmoticons framework to tier3

it much easier to read such patches where there are moves and changes. Also, why did you change from Qt5::Xml to Qt5Xml? - Aleix Pol Gonzalez On Sept. 23, 2013, 5:42 p.m., David Gil Oliva wrote: > > --- > This is an automatically

Re: Review Request 112907: Move KEmoticons framework to tier3

it much easier to read such patches where there are moves and changes. Also, why did you change from Qt5::Xml to Qt5Xml? - Aleix Pol Gonzalez On Sept. 23, 2013, 5:42 p.m., David Gil Oliva wrote: > > --- > This is an automatically

Review Request 112902: Start cleanup for kdewebkit

--- Builds, there are no tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112900: Prepare KDNSSD for moving

txt 47587af dnssd/src/avahi-publicservice.cpp 119c5a8 dnssd/src/mdnsd-publicservice.cpp 2a775fa dnssd/src/servicemodel.cpp 348db57 staging/kde4support/CMakeLists.txt 24ee457 Diff: http://git.reviewboard.kde.org/r/112900/diff/ Testing --- Builds, there are no tests.

Re: Review Request 112900: Prepare KDNSSD for moving

vahi-publicservice.cpp 119c5a8 dnssd/src/mdnsd-publicservice.cpp 2a775fa dnssd/src/servicemodel.cpp 348db57 Diff: http://git.reviewboard.kde.org/r/112900/diff/ Testing --- Builds, there are no tests. Thanks, Aleix Pol Gonzalez ___ Kde-fra

Re: Review Request 112902: Start cleanup for kdewebkit

ttp://git.reviewboard.kde.org/r/112902/#review40642 --- On Sept. 23, 2013, 5:27 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 112902: Start cleanup for kdewebkit

: http://git.reviewboard.kde.org/r/112902/diff/ Testing --- Builds, there are no tests. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

<    1   2   3   4   5   6   7   8   9   10   >