D29534: Implement scroll and drag adjustment of values for SpinBox control

abetts added a comment. +1 from me! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma Cc: abetts, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29070: add alligator icon

abetts added a comment. Look great! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29070 To: mbruchert, tfella, #vdg, ndavis Cc: abetts, ognarb, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

abetts added a comment. My opinion on this patch from the beginning has been that it really doesn't add much more than was there before. Visually, it clutters the UI. The icon selected for it might also not be visually appealing or meaningful enough. I believe there should be a different app

D21813: RFC: Consider adding more padding to the desktop theme

abetts added a comment. +1 on visuals! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21813 To: filipf, #plasma, #vdg, ngraham, broulik Cc: abetts, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21511: Make falkon icon a real SVG

abetts added a comment. +1 REPOSITORY R266 Breeze Icons BRANCH falkon (branched from master) REVISION DETAIL https://phabricator.kde.org/D21511 To: ndavis, #vdg, #falkon, abetts, drosca Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21315: Dolphin-style view modes in the file dialog

abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham, #vdg Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D20977: [KeySequenceItem] Make the clear button have the same height as shortcut button

abetts added a comment. +1 REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20977 To: filipf, #vdg, ngraham, #frameworks, broulik, davidedmundson Cc: abetts, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

abetts added a comment. +1 REVISION DETAIL https://phabricator.kde.org/D20181 To: JJRcop, broulik, #plasma, ngraham Cc: abetts, cfeck, apol, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D20672: Add an icon for Thunderbolt KCM

abetts added a comment. Sorry for coming this late into the conversation. I was wondering if the spear in the bolt can be changed to be horizontal? It would be more visually consistent with the angle that the lightning bold is. The back of the arrow |>, that needs to be horizontal. REPOSITO

D20342: Update KDE logo to be closer to original

abetts added a comment. +1 REPOSITORY R266 Breeze Icons BRANCH update-kde-logo-to-be-closer-to-original (branched from master) REVISION DETAIL https://phabricator.kde.org/D20342 To: GB_2, #vdg, #kde_promo, filipf Cc: abetts, ndavis, filipf, ngraham, #kde_promo, kde-frameworks-devel, #

D20367: Add alternatives icon

abetts added a comment. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20367 To: GB_2, #vdg Cc: abetts, ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

D20226: Add "notifications" and "notifications-disabled" icons

abetts added a comment. In D20226#442854 , @GB_2 wrote: > Move bell's pendulum Love it! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20226 To: GB_2, #plasma, #vdg Cc: abetts, ngraham, #vdg, kde-framework

D20226: Add "notifications" and "notifications-disabled" icons

abetts added a comment. The line that goes across almost completely removes the bell's pendulum to the right. Maybe move the pendulum closer to the center so that even when there is that red strike line, the user can still make out that it is a notification bell REPOSITORY R266 Breeze Ico

D19646: Redesign KDE Connect and bluetooth config pages

abetts added a comment. Could there be a checkmark box or some way to indicate what selection has been made? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D19646 To: nicolasfella, #vdg, apol, ngraham Cc: abetts, ltoscano, kde-frameworks-devel, michaelh, ngr

D19557: Update css

abetts added a comment. +1 REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19020: [breeze-icons] Revamp system.svgz

abetts added a comment. Well, maybe it is time to call it and be done. I don't think we are going to please everyone right now. Maybe our best option is to have you, as the proponent of this idea, make the decision after long debate. REPOSITORY R242 Plasma Framework (Library) REVISION DET

D19020: [breeze-icons] Revamp system.svgz

abetts added a comment. I think the icon is pretty much there. Maybe the label can help the meaning come across. What about: "Enter User" "Type User" "Change User" REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #pl

D19047: [GridDelegate] Fix long labels blending into each other

abetts added a comment. +1 REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D19047 To: filipf, #frameworks, ngraham, #vdg Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

abetts added a comment. In D19020#412431 , @ngraham wrote: > The only problem here that is that the label says "Type User" but the icon depicts a password field. Maybe the icon could depict both a username field and a password field, one on top

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

abetts added a comment. In D19020#412418 , @rooty wrote: > In D19020#412412 , @abetts wrote: > > > Would an icon like this work? > > > > F6615590: Group 3.png

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

abetts added a comment. Would an icon like this work? F6615590: Group 3.png Just trying to get to a good final icon for typing your user. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: roo

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. In D18649#405368 , @ngraham wrote: > One thing I will not do in this patch is synthesize a fake button that has different behaviors from the standard button. If there's a problem with our buttons we need to fix it everywh

D18738: Add ebook thumbnailer

abetts added a comment. +1 Awesome! REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18738 To: broulik, #plasma, #vdg Cc: abetts, ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanue

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. In D18649#405214 , @ngraham wrote: > I want to point out that the original problem was not that the buttons lacked contrast, but that the //icons// were illegible with a variety of thumbnail contents. This problem is 100%

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. In D18649#405209 , @GB_2 wrote: > In D18649#405200 , @ngraham wrote: > > > Here's how the buttons look when placed fully inline and with the color scheme inverted: > > >

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. In D18649#405200 , @ngraham wrote: > Here's how the buttons look when placed fully inline and with the color scheme inverted: > > F6587345: Screenshot_20190204_130444.png > >

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. In D18649#405180 , @ngraham wrote: > In D18649#405179 , @abetts wrote: > > > I was thinking of dark buttons mostly. Something along these lines\ > > > > https://dribbble.co

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. In D18649#405162 , @GB_2 wrote: > I think it looks good. I was thinking of dark buttons mostly. Something along these lines\ https://dribbble.com/shots/5204192-Buttons-Dark I think the breeze default color

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. In D18649#405156 , @ngraham wrote: > Use square buttons and put them on the bottom right, not the top right The functionality seems great! We might need to do more padding with labels. Is there any way we can style

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. Just some variations on Nate's idea: https://dribbble.com/shots/4981650-Floating-Button-Micro-Interaction https://dribbble.com/shots/2619684-Expense-Floating-Button The floating buttons is a very Android-unique feature. Not sure we are copying that if we

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. In D18649#405082 , @ngraham wrote: > In D18649#405081 , @abetts wrote: > > > In D18649#405078 , @ngraham wrote: > > > > > Use ro

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. In D18649#405078 , @ngraham wrote: > Use round buttons in the corner rather than an inline toolbar What does it look like now? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 T

D18675: Use different "None" item icon in grid view KCMs

abetts added a comment. > Seems like a bit too much. BTW, this is the Plasma login splash and there is no text output when disabled. I see, maybe the label could be more descriptive then? Use something like "Black", or "No splash"? REPOSITORY R296 KDeclarative REVISION DETAIL https

D18675: Use different "None" item icon in grid view KCMs

abetts added a comment. In D18675#404090 , @ngraham wrote: > Hmm, I like the use of an X here, but I'm not sure the red color is appropriate. Nothing is being removed, deleted, or destroyed. I agree with you here. It may seem that you are

D18686: Add Cursors KCM icon

abetts added a comment. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18686 To: ndavis, #vdg Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

abetts added a comment. In D18533#403337 , @ndavis wrote: > F6581666: Screenshot_20190201_131014.png > > The colors are not very good, but this is what I was talking about. It looks more 3D. I w

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. In D18649#403336 , @ngraham wrote: > In D18649#40 , @abetts wrote: > > > I love that implementation. I bounced back ideas with Marco long ago about this. I think we should

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. I love that implementation. I bounced back ideas with Marco long ago about this. I think we should implement it in all other KCMs with similar representations. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #pl

D17905: [frameworks] Do not use light font styles for headings (1/3)

abetts added a comment. I don't have a problem with the font as much as I have a problem with the spacing for the title labels. They seem to be super close to checkboxes, other labels and controls. There should be a clear separation. Adding a heavier font to the title label helps a lot but b

D17906: [kirigami] Do not use light font styles for headings (2/3)

abetts added a comment. Goodness, I think this is all about taste. I am more on the side that it looks good. It visually prioritizes hierarchy with labels. @mart Does it just look bad for you or do you think this will cause issues somewhere else? REPOSITORY R169 Kirigami BRANCH no-light

D17609: KTextEditor: Add action for static word wrap

abetts added a comment. +1 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17609 To: loh.tar, #ktexteditor, #vdg Cc: abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

abetts added a comment. +1 for improving visuals REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17461 To: ngraham, #vdg, #frameworks, cullmann, cfeck Cc: abetts, apol, cfeck, cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

D17496: Change network/web color icons to consistent style

abetts added a comment. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17496 To: ndavis, #vdg Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D17469: applications-games icon for dark theme

abetts added a comment. It's looking good. I would say change the last tone to a tad lighter. The gray has too much black in it. I would probably move the hue to the yellow side. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17469 To: guoyunhe, #breeze, #vdg,

D17459: SearchBar: Add Cancel button to stop long running tasks

abetts added a comment. I would probably not make the button that big, but I think it is useful REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17459 To: loh.tar, #ktexteditor, #vdg Cc: abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngr

D17350: Add the missing api for multilevel KCMs to control the columns

abetts added a comment. Instead of connection name, would it make sense to call it, network name instead? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D17350 To: mart, #plasma, jgrulich Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D17309: Add flashlight action icons

abetts added a comment. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17309 To: trickyricky26, #vdg Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

abetts added a comment. In D17220#368147 , @trickyricky26 wrote: > I think the distinction is useful. The off icons would then look like this: > F6446567: microphone-sensitivity-high-22.svg.png > > F

D16951: Add mouse button icons

abetts added a comment. Looks good to me +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, bruns

D16653: Use the new `drive-harddisk-root` icon for the root volume

abetts accepted this revision. abetts added a comment. Minor detail with great impact. Thank you for the work. REPOSITORY R245 Solid BRANCH arcpatch-D16653 REVISION DETAIL https://phabricator.kde.org/D16653 To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns, abetts Cc: abetts, k

D16395: Update the "About KDE" text

abetts added a comment. +1 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D16395 To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo Cc: xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D16395: Update the "About KDE" text

abetts added a comment. > KDE has created the friendly and powerful Plasma desktop environment KDE has created the most friendly and powerful desktop environment, Plasma. > KDE is a cooperative enterprise in which no single entity KDE is a disaggregated development community not

D15973: Add a 'Properties' entry in the places panel context menu

abetts retitled this revision from "Add a 'Propreties' entry in the places panel context menu" to "Add a 'Properties' entry in the places panel context menu". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15973 To: thsurrel, #frameworks, #vdg, ngraham, dfaure Cc: dfaure,

D15935: Don't show an emblem for mounted disks, only unmounted disks

abetts accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH no-mounted-emblem (branched from master) REVISION DETAIL https://phabricator.kde.org/D15935 To: ngraham, #vdg, abetts Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15821: fix pop up positioning for !compositing mode

abetts added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15821 To: mvourlakos, #plasma, broulik, davidedmundson Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15814: show all borders for pop up windows in a dock

abetts added a comment. In D15814#85 , @mvourlakos wrote: > In D15814#10 , @ngraham wrote: > > > A big improvement! Even better would be a little downward-pointing triangle pointing to the

D15814: show all borders for pop up windows in a dock

abetts added a comment. I like both ideas so far. Great improvement! Would it be too hard to create the pointer triangle? I think it make so much sense. That way the poppup doesn't feel like it is floating out of nowhere. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https:

D11880: Add firewall-config and firewall-applet icons

abetts added a comment. Love it! Ship it! +100 REPOSITORY R266 Breeze Icons BRANCH firewalld-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg, #breeze, ngraham Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D15739: [Places panel] Don't show Root by default

abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15739 To: ngraham, #dolphin, #vdg Cc: abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15721: Make lock on plasmavault icon visible with breeze-dark

abetts added a comment. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15721 To: ndavis, #vdg Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D11880: Add firewall-config and firewall-applet icons

abetts added a comment. I solemnly approve! +1 REPOSITORY R266 Breeze Icons BRANCH firewalld-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg, #breeze, ngraham Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

abetts added a comment. Seems good to me. Guys? REPOSITORY R266 Breeze Icons BRANCH firewalld-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg, #breeze, ngraham Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michael

D11880: Add firewall-config and firewall-applet icons

abetts added a comment. If I understand right, there are three states of firewall security that you can be in. Maybe we could use the traffic lights metaphor and have green for low, yellow for medium and red for high? REPOSITORY R266 Breeze Icons BRANCH firewalld-icons (branched from ma

D15194: Draw a line separating PlasmaComponents tab bar from its content area

abetts added a comment. In D15194#328651 , @romangg wrote: > If there are more items than space available in the list a line is drawn already now to indicate that there are more items to come by scrolling down. Does this not conflict with the ne

D15591: Add Open Document thumbnailer

abetts added a comment. +1 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15591 To: broulik, #frameworks, #vdg, ngraham, kossebau, jtamate, fvogt, wbauer Cc: abetts, kde-frameworks-devel, kfm-devel, leinir, kossebau, jtamate, ngraham, feverfew, michaelh, spoorun

D15557: Improve "insufficient disk space" error messgae

abetts added a comment. In D15557#327094 , @ngraham wrote: > We can't use the words "file" or "move" since this part of the code can't know whether the user is moving or copying, or whether the thing being moved or copied is a file or a director

D15557: Improve "insufficient disk space" error messgae

abetts added a comment. I like the proposal already. I would just add other strings for perspective: - Cannot move file. File larger than remaining space. - Unable to move file, insufficient space remaining. REPOSITORY R241 KIO BRANCH improve-insufficient-disk-space-error-message (

D15071: Don't draw frames and shadows around images with transparency

abetts accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH thumbnail-frame-refinement (branched from master) REVISION DETAIL https://phabricator.kde.org/D15071 To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck, abetts Cc: anthonyfiero

D15240: Create a default wallet when user refuses to do so

abetts added a comment. In D15240#319850 , @ngraham wrote: > This strikes me as likely to cause intense frustration. Consider the following dramatized dialogue between a user and the computer: > > User: "Neat, I just set up this KDE plasma th

D15194: Draw a line separating PlasmaComponents tab bar from its content area

abetts added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15194 To: ngraham, #plasma, #vdg Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

abetts added a comment. In D14580#317289 , @mart wrote: > F6223394: Spectacle.k3.png > > in case the kcm wants to go multi columns (default off): > F6223399: Spectacle.l3.png

D14580: support for multi pages kcms

abetts added a comment. What does this look like now Marco? REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D14580 To: mart, #plasma, #frameworks Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15099: add a new property headerVisible

abetts added a comment. Thanks for the work Marco! REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D15099 To: mart, #plasma, #frameworks Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15071: Don't draw frames and shadows around images with an alpha channel

abetts added a comment. I support this 100% REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15071 To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck Cc: abetts, bruns, kde-frameworks-devel, michaelh, ngraham

D14810: Improve Widgets' removal and configure text

abetts accepted this revision. abetts added a comment. This revision is now accepted and ready to land. This patch is sensible, it saves some strings, space, and it is grammatically consistent. REPOSITORY R242 Plasma Framework (Library) BRANCH remove-this-widget (branched from master) R

D14810: Improve Widgets' removal and configure text

abetts added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14810 To: ngraham, #plasma, #vdg Cc: abetts, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14579: api for multi level kcms

abetts added a comment. Awesome! REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D14579 To: mart, #plasma, #frameworks Cc: abetts, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14640: Use appropriate icon for a cancel button that will ask for a new name

abetts accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH rename-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D14640 To: ngraham, #frameworks, #vdg, abetts Cc: abetts, broulik, dfaure, kde-frameworks-devel, micha

D14640: Use appropriate icon for a cancel button that will ask for a new name

abetts added a comment. In D14640#304428 , @ngraham wrote: > In D14640#304405 , @abetts wrote: > > > In D14640#304400 , @ngraham wrote: > > > > > Hmm, I

D14640: Use appropriate icon for a cancel button that will ask for a new name

abetts added a comment. In D14640#304400 , @ngraham wrote: > Hmm, I'm not sure a cancel button makes sense here because that would end the process of creating the folder. If you chose an invalid name, presumably you still want to create the fold

D14640: Use appropriate icon for a cancel button that will ask for a new name

abetts added a comment. Could the message have 2 buttons? A cancel and an "Enter a different name". That way, if the user inadvertently entered that reserved name can cancel the action still. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14640 To: ngraham, #framework

D13773: [KDirOperator] Use alternating background colors for multi-column views

abetts accepted this revision. abetts added a comment. This revision is now accepted and ready to land. Looks good! REPOSITORY R241 KIO BRANCH alternating-row-colors-for-list-style-views (branched from master) REVISION DETAIL https://phabricator.kde.org/D13773 To: ngraham, #frameworks

D13773: [KDirOperator] Use alternating background colors for list-style views

abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13773 To: ngraham, #frameworks, #vdg, #dolphin Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D13643: Add LabPlot project file icon

abetts added a comment. Oh great! I thought the team was looking for a logo. Then, I have nothing more to add. It looks great. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13643 To: mtrescott, #labplot, #vdg, #breeze Cc: abetts, asemke, ngraham, kde-framewor

D13643: Add LabPlot project file icon

abetts added a comment. My first impression is that it looks a lot like a file emblem. I would probably remove the background and keep only the logo. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13643 To: mtrescott, #labplot, #vdg, #breeze Cc: abetts, asemke

D13552: [Properties dialog] Improve some permissions-related strings

abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13552 To: ngraham, #frameworks, #vdg, #dolphin Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D13215: FrameSvg: Recache maskFrame if enabledBorders has been changed

abetts added a comment. What can we do to help this patch move forward @zzag ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13215 To: zzag, #plasma, #frameworks Cc: abetts, mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13215: Update sizes before generating frame svg background

abetts added a comment. +1 on this! Love it! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13215 To: zzag, #plasma, #frameworks Cc: abetts, mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D12992: New elisa icon

abetts added a comment. I think we are trying hard to accommodate and the elements are not lending themselves to turn them into an E with some musical tones. I reviewed a few music sheets looking for commonalities. I feel also that the icon is busy, it is trying really hard to tell you that

D12992: New elisa icon

abetts added a subscriber: andreask. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12992 To: lshoravi, #vdg, ngraham, #elisa Cc: andreask, kde-frameworks-devel, ssteffen, lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, ognarb, januz, ngraham, bruns, kmf,

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

abetts added a comment. In D12986#265687 , @rkflx wrote: > In my personal experience spending more time on a limited set of items leads to better results and less churn (as in reverting commits, number of iterations per patch etc.) than only lig

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

abetts added a comment. In D12986#265675 , @rkflx wrote: > In D12986#265666 , @ngraham wrote: > > > In D12986#265662 , @rkflx wrote: > > > > > Anyway,

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

abetts added a comment. In D12986#265552 , @ngraham wrote: > Like this? > > F5860366: Radiobutton version.png That looks really good IMHO. Somewhat unrelated, I have seen a few UIs recently that

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

abetts added a comment. In D12986#265235 , @rkflx wrote: > In D12986#265231 , @ngraham wrote: > > > Yeah, that makes sense. Suggestions welcome, of course. Is this any better? > > F5859259: After

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

abetts added a comment. In D12986#265231 , @ngraham wrote: > Yeah, that makes sense. Suggestions welcome, of course. Is this any better? > F5859259: After 2.png > > Still not super happy with "When lim

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

abetts added a comment. In D12986#265198 , @rkflx wrote: > I don't think putting whole phrases as a label before the checkbox works very well, and I would be surprised if that's what the HIG now recommends. I assume at most a single subject shou

D12895: WIP: Add KFileItemActionsPlugin

abetts added a comment. +1 REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D12895 To: broulik, #plasma, #vdg, apol Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D10937: Retouching of Screen Layout Selection OSD Icons

abetts added a comment. In D10937#260688 , @pstefan wrote: > In D10937#260289 , @abetts wrote: > > > In D10937#260277 , @ngraham wrote: > > > > > Someon

D10937: Retouching of Screen Layout Selection OSD Icons

abetts added a comment. In D10937#260277 , @ngraham wrote: > Someone will need to land the changes for you. I'd prefer a few more thumbs up first. @abetts, are you good with these? I am linking these a lot. I am "almost" there with the de

D12508: Make KMessageWidget match Kirigami inlineMessage's style

abetts added a comment. +1 on this! REPOSITORY R236 KWidgetsAddons BRANCH arcpatch-D12508 REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, cfeck Cc: broulik, anemeth, abetts, cfeck, mart, fabianr, elvisangelaccio, jnoack, #frameworks, michaelh, ngr

  1   2   >