D22617: Add icons for pagelayout options, as needed in Okular

davidhurka added a comment. I’m not sure whether I did everything correctly. If I did, this is too complicated. The guidelines in the community wiki and the HIG are missing:

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka created this revision. davidhurka added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidhurka requested review of this revision. REVISION SUMMARY This is my try to add the icons I requested in D21196#484674

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka added a subscriber: Okular. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

davidhurka added a comment. I assume that `fill="currentColor"` also doesn’t work as expected, fixing that now... REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg, ndavis Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n,

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

davidhurka updated this revision to Diff 62415. davidhurka added a comment. - Remove color attributes, which were added by scour-icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22617?vs=62411=62415 BRANCH add-icons-for-pagelayouts REVISION

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

davidhurka updated this revision to Diff 62411. davidhurka added a comment. - Fix id=current-color-scheme attributes which were removed by scour-icon. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22617?vs=62332=62411 BRANCH

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

davidhurka added a comment. What does `fill:currentColor` mean, by the way? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg, ndavis Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

davidhurka updated this revision to Diff 62602. davidhurka added a comment. - Add missing id=currentColorScheme to 24px versions of snap-page These snap-page.svg files weren’t in 16px nor 22px, so I forgot them when I replaced `type="text/css"` with `type="text/css"

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

davidhurka marked 2 inline comments as done. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg, ndavis, ngraham Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

davidhurka updated this revision to Diff 62603. davidhurka added a comment. - Add missing .ColorScheme-Text { to 24px versions of snap-page.svg And then the class name was missing, together with the opening brace: `.ColorScheme-Text {`. This is not a comfortable workflow... Would it

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka added a comment. In D22617#499767 , @ndavis wrote: > Nice work! > > I know a lot of monochrome icons currently use the bottom right position for the folded corner, but I think we should start using the top right. The bottom

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka updated this revision to Diff 62293. davidhurka added a comment. - Remove 24px icons - Flip snap-page icons vertically, so the corner fold is at the top-right - Make pagelayout-single link to snap-page - Flip pagelayout-* icons, except pagelayout-single REPOSITORY R266

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka updated this revision to Diff 62294. davidhurka added a comment. - Rename pagelayout-* to view-pages-* REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22617?vs=62293=62294 BRANCH add-icons-for-pagelayouts REVISION DETAIL

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka added a comment. What is the icons-dark directory good for? The icons in there are mostly just the same as in icons. And I’m a bit concerned that scour-icon removes the id="currentColorScheme" attribute from the stylesheet. How do I avoid that? REPOSITORY R266 Breeze Icons

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka added a comment. In D22617#500131 , @ndavis wrote: > I'll give the latest changes a proper review in a little while. > > In D22617#500046 , @davidhurka wrote: > > > What is the

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka added a comment. In D22617#499767 , @ndavis wrote: > Nice work! > > I know a lot of monochrome icons currently use the bottom right position for the folded corner, but I think we should start using the top right. The bottom right

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka added a comment. In D22617#500212 , @ndavis wrote: > In D22617#500031 , @davidhurka wrote: > > > I can’t follow you here. Centering the first page is a feature / technical detail of

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

davidhurka retitled this revision from "Add icons for pagelayout options, as needed in Okular" to "Add view-pages-* icons, as needed in Okular for page layout selection". davidhurka edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

davidhurka updated this revision to Diff 62332. davidhurka added a comment. - Adapt view-pages-facing and -facing-first-centered to use ndavis' suggested files REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22617?vs=62294=62332 BRANCH

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg, ndavis Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

davidhurka added a comment. By the way, the suggested stylesheet in https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Breeze does not follow https://hig.kde.org/style/icon.html as far as I can understand it. - Why does the stylesheet need a background? - How are the

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

davidhurka added a comment. In D22617#500361 , @ndavis wrote: > In D22617#500346 , @davidhurka wrote: > > > - Why does the stylesheet need a background? > > > You only need to add the classes

D22297: Add id="current-color-scheme" to collapse-all icons

davidhurka accepted this revision. davidhurka added a comment. This revision is now accepted and ready to land. Yes, problem solved. The icon is now visible with a dark color theme. Did not check anything else, someone with more knowledge about icons should do that. REPOSITORY R266

D22297: Add id="current-color-scheme" to collapse-all icons

davidhurka added a comment. (Added screenshots) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22297 To: nhiga, #vdg, davidhurka Cc: davidhurka, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22297: Add id="current-color-scheme" to collapse-all icons

davidhurka edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22297 To: nhiga, #vdg, davidhurka Cc: davidhurka, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D27983: Make find-location show a magnifier on a map, to be different to mark-location

davidhurka created this revision. davidhurka added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidhurka requested review of this revision. REVISION SUMMARY This changes find-location, and adds the 22px variant. BUG: 407061

D27983: Make find-location show a magnifier on a map, to be different to mark-location

davidhurka edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27983 To: davidhurka, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

T11950: Reduce the pain of working on monochrome Breeze icons

davidhurka added a comment. Whoops, this Task went past me //while// I created breeze-icon-cleaner . What a pity! I think with this tool, we can check the remaining four tasks of the TODO in the task description. Sounds optimistic?

D27557: Auto-generate 24px monochrome icons

davidhurka added a comment. In D27557#616831 , @sitter wrote: > > - if your script is doing a lot of stuff you may want to revise how the script works. specifically for this diff sed needs to iter all the content of all the SVGs

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

davidhurka added a comment. Now we have less than 130 icons which are different in icons/ and icons-dark/, and less than 100 icons which we should keep as dark version. Maybe we can keep event less. I have sorted them into two files. F8221155: dark_icons_to_keep.txt

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

davidhurka added a comment. @ngraham How’s your progress with the bash script? I’m currently trying to understand bash syntax. Maybe I can do it, if you don’t have done it already. TASK DETAIL https://phabricator.kde.org/T12855 To: davidhurka Cc: ndavis, ngraham, kde-frameworks-devel,

D29027: Move document corner fold to top right in two icons

davidhurka edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29027 To: davidhurka, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29027: Move document corner fold to top right in two icons

davidhurka retitled this revision from "Move document corner fold to top right in two icons This updates document-close in the sizes below 32px and gnumeric-link-internal to the new style. I forgot them in D28203. gnumeric-link-internal uses ButtonFocus." to "Move document corner fold to top

D29027: Move document corner fold to top right in two icons

davidhurka updated this revision to Diff 80707. davidhurka added a comment. - Use Highlight instead of ButtonFocus, Noah already decided that somewhere else REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29027?vs=80702=80707 BRANCH

D29027: Move document corner fold to top right in two icons

davidhurka edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29027 To: davidhurka, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29027: Move document corner fold to top right in two iconsThis updates document-close in the sizes below 32px and gnumeric-link-internal to the new style. I forgot them in D28203.gnumeric-link-intern

davidhurka created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidhurka requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH update-document-close REVISION DETAIL https://phabricator.kde.org/D29027 AFFECTED FILES

D29027: Move document corner fold to top right in two icons

davidhurka added a comment. I looked at the other gnumeric icons. Those which are not a symlink use fixed colors, while the linked icons use Highlight. I don’t see the point to use fixed colors. REPOSITORY R266 Breeze Icons BRANCH update-document-close REVISION DETAIL

T11950: Reduce the pain of working on monochrome Breeze icons

davidhurka added a comment. This is how my source file for find-location (D27983 ) looks in inkscape. F8174793: Screenshot_20200313_201936.png Would it be nice to post such screenshots in Revisions, instead

D28553: Rename stylesheet color ButtonFocus -> Highlight

davidhurka added a comment. Cuttlefish (Ubuntu release)? So that means all icons should be changed from Highlight to ButtonFocus? That would also affect colorful icons. Some of them have Highlight and ButtonFocus in the stylesheet, fortunately with the same color. REPOSITORY R266

D28553: Rename stylesheet color ButtonFocus -> Highlight

davidhurka abandoned this revision. davidhurka added a comment. Ok, then I’ll let you do it. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28553 To: davidhurka, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28553: Rename stylesheet color ButtonFocus -> Highlight

davidhurka created this revision. davidhurka added a reviewer: ndavis. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidhurka requested review of this revision. REVISION SUMMARY This fixes the 3 icons with blue elements, which I recently modified. I used

D27983: Make find-location show a magnifier on a map, to be different to mark-location

This revision was automatically updated to reflect the committed changes. Closed by commit R266:aff4a3e23d92: Make find-location show a magnifier on a map, to be different to mark-location (authored by davidhurka). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D28203: Move corner fold to top right in 24 icons

davidhurka updated this revision to Diff 79272. davidhurka added a comment. Rebase on an initial commit which points to D28203 , not D28204 . - link 32px document-preview-archive and document-preview - Move corner

D28203: Move corner fold to top right in 24 icons

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:2808396a7bb8: Move corner fold to top right in 24 icons (authored by davidhurka). REPOSITORY R266 Breeze Icons

D28203: Move corner fold to top right in 24 icons

davidhurka added a comment. I created revision D28204 accidentally when I tried to update this revision. That made my initial commit point to D28204 instead of D28203 , so I

D28203: Move corner fold to top right in 24 icons

davidhurka added a comment. @ndavis commited (excerpt): diff --git a/icons-dark/actions/22/document-export-ocal.svg b/icons-dark/actions/22/document-export-ocal.svg index 4bfca303..ace4fe41 12 --- a/icons-dark/actions/22/document-export-ocal.svg +++

D28561: Remove border from format-border-set-* icons

davidhurka added a comment. There are 22px versions of these icons. They passed the auto-generation, because they use a different approach. They have a border, but it is not in ViewBackground, but in Text with transparency 0.1. Should I add such a border to the 16px version, or remove it in

D28561: Remove border from format-border-set-* icons

davidhurka created this revision. davidhurka added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidhurka requested review of this revision. REVISION SUMMARY These icons had a kind of border in ViewBackground color, which made them look

D28561: Remove border from format-border-set-* icons

davidhurka edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28561 To: davidhurka, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28561: Remove border from format-border-set-* icons

davidhurka updated this revision to Diff 79386. davidhurka added a comment. - Remove border elements in 22px versions of format-border-* I would like if you accept this new patch version, to be formally correct. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D28561: Remove border from format-border-set-* icons

davidhurka edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH simplify-format-border REVISION DETAIL https://phabricator.kde.org/D28561 To: davidhurka, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28561: Remove border from format-border-set-* icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:07487651e13c: Remove border from format-border-set-* icons (authored by davidhurka). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28561?vs=79386=79393

D28203: Move corner fold to top right in 24 icons

davidhurka marked 3 inline comments as done. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28203: Move corner fold to top right in 24 icons

davidhurka added inline comments. INLINE COMMENTS > ngraham wrote in acrobat.svg:2 > Yeah probably. The color is intrinsic to their brand, not something we should > re-color. Actually the 16px version of acrobat.svg //was// recolored by colorScheme-Negative. I will set the color fixed anyway.

D28203: Move corner fold to top right in 24 icons

davidhurka updated this revision to Diff 78484. davidhurka added a comment. - Give **/acrobat.svg its fixed color back REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28203?vs=78459=78484 BRANCH move-corner-fold-to-top REVISION DETAIL

D28203: Move corner fold to top right in 24 icons

davidhurka added a comment. I would need a developer account to land this. Same for D27983 I assume? REPOSITORY R266 Breeze Icons BRANCH move-corner-fold-to-top REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis,

D28323: Fix some stylesheet colors in 2 icon files

davidhurka created this revision. davidhurka added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidhurka requested review of this revision. REVISION SUMMARY This fixes two tiny inconsistencies in existing icon files in icons/. In the

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

davidhurka added a comment. Can you write a bash script which copies the icon files to icons-dark/ and substitutes the colors? Apparently you know how to do that, my bash skills are a bit worse. TASK DETAIL https://phabricator.kde.org/T12855 To: davidhurka Cc: ngraham,

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

davidhurka added a comment. I have created montages of the different icons. The original files to the left, the generated to the right. (Hover the images to see the file path) There are false positives: F8199094: categories_32_applications-development.png

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

davidhurka added a comment. By the way I looked through the 319 icons. - Some icons actually need fixing in icons/. - The emblem rating is blue in icons-dark/, because it links to another class. We can: - Leave rating in icons-dark/ - Change the light version to be blue too -

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

davidhurka added a comment. I have to take some short notes here. I have written a .sed script which we can use to convert icons/ files to icons-dark/ files. It does the same substitutions as my perl script above, but matches only in the stylesheet. That means, fixed colors will not be

D28203: Move corner fold to top right in 24 icons

davidhurka updated this revision to Diff 78459. davidhurka added a comment. - Fix symlinks: make relative REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28203?vs=78305=78459 BRANCH move-corner-fold-to-top REVISION DETAIL

D28203: Move corner fold to top right in 24 icons

davidhurka marked an inline comment as done. davidhurka added inline comments. INLINE COMMENTS > acrobat.svg:2 > -http://www.w3.org/2000/svg; width="22" height="22"> > - > - I realize that acrobat.svg had a fixed color, which I mistakenly replaced by colorScheme-Negative. Shall I change that

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

davidhurka added a comment. Can anyone explain why rating-unrated and semi-starred-symbolic[-rtl] have 50% transparency, while rating has 100% opacity? That makes my compare script go wild, and I think it doesn’t look intended. TASK DETAIL https://phabricator.kde.org/T12855 To:

D28362: Fix stylesheet linking in 8 icons

davidhurka updated this revision to Diff 78701. davidhurka added a subscriber: ndavis. davidhurka added a comment. @ndavis REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28362?vs=78700=78701 BRANCH fix-some-style-attributes REVISION DETAIL

D28362: Fix stylesheet linking in 8 icons

davidhurka created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidhurka requested review of this revision. REVISION SUMMARY These 8 icons were (partially) not recolored by the stylesheet, because their elements were either not linked to

D28362: Fix stylesheet linking in 8 icons

davidhurka updated this revision to Diff 78702. davidhurka added a comment. - Fix spelling REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28362?vs=78701=78702 BRANCH fix-some-style-attributes REVISION DETAIL https://phabricator.kde.org/D28362

D28203: Move corner fold to top right in 24 icons

davidhurka requested review of this revision. davidhurka added a comment. One potentially important thing: See inline comment. INLINE COMMENTS > filename-title-amarok.svg:8 > +} > +.ColorScheme-ButtonFocus { > +color:#3daee9; I realized that

D29163: WIP: Add document-replace icon (Like for Overwrite action)

davidhurka created this revision. davidhurka added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidhurka requested review of this revision. REVISION SUMMARY This adds an icon document-replace in 16px, 22px, and 32px size, which can be

D29163: WIP: Add document-replace icon (Like for Overwrite action)

davidhurka planned changes to this revision. davidhurka added a comment. The current state is as follows: F8258336: image.png F8258342: image.png All paper sheets are shrunken by 2px, and 16px and 32px got a

D29163: RFC: Add document-replace icon (Like for Overwrite action)

davidhurka retitled this revision from "WIP: Add document-replace icon (Like for Overwrite action)" to "RFC: Add document-replace icon (Like for Overwrite action)". davidhurka edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL

D29027: Move document corner fold to top right in two icons

davidhurka added a comment. Is it possible to land this without arc? I can’t get arc running on my current system. :( If you want this in the next release, you too may land it for me. Otherwise I will land it when I have my own system back, i. e. in a few weeks. I will change the

D29163: RFC: Add document-replace icon (Like for Overwrite action)

davidhurka added a comment. Then I will remove the border. I think it looks slightly better, because the bottom-left corner is visible this way; and the 16px version looks to chunky otherwise. I will update this revision when I have my system back. Otherwise, anyone else may take the

D28203: Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light

davidhurka created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidhurka requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH move-corner-fold-to-top REVISION DETAIL https://phabricator.kde.org/D28203 AFFECTED

D28204: Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light

davidhurka created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidhurka requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH move-corner-fold-to-top REVISION DETAIL https://phabricator.kde.org/D28204 AFFECTED

D28204: Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light

davidhurka abandoned this revision. davidhurka added a comment. Whoops duplicate. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28204 To: davidhurka Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28203: Move corner fold to top right in 24 icons

davidhurka retitled this revision from "Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light)" to "Move corner fold to top right in 24 icons". davidhurka

D28203: Move corner fold to top right in 24 icons

davidhurka edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28203: Move corner fold to top right in 24 icons

davidhurka added a comment. I understand the concerns. It looks unbalanced. But these icons also look unbalanced now: acrobat, filename-title-amarok. By the way I changed the arrow of document-export to point //outwards// the document, not inwards. That often confused me in inkscape,

D28204: Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light

davidhurka updated this revision to Diff 78304. davidhurka added a comment. - link 32px document-preview-archive and document-preview - Move corner fold to top for 6 32px icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28204?vs=78231=78304

D28204: Move corner fold to top right in 24 icons, make 16px versions of 2 icons (dark and light), make 24px versions of 3 icons (dark and light), make 24px symlink versions of 30icons (dark and light

davidhurka abandoned this revision. davidhurka added a comment. garg. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28204 To: davidhurka Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28203: Move corner fold to top right in 24 icons

davidhurka added a comment. There are 172 icons in 16px but not in 22px, and 348 icons in 22px but not in 16px. There are 1561 icons in 22px but not in 32px, and 9 icons in 32px but not in 22px. What are 12px and 32px good for? I fixed the 6 32px icons which had the old style. 2

D28203: Move corner fold to top right in 24 icons

davidhurka updated this revision to Diff 78305. davidhurka added a comment. - link 32px document-preview-archive and document-preview - Move corner fold to top for 6 32px icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28203?vs=78230=78305

D29163: RFC: Add document-replace icon (Like for Overwrite action)

davidhurka abandoned this revision. davidhurka added a comment. Moved to https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/18 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29163 To: davidhurka, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n,