D22715: Save and load page margins

dhaumann added a comment. I think adding the printer name makes sense. We could go the full road, see: https://stackoverflow.com/a/14979437/2224190 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22715 To: hoffmannrobert, cullmann Cc: ltoscano, aacid, dhaumann,

D22715: Save and load page margins

dhaumann added a comment. Btw, I recently wrote a mail to John Layt with the following content. The linked bug may be closed with this change: Hi John, quick question to the QPrinter: We still have issues in Kate (and other KDE apps I assume), that the margins of the QPrintDialog

D22715: Save and load page margins

dhaumann added a comment. Since the former patch was originally from me: I agree to accept it, but it has it's drawbacks: if you have multiple printers, having different margins is not possible, since this is not saved per printer. REPOSITORY R39 KTextEditor REVISION DETAIL

Re: New framework: KCalCore

To me this sounds as if KCal is the best choice: KCal - a library with iCal support. It's short, closest to iCal, and does not clash with calendar systems. Greetings Dominik Allen Winter schrieb am Do., 18. Juli 2019, 18:40: > On Thursday, July 18, 2019 12:18:36 PM EDT Volker Krause wrote: > >

D13867: [KMessageWidget] Pass widget to standardIcon()

dhaumann accepted this revision. dhaumann added a comment. The commit log says "Breeze now knows it's a KMessageWidget". Ok. And now? The commit log lacks what issue this patch fixes... Besides that, looks good to me. REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D22515: Add support for additional QML keywords not part of JavaScript

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Please commit. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D22515 To: vkrause, dhaumann Cc: dhaumann, broulik, kwrite-devel,

D22340: Update cmake highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit R216:61f3846b0fe4: Update cmake highlighting (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22340?vs=61409=61455 REVISION DETAIL

D22340: Update cmake highlighting

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22340 To: turbov, #kate, #framework_syntax_highlighting, dhaumann Cc: ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n,

D22340: Update cmake highlighting

dhaumann retitled this revision from "cmake: bring some missed features" to "Update cmake highlighting". REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22340 To: turbov, #kate, #framework_syntax_highlighting Cc: ngraham, kwrite-devel, kde-frameworks-devel,

D22315: Add setting to enable/disable text drag-and-drop (on by default)

dhaumann added a comment. Good, I expected nothing less ;) REPOSITORY R39 KTextEditor BRANCH text_drag_and_drop_setting REVISION DETAIL https://phabricator.kde.org/D22315 To: thomassc, #ktexteditor, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n,

D22315: Add setting to enable/disable text drag-and-drop (on by default)

dhaumann added inline comments. INLINE COMMENTS > kateconfig.h:986 > ShowWordCount, > +TextDragAndDrop, > SmartCopyCut, @cullmann Is the order here important? This changes all values of remaining enums. REPOSITORY R39 KTextEditor BRANCH

D22315: Add setting to enable/disable text drag-and-drop (on by default)

dhaumann added a comment. When you do UI changes, please always add a screenshot. In this case of the changed config page :) REPOSITORY R39 KTextEditor BRANCH text_drag_and_drop_setting REVISION DETAIL https://phabricator.kde.org/D22315 To: thomassc, #ktexteditor, cullmann Cc:

D22276: Add an action to insert a non-indented newline

dhaumann added inline comments. INLINE COMMENTS > katedocument.h:827 > > -void newLine(KTextEditor::ViewPrivate *view); // Changes input > +void newLine(KTextEditor::ViewPrivate *view, const bool noIndentation = > false); // Changes input > void

D21713: Fortran: implement free & fixed formats

dhaumann added inline comments. INLINE COMMENTS > nibags wrote in fortran-free.xml:3 > Include keywords was added in KF5.52, but the implementation had a bug that > was fixed in KF5.53. So far, the files that use this (SCSS and TypeScript) > require 5.53 > > Include-keywords (5.52): >

D21713: Fortran: implement free & fixed formats

dhaumann added inline comments. INLINE COMMENTS > fortran-free.xml:3 > + > + section="Sources" > extensions="*.f90;*.F90;*.f95;*.F95;*.f03;*.F03;*.f08;*.F08;" > mimetype="text/x-fortran-src" casesensitive="0" author="Franchin Matteo > (f...@libero.it), Janus Weil" license="LGPL"

D21204: Ensure no trailing slash in mountpoint read from fstab file.

dhaumann added a comment. Minor/general comment: given this is a KDE Frameworks change, could you improve the summary of the commit message for this and future commits? Here it just says bug, ccbug, fixedin. Imho a commit log should be self-explaining and self-contained: what is broken

D21563: Fix empty pages in print preview and lines printed twice

dhaumann closed this revision. dhaumann added a comment. Fixed for KF 5.60 with commit 6bbbe6aa51c0a293a58dbca6223e37a73ce32122, thanks for the patch - keep it coming! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21563 To: hoffmannrobert, #kate, #ktexteditor,

D21563: Fix empty pages in print preview and lines printed twice

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I just tested kwrite from master with Qt 5.12.0, and printing was completely broken. It even printed on Letter even though I specified A4 paper. A Qt update to Qt 5.12.3 fixed this -

D21563: Fix empty pages in print preview and lines printed twice

dhaumann added a comment. I will test tomorrow ;) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21563 To: hoffmannrobert, #kate, #ktexteditor Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, bruns, demsking,

D21861: Add default variables for variables interface

This revision was automatically updated to reflect the committed changes. Closed by commit R39:cf85a33e1ff0: Add default variables for variables interface (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21861?vs=60393=60614 REVISION

D21563: Fix empty pages in print preview and lines printed twice

dhaumann added a comment. Many years ago I also stumbled over this bug, and I know for sure it never was fixed. If this fix really works then this would be really great! That said I have not yet tried the patch but am positive to get this in soon! REPOSITORY R39 KTextEditor REVISION

D21940: Make automatic spellcheck work after reloading a document

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me now :) REPOSITORY R39 KTextEditor BRANCH document-reloaded-spellcheck (branched from master) REVISION DETAIL https://phabricator.kde.org/D21940 To: ahmadsamir,

D21940: Make automatic spellcheck work after reloading a document

dhaumann added inline comments. INLINE COMMENTS > ahmadsamir wrote in ontheflycheck.cpp:75 > In file included from /usr/include/qt5/QtCore/qalgorithms.h:43, >from /usr/include/qt5/QtCore/qlist.h:43, >from /usr/include/qt5/QtCore/QList:1, >

D21861: Add default variables for variables interface

dhaumann edited the summary of this revision. dhaumann edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21861 To: dhaumann, cullmann, gregormi Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns,

D21861: Add default variables for variables interface

dhaumann updated this revision to Diff 60393. dhaumann added a comment. - Drop 'Current' prefix and improve documentation This should be good enough now, OK to commit? REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21861?vs=60384=60393 BRANCH

D21907: Show feedback inline when creating new files or folders

dhaumann added a comment. So it boils down to "let's try this and improve later if necessary" - well then :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21907 To: ngraham, #vdg, #frameworks, shubham, filipf, meven Cc: filipf, squeakypancakes, dhaumann, aacid,

D21861: Add default variables for variables interface

dhaumann added a comment. I'd like to drop the " Current" prefix in all the variables. It just makes the names longer and I don't see any value for users. Comments? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21861 To: dhaumann, cullmann, gregormi Cc:

D21861: Add default variables for variables interface

dhaumann updated this revision to Diff 60384. dhaumann added a comment. - Implement JS: variable expansion, e.g. %{JS:3+%{JS:2+1}} --> 6 - Variable expansion: Add unit tests REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21861?vs=59959=60384 BRANCH

D21907: Show feedback inline when creating new files or folders

dhaumann added a comment. These two points were not discussed anymore: 1. Isn't there a better solution by creating the folder and immediately select it + change to edit mode? 2. Resizing dialogs are usually not preferred. If everyone else thinks this change is a good idea - then

D21960: AppArmor: update syntax

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Lgtm. REPOSITORY R216 Syntax Highlighting BRANCH update-apparmor-hl REVISION DETAIL https://phabricator.kde.org/D21960 To: nibags, #framework_syntax_highlighting, dhaumann,

D21940: Make automatic spellcheck work after reloading a document

dhaumann added inline comments. INLINE COMMENTS > ahmadsamir wrote in ontheflycheck.cpp:75 > That wouldn't work, reloaded() takes a Document pointer parameter whereas > refreshSpellcheck takes a Range parameter. But refreshSpellCheck() has a default parameter, so this function exists without

D21940: Make automatic spellcheck work after reloading a document

dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. You don't need the extra function. Could you update the patch? INLINE COMMENTS > ontheflycheck.cpp:75 > > +connect(document, ::Document::reloaded, > +this,

D21907: Show feedback inline when creating new files or folders

dhaumann added a comment. Have not looked at the patch, just the gif: I am rather sceptical if instant feedback is a good idea here. First, having an empty line edit will happen a lot, usually without the user wanting to press OK. That means the user will already get feedback in the middle

D21861: Add default variables for variables interface

dhaumann added a comment. Btw, if there is a better place for initialization, I'd happily move the code to some other place. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21861 To: dhaumann, cullmann, gregormi Cc: kwrite-devel, kde-frameworks-devel, LeGast00n,

D21861: Add default variables for variables interface

dhaumann created this revision. dhaumann added reviewers: cullmann, gregormi. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY Add set of default variables that mostly match Qt

D17241: WIP:Disable highlighting after 512 characters on a line.

dhaumann accepted this revision. dhaumann added a comment. +1 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17241 To: cullmann, vkrause, dhaumann, mwolff, sars Cc: zetazeta, mwolff, brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh,

D17241: WIP:Disable highlighting after 512 characters on a line.

dhaumann added a comment. Could this be pushed even further by using QVarLengthArray? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17241 To: cullmann, vkrause, dhaumann, mwolff, sars Cc: zetazeta, mwolff, brauch, kwrite-devel, kde-frameworks-devel, LeGast00n,

D21587: Lua: update for Lua54 and end of function as Keyword rather than Control

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Lgtm REPOSITORY R216 Syntax Highlighting BRANCH lua54 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21587 To: jpoelen, #framework_syntax_highlighting,

D21508: Jam: various improvements and fixes

dhaumann accepted this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix_jam (branched from master) REVISION DETAIL https://phabricator.kde.org/D21508 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, domson,

D21585: C++: update for C++20

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Thanks for the update! REPOSITORY R216 Syntax Highlighting BRANCH cpp2a (branched from master) REVISION DETAIL https://phabricator.kde.org/D21585 To: jpoelen,

D21467: fix highlighting of '\0' in C mode

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Guess that's fine. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D21467 To: cullmann, dhaumann, vkrause, nibags Cc:

D21411: YAML: only comments after spaces and other improvements/fixes

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH improve-yaml REVISION DETAIL https://phabricator.kde.org/D21411 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting Cc: kwrite-devel,

D21410: Markdown: use includeAttrib in code blocks

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH markdown-code REVISION DETAIL https://phabricator.kde.org/D21410 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting Cc: kwrite-devel,

D21402: Avoid double overwrite check

dhaumann added a comment. Is this correct in all cases? Do we support KIO here? Does that depend on platform integration, i.e. gnome or Windows? REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D21402 To: meven, #kate, #frameworks, cullmann Cc: dhaumann, kwrite-devel,

D19771: Use placeholder instead of label

dhaumann added a comment. In D19771#468881 , @loh.tar wrote: > > Hi, any more feedback on this? > > When in power mode, and the fields are filled, it is not clear what which field is. I think this is a valid concern... REPOSITORY

D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit R216:bbc465981bd5: SyntaxHighlighter: Fix foreground color for text without special highlighting (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21295?vs=58315=58511#toc

D21287: Try to find always an unique visible document name without a number suffix

dhaumann added a comment. There even is a bug report about this: https://bugs.kde.org/show_bug.cgi?id=381532 In this bug report, there is also an example of how sublime text handles this, namely "Document name - path/bla", i.e. the path is appended behind the document name. What about

D21299: examples: move codeeditor also in own subdir

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Thanks! I was about to propose this for consistency as well, please go ahead. REPOSITORY R216 Syntax Highlighting BRANCH haveonesubdirperexample REVISION DETAIL

D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting

dhaumann added a comment. @cullmann I don't see how we can optimize unneed `hasXXX` calls away: `Format::isDefaultTextStyle(const Theme )` internally uses the same 'hasXXX' calls, i.e. if we use both, we do it twice. Right now I don't see a trivial way to improve the patch. REPOSITORY

D21298: Add example app for printing highlighted text to pdf

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I ngeneral looks good to me. Maybe use ecm_optional_add_subdirectory - this also allows 3rd party users to omit the code and it still works. INLINE COMMENTS > CMakeLists.txt:6 > + >

D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting

dhaumann added a comment. Well, this change only affects the SyntaxHighlighter, which KTextEditor does not use ;) For completeness: https://code.woboq.org/qt5/qtbase/src/gui/text/qtextdocument.cpp.html#673 Here, we can see that QTextDocument::drawContents() internally uses a

D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting

dhaumann added a comment. The text thumbnailer was added in: D19432 . REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21295 To: dhaumann, vkrause, cullmann, kossebau Cc: kwrite-devel, kde-frameworks-devel, domson,

D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting

dhaumann created this revision. dhaumann added reviewers: vkrause, cullmann, kossebau. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY QTextDocument seems to use the widget

D21293: Markdown: Use color with higher contrast for lists

This revision was automatically updated to reflect the committed changes. Closed by commit R216:7be1380c52a8: Markdown: Use color with higher contrast for lists (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D21293: Markdown: Use color with higher contrast for lists

dhaumann added a comment. New color is red: F6835074: Screenshot_20190519_175848.png @gregormi If you want other colors, please propose them yourself :-) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21293

D21293: Markdown: Use color with higher contrast for lists

dhaumann created this revision. dhaumann added reviewers: cullmann, gregormi. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY BUG: 405824 FIXED-IN: 5.59 TEST PLAN make &&

D21287: Try to find always an unique visible document name without a number suffix

dhaumann added a comment. Looking at the screenshots, I find it rather intransparent which document gets what name, besides that the quick open already shows the path to distinguish the files -> is this really an improvement? And: I have the feeling this patch should pay attention to

D21289: Fix: Use default indentation mode for new files

This revision was automatically updated to reflect the committed changes. Closed by commit R39:11fb4c4d5e10: Fix: Use default indentation mode for new files (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21289?vs=58296=58300

D21289: Fix: Use default indentation mode for new files

dhaumann updated this revision to Diff 58296. dhaumann added a comment. - Use updateConfig() to set indentation mode REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21289?vs=58294=58296 BRANCH fix-default-indent-mode REVISION DETAIL

D21289: Fix: Use default indentation mode for new files

dhaumann added a comment. Alternatively, we could call updateConfig() at the end of the KateDocument constructor which does - among other things - the same. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21289 To: dhaumann, cullmann Cc: kwrite-devel,

D21289: Fix: Use default indentation mode for new files

dhaumann created this revision. dhaumann added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY BUG: 375502 TEST PLAN make && make test REPOSITORY R39

D21286: Perl: fix the // operator

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Thanks for the fix, please commit. REPOSITORY R216 Syntax Highlighting BRANCH fix-perl REVISION DETAIL https://phabricator.kde.org/D21286 To: nibags,

D19608: DocumentPrivate: Make bracket handling smart

dhaumann added a comment. I think this change introduces a regression: This code does not check for "view->config()->autoBrackets()", so it's *ALWAYS* active, which I do not want. Consider this: if (bla |) { ... } Now you type && foo(), the result is then: if (bla && foo()

D17595: Upstream Dolphin's file rename dialog

dhaumann added a comment. Yes, please ask Peter Penz and CC a public mailing list and/or use the relicense check script. I am sure Peter would agree to a license change. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17595 To: ngraham, #frameworks, #dolphin, broulik

D21173: API dox: note for FrameSvg::prefix()/actualPrefix() the trailing '-'

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fixdoxofprefix REVISION DETAIL https://phabricator.kde.org/D21173 To: kossebau, #plasma, dhaumann Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

dhaumann added a comment. @hindenburg: lgtm, could you comment? REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: dhaumann, pino, michaelh, ngraham, bruns

D20958: New menu of syntax highlighting in the status bar

dhaumann added a comment. Btw, I think this is a really nice improvement! Keep it coming :-) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20958 To: nibags, #ktexteditor, #kate, #vdg, ngraham, cullmann Cc: dhaumann, anthonyfieroni, cullmann, ngraham, loh.tar,

D21007: Review kate config pages to improve maintenance friendliness

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I guess this is more easy on the eyes. Alternatively, one could consider making observeCanges a free function, but please commit for now. INLINE COMMENTS > katedialogs.cpp:156 >

D20958: New menu of syntax highlighting in the status bar

dhaumann added a comment. My comments are very vague, but I think this patch could even be better. Only did a review half through due to lack of time. INLINE COMMENTS > katemodemenulist.h:141 > + */ > +class ModeListWidget : public QListWidget > +{ Can you make this a

D20924: ViewConfig: Use new generic config interface

dhaumann added a comment. PS: I know this comment comes too late, but this could have waited 2 more days after the next KF5 tag tomorrow :-) we had 1 day of testing now. Maybe we are lucky and there is no regression - let's try now. REPOSITORY R39 KTextEditor REVISION DETAIL

D20924: [WIP] ViewConfig: Use new generic config interface

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I read the diff carefully, please commit. INLINE COMMENTS > kateconfig.h:964 > +ShowScrollBarPreview, > +ShowWordCount, > }; Are training commas allowed

D20897: Ensure the left border miss no change of the count of line number digits

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20897 To: loh.tar, #ktexteditor, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns,

D20903: Fix bookmark pixmap painting on icon bar

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20903 To: loh.tar, #ktexteditor, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns,

D20870: Fix vimode_keys AltGr test

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Lgtm. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20870 To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel,

D20852: Fix to show folding preview when move the mouse from bottom to top

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Lgtm and is more readable, thanks. REVISION DETAIL https://phabricator.kde.org/D20852 To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, brauch, kwrite-devel, kde-frameworks-devel,

D20697: Review IconBorder

dhaumann added a comment. Well, issues that were already there before should not hinder this patch of course! If you think this is good enough, please go on. REVISION DETAIL https://phabricator.kde.org/D20697 To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, kwrite-devel,

D20169: Add profile support interface for TerminalInterface

dhaumann added a comment. Please fix the API getters: in the KDE/Qt world, getters never start with 'get': just use availableProdiles() etc. Similarly, I suggest to rename changeCurrentProfile() to setCurrentProfile(). Could you provide an updated patch? REPOSITORY R306 KParts

D20697: Review IconBorder

dhaumann added a comment. Did you test that the annotation border still works? You can do so in KDevelop by invoking git blame. Besides I still gave no issues with this patch, except that I did not test myself. If you say there are mouse move issues, then these issues should be fixed

D20264: Add test for "Auto Reload Document" option

dhaumann added a comment. Yes, that's exactly what I meant. But if it's not stable, then it does not help. Maybe in that case keep it as is for now? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20264 To: loh.tar, dhaumann, cullmann Cc: cullmann, kwrite-devel,

D20697: Review IconBorder

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I like the visual change, let's give it a try. Thanks! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20697 To: loh.tar, #ktexteditor, dhaumann Cc:

D20606: Toggle folding of child ranges by right click

dhaumann added a comment. I would prefer a context menu that has this as action. This is much better discoverable and also extensible with more folding actions. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20606 To: loh.tar, #ktexteditor, cullmann, ngraham,

D20565: Ensure not to fold the end marker

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Yes, I am in favor. thanks REVISION DETAIL https://phabricator.kde.org/D20565 To: loh.tar, #ktexteditor, cullmann, dhaumann, ngraham Cc: kwrite-devel, kde-frameworks-devel,

D20534: avoid conflicting shortcuts for switching tabs

dhaumann added a comment. lgtm REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20534 To: cullmann, #kate, ngraham, dhaumann Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D20264: Add test for "Auto Reload Document" option

dhaumann added a comment. I think KateViewInternal::updateView is called for cursor blinking for instance. May that be an issue? REVISION DETAIL https://phabricator.kde.org/D20264 To: loh.tar, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh,

D20467: Allow to close a document whose file was deleted on disk

dhaumann added a comment. Hm, the correct fix is to implement this function for KWrite. And: There is also KDevelop and Kile... Having only a half-working solution sounds suboptimal to me. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20467 To: meven,

D20467: Allow to close a document whose file was deleted on disk

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me. INLINE COMMENTS > katedialogs.cpp:1298 > +m_message->addAction(closeFile, false); > +connect(closeFile, SIGNAL(triggered()), this, >

D20431: KateIconBorder: Ensure Dyn Wrap Marker are shown

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. As I understand, one can still disable the indicator if not wanted, right? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20431 To: loh.tar, cullmann,

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Let's give this a try. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20434 To: loh.tar, cullmann, #ktexteditor, dhaumann Cc: dhaumann, cfeck, ngraham,

D20425: KateIconBorder: Code cosmetic

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20425 To: loh.tar, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, szutmael, gennad, domson, michaelh, ngraham,

D19438: Add syntax definition for Elm language to syntax-highlighting

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. It's also ok to generate the reference data om first commit. Often highlighting contributors do not have a compiling KSyntaxHighlighting git around, so this is a significant hurdle.

D20264: Add test for "Auto Reload Document" option

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. There is a getter bool KateGlobal::self()->unitTestMode(). You could use this in DocumentPrivate to reduce the timer from 3000 to e.g. 50ms or so to reduce testing time. But

D19764: Fix Minimap with QtCurve style

dhaumann added a comment. Thanks for the fix. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19764 To: sars, brauch, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

Re: CI system maintainability

Kevin Ottens schrieb am Do., 28. März 2019, 09:29: > Hello, > > On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote: > > Please note that the commits in this instance were pushed without > > review, so restrictions on merge requests wouldn't make a difference > > in this case

D19876: Fix: apply correctly the text colors of the chosen scheme

dhaumann added a comment. I think such a workaround is ok, but the real issue here is that KTextEditor does not fully use the KSyntaxHighlighting Theme colors. Instead, it still has its own configuration, such that hacks like this are introduced to somehow make it work. But it's just a

D19974: Add extensions to groovy highlighting

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19974 To: apushnov, #framework_syntax_highlighting, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, gennad,

D19999: Fix endRegion folding in rules with beginRegion+endRegion (use length=0)

dhaumann added a comment. Looks good to me. Anyone else? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D1 To: nibags, #framework_syntax_highlighting, cullmann, dhaumann, vkrause Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh,

D19974: Add extensions to groovy highlighting

dhaumann added a comment. You also have to increase the "version" from 5 to 6. Could you provide an updated patch? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19974 To: apushnov, #framework_syntax_highlighting Cc: dhaumann, kwrite-devel,

D19795: Add Variable interface to KTextEditor::Editor

dhaumann added a comment. It's committed now: - quoting is now not supported at all anymore - expandText() now returns void REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19795 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, gennad, domson,

D19795: Add Variable interface to KTextEditor::Editor

This revision was automatically updated to reflect the committed changes. Closed by commit R39:a4083c7cf0d6: Add Variable interface to KTextEditor::Editor (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19795?vs=54264=54265 REVISION

D19795: Add Variable interface to KTextEditor::Editor

dhaumann updated this revision to Diff 54264. dhaumann added a comment. This revision is now accepted and ready to land. - Drop KWordMacroExpander in favor of own simple implementation (50 slocs) REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

<    1   2   3   4   5   6   7   8   9   10   >