mlaurent created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
Compile it
REPOSITORY
R309 KService
BRANCH
fix_compile_QT_NO_CAST_FROM_ASCII
REVISION DETAIL
https://phabricator.kde.org/D9044
AFFECTED F
mlaurent added a reviewer: dfaure.
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D9044
To: mlaurent, dfaure
Cc: #frameworks
mlaurent updated this revision to Diff 23071.
mlaurent marked 3 inline comments as done.
mlaurent added a comment.
Fix comment from David
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8619?vs=21828&id=23071
REVISION DETAIL
https://phabricator.kde.org/D8619
AFFECTED FILES
src/f
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:4b4062497afc: Make it compile with QT_NO_CAST_FROM_ASCII
(authored by mlaurent).
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9027?vs=23069&id=23070
REVIS
mlaurent updated this revision to Diff 23069.
mlaurent marked 5 inline comments as done.
mlaurent added a comment.
- Fix comment found by david
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9027?vs=23062&id=23069
BRANCH
make_it_compile_with_QT_NO
mlaurent created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
compile execute autotest
REPOSITORY
R289 KNotifications
BRANCH
make_it_compile_with_QT_NO_CAST_FROM_ASCII
REVISION DETAIL
https://phabrica
mlaurent added a reviewer: dfaure.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D9027
To: mlaurent, dfaure
Cc: #frameworks
mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesmodel.cpp:77
> +if (day > 0) {
> +date += QString("-%1").arg(day, 2, 10, QChar('0'));
> +}
QStringLiteral("-%1").arg(...)
> kfileplacesmodel.cpp:96
> +timelineUrl = QUrl(timelinePrefix + timelin
mlaurent added a comment.
oh it was abandoned ! ok :)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8862
To: renatoo, dfaure, mwolff
Cc: mlaurent, mwolff, dfaure, ngraham, #frameworks
mlaurent accepted this revision.
mlaurent added a comment.
Seems ok for me now.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure
Cc: dfaure, elvisangelaccio, mwolff, mlaurent, #frameworks
mlaurent edited the summary of this revision.
REVISION DETAIL
https://phabricator.kde.org/D8619
To: mlaurent, #frameworks, ervin
Cc: ngraham
mlaurent updated this revision to Diff 21828.
mlaurent added a comment.
Don't disconnect a model without check if not null.
Const'ify some variables
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8619?vs=21779&id=21828
REVISION DETAIL
https://phabricator.kde.org/D8619
AFFECTED
mlaurent accepted this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin, mlaurent
Cc: ervin, usta, mlaurent, dvratil, ngraham, #frameworks
mlaurent updated this revision to Diff 21779.
mlaurent added a comment.
Remove virtual keyword when we have override
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8619?vs=21778&id=21779
REVISION DETAIL
https://phabricator.kde.org/D8619
AFFECTED FILES
src/filewidgets/kfileplace
mlaurent updated this revision to Diff 21778.
mlaurent added a comment.
Const'ify + use more static_cast
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8619?vs=21776&id=21778
REVISION DETAIL
https://phabricator.kde.org/D8619
AFFECTED FILES
src/filewidgets/kfileplacesview.cpp
T
mlaurent created this revision.
mlaurent added reviewers: Frameworks, ervin.
REVISION SUMMARY
Remove duplicate code.
Use static_cast when we don't test result from dynamic_cast
Remove unused variable
TEST PLAN
compile/test
REPOSITORY
R342 KIO AudioCD
REVISION DETAIL
https://phabric
mlaurent added a comment.
+1 for me
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin, mlaurent
Cc: ervin, usta, mlaurent, dvratil, ngraham, #frameworks
mlaurent accepted this revision.
mlaurent added a comment.
Seems good for me
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent
Cc: elvisangelaccio, mwolff, mlaurent, #frameworks
mlaurent updated this revision to Diff 21755.
mlaurent added a comment.
Remove commented code. Rename methods
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=21752&id=21755
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
autotests/kfileplacesmodeltest.cp
mlaurent marked 2 inline comments as done.
REVISION DETAIL
https://phabricator.kde.org/D8367
To: mlaurent, renatoo, ngraham, franckarrecot, ervin
Cc: ngraham, mlaurent, #frameworks
mlaurent updated this revision to Diff 21752.
mlaurent added a comment.
Rebase against master + other top patchs :)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=21645&id=21752
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
autotests/kfileplacesmodelt
mlaurent updated this revision to Diff 21750.
mlaurent added a comment.
Rebase it
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8366?vs=21646&id=21750
REVISION DETAIL
https://phabricator.kde.org/D8366
AFFECTED FILES
autotests/kfileplacesmodeltest.cpp
To: mlaurent, renatoo, er
mlaurent requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin, mlaurent
Cc: ervin, usta, mlaurent, dvratil
mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesviewtest.cpp:2
> +/* This file is part of the KDE project
> +Copyright (C) 2007 Kevin Ottens
> +
? I don't think that you are kevin ottens :) and we are in 2017 :)
> kfileplacesviewtest.cpp:20
> +
> +#include
> +#include
QtCo
mlaurent updated this revision to Diff 21646.
mlaurent added a comment.
Fix typo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8366?vs=21289&id=21646
REVISION DETAIL
https://phabricator.kde.org/D8366
AFFECTED FILES
autotests/kfileplacesmodeltest.cpp
To: mlaurent, renatoo, erv
mlaurent commandeered this revision.
mlaurent edited reviewers, added: franckarrecot; removed: mlaurent.
mlaurent added a comment.
impossible to rebase this one...
I will need to rewrite all this patch
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8366
To: mlaurent,
mlaurent updated this revision to Diff 21645.
mlaurent added a comment.
Fixing create static variable
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=21643&id=21645
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
autotests/kfileplacesmodeltest.cpp
src/
mlaurent marked an inline comment as done.
mlaurent added inline comments.
INLINE COMMENTS
> ervin wrote in kfileplacesmodel.h:55
> You missed a bit, it looks like it wasn't applied on top of the latest
> iteration from the other patches the GroupType enum gained some values for
> its entries.
mlaurent updated this revision to Diff 21644.
mlaurent added a comment.
Autotest GroupIndexes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8450?vs=21612&id=21644
REVISION DETAIL
https://phabricator.kde.org/D8450
AFFECTED FILES
autotests/kfileplacesmodeltest.cpp
src/filewidg
mlaurent updated this revision to Diff 21643.
mlaurent added a comment.
updated according to comments
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=21605&id=21643
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
autotests/kfileplacesmodeltest.cpp
src/
mlaurent marked 6 inline comments as done.
mlaurent added inline comments.
INLINE COMMENTS
> ervin wrote in kfileplacesitem.cpp:202
> Very welcome refactoring... in a separate commit
This one is for avoiding duplicate code as we create in this patch isHidden
method.
REVISION DETAIL
https://p
mlaurent added a reviewer: ervin.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8348
To: renatoo, #dolphin, #frameworks, #vdg, ervin
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks
mlaurent updated this revision to Diff 21612.
mlaurent added a comment.
Minor optimization.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8450?vs=21291&id=21612
REVISION DETAIL
https://phabricator.kde.org/D8450
AFFECTED FILES
src/filewidgets/kfileplacesmodel.cpp
src/filewidg
mlaurent edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: mlaurent, ngraham, renatoo, franckarrecot
Cc: #frameworks
mlaurent added a reviewer: ervin.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: mlaurent, ngraham, renatoo, franckarrecot, ervin
Cc: #frameworks
mlaurent edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: mlaurent, ngraham, renatoo, franckarrecot
Cc: #frameworks
mlaurent commandeered this revision.
mlaurent edited reviewers, added: franckarrecot; removed: mlaurent.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: mlaurent, ngraham, renatoo, franckarrecot
Cc: #frameworks
mlaurent edited the test plan for this revision.
REVISION DETAIL
https://phabricator.kde.org/D8367
To: mlaurent, renatoo, ngraham, franckarrecot, ervin
Cc: ngraham, mlaurent, #frameworks
mlaurent edited the test plan for this revision.
REVISION DETAIL
https://phabricator.kde.org/D8367
To: mlaurent, renatoo, ngraham, franckarrecot, ervin
Cc: ngraham, mlaurent, #frameworks
mlaurent updated this revision to Diff 21605.
mlaurent added a comment.
Remove duplicate code
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=21604&id=21605
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
autotests/kfileplacesmodeltest.cpp
src/filewidg
mlaurent edited the summary of this revision.
REVISION DETAIL
https://phabricator.kde.org/D8367
To: mlaurent, renatoo, ngraham, franckarrecot
Cc: ngraham, mlaurent, #frameworks
mlaurent added a reviewer: ervin.
REVISION DETAIL
https://phabricator.kde.org/D8367
To: mlaurent, renatoo, ngraham, franckarrecot, ervin
Cc: ngraham, mlaurent, #frameworks
mlaurent updated this revision to Diff 21604.
mlaurent added a comment.
Modernize code.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=21572&id=21604
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
autotests/kfileplacesmodeltest.cpp
src/filewidgets/kf
mlaurent edited the summary of this revision.
mlaurent added dependencies: D8366: Factoring out lists of url data within
KFilePlacesModelTest, D8348: Add a section for removable devices, D8332: Added
baloo urls into places model.
REVISION DETAIL
https://phabricator.kde.org/D8367
To: mlaurent,
mlaurent added a dependent revision: D8367: Hidding place groups implementation
in KFilePlacesModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham
Cc: usta, mlaurent, dvratil, ngraham, #fra
mlaurent added a dependent revision: D8367: Hidding place groups implementation
in KFilePlacesModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8348
To: renatoo, #dolphin, #frameworks, #vdg
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks
mlaurent added a dependent revision: D8367: Hidding place groups implementation
in KFilePlacesModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8366
To: franckarrecot, renatoo, mlaurent
Cc: mlaurent, #frameworks
mlaurent updated this revision to Diff 21572.
mlaurent added a comment.
We can't use qAsConst as it's a qt5.8 macro.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=21290&id=21572
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
autotests/kfileplacesmodel
mlaurent commandeered this revision.
mlaurent edited reviewers, added: franckarrecot; removed: mlaurent.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8367
To: mlaurent, renatoo, ngraham, franckarrecot
Cc: ngraham, mlaurent, #frameworks
mlaurent added a comment.
depend against https://phabricator.kde.org/D8366 too...
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8367
To: franckarrecot, renatoo, mlaurent, ngraham
Cc: ngraham, mlaurent, #frameworks
mlaurent added a comment.
it depends against https://phabricator.kde.org/D8348 too
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8367
To: franckarrecot, renatoo, mlaurent, ngraham
Cc: ngraham, mlaurent, #frameworks
mlaurent added a comment.
it depends against https://phabricator.kde.org/D8332.diff too
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8367
To: franckarrecot, renatoo, mlaurent, ngraham
Cc: ngraham, mlaurent, #frameworks
Le jeudi 26 octobre 2017, 01:19:02 CEST Valorie Zimmerman a écrit :
> On Wed, Oct 25, 2017 at 1:44 AM, Harald Sitter wrote:
> > On Wed, Oct 25, 2017 at 10:35 AM, laurent Montel wrote:
> >> Hi,
> >> I send this email to kde-frameworks-devel
> >>
> >
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
seems ok for me
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8366
To: franckarrecot, renatoo, mlaurent
Cc: mlaurent, #frameworks
mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesview.cpp:297
> +const QModelIndexList indexesGroup =
> placesModel->groupIndexes(placesModel->groupType(index));
> +
> +for (const QModelIndex &idx : indexesGroup) {
m_disappearingItems.reserve(m_disappearingItems.count() + in
page just not been filled in yet?
>
> Valorie
--
Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53,
www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent
software solutions
mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesmodel.cpp:596
> +const QHash groupStates = groupStateHidden(root);
> +for (KFilePlacesItem *item : items) {
> +if (bool hasToBeHidden = groupStates.value(item->groupType())) {
for(... : qAsConst(items)) {
}
REPOSITORY
mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesitem.cpp:354
> +if (m_access) {
> +connect(m_access, SIGNAL(accessibilityChanged(bool,QString)),
> +this, SLOT(onAccessibilityChanged(bool)));
could you use new connect api please ?
REPOSITORY
mlaurent added a comment.
+1 for me :) But I am not the maintainer :)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin
Cc: mlaurent, #frameworks
mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesitem.cpp:168
> +if (protocol == QLatin1String("remote") ||
> +KProtocolInfo::protocolClass(protocol) != ":local") {
> +return NetworkType;
!= QLatin1String(":local")
REPOSITORY
R241 KIO
REVISION DETA
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D8401
To: mkoller, mlaurent
Cc: #frameworks
mlaurent requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8367
To: franckarrecot, renatoo, mlaurent
Cc: mlaurent, #frameworks
mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesmodeltest.cpp:83
>
> +bool isFileIndexingEnabled;
> QMap m_interfacesMap;
m_isFileIndexingEnabled
> kfileplacesmodeltest.cpp:89
> {
> return
> QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) +
mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesview.cpp:1303
> +const int day = date.day();
> +timelineUrl = QUrl("timeline:/" + timelineDateString(year, month) +
> + '/' + timelineDateString(year, month, day));
Add QStringLiteral and QLatin1Char('/') t
mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesview.cpp:113
> +QColor baseColor(const QStyleOption &option) const;
> +QColor mixedColor(const QColor& c1, const QColor& c2, int c1Percent)
> const;
> };
coding style const QColor &c1, const QColor &c2
REPOSITORY
R241 KIO
mlaurent accepted this revision.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D7378
To: cfeck, mlaurent, davidedmundson
Cc: #frameworks
mlaurent closed this revision.
REVISION DETAIL
https://phabricator.kde.org/D7062
To: mlaurent, dfaure, kossebau, cfeck
Cc: cfeck, elvisangelaccio, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:ec3b3e105064: CHANGELOG: Extract lineedit password widget
(authored by mlaurent).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7011?vs=17621&id=17657
REVI
mlaurent updated this revision to Diff 17621.
mlaurent added a comment.
+1
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7011?vs=17620&id=17621
REVISION DETAIL
https://phabricator.kde.org/D7011
AFFECTED FILES
autotests/CMakeLists.txt
autotests/knewpasswordwidgettest.cpp
au
mlaurent updated this revision to Diff 17620.
mlaurent added a comment.
Remove Q_PRIVATE_SLOT
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7011?vs=17617&id=17620
REVISION DETAIL
https://phabricator.kde.org/D7011
AFFECTED FILES
autotests/CMakeLists.txt
autotests/knewpassword
mlaurent updated this revision to Diff 17617.
mlaurent added a comment.
update
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7011?vs=17615&id=17617
REVISION DETAIL
https://phabricator.kde.org/D7011
AFFECTED FILES
autotests/CMakeLists.txt
autotests/knewpasswordwidgettest.cpp
mlaurent added inline comments.
INLINE COMMENTS
> cfeck wrote in kpasswordlineedit.cpp:30
> That's fishy. I just checked a single class (KColumnResizer), and it has just
> "class KColumnResizerPrivate" (no namespace, no QObject), and still has a
> Q_PRIVATE_SLOT in its KColumnResizer class.
wi
mlaurent added inline comments.
INLINE COMMENTS
> cfeck wrote in kpasswordlineedit.cpp:30
> You made it a namespaced class again. Why?
Otherwise it failed to using Q_PRIVATE_SLOT...
REVISION DETAIL
https://phabricator.kde.org/D7011
To: mlaurent, cfeck, dfaure, elvisangelaccio
Cc: kossebau, e
mlaurent updated this revision to Diff 17615.
mlaurent added a comment.
Fix all comment reported
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7011?vs=17606&id=17615
REVISION DETAIL
https://phabricator.kde.org/D7011
AFFECTED FILES
autotests/CMakeLists.txt
autotests/knewpassw
mlaurent marked 4 inline comments as done.
mlaurent added inline comments.
INLINE COMMENTS
> cfeck wrote in knewpasswordwidget.cpp:118
> Ah, now I understand. Also, use the passed echoMode, instead of accessing
> lineEdit().
we can't as we use it in :
connect(toggleEchoModeAction, &QAction::tri
mlaurent marked 3 inline comments as done.
mlaurent added inline comments.
INLINE COMMENTS
> cfeck wrote in knewpasswordwidget.cpp:118
> Can you double-check this change? To me, the echoMode() checks are now
> reversed compared to the original code.
>
> I have not tested the code yet :)
Nope i
mlaurent updated this revision to Diff 17606.
mlaurent marked an inline comment as done.
mlaurent added a comment.
Fix include order, remove textChanged, add argument to signal etc.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7011?vs=17541&id=17606
REVISION DETAIL
https://phabr
mlaurent marked an inline comment as done.
REVISION DETAIL
https://phabricator.kde.org/D7062
To: mlaurent, dfaure, kossebau, elvisangelaccio
Cc: cfeck, elvisangelaccio, #frameworks
mlaurent updated this revision to Diff 17592.
mlaurent added a comment.
Remove empty line
Move in good place.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7062?vs=17574&id=17592
REVISION DETAIL
https://phabricator.kde.org/D7062
AFFECTED FILES
src/kde.widgets
To: mlaurent,
mlaurent marked 2 inline comments as done.
REVISION DETAIL
https://phabricator.kde.org/D7062
To: mlaurent, dfaure, kossebau, elvisangelaccio
Cc: elvisangelaccio, #frameworks
mlaurent updated this revision to Diff 17574.
mlaurent added a comment.
Fix typo + Group as requested.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7062?vs=17542&id=17574
REVISION DETAIL
https://phabricator.kde.org/D7062
AFFECTED FILES
src/kde.widgets
To: mlaurent, dfaure, k
mlaurent added a comment.
https://phabricator.kde.org/D7062 (designer plugin)
REVISION DETAIL
https://phabricator.kde.org/D7011
To: mlaurent, cfeck, dfaure, elvisangelaccio
Cc: kossebau, elvisangelaccio, #frameworks
mlaurent created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
We need a plugin for showing it in designer
TEST PLAN
launch designer with knewpasswordwidget from kwidgetaddons
REPOSITORY
R298 KDesi
mlaurent updated this revision to Diff 17541.
mlaurent added a comment.
I created a designer plugin for it, I will put url here after create review
I add property for echo mode
Now we can see lineedit in designer (created from a plugin)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.o
mlaurent updated this revision to Diff 17535.
mlaurent added a comment.
Use a correct license (I copied a header from david class so I think it's ok
now) as in kwidgetaddons there is lgpl2 lgpl2.1 lgpl3 lgpl...
I didn't change ui file a QWidget otherwise we can't see qlineedit in
designe
mlaurent added inline comments.
INLINE COMMENTS
> kossebau wrote in knewpasswordwidget.ui:88
> rather extends QWidget now? unsure what exactly the consequences are
The consequence is that we don't see it in designer :)
So why not but it's better to show a lineedit no ?
> kossebau wrote in kpass
mlaurent updated this revision to Diff 17533.
mlaurent added a comment.
Fix copyright
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7011?vs=17471&id=17533
REVISION DETAIL
https://phabricator.kde.org/D7011
AFFECTED FILES
autotests/CMakeLists.txt
autotests/knewpasswordwidgette
mlaurent updated this revision to Diff 17471.
mlaurent added a comment.
Rename method as lineEdit as requested by David
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7011?vs=17470&id=17471
REVISION DETAIL
https://phabricator.kde.org/D7011
AFFECTED FILES
autotests/CMakeLists.tx
mlaurent retitled this revision from "Extract lineedit password" to "Extract
KPasswordLineEdit class".
REVISION DETAIL
https://phabricator.kde.org/D7011
To: mlaurent, cfeck, dfaure, elvisangelaccio
Cc: kossebau, elvisangelaccio, #frameworks
mlaurent updated this revision to Diff 17470.
mlaurent added a comment.
Create a real class for private class as requested
+ fix signal
etc.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7011?vs=17469&id=17470
REVISION DETAIL
https://phabricator.kde.org/D7011
AFFECTED FILES
mlaurent updated this revision to Diff 17469.
mlaurent added a comment.
I renamed class/test apps/autotests as requested
I fixed autotest with new autotest from master
I fixed all comment on this review
etc.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7011?vs=17420&id=17469
mlaurent marked 7 inline comments as done.
REVISION DETAIL
https://phabricator.kde.org/D7011
To: mlaurent, cfeck, dfaure, elvisangelaccio
Cc: kossebau, elvisangelaccio, #frameworks
mlaurent marked 5 inline comments as done.
REVISION DETAIL
https://phabricator.kde.org/D7011
To: mlaurent, cfeck, dfaure, elvisangelaccio
Cc: kossebau, elvisangelaccio, #frameworks
mlaurent added inline comments.
INLINE COMMENTS
> cfeck wrote in knewpasswordwidgettest.cpp:63
> Does using setPassword() not work for these tests?
Nope as setPassword not authorize to see icon (it's a security when we
setPassword from apps you don't want to see it)
> cfeck wrote in knewpasswo
mlaurent updated this revision to Diff 17420.
mlaurent added a comment.
I renamed class name.
I ported KNewPasswordWidget .
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7011?vs=17413&id=17420
REVISION DETAIL
https://phabricator.kde.org/D7011
AFFECTED FILES
autotests/CMakeLi
mlaurent created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Now we can use lineedit password outside kpassworddialog.
It's useful in kdepim for example.
TEST PLAN
I added autotest and test apps.
ITIONAL 337/520 (65%)>
> > src.indexer
> >
> > FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 53/71
> > (75%)CONDITIONAL 73/92 (79%)
> >
> > src.lib
> >
> > F
> On Dec. 30, 2016, 6:39 a.m., Martin Gräßlin wrote:
> > Is that enabled by default now? I hope not! This is a completely useless
> > warning for all frameworks (as we are not allowed to use override) and even
> > more for a legacy code bases. I don't want to have to adjust the cmake in
> > al
Hi,
Done. I cleaned up my reporitories
Regards
--
Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53,
www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent
software
- Laurent Montel
On Sept. 21, 2016, 5:36 p.m., Heiko Becker wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
601 - 700 of 806 matches
Mail list logo
