Re: Review Request 126313: Use an xcb for interaction with KStartupInfo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126313/#review91596 --- FYI, this breaks Plasma 5 startup completely for me. kinit crashes with ```gdb #0 0x7ff831e58c20 in QObject::thread() const () at /usr/lib64/libQt5Core.so.5 #1 0x7ff8329d1a20 in KWindowSystem::d_func() () at /usr/lib64/libKF5WindowSystem.so.5 #2 0x7ff8329d2cc9 in KWindowSystem::mapViewport() () at /usr/lib64/libKF5WindowSystem.so.5 #3 0x7ff8329dce02 in NETRootInfo::currentDesktop(bool) const () at /usr/lib64/libKF5WindowSystem.so.5 #4 0x00408d09 in launch(int, char const*, char const*, char const*, int, char const*, bool, char const*, bool, char const*) (this=0x8e4458) at /usr/include/qt5/QtCore/qbytearray.h:485 #5 0x00408d09 in launch(int, char const*, char const*, char const*, int, char const*, bool, char const*, bool, char const*) (this=0x8e4458) at /usr/include/qt5/QtCore/qbytearray.h:479 #6 0x00408d09 in launch(int, char const*, char const*, char const*, int, char const*, bool, char const*, bool, char const*) (argc=32767, _name=0x7db02e20 "\020c\215", args=0x8e446b "/home/lb", cwd=, envc=, envs=, reset_env=false, tty=0x8e55b0 "", avoid_loops=160, startup_id_str=0x1161 ) at /home/lb/Coding/KDEsrc/kinit/src/kdeinit/kinit.cpp:643 #7 0x008e559d in () #8 0x in () ``` I had to revert it or kdeinit would crash and prevent me from having a functional session. ;) - Luca Beltrame On Gen. 25, 2016, 3:34 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126313/ > --- > > (Updated Gen. 25, 2016, 3:34 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kinit > > > Description > --- > > By changing to xcb we can use NETRootInfo to get the current desktop > and don't need to duplicate the logic. Also it means that more code > is ported from XLib to xcb and might allow us to drop the XLib > dependency in future. > > > Diffs > - > > CMakeLists.txt eeecab775cfb5dfe12cf9c4991c658cc261ed727 > src/config-kdeinit.h.cmake cfcfc61a1bb560ff9a902b89bd3b8fb27273ebf2 > src/kdeinit/CMakeLists.txt f94db717f2403b602648286eac243837d8714069 > src/kdeinit/kinit.cpp a18008a11bf00a35aa0cab450180926217cd58f5 > > Diff: https://git.reviewboard.kde.org/r/126313/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: ECM metainfo path
Il giorno Thu, 21 Apr 2016 12:26:54 +0200 Harald Sitter ha scritto: > doesn't that break compatibility with older appstreams for everything > that uses ECM? if so, I am not sure that is appropriate TBH I noticed that as well (at the same time when we were standardizing the AppStream directory in openSUSE packages of KDE software, ironically), and I second the question on this change (and why does this stuff - appstream - change every release?). pgpAK2Uy43aex.pgp Description: Firma digitale OpenPGP ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117799: Clean up private slots in KCompletion
Commit Hook wrote: > 210ed36c1ae1e3ce33fbd752e460651e31d1a37d by David Gil to branch > clean_up_private_slots. Was this the right branch, or a mistake? -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Getting ecm files from the ECM package
Rex Dieter wrote: > I can vouche for fedora/redhat that the buildsystem does not have internet > access. Likewise, the OBS for openSUSE does not have net access during building. -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KAuth and KF5
Hello, currently, the KF5 version of KAuth is not quite usable as any helper used by KAuth segfaults: the most notable is backlighthelper, which always crashes at login. According to some investigations made by a fellow openSUSE Community KDE member, it crashes somewhere in Qt, in dbusInterfaceString(). I've tried myself to get a backtrace but gdb offers no stack Given that the release is so close by and that KAuth is used by a lot of pieces in the upcoming workspace release: 1. How can this be debugged further? 2. Has anyone been able to reproduce this? 3. Is this something different entirely? Basically this makes KAuth non-functional. I'm hoping this is only a local issue, though, ;) -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KAuth and KF5
šumski wrote: > http://paste.opensuse.org/view/raw/45956382 In case the pastebin link expires: #0 QString (other=..., this=0x7fff18fa23b0) at ../../src/corelib/tools/qstring.h:814 #1 dbusInterfaceString () at qdbusintegrator.cpp:87 #2 QDBusConnectionPrivate::disconnectSignal (this=this@entry=0xa93640, it=...) at qdbusintegrator.cpp:2270 #3 0x7fde826414b1 in QDBusConnectionPrivate::objectDestroyed (this=0xa93640, obj=0xa6f720) at qdbusintegrator.cpp:1228 #4 0x7fde826883bc in QDBusConnectionPrivate::qt_static_metacall (_o=, _c=, _id=, _a=) at .moc/moc_qdbusconnection_p.cpp:131 #5 0x7fde83ebcd7e in QMetaObject::activate (sender=sender@entry=0xa6f720, signalOffset=, local_signal_index=local_signal_index@entry=0, argv=argv@entry=0x7fff18fa2610) at kernel/qobject.cpp:3680 #6 0x7fde83ebd237 in QMetaObject::activate (sender=sender@entry=0xa6f720, m=m@entry=0x7fde842caf00 , local_signal_index=local_signal_index@entry=0, argv=argv@entry=0x7fff18fa2610) at kernel/qobject.cpp:3546 #7 0x7fde83ebd2cf in QObject::destroyed (this=this@entry=0xa6f720, _t1=_t1@entry=0xa6f720) at .moc/moc_qobject.cpp:205 #8 0x7fde83ec4768 in QObject::~QObject (this=0xa6f720, __in_chrg=) at kernel/qobject.cpp:901 #9 0x7fde7b36ae39 in PolkitQt1::Authority::~Authority (this=0xa6f720, __in_chrg=) at /usr/src/debug/polkit-qt-1-0.103.0/core/polkitqt1-authority.cpp:164 #10 0x7fde7b36aa62 in PolkitQt1::(anonymous namespace)::Q_QGS_s_globalAuthority::innerFunction()::Holder::~Holder() () at /usr/src/debug/polkit-qt-1-0.103.0/core/polkitqt1-authority.cpp:40 #11 0x7fde8337df99 in __run_exit_handlers () from /lib64/libc.so.6 #12 0x7fde8337dfe5 in exit () from /lib64/libc.so.6 #13 0x7fde83367b0c in __libc_start_main () from /lib64/libc.so.6 #14 0x00402021 in _start () at ../sysdeps/x86_64/start.S:122 -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KAuth and KF5
Harald Sitter wrote: > FWIW, I noticed that kauth actually can link against a qt4 polkit-qt, > might be related.. or not ^^ This has been ruled out as openSUSE packages have a patch (under review, btw: https://git.reviewboard.kde.org/r/118264/) that prevents that. So I'm guessing the issue is somewhere else. -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
kf5-config, startkde and bug 333793
Hello,
I set out an attempt to fix bug 333793 [1] and to port kf5-config in
kdelibs4support to QCommandLineParser and QStandardPaths where possible.
The issue in the bug is that kf5-config --path lib misses ~/.local (XDG)
because basePrefixForResource (kstandarddirs.cpp) says (lines 244-250):
if (typeBa.startsWith("xdgconf") || typeBa == "config") {
return XdgConf;
} else if (typeBa == "exe" || typeBa == "lib") {
return KdePrefixes;
} else { // was: if (typeBa.startsWith("xdgdata") || typeBa == "data")
return XdgData;
}
The problem is, we're not using KdePrefixes anymore and thus --path lib is
broken in interesting ways. the most important being the impossibility of
sourcing env scripts in the user's $HOME (~/.local/env), which may break
some user customization (see the bug report).
The problem is also lies in startkde which uses that option to parse for env
scripts.
So, there are 2 possible solutions:
1. Fix KStandardDirs: I tried to dive into the coe but I really can't figure
out to fix this (I'm very naive where it comes to C++). Can someone familiar
with the code give me some pointers?
2. Fix startkde: in that other case, how can we reliably get the XDG local
dir (which is ~/.local in Linux by default but I would not assume that)?
[1] https://bugs.kde.org/show_bug.cgi?id=333793
P.S.: I have also a branch with the port of kf5-config to QCommandLineParser
and QStandardDirs where possible, I'll try to submit it for review ASAP.
--
Luca Beltrame - KDE Forums team
KDE Science supporter
GPG key ID: 6E1A4E79
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kf5-config, startkde and bug 333793
David Faure wrote:
> Well, kde4-config --path lib never included ~/.local so that's not really
> a bug.
It used to include $KDEHOME, on which startkde relied, that's probably the
cause of the bug.
> Shall we say ~/.config/startkde/env/ ?
If that's the case, we have a problem elsewhere. ;) systemsettings saves to
~/.local/share/env (I'm guessing it uses GenericDataLocation). In fact,
plasma-desktop/kcms/autostart.cpp, line 141:
QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) +
QStringLiteral("/env/");
So in this case we have to adjust the KCM as well. I can do the job, as long
as there's consensus for it.
BTW, there's a similar hack for "shutdown". In fact the KCM writes autostart
into GenericConfigLocation and env and shutdown in GenericDataLocation.
Does anyone know the reason? Should we all change them to
GenericConfigLocation?
> kf5-config is deprecated, qtpaths replaces it.
My plan was exactly to remove usage in startkde, that will also help solve
the bug.
--
Luca Beltrame - KDE Forums team
KDE Science supporter
GPG key ID: 6E1A4E79
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 119145: Use qtpaths instead of kf5-confg in startkde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- Review request for KDE Frameworks, Plasma and David Faure. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under GenericDataLocation + "env". This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122&r=1&w=2 Diffs - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 12:52 p.m.) Review request for KDE Frameworks, Plasma and David Faure. Changes --- Updated description. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description (updated) --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under GenericDataLocation + "env" (or "shutdown"). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122&r=1&w=2 Diffs - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
> On Lug. 6, 2014, 12:57 p.m., David Faure wrote: > > GenericDataLocation + env is polluting the global namespace. Imagine if > > gnome did the same... > > > > My suggestion is GenericConfigLocation + "/startkde/env/" > > or GenericConfigLocation + "/kde-workspace/env/". > > > > Yes, this means adjusting the KCM as well, of course. I know we're in deep bikeshedding territory. ;) But perhaps "plasma-workspace", given that's what's using it? > On Lug. 6, 2014, 12:57 p.m., David Faure wrote: > > startkde/startkde.cmake, line 198 > > <https://git.reviewboard.kde.org/r/119145/diff/1/?file=287769#file287769line198> > > > > concatenation doesn't really need sed. Right, I kept it out of laziness. ;) I'll fix. - Luca --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/#review61694 --- On Lug. 6, 2014, 12:52 p.m., Luca Beltrame wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119145/ > --- > > (Updated Lug. 6, 2014, 12:52 p.m.) > > > Review request for KDE Frameworks, Plasma and David Faure. > > > Bugs: 333793 > https://bugs.kde.org/show_bug.cgi?id=333793 > > > Repository: plasma-workspace > > > Description > --- > > Currently env and shutdown scripts in startkde are not run due to the way > kf5-config is used. There is no more $KDEHOME, so proper paths aren't being > found. > > This patch moves things to qtpaths, putting things under GenericDataLocation > + "env" (or "shutdown"). This is what the plasma-desktop KCM does, but > according to the discussion in [1] it may change depending on the outcome. > > [1] http://lists.kde.org/?t=14046415122&r=1&w=2 > > > Diffs > - > > startkde/startkde.cmake 24610f4 > > Diff: https://git.reviewboard.kde.org/r/119145/diff/ > > > Testing > --- > > > Thanks, > > Luca Beltrame > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 1:13 p.m.) Review request for KDE Frameworks, Plasma and David Faure. Changes --- Updated diff, resolved issues, moved to GenericConfigLocation + plasma-workspace + [env|shutdown] Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under GenericDataLocation + "env" (or "shutdown"). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122&r=1&w=2 Diffs (updated) - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 1:19 p.m.) Review request for KDE Frameworks, Plasma and David Faure. Changes --- Whoops, use ConfigLocation (there's no such thing as GenericConfigLocation) and update "libpath" to be "scriptpath" so that it's clear what it does. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description (updated) --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under ConfigLocation + "plasma-workspace" + "env" (or "shutdown"). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122&r=1&w=2 Diffs (updated) - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 119146: Autostart KCM: update env and shutdown paths to GenericConfigLocation + plasma-workspace + [env|shutdown]
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119146/ --- Review request for KDE Frameworks, Plasma and David Faure. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-desktop Description --- In order to fix bug 333793, some adjustments to both the startkde (RR 119145) and the autostart KCM are needed. This patch, like the startkde one, moves env and shutdown directories to GenericConfigLocation + plasma-workspace/[env|shutdown]. For further information on the discussion, see [1]. [1] http://lists.kde.org/?t=14046415122&r=1&w=2 Diffs - kcms/autostart/autostart.cpp 2559726 Diff: https://git.reviewboard.kde.org/r/119146/diff/ Testing --- Compiles. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
> On Lug. 6, 2014, 1:25 p.m., David Faure wrote: > > I added GenericConfigLocation to Qt 5.2.0's QStandardPaths, but indeed it's > > missing in qtpaths, I'll fix that. > > > > We should be using it, because ConfigLocation includes the appname on > > Windows (big whoops). > > David Faure wrote: > I mean we should be using it once we can depend on Qt 5.4 :) > For now ConfigLocation will do. I'll add a TODO so that it is not forgotten. - Luca --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/#review61701 --- On Lug. 6, 2014, 1:19 p.m., Luca Beltrame wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119145/ > --- > > (Updated Lug. 6, 2014, 1:19 p.m.) > > > Review request for KDE Frameworks, Plasma and David Faure. > > > Bugs: 333793 > https://bugs.kde.org/show_bug.cgi?id=333793 > > > Repository: plasma-workspace > > > Description > --- > > Currently env and shutdown scripts in startkde are not run due to the way > kf5-config is used. There is no more $KDEHOME, so proper paths aren't being > found. > > This patch moves things to qtpaths, putting things under ConfigLocation + > "plasma-workspace" + "env" (or "shutdown"). This is what the plasma-desktop > KCM does, but according to the discussion in [1] it may change depending on > the outcome. > > [1] http://lists.kde.org/?t=14046415122&r=1&w=2 > > > Diffs > - > > startkde/startkde.cmake 24610f4 > > Diff: https://git.reviewboard.kde.org/r/119145/diff/ > > > Testing > --- > > > Thanks, > > Luca Beltrame > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119146: Autostart KCM: update env and shutdown paths to GenericConfigLocation + plasma-workspace + [env|shutdown]
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119146/ --- (Updated Lug. 6, 2014, 1:33 p.m.) Review request for KDE Frameworks, Plasma and David Faure. Changes --- Add a comment explaining the reasoning for the change. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-desktop Description --- In order to fix bug 333793, some adjustments to both the startkde (RR 119145) and the autostart KCM are needed. This patch, like the startkde one, moves env and shutdown directories to GenericConfigLocation + plasma-workspace/[env|shutdown]. For further information on the discussion, see [1]. [1] http://lists.kde.org/?t=14046415122&r=1&w=2 Diffs (updated) - kcms/autostart/autostart.cpp 2559726 Diff: https://git.reviewboard.kde.org/r/119146/diff/ Testing --- Compiles. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 1:35 p.m.) Review request for KDE Frameworks, Plasma and David Faure. Changes --- Add a TODO. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under ConfigLocation + "plasma-workspace" + "env" (or "shutdown"). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122&r=1&w=2 Diffs (updated) - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
> On Lug. 6, 2014, 1:25 p.m., David Faure wrote: > > I added GenericConfigLocation to Qt 5.2.0's QStandardPaths, but indeed it's > > missing in qtpaths, I'll fix that. > > > > We should be using it, because ConfigLocation includes the appname on > > Windows (big whoops). > > David Faure wrote: > I mean we should be using it once we can depend on Qt 5.4 :) > For now ConfigLocation will do. > > Luca Beltrame wrote: > I'll add a TODO so that it is not forgotten. > > David Faure wrote: > For reference: https://codereview.qt-project.org/89209 for adding > GenericConfigLocation to qtpaths. Done. Waiting for objections / Ship it! on this one too, so that I can commit both. - Luca --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/#review61701 --- On Lug. 6, 2014, 1:35 p.m., Luca Beltrame wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119145/ > --- > > (Updated Lug. 6, 2014, 1:35 p.m.) > > > Review request for KDE Frameworks, Plasma and David Faure. > > > Bugs: 333793 > https://bugs.kde.org/show_bug.cgi?id=333793 > > > Repository: plasma-workspace > > > Description > --- > > Currently env and shutdown scripts in startkde are not run due to the way > kf5-config is used. There is no more $KDEHOME, so proper paths aren't being > found. > > This patch moves things to qtpaths, putting things under ConfigLocation + > "plasma-workspace" + "env" (or "shutdown"). This is what the plasma-desktop > KCM does, but according to the discussion in [1] it may change depending on > the outcome. > > [1] http://lists.kde.org/?t=14046415122&r=1&w=2 > > > Diffs > - > > startkde/startkde.cmake 24610f4 > > Diff: https://git.reviewboard.kde.org/r/119145/diff/ > > > Testing > --- > > > Thanks, > > Luca Beltrame > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 1:44 p.m.) Review request for KDE Frameworks, Plasma and David Faure. Changes --- Updated comments in the code. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under ConfigLocation + "plasma-workspace" + "env" (or "shutdown"). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122&r=1&w=2 Diffs (updated) - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 1:46 p.m.) Review request for KDE Frameworks, Plasma and David Faure. Changes --- Fixed wrong name in the comment (plasma-desktop instead of plasma-workspace). Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under ConfigLocation + "plasma-workspace" + "env" (or "shutdown"). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122&r=1&w=2 Diffs (updated) - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated July 6, 2014, 2:41 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Plasma and David Faure. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-workspace Description --- Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found. This patch moves things to qtpaths, putting things under ConfigLocation + "plasma-workspace" + "env" (or "shutdown"). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122&r=1&w=2 Diffs - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119146: Autostart KCM: update env and shutdown paths to GenericConfigLocation + plasma-workspace + [env|shutdown]
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119146/ --- (Updated July 6, 2014, 2:43 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Plasma and David Faure. Bugs: 333793 https://bugs.kde.org/show_bug.cgi?id=333793 Repository: plasma-desktop Description --- In order to fix bug 333793, some adjustments to both the startkde (RR 119145) and the autostart KCM are needed. This patch, like the startkde one, moves env and shutdown directories to GenericConfigLocation + plasma-workspace/[env|shutdown]. For further information on the discussion, see [1]. [1] http://lists.kde.org/?t=14046415122&r=1&w=2 Diffs - kcms/autostart/autostart.cpp 2559726 Diff: https://git.reviewboard.kde.org/r/119146/diff/ Testing --- Compiles. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
What to do with autostart scripts? (kinit / ksmserver problem)
Hello, commit f913e251fe66e22606c380a8cc0ddc8c69e3c07d in plasma-workspace removed autostart support in ksmserver because it caused .desktop files to be autostarted twice (one for kinit, and one for ksmserver). I just noticed that it causes a regression in behavior from 4.x times, as user scripts (like adding ssh-agents etc.) are no longer run (because kinit only runs .desktop files). So, this needs to be either communicated to the users or handled differently (yes, I don't want to wade through possible complaints in the forums ;) My high (uniformed) level opinion on the possible scenarios: - Re-enable autostart for everything but desktop files in ksmserver; - Add support for scripts in kinit (does it even make sense?); - Drop autostart scripts, tell users to make .desktop files What do the gurus say on this? -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Call for help: possible race conditions in KAuth
When submitting KAuth to openSUSE, the SUSE security team found possible race conditions that could lead to security issues[1]- I'm writing here because until these issues are solved, KAuth will not be accepted into openSUSE. The second reason I'm posting this here is because it seems people involved with KAuth are not reachable: - security@ko was contacted without an answer; - other KDE people including drf were contacted without a response; Some discussion was raised with Martin Briza (CC'ed just in case, so he may provide some insight, at least) with regards to polkit-qt-1 issues which were (to my understanding) fixed. I can say I cannot fix this at all (I can write C++, but I have neither the skill nor the time to fix what's needed here), and therefore this is a cry for help to see at least the identification of the issue and a fix or workaround, or just an explanation why this is not an issue. I think this is quite important as KAuth is a security-related framework. [1] https://bugzilla.novell.com/show_bug.cgi?id=864716#c41 -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119323: fix auth race condition
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/#review62520 --- I ran the (few) autotests, and those also pass. I can't test it runtime, will do so later hopefully. - Luca Beltrame On Lug. 16, 2014, 4:05 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119323/ > --- > > (Updated Lug. 16, 2014, 4:05 p.m.) > > > Review request for KDE Frameworks, Hrvoje Senjan, Luca Beltrame, and Martin > Bříza. > > > Repository: kauth > > > Description > --- > > pid based auth is racy because of pid reuse, don't use it. > > > Diffs > - > > src/backends/polkit-1/Polkit1Backend.cpp 165f7bb > > Diff: https://git.reviewboard.kde.org/r/119323/diff/ > > > Testing > --- > > it builds > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Call for help: possible race conditions in KAuth
Luca Beltrame wrote: > When submitting KAuth to openSUSE, the SUSE security team found possible > race conditions that could lead to security issues[1]- For reference, there is a RR at https://git.reviewboard.kde.org/r/119323/. Input by knowledgeable people is welcome! -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119323: fix auth race condition
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/#review62547 --- FYI, this probably needs to go in kdelibs too as the issue is there too. I and Hrvoje are currently testing also a version for 4.x. - Luca Beltrame On Lug. 16, 2014, 4:05 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119323/ > --- > > (Updated Lug. 16, 2014, 4:05 p.m.) > > > Review request for KDE Frameworks, Hrvoje Senjan, Luca Beltrame, and Martin > Bříza. > > > Repository: kauth > > > Description > --- > > pid based auth is racy because of pid reuse, don't use it. > > > Diffs > - > > src/backends/polkit-1/Polkit1Backend.cpp 165f7bb > > Diff: https://git.reviewboard.kde.org/r/119323/diff/ > > > Testing > --- > > it builds > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KXMLGUI and KParts
Hello, while testing out Yakuake (frameworks) I noticed that it would not display the context menu. Konsole had a similar issue, but that was fixed by adjusting the calls that loaded the XML file (this occurred after the port to KXMLGUI_INSTALL_DIR). However this did not occur with Yakuake, which uses the Konsole KPart. In fact I kept on getting cannot find .rc file "partui.rc" for component "yakuake" where "partui.rc" is the Konsole KXMLGUI rc file. The only way I could fix it was to create a "yakuake" directory under the kxmlgui install dir and symlink the rc file there. Given that this is *highly* suboptimal: - Is Yakuake doing something wrong? - Is this a bug? - Or instead the code loading the KPart needs to be adjusted? -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KXMLGUI and KParts
Luca Beltrame wrote: > - Or instead the code loading the KPart needs to be adjusted? Just FYI: the issue was in Konsole, which did not set a component name. This was fixed in g88ffcc8 in Konsole (frameworks branch). -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119323: fix auth race condition
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/#review62631 --- Ship it! I have been using this for 4.x and 5.x for a while without issues. Unit tests (no matter how little they are) also pass, so this should go in. IMO this should also be pushed for kdelibs, which is affected in the same manner. - Luca Beltrame On Lug. 17, 2014, 11:23 a.m., Martin Tobias Holmedahl Sandsmark wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119323/ > --- > > (Updated Lug. 17, 2014, 11:23 a.m.) > > > Review request for KDE Frameworks, Hrvoje Senjan, Luca Beltrame, and Martin > Bříza. > > > Repository: kauth > > > Description > --- > > pid based auth is racy because of pid reuse, don't use it. > > > Diffs > - > > src/backends/polkit-1/Polkit1Backend.cpp 165f7bb > > Diff: https://git.reviewboard.kde.org/r/119323/diff/ > > > Testing > --- > > it builds > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119542: create qapplication before using dbus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119542/#review63482 --- +1, from what I've seen it looks fairly harmless. - Luca Beltrame On Lug. 30, 2014, 12:43 a.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119542/ > --- > > (Updated Lug. 30, 2014, 12:43 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kauth > > > Description > --- > > qt doesn't take very kindly to using dbus before having a qcoreapplication, > so move the app init before the helper proxy init (which might be using > dbus) to avoid possible issues in the future > > > Diffs > - > > src/kauthhelpersupport.cpp 99868803fdfaf99283d65a8ab61e7a32fb22e708 > > Diff: https://git.reviewboard.kde.org/r/119542/diff/ > > > Testing > --- > > > Thanks, > > Harald Sitter > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119540: don't construct bogus KAuthAction objects
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119540/#review63509
---
My question is, is KAuth being constructed with a default string ("") useful to
anyone? IMO the issue, if any, it's there, and this looks like a workaround.
(But I claim no expertise on the code, so feel free to flame me :P)
- Luca Beltrame
On Lug. 30, 2014, 12:32 a.m., Harald Sitter wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119540/
> ---
>
> (Updated Lug. 30, 2014, 12:32 a.m.)
>
>
> Review request for KDE Frameworks, Hrvoje Senjan and Martin Bříza.
>
>
> Repository: kconfigwidgets
>
>
> Description
> ---
>
> KAuthAction(0) actually calls the QString constructor which will dispatch
> bogus polkit auth checks, polkitqt and polkitd are not terribly happy about
> those and subsequently don't want to talk to the KCM anymore, even if it
> manages to create a proper Action
>
> creating a null Action rather than accidentally triggering the QString
> ctor ensures that we only do polkit interaction with reasonable actionids
> making sure that authentication works as expected
>
>
> Diffs
> -
>
> src/kcmodule.cpp 92e5427c121491e4ebf289addda040cc117cdd68
>
> Diff: https://git.reviewboard.kde.org/r/119540/diff/
>
>
> Testing
> ---
>
> tested with clock kcm, succesfully can talk with the helper app if the bogus
> actionid "" wasn't used intermediately
>
>
> Thanks,
>
> Harald Sitter
>
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: What to do with autostart scripts? (kinit / ksmserver problem)
In data martedì 19 agosto 2014 21:48:04, David Faure ha scritto: > I'd pick option 1 - do it all in ksmserver. I suppose this would mean running all but .desktop files (which are handled by kinit)? -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Split kde-baseapps?
Michael Palimaka wrote: > Are there any plans to split frameworks-based kde-baseapps? IMO it would make sense first to consult with the various applications' maintainers and / or review what's in there and what should happen to it. -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Split kde-baseapps?
Aleix Pol wrote: > - kioslave/about: I guess it should go either to kioslave-extras or > konqueror itself. I guess it's here because the applications use it, so > kioslave. I'm wondering how many use that KIO slave aside konqueror... > - kfind: looks like it could be split. Doesn't look maintained, we can > decide where to put it later on. It's an executable, so it's easy to move > around. Should it be part of the workspace? > - konqplugins: By the name sounds like it should go wherever konqueror > goes. Or do other applications use them? > - nsplugins: same, wherever konqueror goes? I've seen them used by konqueror only, but I have no experience in the area. libkonq also lives in kde-baseapps, and that lib is used by dolphin at minimum (IIRC). -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121078: Fix exports.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/#review70678 --- This breaks compilation on Linux (was this tested?) and on CI: fatal error: libdolphin_export.h: No such file or directory - Luca Beltrame On Nov. 20, 2014, 3:29 a.m., Andrius da Costa Ribas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121078/ > --- > > (Updated Nov. 20, 2014, 3:29 a.m.) > > > Review request for KDE Base Apps, KDE Frameworks and kdewin. > > > Repository: kde-baseapps > > > Description > --- > > Use CMake's generate_export_header whenever possible, and fix some > inconsistent exports. > Also, use Q_DECL_EXPORT consistently across occurrences of kdemain for > kdeinit apps (removing kdemacros.h where KDE_EXPORT was being in use). > > > Diffs > - > > dolphin/src/views/dolphinfileitemlistwidget.h 5f7c181 > dolphin/src/views/dolphinitemlistview.h 7fd72e5 > dolphin/src/views/versioncontrol/updateitemstatesthread.h 9b744d5 > dolphin/src/views/versioncontrol/versioncontrolobserver.h 034ef8b > dolphin/src/views/viewmodecontroller.h 9ea717a > dolphin/src/views/viewproperties.h d3ea428 > keditbookmarks/kbookmarkmodel/CMakeLists.txt 2f83af2 > keditbookmarks/kbookmarkmodel/kbookmarkmodel_export.h b759bf9 > keditbookmarks/main.cpp bc64193 > konqueror/client/kfmclient.cpp 276452b > konqueror/src/CMakeLists.txt 6831c88 > konqueror/src/konq_statusbarmessagelabel.h a115d39 > konqueror/src/konqmain.cpp 7a73231 > konqueror/src/konqprivate_export.h 2dec78b > dolphin/src/libdolphin_export.h ff0f125 > dolphin/src/main.cpp 91d32a0 > dolphin/src/kitemviews/private/kitemlistviewlayouter.h 0efcab1 > dolphin/src/CMakeLists.txt c074908 > dolphin/src/kitemviews/kfileitemlistview.h 9f07c9d > dolphin/src/kitemviews/kfileitemlistwidget.h b7061d3 > dolphin/src/kitemviews/kfileitemmodel.h 535e0f3 > dolphin/src/kitemviews/kfileitemmodelrolesupdater.h e8b186a > dolphin/src/kitemviews/kitemlistcontainer.h 55a9a11 > dolphin/src/kitemviews/kitemlistcontroller.h 99df531 > dolphin/src/kitemviews/kitemlistgroupheader.h 66fe929 > dolphin/src/kitemviews/kitemlistheader.h fe2d0ac > dolphin/src/kitemviews/kitemlistselectionmanager.h c4decd3 > dolphin/src/kitemviews/kitemliststyleoption.h 782dd0e > dolphin/src/kitemviews/kitemlistview.h cc0754f > dolphin/src/kitemviews/kitemlistviewaccessible.h 674f1d1 > dolphin/src/kitemviews/kitemlistwidget.h 07fc789 > dolphin/src/kitemviews/kitemmodelbase.h 283cfa5 > dolphin/src/kitemviews/kstandarditem.h 59190bf > dolphin/src/kitemviews/kstandarditemlistgroupheader.h 871c93d > dolphin/src/kitemviews/kstandarditemlistview.h eb07c7f > dolphin/src/kitemviews/kstandarditemlistwidget.h 7683f84 > dolphin/src/kitemviews/kstandarditemmodel.h 9d1db1a > dolphin/src/kitemviews/private/kbaloorolesprovider.h f1ad5c7 > dolphin/src/kitemviews/private/kfileitemmodeldirlister.h 94a0e39 > dolphin/src/kitemviews/private/kfileitemmodelfilter.h e4fb0a2 > dolphin/src/kitemviews/private/kitemlistheaderwidget.h b99f45f > dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.h 661178d > dolphin/src/kitemviews/private/kitemlistrubberband.h aea58af > dolphin/src/kitemviews/private/kitemlistselectiontoggle.h 8a1a857 > dolphin/src/kitemviews/private/kitemlistsizehintresolver.h a0ad033 > dolphin/src/kitemviews/private/kitemlistsmoothscroller.h ea56822 > dolphin/src/kitemviews/private/kitemlistviewanimation.h e2e5338 > dolphin/src/kitemviews/private/kpixmapmodifier.h 4f863c3 > > Diff: https://git.reviewboard.kde.org/r/121078/diff/ > > > Testing > --- > > It builds (MSVC2013 - 64bit) after this patch (along other patches I'm > sending to review today). Kdebase-apps is still not very functional, though > (missing icons and weird UI). > > > Thanks, > > Andrius da Costa Ribas > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121078: Fix exports.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/#review70680 --- dolphin/src/CMakeLists.txt <https://git.reviewboard.kde.org/r/121078/#comment49452> This one was missing from the commit and broke the build. I fixed it in 9cd55421bdadc663c947ddac9504a8d916e87012. - Luca Beltrame On Nov. 20, 2014, 3:29 a.m., Andrius da Costa Ribas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121078/ > --- > > (Updated Nov. 20, 2014, 3:29 a.m.) > > > Review request for KDE Base Apps, KDE Frameworks and kdewin. > > > Repository: kde-baseapps > > > Description > --- > > Use CMake's generate_export_header whenever possible, and fix some > inconsistent exports. > Also, use Q_DECL_EXPORT consistently across occurrences of kdemain for > kdeinit apps (removing kdemacros.h where KDE_EXPORT was being in use). > > > Diffs > - > > dolphin/src/views/dolphinfileitemlistwidget.h 5f7c181 > dolphin/src/views/dolphinitemlistview.h 7fd72e5 > dolphin/src/views/versioncontrol/updateitemstatesthread.h 9b744d5 > dolphin/src/views/versioncontrol/versioncontrolobserver.h 034ef8b > dolphin/src/views/viewmodecontroller.h 9ea717a > dolphin/src/views/viewproperties.h d3ea428 > keditbookmarks/kbookmarkmodel/CMakeLists.txt 2f83af2 > keditbookmarks/kbookmarkmodel/kbookmarkmodel_export.h b759bf9 > keditbookmarks/main.cpp bc64193 > konqueror/client/kfmclient.cpp 276452b > konqueror/src/CMakeLists.txt 6831c88 > konqueror/src/konq_statusbarmessagelabel.h a115d39 > konqueror/src/konqmain.cpp 7a73231 > konqueror/src/konqprivate_export.h 2dec78b > dolphin/src/libdolphin_export.h ff0f125 > dolphin/src/main.cpp 91d32a0 > dolphin/src/kitemviews/private/kitemlistviewlayouter.h 0efcab1 > dolphin/src/CMakeLists.txt c074908 > dolphin/src/kitemviews/kfileitemlistview.h 9f07c9d > dolphin/src/kitemviews/kfileitemlistwidget.h b7061d3 > dolphin/src/kitemviews/kfileitemmodel.h 535e0f3 > dolphin/src/kitemviews/kfileitemmodelrolesupdater.h e8b186a > dolphin/src/kitemviews/kitemlistcontainer.h 55a9a11 > dolphin/src/kitemviews/kitemlistcontroller.h 99df531 > dolphin/src/kitemviews/kitemlistgroupheader.h 66fe929 > dolphin/src/kitemviews/kitemlistheader.h fe2d0ac > dolphin/src/kitemviews/kitemlistselectionmanager.h c4decd3 > dolphin/src/kitemviews/kitemliststyleoption.h 782dd0e > dolphin/src/kitemviews/kitemlistview.h cc0754f > dolphin/src/kitemviews/kitemlistviewaccessible.h 674f1d1 > dolphin/src/kitemviews/kitemlistwidget.h 07fc789 > dolphin/src/kitemviews/kitemmodelbase.h 283cfa5 > dolphin/src/kitemviews/kstandarditem.h 59190bf > dolphin/src/kitemviews/kstandarditemlistgroupheader.h 871c93d > dolphin/src/kitemviews/kstandarditemlistview.h eb07c7f > dolphin/src/kitemviews/kstandarditemlistwidget.h 7683f84 > dolphin/src/kitemviews/kstandarditemmodel.h 9d1db1a > dolphin/src/kitemviews/private/kbaloorolesprovider.h f1ad5c7 > dolphin/src/kitemviews/private/kfileitemmodeldirlister.h 94a0e39 > dolphin/src/kitemviews/private/kfileitemmodelfilter.h e4fb0a2 > dolphin/src/kitemviews/private/kitemlistheaderwidget.h b99f45f > dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.h 661178d > dolphin/src/kitemviews/private/kitemlistrubberband.h aea58af > dolphin/src/kitemviews/private/kitemlistselectiontoggle.h 8a1a857 > dolphin/src/kitemviews/private/kitemlistsizehintresolver.h a0ad033 > dolphin/src/kitemviews/private/kitemlistsmoothscroller.h ea56822 > dolphin/src/kitemviews/private/kitemlistviewanimation.h e2e5338 > dolphin/src/kitemviews/private/kpixmapmodifier.h 4f863c3 > > Diff: https://git.reviewboard.kde.org/r/121078/diff/ > > > Testing > --- > > It builds (MSVC2013 - 64bit) after this patch (along other patches I'm > sending to review today). Kdebase-apps is still not very functional, though > (missing icons and weird UI). > > > Thanks, > > Andrius da Costa Ribas > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121078: Fix exports.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/#review70681 --- Actually it's still broken: I didn't notice because I did not build tests: /srv/jenkins/workspace/kde-baseapps_frameworks_qt5/konqueror/src/konqapplication.h:28:46: error: expected initializer before ‘:’ token The line being class KONQ_TESTS_EXPORT KonquerorApplication : public KApplication - Luca Beltrame On Nov. 20, 2014, 3:29 a.m., Andrius da Costa Ribas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121078/ > --- > > (Updated Nov. 20, 2014, 3:29 a.m.) > > > Review request for KDE Base Apps, KDE Frameworks and kdewin. > > > Repository: kde-baseapps > > > Description > --- > > Use CMake's generate_export_header whenever possible, and fix some > inconsistent exports. > Also, use Q_DECL_EXPORT consistently across occurrences of kdemain for > kdeinit apps (removing kdemacros.h where KDE_EXPORT was being in use). > > > Diffs > - > > dolphin/src/views/dolphinfileitemlistwidget.h 5f7c181 > dolphin/src/views/dolphinitemlistview.h 7fd72e5 > dolphin/src/views/versioncontrol/updateitemstatesthread.h 9b744d5 > dolphin/src/views/versioncontrol/versioncontrolobserver.h 034ef8b > dolphin/src/views/viewmodecontroller.h 9ea717a > dolphin/src/views/viewproperties.h d3ea428 > keditbookmarks/kbookmarkmodel/CMakeLists.txt 2f83af2 > keditbookmarks/kbookmarkmodel/kbookmarkmodel_export.h b759bf9 > keditbookmarks/main.cpp bc64193 > konqueror/client/kfmclient.cpp 276452b > konqueror/src/CMakeLists.txt 6831c88 > konqueror/src/konq_statusbarmessagelabel.h a115d39 > konqueror/src/konqmain.cpp 7a73231 > konqueror/src/konqprivate_export.h 2dec78b > dolphin/src/libdolphin_export.h ff0f125 > dolphin/src/main.cpp 91d32a0 > dolphin/src/kitemviews/private/kitemlistviewlayouter.h 0efcab1 > dolphin/src/CMakeLists.txt c074908 > dolphin/src/kitemviews/kfileitemlistview.h 9f07c9d > dolphin/src/kitemviews/kfileitemlistwidget.h b7061d3 > dolphin/src/kitemviews/kfileitemmodel.h 535e0f3 > dolphin/src/kitemviews/kfileitemmodelrolesupdater.h e8b186a > dolphin/src/kitemviews/kitemlistcontainer.h 55a9a11 > dolphin/src/kitemviews/kitemlistcontroller.h 99df531 > dolphin/src/kitemviews/kitemlistgroupheader.h 66fe929 > dolphin/src/kitemviews/kitemlistheader.h fe2d0ac > dolphin/src/kitemviews/kitemlistselectionmanager.h c4decd3 > dolphin/src/kitemviews/kitemliststyleoption.h 782dd0e > dolphin/src/kitemviews/kitemlistview.h cc0754f > dolphin/src/kitemviews/kitemlistviewaccessible.h 674f1d1 > dolphin/src/kitemviews/kitemlistwidget.h 07fc789 > dolphin/src/kitemviews/kitemmodelbase.h 283cfa5 > dolphin/src/kitemviews/kstandarditem.h 59190bf > dolphin/src/kitemviews/kstandarditemlistgroupheader.h 871c93d > dolphin/src/kitemviews/kstandarditemlistview.h eb07c7f > dolphin/src/kitemviews/kstandarditemlistwidget.h 7683f84 > dolphin/src/kitemviews/kstandarditemmodel.h 9d1db1a > dolphin/src/kitemviews/private/kbaloorolesprovider.h f1ad5c7 > dolphin/src/kitemviews/private/kfileitemmodeldirlister.h 94a0e39 > dolphin/src/kitemviews/private/kfileitemmodelfilter.h e4fb0a2 > dolphin/src/kitemviews/private/kitemlistheaderwidget.h b99f45f > dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.h 661178d > dolphin/src/kitemviews/private/kitemlistrubberband.h aea58af > dolphin/src/kitemviews/private/kitemlistselectiontoggle.h 8a1a857 > dolphin/src/kitemviews/private/kitemlistsizehintresolver.h a0ad033 > dolphin/src/kitemviews/private/kitemlistsmoothscroller.h ea56822 > dolphin/src/kitemviews/private/kitemlistviewanimation.h e2e5338 > dolphin/src/kitemviews/private/kpixmapmodifier.h 4f863c3 > > Diff: https://git.reviewboard.kde.org/r/121078/diff/ > > > Testing > --- > > It builds (MSVC2013 - 64bit) after this patch (along other patches I'm > sending to review today). Kdebase-apps is still not very functional, though > (missing icons and weird UI). > > > Thanks, > > Andrius da Costa Ribas > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121078: Fix exports.
> On Nov. 20, 2014, 9 a.m., Luca Beltrame wrote: > > Actually it's still broken: I didn't notice because I did not build tests: > > > > > > /srv/jenkins/workspace/kde-baseapps_frameworks_qt5/konqueror/src/konqapplication.h:28:46: > > error: expected initializer before ‘:’ token > > > > The line being > > > > class KONQ_TESTS_EXPORT KonquerorApplication : public KApplication And finally fixed. - Luca --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/#review70681 --- On Nov. 20, 2014, 3:29 a.m., Andrius da Costa Ribas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121078/ > --- > > (Updated Nov. 20, 2014, 3:29 a.m.) > > > Review request for KDE Base Apps, KDE Frameworks and kdewin. > > > Repository: kde-baseapps > > > Description > --- > > Use CMake's generate_export_header whenever possible, and fix some > inconsistent exports. > Also, use Q_DECL_EXPORT consistently across occurrences of kdemain for > kdeinit apps (removing kdemacros.h where KDE_EXPORT was being in use). > > > Diffs > - > > dolphin/src/views/dolphinfileitemlistwidget.h 5f7c181 > dolphin/src/views/dolphinitemlistview.h 7fd72e5 > dolphin/src/views/versioncontrol/updateitemstatesthread.h 9b744d5 > dolphin/src/views/versioncontrol/versioncontrolobserver.h 034ef8b > dolphin/src/views/viewmodecontroller.h 9ea717a > dolphin/src/views/viewproperties.h d3ea428 > keditbookmarks/kbookmarkmodel/CMakeLists.txt 2f83af2 > keditbookmarks/kbookmarkmodel/kbookmarkmodel_export.h b759bf9 > keditbookmarks/main.cpp bc64193 > konqueror/client/kfmclient.cpp 276452b > konqueror/src/CMakeLists.txt 6831c88 > konqueror/src/konq_statusbarmessagelabel.h a115d39 > konqueror/src/konqmain.cpp 7a73231 > konqueror/src/konqprivate_export.h 2dec78b > dolphin/src/libdolphin_export.h ff0f125 > dolphin/src/main.cpp 91d32a0 > dolphin/src/kitemviews/private/kitemlistviewlayouter.h 0efcab1 > dolphin/src/CMakeLists.txt c074908 > dolphin/src/kitemviews/kfileitemlistview.h 9f07c9d > dolphin/src/kitemviews/kfileitemlistwidget.h b7061d3 > dolphin/src/kitemviews/kfileitemmodel.h 535e0f3 > dolphin/src/kitemviews/kfileitemmodelrolesupdater.h e8b186a > dolphin/src/kitemviews/kitemlistcontainer.h 55a9a11 > dolphin/src/kitemviews/kitemlistcontroller.h 99df531 > dolphin/src/kitemviews/kitemlistgroupheader.h 66fe929 > dolphin/src/kitemviews/kitemlistheader.h fe2d0ac > dolphin/src/kitemviews/kitemlistselectionmanager.h c4decd3 > dolphin/src/kitemviews/kitemliststyleoption.h 782dd0e > dolphin/src/kitemviews/kitemlistview.h cc0754f > dolphin/src/kitemviews/kitemlistviewaccessible.h 674f1d1 > dolphin/src/kitemviews/kitemlistwidget.h 07fc789 > dolphin/src/kitemviews/kitemmodelbase.h 283cfa5 > dolphin/src/kitemviews/kstandarditem.h 59190bf > dolphin/src/kitemviews/kstandarditemlistgroupheader.h 871c93d > dolphin/src/kitemviews/kstandarditemlistview.h eb07c7f > dolphin/src/kitemviews/kstandarditemlistwidget.h 7683f84 > dolphin/src/kitemviews/kstandarditemmodel.h 9d1db1a > dolphin/src/kitemviews/private/kbaloorolesprovider.h f1ad5c7 > dolphin/src/kitemviews/private/kfileitemmodeldirlister.h 94a0e39 > dolphin/src/kitemviews/private/kfileitemmodelfilter.h e4fb0a2 > dolphin/src/kitemviews/private/kitemlistheaderwidget.h b99f45f > dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.h 661178d > dolphin/src/kitemviews/private/kitemlistrubberband.h aea58af > dolphin/src/kitemviews/private/kitemlistselectiontoggle.h 8a1a857 > dolphin/src/kitemviews/private/kitemlistsizehintresolver.h a0ad033 > dolphin/src/kitemviews/private/kitemlistsmoothscroller.h ea56822 > dolphin/src/kitemviews/private/kitemlistviewanimation.h e2e5338 > dolphin/src/kitemviews/private/kpixmapmodifier.h 4f863c3 > > Diff: https://git.reviewboard.kde.org/r/121078/diff/ > > > Testing > --- > > It builds (MSVC2013 - 64bit) after this patch (along other patches I'm > sending to review today). Kdebase-apps is still not very functional, though > (missing icons and weird UI). > > > Thanks, > > Andrius da Costa Ribas > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121850: Port KRunner to categorized logging
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121850/ --- Review request for KDE Frameworks, Plasma and Vishesh Handa. Bugs: 342491 https://bugs.kde.org/show_bug.cgi?id=342491 Repository: krunner Description --- This ports KRunner to categorized logging to reduce verbosity. Notice: I've duplicated the code in declarative/ because it has separate CMakeLists. I can fix it (suggestions welcome on how to do it) or just remove the categorized logging there if not needed. Diffs - src/runnermanager.cpp 0cf8120 src/runnerjobs.cpp b090821 src/querymatch.cpp d22f4f0 src/runnercontext.cpp c7070ac src/declarative/CMakeLists.txt 5d73e10 src/declarative/runnermodel.cpp 4fd2f2b src/declarative/runnermodelplugin.cpp 33539a9 src/abstractrunner.cpp 9693ed8 src/CMakeLists.txt 71d7409 Diff: https://git.reviewboard.kde.org/r/121850/diff/ Testing --- Compiles. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121850: Port KRunner to categorized logging
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121850/ --- (Updated Gen. 5, 2015, 9:41 a.m.) Review request for KDE Frameworks and Vishesh Handa. Changes --- Add the missing files. Bugs: 342491 https://bugs.kde.org/show_bug.cgi?id=342491 Repository: krunner Description --- This ports KRunner to categorized logging to reduce verbosity. Notice: I've duplicated the code in declarative/ because it has separate CMakeLists. I can fix it (suggestions welcome on how to do it) or just remove the categorized logging there if not needed. Diffs (updated) - src/CMakeLists.txt 71d7409 src/abstractrunner.cpp 9693ed8 src/declarative/CMakeLists.txt 5d73e10 src/declarative/runnermodel.cpp 4fd2f2b src/declarative/runnermodelplugin.cpp 33539a9 src/querymatch.cpp d22f4f0 src/runnercontext.cpp c7070ac src/runnerjobs.cpp b090821 src/runnermanager.cpp 0cf8120 Diff: https://git.reviewboard.kde.org/r/121850/diff/ Testing --- Compiles. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121850: Port KRunner to categorized logging
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121850/ --- (Updated Gen. 5, 2015, 9:41 a.m.) Review request for KDE Frameworks, Plasma and Vishesh Handa. Bugs: 342491 https://bugs.kde.org/show_bug.cgi?id=342491 Repository: krunner Description --- This ports KRunner to categorized logging to reduce verbosity. Notice: I've duplicated the code in declarative/ because it has separate CMakeLists. I can fix it (suggestions welcome on how to do it) or just remove the categorized logging there if not needed. Diffs - src/CMakeLists.txt 71d7409 src/abstractrunner.cpp 9693ed8 src/declarative/CMakeLists.txt 5d73e10 src/declarative/runnermodel.cpp 4fd2f2b src/declarative/runnermodelplugin.cpp 33539a9 src/querymatch.cpp d22f4f0 src/runnercontext.cpp c7070ac src/runnerjobs.cpp b090821 src/runnermanager.cpp 0cf8120 Diff: https://git.reviewboard.kde.org/r/121850/diff/ Testing --- Compiles. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121850: Port KRunner to categorized logging
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121850/ --- (Updated Gen. 5, 2015, 9:45 a.m.) Review request for KDE Frameworks, Plasma and Vishesh Handa. Changes --- *Really* add the missing files this time. Bugs: 342491 https://bugs.kde.org/show_bug.cgi?id=342491 Repository: krunner Description --- This ports KRunner to categorized logging to reduce verbosity. Notice: I've duplicated the code in declarative/ because it has separate CMakeLists. I can fix it (suggestions welcome on how to do it) or just remove the categorized logging there if not needed. Diffs (updated) - src/CMakeLists.txt 71d7409 src/abstractrunner.cpp 9693ed8 src/declarative/CMakeLists.txt 5d73e10 src/declarative/krunner_debug.h PRE-CREATION src/declarative/krunner_debug.cpp PRE-CREATION src/declarative/runnermodel.cpp 4fd2f2b src/declarative/runnermodelplugin.cpp 33539a9 src/krunner_debug.h PRE-CREATION src/krunner_debug.cpp PRE-CREATION src/querymatch.cpp d22f4f0 src/runnercontext.cpp c7070ac src/runnerjobs.cpp b090821 src/runnermanager.cpp 0cf8120 Diff: https://git.reviewboard.kde.org/r/121850/diff/ Testing --- Compiles. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121850: Port KRunner to categorized logging
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121850/ --- (Updated Jan. 5, 2015, 12:20 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Plasma and Vishesh Handa. Bugs: 342491 https://bugs.kde.org/show_bug.cgi?id=342491 Repository: krunner Description --- This ports KRunner to categorized logging to reduce verbosity. Notice: I've duplicated the code in declarative/ because it has separate CMakeLists. I can fix it (suggestions welcome on how to do it) or just remove the categorized logging there if not needed. Diffs - src/CMakeLists.txt 71d7409 src/abstractrunner.cpp 9693ed8 src/declarative/CMakeLists.txt 5d73e10 src/declarative/krunner_debug.h PRE-CREATION src/declarative/krunner_debug.cpp PRE-CREATION src/declarative/runnermodel.cpp 4fd2f2b src/declarative/runnermodelplugin.cpp 33539a9 src/krunner_debug.h PRE-CREATION src/krunner_debug.cpp PRE-CREATION src/querymatch.cpp d22f4f0 src/runnercontext.cpp c7070ac src/runnerjobs.cpp b090821 src/runnermanager.cpp 0cf8120 Diff: https://git.reviewboard.kde.org/r/121850/diff/ Testing --- Compiles. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- Like the corresponding properties in QML's Image, this patch introduces paintedWidth and paintedHeight to QPixmapItem, to get information on the size of the pixmap that's actually shown (depending on fillMode), as compared to its actual size. This brings QPixmapItem closer to the mode of usage of Image. CHANGELOG: New properties paintedWidth and paintedHeight added to QPixmapItem Diffs - src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h 485d6f7 src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp 6c9e3a2 Diff: https://git.reviewboard.kde.org/r/122413/diff/ Testing --- Builds. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- (Updated Feb. 3, 2015, 8:32 p.m.) Review request for KDE Frameworks. Changes --- Only update paintedWidth and height if they change. Repository: kdeclarative Description --- Like the corresponding properties in QML's Image, this patch introduces paintedWidth and paintedHeight to QPixmapItem, to get information on the size of the pixmap that's actually shown (depending on fillMode), as compared to its actual size. This brings QPixmapItem closer to the mode of usage of Image. CHANGELOG: New properties paintedWidth and paintedHeight added to QPixmapItem Diffs (updated) - src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp 6c9e3a2 src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h 485d6f7 Diff: https://git.reviewboard.kde.org/r/122413/diff/ Testing --- Builds. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem
> On Feb. 3, 2015, 8:28 p.m., David Edmundson wrote:
> > src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp, line 159
> > <https://git.reviewboard.kde.org/r/122413/diff/1/?file=346713#file346713line159>
> >
> > only emit if we've actually changed, otherwise every binding is going
> > to be recalculated every frame.
something like
if (rect.height() != m_paintedHeight) {
emit ...
}
?
> On Feb. 3, 2015, 8:28 p.m., David Edmundson wrote:
> > src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h, line 34
> > <https://git.reviewboard.kde.org/r/122413/diff/1/?file=346712#file346712line34>
> >
> > if it goes here it should go on qimageitem too
> > should be a copy and paste.
I plan to do so in a separate commit once this is in.
- Luca
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122413/#review75332
-------
On Feb. 3, 2015, 8:32 p.m., Luca Beltrame wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122413/
> ---
>
> (Updated Feb. 3, 2015, 8:32 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdeclarative
>
>
> Description
> ---
>
> Like the corresponding properties in QML's Image, this patch introduces
> paintedWidth and paintedHeight to QPixmapItem, to get information on the size
> of the pixmap that's actually shown (depending on fillMode), as compared to
> its actual size.
>
> This brings QPixmapItem closer to the mode of usage of Image.
>
> CHANGELOG: New properties paintedWidth and paintedHeight added to QPixmapItem
>
>
> Diffs
> -
>
> src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp 6c9e3a2
> src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h 485d6f7
>
> Diff: https://git.reviewboard.kde.org/r/122413/diff/
>
>
> Testing
> ---
>
> Builds.
>
>
> Thanks,
>
> Luca Beltrame
>
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- (Updated Feb. 3, 2015, 8:33 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- Like the corresponding properties in QML's Image, this patch introduces paintedWidth and paintedHeight to QPixmapItem, to get information on the size of the pixmap that's actually shown (depending on fillMode), as compared to its actual size. This brings QPixmapItem closer to the mode of usage of Image. CHANGELOG: New properties paintedWidth and paintedHeight added to QPixmapItem Diffs - src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp 6c9e3a2 src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h 485d6f7 Diff: https://git.reviewboard.kde.org/r/122413/diff/ Testing --- Builds. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem
> On Feb. 3, 2015, 8:43 p.m., David Edmundson wrote: > > Next set of bugs: > > - what about if the paintedWidth is requested before the item's source has > > first been set? > > - or if the item is currently invisible? (what should that return? I'm not > > sure what Image does) > > > > > > Other thought: > > I don't really like that we won't update until after we paint which only > > happens once all previous binding finishes. So we'll always be one frame > > out. > > I think we might have to move lines 115-150 to a separate method and call > > it from setSource, setFillMode and geomtryChanged then cache the destRect > > instead of these paintedWidth/Heights as a member variable. > > Marco Martin wrote: > the whole destrect calculation could perhaps move out of paint, right in > the resize event, that would remove a bit of weight from paint() and not have > the signal emitted after it's too late Any suggestions on where I should look for those? How can I check for the item's source? Also, for notmart's question: any example where I should look at? Sorry for all the questions but I'm fairly inexperienced at c++ and even less so at QML. - Luca --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/#review75334 --- On Feb. 3, 2015, 8:33 p.m., Luca Beltrame wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122413/ > --- > > (Updated Feb. 3, 2015, 8:33 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdeclarative > > > Description > --- > > Like the corresponding properties in QML's Image, this patch introduces > paintedWidth and paintedHeight to QPixmapItem, to get information on the size > of the pixmap that's actually shown (depending on fillMode), as compared to > its actual size. > > This brings QPixmapItem closer to the mode of usage of Image. > > CHANGELOG: New properties paintedWidth and paintedHeight added to QPixmapItem > > > Diffs > - > > src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp 6c9e3a2 > src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h 485d6f7 > > Diff: https://git.reviewboard.kde.org/r/122413/diff/ > > > Testing > --- > > Builds. > > > Thanks, > > Luca Beltrame > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- (Updated Feb. 3, 2015, 10:22 p.m.) Review request for KDE Frameworks and Plasma. Changes --- Return 0 for both methods if m_pixmap is null (not already set). Repository: kdeclarative Description --- Like the corresponding properties in QML's Image, this patch introduces paintedWidth and paintedHeight to QPixmapItem, to get information on the size of the pixmap that's actually shown (depending on fillMode), as compared to its actual size. This brings QPixmapItem closer to the mode of usage of Image. CHANGELOG: New properties paintedWidth and paintedHeight added to QPixmapItem Diffs (updated) - src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h 485d6f7 src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp 6c9e3a2 Diff: https://git.reviewboard.kde.org/r/122413/diff/ Testing --- Builds. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- (Updated Feb. 3, 2015, 11:41 p.m.) Review request for KDE Frameworks and Plasma. Changes --- Add a function setPaintedRect() (could also be updatePaintedRect if you prefer) caching the rect and only updating it when there are actual changes. Made said function a slot so it's invoked after geometryChanged is fired. Repository: kdeclarative Description --- Like the corresponding properties in QML's Image, this patch introduces paintedWidth and paintedHeight to QPixmapItem, to get information on the size of the pixmap that's actually shown (depending on fillMode), as compared to its actual size. This brings QPixmapItem closer to the mode of usage of Image. CHANGELOG: New properties paintedWidth and paintedHeight added to QPixmapItem Diffs (updated) - src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h 485d6f7 src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp 6c9e3a2 Diff: https://git.reviewboard.kde.org/r/122413/diff/ Testing --- Builds. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem
> On Feb. 4, 2015, 12:59 p.m., Marco Martin wrote: > > src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp, line 115 > > <https://git.reviewboard.kde.org/r/122413/diff/4/?file=346726#file346726line115> > > > > i'm not sure setting the panted rect in paint changes anything. > > > > since it's done in setPixmap/setFillmode, that should be enough? If by the time paint() has been called the information on the new size is already known (I don't know, though), then yeah, probably it would not matter. BTW, do you prefer updatePaintRect since setPaintRect isn't taking any parameter? I'll try to fix things this evening then push (and then do a separate RR for ImageItem). - Luca --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/#review75386 --- On Feb. 3, 2015, 11:41 p.m., Luca Beltrame wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122413/ > --- > > (Updated Feb. 3, 2015, 11:41 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdeclarative > > > Description > --- > > Like the corresponding properties in QML's Image, this patch introduces > paintedWidth and paintedHeight to QPixmapItem, to get information on the size > of the pixmap that's actually shown (depending on fillMode), as compared to > its actual size. > > This brings QPixmapItem closer to the mode of usage of Image. > > CHANGELOG: New properties paintedWidth and paintedHeight added to QPixmapItem > > > Diffs > - > > src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h 485d6f7 > src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp 6c9e3a2 > > Diff: https://git.reviewboard.kde.org/r/122413/diff/ > > > Testing > --- > > Builds. > > > Thanks, > > Luca Beltrame > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- (Updated Feb. 4, 2015, 7:18 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- Like the corresponding properties in QML's Image, this patch introduces paintedWidth and paintedHeight to QPixmapItem, to get information on the size of the pixmap that's actually shown (depending on fillMode), as compared to its actual size. This brings QPixmapItem closer to the mode of usage of Image. CHANGELOG: New properties paintedWidth and paintedHeight added to QPixmapItem Diffs - src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h 485d6f7 src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp 6c9e3a2 Diff: https://git.reviewboard.kde.org/r/122413/diff/ Testing --- Builds. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122432: Add paintedRect and paintedWidth to QImageItem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122432/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is analogous to RR 122413, in this case it adds support for the same properties to QImage. It is basically a copy and paste operation with variable adjustments. Diffs - src/qmlcontrols/kquickcontrolsaddons/qimageitem.h 3d0bc2c src/qmlcontrols/kquickcontrolsaddons/qimageitem.cpp deeb941 Diff: https://git.reviewboard.kde.org/r/122432/diff/ Testing --- Builds. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122432: Add paintedRect and paintedWidth to QImageItem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122432/ --- (Updated Feb. 4, 2015, 7:52 p.m.) Review request for KDE Frameworks and Plasma. Changes --- Fixed paintedHeight(). Repository: kdeclarative Description --- This is analogous to RR 122413, in this case it adds support for the same properties to QImage. It is basically a copy and paste operation with variable adjustments. Diffs (updated) - src/qmlcontrols/kquickcontrolsaddons/qimageitem.h 3d0bc2c src/qmlcontrols/kquickcontrolsaddons/qimageitem.cpp deeb941 Diff: https://git.reviewboard.kde.org/r/122432/diff/ Testing --- Builds. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122432: Add paintedRect and paintedWidth to QImageItem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122432/ --- (Updated Feb. 4, 2015, 8:19 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is analogous to RR 122413, in this case it adds support for the same properties to QImage. It is basically a copy and paste operation with variable adjustments. Diffs - src/qmlcontrols/kquickcontrolsaddons/qimageitem.h 3d0bc2c src/qmlcontrols/kquickcontrolsaddons/qimageitem.cpp deeb941 Diff: https://git.reviewboard.kde.org/r/122432/diff/ Testing --- Builds. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122776: Add test for qimageitem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122776/#review76904 --- +1 from me, given I touched this code recently. - Luca Beltrame On Mar. 2, 2015, 2:49 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122776/ > --- > > (Updated Mar. 2, 2015, 2:49 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdeclarative > > > Description > --- > > Add test for qimageitem > > > Diffs > - > > tests/CMakeLists.txt a8abfaf > tests/kdeclarativetest.cpp 70ea03f > tests/qimageitemtest.qml PRE-CREATION > tests/testimage.png PRE-CREATION > tests/testim...@2x.png PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/122776/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122774: Fix logic error in qpixmap/image item
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122774/#review76906 --- Ship it! Oops, copy-paste error on my part... thanks for spotting! - Luca Beltrame On Mar. 2, 2015, 2:43 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122774/ > --- > > (Updated Mar. 2, 2015, 2:43 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdeclarative > > > Description > --- > > sourceRect is used to see if the destination rect changes since the > previous update, this value is stored in m_paintedRect, m_image.rect() > is constant > > > Diffs > - > > src/qmlcontrols/kquickcontrolsaddons/qimageitem.cpp ed735b5 > src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp 8c06146 > > Diff: https://git.reviewboard.kde.org/r/122774/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122775: Make QImageItem handle non default devicePixelRatios
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122775/#review76905 --- Ship it! Inviala! - Luca Beltrame On Mar. 2, 2015, 2:50 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122775/ > --- > > (Updated Mar. 2, 2015, 2:50 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdeclarative > > > Description > --- > > PaintedWidth/Height are all relative to the items geometry so already > in user pixels not device pixels. > > > Diffs > - > > src/qmlcontrols/kquickcontrolsaddons/qimageitem.cpp ed735b5 > src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp 8c06146 > > Diff: https://git.reviewboard.kde.org/r/122775/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Proposal: move KWalletManager inside KWallet framework
Valentin Rusu wrote: Hello, first of all thanks to Valentin for bringing the issue here. > So, I'd like to resubmit my old proposal: would that be possible to > include KWalletManager in KF5::KWallet, in the runtime part, next to A possible issue that may have been raised in the past (however, I didn't follow the discussion back then) would be in the matter of dependencies. What tier is KWallet now? What other deps are pulled in by KWalletManager? And to elaborate on packaging: we would like *not* to push git snapshots on users, and currently the KF5 version of KWalletManager (part of kdeutils, IIRC, but feel free to correct me) has never been released. -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125044: Fix crash when hovering the 'Activities' context menu entry and constantly moving the mouse cursor around
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125044/#review84820 --- Can you check whether it also fixes bug 351585? To me the issue seems related. - Luca Beltrame On Set. 4, 2015, 1:01 p.m., Emmanuel Pescosta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125044/ > --- > > (Updated Set. 4, 2015, 1:01 p.m.) > > > Review request for KDE Frameworks and Ivan Čukić. > > > Bugs: 352207 > http://bugs.kde.org/show_bug.cgi?id=352207 > > > Repository: kactivities > > > Description > --- > > Only spawn one action loader (thread) when the actions of the > FileItemLinkingPlugin are not initialized already. > > > Diffs > - > > src/workspace/fileitemplugin/FileItemLinkingPlugin.cpp 353d941 > src/workspace/fileitemplugin/FileItemLinkingPlugin_p.h 05a39b4 > > Diff: https://git.reviewboard.kde.org/r/125044/diff/ > > > Testing > --- > > > Thanks, > > Emmanuel Pescosta > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125044: Fix crash when hovering the 'Activities' context menu entry and constantly moving the mouse cursor around
> On Set. 4, 2015, 1:14 p.m., Luca Beltrame wrote: > > Can you check whether it also fixes bug 351585? To me the issue seems > > related. I applied the patch locally, fixes also the aforementioned bug. - Luca --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125044/#review84820 --- On Set. 4, 2015, 1:01 p.m., Emmanuel Pescosta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125044/ > --- > > (Updated Set. 4, 2015, 1:01 p.m.) > > > Review request for KDE Frameworks and Ivan Čukić. > > > Bugs: 352207 > http://bugs.kde.org/show_bug.cgi?id=352207 > > > Repository: kactivities > > > Description > --- > > Only spawn one action loader (thread) when the actions of the > FileItemLinkingPlugin are not initialized already. > > > Diffs > - > > src/workspace/fileitemplugin/FileItemLinkingPlugin.cpp 353d941 > src/workspace/fileitemplugin/FileItemLinkingPlugin_p.h 05a39b4 > > Diff: https://git.reviewboard.kde.org/r/125044/diff/ > > > Testing > --- > > > Thanks, > > Emmanuel Pescosta > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125044: Fix crash when hovering the 'Activities' context menu entry and constantly moving the mouse cursor around
> On Set. 4, 2015, 1:14 p.m., Luca Beltrame wrote: > > Can you check whether it also fixes bug 351585? To me the issue seems > > related. > > Luca Beltrame wrote: > I applied the patch locally, fixes also the aforementioned bug. It just occurred to me that kactivities does not use RB for patch tracking. You need to use phabricator, at phabricator.kde.org. - Luca --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125044/#review84820 --- On Set. 4, 2015, 1:01 p.m., Emmanuel Pescosta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125044/ > --- > > (Updated Set. 4, 2015, 1:01 p.m.) > > > Review request for KDE Frameworks and Ivan Čukić. > > > Bugs: 352207 > http://bugs.kde.org/show_bug.cgi?id=352207 > > > Repository: kactivities > > > Description > --- > > Only spawn one action loader (thread) when the actions of the > FileItemLinkingPlugin are not initialized already. > > > Diffs > - > > src/workspace/fileitemplugin/FileItemLinkingPlugin.cpp 353d941 > src/workspace/fileitemplugin/FileItemLinkingPlugin_p.h 05a39b4 > > Diff: https://git.reviewboard.kde.org/r/125044/diff/ > > > Testing > --- > > > Thanks, > > Emmanuel Pescosta > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125154: Workaround 350758 with same hack in 494584ee43c20948044eb80012b69f65920b33f4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125154/#review85165 --- +1 - Luca Beltrame On Set. 11, 2015, 8:28 a.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125154/ > --- > > (Updated Set. 11, 2015, 8:28 a.m.) > > > Review request for KDE Frameworks and Lukáš Tinkl. > > > Bugs: 350758 > https://bugs.kde.org/show_bug.cgi?id=350758 > > > Repository: frameworkintegration > > > Description > --- > > In https://bugs.kde.org/show_bug.cgi?id=334963 Cjacker proposed a patch. > > Which seems makes some sense because same situation in exec() may also happen > to show(). > > > Diffs > - > > src/platformtheme/kdeplatformfiledialoghelper.cpp 94f2059 > > Diff: https://git.reviewboard.kde.org/r/125154/diff/ > > > Testing > --- > > So far I'm not able to reproduce 350758 for now. > I uses lokalize merge file window to test since it's the easiest one for me > to reproduce 350758. > > > Thanks, > > Xuetian Weng > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125537: Use largest timestamp in subdirectory as resource directory timestamp.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125537/#review86407 --- +1. I hit this issue today and this patch fixes it. - Luca Beltrame On Ott. 6, 2015, 4:18 a.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125537/ > --- > > (Updated Ott. 6, 2015, 4:18 a.m.) > > > Review request for KDE Frameworks, Albert Astals Cid and David Faure. > > > Repository: kservice > > > Description > --- > > In 0e4d7247e27f82a9b79b19dbceb35b603baceb76, a new feature saving directory > mtime in ksycoca db is introduced. > > In the related code, TimestampChecker() will check the mtime recursively, but > the building process will only read the top level directories' mtime, which > causes ksycoca db being recreated again and again. > > I hit this because my ~/.config/menus/applications-merged mtime newer than > ~/.config/menus. And plasmashell is running with 100% since it's creating > ksycoca db repeatedly. > > This patch change the building db procedure to use the same logic as in > TimestampChecker(), so building and checking are consistent now. > > > Diffs > - > > autotests/ksycocatest.cpp 67f0700 > src/sycoca/kbuildsycoca.cpp 00aaac3 > > Diff: https://git.reviewboard.kde.org/r/125537/diff/ > > > Testing > --- > > Now a sub directory with larger timestamp than parent will not cause ksycoca > data being recreated again and again. > > > Thanks, > > Xuetian Weng > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: breeze icons default and its inheritance
Il Thu, 22 Oct 2015 07:28:09 +0200, Harald Sitter ha scritto: > temporarily revert kiconthemes commit until breeze-icons with a I would suggest this for the moment while a fix is sought. It's been causing crashes in KMail because the fallback fails and KPixmapSequence accesses invalid data -> kaboom. -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: A29D259B ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125875: Fix build for Qt < 5.5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125875/#review87725 --- +1 - Luca Beltrame On Ott. 29, 2015, 7:55 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125875/ > --- > > (Updated Ott. 29, 2015, 7:55 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kauth > > > Description > --- > > Fix build for Qt < 5.5 > > > Diffs > - > > src/backends/dbus/DBusHelperProxy.cpp > c258db2811b1bdb5d51950bedf66f6d90a7ea3a9 > > Diff: https://git.reviewboard.kde.org/r/125875/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125863/#review87757 --- It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how can I debug to ensure this is the case and not a local issue? - Luca Beltrame On Ott. 29, 2015, 8:01 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125863/ > --- > > (Updated Ott. 29, 2015, 8:01 p.m.) > > > Review request for KDE Frameworks. > > > Bugs: 291144 > https://bugs.kde.org/show_bug.cgi?id=291144 > > > Repository: frameworkintegration > > > Description > --- > > Use platform theme hint instead of manually using > QApplication::setWheelScrollLines > > > Diffs > - > > src/platformtheme/khintssettings.cpp 6e8313d > > Diff: https://git.reviewboard.kde.org/r/125863/diff/ > > > Testing > --- > > Qt 5.5 apps now correctly scroll by the value set in mouse kcm > > > Thanks, > > David Rosca > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5
> On Ott. 30, 2015, 8:34 p.m., Luca Beltrame wrote: > > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how > > can I debug to ensure this is the case and not a local issue? > > David Rosca wrote: > Broke in what way? Did you try if it works without this commit? I just reverted it and wheel scrolls again. Broken as in, there is no wheel scrolling in (tested): - Kate - Konversation - Kontact But works in: - Dolphin - Luca --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125863/#review87757 --- On Ott. 29, 2015, 8:01 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125863/ > --- > > (Updated Ott. 29, 2015, 8:01 p.m.) > > > Review request for KDE Frameworks. > > > Bugs: 291144 > https://bugs.kde.org/show_bug.cgi?id=291144 > > > Repository: frameworkintegration > > > Description > --- > > Use platform theme hint instead of manually using > QApplication::setWheelScrollLines > > > Diffs > - > > src/platformtheme/khintssettings.cpp 6e8313d > > Diff: https://git.reviewboard.kde.org/r/125863/diff/ > > > Testing > --- > > Qt 5.5 apps now correctly scroll by the value set in mouse kcm > > > Thanks, > > David Rosca > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5
> On Ott. 30, 2015, 8:34 p.m., Luca Beltrame wrote: > > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how > > can I debug to ensure this is the case and not a local issue? > > David Rosca wrote: > Broke in what way? Did you try if it works without this commit? > > Luca Beltrame wrote: > I just reverted it and wheel scrolls again. > Broken as in, there is no wheel scrolling in (tested): > > - Kate > - Konversation > - Kontact > > But works in: > - Dolphin > > David Rosca wrote: > It shouldn't break it, unless you have set 0 wheel scroll lines in mouse > kcm. In the worst case, it should just ignore that value from kcm and use > default 3 lines (but that is what this should be actually fixing). FYI, it's set to 3 lines there. - Luca --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125863/#review87757 --- On Ott. 29, 2015, 8:01 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125863/ > --- > > (Updated Ott. 29, 2015, 8:01 p.m.) > > > Review request for KDE Frameworks. > > > Bugs: 291144 > https://bugs.kde.org/show_bug.cgi?id=291144 > > > Repository: frameworkintegration > > > Description > --- > > Use platform theme hint instead of manually using > QApplication::setWheelScrollLines > > > Diffs > - > > src/platformtheme/khintssettings.cpp 6e8313d > > Diff: https://git.reviewboard.kde.org/r/125863/diff/ > > > Testing > --- > > Qt 5.5 apps now correctly scroll by the value set in mouse kcm > > > Thanks, > > David Rosca > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5
> On Ott. 30, 2015, 8:34 p.m., Luca Beltrame wrote: > > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how > > can I debug to ensure this is the case and not a local issue? > > David Rosca wrote: > Broke in what way? Did you try if it works without this commit? > > Luca Beltrame wrote: > I just reverted it and wheel scrolls again. > Broken as in, there is no wheel scrolling in (tested): > > - Kate > - Konversation > - Kontact > > But works in: > - Dolphin > > David Rosca wrote: > It shouldn't break it, unless you have set 0 wheel scroll lines in mouse > kcm. In the worst case, it should just ignore that value from kcm and use > default 3 lines (but that is what this should be actually fixing). > > Luca Beltrame wrote: > FYI, it's set to 3 lines there. > > David Rosca wrote: > Ok, so can you add qDebug() << "wheelscrolllines" << > m_hints[QPlatformTheme::WheelScrollLines]; after it is fetched from config > and check it picks the correct value? (line 110 and 337 in khintssettings.cpp) > Also can you test if changing the wheel scroll lines value in mouse kcm > and applying it fixes scrolling for running applications? Before adjusting config in the mouse KCM: ``` kate wheelscrolllines at line 110 QVariant(int, 0) 0x13dda40 void QWindowPrivate::setTopLevelScreen(QScreen*, bool) ( QScreen(0x977880) ): Attempt to set a screen on a child window. 0x13ddf20 void QWindowPrivate::setTopLevelScreen(QScreen*, bool) ( QScreen(0x977880) ): Attempt to set a screen on a child window. 0x13de8b0 void QWindowPrivate::setTopLevelScreen(QScreen*, bool) ( QScreen(0x977880) ): Attempt to set a screen on a child window. 0x13df0a0 void QWindowPrivate::setTopLevelScreen(QScreen*, bool) ( QScreen(0x977880) ): Attempt to set a screen on a child window. 0x13e2150 void QWindowPrivate::setTopLevelScreen(QScreen*, bool) ( QScreen(0x977880) ): Attempt to set a screen on a child window. 0x145e790 void QWindowPrivate::setTopLevelScreen(QScreen*, bool) ( QScreen(0x977880) ): Attempt to set a screen on a child window. wheelscrolllines at 338 QVariant(int, 0) After changing config, scrolling works again (need an application restart). - Luca --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125863/#review87757 --- On Ott. 29, 2015, 8:01 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125863/ > --- > > (Updated Ott. 29, 2015, 8:01 p.m.) > > > Review request for KDE Frameworks. > > > Bugs: 291144 > https://bugs.kde.org/show_bug.cgi?id=291144 > > > Repository: frameworkintegration > > > Description > --- > > Use platform theme hint instead of manually using > QApplication::setWheelScrollLines > > > Diffs > - > > src/platformtheme/khintssettings.cpp 6e8313d > > Diff: https://git.reviewboard.kde.org/r/125863/diff/ > > > Testing > --- > > Qt 5.5 apps now correctly scroll by the value set in mouse kcm > > > Thanks, > > David Rosca > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125884: Set default value for WheelScrollLines
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125884/#review87766 --- +1. - Luca Beltrame On Ott. 30, 2015, 10 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125884/ > --- > > (Updated Ott. 30, 2015, 10 p.m.) > > > Review request for KDE Frameworks. > > > Repository: frameworkintegration > > > Description > --- > > Use 3 (same as mouse kcm) as default value instead of > QApplication::wheelScrollLines(). > > > Diffs > - > > src/platformtheme/khintssettings.cpp e5c362a > > Diff: https://git.reviewboard.kde.org/r/125884/diff/ > > > Testing > --- > > No longer sets 0 lines when WheelScrollLines entry is not in kdeglobals. > > > Thanks, > > David Rosca > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)
Il Wed, 18 Nov 2015 17:28:27 +0100, René J.V. Bertin ha scritto: > If we're starting to call names arguing indeed becomes pointless as the > apparent lack of actual reading my arguments already suggested. It In the interest of the CoC and before people heat up, Martin said: "Thus the code is idiotic" so I don't see anything like name calling. Anyway, since this is likely off-topic, if you feel you've been treated unfairly from a non-development point of view, feel free to contact KDE's community working group. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Scrap baloo?
Il giorno Wed, 14 Sep 2016 23:29:22 +0200 (CEST) Christoph Cullmann ha scritto: > CC'd Vishesh, perhaps I am wrong with that issues and misunderstand > the code, unfortunately e.g. the database structure is not that well > documented, if I don't just not find the correct docs in the git. While perhaps it's strong to write "scrap", I believe this is a potentially useful Framework which (along with KFileMetadata) extremely badly documented. I don't mean to bash its maintainer here, I say it as a statement of fact: in order to implement KFileMedadata in my own application, I had to scavenge the source code to understand how to use it, and there were close to 0 API docs. As discussed with Cristoph last night on IRC, I would suggest to use this case to ensure that, in the future: a. Only allow frameworks with at least a maintenance commitment promise b. Only allow frameworks with at least their main classes properly documented. c. Only allow frameworks with adequate test coverage (more unit tests would have uncovered some of the problems here?) > 4) fundamental problems like: wrong data structure for index (32-bit > inodes in 21th century?) and close to zero docs what it does > internally I assume this won't be switchable easily? > Scrap baloo_file* and Co. and just reimplement the public API (modulo > the settings for the then non-existing indexer daemon) to use tracker. As I said yesterday on IRC, I don't oppose this if it means better maintenance. Only, please ensure things won't break, I don't want to deal with the angry mobs in the forum. ;) > => Opinions? It would be nice to hear what Vishesh, Pinak and Boudhayan think about this. -- Luca Beltrame, Ph.D. Translational Genomics Unit, Department of Oncology IRCCS Istituto di Ricerche Farmacologiche "Mario Negri" pgpuoh7i0UqTW.pgp Description: Firma digitale OpenPGP
Re: Scrap baloo?
Il giorno Thu, 15 Sep 2016 06:46:57 +0200 (CEST) Christoph Cullmann ha scritto: > FYI > Compile LMDB with -DMDB_VL32 to allow using larger-than-32bit DBs on > 32bit systems. With my distro hat on, I wonder if this would change the on-disk format for existing installs... Otherwise it would be good to suggest it to kde-distro-packagers as a stopgap solution. pgplOEutiAXDL.pgp Description: Firma digitale OpenPGP
Re: Scrap baloo?
Il giorno Thu, 22 Sep 2016 21:54:26 +0200 (CEST) Christoph Cullmann ha scritto: > anyone had some time to take a look at Baloo and Co.? Last thing on the topic I saw was this comment to this review: https://git.reviewboard.kde.org/r/128664/ pgp3TaryU1XpJ.pgp Description: Firma digitale OpenPGP
Re: KDE Frameworks & Plasma 5.8 LTS
Il giorno Sun, 23 Oct 2016 12:14:51 +0200 Dominik Haumann ha scritto: > Do we have any knowledge on whether distributions that ship Plasma 5.8 > LTS still provide updates to KDE Frameworks 5.27 etc? openSUSE Tumbleweed will always have the last version of everything (barring issues). openSUSE Leap 42.2 will *not* get any major version update, so it will stick with Plasma 5.8 and KF 5.26. -- Luca Beltrame - KDE Forums team GPG key ID: A29D259B pgp79DaGH19rA.pgp Description: Firma digitale OpenPGP
ATTN: latest changes in breeze-icons make packaging untenable
Hello, recent changes in breeze broke building in openSUSE's OBS: after a discussion on IRC, it turned out that there were incorrect symlinks. Adjustments were made in order to preserve space. However, while harmless at first (I didn't notice earlier, and CI was green) these changes *break* packaging for most systems. The reason? Directories became symlinks, hence a package manager can't fix that, it will totally break when a package updates (because it will try to symlink something existent). Therefore there is *no* way the current state of breeze-icons can be installed a the moment by any sane distribution. No problem for now, but Frameworks are monthly releases, so... This needs to be fixed, even if at the cost of wasting space (but making packagers much happier). If there's no consensus, I will revert these commits [1][2][3][4] in breeze-icons by Sunday morning. [1] f40a8314d292a881257767a72162ec3b2919b214 [2] c45891e5e19c0d9ba837f2ce0ef9cabff38d696c [3] 44bee349abe50f57f799d0cb003347d48847caea [4] fd6fbc99b2846b8baa5f266a19ab2b0e906cd353 pgpQaxvVK4vbL.pgp Description: Firma digitale OpenPGP
Re: ATTN: latest changes in breeze-icons make packaging untenable
Il giorno Tue, 25 Oct 2016 16:47:40 +0200 Luca Beltrame ha scritto: > If there's no consensus, I will revert these commits [1][2][3][4] in > breeze-icons by Sunday morning. After discussion on IRC, the commits were reverted. pgpkAXusssxMw.pgp Description: Firma digitale OpenPGP
D23694: Add support for sshfs to the fstab backend
lbeltrame added a comment. Would this change be needed on this side or kdeconnect side? I don't mind landing this, but I need formal approval by someone. (I won't have any time to do additional changes elsewhere). REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694 To: lbeltrame, bruns, broulik, fvogt, #kde_connect Cc: elvisangelaccio, albertvaka, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
D23694: Add support for sshfs to the fstab backend
lbeltrame added a comment. @elvisangelaccio Thanks, first of all. If that's the case, do you think it's better to touch KIO first before landing this? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694 To: lbeltrame, bruns, broulik, fvogt, #kde_connect Cc: elvisangelaccio, albertvaka, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
D23694: Add support for sshfs to the fstab backend
lbeltrame added a comment. Any objections? Or I'll merge on Sunday evening UTC+1. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694 To: lbeltrame, bruns, broulik, fvogt, #kde_connect Cc: elvisangelaccio, albertvaka, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
D23694: Add support for sshfs to the fstab backend
lbeltrame closed this revision. lbeltrame added a comment. https://invent.kde.org/frameworks/solid/commit/a41ce6a27eb07096356acb3e03ecf69e9ca0173d REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694 To: lbeltrame, bruns, broulik, fvogt, #kde_connect Cc: elvisangelaccio, albertvaka, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
D12423: Install pri file for qmake support & document it in metainfo.yaml
lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH installprifile REVISION DETAIL https://phabricator.kde.org/D12423 To: kossebau, #build_system, lbeltrame Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns
D12424: Install pri file for qmake support & document it in metainfo.yaml
lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH installprifile REVISION DETAIL https://phabricator.kde.org/D12424 To: kossebau, #build_system, lbeltrame Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns
D11925: Add "SkipSwitcher" to API
lbeltrame added a comment. Observed this on the openSUSE OBS as well. Please fix the compilation issue or revert. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein, graesslin Cc: lbeltrame, rikmills, davidedmundson, #plasma, graesslin, #frameworks, michaelh, bruns
D11925: Add "SkipSwitcher" to API
lbeltrame added a comment. For now I reverted the commit in kwin to allow building. Once this review is merged, it can be re-instated. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein, graesslin Cc: lbeltrame, rikmills, davidedmundson, #plasma, graesslin, #frameworks, michaelh, bruns
D12696: Use the new uds implementation
lbeltrame added a comment. I wonder if this is related to timeline:/ no longer working properly in the file dialog. (didn't investigate yet). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12696 To: jtamate, dfaure, #frameworks Cc: lbeltrame, asturmlechner, martinkostolny, kde-frameworks-devel, bruns, michaelh, ngraham
D13641: [KCharSelect] Port generate-datafile.py to Python 3
lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13641 To: cfeck, #frameworks, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13641: [KCharSelect] Port generate-datafile.py to Python 3
lbeltrame requested changes to this revision. lbeltrame added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcharselect-generate-datafile.py:41 Perhaps the diff view is wrong.. but the `return size` here (at this level of nesting) wouldn't make the downstream code de facto unreachable in this function? > kcharselect-generate-datafile.py:118 Same here. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13641 To: cfeck, #frameworks, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13641: [KCharSelect] Port generate-datafile.py to Python 3
lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. I did an accept to undo my earlier "Changes required" because Phab messed up the lines I commented on, and because I realized I wasn't commenting on your specific changes. Sorry about that. INLINE COMMENTS > kcharselect-generate-datafile.py:432 > size += 2 > return size Perhaps the diff view is wrong.. but the return size here (at this level of nesting) wouldn't make the downstream code de facto unreachable in this function? > kcharselect-generate-datafile.py:607 > for char in self.unihan.keys(): > for entry in self.unihan[char]: Unrelated to this patch, but this could be changed to `for char in self.unihan` (perhaps in a separate revision). > kcharselect-generate-datafile.py:624 > pos += size > return pos Same here wrt position of return. Now I notice that they're not related to your changes, so I wonder if it's phab showing something off, or there is a problem of tab vs spaces REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13641 To: cfeck, #frameworks, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D12233: Avoid manipulation of lists with quadratic complexity
lbeltrame added a reviewer: mgallien. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: bruns, #baloo, michaelh, mgallien Cc: dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, ashaposhnikov, michaelh, astippich, spoorun, abrahams
D14395: [KSambaShare] Check file that's changed before reloading
lbeltrame added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14395 To: broulik, #frameworks, dfaure Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns
D18527: List Android as officially supported
lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D18527 To: vkrause, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf
lbeltrame added a comment. Can you expand a bit the description? I understand you are fixing problems, but why the problems are there and what you are doing exactly. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D18574 To: fvogt, aacid Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns
D18941: Fix build with cmake 3.5
lbeltrame added a reviewer: bruns. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18941 To: wbauer, #build_system, cgiboudeaux, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D18941: Fix build with cmake 3.5
lbeltrame added reviewers: Build System, cgiboudeaux. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18941 To: wbauer, #build_system, cgiboudeaux Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D18947: Bring FindUDev.cmake up to ECM standards
lbeltrame added a reviewer: cgiboudeaux. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D18947 To: vkrause, #build_system, cgiboudeaux Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D18952: new find module for Canberra
lbeltrame added a reviewer: cgiboudeaux. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18952 To: sitter, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
