D24656: [SlaveBase] Prevent crash by properly initializing Kconfig objects

meven abandoned this revision. meven added a comment. Superseeded by https://phabricator.kde.org/D24655 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24656 To: meven, #frameworks, vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24656: [SlaveBase] Prevent crash by properly initializing Kconfig objects

meven created this revision. meven added reviewers: Frameworks, vkrause, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY As suggested at https://phabricator.kde.org/R241:a497d47c45a5#inline-16

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven added a comment. In D24582#547267 , @dfaure wrote: > Looks fine, but a bit verbose. Maybe we could have configValue() overloads (in SlaveBase) for bool, int and QString, to cover the most common use cases? > > - mapConfig().value(QStr

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven updated this revision to Diff 67943. meven added a comment. Add configValue overloads to simplify code REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24582?vs=67772&id=67943 BRANCH arcpatch-D24582 REVISION DETAIL https://phabricator.kde.org/D24582

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a497d47c45a5: [SlaveBase] Use QMap instead of KConfig to store ioslave config (authored by meven). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23523?vs=67763&id=67940#toc REPOSITORY R241

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven added a comment. In D23523#547265 , @dfaure wrote: > Looks fine, but it seems that the uploaded diff is only the delta compared to the previous diff, not the overall change. Anyhow, feel free to push both. It was on purpose to have

kde-frameworks-devel@kde.org

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D24584 To: aacid, meven Cc: meven, kde-frameworks-devel, #baloo, hurikhan77, lots0logs

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven updated this revision to Diff 67772. meven added a comment. Clean up a QVariant() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24582?vs=67771&id=67772 BRANCH next-D23523 REVISION DETAIL https://phabricator.kde.org/D24582 AFFECTED FILES src/iosl

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven updated this revision to Diff 67771. meven added a comment. Fixes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24582?vs=67768&id=67771 BRANCH next-D23523 REVISION DETAIL https://phabricator.kde.org/D24582 AFFECTED FILES src/ioslaves/file/file.c

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven updated this revision to Diff 67768. meven added a comment. Replace more config() calls, fixes, code cleanup REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24582?vs=67767&id=67768 BRANCH next-D23523 REVISION DETAIL https://phabricator.kde.org/D24582

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven updated this revision to Diff 67767. meven added a comment. Replace more config() calls, fixes, code cleanup REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24582?vs=67765&id=67767 BRANCH next-D23523 REVISION DETAIL https://phabricator.kde.org/D24582

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24582 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven added a dependent revision: D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig(). REPOSITORY R241 KIO BRANCH arcpatch-D23523 REVISION DETAIL https://phabricator.kde.org/D23523 To: meven, davidedmundson, dfaure, #frameworks Cc: broulik, kde-frameworks-devel, LeGast

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven created this revision. meven added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Depends on D23523 Now that SlaveBase::c

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven updated this revision to Diff 67763. meven added a comment. Fix slavebase.cpp following QVariant changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23523?vs=67762&id=67763 BRANCH arcpatch-D23523 REVISION DETAIL https://phabricator.kde.org/D23523

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven updated this revision to Diff 67762. meven added a comment. Update since, use QVariant as mapConfig value REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23523?vs=65991&id=67762 BRANCH arcpatch-D23523 REVISION DETAIL https://phabricator.kde.org/D2352

D24439: Fix test kfileplacesmodeltest after D7446

meven added a comment. Fixed as of https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/250/ REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24439 To: meven, dfaure, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, micha

D24439: Fix test kfileplacesmodeltest after D7446

This revision was automatically updated to reflect the committed changes. Closed by commit R241:6d8bd6f99a1c: Fix test kfileplacesmodeltest after D7446 (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24439?vs=67369&id=67384 REVISION DETAIL h

D24439: Fix test kfileplacesmodeltest after D7446

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24439 To: meven, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. In D7446#542407 , @dfaure wrote: > This commit breaks `kfileplacesmodeltest`, please take a look. > > https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/247/testReport/ju

D24439: Fix test kfileplacesmodeltest after D7446

meven created this revision. meven added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY See D7556 REPOSITORY R241 KIO BRANCH master REVIS

D17595: Upstream Dolphin's file rename dialog

meven added a comment. I received the agreements of all contributors including the original code author, to relicense this code and hence upstream it. It reminds of the importance of signing FLA to KDE e.V. So this is good to follow through the normal review process. @dfaure I wo

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. In D7446#542055 , @ngraham wrote: > I think you can go for it. :) Tagging is tomorrow, so please do! Just landed ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, bro

D7446: [Places panel] Revamp the Recently Saved section

This revision was automatically updated to reflect the committed changes. Closed by commit R241:e65bf3bc541a: [Places panel] Revamp the Recently Saved section (authored by ngraham, committed by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=67242&i

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. Any new feedback ? REPOSITORY R241 KIO BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel,

D24405: Small performance improvements suggested by clang-tidy

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Makes sense REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D24405 To: aacid, meven Cc: meven, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbam

D23266: Export Plasma core lib log category, add a category to a qWarning

This revision was automatically updated to reflect the committed changes. Closed by commit R242:5f6996ee50f8: Export Plasma core lib log category, add a category to a qWarning (authored by meven). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23266?vs=64060&id=67300#toc REPOSITORY R24

D23266: Export Plasma core lib log category, add a category to a qWarning

meven added a comment. ping @apol REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23266 To: meven, #frameworks, broulik Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24388: Mark technology propertie as constant to avoid warning

This revision was automatically updated to reflect the committed changes. Closed by commit R245:edb12de9490e: Mark technology propertie as constant to avoid warning (authored by meven). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24388?vs=67260&id=67266 REVI

D24389: Fix klistopenfilesjob header file not being installed

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D24389 To: hallas, dfaure, meven Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24388: Mark technology propertie as constant to avoid warning

meven created this revision. meven added reviewers: davidedmundson, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY To avoid output such as : QQmlExpression: Expression file:///home

D7446: [Places panel] Revamp the Recently Saved section

meven marked an inline comment as done. REPOSITORY R241 KIO BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoor

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 67242. meven marked 4 inline comments as done. meven added a comment. Better variable naming REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=67241&id=67242 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricato

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 67241. meven added a comment. Make bookmarkForUrl const, add context to translate Recent REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=67203&id=67241 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kd

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. Code is ready for review, tests pass @elvisangelaccio @dfaure Following https://phabricator.kde.org/D7446#528536 recentlyused:/ bookmarks are only added when KDE_FULL_SESSION is set. D23557 will get merged after this one.

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 67203. meven added a comment. Small changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65981&id=67203 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES autotests/kfile

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D23523 REVISION DETAIL https://phabricator.kde.org/D23523 To: meven, davidedmundson, dfaure, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21760: Add KListOpenFilesJob

meven added a comment. Now we can use it : > dolphin D19989 > plasma-vault > libksysguard (KLsofWidget) > dataengines/devicenotifications/ksolidnotify REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21760 To: hall

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

This revision was automatically updated to reflect the committed changes. Closed by commit R320:52175ce07389: Add two special cases url recentlyused:/files and recentlyused:/folders (authored by meven). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?v

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven added a comment. The /folders path is /locations in fact REPOSITORY R320 KIO Extras BRANCH arcpatch-D23742 REVISION DETAIL https://phabricator.kde.org/D23742 To: meven, ivan, ngraham, #frameworks Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampalo

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 67102. meven added a comment. Correct ?type use with /files : ?type overrules /files, since they are aggregated with ORs REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65959&id=67102 BRANCH arcpatch-D23742

D23667: Add == and != operators to KIO::UDSEntry

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f893784ea4f1: Add == and != operators to KIO::UDSEntry (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=66086&id=66883 REVISION DETAIL ht

D23667: Add == and != operators to KIO::UDSEntry

meven added a comment. In D23667#535222 , @dfaure wrote: > Looks ok, but I'm just curious about the use case. "I felt it was missing" doesn't sound as strong an argument as "I need this"... > > Slaves are supposed to mostly create those, not

D23667: Add == and != operators to KIO::UDSEntry

meven added a comment. @pino if this is fine for you... REPOSITORY R241 KIO BRANCH arcpatch-D23667 REVISION DETAIL https://phabricator.kde.org/D23667 To: meven, #frameworks, ngraham Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 66086. meven added a comment. Update @since references REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65705&id=66086 BRANCH arcpatch-D23667 REVISION DETAIL https://phabricator.kde.org/D23667 AFFECTED FILES a

D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes

meven updated this revision to Diff 66028. meven added a comment. Add a KF6 clean up todo REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23851?vs=65795&id=66028 BRANCH arcpatch-D23851 REVISION DETAIL https://phabricator.kde.org/D23851 AFFECTED FILES sr

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven updated this revision to Diff 65991. meven added a comment. Update @deprecated message to be more clear REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23523?vs=65931&id=65991 BRANCH arcpatch-D23523 REVISION DETAIL https://phabricator.kde.org/D23523

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23523 To: meven, davidedmundson, dfaure, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 65981. meven added a comment. Update since version REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65980&id=65981 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES autotest

D7446: [Places panel] Revamp the Recently Saved section

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, andreaska, gregorm

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 65980. meven added a comment. add recentlyused:/ bookmarks only in plasma, update following D23742 changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65602&id=65980 BRANCH

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven added inline comments. INLINE COMMENTS > dfaure wrote in slavebase.h:353 > Can you update the docu as suggested above, to point more clearly to the > replacement? This makes things easier for people doing porting. Thanks. I have a `@see mapConfig` on the line below, did you see ? Or do yo

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven marked 2 inline comments as done. meven added a comment. I will land this soonish if no one has any objections. REPOSITORY R320 KIO Extras BRANCH arcpatch-D23742 REVISION DETAIL https://phabricator.kde.org/D23742 To: meven, ivan, ngraham, #frameworks Cc: kde-frameworks-devel, kf

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65959. meven added a comment. Allow users to use ?type filter with /files path REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65597&id=65959 BRANCH arcpatch-D23742 REVISION DETAIL https://phabricator.kde

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

meven updated this revision to Diff 65955. meven added a comment. Rebase on master, review feedback REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21204?vs=62027&id=65955 BRANCH arcpatch-D21204 REVISION DETAIL https://phabricator.kde.org/D21204 AFFECTE

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

meven marked an inline comment as done. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21204 To: meven, bruns, #frameworks, ngraham Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven updated this revision to Diff 65931. meven marked 2 inline comments as done. meven added a comment. Clean up and update @since REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23523?vs=65374&id=65931 BRANCH arcpatch-D23523 REVISION DETAIL https://phab

D23855: Avoid installing log categorie file to KDE_INSTALL_CONFDIR

This revision was automatically updated to reflect the committed changes. Closed by commit R159:31f921f65093: Avoid installing log categorie file to KDE_INSTALL_CONFDIR (authored by meven). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23855?vs

D23855: Avoid installing log categorie file to KDE_INSTALL_CONFDIR

meven added a comment. Btw we have quite a few CMakeLists.txt files that would need the same attention. REPOSITORY R159 KActivities Statistics BRANCH arcpatch-D23855 REVISION DETAIL https://phabricator.kde.org/D23855 To: meven, ivan, cgiboudeaux Cc: kde-frameworks-devel, LeGast00n, G

D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes

meven retitled this revision from "Avoid sending KDirNotify::emitFilesAdded when the trash is emptied" to "Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23851 To: meven, broulik, ngraham Cc: kde-f

D23855: Avoid installing log categorie file to KDE_INSTALL_CONFDIR

meven added a comment. See https://phabricator.kde.org/D22143#526980 REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D23855 To: meven, ivan, cgiboudeaux Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23855: Avoid installing log categorie file to KDE_INSTALL_CONFDIR

meven updated this revision to Diff 65802. meven added a comment. rebase REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23855?vs=65801&id=65802 BRANCH arcpatch-D23855 REVISION DETAIL https://phabricator.kde.org/D23855 AFFECTED FILES

D23855: Avoid installing log categorie file to KDE_INSTALL_CONFDIR

meven created this revision. meven added reviewers: ivan, cgiboudeaux. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Since we depend here on ECM > 5.61 we don't need to install the categorie file to

D23851: Avoid sending KDirNotify::emitFilesAdded when the trash is emptied

meven created this revision. meven added reviewers: broulik, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY D23650 added an empty trash check in trash fi

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven added inline comments. INLINE COMMENTS > recentlyused.cpp:98 > -// handles type aka mimetype > -if (urlQuery.hasQueryItem(QStringLiteral("type"))) { > -const auto typeValue = > urlQuery.queryItemValue(QStringLiteral("type")); Should we allow the filtering through type with

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. A plan of action would be : 1. Check add recenly_used only on plasma KDE_FULL_SESSION (it can't be used outside ) To improve dolphin and kde apps outside of plasma, make KRecentDocuments a recentlyused file user : 2. Outside of plasma, make `recentlyused:

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 65705. meven added a comment. Remove unneeded friend function declarations REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65608&id=65705 BRANCH arcpatch-D23667 REVISION DETAIL https://phabricator.kde.org/D23667

D23730: Add new protocol for 7z archives

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. `7zip:/` is in fact not correct because this would make the url scheme 7zip, but a url scheme must begin with a letter . That's too bad URL aren't not more flexible. REPOSITORY R320 KIO E

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 65608. meven marked 5 inline comments as done. meven added a comment. typo fix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65607&id=65608 BRANCH arcpatch-D23667 REVISION DETAIL https://phabricator.kde.org/D2

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 65607. meven added a comment. Fix test and implementation REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65298&id=65607 BRANCH arcpatch-D23667 REVISION DETAIL https://phabricator.kde.org/D23667 AFFECTED FILES

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 65602. meven added a comment. Use new folder-open-recent for /locations bookmark REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65519&id=65602 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7

D23761: Make small recent documents icons look like documents and improve clock emblems

meven added a comment. Is that the expected result ? F7328222: Screenshot_20190907_230008.png If so, it needs some polishing IMO. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23761 To: ngraham, #vdg, ndavis Cc

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65597. meven added a comment. Use new folder-open-recent for /locations REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65492&id=65597 BRANCH arcpatch-D23742 REVISION DETAIL https://phabricator.kde.org/D2

D23760: Create new "Recent folders" icon

meven added a comment. In D23760#526842 , @ngraham wrote: > The document icons will also need adjustment to match this style, and also to correct some related visual deficiencies (e.g. the lack of a folded corner). We can do that next. G

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. >> Conditionalize the code here with version ifdefs so that people only get both new entries when using kio-extras from 19.12.0 It is already the case : users won't get the new entries without recentlyused:/ installed, `KProtocolInfo::isKnownProtocol(QStringLitera

D23760: Create new "Recent folders" icon

meven added a comment. Also it seems to me the icon is not very similar to F7325279: Screenshot_20190906_224006.png The thickness of the clock pen in particular. They should be somewhat reminiscent of one another IMHO. REPOSITORY R266 Breeze Ico

D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them

This revision was automatically updated to reflect the committed changes. Closed by commit R159:df52b1a382af: Add Term::Type::files() and Term::Type::directories() to filter only… (authored by meven). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 65519. meven added a comment. Add two entries to Recent 'Recent Files' and 'Recent Locations' REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65199&id=65519 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricat

D7446: [Places panel] Revamp the Recently Saved section

meven edited the summary of this revision. meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. In D7446#526506 , @ngraham wrote: > In D7446#526494 , @meven wrote: > > > It would be great to have two different icons for recentlyused:/locations and recentlyused:/files. > >

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. It would be great to have two different icons for recentlyused:/locations and recentlyused:/files. Also I am not sure recentlyuserd:/ should use "document-open-recent-symbolic" since it is monochrone, the kio declares currently "document-open-recent". Maybe "folder-

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65492. meven added a comment. Use Terms::Type::directories() REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65484&id=65492 BRANCH arcpatch-D23742 REVISION DETAIL https://phabricator.kde.org/D23742 AFFEC

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. @ngraham you added some dependencies but D23737 and D23741 are not direct dependencies, but rather related fixes. Still, I don't mind leaving them as dependencies. REPOSITORY R241 KIO REVIS

D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them

meven updated this revision to Diff 65491. meven added a comment. Spacing REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23736?vs=65490&id=65491 BRANCH arcpatch-D23736 REVISION DETAIL https://phabricator.kde.org/D23736 AFFECTED FILES

D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them

meven updated this revision to Diff 65490. meven added a comment. Rename constant LOCATIONS_TYPE_TAG -> DIRECTORIES_TYPE_TAG bis REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23736?vs=65489&id=65490 BRANCH arcpatch-D23736 REVISION DETAIL

D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them

meven updated this revision to Diff 65489. meven added a comment. Rename constant LOCATIONS_TYPE_TAG -> DIRECTORIES_TYPE_TAG REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23736?vs=65488&id=65489 BRANCH arcpatch-D23736 REVISION DETAIL h

D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them

meven retitled this revision from "Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding then" to "Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them". REPOSITORY R159 KActivities Statistics REVISION DETA

D23736: Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding then

meven retitled this revision from "Add Term::Type::files() and Term::Type::locations() to filter excluding or only directories" to "Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding then". REPOSITORY R159 KActivities Statistics REVISION DETAIL ht

D23736: Add Term::Type::files() and Term::Type::locations() to filter excluding or only directories

meven updated this revision to Diff 65488. meven added a comment. Rename locations to directories REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23736?vs=65485&id=65488 BRANCH arcpatch-D23736 REVISION DETAIL https://phabricator.kde.org/

D23736: Add Term::Type::files() and Term::Type::locations() to filter excluding or only directories

meven retitled this revision from "Add a Term::Type::files() to filter excluding directories" to "Add Term::Type::files() and Term::Type::locations() to filter excluding or only directories". REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D23736 To: meve

D23736: Add a Term::Type::files() to filter excluding directories

meven updated this revision to Diff 65485. meven added a comment. Add Term::Type::locations REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23736?vs=65446&id=65485 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23736 AFFECTE

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65484. meven added a comment. grammar REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65474&id=65484 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23742 AFFECTED FILES recentlyused/recentl

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65474. meven added a comment. typo REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65473&id=65474 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23742 AFFECTED FILES recentlyused/recentlyus

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65473. meven added a comment. Replace /folders by /locations, add some documentation REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65470&id=65473 BRANCH master REVISION DETAIL https://phabricator.kde.or

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65470. meven added a comment. Add some const REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65467&id=65470 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23742 AFFECTED FILES recentlyused/

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven updated this revision to Diff 65467. meven added a comment. Rephrase 'Recent Folders' to 'Recent Locations' REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23742?vs=65449&id=65467 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2374

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. In D7446#526201 , @ngraham wrote: > Fantastic work. That's exactly what I had in mind and it works perfectly! > > With those, we can have Recent Files and Recent Locations (or maybe Recent Folders) in the Recent section,

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. In D7446#526039 , @meven wrote: > In D7446#526032 , @ngraham wrote: > > > This works great. > > > > one minor concern I have with the new IOSlave in general is how it shows b

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven created this revision. meven added reviewers: ivan, ngraham, Frameworks. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Depends on D23736

D23736: Add a Term::Type::files() to filter excluding directories

meven added a dependent revision: D23742: Add two special cases url recentlyused:/files and recentlyused:/folders. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D23736 To: meven, ivan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

<    6   7   8   9   10   11   12   13   14   15   >