Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

/118452/#comment50037 you are missing a reserve call here - Milian Wolff On Dec. 9, 2014, 10:44 p.m., Frank Reininghaus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118452

Re: Baloo Framework - License Exception

that just the fact that the Baloo library is linking against Xapian is enough to make it GPL. May I ask the question why Baloo should become a framework in the first place? On Windows or Mac, people won't use it anyways, no? Or is it required there for e.g. searches in KMail? Bye -- Milian Wolff m

Re: Baloo Framework - License Exception

On Thursday 18 December 2014 12:43:18 Vishesh Handa wrote: On Wed, Dec 17, 2014 at 2:38 PM, Milian Wolff m...@milianw.de wrote: May I ask the question why Baloo should become a framework in the first place? On Windows or Mac, people won't use it anyways, no? Or is it required

Re: Review Request 122330: Associate *.qmltypes and *.qmlproject files with the text/x-qml mime type

On Feb. 1, 2015, 8:32 p.m., David Faure wrote: -1 for not submitting this upstream for shared-mime-info. I took care of it, it's committed, will be in s-m-i 1.4. Could we add a comment to this file then, telling people to work on upstream smi instead then? - Milian

Re: Review Request 121263: Prevent API abuse of calling setters on temporary objects.

, kate and kdev* builds fine. Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122194: Initialise all member variables

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122194/#review74508 --- Ship it! Ship It! - Milian Wolff On Jan. 21, 2015, 10:19

Re: Review Request 122109: Cache QMetaMethods that are invoked on hot paths.

-metaObject()-indexOfMethod(signature); Q_ASSERT(idx != -1); return object-metaObject()-method(idx); } ... static const QMetaMethod method = findMethod(q, _q_sourceDataChanged(...)); - Milian Wolff On Jan. 17, 2015, 5:22 p.m., Volker

Review Request 122204: Mark results as required.

://git.reviewboard.kde.org/r/122204/diff/ Testing --- Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122204: Mark results as required.

--- On Jan. 22, 2015, 6:34 p.m., Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122204

Re: reviving make uninstall?

On Wednesday 28 January 2015 20:08:41 Alex Merry wrote: On Wednesday 28 January 2015 17:10:41 Milian Wolff wrote: Hello all, why was the uninstall target removed from make files in frameworks? I cannot find any discussion regarding that on the web. As a developer, I find it highly

Re: Supporting MSVC2010 in ktexteditor framework

is still the same on this matter: VS2012 (aka MSVC11). +1 -- Milian Wolff m...@milianw.de http://milianw.de ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122204: Mark results as required.

Diffs - src/klocalizedstring.h 8e8e84926b444150e00c80b3b77766ba16e03e25 Diff: https://git.reviewboard.kde.org/r/122204/diff/ Testing --- Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: [ki18n] src: small qstring optimizations

are bad: See also: http://neugierig.org/software/chromium/notes/2011/08/static-initializers.html -- Milian Wolff m...@milianw.de http://milianw.de ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 122330: Associate *.qmltypes and *.qmlproject files with the text/x-qml mime type

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122330/#review75164 --- Ship it! Ship It! - Milian Wolff On Jan. 31, 2015, 5:48

reviving make uninstall?

? -- Milian Wolff m...@milianw.de http://milianw.de ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122293: Use activate on single click setting from QPlatformTheme rather than duplicating it

, which it does even better than before if I understand you correctly. So +1 from my side, FWIW. - Milian Wolff On Jan. 28, 2015, 5:26 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: OSX/CI: konsole fails to build on branch master

... -- Milian Wolff m...@milianw.de http://milianw.de ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Qt 5 buildability

anyone, and KDE in particular, as fast as possible. Bye -- Milian Wolff m...@milianw.de http://milianw.de ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121946: Do not emit documentUrlChanged during reload.

: ktexteditor Description --- Do not emit documentUrlChanged during reload. Diffs - src/document/katedocument.cpp b33d9170c8f667dbc41335c7d38b774c88109c2a Diff: https://git.reviewboard.kde.org/r/121946/diff/ Testing --- Thanks, Milian Wolff

Re: Review Request 121931: Unbreak KRecursiveFilterProxyModel for Qt 5.5.0+.

://git.reviewboard.kde.org/r/121931/diff/ Testing --- sadly, there are no unit tests for this. but I can use Kate again without crashes and there are no warnings on startup either. Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde

Review Request 121931: Unbreak KRecursiveFilterProxyModel for Qt 5.5.0+.

and there are no warnings on startup either. Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121931: Unbreak KRecursiveFilterProxyModel for Qt 5.5.0+.

: https://git.reviewboard.kde.org/r/121931/diff/ Testing --- sadly, there are no unit tests for this. but I can use Kate again without crashes and there are no warnings on startup either. Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list

Re: Review Request 121931: Unbreak KRecursiveFilterProxyModel for Qt 5.5.0+.

, there are no unit tests for this. but I can use Kate again without crashes and there are no warnings on startup either. Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 121931: Unbreak KRecursiveFilterProxyModel for Qt 5.5.0+.

--- sadly, there are no unit tests for this. but I can use Kate again without crashes and there are no warnings on startup either. Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 121672: Properly convert .desktop files that have an associated servicetype

not listProperties().contains(), similar below - i.e. why the (non const!) temporaries above? - Milian Wolff On Dec. 26, 2014, 5:21 p.m., Alex Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 121922: support stringlists as properties

',' or ';'. but, shouldn't it be only one or the other? isn't the .desktop file specification telling you which one it is? or is this all KDE custom? In KDevelop at least, the format always was foo, bar, Note the extra whitespace, which you are not trimming. - Milian Wolff On Jan. 8, 2015, 3:34 p.m., Marco

Re: Qt 5 buildability

On Friday 09 January 2015 13:48:29 Milian Wolff wrote: On Friday 09 January 2015 22:41:15 Ben Cooksley wrote: On Fri, Jan 9, 2015 at 10:32 PM, Jan Kundrát j...@kde.org wrote: On Thursday, 8 January 2015 22:59:53 CEST, Ben Cooksley wrote: QtWebEngine won't build unless you have nss-devel

Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

: 123479 Diffs - src/lib/io/kdirwatch.cpp a75fae012c59021996b46845db2e97abb5526930 Diff: https://git.reviewboard.kde.org/r/123479/diff/ Testing --- Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

with this: https://paste.kde.org/pmoue241d Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

this into some branch? There are none in kcoreaddons. This patch here should probably be put into a patch release (if we do this for kf5). - Milian Wolff On April 23, 2015, 4:50 p.m., Milian Wolff wrote: --- This is an automatically generated e

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

://git.reviewboard.kde.org/r/123479/diff/ Testing --- I used the test and looked at the output and also ran it against a patched qtbase with this: https://paste.kde.org/pmoue241d Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

like. - Milian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/#review79415 --- On April 23, 2015, 5:19 p.m., Milian Wolff

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

marked as submitted. Review request for KDE Frameworks, David Faure, Marc Mutz, and Volker Krause. Changes --- Submitted with commit ff964c0c42202228348213e7d5c10f5611a9ee54 by Milian Wolff to branch master. Repository: kcoreaddons Description --- The len in inotify_event

Re: Review Request 123567: Add an Arch Linux package search provider

? doesn't make much sense to have it on non-arch systems, no? - Milian Wolff On April 29, 2015, 1:21 p.m., Anthony Vital wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123567

Re: Review Request 123567: Add an Arch Linux package search provider

On April 29, 2015, 1:55 p.m., Milian Wolff wrote: shouldn't something like this be provided by the distribution? doesn't make much sense to have it on non-arch systems, no? Anthony Vital wrote: I don't know but there are search providers for debian and opensuse already. ah ok

Re: Review Request 123654: Improve performance of KFileItem and KDirSortFilterProxyModel

is this check required, i.e. shouldn't the collator code in Qt handle it and do a no-op if nothing changes? - Milian Wolff On May 6, 2015, 2:35 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 123679: Fix build with Qt 5.5

this is destroyed, leading to undefined behavior. - Milian Wolff On May 7, 2015, 11:31 p.m., Jan Kundrát wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123679

Re: Review Request 123679: Fix build with Qt 5.5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123679/#review80082 --- Ship it! Ship It! - Milian Wolff On May 8, 2015, 10:42

Review Request 123852: Optimize: Do not wipe dict cache when copying speller objects.

/ Testing --- Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122487: Reorder member variables to reduce memory usage.

or was this still requiring manual interpretation? - Milian Wolff On Feb. 9, 2015, 5:04 p.m., Volker Krause wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122487

Re: Review Request 123397: Generalize the creation of KPluginLoader-based plugins

is empty or the list of sources is empty? the latter was recently added to kdevplatform afaik. as the initial author of this macro in kdev, a general +1 from my side for upstreaming it and many thanks! - Milian Wolff On April 17, 2015, 12:35 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 123858: Fix memory leak in drags

, then put it into a QScopedPointer - Milian Wolff On May 20, 2015, 12:23 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123858

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

://git.reviewboard.kde.org/r/123857/#comment55298 no need to change the indentation level of all the code if you'd do if (!str) { return; } instead - Milian Wolff On May 19, 2015, 10:11 p.m., David Edmundson wrote

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

there is a unit test. anyone objects to getting it in? - Milian Wolff On May 12, 2015, 6:03 p.m., Kåre Särs wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123341

Re: Review Request 123867: Fix build on OSX clang and replace another abs with std::abs

://git.reviewboard.kde.org/r/123867/#comment55313 shouldn't this be #include cmath - Milian Wolff On May 21, 2015, 5:50 a.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

On May 19, 2015, 3:12 p.m., Vishesh Handa wrote: autotests/test_settings.cpp, line 43 https://git.reviewboard.kde.org/r/123341/diff/4/?file=362129#file362129line43 Minor thing, which is up to you. In this test you're allocating the `Speller` off the heap and having to

How to port KGlobalSettings::fixedFont et. al?

Hey all, as the subject says - how should KGlobalSettings::fixedFont and the like be ported? QFont(monospace)? Thanks -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part. ___ Kde

Re: How to port KGlobalSettings::fixedFont et. al?

be ported? QFont(monospace)? Thanks -- Milian Wolff m...@milianw.de http://milianw.de ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- Milian Wolff m

Review Request 124032: Do not try to complete users and assert when prepend is non-empty.

passes. also kate and the manual kurlrequestertest_gui test don't crash anymore when I insert ~/. into a url requester. Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 124032: Do not try to complete users and assert when prepend is non-empty.

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 36b558dbc9d739d5367366290d034cb05e1e8061 by Milian Wolff to branch master. Repository: kio Description --- BUG: 346920 REVIEW: 124032 Add unit test for user completion when

Re: Review Request 124032: Do not try to complete users and assert when prepend is non-empty.

://git.reviewboard.kde.org/r/124032/#review81277 --- On June 6, 2015, 8:58 p.m., Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https

What environment variable defines where krunner looks for libkdeinit5_$app.so

environment variable do I need to set for KRunner to find it? Thanks -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 124032: Do not try to complete users and assert when prepend is non-empty.

changes due to the QUrl-KUrl porting, you don't *have* to answer this one ;) Milian Wolff wrote: it still works and I also wonder why this has not happened before - I blame the KUrl/QUrl differences here. Who was the expert in that area again to ask? :P Is it OK if I just add a test

Re: Review Request 124032: Do not try to complete users and assert when prepend is non-empty.

d7ae787e6c3d1dba1a168e77cc2d5001b4bed7ef Diff: https://git.reviewboard.kde.org/r/124032/diff/ Testing --- added a unit test, it now passes. also kate and the manual kurlrequestertest_gui test don't crash anymore when I insert ~/. into a url requester. Thanks, Milian Wolff

Re: What environment variable defines where krunner looks for libkdeinit5_$app.so

On Saturday 06 June 2015 23:31:52 David Faure wrote: On Saturday 06 June 2015 23:18:51 Milian Wolff wrote: Hey all, I try to configure my KF5 plasma environment similar to my old KDE4 plasma. There, I could open even applications build into my custom prefix via krunner. I think

Re: Review Request 123930: Reduce temporary allocations.

marked as submitted. Review request for KDE Frameworks, David Faure, Laurent Montel, Martin Tobias Holmedahl Sandsmark, and Kåre Särs. Changes --- Submitted with commit 779a676d46567df4db29445e689ff9ddb6368616 by Milian Wolff to branch master. Repository: sonnet Description

Review Request 123930: WIP: Make the speller dict cache static.

anyways. Diffs - src/core/speller.cpp dcf98eccb2d82642dc2efe0145ad7ba9a814505f Diff: https://git.reviewboard.kde.org/r/123930/diff/ Testing --- ran katepart again - much quicker now, even with auto-language-detection enabled! unit test still work as well. Thanks, Milian Wolff

Re: Review Request 123930: Reduce temporary allocations.

://git.reviewboard.kde.org/r/123930/#review80953 --- On May 30, 2015, 5:13 p.m., Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 123930: Reduce temporary allocations.

/speller.cpp dcf98eccb2d82642dc2efe0145ad7ba9a814505f Diff: https://git.reviewboard.kde.org/r/123930/diff/ Testing --- ran katepart again - much quicker now, even with auto-language-detection enabled! unit test still work as well. Thanks, Milian Wolff

Re: Review Request 123924: Optimize KIconEngine::availableSizes()

://git.reviewboard.kde.org/r/123924/#comment55450 in KF6, this should also not use QList, but QVector instead. on 32bit platforms, a QListQSize is pretty damn slow - Milian Wolff On May 28, 2015, 2:41 p.m., Aleix Pol Gonzalez wrote

Re: QPA plugin like functionality in frameworks?

by using static QMetaMethod and invoking them). And, probably more important, there is no compile-time check that the invoked methods are available in the implementation side. Bye -- Milian Wolff m...@milianw.de http://milianw.de ___ Kde-frameworks-devel

Re: Review Request 124222: kidletime: Introduce plugin infrastructure for platform specific parts

to deduplicate the data - it won't do that for lambdas and thus QStringLiteral. - Milian Wolff On July 2, 2015, 12:14 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 124239: Fix KMimeType::Ptr::isNull implementation.

://git.reviewboard.kde.org/r/124239/diff/ Testing --- Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 124239: Fix KMimeType::Ptr::isNull implementation.

c7db1cb64ec5470a5590b783d46fc97d1d2e89d8 src/kdecore/kmimetype.h 93bbddc8d9be8f8b6bdb3003dfbe9558d24aff9b Diff: https://git.reviewboard.kde.org/r/124239/diff/ Testing --- Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 124239: Fix KMimeType::Ptr::isNull implementation.

marked as submitted. Review request for KDE Frameworks, David Faure and Laurent Montel. Changes --- Submitted with commit 7ebe1d32c4704e8048dfb2579dd4f5fa2ba9dce1 by Milian Wolff to branch master. Repository: kdelibs4support Description --- The pointer is null if the contained data

Re: Review Request 123852: Optimize: Do not wipe dict cache when copying speller objects.

marked as submitted. Review request for KDE Frameworks, Laurent Montel, Martin Tobias Holmedahl Sandsmark, and Kåre Särs. Changes --- Submitted with commit 1334cdcbce2f355455faf0bf9693881462c20416 by Milian Wolff to branch master. Repository: sonnet Description --- This removes

Re: Review Request 124772: kservice: fix almost all clang warnings

) https://git.reviewboard.kde.org/r/124772/#comment58146 QStringLiteral - Milian Wolff On Aug. 16, 2015, 12:39 p.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: ksycoca improvements (Re: assert in kservicetypefactory.cpp)

On Monday, August 24, 2015 2:48:14 PM CEST David Faure wrote: On Monday 24 August 2015 13:04:24 Milian Wolff wrote: [QK]LockFile was too unreliable on linux That sounds like judging QLockFile based on how badly KLockFile worked :) IOW, it doesn't sound like you actually tried Qt5's

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124902/#review84290 --- Ship it! Ship It! - Milian Wolff On Aug. 24, 2015, 12:59

Re: ksycoca improvements (Re: assert in kservicetypefactory.cpp)

-session feature. [QK]LockFile was too unreliable on linux, DBus is trivial and magically works. It could be removed for Windows if it's a big issue and we find a good alternative. Bye -- Milian Wolff m...@milianw.de http://milianw.de ___ Kde-frameworks

Re: Review Request 124896: Fix bad behavior / running OOM on Windows

that allocator put values in there that overflowed? anyhow, lgtm if it fixes the warnings alone - Milian Wolff On Aug. 24, 2015, 8:27 a.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 124811: KIconLoader: speed up hasIcon/iconPath by using the on-disk cache from loadIcon

that kiconthemes_unittests_searchOnDisk is leaked :-/ nothing we can do about it, I assume? - Milian Wolff On Aug. 20, 2015, 8:07 a.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124811

Re: Review Request 124505: Add API to use QIcon for KMultiTabBar to avoid problems with wrong sized QPixmaps on HiDPI screens

://git.reviewboard.kde.org/r/124505/#comment57434 move up? - Milian Wolff On July 30, 2015, 11:11 a.m., Christoph Cullmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124505

Re: Does frameworks allow move semantics unconditionally?

clang started to support these things. For clang, check http://clang.llvm.org/cxx_status.html - RValue references got supported in 2.9. Cheers -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part

Re: Review Request 124557: Fix method behavior KShortcutsEditorPrivate::importConfiguration

://git.reviewboard.kde.org/r/124557/#comment57478 should this variable and the one above be renamed to actionId then? - Milian Wolff On July 31, 2015, 3:37 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail

Review Request 124435: Remove temporary string allocations.

: kiconthemes Description --- This removes approx. 5000 temporary allocations when starting up kwrite. Found using heaptrack. Diffs - src/kicontheme.cpp 652f3c7d9fae7a4ba6c174d112c97122cf7e7d44 Diff: https://git.reviewboard.kde.org/r/124435/diff/ Testing --- Thanks, Milian Wolff

Re: Review Request 124435: Remove temporary string allocations.

Diff: https://git.reviewboard.kde.org/r/124435/diff/ Testing --- Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124607: KService: detect ksycoca changing on disk without relying on the DBus signal.

://git.reviewboard.kde.org/r/124607/#comment57672 what about putting these calls into `KServiceGroupFactory::self()`? It seems to me that this would reduce the size of this patch considerable and makes sure it always works? - Milian Wolff On Aug. 5, 2015, 8:09 a.m., David Faure wrote

Re: Review Request 124696: Fix (worrying) MSVC warning

://git.reviewboard.kde.org/r/124696/#comment57929 while at it: make static or wrap in anonymous namespace (in a separate commit?) - Milian Wolff On Aug. 11, 2015, 11 a.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

(factor of 2). src/kextracolumnsproxymodel.cpp (line 85) https://git.reviewboard.kde.org/r/124331/#comment56909 here and elsewhere: why not use the newstyle connect syntax? - Milian Wolff On July 14, 2015, 10:42 a.m., David Faure wrote

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

here?), I stopped using private signals and instead do something like connect(foo, Foo::bar, this, [this] (...) { d-onBar(...); }); I quite like that, as it does not leak anything to the public header at all. - Milian Wolff On July 15, 2015, 8:59 a.m

Re: Review Request 126002: Fix KArchive for behavior change in Qt 5.6

... src/ktar.cpp (line 292) <https://git.reviewboard.kde.org/r/126002/#comment60474> I agree with Nick, here and below it could be QByteArray::fromRawData. But that's an optimization and we could get this in first as a fix and optimize later on. - Milian Wolff On Nov. 9, 2015, 7:

Re: Review Request 125924: KJob::kill(Quiet) should also exit the event loop

(line 644) <https://git.reviewboard.kde.org/r/125924/#comment60319> move this into KJobPrivate, no? - Milian Wolff On Nov. 2, 2015, 7:31 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e

Re: Review Request 125971: k7zip: fix memleaks, lower memory usage

> On Nov. 6, 2015, 12:25 p.m., Milian Wolff wrote: > > I'd remove the code, instead of just commenting it out if it's really not > > needed. > > > > Also, minor nitpick: QList<T*> is pretty much equivalent to QVector<T*>, > > you won't see a

Re: Review Request 125971: k7zip: fix memleaks, lower memory usage

d maybe wait for a review of David before pushing this. I have no clue about the code itself. The patch looks fine from my POV though. src/k7zip.cpp (line 2644) <https://git.reviewboard.kde.org/r/125971/#comment60438> this looks odd, either remove it or not, but don't just comment out t

Re: Review Request 125615: Make phonon dependency optional

side! - Milian Wolff On Oct. 12, 2015, 8:04 p.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125612: Make doctools optional

. - Milian Wolff On Oct. 12, 2015, 8:10 p.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125598: Allow KConfig to use resources as fallback config files

#comment59690> is prepending it really a fallback? - Milian Wolff On Oct. 12, 2015, 12:55 p.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.

Re: Review Request 124304: Reduce the KDBusService timeout from 5 minutes to 25 seconds

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124304/#review82275 --- also +1 from my side - Milian Wolff On July 9, 2015, 11:48

Re: Review Request 124282: Implement Voikko based spellchecker for Sonnet

/r/124282/#comment56675 same as above, with the placement of the : - Milian Wolff On July 9, 2015, 10:41 p.m., Jesse Jaara wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 124282: Implement Voikko based spellchecker for Sonnet

(...)) { src/plugins/voikko/voikkodict.cpp (line 219) https://git.reviewboard.kde.org/r/124282/#comment56638 join next line - Milian Wolff On July 8, 2015, 5:10 p.m., Jesse Jaara wrote: --- This is an automatically generated e-mail

Re: Review Request 125106: Minor optimizations

onfig_compiler.cpp (line 506) <https://git.reviewboard.kde.org/r/125106/#comment58805> ost of the concatenations below should also use QLatin1String. are we enabling QStringBuilder for this repo btw? - Milian Wolff On Sept. 8

Re: Review Request 125106: Minor optimizations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125106/#review86288 --- Ship it! Ship It! - Milian Wolff On Sept. 11, 2015, 11:56

Re: Review Request 125106: Minor optimizations

> On Oct. 3, 2015, 12:28 a.m., Matthew Dawson wrote: > > src/core/kdesktopfile.cpp, line 307 > > > > > > Since this gets converted to a QString immediately, should this not be > > a QStringLiteral? There

Re: Review Request 125504: KServiceTypeProfile: remove unnecessary factory creation, to fix a deadlock

notify you when I can reproduce this after this gets merged. - Milian Wolff On Oct. 4, 2015, 9:40 a.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: RFC: Enabling -DECM_ENABLE_SANITIZERS='address' in jenkins

combined with ASan and should thus find even more issues in our codebase! Bye -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126039: When configfile is loaded from resource, do not issue file not found error

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126039/#review89263 --- Ship it! Ship It! - Milian Wolff On Nov. 12, 2015, 11:15

Re: Review Request 126087: Move the i18n context from KDeclarative

7/#comment60822> virtual src/klocalizedcontext.h (line 132) <https://git.reviewboard.kde.org/r/126087/#comment60823> are we sure we'll never add anything else? i.e. is pimpling a safer choice? - Milian Wolff On Nov. 20, 2015, 2:03 p.m.,

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

don't want that, change it via systemsettings - Milian Wolff On May 31, 2016, 8:48 a.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128018: Add donate menu item to help menu of our apps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128018/#review95924 --- Ship it! Ship It! - Milian Wolff On May 25, 2016, 10

<    1   2   3   4   5   >